All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] perf: remove unused pointer task_ctx
@ 2022-10-28 12:25 Colin Ian King
  2022-11-16  9:14 ` [tip: perf/core] perf: Remove " tip-bot2 for Colin Ian King
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-10-28 12:25 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
	linux-perf-users
  Cc: kernel-janitors, linux-kernel

The pointer task_ctx is being assigned a value that is not read, the
assignment is redundant and so is the pointer. Remove it

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 kernel/events/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index ebd9ebd53238..e7c0df152c8f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4215,7 +4215,6 @@ static bool perf_rotate_context(struct perf_cpu_pmu_context *cpc)
 	struct perf_cpu_context *cpuctx = this_cpu_ptr(&cpu_context);
 	struct perf_event_pmu_context *cpu_epc, *task_epc = NULL;
 	struct perf_event *cpu_event = NULL, *task_event = NULL;
-	struct perf_event_context *task_ctx = NULL;
 	int cpu_rotate, task_rotate;
 	struct pmu *pmu;
 
@@ -4229,7 +4228,6 @@ static bool perf_rotate_context(struct perf_cpu_pmu_context *cpc)
 	task_epc = cpc->task_epc;
 
 	cpu_rotate = cpu_epc->rotate_necessary;
-	task_ctx = cpuctx->task_ctx;
 	task_rotate = task_epc ? task_epc->rotate_necessary : 0;
 
 	if (!(cpu_rotate || task_rotate))
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip: perf/core] perf: Remove unused pointer task_ctx
  2022-10-28 12:25 [PATCH][next] perf: remove unused pointer task_ctx Colin Ian King
@ 2022-11-16  9:14 ` tip-bot2 for Colin Ian King
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Colin Ian King @ 2022-11-16  9:14 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Colin Ian King, Peter Zijlstra (Intel), x86, linux-kernel

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     3ce1cb7eee70335b6d4f50fadec264473e9566c3
Gitweb:        https://git.kernel.org/tip/3ce1cb7eee70335b6d4f50fadec264473e9566c3
Author:        Colin Ian King <colin.i.king@gmail.com>
AuthorDate:    Fri, 28 Oct 2022 13:25:45 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 15 Nov 2022 22:30:11 +01:00

perf: Remove unused pointer task_ctx

The pointer task_ctx is being assigned a value that is not read, the
assignment is redundant and so is the pointer. Remove it

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221028122545.528999-1-colin.i.king@gmail.com
---
 kernel/events/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index ec2abc5..baa2997 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4215,7 +4215,6 @@ static bool perf_rotate_context(struct perf_cpu_pmu_context *cpc)
 	struct perf_cpu_context *cpuctx = this_cpu_ptr(&perf_cpu_context);
 	struct perf_event_pmu_context *cpu_epc, *task_epc = NULL;
 	struct perf_event *cpu_event = NULL, *task_event = NULL;
-	struct perf_event_context *task_ctx = NULL;
 	int cpu_rotate, task_rotate;
 	struct pmu *pmu;
 
@@ -4229,7 +4228,6 @@ static bool perf_rotate_context(struct perf_cpu_pmu_context *cpc)
 	task_epc = cpc->task_epc;
 
 	cpu_rotate = cpu_epc->rotate_necessary;
-	task_ctx = cpuctx->task_ctx;
 	task_rotate = task_epc ? task_epc->rotate_necessary : 0;
 
 	if (!(cpu_rotate || task_rotate))

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-16  9:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-28 12:25 [PATCH][next] perf: remove unused pointer task_ctx Colin Ian King
2022-11-16  9:14 ` [tip: perf/core] perf: Remove " tip-bot2 for Colin Ian King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.