* [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling @ 2022-11-17 23:00 Anusha Srivatsa 2022-11-17 23:00 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk Anusha Srivatsa ` (8 more replies) 0 siblings, 9 replies; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-17 23:00 UTC (permalink / raw) To: intel-gfx cdclk_sanitize() function was written assuming vco was a signed integer. vco gets assigned to -1 (essentially ~0) for the case where PLL might be enabled and vco is not a frequency that will ever get used. In such a scenario the right thing to do is disable the PLL and re-enable it again with a valid frequency. However the vco is declared as a unsigned variable. With the above assumption, driver takes crawl path when not needed. Add explicit check to not crawl in the case of an invalid PLL. v2: Move the check from .h to .c (MattR) - Move check to bxt_set_cdclk() instead of intel_modeset_calc_cdclk() which is directly in the path of the sanitize() function (Ville) v3: remove unwanted parenthesis(Ville) Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index b74e36d76013..25d01271dc09 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1717,6 +1717,16 @@ static void dg2_cdclk_squash_program(struct drm_i915_private *i915, intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl); } +static bool cdclk_pll_is_unknown(unsigned int vco) +{ + /* + * Ensure driver does not take the crawl path for the + * case when the vco is set to ~0 in the + * sanitize path. + */ + return vco == ~0; +} + static void bxt_set_cdclk(struct drm_i915_private *dev_priv, const struct intel_cdclk_config *cdclk_config, enum pipe pipe) @@ -1749,7 +1759,8 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, return; } - if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0) { + if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && + !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { if (dev_priv->display.cdclk.hw.vco != vco) adlp_cdclk_pll_crawl(dev_priv, vco); } else if (DISPLAY_VER(dev_priv) >= 11) -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa @ 2022-11-17 23:00 ` Anusha Srivatsa 2022-11-18 0:53 ` Matt Roper 2022-11-17 23:00 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: Add CDCLK Support for MTL Anusha Srivatsa ` (7 subsequent siblings) 8 siblings, 1 reply; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-17 23:00 UTC (permalink / raw) To: intel-gfx; +Cc: Balasubramani Vivekanandan From: Ville Syrjälä <ville.syrjala@linux.intel.com> For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk Driver should not take some Pcode mailbox communication in the cdclk path for platforms that are Display version 14 and later. v2: Add check in intel_modeset_calc_cdclk() to avoid cdclk change via modeset for platforms that support squash_crawl sequences(Ville) v3: Add checks for: - scenario where only slow clock is used and cdclk is actually 0 (bringing up display). - PLLs are on before looking up the waveform. - Squash and crawl capability checks.(Ville) v4: Rebase - Move checks to be more consistent (Ville) - Add comments (Bala) v5: - Further small changes. Move checks around. - Make if-else better looking (Ville) v6: MTl should not follow PUnit mailbox communication as the rest of gen11+ platforms.(Anusha) Cc: Clint Taylor <Clinton.A.Taylor@intel.com> Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 181 +++++++++++++++++---- 1 file changed, 150 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 25d01271dc09..1280a08b9c72 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1727,37 +1727,79 @@ static bool cdclk_pll_is_unknown(unsigned int vco) return vco == ~0; } -static void bxt_set_cdclk(struct drm_i915_private *dev_priv, - const struct intel_cdclk_config *cdclk_config, - enum pipe pipe) +static int cdclk_squash_divider(u16 waveform) +{ + return hweight16(waveform ?: 0xffff); +} + +static bool cdclk_compute_crawl_and_squash_midpoint(struct drm_i915_private *i915, + const struct intel_cdclk_config *old_cdclk_config, + const struct intel_cdclk_config *new_cdclk_config, + struct intel_cdclk_config *mid_cdclk_config) +{ + u16 old_waveform, new_waveform, mid_waveform; + int size = 16; + int div = 2; + + /* Return for vco ~0 (-1) and follow complete PLL disable and enable */ + if (cdclk_pll_is_unknown(old_cdclk_config->vco)) + return false; + + /* Return if both Squash and Crawl are not present */ + if (!HAS_CDCLK_CRAWL(i915) || !HAS_CDCLK_SQUASH(i915)) + return false; + + old_waveform = cdclk_squash_waveform(i915, old_cdclk_config->cdclk); + new_waveform = cdclk_squash_waveform(i915, new_cdclk_config->cdclk); + + /* Return if Squash only or Crawl only is the desired action */ + if (old_cdclk_config->vco == 0 || new_cdclk_config->vco == 0 || + old_cdclk_config->vco == new_cdclk_config->vco || + old_waveform == new_waveform) + return false; + + *mid_cdclk_config = *new_cdclk_config; + + /* + * Populate the mid_cdclk_config accordingly. + * - If moving to a higher cdclk, the desired action is squashing. + * The mid cdclk config should have the new (squash) waveform. + * - If moving to a lower cdclk, the desired action is crawling. + * The mid cdclk config should have the new vco. + */ + + if (cdclk_squash_divider(new_waveform) > cdclk_squash_divider(old_waveform)) { + mid_cdclk_config->vco = old_cdclk_config->vco; + mid_waveform = new_waveform; + } else { + mid_cdclk_config->vco = new_cdclk_config->vco; + mid_waveform = old_waveform; + } + + mid_cdclk_config->cdclk = DIV_ROUND_CLOSEST(cdclk_squash_divider(mid_waveform) * + mid_cdclk_config->vco, size * div); + + /* make sure the mid clock came out sane */ + + drm_WARN_ON(&i915->drm, mid_cdclk_config->cdclk < + min(old_cdclk_config->cdclk, new_cdclk_config->cdclk)); + drm_WARN_ON(&i915->drm, mid_cdclk_config->cdclk > + i915->display.cdclk.max_cdclk_freq); + drm_WARN_ON(&i915->drm, cdclk_squash_waveform(i915, mid_cdclk_config->cdclk) != + mid_waveform); + + return true; +} + +static void _bxt_set_cdclk(struct drm_i915_private *dev_priv, + const struct intel_cdclk_config *cdclk_config, + enum pipe pipe) { int cdclk = cdclk_config->cdclk; int vco = cdclk_config->vco; u32 val; u16 waveform; int clock; - int ret; - - /* Inform power controller of upcoming frequency change. */ - if (DISPLAY_VER(dev_priv) >= 11) - ret = skl_pcode_request(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, - SKL_CDCLK_PREPARE_FOR_CHANGE, - SKL_CDCLK_READY_FOR_CHANGE, - SKL_CDCLK_READY_FOR_CHANGE, 3); - else - /* - * BSpec requires us to wait up to 150usec, but that leads to - * timeouts; the 2ms used here is based on experiment. - */ - ret = snb_pcode_write_timeout(&dev_priv->uncore, - HSW_PCODE_DE_WRITE_FREQ_REQ, - 0x80000000, 150, 2); - if (ret) { - drm_err(&dev_priv->drm, - "Failed to inform PCU about cdclk change (err %d, freq %d)\n", - ret, cdclk); - return; - } if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { @@ -1793,11 +1835,62 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, if (pipe != INVALID_PIPE) intel_crtc_wait_for_next_vblank(intel_crtc_for_pipe(dev_priv, pipe)); +} + +static void bxt_set_cdclk(struct drm_i915_private *dev_priv, + const struct intel_cdclk_config *cdclk_config, + enum pipe pipe) +{ + struct intel_cdclk_config mid_cdclk_config; + int cdclk = cdclk_config->cdclk; + int ret = 0; + + /* + * Inform power controller of upcoming frequency change. + * Display versions 14 and beyond do not follow the PUnit + * mailbox communication, skip + * this step. + */ + if (DISPLAY_VER(dev_priv) >= 14) + /* NOOP */; + else if (DISPLAY_VER(dev_priv) >= 11) + ret = skl_pcode_request(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, + SKL_CDCLK_PREPARE_FOR_CHANGE, + SKL_CDCLK_READY_FOR_CHANGE, + SKL_CDCLK_READY_FOR_CHANGE, 3); + else + /* + * BSpec requires us to wait up to 150usec, but that leads to + * timeouts; the 2ms used here is based on experiment. + */ + ret = snb_pcode_write_timeout(&dev_priv->uncore, + HSW_PCODE_DE_WRITE_FREQ_REQ, + 0x80000000, 150, 2); + + if (ret) { + drm_err(&dev_priv->drm, + "Failed to inform PCU about cdclk change (err %d, freq %d)\n", + ret, cdclk); + return; + } - if (DISPLAY_VER(dev_priv) >= 11) { + if (cdclk_compute_crawl_and_squash_midpoint(dev_priv, &dev_priv->display.cdclk.hw, + cdclk_config, &mid_cdclk_config)) { + _bxt_set_cdclk(dev_priv, &mid_cdclk_config, pipe); + _bxt_set_cdclk(dev_priv, cdclk_config, pipe); + } else { + _bxt_set_cdclk(dev_priv, cdclk_config, pipe); + } + + if (DISPLAY_VER(dev_priv) >= 14) + /* + * NOOP - No Pcode communication needed for + * Display versions 14 and beyond + */; + else if (DISPLAY_VER(dev_priv) >= 11) ret = snb_pcode_write(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, cdclk_config->voltage_level); - } else { + else /* * The timeout isn't specified, the 2ms used here is based on * experiment. @@ -1808,7 +1901,6 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, HSW_PCODE_DE_WRITE_FREQ_REQ, cdclk_config->voltage_level, 150, 2); - } if (ret) { drm_err(&dev_priv->drm, @@ -1965,6 +2057,28 @@ void intel_cdclk_uninit_hw(struct drm_i915_private *i915) skl_cdclk_uninit_hw(i915); } +static bool intel_cdclk_can_crawl_and_squash(struct drm_i915_private *i915, + const struct intel_cdclk_config *a, + const struct intel_cdclk_config *b) +{ + u16 old_waveform; + u16 new_waveform; + + drm_WARN_ON(&i915->drm, cdclk_pll_is_unknown(a->vco)); + + if (a->vco == 0 || b->vco == 0) + return false; + + if (!HAS_CDCLK_CRAWL(i915) || !HAS_CDCLK_SQUASH(i915)) + return false; + + old_waveform = cdclk_squash_waveform(i915, a->cdclk); + new_waveform = cdclk_squash_waveform(i915, b->cdclk); + + return a->vco != b->vco && + old_waveform != new_waveform; +} + static bool intel_cdclk_can_crawl(struct drm_i915_private *dev_priv, const struct intel_cdclk_config *a, const struct intel_cdclk_config *b) @@ -2771,9 +2885,14 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state) pipe = INVALID_PIPE; } - if (intel_cdclk_can_squash(dev_priv, - &old_cdclk_state->actual, - &new_cdclk_state->actual)) { + if (intel_cdclk_can_crawl_and_squash(dev_priv, + &old_cdclk_state->actual, + &new_cdclk_state->actual)) { + drm_dbg_kms(&dev_priv->drm, + "Can change cdclk via crawling and squashing\n"); + } else if (intel_cdclk_can_squash(dev_priv, + &old_cdclk_state->actual, + &new_cdclk_state->actual)) { drm_dbg_kms(&dev_priv->drm, "Can change cdclk via squashing\n"); } else if (intel_cdclk_can_crawl(dev_priv, -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk 2022-11-17 23:00 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk Anusha Srivatsa @ 2022-11-18 0:53 ` Matt Roper 0 siblings, 0 replies; 14+ messages in thread From: Matt Roper @ 2022-11-18 0:53 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx, Balasubramani Vivekanandan On Thu, Nov 17, 2022 at 03:00:01PM -0800, Anusha Srivatsa wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construtc a mid cdclk config. s/construtc/construct/ > Set the cdclk twice: > - Current cdclk -> mid cdclk > - mid cdclk -> desired cdclk > > Driver should not take some Pcode mailbox communication > in the cdclk path for platforms that are Display version 14 and later. > > v2: Add check in intel_modeset_calc_cdclk() to avoid cdclk > change via modeset for platforms that support squash_crawl sequences(Ville) > > v3: Add checks for: > - scenario where only slow clock is used and > cdclk is actually 0 (bringing up display). > - PLLs are on before looking up the waveform. > - Squash and crawl capability checks.(Ville) > > v4: Rebase > - Move checks to be more consistent (Ville) > - Add comments (Bala) > v5: > - Further small changes. Move checks around. > - Make if-else better looking (Ville) > > v6: MTl should not follow PUnit mailbox communication as the rest of > gen11+ platforms.(Anusha) > > Cc: Clint Taylor <Clinton.A.Taylor@intel.com> > Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 181 +++++++++++++++++---- > 1 file changed, 150 insertions(+), 31 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 25d01271dc09..1280a08b9c72 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -1727,37 +1727,79 @@ static bool cdclk_pll_is_unknown(unsigned int vco) > return vco == ~0; > } > > -static void bxt_set_cdclk(struct drm_i915_private *dev_priv, > - const struct intel_cdclk_config *cdclk_config, > - enum pipe pipe) > +static int cdclk_squash_divider(u16 waveform) > +{ > + return hweight16(waveform ?: 0xffff); > +} > + > +static bool cdclk_compute_crawl_and_squash_midpoint(struct drm_i915_private *i915, > + const struct intel_cdclk_config *old_cdclk_config, > + const struct intel_cdclk_config *new_cdclk_config, > + struct intel_cdclk_config *mid_cdclk_config) > +{ > + u16 old_waveform, new_waveform, mid_waveform; > + int size = 16; > + int div = 2; > + > + /* Return for vco ~0 (-1) and follow complete PLL disable and enable */ I don't think the mention of ~0 / -1 here is helpful; we added the helper function to hide those low-level implementation details. Just say something high-level about what you're actually trying to do like "If the PLL is in an unknown state, force a complete disable and re-enable." Aside from that (and the typo in the commit message), Reviewed-by: Matt Roper <matthew.d.roper@intel.com> > + if (cdclk_pll_is_unknown(old_cdclk_config->vco)) > + return false; > + > + /* Return if both Squash and Crawl are not present */ > + if (!HAS_CDCLK_CRAWL(i915) || !HAS_CDCLK_SQUASH(i915)) > + return false; > + > + old_waveform = cdclk_squash_waveform(i915, old_cdclk_config->cdclk); > + new_waveform = cdclk_squash_waveform(i915, new_cdclk_config->cdclk); > + > + /* Return if Squash only or Crawl only is the desired action */ > + if (old_cdclk_config->vco == 0 || new_cdclk_config->vco == 0 || > + old_cdclk_config->vco == new_cdclk_config->vco || > + old_waveform == new_waveform) > + return false; > + > + *mid_cdclk_config = *new_cdclk_config; > + > + /* > + * Populate the mid_cdclk_config accordingly. > + * - If moving to a higher cdclk, the desired action is squashing. > + * The mid cdclk config should have the new (squash) waveform. > + * - If moving to a lower cdclk, the desired action is crawling. > + * The mid cdclk config should have the new vco. > + */ > + > + if (cdclk_squash_divider(new_waveform) > cdclk_squash_divider(old_waveform)) { > + mid_cdclk_config->vco = old_cdclk_config->vco; > + mid_waveform = new_waveform; > + } else { > + mid_cdclk_config->vco = new_cdclk_config->vco; > + mid_waveform = old_waveform; > + } > + > + mid_cdclk_config->cdclk = DIV_ROUND_CLOSEST(cdclk_squash_divider(mid_waveform) * > + mid_cdclk_config->vco, size * div); > + > + /* make sure the mid clock came out sane */ > + > + drm_WARN_ON(&i915->drm, mid_cdclk_config->cdclk < > + min(old_cdclk_config->cdclk, new_cdclk_config->cdclk)); > + drm_WARN_ON(&i915->drm, mid_cdclk_config->cdclk > > + i915->display.cdclk.max_cdclk_freq); > + drm_WARN_ON(&i915->drm, cdclk_squash_waveform(i915, mid_cdclk_config->cdclk) != > + mid_waveform); > + > + return true; > +} > + > +static void _bxt_set_cdclk(struct drm_i915_private *dev_priv, > + const struct intel_cdclk_config *cdclk_config, > + enum pipe pipe) > { > int cdclk = cdclk_config->cdclk; > int vco = cdclk_config->vco; > u32 val; > u16 waveform; > int clock; > - int ret; > - > - /* Inform power controller of upcoming frequency change. */ > - if (DISPLAY_VER(dev_priv) >= 11) > - ret = skl_pcode_request(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, > - SKL_CDCLK_PREPARE_FOR_CHANGE, > - SKL_CDCLK_READY_FOR_CHANGE, > - SKL_CDCLK_READY_FOR_CHANGE, 3); > - else > - /* > - * BSpec requires us to wait up to 150usec, but that leads to > - * timeouts; the 2ms used here is based on experiment. > - */ > - ret = snb_pcode_write_timeout(&dev_priv->uncore, > - HSW_PCODE_DE_WRITE_FREQ_REQ, > - 0x80000000, 150, 2); > - if (ret) { > - drm_err(&dev_priv->drm, > - "Failed to inform PCU about cdclk change (err %d, freq %d)\n", > - ret, cdclk); > - return; > - } > > if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && > !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { > @@ -1793,11 +1835,62 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, > > if (pipe != INVALID_PIPE) > intel_crtc_wait_for_next_vblank(intel_crtc_for_pipe(dev_priv, pipe)); > +} > + > +static void bxt_set_cdclk(struct drm_i915_private *dev_priv, > + const struct intel_cdclk_config *cdclk_config, > + enum pipe pipe) > +{ > + struct intel_cdclk_config mid_cdclk_config; > + int cdclk = cdclk_config->cdclk; > + int ret = 0; > + > + /* > + * Inform power controller of upcoming frequency change. > + * Display versions 14 and beyond do not follow the PUnit > + * mailbox communication, skip > + * this step. > + */ > + if (DISPLAY_VER(dev_priv) >= 14) > + /* NOOP */; > + else if (DISPLAY_VER(dev_priv) >= 11) > + ret = skl_pcode_request(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, > + SKL_CDCLK_PREPARE_FOR_CHANGE, > + SKL_CDCLK_READY_FOR_CHANGE, > + SKL_CDCLK_READY_FOR_CHANGE, 3); > + else > + /* > + * BSpec requires us to wait up to 150usec, but that leads to > + * timeouts; the 2ms used here is based on experiment. > + */ > + ret = snb_pcode_write_timeout(&dev_priv->uncore, > + HSW_PCODE_DE_WRITE_FREQ_REQ, > + 0x80000000, 150, 2); > + > + if (ret) { > + drm_err(&dev_priv->drm, > + "Failed to inform PCU about cdclk change (err %d, freq %d)\n", > + ret, cdclk); > + return; > + } > > - if (DISPLAY_VER(dev_priv) >= 11) { > + if (cdclk_compute_crawl_and_squash_midpoint(dev_priv, &dev_priv->display.cdclk.hw, > + cdclk_config, &mid_cdclk_config)) { > + _bxt_set_cdclk(dev_priv, &mid_cdclk_config, pipe); > + _bxt_set_cdclk(dev_priv, cdclk_config, pipe); > + } else { > + _bxt_set_cdclk(dev_priv, cdclk_config, pipe); > + } > + > + if (DISPLAY_VER(dev_priv) >= 14) > + /* > + * NOOP - No Pcode communication needed for > + * Display versions 14 and beyond > + */; > + else if (DISPLAY_VER(dev_priv) >= 11) > ret = snb_pcode_write(&dev_priv->uncore, SKL_PCODE_CDCLK_CONTROL, > cdclk_config->voltage_level); > - } else { > + else > /* > * The timeout isn't specified, the 2ms used here is based on > * experiment. > @@ -1808,7 +1901,6 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, > HSW_PCODE_DE_WRITE_FREQ_REQ, > cdclk_config->voltage_level, > 150, 2); > - } > > if (ret) { > drm_err(&dev_priv->drm, > @@ -1965,6 +2057,28 @@ void intel_cdclk_uninit_hw(struct drm_i915_private *i915) > skl_cdclk_uninit_hw(i915); > } > > +static bool intel_cdclk_can_crawl_and_squash(struct drm_i915_private *i915, > + const struct intel_cdclk_config *a, > + const struct intel_cdclk_config *b) > +{ > + u16 old_waveform; > + u16 new_waveform; > + > + drm_WARN_ON(&i915->drm, cdclk_pll_is_unknown(a->vco)); > + > + if (a->vco == 0 || b->vco == 0) > + return false; > + > + if (!HAS_CDCLK_CRAWL(i915) || !HAS_CDCLK_SQUASH(i915)) > + return false; > + > + old_waveform = cdclk_squash_waveform(i915, a->cdclk); > + new_waveform = cdclk_squash_waveform(i915, b->cdclk); > + > + return a->vco != b->vco && > + old_waveform != new_waveform; > +} > + > static bool intel_cdclk_can_crawl(struct drm_i915_private *dev_priv, > const struct intel_cdclk_config *a, > const struct intel_cdclk_config *b) > @@ -2771,9 +2885,14 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state) > pipe = INVALID_PIPE; > } > > - if (intel_cdclk_can_squash(dev_priv, > - &old_cdclk_state->actual, > - &new_cdclk_state->actual)) { > + if (intel_cdclk_can_crawl_and_squash(dev_priv, > + &old_cdclk_state->actual, > + &new_cdclk_state->actual)) { > + drm_dbg_kms(&dev_priv->drm, > + "Can change cdclk via crawling and squashing\n"); > + } else if (intel_cdclk_can_squash(dev_priv, > + &old_cdclk_state->actual, > + &new_cdclk_state->actual)) { > drm_dbg_kms(&dev_priv->drm, > "Can change cdclk via squashing\n"); > } else if (intel_cdclk_can_crawl(dev_priv, > -- > 2.25.1 > -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/display: Add CDCLK Support for MTL 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa 2022-11-17 23:00 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk Anusha Srivatsa @ 2022-11-17 23:00 ` Anusha Srivatsa 2022-11-17 23:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling Patchwork ` (6 subsequent siblings) 8 siblings, 0 replies; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-17 23:00 UTC (permalink / raw) To: intel-gfx As per bSpec MTL has 38.4 MHz Reference clock. Adding the cdclk tables and cdclk_funcs that MTL will use. v2: Revert to using bxt_get_cdclk() BSpec: 65243 Cc: Clint Taylor <Clinton.A.Taylor@intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 1280a08b9c72..32fbabf531fe 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1346,6 +1346,16 @@ static const struct intel_cdclk_vals dg2_cdclk_table[] = { {} }; +static const struct intel_cdclk_vals mtl_cdclk_table[] = { + { .refclk = 38400, .cdclk = 172800, .divider = 2, .ratio = 16, .waveform = 0xad5a }, + { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 16, .waveform = 0xb6b6 }, + { .refclk = 38400, .cdclk = 307200, .divider = 2, .ratio = 16, .waveform = 0x0000 }, + { .refclk = 38400, .cdclk = 480000, .divider = 2, .ratio = 25, .waveform = 0x0000 }, + { .refclk = 38400, .cdclk = 556800, .divider = 2, .ratio = 29, .waveform = 0x0000 }, + { .refclk = 38400, .cdclk = 652800, .divider = 2, .ratio = 34, .waveform = 0x0000 }, + {} +}; + static int bxt_calc_cdclk(struct drm_i915_private *dev_priv, int min_cdclk) { const struct intel_cdclk_vals *table = dev_priv->display.cdclk.table; @@ -3190,6 +3200,13 @@ u32 intel_read_rawclk(struct drm_i915_private *dev_priv) return freq; } +static const struct intel_cdclk_funcs mtl_cdclk_funcs = { + .get_cdclk = bxt_get_cdclk, + .set_cdclk = bxt_set_cdclk, + .modeset_calc_cdclk = bxt_modeset_calc_cdclk, + .calc_voltage_level = tgl_calc_voltage_level, +}; + static const struct intel_cdclk_funcs tgl_cdclk_funcs = { .get_cdclk = bxt_get_cdclk, .set_cdclk = bxt_set_cdclk, @@ -3325,7 +3342,10 @@ static const struct intel_cdclk_funcs i830_cdclk_funcs = { */ void intel_init_cdclk_hooks(struct drm_i915_private *dev_priv) { - if (IS_DG2(dev_priv)) { + if (IS_METEORLAKE(dev_priv)) { + dev_priv->display.funcs.cdclk = &mtl_cdclk_funcs; + dev_priv->display.cdclk.table = mtl_cdclk_table; + } else if (IS_DG2(dev_priv)) { dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs; dev_priv->display.cdclk.table = dg2_cdclk_table; } else if (IS_ALDERLAKE_P(dev_priv)) { -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa 2022-11-17 23:00 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk Anusha Srivatsa 2022-11-17 23:00 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: Add CDCLK Support for MTL Anusha Srivatsa @ 2022-11-17 23:31 ` Patchwork 2022-11-17 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (5 subsequent siblings) 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-17 23:31 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/111045/ State : warning == Summary == Error: dim checkpatch failed c105abf14fde drm/i915/display: Add missing checks for cdclk crawling f6927d8d6e84 drm/i915/display: Do both crawl and squash when changing cdclk -:61: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #61: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1736: + const struct intel_cdclk_config *old_cdclk_config, -:62: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1737: + const struct intel_cdclk_config *new_cdclk_config, -:173: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26) #173: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1854: + if (DISPLAY_VER(dev_priv) >= 14) + /* NOOP */; -:205: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19) #205: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1885: + if (DISPLAY_VER(dev_priv) >= 14) [...] + */; total: 0 errors, 4 warnings, 0 checks, 220 lines checked 58eebe208394 drm/i915/display: Add CDCLK Support for MTL ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (2 preceding siblings ...) 2022-11-17 23:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling Patchwork @ 2022-11-17 23:57 ` Patchwork 2022-11-18 16:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork ` (4 subsequent siblings) 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-17 23:57 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 13877 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/111045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12396 -> Patchwork_111045v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/index.html Participating hosts (40 -> 38) ------------------------------ Additional (2): fi-rkl-11600 bat-dg1-6 Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-ilk-m540 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_111045v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#7456]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@debugfs_test@basic-hwmon.html * igt@gem_exec_gttfill@basic: - fi-pnv-d510: [PASS][2] -> [FAIL][3] ([i915#7229]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/fi-pnv-d510/igt@gem_exec_gttfill@basic.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html * igt@gem_huc_copy@huc-copy: - fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#2190]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html * igt@gem_linear_blits@basic: - fi-pnv-d510: [PASS][5] -> [SKIP][6] ([fdo#109271]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/fi-pnv-d510/igt@gem_linear_blits@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-pnv-d510/igt@gem_linear_blits@basic.html * igt@gem_lmem_swapping@basic: - fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@gem_lmem_swapping@basic.html * igt@gem_mmap@basic: - bat-dg1-6: NOTRUN -> [SKIP][8] ([i915#4083]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@gem_mmap@basic.html * igt@gem_render_tiled_blits@basic: - bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4079]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@gem_render_tiled_blits@basic.html * igt@gem_tiled_fence_blits@basic: - bat-dg1-6: NOTRUN -> [SKIP][10] ([i915#4077]) +2 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#3282]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - bat-dg1-6: NOTRUN -> [SKIP][12] ([i915#1155]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html - fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#3012]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html * igt@i915_pm_rps@basic-api: - bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#6621]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@i915_pm_rps@basic-api.html * igt@i915_selftest@live@hangcheck: - fi-rkl-guc: [PASS][15] -> [INCOMPLETE][16] ([i915#4983]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@migrate: - bat-adlp-4: [PASS][17] -> [INCOMPLETE][18] ([i915#7308] / [i915#7348]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-adlp-4/igt@i915_selftest@live@migrate.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-adlp-4/igt@i915_selftest@live@migrate.html * igt@i915_suspend@basic-s3-without-i915: - fi-rkl-11600: NOTRUN -> [INCOMPLETE][19] ([i915#4817]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - bat-dg1-6: NOTRUN -> [SKIP][20] ([i915#4215]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_addfb_basic@tile-pitch-mismatch: - bat-dg1-6: NOTRUN -> [SKIP][21] ([i915#4212]) +7 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html * igt@kms_chamelium@hdmi-crc-fast: - bat-dg1-6: NOTRUN -> [SKIP][22] ([fdo#111827]) +8 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html * igt@kms_chamelium@hdmi-edid-read: - fi-rkl-11600: NOTRUN -> [SKIP][23] ([fdo#111827]) +7 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - fi-rkl-11600: NOTRUN -> [SKIP][24] ([i915#4103]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html - bat-dg1-6: NOTRUN -> [SKIP][25] ([i915#4103] / [i915#4213]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_force_connector_basic@force-load-detect: - fi-rkl-11600: NOTRUN -> [SKIP][26] ([fdo#109285] / [i915#4098]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html - bat-dg1-6: NOTRUN -> [SKIP][27] ([fdo#109285]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@primary_page_flip: - fi-rkl-11600: NOTRUN -> [SKIP][28] ([i915#1072]) +3 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html * igt@kms_psr@sprite_plane_onoff: - bat-dg1-6: NOTRUN -> [SKIP][29] ([i915#1072] / [i915#4078]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - fi-rkl-11600: NOTRUN -> [SKIP][30] ([i915#3555] / [i915#4098]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html - bat-dg1-6: NOTRUN -> [SKIP][31] ([i915#3555]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-gtt: - bat-dg1-6: NOTRUN -> [SKIP][32] ([i915#3708] / [i915#4077]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@prime_vgem@basic-gtt.html * igt@prime_vgem@basic-read: - fi-rkl-11600: NOTRUN -> [SKIP][33] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@prime_vgem@basic-read.html * igt@prime_vgem@basic-userptr: - bat-dg1-6: NOTRUN -> [SKIP][34] ([i915#3708] / [i915#4873]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@prime_vgem@basic-userptr.html - fi-rkl-11600: NOTRUN -> [SKIP][35] ([fdo#109295] / [i915#3301] / [i915#3708]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html * igt@prime_vgem@basic-write: - bat-dg1-6: NOTRUN -> [SKIP][36] ([i915#3708]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-dg1-6/igt@prime_vgem@basic-write.html * igt@runner@aborted: - bat-adlp-4: NOTRUN -> [FAIL][37] ([i915#4312]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-adlp-4/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - {bat-rpls-2}: [DMESG-WARN][38] ([i915#6434]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@smem: - {bat-rplp-1}: [DMESG-WARN][40] ([i915#2867]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@guc: - {bat-rpls-2}: [DMESG-WARN][42] ([i915#6471]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-rpls-2/igt@i915_selftest@live@guc.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-rpls-2/igt@i915_selftest@live@guc.html * igt@kms_frontbuffer_tracking@basic: - {bat-rpls-2}: [SKIP][44] ([i915#1849]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html * igt@prime_vgem@basic-fence-flip: - {bat-rpls-2}: [SKIP][46] ([fdo#109295] / [i915#1845] / [i915#3708]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 [i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 [i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229 [i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308 [i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 Build changes ------------- * Linux: CI_DRM_12396 -> Patchwork_111045v1 CI-20190529: 20190529 CI_DRM_12396: 75ed1f4f7835f178647e3f73910ed4af0944d9ec @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7065: cdc0258a4672b3f1552e4c362ad857ffd792359a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111045v1: 75ed1f4f7835f178647e3f73910ed4af0944d9ec @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 96bc539854e3 drm/i915/display: Add CDCLK Support for MTL 61141ba98ddb drm/i915/display: Do both crawl and squash when changing cdclk 6766b3756998 drm/i915/display: Add missing checks for cdclk crawling == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/index.html [-- Attachment #2: Type: text/html, Size: 16222 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (3 preceding siblings ...) 2022-11-17 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2022-11-18 16:57 ` Patchwork 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) Patchwork ` (3 subsequent siblings) 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-18 16:57 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 46151 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/111045/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12396_full -> Patchwork_111045v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_111045v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_111045v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_111045v1_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_reloc@basic-write-wc: - shard-glk: [PASS][1] -> [TIMEOUT][2] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk3/igt@gem_exec_reloc@basic-write-wc.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/igt@gem_exec_reloc@basic-write-wc.html * igt@i915_selftest@live@evict: - shard-skl: NOTRUN -> [INCOMPLETE][3] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@i915_selftest@live@evict.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling: - shard-glk: NOTRUN -> [TIMEOUT][4] +1 similar issue [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-glk: [SKIP][5] ([fdo#109271] / [i915#658]) -> [TIMEOUT][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk3/igt@i915_pm_dc@dc3co-vpb-simulation.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/igt@i915_pm_dc@dc3co-vpb-simulation.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_gttfill@all: - {shard-rkl}: [PASS][7] -> [INCOMPLETE][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-4/igt@gem_exec_gttfill@all.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-2/igt@gem_exec_gttfill@all.html New tests --------- New tests have been introduced between CI_DRM_12396_full and Patchwork_111045v1_full: ### New IGT tests (2) ### * igt@kms_ccs: - Statuses : - Exec time: [None] s * igt@kms_plane_scaling: - Statuses : - Exec time: [None] s Known issues ------------ Here are the changes found in Patchwork_111045v1_full that come from known issues: ### CI changes ### #### Issues hit #### * boot: - shard-glk: ([PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33]) -> ([PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58]) ([i915#4392]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk9/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk9/boot.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk9/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk9/boot.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk8/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk8/boot.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk8/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk7/boot.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk7/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk7/boot.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk6/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk6/boot.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk6/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk5/boot.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk5/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk5/boot.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk3/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk3/boot.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk3/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk2/boot.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk2/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk2/boot.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk1/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk1/boot.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk1/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk9/boot.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk9/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk9/boot.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk8/boot.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk8/boot.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk8/boot.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk7/boot.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk7/boot.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk7/boot.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk6/boot.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk6/boot.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk6/boot.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/boot.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/boot.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk5/boot.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk3/boot.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk3/boot.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk3/boot.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk3/boot.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk2/boot.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk2/boot.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk2/boot.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk1/boot.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk1/boot.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk1/boot.html ### IGT changes ### #### Issues hit #### * igt@gem_ccs@ctrl-surf-copy-new-ctx: - shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271]) +167 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl10/igt@gem_ccs@ctrl-surf-copy-new-ctx.html * igt@gem_create@create-ext-cpu-access-sanity-check: - shard-iclb: NOTRUN -> [SKIP][60] ([i915#6335]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@gem_create@create-ext-cpu-access-sanity-check.html * igt@gem_exec_balancer@parallel: - shard-iclb: [PASS][61] -> [SKIP][62] ([i915#4525]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb2/igt@gem_exec_balancer@parallel.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb7/igt@gem_exec_balancer@parallel.html * igt@gem_exec_fair@basic-none@vecs0: - shard-glk: [PASS][63] -> [FAIL][64] ([i915#2842]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-glk5/igt@gem_exec_fair@basic-none@vecs0.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-glk2/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_lmem_swapping@heavy-verify-random: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@gem_lmem_swapping@heavy-verify-random.html * igt@gem_lmem_swapping@parallel-random-verify: - shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) +2 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl10/igt@gem_lmem_swapping@parallel-random-verify.html * igt@gem_tiled_wb: - shard-skl: NOTRUN -> [TIMEOUT][67] ([i915#6990]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@gem_tiled_wb.html * igt@gen9_exec_parse@unaligned-jump: - shard-iclb: NOTRUN -> [SKIP][68] ([i915#2856]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@gen9_exec_parse@unaligned-jump.html * igt@i915_pipe_stress@stress-xrgb8888-ytiled: - shard-skl: NOTRUN -> [FAIL][69] ([i915#7036]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl1/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html * igt@i915_pm_rpm@dpms-non-lpsp: - shard-iclb: NOTRUN -> [SKIP][70] ([fdo#110892]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_query@query-topology-unsupported: - shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109302]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@i915_query@query-topology-unsupported.html * igt@i915_selftest@live@gt_pm: - shard-skl: NOTRUN -> [DMESG-FAIL][72] ([i915#1886]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@i915_selftest@live@gt_pm.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][73] ([fdo#110725] / [fdo#111614]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-270: - shard-iclb: NOTRUN -> [SKIP][74] ([fdo#110723]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html * igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs: - shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278]) +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_ccs@pipe-a-crc-primary-basic-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +7 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3886]) +6 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@dp-hpd-enable-disable-mode: - shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109284] / [fdo#111827]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_chamelium@dp-hpd-enable-disable-mode.html * igt@kms_chamelium@hdmi-crc-multiple: - shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +9 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl1/igt@kms_chamelium@hdmi-crc-multiple.html * igt@kms_chamelium@vga-hpd-fast: - shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@kms_chamelium@vga-hpd-fast.html * igt@kms_color@ctm-0-25@pipe-b-edp-1: - shard-iclb: NOTRUN -> [FAIL][81] ([i915#315] / [i915#6946]) +2 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_color@ctm-0-25@pipe-b-edp-1.html * igt@kms_content_protection@atomic@pipe-a-dp-1: - shard-apl: NOTRUN -> [TIMEOUT][82] ([i915#7173]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@kms_content_protection@atomic@pipe-a-dp-1.html * igt@kms_cursor_crc@cursor-sliding-32x32: - shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271]) +43 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl6/igt@kms_cursor_crc@cursor-sliding-32x32.html * igt@kms_flip@2x-flip-vs-panning-interruptible: - shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109274]) +1 similar issue [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_flip@2x-flip-vs-panning-interruptible.html * igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1: - shard-skl: [PASS][85] -> [FAIL][86] ([i915#2122]) +4 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl2/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank@b-dp1: - shard-apl: [PASS][87] -> [FAIL][88] ([i915#79]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl6/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl8/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][89] ([i915#2587] / [i915#2672]) +2 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][90] ([i915#2672]) +2 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][91] ([i915#3555]) +3 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][92] ([i915#2672] / [i915#3555]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_force_connector_basic@force-load-detect: - shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109285]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-wc: - shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109280]) +2 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-wc.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-edp-1: - shard-iclb: NOTRUN -> [SKIP][95] ([i915#5176]) +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-edp-1.html * igt@kms_psr2_sf@plane-move-sf-dmg-area: - shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@kms_psr2_sf@plane-move-sf-dmg-area.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#658]) +2 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@kms_psr2_su@page_flip-nv12: - shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109642] / [fdo#111068] / [i915#658]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb7/igt@kms_psr2_su@page_flip-nv12.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][99] -> [SKIP][100] ([fdo#109441]) +1 similar issue [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_psr_stress_test@invalidate-primary-flip-overlay: - shard-tglb: [PASS][101] -> [SKIP][102] ([i915#5519]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-tglb2/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-tglb2/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-skl: [PASS][103] -> [INCOMPLETE][104] ([i915#7404]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@kms_writeback@writeback-pixel-formats: - shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2437]) +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl7/igt@kms_writeback@writeback-pixel-formats.html * igt@sysfs_clients@fair-3: - shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl1/igt@sysfs_clients@fair-3.html * igt@sysfs_clients@recycle: - shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2994]) +1 similar issue [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@sysfs_clients@recycle.html #### Possible fixes #### * igt@drm_read@empty-nonblock: - {shard-rkl}: [SKIP][108] ([i915#4098]) -> [PASS][109] [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@drm_read@empty-nonblock.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@drm_read@empty-nonblock.html * igt@feature_discovery@psr1: - {shard-rkl}: [SKIP][110] ([i915#658]) -> [PASS][111] +1 similar issue [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@feature_discovery@psr1.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@feature_discovery@psr1.html * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglb: [FAIL][112] ([i915#6268]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-tglb8/igt@gem_ctx_exec@basic-nohangcheck.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-tglb8/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_ctx_persistence@engines-hang@bcs0: - {shard-rkl}: [SKIP][114] ([i915#6252]) -> [PASS][115] [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-4/igt@gem_ctx_persistence@engines-hang@bcs0.html * igt@gem_exec_balancer@parallel-keep-in-fence: - shard-iclb: [SKIP][116] ([i915#4525]) -> [PASS][117] [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb3/igt@gem_exec_balancer@parallel-keep-in-fence.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb1/igt@gem_exec_balancer@parallel-keep-in-fence.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [FAIL][118] ([i915#2842]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - {shard-rkl}: [SKIP][120] ([fdo#109313]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-1/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-write-read: - {shard-rkl}: [SKIP][122] ([i915#3281]) -> [PASS][123] +7 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-1/igt@gem_exec_reloc@basic-write-read.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-5/igt@gem_exec_reloc@basic-write-read.html * igt@gem_exec_suspend@basic-s3@smem: - {shard-rkl}: [FAIL][124] ([fdo#103375]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-4/igt@gem_exec_suspend@basic-s3@smem.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-2/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_exec_whisper@basic-queues-forked: - shard-iclb: [INCOMPLETE][126] ([i915#6453]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb1/igt@gem_exec_whisper@basic-queues-forked.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb5/igt@gem_exec_whisper@basic-queues-forked.html * igt@gem_ppgtt@blt-vs-render-ctx0: - {shard-rkl}: [FAIL][128] ([i915#3692]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@gem_ppgtt@blt-vs-render-ctx0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@gem_ppgtt@blt-vs-render-ctx0.html * igt@gem_pread@display: - {shard-rkl}: [SKIP][130] ([i915#3282]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-1/igt@gem_pread@display.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-5/igt@gem_pread@display.html * igt@gem_spin_batch@user-each: - shard-skl: [FAIL][132] ([i915#2898]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl1/igt@gem_spin_batch@user-each.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl6/igt@gem_spin_batch@user-each.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [DMESG-WARN][134] ([i915#5566] / [i915#716]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl2/igt@gen9_exec_parse@allowed-single.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl6/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@valid-registers: - {shard-rkl}: [SKIP][136] ([i915#2527]) -> [PASS][137] +2 similar issues [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-1/igt@gen9_exec_parse@valid-registers.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-5/igt@gen9_exec_parse@valid-registers.html * igt@i915_hangman@gt-engine-error@bcs0: - {shard-rkl}: [SKIP][138] ([i915#6258]) -> [PASS][139] [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-4/igt@i915_hangman@gt-engine-error@bcs0.html * igt@i915_module_load@reload: - shard-skl: [DMESG-WARN][140] ([i915#1982]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl7/igt@i915_module_load@reload.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl10/igt@i915_module_load@reload.html * igt@i915_pm_backlight@bad-brightness: - {shard-rkl}: [SKIP][142] ([i915#3012]) -> [PASS][143] +1 similar issue [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@i915_pm_backlight@bad-brightness.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@i915_pm_backlight@bad-brightness.html * igt@i915_pm_dc@dc6-dpms: - {shard-rkl}: [SKIP][144] ([i915#3361]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rc6_residency@rc6-idle@bcs0: - {shard-dg1}: [FAIL][146] ([i915#3591]) -> [PASS][147] +1 similar issue [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: - {shard-rkl}: [SKIP][148] ([i915#1397]) -> [PASS][149] [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@i915_suspend@forcewake: - shard-apl: [DMESG-WARN][150] ([i915#180]) -> [PASS][151] [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl2/igt@i915_suspend@forcewake.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl1/igt@i915_suspend@forcewake.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1: - shard-skl: [FAIL][152] ([i915#2521]) -> [PASS][153] [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html * igt@kms_big_fb@x-tiled-32bpp-rotate-0: - {shard-rkl}: [SKIP][154] ([i915#1845] / [i915#4098]) -> [PASS][155] +29 similar issues [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html * igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1: - shard-skl: [INCOMPLETE][156] ([i915#6951]) -> [PASS][157] [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl7/igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl10/igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1.html * igt@kms_fbcon_fbt@psr: - {shard-rkl}: [SKIP][158] ([i915#3955]) -> [PASS][159] [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@kms_fbcon_fbt@psr.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@kms_fbcon_fbt@psr.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][160] ([i915#79]) -> [PASS][161] [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][162] ([i915#1849] / [i915#4098]) -> [PASS][163] +14 similar issues [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_plane@plane-panning-top-left@pipe-a-planes: - {shard-rkl}: [SKIP][164] ([i915#3558]) -> [PASS][165] +3 similar issues [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-3/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@kms_plane@plane-panning-top-left@pipe-a-planes.html * igt@kms_plane_alpha_blend@constant-alpha-min@pipe-b-edp-1: - shard-skl: [FAIL][166] ([i915#4573]) -> [PASS][167] [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl4/igt@kms_plane_alpha_blend@constant-alpha-min@pipe-b-edp-1.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl9/igt@kms_plane_alpha_blend@constant-alpha-min@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1: - shard-iclb: [SKIP][168] ([i915#5235]) -> [PASS][169] +2 similar issues [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html * igt@kms_psr@cursor_render: - {shard-rkl}: [SKIP][170] ([i915#1072]) -> [PASS][171] +2 similar issues [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-5/igt@kms_psr@cursor_render.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-6/igt@kms_psr@cursor_render.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][172] ([fdo#109441]) -> [PASS][173] +1 similar issue [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-tglb: [SKIP][174] ([i915#5519]) -> [PASS][175] [174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-tglb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-tglb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@perf@polling: - {shard-rkl}: [FAIL][176] ([i915#5639]) -> [PASS][177] [176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-rkl-1/igt@perf@polling.html [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-rkl-5/igt@perf@polling.html * igt@sysfs_heartbeat_interval@mixed@rcs0: - shard-skl: [FAIL][178] ([i915#1731]) -> [PASS][179] [178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl9/igt@sysfs_heartbeat_interval@mixed@rcs0.html [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl6/igt@sysfs_heartbeat_interval@mixed@rcs0.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [FAIL][180] ([i915#6117]) -> [SKIP][181] ([i915#4525]) [180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html * igt@gem_pread@exhaustion: - shard-apl: [INCOMPLETE][182] ([i915#7248]) -> [WARN][183] ([i915#2658]) [182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl1/igt@gem_pread@exhaustion.html [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl6/igt@gem_pread@exhaustion.html * igt@gem_pwrite@basic-exhaustion: - shard-tglb: [WARN][184] ([i915#2658]) -> [INCOMPLETE][185] ([i915#7248]) [184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-tglb8/igt@gem_pwrite@basic-exhaustion.html [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-tglb6/igt@gem_pwrite@basic-exhaustion.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][186] ([i915#2122]) -> [FAIL][187] ([i915#79]) [186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][188] ([fdo#111068] / [i915#658]) -> [SKIP][189] ([i915#2920]) [188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb5/igt@kms_psr2_sf@cursor-plane-update-sf.html [189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-iclb: [SKIP][190] ([i915#658]) -> [SKIP][191] ([i915#2920]) +1 similar issue [190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb7/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html [191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area: - shard-iclb: [SKIP][192] ([i915#2920]) -> [SKIP][193] ([fdo#111068] / [i915#658]) [192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html [193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html * igt@runner@aborted: - shard-apl: ([FAIL][194], [FAIL][195], [FAIL][196], [FAIL][197]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][198], [FAIL][199]) ([i915#3002] / [i915#4312]) [194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl2/igt@runner@aborted.html [195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl7/igt@runner@aborted.html [196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl2/igt@runner@aborted.html [197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12396/shard-apl2/igt@runner@aborted.html [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl6/igt@runner@aborted.html [199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/shard-apl8/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 [i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6951]: https://gitlab.freedesktop.org/drm/intel/issues/6951 [i915#6990]: https://gitlab.freedesktop.org/drm/intel/issues/6990 [i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173 [i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248 [i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276 [i915#7404]: https://gitlab.freedesktop.org/drm/intel/issues/7404 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_12396 -> Patchwork_111045v1 CI-20190529: 20190529 CI_DRM_12396: 75ed1f4f7835f178647e3f73910ed4af0944d9ec @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7065: cdc0258a4672b3f1552e4c362ad857ffd792359a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111045v1: 75ed1f4f7835f178647e3f73910ed4af0944d9ec @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v1/index.html [-- Attachment #2: Type: text/html, Size: 49300 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (4 preceding siblings ...) 2022-11-18 16:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2022-11-19 0:13 ` Patchwork 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork ` (2 subsequent siblings) 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-19 0:13 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) URL : https://patchwork.freedesktop.org/series/111045/ State : warning == Summary == Error: dim checkpatch failed 2934471a6919 drm/i915/display: Add missing checks for cdclk crawling f7ff44e0745c drm/i915/display: Do both crawl and squash when changing cdclk -:62: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1736: + const struct intel_cdclk_config *old_cdclk_config, -:63: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #63: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1737: + const struct intel_cdclk_config *new_cdclk_config, -:174: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26) #174: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1854: + if (DISPLAY_VER(dev_priv) >= 14) + /* NOOP */; -:206: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19) #206: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1885: + if (DISPLAY_VER(dev_priv) >= 14) [...] + */; total: 0 errors, 4 warnings, 0 checks, 220 lines checked eb9eda5c9027 drm/i915/display: Add CDCLK Support for MTL ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (5 preceding siblings ...) 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) Patchwork @ 2022-11-19 0:13 ` Patchwork 2022-11-19 0:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-11-19 19:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-19 0:13 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) URL : https://patchwork.freedesktop.org/series/111045/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead ./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (6 preceding siblings ...) 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork @ 2022-11-19 0:33 ` Patchwork 2022-11-19 19:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-19 0:33 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 7595 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) URL : https://patchwork.freedesktop.org/series/111045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12403 -> Patchwork_111045v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/index.html Participating hosts (43 -> 41) ------------------------------ Additional (2): fi-hsw-4770 fi-tgl-dsi Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-rkl-11600 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_111045v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_hotunplug@unbind-rebind: - fi-apl-guc: [PASS][1] -> [INCOMPLETE][2] ([i915#7073]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-apl-guc/igt@core_hotunplug@unbind-rebind.html * igt@gem_softpin@allocator-basic-reserve: - fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271]) +11 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html * igt@i915_selftest@live@execlists: - fi-bdw-gvtdvm: [PASS][4] -> [INCOMPLETE][5] ([i915#2940]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7567u: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html - bat-adlp-4: NOTRUN -> [SKIP][7] ([fdo#111827]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/bat-adlp-4/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-crc-fast: - fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html * igt@kms_pipe_crc_basic@suspend-read-crc: - bat-adlp-4: NOTRUN -> [SKIP][9] ([i915#3546]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/bat-adlp-4/igt@kms_pipe_crc_basic@suspend-read-crc.html - fi-kbl-7567u: NOTRUN -> [SKIP][10] ([fdo#109271]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-kbl-7567u/igt@kms_pipe_crc_basic@suspend-read-crc.html * igt@kms_psr@sprite_plane_onoff: - fi-hsw-4770: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1072]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html * igt@runner@aborted: - fi-bdw-gvtdvm: NOTRUN -> [FAIL][12] ([i915#4312]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-bdw-gvtdvm/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - {bat-rpls-2}: [DMESG-WARN][13] ([i915#6434]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html * igt@i915_selftest@live@hangcheck: - {fi-ehl-2}: [INCOMPLETE][15] ([i915#5153] / [i915#6106] / [i915#7351]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/fi-ehl-2/igt@i915_selftest@live@hangcheck.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-ehl-2/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@migrate: - bat-adlp-4: [INCOMPLETE][17] ([i915#7308] / [i915#7348]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/bat-adlp-4/igt@i915_selftest@live@migrate.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/bat-adlp-4/igt@i915_selftest@live@migrate.html * igt@i915_suspend@basic-s3-without-i915: - fi-kbl-7567u: [INCOMPLETE][19] ([i915#4817]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153 [i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 [i915#6856]: https://gitlab.freedesktop.org/drm/intel/issues/6856 [i915#7073]: https://gitlab.freedesktop.org/drm/intel/issues/7073 [i915#7125]: https://gitlab.freedesktop.org/drm/intel/issues/7125 [i915#7308]: https://gitlab.freedesktop.org/drm/intel/issues/7308 [i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346 [i915#7348]: https://gitlab.freedesktop.org/drm/intel/issues/7348 [i915#7351]: https://gitlab.freedesktop.org/drm/intel/issues/7351 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 Build changes ------------- * Linux: CI_DRM_12403 -> Patchwork_111045v2 CI-20190529: 20190529 CI_DRM_12403: 9c91ccfa558e7510add39958a56745ae7fa07753 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7068: 5c0ec905b6bbecfb8df8b8f3315d0470539e6ae3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111045v2: 9c91ccfa558e7510add39958a56745ae7fa07753 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 05377c001228 drm/i915/display: Add CDCLK Support for MTL b2472c5b3801 drm/i915/display: Do both crawl and squash when changing cdclk 52b882638e77 drm/i915/display: Add missing checks for cdclk crawling == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/index.html [-- Attachment #2: Type: text/html, Size: 7930 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa ` (7 preceding siblings ...) 2022-11-19 0:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2022-11-19 19:34 ` Patchwork 8 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-19 19:34 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 45074 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) URL : https://patchwork.freedesktop.org/series/111045/ State : success == Summary == CI Bug Log - changes from CI_DRM_12403_full -> Patchwork_111045v2_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (11 -> 11) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_111045v2_full that come from known issues: ### CI changes ### #### Possible fixes #### * boot: - shard-glk: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [FAIL][6], [PASS][7], [FAIL][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) ([i915#4392]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk9/boot.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk8/boot.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk1/boot.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk1/boot.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk1/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk2/boot.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk2/boot.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk2/boot.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk2/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk2/boot.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk3/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk3/boot.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk3/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk5/boot.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk5/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk6/boot.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk6/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk6/boot.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk7/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk7/boot.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk7/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk8/boot.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk9/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk9/boot.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk8/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk2/boot.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk1/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk1/boot.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk1/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk2/boot.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk2/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk3/boot.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk3/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk3/boot.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk3/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk5/boot.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk5/boot.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk5/boot.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk6/boot.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk6/boot.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk6/boot.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/boot.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/boot.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/boot.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk8/boot.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk8/boot.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk8/boot.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/boot.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/boot.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/boot.html ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@crc32: - shard-iclb: NOTRUN -> [SKIP][51] ([i915#6230]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@api_intel_bb@crc32.html * igt@feature_discovery@display-3x: - shard-iclb: NOTRUN -> [SKIP][52] ([i915#1839]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@feature_discovery@display-3x.html * igt@gem_eio@in-flight-suspend: - shard-skl: [PASS][53] -> [INCOMPLETE][54] ([i915#7112]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl1/igt@gem_eio@in-flight-suspend.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl10/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [PASS][55] -> [SKIP][56] ([i915#4525]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-glk: NOTRUN -> [FAIL][57] ([i915#2842]) +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][58] -> [FAIL][59] ([i915#2842]) +1 similar issue [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_lmem_swapping@parallel-random-verify: - shard-iclb: NOTRUN -> [SKIP][60] ([i915#4613]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@gem_lmem_swapping@parallel-random-verify.html * igt@gem_lmem_swapping@smem-oom: - shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#4613]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@gem_lmem_swapping@smem-oom.html * igt@gem_lmem_swapping@verify-random-ccs: - shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#4613]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/igt@gem_lmem_swapping@verify-random-ccs.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271]) +47 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][64] ([i915#3318]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#5566] / [i915#716]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl1/igt@gen9_exec_parse@allowed-single.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl2/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@cmd-crossing-page: - shard-iclb: NOTRUN -> [SKIP][67] ([i915#2856]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@gen9_exec_parse@cmd-crossing-page.html * igt@i915_pm_rpm@modeset-pc8-residency-stress: - shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109293] / [fdo#109506]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@i915_pm_rpm@modeset-pc8-residency-stress.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][69] -> [DMESG-WARN][70] ([i915#180]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip: - shard-iclb: NOTRUN -> [SKIP][71] ([i915#5286]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html * igt@kms_big_fb@y-tiled-64bpp-rotate-270: - shard-iclb: NOTRUN -> [SKIP][72] ([fdo#110725] / [fdo#111614]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs: - shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs: - shard-glk: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3886]) +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109278] / [i915#3886]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@common-hpd-after-suspend: - shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-crc-single: - shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109284] / [fdo#111827]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_chamelium@dp-crc-single.html * igt@kms_chamelium@dp-hpd-enable-disable-mode: - shard-glk: NOTRUN -> [SKIP][78] ([fdo#109271] / [fdo#111827]) +5 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/igt@kms_chamelium@dp-hpd-enable-disable-mode.html * igt@kms_content_protection@content_type_change: - shard-iclb: NOTRUN -> [SKIP][79] ([i915#7118]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_content_protection@content_type_change.html * igt@kms_content_protection@lic@pipe-a-dp-1: - shard-apl: NOTRUN -> [TIMEOUT][80] ([i915#7173]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@kms_content_protection@lic@pipe-a-dp-1.html * igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1: - shard-skl: NOTRUN -> [INCOMPLETE][81] ([i915#6951]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl4/igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1.html * igt@kms_cursor_legacy@cursor-vs-flip@toggle: - shard-skl: [PASS][82] -> [FAIL][83] ([i915#5072]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl9/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl1/igt@kms_cursor_legacy@cursor-vs-flip@toggle.html * igt@kms_cursor_legacy@flip-vs-cursor@toggle: - shard-skl: [PASS][84] -> [SKIP][85] ([fdo#109271]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html * igt@kms_dsc@dsc-with-bpc-formats: - shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#7205]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk2/igt@kms_dsc@dsc-with-bpc-formats.html * igt@kms_flip@flip-vs-suspend-interruptible@c-edp1: - shard-iclb: [PASS][87] -> [DMESG-WARN][88] ([i915#2867]) +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb5/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1: - shard-skl: [PASS][89] -> [FAIL][90] ([i915#2122]) +8 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][91] ([i915#2672]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][92] ([i915#6375]) [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][93] ([i915#2587] / [i915#2672]) +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary: - shard-glk: [PASS][94] -> [FAIL][95] ([i915#2546]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html - shard-iclb: [PASS][96] -> [FAIL][97] ([i915#2546]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html * igt@kms_frontbuffer_tracking@fbcpsr-tiling-4: - shard-iclb: NOTRUN -> [SKIP][98] ([i915#5438]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-msflip-blt: - shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109280]) +7 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-msflip-blt.html * igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2: - shard-glk: NOTRUN -> [FAIL][100] ([i915#4573]) +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2.html * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1: - shard-iclb: [PASS][101] -> [SKIP][102] ([i915#5176]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb8/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html * igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-1: - shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271]) +92 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1: - shard-iclb: NOTRUN -> [SKIP][104] ([i915#5235]) +2 similar issues [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-iclb: NOTRUN -> [SKIP][105] ([i915#658]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@overlay-plane-update-continuous-sf: - shard-glk: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658]) +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb: - shard-apl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#658]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][108] -> [SKIP][109] ([fdo#109441]) +2 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109441]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_psr_stress_test@invalidate-primary-flip-overlay: - shard-iclb: [PASS][111] -> [SKIP][112] ([i915#5519]) [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb2/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb7/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html * igt@kms_writeback@writeback-check-output: - shard-iclb: NOTRUN -> [SKIP][113] ([i915#2437]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_writeback@writeback-check-output.html * igt@perf@polling: - shard-skl: [PASS][114] -> [FAIL][115] ([i915#1542]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl1/igt@perf@polling.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl10/igt@perf@polling.html * igt@sysfs_clients@sema-50: - shard-glk: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2994]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk9/igt@sysfs_clients@sema-50.html * igt@sysfs_heartbeat_interval@mixed@vcs0: - shard-skl: [PASS][117] -> [FAIL][118] ([i915#1731]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl1/igt@sysfs_heartbeat_interval@mixed@vcs0.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl6/igt@sysfs_heartbeat_interval@mixed@vcs0.html * igt@tools_test@sysfs_l3_parity: - shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109307]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@tools_test@sysfs_l3_parity.html #### Possible fixes #### * igt@drm_read@short-buffer-nonblock: - {shard-rkl}: [SKIP][120] ([i915#4098]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@drm_read@short-buffer-nonblock.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@drm_read@short-buffer-nonblock.html * igt@gem_create@create-clear@smem0: - {shard-rkl}: [INCOMPLETE][122] ([i915#7397]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@gem_create@create-clear@smem0.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@gem_create@create-clear@smem0.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][124] ([i915#6259]) -> [PASS][125] [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-2/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_balancer@full-pulse: - {shard-dg1}: [FAIL][126] ([i915#6032]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-dg1-17/igt@gem_exec_balancer@full-pulse.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-dg1-19/igt@gem_exec_balancer@full-pulse.html * igt@gem_exec_fair@basic-none@vcs0: - shard-glk: [FAIL][128] ([i915#2842]) -> [PASS][129] +1 similar issue [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk6/igt@gem_exec_fair@basic-none@vcs0.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk3/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fence@syncobj-repeat: - shard-skl: [FAIL][130] -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl10/igt@gem_exec_fence@syncobj-repeat.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl6/igt@gem_exec_fence@syncobj-repeat.html * igt@gem_exec_reloc@basic-write-read-active: - {shard-rkl}: [SKIP][132] ([i915#3281]) -> [PASS][133] +5 similar issues [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-4/igt@gem_exec_reloc@basic-write-read-active.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-active.html * igt@gem_tiled_partial_pwrite_pread@writes: - {shard-rkl}: [SKIP][134] ([i915#3282]) -> [PASS][135] +3 similar issues [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-1/igt@gem_tiled_partial_pwrite_pread@writes.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-5/igt@gem_tiled_partial_pwrite_pread@writes.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [DMESG-WARN][136] ([i915#5566] / [i915#716]) -> [PASS][137] [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk8/igt@gen9_exec_parse@allowed-single.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk7/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@bb-chained: - {shard-rkl}: [SKIP][138] ([i915#2527]) -> [PASS][139] +4 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-2/igt@gen9_exec_parse@bb-chained.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-5/igt@gen9_exec_parse@bb-chained.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][140] ([i915#3989] / [i915#454]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb6/igt@i915_pm_dc@dc6-psr.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [SKIP][142] ([i915#4281]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html * igt@i915_selftest@live@hangcheck: - shard-tglb: [DMESG-WARN][144] ([i915#5591]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-tglb2/igt@i915_selftest@live@hangcheck.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-tglb8/igt@i915_selftest@live@hangcheck.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs: - {shard-rkl}: [SKIP][146] ([i915#1845] / [i915#4098]) -> [PASS][147] +6 similar issues [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1: - shard-skl: [INCOMPLETE][148] ([i915#1982] / [i915#6951]) -> [PASS][149] [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl6/igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl4/igt@kms_cursor_crc@cursor-suspend@pipe-a-edp-1.html * igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1: - shard-apl: [DMESG-WARN][150] ([i915#180]) -> [PASS][151] +1 similar issue [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl8/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl1/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][152] ([i915#2346]) -> [PASS][153] +1 similar issue [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_cursor_legacy@forked-bo@pipe-c: - shard-iclb: [INCOMPLETE][154] ([i915#4391]) -> [PASS][155] [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb7/igt@kms_cursor_legacy@forked-bo@pipe-c.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb8/igt@kms_cursor_legacy@forked-bo@pipe-c.html * igt@kms_flip@flip-vs-suspend-interruptible@d-hdmi-a4: - {shard-dg1}: [FAIL][156] ([fdo#103375]) -> [PASS][157] [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-dg1-15/igt@kms_flip@flip-vs-suspend-interruptible@d-hdmi-a4.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-dg1-17/igt@kms_flip@flip-vs-suspend-interruptible@d-hdmi-a4.html * igt@kms_flip@plain-flip-fb-recreate@b-edp1: - shard-skl: [FAIL][158] ([i915#2122]) -> [PASS][159] [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl10/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu: - {shard-rkl}: [SKIP][160] ([i915#1849] / [i915#4098]) -> [PASS][161] +5 similar issues [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html * igt@kms_properties@plane-properties-legacy: - {shard-rkl}: [SKIP][162] ([i915#1849]) -> [PASS][163] [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@kms_properties@plane-properties-legacy.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@kms_properties@plane-properties-legacy.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][164] ([fdo#109441]) -> [PASS][165] +1 similar issue [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb6/igt@kms_psr@psr2_no_drrs.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@kms_psr@sprite_render: - {shard-rkl}: [SKIP][166] ([i915#1072]) -> [PASS][167] [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@kms_psr@sprite_render.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@kms_psr@sprite_render.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-tglb: [SKIP][168] ([i915#5519]) -> [PASS][169] +1 similar issue [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-tglb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-tglb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@prime_vgem@basic-fence-flip: - {shard-rkl}: [SKIP][170] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][171] [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-5/igt@prime_vgem@basic-fence-flip.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@coherency-gtt: - {shard-rkl}: [SKIP][172] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][173] [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-rkl-2/igt@prime_vgem@coherency-gtt.html [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-rkl-5/igt@prime_vgem@coherency-gtt.html #### Warnings #### * igt@gem_pread@exhaustion: - shard-glk: [INCOMPLETE][174] ([i915#7248]) -> [WARN][175] ([i915#2658]) [174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-glk8/igt@gem_pread@exhaustion.html [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-glk6/igt@gem_pread@exhaustion.html * igt@gem_pwrite@basic-exhaustion: - shard-tglb: [INCOMPLETE][176] ([i915#7248]) -> [WARN][177] ([i915#2658]) [176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-tglb3/igt@gem_pwrite@basic-exhaustion.html [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-tglb6/igt@gem_pwrite@basic-exhaustion.html * igt@i915_pm_rc6_residency@rc6-idle@rcs0: - shard-iclb: [FAIL][178] ([i915#2684]) -> [WARN][179] ([i915#2684]) [178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html * igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1: - shard-apl: [DMESG-FAIL][180] ([IGT#6]) -> [FAIL][181] ([i915#4573]) +1 similar issue [180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl2/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html * igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1: - shard-skl: [DMESG-FAIL][182] ([IGT#6]) -> [FAIL][183] ([i915#4573]) [182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-skl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1.html [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-skl4/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1.html * igt@kms_psr2_sf@cursor-plane-move-continuous-sf: - shard-iclb: [SKIP][184] ([i915#2920]) -> [SKIP][185] ([i915#658]) [184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html * igt@kms_psr2_sf@overlay-plane-move-continuous-sf: - shard-iclb: [SKIP][186] ([i915#658]) -> [SKIP][187] ([i915#2920]) [186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-iclb6/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html * igt@runner@aborted: - shard-apl: ([FAIL][188], [FAIL][189], [FAIL][190]) ([i915#3002] / [i915#4312]) -> ([FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) [188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl8/igt@runner@aborted.html [189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl7/igt@runner@aborted.html [190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12403/shard-apl2/igt@runner@aborted.html [191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl2/igt@runner@aborted.html [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl6/igt@runner@aborted.html [193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl6/igt@runner@aborted.html [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/shard-apl3/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6 [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5438]: https://gitlab.freedesktop.org/drm/intel/issues/5438 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591 [i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375 [i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6951]: https://gitlab.freedesktop.org/drm/intel/issues/6951 [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037 [i915#7112]: https://gitlab.freedesktop.org/drm/intel/issues/7112 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173 [i915#7205]: https://gitlab.freedesktop.org/drm/intel/issues/7205 [i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248 [i915#7397]: https://gitlab.freedesktop.org/drm/intel/issues/7397 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 Build changes ------------- * Linux: CI_DRM_12403 -> Patchwork_111045v2 CI-20190529: 20190529 CI_DRM_12403: 9c91ccfa558e7510add39958a56745ae7fa07753 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7068: 5c0ec905b6bbecfb8df8b8f3315d0470539e6ae3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111045v2: 9c91ccfa558e7510add39958a56745ae7fa07753 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111045v2/index.html [-- Attachment #2: Type: text/html, Size: 47611 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling @ 2022-11-16 21:50 Anusha Srivatsa 2022-11-16 23:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork 0 siblings, 1 reply; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-16 21:50 UTC (permalink / raw) To: intel-gfx cdclk_sanitize() function was written assuming vco was a signed integer. vco gets assigned to -1 (essentially ~0) for the case where PLL might be enabled and vco is not a frequency that will ever get used. In such a scenario the right thing to do is disable the PLL and re-enable it again with a valid frequency. However the vco is declared as a unsigned variable. With the above assumption, driver takes crawl path when not needed. Add explicit check to not crawl in the case of an invalid PLL. v2: Move the check from .h to .c (MattR) - Move check to bxt_set_cdclk() instead of intel_modeset_calc_cdclk() which is directly in the path of the sanitize() function (Ville) v3: remove unwanted parenthesis(Ville) Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index b74e36d76013..25d01271dc09 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1717,6 +1717,16 @@ static void dg2_cdclk_squash_program(struct drm_i915_private *i915, intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl); } +static bool cdclk_pll_is_unknown(unsigned int vco) +{ + /* + * Ensure driver does not take the crawl path for the + * case when the vco is set to ~0 in the + * sanitize path. + */ + return vco == ~0; +} + static void bxt_set_cdclk(struct drm_i915_private *dev_priv, const struct intel_cdclk_config *cdclk_config, enum pipe pipe) @@ -1749,7 +1759,8 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, return; } - if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0) { + if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && + !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { if (dev_priv->display.cdclk.hw.vco != vco) adlp_cdclk_pll_crawl(dev_priv, vco); } else if (DISPLAY_VER(dev_priv) >= 11) -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-16 21:50 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa @ 2022-11-16 23:29 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-16 23:29 UTC (permalink / raw) To: Anusha Srivatsa; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/110986/ State : warning == Summary == Error: dim checkpatch failed aa8ce217526b drm/i915/display: Add missing checks for cdclk crawling b688374372d5 drm/i915/display: Do both crawl and squash when changing cdclk -:61: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #61: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1736: + const struct intel_cdclk_config *old_cdclk_config, -:62: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1737: + const struct intel_cdclk_config *new_cdclk_config, -:172: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26) #172: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1852: + if (DISPLAY_VER(dev_priv) >= 14) + /* NOOP */; -:203: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19) #203: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1883: + if (DISPLAY_VER(dev_priv) >= 14) [...] + */; total: 0 errors, 4 warnings, 0 checks, 216 lines checked 2ab8faf850e7 drm/i915/display: Add CDCLK Support for MTL ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling @ 2022-11-16 14:50 Anusha Srivatsa 2022-11-16 21:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork 0 siblings, 1 reply; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-16 14:50 UTC (permalink / raw) To: intel-gfx cdclk_sanitize() function was written assuming vco was a signed integer. vco gets assigned to -1 (essentially ~0) for the case where PLL might be enabled and vco is not a frequency that will ever get used. In such a scenario the right thing to do is disable the PLL and re-enable it again with a valid frequency. However the vco is declared as a unsigned variable. With the above assumption, driver takes crawl path when not needed. Add explicit check to not crawl in the case of an invalid PLL. v2: Move the check from .h to .c (MattR) - Move check to bxt_set_cdclk() instead of intel_modeset_calc_cdclk() which is directly in the path of the sanitize() function (Ville) v3: remove unwanted parenthesis(Ville) Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index b74e36d76013..25d01271dc09 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1717,6 +1717,16 @@ static void dg2_cdclk_squash_program(struct drm_i915_private *i915, intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl); } +static bool cdclk_pll_is_unknown(unsigned int vco) +{ + /* + * Ensure driver does not take the crawl path for the + * case when the vco is set to ~0 in the + * sanitize path. + */ + return vco == ~0; +} + static void bxt_set_cdclk(struct drm_i915_private *dev_priv, const struct intel_cdclk_config *cdclk_config, enum pipe pipe) @@ -1749,7 +1759,8 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, return; } - if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0) { + if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && + !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { if (dev_priv->display.cdclk.hw.vco != vco) adlp_cdclk_pll_crawl(dev_priv, vco); } else if (DISPLAY_VER(dev_priv) >= 11) -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-16 14:50 [Intel-gfx] [PATCH 1/3] " Anusha Srivatsa @ 2022-11-16 21:21 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-16 21:21 UTC (permalink / raw) To: Srivatsa, Anusha; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/110970/ State : warning == Summary == Error: dim checkpatch failed 8b43fdea884d drm/i915/display: Add missing checks for cdclk crawling 0058d40d8134 drm/i915/display: Do both crawl and squash when changing cdclk -:61: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #61: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1736: + const struct intel_cdclk_config *old_cdclk_config, -:62: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1737: + const struct intel_cdclk_config *new_cdclk_config, -:170: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26) #170: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1850: + if (DISPLAY_VER(dev_priv) >= 14) + /* NOOP */; -:201: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19) #201: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1881: + if (DISPLAY_VER(dev_priv) >= 14) [...] + */; total: 0 errors, 4 warnings, 0 checks, 214 lines checked b56ac994c40f drm/i915/display: Add CDCLK Support for MTL ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling @ 2022-11-14 20:57 Anusha Srivatsa 2022-11-15 0:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork 0 siblings, 1 reply; 14+ messages in thread From: Anusha Srivatsa @ 2022-11-14 20:57 UTC (permalink / raw) To: intel-gfx cdclk_sanitize() function was written assuming vco was a signed integer. vco gets assigned to -1 (essentially ~0) for the case where PLL might be enabled and vco is not a frequency that will ever get used. In such a scenario the right thing to do is disable the PLL and re-enable it again with a valid frequency. However the vco is declared as a unsigned variable. With the above assumption, driver takes crawl path when not needed. Add explicit check to not crawl in the case of an invalid PLL. v2: Move the check from .h to .c (MattR) - Move check to bxt_set_cdclk() instead of intel_modeset_calc_cdclk() which is directly in the path of the sanitize() function (Ville) v3: remove unwanted parenthesis(Ville) Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index b74e36d76013..25d01271dc09 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -1717,6 +1717,16 @@ static void dg2_cdclk_squash_program(struct drm_i915_private *i915, intel_de_write(i915, CDCLK_SQUASH_CTL, squash_ctl); } +static bool cdclk_pll_is_unknown(unsigned int vco) +{ + /* + * Ensure driver does not take the crawl path for the + * case when the vco is set to ~0 in the + * sanitize path. + */ + return vco == ~0; +} + static void bxt_set_cdclk(struct drm_i915_private *dev_priv, const struct intel_cdclk_config *cdclk_config, enum pipe pipe) @@ -1749,7 +1759,8 @@ static void bxt_set_cdclk(struct drm_i915_private *dev_priv, return; } - if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0) { + if (HAS_CDCLK_CRAWL(dev_priv) && dev_priv->display.cdclk.hw.vco > 0 && vco > 0 && + !cdclk_pll_is_unknown(dev_priv->display.cdclk.hw.vco)) { if (dev_priv->display.cdclk.hw.vco != vco) adlp_cdclk_pll_crawl(dev_priv, vco); } else if (DISPLAY_VER(dev_priv) >= 11) -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling 2022-11-14 20:57 [Intel-gfx] [PATCH 1/3] " Anusha Srivatsa @ 2022-11-15 0:25 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-11-15 0:25 UTC (permalink / raw) To: Srivatsa, Anusha; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling URL : https://patchwork.freedesktop.org/series/110882/ State : warning == Summary == Error: dim checkpatch failed 77c35543c996 drm/i915/display: Add missing checks for cdclk crawling 0ea41d2f3543 drm/i915/display: Do both crawl and squash when changing cdclk -:62: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #62: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1736: + const struct intel_cdclk_config *old_cdclk_config, -:63: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #63: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1737: + const struct intel_cdclk_config *new_cdclk_config, -:192: ERROR:TRAILING_WHITESPACE: trailing whitespace #192: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:1862: +^I$ total: 1 errors, 2 warnings, 0 checks, 206 lines checked 17dddff83aa5 drm/i915/display: Add CDCLK Support for MTL ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-11-19 19:34 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-17 23:00 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa 2022-11-17 23:00 ` [Intel-gfx] [PATCH 2/3] drm/i915/display: Do both crawl and squash when changing cdclk Anusha Srivatsa 2022-11-18 0:53 ` Matt Roper 2022-11-17 23:00 ` [Intel-gfx] [PATCH 3/3] drm/i915/display: Add CDCLK Support for MTL Anusha Srivatsa 2022-11-17 23:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling Patchwork 2022-11-17 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-11-18 16:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Add missing checks for cdclk crawling (rev2) Patchwork 2022-11-19 0:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2022-11-19 0:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-11-19 19:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2022-11-16 21:50 [Intel-gfx] [PATCH 1/3] drm/i915/display: Add missing checks for cdclk crawling Anusha Srivatsa 2022-11-16 23:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork 2022-11-16 14:50 [Intel-gfx] [PATCH 1/3] " Anusha Srivatsa 2022-11-16 21:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork 2022-11-14 20:57 [Intel-gfx] [PATCH 1/3] " Anusha Srivatsa 2022-11-15 0:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.