* [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
@ 2022-11-22 8:40 ` Jiucheng Xu
0 siblings, 0 replies; 6+ messages in thread
From: Jiucheng Xu @ 2022-11-22 8:40 UTC (permalink / raw)
To: Jiucheng Xu, Will Deacon, Mark Rutland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: Jianxin Pan, Kelvin Zhang, Chris Healy, Chris Healy,
linux-amlogic, linux-arm-kernel, linux-kernel
The driver misses including <linux/io.h>. It causes
compiling error "implicit declaration of function
'readl' and 'writel'" when make X86_64 allmodconfig.
Fixs: '2016e2113d35b ("perf/amlogic: Add support for
Amlogic meson G12 SoC DDR PMU driver")'
Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes v1 -> v2:
- Add the "Reviewed-by" tag
---
drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
index c07c34f03cce..932802abd18c 100644
--- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
+++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
@@ -4,6 +4,7 @@
*/
#include <linux/err.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
@ 2022-11-22 8:40 ` Jiucheng Xu
0 siblings, 0 replies; 6+ messages in thread
From: Jiucheng Xu @ 2022-11-22 8:40 UTC (permalink / raw)
To: Jiucheng Xu, Will Deacon, Mark Rutland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: Jianxin Pan, Kelvin Zhang, Chris Healy, Chris Healy,
linux-amlogic, linux-arm-kernel, linux-kernel
The driver misses including <linux/io.h>. It causes
compiling error "implicit declaration of function
'readl' and 'writel'" when make X86_64 allmodconfig.
Fixs: '2016e2113d35b ("perf/amlogic: Add support for
Amlogic meson G12 SoC DDR PMU driver")'
Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes v1 -> v2:
- Add the "Reviewed-by" tag
---
drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
index c07c34f03cce..932802abd18c 100644
--- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
+++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
@@ -4,6 +4,7 @@
*/
#include <linux/err.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
@ 2022-11-22 8:40 ` Jiucheng Xu
0 siblings, 0 replies; 6+ messages in thread
From: Jiucheng Xu @ 2022-11-22 8:40 UTC (permalink / raw)
To: Jiucheng Xu, Will Deacon, Mark Rutland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: Jianxin Pan, Kelvin Zhang, Chris Healy, Chris Healy,
linux-amlogic, linux-arm-kernel, linux-kernel
The driver misses including <linux/io.h>. It causes
compiling error "implicit declaration of function
'readl' and 'writel'" when make X86_64 allmodconfig.
Fixs: '2016e2113d35b ("perf/amlogic: Add support for
Amlogic meson G12 SoC DDR PMU driver")'
Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes v1 -> v2:
- Add the "Reviewed-by" tag
---
drivers/perf/amlogic/meson_g12_ddr_pmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/amlogic/meson_g12_ddr_pmu.c b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
index c07c34f03cce..932802abd18c 100644
--- a/drivers/perf/amlogic/meson_g12_ddr_pmu.c
+++ b/drivers/perf/amlogic/meson_g12_ddr_pmu.c
@@ -4,6 +4,7 @@
*/
#include <linux/err.h>
+#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of.h>
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
2022-11-22 8:40 ` Jiucheng Xu
(?)
@ 2022-11-22 11:19 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2022-11-22 11:19 UTC (permalink / raw)
To: Jerome Brunet, Jiucheng Xu, Neil Armstrong, Mark Rutland,
Kevin Hilman, Martin Blumenstingl
Cc: catalin.marinas, kernel-team, Will Deacon, linux-amlogic,
Chris Healy, linux-kernel, Chris Healy, Kelvin Zhang,
Jianxin Pan, linux-arm-kernel
On Tue, 22 Nov 2022 16:40:28 +0800, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
>
> Amlogic meson G12 SoC DDR PMU driver")'
>
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf/amlogic: Fix build error for x86_64 allmodconfig
https://git.kernel.org/will/c/9d1d5cb32314
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
@ 2022-11-22 11:19 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2022-11-22 11:19 UTC (permalink / raw)
To: Jerome Brunet, Jiucheng Xu, Neil Armstrong, Mark Rutland,
Kevin Hilman, Martin Blumenstingl
Cc: catalin.marinas, kernel-team, Will Deacon, linux-amlogic,
Chris Healy, linux-kernel, Chris Healy, Kelvin Zhang,
Jianxin Pan, linux-arm-kernel
On Tue, 22 Nov 2022 16:40:28 +0800, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
>
> Amlogic meson G12 SoC DDR PMU driver")'
>
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf/amlogic: Fix build error for x86_64 allmodconfig
https://git.kernel.org/will/c/9d1d5cb32314
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig
@ 2022-11-22 11:19 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2022-11-22 11:19 UTC (permalink / raw)
To: Jerome Brunet, Jiucheng Xu, Neil Armstrong, Mark Rutland,
Kevin Hilman, Martin Blumenstingl
Cc: catalin.marinas, kernel-team, Will Deacon, linux-amlogic,
Chris Healy, linux-kernel, Chris Healy, Kelvin Zhang,
Jianxin Pan, linux-arm-kernel
On Tue, 22 Nov 2022 16:40:28 +0800, Jiucheng Xu wrote:
> The driver misses including <linux/io.h>. It causes
> compiling error "implicit declaration of function
> 'readl' and 'writel'" when make X86_64 allmodconfig.
>
> Amlogic meson G12 SoC DDR PMU driver")'
>
>
> [...]
Applied to will (for-next/perf), thanks!
[1/1] perf/amlogic: Fix build error for x86_64 allmodconfig
https://git.kernel.org/will/c/9d1d5cb32314
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-22 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 8:40 [PATCH v2] perf/amlogic: Fix build error for x86_64 allmodconfig Jiucheng Xu
2022-11-22 8:40 ` Jiucheng Xu
2022-11-22 8:40 ` Jiucheng Xu
2022-11-22 11:19 ` Will Deacon
2022-11-22 11:19 ` Will Deacon
2022-11-22 11:19 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.