* [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask
@ 2022-12-04 9:47 Krzysztof Kozlowski
2022-12-04 9:47 ` [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-04 9:47 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Adrian Hunter,
Bhupesh Sharma, linux-mmc, devicetree, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, abel.vesa, Johan Hovold,
Krzysztof Kozlowski
The Linux SDHCI driver core reads 'sdhci-caps' and 'sdhci-caps-mask'
properties and few devices already use it (e.g. Qualcomm SM8450), so add
them to a shared SDHCI bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/mmc/sdhci-am654.yaml | 4 +--
.../devicetree/bindings/mmc/sdhci-common.yaml | 32 +++++++++++++++++++
.../devicetree/bindings/mmc/sdhci-msm.yaml | 2 +-
MAINTAINERS | 1 +
4 files changed, 35 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-common.yaml
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
index 382d5face49a..c4c73ee1422c 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
@@ -11,7 +11,7 @@ maintainers:
- Ulf Hansson <ulf.hansson@linaro.org>
allOf:
- - $ref: mmc-controller.yaml#
+ - $ref: sdhci-common.yaml#
properties:
compatible:
@@ -49,8 +49,6 @@ properties:
- const: clk_ahb
- const: clk_xin
- sdhci-caps-mask: true
-
dma-coherent:
type: boolean
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-common.yaml b/Documentation/devicetree/bindings/mmc/sdhci-common.yaml
new file mode 100644
index 000000000000..1664615187c8
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-common.yaml
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/sdhci-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SDHCI Controller Common Properties
+
+maintainers:
+ - Adrian Hunter <adrian.hunter@intel.com>
+
+description:
+ Common properties present on Secure Digital Host Controller Interface (SDHCI)
+ devices.
+
+properties:
+ sdhci-caps:
+ $ref: /schemas/types.yaml#/definitions/uint64
+ description:
+ Additionally present SDHCI capabilities - values for SDHCI_CAPABILITIES
+ and SDHCI_CAPABILITIES_1 registers.
+
+ sdhci-caps-mask:
+ $ref: /schemas/types.yaml#/definitions/uint64
+ description:
+ Masked SDHCI capabilities to remove from SDHCI_CAPABILITIES and
+ SDHCI_CAPABILITIES_1 registers.
+
+allOf:
+ - $ref: mmc-controller.yaml#
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index fade797af150..2736c9a79f65 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -169,7 +169,7 @@ required:
- interrupts
allOf:
- - $ref: mmc-controller.yaml#
+ - $ref: sdhci-common.yaml#
- if:
properties:
diff --git a/MAINTAINERS b/MAINTAINERS
index 3583c5f6889d..be71999cea73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18732,6 +18732,7 @@ SECURE DIGITAL HOST CONTROLLER INTERFACE (SDHCI) DRIVER
M: Adrian Hunter <adrian.hunter@intel.com>
L: linux-mmc@vger.kernel.org
S: Supported
+F: Documentation/devicetree/bindings/mmc/sdhci-common.yaml
F: drivers/mmc/host/sdhci*
SECURE DIGITAL HOST CONTROLLER INTERFACE (SDHCI) MICROCHIP DRIVER
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
@ 2022-12-04 9:47 ` Krzysztof Kozlowski
2022-12-05 22:08 ` Rob Herring
2022-12-04 9:47 ` [PATCH 3/5] dt-bindings: mmc: sdhci-msm: " Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-04 9:47 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Adrian Hunter,
Bhupesh Sharma, linux-mmc, devicetree, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, abel.vesa, Johan Hovold,
Krzysztof Kozlowski
Cleanup coding style without functional changes:
1. Drop unnecessary quotes from $ref.
2. Use simple enum for compatible enumeration and sort entries.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/mmc/sdhci-am654.yaml | 61 ++++++++++---------
1 file changed, 31 insertions(+), 30 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
index c4c73ee1422c..676a74695389 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
@@ -2,8 +2,8 @@
# Copyright (C) 2020 Texas Instruments Incorporated - http://www.ti.com/
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/mmc/sdhci-am654.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/mmc/sdhci-am654.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: TI AM654 MMC Controller
@@ -16,12 +16,13 @@ allOf:
properties:
compatible:
oneOf:
- - const: ti,am654-sdhci-5.1
- - const: ti,j721e-sdhci-8bit
- - const: ti,j721e-sdhci-4bit
- - const: ti,am64-sdhci-8bit
- - const: ti,am64-sdhci-4bit
- - const: ti,am62-sdhci
+ - enum:
+ - ti,am62-sdhci
+ - ti,am64-sdhci-4bit
+ - ti,am64-sdhci-8bit
+ - ti,am654-sdhci-5.1
+ - ti,j721e-sdhci-4bit
+ - ti,j721e-sdhci-8bit
- items:
- const: ti,j7200-sdhci-8bit
- const: ti,j721e-sdhci-8bit
@@ -59,67 +60,67 @@ properties:
ti,otap-del-sel-legacy:
description: Output tap delay for SD/MMC legacy timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-mmc-hs:
description: Output tap delay for MMC high speed timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-sd-hs:
description: Output tap delay for SD high speed timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-sdr12:
description: Output tap delay for SD UHS SDR12 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-sdr25:
description: Output tap delay for SD UHS SDR25 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-sdr50:
description: Output tap delay for SD UHS SDR50 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-sdr104:
description: Output tap delay for SD UHS SDR104 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-ddr50:
description: Output tap delay for SD UHS DDR50 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-ddr52:
description: Output tap delay for eMMC DDR52 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-hs200:
description: Output tap delay for eMMC HS200 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,otap-del-sel-hs400:
description: Output tap delay for eMMC HS400 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
@@ -129,55 +130,55 @@ properties:
ti,itap-del-sel-legacy:
description: Input tap delay for SD/MMC legacy timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-mmc-hs:
description: Input tap delay for MMC high speed timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-sd-hs:
description: Input tap delay for SD high speed timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-sdr12:
description: Input tap delay for SD UHS SDR12 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-sdr25:
description: Input tap delay for SD UHS SDR25 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-ddr50:
description: Input tap delay for MMC DDR50 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,itap-del-sel-ddr52:
description: Input tap delay for MMC DDR52 timing
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0x1f
ti,trm-icp:
description: DLL trim select
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 0xf
ti,driver-strength-ohm:
description: DLL drive strength in ohms
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
enum:
- 33
- 40
@@ -187,11 +188,11 @@ properties:
ti,strobe-sel:
description: strobe select delay for HS400 speed mode.
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
ti,clkbuf-sel:
description: Clock Delay Buffer Select
- $ref: "/schemas/types.yaml#/definitions/uint32"
+ $ref: /schemas/types.yaml#/definitions/uint32
ti,fails-without-test-cd:
$ref: /schemas/types.yaml#/definitions/flag
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] dt-bindings: mmc: sdhci-msm: cleanup style
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
2022-12-04 9:47 ` [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style Krzysztof Kozlowski
@ 2022-12-04 9:47 ` Krzysztof Kozlowski
2022-12-05 22:09 ` Rob Herring
2022-12-04 9:47 ` [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-04 9:47 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Adrian Hunter,
Bhupesh Sharma, linux-mmc, devicetree, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, abel.vesa, Johan Hovold,
Krzysztof Kozlowski
Drop unnecessary quotes from $ref.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 2736c9a79f65..9e7c0e3803c6 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -1,9 +1,8 @@
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-
%YAML 1.2
---
-$id: "http://devicetree.org/schemas/mmc/sdhci-msm.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/mmc/sdhci-msm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Qualcomm SDHCI controller (sdhci-msm)
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
2022-12-04 9:47 ` [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style Krzysztof Kozlowski
2022-12-04 9:47 ` [PATCH 3/5] dt-bindings: mmc: sdhci-msm: " Krzysztof Kozlowski
@ 2022-12-04 9:47 ` Krzysztof Kozlowski
2022-12-05 22:11 ` Rob Herring
2022-12-04 9:47 ` [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent Krzysztof Kozlowski
2022-12-05 22:08 ` [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Rob Herring
4 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-04 9:47 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Adrian Hunter,
Bhupesh Sharma, linux-mmc, devicetree, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, abel.vesa, Johan Hovold,
Krzysztof Kozlowski
There is no need to explicitly list properties already brought by
mmc-controller.yaml schema.
Fixes: 8574adf5222d ("dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 9e7c0e3803c6..39e303468bc4 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -136,16 +136,6 @@ properties:
description: A phandle to sdhci power domain node
maxItems: 1
- mmc-ddr-1_8v: true
-
- mmc-hs200-1_8v: true
-
- mmc-hs400-1_8v: true
-
- bus-width: true
-
- max-frequency: true
-
operating-points-v2: true
patternProperties:
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-12-04 9:47 ` [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC Krzysztof Kozlowski
@ 2022-12-04 9:47 ` Krzysztof Kozlowski
2022-12-05 22:11 ` Rob Herring
2022-12-07 12:37 ` Ulf Hansson
2022-12-05 22:08 ` [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Rob Herring
4 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-04 9:47 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Adrian Hunter,
Bhupesh Sharma, linux-mmc, devicetree, linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, abel.vesa, Johan Hovold,
Krzysztof Kozlowski
SM8350, SM8450 and SM8550 SDHCI controllers for SD card are marked with
dma-coherent, so allow it.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
dma-coherent was first added to SM8450... then to SM8350 (not merged
yet) and now it appeared in SM8550 patches, but I actually do not know
if this is copy-paste or real need.
---
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 39e303468bc4..6b89238f0565 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -83,6 +83,8 @@ properties:
- const: cal
- const: sleep
+ dma-coherent: true
+
interrupts:
maxItems: 2
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-12-04 9:47 ` [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent Krzysztof Kozlowski
@ 2022-12-05 22:08 ` Rob Herring
4 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-12-05 22:08 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: abel.vesa, linux-mmc, Johan Hovold, linux-kernel,
Bjorn Andersson, Ulf Hansson, Bhupesh Sharma, Rob Herring,
devicetree, Konrad Dybcio, Adrian Hunter, Krzysztof Kozlowski
On Sun, 04 Dec 2022 10:47:13 +0100, Krzysztof Kozlowski wrote:
> The Linux SDHCI driver core reads 'sdhci-caps' and 'sdhci-caps-mask'
> properties and few devices already use it (e.g. Qualcomm SM8450), so add
> them to a shared SDHCI bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/mmc/sdhci-am654.yaml | 4 +--
> .../devicetree/bindings/mmc/sdhci-common.yaml | 32 +++++++++++++++++++
> .../devicetree/bindings/mmc/sdhci-msm.yaml | 2 +-
> MAINTAINERS | 1 +
> 4 files changed, 35 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-common.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style
2022-12-04 9:47 ` [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style Krzysztof Kozlowski
@ 2022-12-05 22:08 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-12-05 22:08 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Johan Hovold, Bhupesh Sharma,
Bjorn Andersson, Adrian Hunter, linux-kernel, Rob Herring,
Ulf Hansson, linux-mmc, abel.vesa, devicetree, Konrad Dybcio
On Sun, 04 Dec 2022 10:47:14 +0100, Krzysztof Kozlowski wrote:
> Cleanup coding style without functional changes:
> 1. Drop unnecessary quotes from $ref.
> 2. Use simple enum for compatible enumeration and sort entries.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/mmc/sdhci-am654.yaml | 61 ++++++++++---------
> 1 file changed, 31 insertions(+), 30 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/5] dt-bindings: mmc: sdhci-msm: cleanup style
2022-12-04 9:47 ` [PATCH 3/5] dt-bindings: mmc: sdhci-msm: " Krzysztof Kozlowski
@ 2022-12-05 22:09 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-12-05 22:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Konrad Dybcio, linux-mmc, linux-kernel, Adrian Hunter,
Bhupesh Sharma, Krzysztof Kozlowski, Ulf Hansson, abel.vesa,
Bjorn Andersson, Johan Hovold, devicetree, Rob Herring
On Sun, 04 Dec 2022 10:47:15 +0100, Krzysztof Kozlowski wrote:
> Drop unnecessary quotes from $ref.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC
2022-12-04 9:47 ` [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC Krzysztof Kozlowski
@ 2022-12-05 22:11 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-12-05 22:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ulf Hansson, Krzysztof Kozlowski, Adrian Hunter, Bhupesh Sharma,
linux-mmc, devicetree, linux-kernel, Bjorn Andersson,
Konrad Dybcio, abel.vesa, Johan Hovold
On Sun, Dec 04, 2022 at 10:47:16AM +0100, Krzysztof Kozlowski wrote:
> There is no need to explicitly list properties already brought by
> mmc-controller.yaml schema.
>
> Fixes: 8574adf5222d ("dt-bindings: mmc: sdhci-msm: Fix issues in yaml bindings")
Redundant, but not broken.
With 'Fixes' dropped,
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent
2022-12-04 9:47 ` [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent Krzysztof Kozlowski
@ 2022-12-05 22:11 ` Rob Herring
2022-12-07 12:37 ` Ulf Hansson
1 sibling, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-12-05 22:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-mmc, abel.vesa, Ulf Hansson, linux-kernel,
Bhupesh Sharma, Krzysztof Kozlowski, devicetree, Konrad Dybcio,
Johan Hovold, Rob Herring, Adrian Hunter
On Sun, 04 Dec 2022 10:47:17 +0100, Krzysztof Kozlowski wrote:
> SM8350, SM8450 and SM8550 SDHCI controllers for SD card are marked with
> dma-coherent, so allow it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> dma-coherent was first added to SM8450... then to SM8350 (not merged
> yet) and now it appeared in SM8550 patches, but I actually do not know
> if this is copy-paste or real need.
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent
2022-12-04 9:47 ` [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent Krzysztof Kozlowski
2022-12-05 22:11 ` Rob Herring
@ 2022-12-07 12:37 ` Ulf Hansson
1 sibling, 0 replies; 11+ messages in thread
From: Ulf Hansson @ 2022-12-07 12:37 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Adrian Hunter, Bhupesh Sharma,
linux-mmc, devicetree, linux-kernel, Bjorn Andersson,
Konrad Dybcio, abel.vesa, Johan Hovold
On Sun, 4 Dec 2022 at 10:47, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> SM8350, SM8450 and SM8550 SDHCI controllers for SD card are marked with
> dma-coherent, so allow it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
All five patches applied from the series and by removing the fixes tag
from patch4/5, thanks!
Kind regards
Uffe
>
> ---
>
> dma-coherent was first added to SM8450... then to SM8350 (not merged
> yet) and now it appeared in SM8550 patches, but I actually do not know
> if this is copy-paste or real need.
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 39e303468bc4..6b89238f0565 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -83,6 +83,8 @@ properties:
> - const: cal
> - const: sleep
>
> + dma-coherent: true
> +
> interrupts:
> maxItems: 2
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-12-07 12:39 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-04 9:47 [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Krzysztof Kozlowski
2022-12-04 9:47 ` [PATCH 2/5] dt-bindings: mmc: sdhci-am654: cleanup style Krzysztof Kozlowski
2022-12-05 22:08 ` Rob Herring
2022-12-04 9:47 ` [PATCH 3/5] dt-bindings: mmc: sdhci-msm: " Krzysztof Kozlowski
2022-12-05 22:09 ` Rob Herring
2022-12-04 9:47 ` [PATCH 4/5] dt-bindings: mmc: sdhci-msm: drop properties mentioned in common MMC Krzysztof Kozlowski
2022-12-05 22:11 ` Rob Herring
2022-12-04 9:47 ` [PATCH 5/5] dt-bindings: mmc: sdhci-msm: allow dma-coherent Krzysztof Kozlowski
2022-12-05 22:11 ` Rob Herring
2022-12-07 12:37 ` Ulf Hansson
2022-12-05 22:08 ` [PATCH 1/5] dt-bindings: mmc: sdhci: document sdhci-caps and sdhci-caps-mask Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.