* [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-11-15 11:27 ` Pin-yen Lin
0 siblings, 0 replies; 12+ messages in thread
From: Pin-yen Lin @ 2022-11-15 11:27 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec
Cc: allen chen, linux-kernel, David Airlie, dri-devel, Daniel Vetter,
Pin-yen Lin
Add caching when EDID is read, and invalidate the cache until the
bridge detects HPD low or sink count changes on HPD_IRQ.
It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
one EDID read would be a notable difference on user experience.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
drivers/gpu/drm/bridge/ite-it6505.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 21a9b8422bda..4b818f31668f 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -457,6 +457,8 @@ struct it6505 {
/* it6505 driver hold option */
bool enable_drv_hold;
+
+ struct edid *cached_edid;
};
struct it6505_step_train_para {
@@ -2244,6 +2246,13 @@ static void it6505_plugged_status_to_codec(struct it6505 *it6505)
status == connector_status_connected);
}
+
+static void it6505_remove_edid(struct it6505 *it6505)
+{
+ kfree(it6505->cached_edid);
+ it6505->cached_edid = NULL;
+}
+
static int it6505_process_hpd_irq(struct it6505 *it6505)
{
struct device *dev = &it6505->client->dev;
@@ -2270,6 +2279,7 @@ static int it6505_process_hpd_irq(struct it6505 *it6505)
it6505_reset_logic(it6505);
it6505_int_mask_enable(it6505);
it6505_init(it6505);
+ it6505_remove_edid(it6505);
return 0;
}
@@ -2353,6 +2363,7 @@ static void it6505_irq_hpd(struct it6505 *it6505)
it6505_video_reset(it6505);
} else {
memset(it6505->dpcd, 0, sizeof(it6505->dpcd));
+ it6505_remove_edid(it6505);
if (it6505->hdcp_desired)
it6505_stop_hdcp(it6505);
@@ -3016,16 +3027,18 @@ static struct edid *it6505_bridge_get_edid(struct drm_bridge *bridge,
{
struct it6505 *it6505 = bridge_to_it6505(bridge);
struct device *dev = &it6505->client->dev;
- struct edid *edid;
- edid = drm_do_get_edid(connector, it6505_get_edid_block, it6505);
+ if (!it6505->cached_edid) {
+ it6505->cached_edid = drm_do_get_edid(connector, it6505_get_edid_block,
+ it6505);
- if (!edid) {
- DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
- return NULL;
+ if (!it6505->cached_edid) {
+ DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
+ return NULL;
+ }
}
- return edid;
+ return drm_edid_duplicate(it6505->cached_edid);
}
static const struct drm_bridge_funcs it6505_bridge_funcs = {
@@ -3367,6 +3380,7 @@ static void it6505_i2c_remove(struct i2c_client *client)
drm_dp_aux_unregister(&it6505->aux);
it6505_debugfs_remove(it6505);
it6505_poweroff(it6505);
+ it6505_remove_edid(it6505);
}
static const struct i2c_device_id it6505_id[] = {
--
2.38.1.493.g58b659f92b-goog
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
2022-11-15 11:27 ` Pin-yen Lin
@ 2022-12-13 15:51 ` Robert Foss
-1 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-13 15:51 UTC (permalink / raw)
To: Pin-yen Lin
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, allen chen, linux-kernel, David Airlie,
dri-devel, Daniel Vetter
On Tue, 15 Nov 2022 at 12:27, Pin-yen Lin <treapking@chromium.org> wrote:
>
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
>
> ---
>
> drivers/gpu/drm/bridge/ite-it6505.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 21a9b8422bda..4b818f31668f 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -457,6 +457,8 @@ struct it6505 {
>
> /* it6505 driver hold option */
> bool enable_drv_hold;
> +
> + struct edid *cached_edid;
> };
>
> struct it6505_step_train_para {
> @@ -2244,6 +2246,13 @@ static void it6505_plugged_status_to_codec(struct it6505 *it6505)
> status == connector_status_connected);
> }
>
> +
> +static void it6505_remove_edid(struct it6505 *it6505)
> +{
> + kfree(it6505->cached_edid);
> + it6505->cached_edid = NULL;
> +}
> +
> static int it6505_process_hpd_irq(struct it6505 *it6505)
> {
> struct device *dev = &it6505->client->dev;
> @@ -2270,6 +2279,7 @@ static int it6505_process_hpd_irq(struct it6505 *it6505)
> it6505_reset_logic(it6505);
> it6505_int_mask_enable(it6505);
> it6505_init(it6505);
> + it6505_remove_edid(it6505);
> return 0;
> }
>
> @@ -2353,6 +2363,7 @@ static void it6505_irq_hpd(struct it6505 *it6505)
> it6505_video_reset(it6505);
> } else {
> memset(it6505->dpcd, 0, sizeof(it6505->dpcd));
> + it6505_remove_edid(it6505);
>
> if (it6505->hdcp_desired)
> it6505_stop_hdcp(it6505);
> @@ -3016,16 +3027,18 @@ static struct edid *it6505_bridge_get_edid(struct drm_bridge *bridge,
> {
> struct it6505 *it6505 = bridge_to_it6505(bridge);
> struct device *dev = &it6505->client->dev;
> - struct edid *edid;
>
> - edid = drm_do_get_edid(connector, it6505_get_edid_block, it6505);
> + if (!it6505->cached_edid) {
> + it6505->cached_edid = drm_do_get_edid(connector, it6505_get_edid_block,
> + it6505);
>
> - if (!edid) {
> - DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
> - return NULL;
> + if (!it6505->cached_edid) {
> + DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
> + return NULL;
> + }
> }
>
> - return edid;
> + return drm_edid_duplicate(it6505->cached_edid);
> }
>
> static const struct drm_bridge_funcs it6505_bridge_funcs = {
> @@ -3367,6 +3380,7 @@ static void it6505_i2c_remove(struct i2c_client *client)
> drm_dp_aux_unregister(&it6505->aux);
> it6505_debugfs_remove(it6505);
> it6505_poweroff(it6505);
> + it6505_remove_edid(it6505);
> }
>
> static const struct i2c_device_id it6505_id[] = {
> --
> 2.38.1.493.g58b659f92b-goog
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-12-13 15:51 ` Robert Foss
0 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-13 15:51 UTC (permalink / raw)
To: Pin-yen Lin
Cc: Neil Armstrong, Jonas Karlman, allen chen, dri-devel,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda
On Tue, 15 Nov 2022 at 12:27, Pin-yen Lin <treapking@chromium.org> wrote:
>
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
>
> ---
>
> drivers/gpu/drm/bridge/ite-it6505.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 21a9b8422bda..4b818f31668f 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -457,6 +457,8 @@ struct it6505 {
>
> /* it6505 driver hold option */
> bool enable_drv_hold;
> +
> + struct edid *cached_edid;
> };
>
> struct it6505_step_train_para {
> @@ -2244,6 +2246,13 @@ static void it6505_plugged_status_to_codec(struct it6505 *it6505)
> status == connector_status_connected);
> }
>
> +
> +static void it6505_remove_edid(struct it6505 *it6505)
> +{
> + kfree(it6505->cached_edid);
> + it6505->cached_edid = NULL;
> +}
> +
> static int it6505_process_hpd_irq(struct it6505 *it6505)
> {
> struct device *dev = &it6505->client->dev;
> @@ -2270,6 +2279,7 @@ static int it6505_process_hpd_irq(struct it6505 *it6505)
> it6505_reset_logic(it6505);
> it6505_int_mask_enable(it6505);
> it6505_init(it6505);
> + it6505_remove_edid(it6505);
> return 0;
> }
>
> @@ -2353,6 +2363,7 @@ static void it6505_irq_hpd(struct it6505 *it6505)
> it6505_video_reset(it6505);
> } else {
> memset(it6505->dpcd, 0, sizeof(it6505->dpcd));
> + it6505_remove_edid(it6505);
>
> if (it6505->hdcp_desired)
> it6505_stop_hdcp(it6505);
> @@ -3016,16 +3027,18 @@ static struct edid *it6505_bridge_get_edid(struct drm_bridge *bridge,
> {
> struct it6505 *it6505 = bridge_to_it6505(bridge);
> struct device *dev = &it6505->client->dev;
> - struct edid *edid;
>
> - edid = drm_do_get_edid(connector, it6505_get_edid_block, it6505);
> + if (!it6505->cached_edid) {
> + it6505->cached_edid = drm_do_get_edid(connector, it6505_get_edid_block,
> + it6505);
>
> - if (!edid) {
> - DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
> - return NULL;
> + if (!it6505->cached_edid) {
> + DRM_DEV_DEBUG_DRIVER(dev, "failed to get edid!");
> + return NULL;
> + }
> }
>
> - return edid;
> + return drm_edid_duplicate(it6505->cached_edid);
> }
>
> static const struct drm_bridge_funcs it6505_bridge_funcs = {
> @@ -3367,6 +3380,7 @@ static void it6505_i2c_remove(struct i2c_client *client)
> drm_dp_aux_unregister(&it6505->aux);
> it6505_debugfs_remove(it6505);
> it6505_poweroff(it6505);
> + it6505_remove_edid(it6505);
> }
>
> static const struct i2c_device_id it6505_id[] = {
> --
> 2.38.1.493.g58b659f92b-goog
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
2022-11-15 11:27 ` Pin-yen Lin
@ 2022-12-14 16:51 ` Robert Foss
-1 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-14 16:51 UTC (permalink / raw)
To: Neil Armstrong, Jonas Karlman, Laurent Pinchart, Jernej Skrabec,
Pin-yen Lin, Andrzej Hajda
Cc: Robert Foss, David Airlie, Daniel Vetter, allen chen,
linux-kernel, dri-devel
On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
>
> [...]
Applied, thanks!
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[1/1] drm/bridge: it6505: Add caching for EDID
(no commit info)
rob
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-12-14 16:51 ` Robert Foss
0 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-14 16:51 UTC (permalink / raw)
To: Neil Armstrong, Jonas Karlman, Laurent Pinchart, Jernej Skrabec,
Pin-yen Lin, Andrzej Hajda
Cc: allen chen, linux-kernel, dri-devel, Robert Foss
On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
>
> [...]
Applied, thanks!
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[1/1] drm/bridge: it6505: Add caching for EDID
(no commit info)
rob
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
2022-12-14 16:51 ` Robert Foss
@ 2022-12-15 8:36 ` Pin-yen Lin
-1 siblings, 0 replies; 12+ messages in thread
From: Pin-yen Lin @ 2022-12-15 8:36 UTC (permalink / raw)
To: Robert Foss
Cc: Neil Armstrong, Jonas Karlman, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, David Airlie, Daniel Vetter, allen chen,
linux-kernel, dri-devel
Hi Robert,
Thanks for the review.
I didn't see this patch on drm-misc-next, but my another patch merged
instead: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5eb9a4314053bda7642643f70f49a2b415920812
Did something go wrong? Or is it me missing something?
Regards,
Pin-yen
On Thu, Dec 15, 2022 at 12:51 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> > Add caching when EDID is read, and invalidate the cache until the
> > bridge detects HPD low or sink count changes on HPD_IRQ.
> >
> > It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> > one EDID read would be a notable difference on user experience.
> >
> >
> > [...]
>
> Applied, thanks!
>
> Repo: https://cgit.freedesktop.org/drm/drm-misc/
>
>
> [1/1] drm/bridge: it6505: Add caching for EDID
> (no commit info)
>
>
>
> rob
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-12-15 8:36 ` Pin-yen Lin
0 siblings, 0 replies; 12+ messages in thread
From: Pin-yen Lin @ 2022-12-15 8:36 UTC (permalink / raw)
To: Robert Foss
Cc: Neil Armstrong, Jonas Karlman, allen chen, dri-devel,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda
Hi Robert,
Thanks for the review.
I didn't see this patch on drm-misc-next, but my another patch merged
instead: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5eb9a4314053bda7642643f70f49a2b415920812
Did something go wrong? Or is it me missing something?
Regards,
Pin-yen
On Thu, Dec 15, 2022 at 12:51 AM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> > Add caching when EDID is read, and invalidate the cache until the
> > bridge detects HPD low or sink count changes on HPD_IRQ.
> >
> > It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> > one EDID read would be a notable difference on user experience.
> >
> >
> > [...]
>
> Applied, thanks!
>
> Repo: https://cgit.freedesktop.org/drm/drm-misc/
>
>
> [1/1] drm/bridge: it6505: Add caching for EDID
> (no commit info)
>
>
>
> rob
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
2022-12-15 8:36 ` Pin-yen Lin
@ 2022-12-15 10:29 ` Robert Foss
-1 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-15 10:29 UTC (permalink / raw)
To: Pin-yen Lin
Cc: Neil Armstrong, Jonas Karlman, Laurent Pinchart, Jernej Skrabec,
Andrzej Hajda, David Airlie, Daniel Vetter, allen chen,
linux-kernel, dri-devel
On Thu, 15 Dec 2022 at 09:36, Pin-yen Lin <treapking@chromium.org> wrote:
>
> Hi Robert,
>
> Thanks for the review.
>
> I didn't see this patch on drm-misc-next, but my another patch merged
> instead: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5eb9a4314053bda7642643f70f49a2b415920812
>
> Did something go wrong? Or is it me missing something?
This is my mistake. I'm switching to a 'b4 ty' based workflow, and the
wrong thank you message got sent out.
Let me have a look at this patch too.
>
> Regards,
> Pin-yen
>
> On Thu, Dec 15, 2022 at 12:51 AM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> > > Add caching when EDID is read, and invalidate the cache until the
> > > bridge detects HPD low or sink count changes on HPD_IRQ.
> > >
> > > It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> > > one EDID read would be a notable difference on user experience.
> > >
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > Repo: https://cgit.freedesktop.org/drm/drm-misc/
> >
> >
> > [1/1] drm/bridge: it6505: Add caching for EDID
> > (no commit info)
> >
> >
> >
> > rob
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-12-15 10:29 ` Robert Foss
0 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-15 10:29 UTC (permalink / raw)
To: Pin-yen Lin
Cc: Neil Armstrong, Jonas Karlman, allen chen, dri-devel,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda
On Thu, 15 Dec 2022 at 09:36, Pin-yen Lin <treapking@chromium.org> wrote:
>
> Hi Robert,
>
> Thanks for the review.
>
> I didn't see this patch on drm-misc-next, but my another patch merged
> instead: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5eb9a4314053bda7642643f70f49a2b415920812
>
> Did something go wrong? Or is it me missing something?
This is my mistake. I'm switching to a 'b4 ty' based workflow, and the
wrong thank you message got sent out.
Let me have a look at this patch too.
>
> Regards,
> Pin-yen
>
> On Thu, Dec 15, 2022 at 12:51 AM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> > > Add caching when EDID is read, and invalidate the cache until the
> > > bridge detects HPD low or sink count changes on HPD_IRQ.
> > >
> > > It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> > > one EDID read would be a notable difference on user experience.
> > >
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > Repo: https://cgit.freedesktop.org/drm/drm-misc/
> >
> >
> > [1/1] drm/bridge: it6505: Add caching for EDID
> > (no commit info)
> >
> >
> >
> > rob
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
2022-11-15 11:27 ` Pin-yen Lin
@ 2022-12-15 10:45 ` Robert Foss
-1 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-15 10:45 UTC (permalink / raw)
To: Laurent Pinchart, Andrzej Hajda, Pin-yen Lin, Neil Armstrong,
Jonas Karlman, Jernej Skrabec
Cc: Robert Foss, David Airlie, Daniel Vetter, linux-kernel,
allen chen, dri-devel
On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
>
> [...]
Applied, thanks!
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[1/1] drm/bridge: it6505: Add caching for EDID
commit: 11feaef69d0cb81278294299bbfd86f94c2004e3
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/bridge: it6505: Add caching for EDID
@ 2022-12-15 10:45 ` Robert Foss
0 siblings, 0 replies; 12+ messages in thread
From: Robert Foss @ 2022-12-15 10:45 UTC (permalink / raw)
To: Laurent Pinchart, Andrzej Hajda, Pin-yen Lin, Neil Armstrong,
Jonas Karlman, Jernej Skrabec
Cc: allen chen, linux-kernel, dri-devel, Robert Foss
On Tue, 15 Nov 2022 19:27:20 +0800, Pin-yen Lin wrote:
> Add caching when EDID is read, and invalidate the cache until the
> bridge detects HPD low or sink count changes on HPD_IRQ.
>
> It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping
> one EDID read would be a notable difference on user experience.
>
>
> [...]
Applied, thanks!
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[1/1] drm/bridge: it6505: Add caching for EDID
commit: 11feaef69d0cb81278294299bbfd86f94c2004e3
Rob
^ permalink raw reply [flat|nested] 12+ messages in thread