* [PATCH] io_uring: remove excessive unlikely on IS_ERR
@ 2023-01-09 18:58 Dmitrii Bundin
2023-01-09 23:14 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Dmitrii Bundin @ 2023-01-09 18:58 UTC (permalink / raw)
To: axboe, asml.silence; +Cc: io-uring, linux-kernel, Dmitrii Bundin
The IS_ERR function uses the IS_ERR_VALUE macro under the hood which
already wraps the condition into unlikely.
Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
---
io_uring/rw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/rw.c b/io_uring/rw.c
index 8227af2e1c0f..27d5e3323a53 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -410,7 +410,7 @@ static inline int io_import_iovec(int rw, struct io_kiocb *req,
unsigned int issue_flags)
{
*iovec = __io_import_iovec(rw, req, s, issue_flags);
- if (unlikely(IS_ERR(*iovec)))
+ if (IS_ERR(*iovec))
return PTR_ERR(*iovec);
iov_iter_save_state(&s->iter, &s->iter_state);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring: remove excessive unlikely on IS_ERR
2023-01-09 18:58 [PATCH] io_uring: remove excessive unlikely on IS_ERR Dmitrii Bundin
@ 2023-01-09 23:14 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2023-01-09 23:14 UTC (permalink / raw)
To: asml.silence, Dmitrii Bundin; +Cc: io-uring, linux-kernel
On Mon, 09 Jan 2023 21:58:54 +0300, Dmitrii Bundin wrote:
> The IS_ERR function uses the IS_ERR_VALUE macro under the hood which
> already wraps the condition into unlikely.
>
>
Applied, thanks!
[1/1] io_uring: remove excessive unlikely on IS_ERR
commit: 119fda37c54736ea65a669273d0b3c394c99a75c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-09 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 18:58 [PATCH] io_uring: remove excessive unlikely on IS_ERR Dmitrii Bundin
2023-01-09 23:14 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.