* [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
@ 2023-01-12 9:41 Chaitanya Kumar Borah
2023-01-12 14:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Chaitanya Kumar Borah @ 2023-01-12 9:41 UTC (permalink / raw)
To: intel-gfx
Fix typo for reference clock from 24400 to 24000
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 0c107a38f9d0..7e16b655c833 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = {
{ .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
{ .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
{ .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
- { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
+ { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
{ .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
{ .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix typo for reference clock
2023-01-12 9:41 [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock Chaitanya Kumar Borah
@ 2023-01-12 14:59 ` Patchwork
2023-01-12 17:40 ` [Intel-gfx] [PATCH] " Matt Roper
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-12 14:59 UTC (permalink / raw)
To: Borah, Chaitanya Kumar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7047 bytes --]
== Series Details ==
Series: drm/i915/display: Fix typo for reference clock
URL : https://patchwork.freedesktop.org/series/112729/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12575 -> Patchwork_112729v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/index.html
Participating hosts (34 -> 34)
------------------------------
Additional (1): fi-rkl-11600
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_112729v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@debugfs_test@basic-hwmon.html
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#7561])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][6] -> [DMESG-FAIL][7] ([i915#5334])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][8] ([i915#4817])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][9] ([i915#7828])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_chamelium_hpd@dp-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#7828]) +7 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@kms_chamelium_hpd@dp-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#4103])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([fdo#109285] / [i915#4098])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([i915#1072]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-snb-2600: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-snb-2600/igt@kms_setmode@basic-clone-single-crtc.html
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#3555] / [i915#4098])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#3301] / [i915#3708])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [INCOMPLETE][18] ([i915#4983]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12575 -> Patchwork_112729v1
CI-20190529: 20190529
CI_DRM_12575: 52754fc9f57a4e13ccd1ce908d5d86219121e1b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7117: 67669415954a763e2d1aa1bed6ef3786c0d17807 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112729v1: 52754fc9f57a4e13ccd1ce908d5d86219121e1b9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
55abd1995392 drm/i915/display: Fix typo for reference clock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/index.html
[-- Attachment #2: Type: text/html, Size: 8269 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-12 9:41 [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock Chaitanya Kumar Borah
2023-01-12 14:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-01-12 17:40 ` Matt Roper
2023-01-12 17:43 ` Matt Roper
2023-01-30 11:58 ` Jani Nikula
2023-01-12 19:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-01-16 9:12 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 2 replies; 10+ messages in thread
From: Matt Roper @ 2023-01-12 17:40 UTC (permalink / raw)
To: Chaitanya Kumar Borah; +Cc: intel-gfx
On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> Fix typo for reference clock from 24400 to 24000
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 0c107a38f9d0..7e16b655c833 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = {
> { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
>
> { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
> --
> 2.25.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-12 17:40 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2023-01-12 17:43 ` Matt Roper
2023-01-30 11:58 ` Jani Nikula
1 sibling, 0 replies; 10+ messages in thread
From: Matt Roper @ 2023-01-12 17:43 UTC (permalink / raw)
To: Chaitanya Kumar Borah; +Cc: intel-gfx
On Thu, Jan 12, 2023 at 09:40:42AM -0800, Matt Roper wrote:
> On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> > Fix typo for reference clock from 24400 to 24000
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>
> Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Oh, I guess one suggestion (which can be made while applying; no need to
re-send): it would be better to use a "drm/i915/adlp" prefix rather than
"drm/i915/display" since this is a platform-specific change.
Matt
>
> > ---
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index 0c107a38f9d0..7e16b655c833 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = {
> > { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> > { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> > { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> > - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> > + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >
> > { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> > { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
> > --
> > 2.25.1
> >
>
> --
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix typo for reference clock
2023-01-12 9:41 [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock Chaitanya Kumar Borah
2023-01-12 14:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-01-12 17:40 ` [Intel-gfx] [PATCH] " Matt Roper
@ 2023-01-12 19:41 ` Patchwork
2023-01-16 9:12 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-12 19:41 UTC (permalink / raw)
To: Borah, Chaitanya Kumar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 21050 bytes --]
== Series Details ==
Series: drm/i915/display: Fix typo for reference clock
URL : https://patchwork.freedesktop.org/series/112729/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12575_full -> Patchwork_112729v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/index.html
Participating hosts (14 -> 11)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Known issues
------------
Here are the changes found in Patchwork_112729v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-glk2/igt@gem_exec_fair@basic-throttle@rcs0.html
#### Possible fixes ####
* igt@drm_fdinfo@idle@rcs0:
- {shard-rkl}: [FAIL][3] ([i915#7742]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-2/igt@drm_fdinfo@idle@rcs0.html
* igt@drm_read@invalid-buffer:
- {shard-tglu}: [SKIP][5] ([i915#1845]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@drm_read@invalid-buffer.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-5/igt@drm_read@invalid-buffer.html
* igt@fbdev@info:
- {shard-rkl}: [SKIP][7] ([i915#2582]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-2/igt@fbdev@info.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-6/igt@fbdev@info.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][9] ([i915#6268]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][11] ([i915#7052]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-3/igt@gem_eio@suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-2/igt@gem_eio@suspend.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#2842]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@gem_exec_fair@basic-none-share@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- {shard-rkl}: [SKIP][15] ([fdo#109313]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][17] ([i915#3281]) -> [PASS][18] +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-tglu}: [SKIP][19] ([i915#1850]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@gem_mmap_wc@set-cache-level.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@gem_mmap_wc@set-cache-level.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][21] ([i915#3282]) -> [PASS][22] +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-1/igt@gem_partial_pwrite_pread@writes-after-reads.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][23] ([i915#2527]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@gen9_exec_parse@bb-start-out.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: [SKIP][25] ([i915#658]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-2/igt@i915_pm_dc@dc5-psr.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][27] ([i915#1937]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-dg1-17/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-dg1-14/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-tglu}: [SKIP][29] ([i915#1397]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-dg1}: [SKIP][31] ([i915#1397]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-dg1-14/igt@i915_pm_rpm@dpms-non-lpsp.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-dg1-17/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-rkl}: [FAIL][33] ([fdo#103375]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-3/igt@i915_suspend@fence-restore-tiled2untiled.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-2/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- {shard-tglu}: [SKIP][35] ([i915#1845] / [i915#7651]) -> [PASS][36] +5 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
- {shard-tglu}: [SKIP][37] ([i915#1849]) -> [PASS][38] +7 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- {shard-rkl}: [SKIP][39] ([i915#1849] / [i915#4098]) -> [PASS][40] +9 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-tglu}: [SKIP][41] ([i915#1849] / [i915#3558]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@kms_plane@pixel-format@pipe-b-planes.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@kms_plane@pixel-format@pipe-b-planes.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][43] ([i915#1072]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-2/igt@kms_psr@sprite_mmap_gtt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_rotation_crc@exhaust-fences:
- {shard-rkl}: [SKIP][45] ([i915#1845] / [i915#4098]) -> [PASS][46] +13 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-1/igt@kms_rotation_crc@exhaust-fences.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-6/igt@kms_rotation_crc@exhaust-fences.html
* igt@kms_universal_plane@universal-plane-pipe-a-sanity:
- {shard-tglu}: [SKIP][47] ([fdo#109274]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-5/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- {shard-tglu}: [SKIP][49] ([i915#7651]) -> [PASS][50] +11 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-tglu-6/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-tglu-7/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][51] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@prime_vgem@basic-write.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@prime_vgem@basic-write.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][53] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-6/igt@prime_vgem@coherency-gtt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
* igt@sysfs_heartbeat_interval@precise@vecs0:
- {shard-rkl}: [FAIL][55] ([i915#1755]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12575/shard-rkl-2/igt@sysfs_heartbeat_interval@precise@vecs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/shard-rkl-4/igt@sysfs_heartbeat_interval@precise@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7679]: https://gitlab.freedesktop.org/drm/intel/issues/7679
[i915#7681]: https://gitlab.freedesktop.org/drm/intel/issues/7681
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12575 -> Patchwork_112729v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12575: 52754fc9f57a4e13ccd1ce908d5d86219121e1b9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7117: 67669415954a763e2d1aa1bed6ef3786c0d17807 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112729v1: 52754fc9f57a4e13ccd1ce908d5d86219121e1b9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112729v1/index.html
[-- Attachment #2: Type: text/html, Size: 15470 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-12 9:41 [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock Chaitanya Kumar Borah
` (2 preceding siblings ...)
2023-01-12 19:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
@ 2023-01-16 9:12 ` Jani Nikula
2023-01-16 9:16 ` Borah, Chaitanya Kumar
2023-01-16 9:33 ` Borah, Chaitanya Kumar
3 siblings, 2 replies; 10+ messages in thread
From: Jani Nikula @ 2023-01-16 9:12 UTC (permalink / raw)
To: Chaitanya Kumar Borah, intel-gfx
On Thu, 12 Jan 2023, Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> wrote:
> Fix typo for reference clock from 24400 to 24000
Is there a bug report? What's the impact?
It's obvious and easy to say there's a typo, but the harder part is
matching this against observed faulty behaviour, and that's something
people will want to do to match bug reports and fixes.
BR,
Jani.
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index 0c107a38f9d0..7e16b655c833 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = {
> { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
>
> { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-16 9:12 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2023-01-16 9:16 ` Borah, Chaitanya Kumar
2023-01-16 9:33 ` Borah, Chaitanya Kumar
1 sibling, 0 replies; 10+ messages in thread
From: Borah, Chaitanya Kumar @ 2023-01-16 9:16 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
Hello Jani,
There are no bug reports for it. It was pointed out by Matt in another patch series.
https://patchwork.freedesktop.org/patch/517283/?series=111472&rev=3
Regards
Chaitanya
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, January 16, 2023 2:42 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
>
> On Thu, 12 Jan 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com> wrote:
> > Fix typo for reference clock from 24400 to 24000
>
> Is there a bug report? What's the impact?
>
> It's obvious and easy to say there's a typo, but the harder part is matching
> this against observed faulty behaviour, and that's something people will
> want to do to match bug reports and fixes.
>
> BR,
> Jani.
>
> >
> > Signed-off-by: Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index 0c107a38f9d0..7e16b655c833 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals
> adlp_cdclk_table[] = {
> > { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> > { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> > { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> > - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> > + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >
> > { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> > { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-16 9:12 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-01-16 9:16 ` Borah, Chaitanya Kumar
@ 2023-01-16 9:33 ` Borah, Chaitanya Kumar
1 sibling, 0 replies; 10+ messages in thread
From: Borah, Chaitanya Kumar @ 2023-01-16 9:33 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
Hello Jani,
Sorry about the previous mail. Replying in-line.
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, January 16, 2023 2:42 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
>
> On Thu, 12 Jan 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com> wrote:
> > Fix typo for reference clock from 24400 to 24000
>
> Is there a bug report? What's the impact?
>
> It's obvious and easy to say there's a typo, but the harder part is matching
> this against observed faulty behaviour, and that's something people will
> want to do to match bug reports and fixes.
>
There are no bug reports for it. It was pointed out by Matt in another patch series.
https://patchwork.freedesktop.org/patch/517283/?series=111472&rev=3
Regards
Chaitanya
> BR,
> Jani.
>
> >
> > Signed-off-by: Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index 0c107a38f9d0..7e16b655c833 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals
> adlp_cdclk_table[] = {
> > { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> > { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> > { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> > - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> > + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >
> > { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> > { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-12 17:40 ` [Intel-gfx] [PATCH] " Matt Roper
2023-01-12 17:43 ` Matt Roper
@ 2023-01-30 11:58 ` Jani Nikula
2023-01-30 17:56 ` Borah, Chaitanya Kumar
1 sibling, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2023-01-30 11:58 UTC (permalink / raw)
To: Matt Roper, Chaitanya Kumar Borah; +Cc: intel-gfx
On Thu, 12 Jan 2023, Matt Roper <matthew.d.roper@intel.com> wrote:
> On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
>> Fix typo for reference clock from 24400 to 24000
>>
>> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>
> Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Pushed to drm-intel-next, thanks for the patch and review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
>> index 0c107a38f9d0..7e16b655c833 100644
>> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
>> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
>> @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals adlp_cdclk_table[] = {
>> { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
>> { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
>> { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
>> - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
>> + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
>>
>> { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
>> { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
>> --
>> 2.25.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock
2023-01-30 11:58 ` Jani Nikula
@ 2023-01-30 17:56 ` Borah, Chaitanya Kumar
0 siblings, 0 replies; 10+ messages in thread
From: Borah, Chaitanya Kumar @ 2023-01-30 17:56 UTC (permalink / raw)
To: Jani Nikula, Roper, Matthew D; +Cc: intel-gfx
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, January 30, 2023 5:29 PM
> To: Roper, Matthew D <matthew.d.roper@intel.com>; Borah, Chaitanya
> Kumar <chaitanya.kumar.borah@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference
> clock
>
> On Thu, 12 Jan 2023, Matt Roper <matthew.d.roper@intel.com> wrote:
> > On Thu, Jan 12, 2023 at 03:11:31PM +0530, Chaitanya Kumar Borah wrote:
> >> Fix typo for reference clock from 24400 to 24000
> >>
> >> Signed-off-by: Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com>
> >
> > Fixes: 626426ff9ce4 ("drm/i915/adl_p: Add cdclk support for ADL-P")
> > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> Pushed to drm-intel-next, thanks for the patch and review.
>
Thank you Jani.
Regards
Chaitanya
> BR,
> Jani.
>
> >
> >> ---
> >> drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c
> b/drivers/gpu/drm/i915/display/intel_cdclk.c
> >> index 0c107a38f9d0..7e16b655c833 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> >> @@ -1319,7 +1319,7 @@ static const struct intel_cdclk_vals
> adlp_cdclk_table[] = {
> >> { .refclk = 24000, .cdclk = 192000, .divider = 2, .ratio = 16 },
> >> { .refclk = 24000, .cdclk = 312000, .divider = 2, .ratio = 26 },
> >> { .refclk = 24000, .cdclk = 552000, .divider = 2, .ratio = 46 },
> >> - { .refclk = 24400, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >> + { .refclk = 24000, .cdclk = 648000, .divider = 2, .ratio = 54 },
> >>
> >> { .refclk = 38400, .cdclk = 179200, .divider = 3, .ratio = 14 },
> >> { .refclk = 38400, .cdclk = 192000, .divider = 2, .ratio = 10 },
> >> --
> >> 2.25.1
> >>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-30 17:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 9:41 [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference clock Chaitanya Kumar Borah
2023-01-12 14:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-01-12 17:40 ` [Intel-gfx] [PATCH] " Matt Roper
2023-01-12 17:43 ` Matt Roper
2023-01-30 11:58 ` Jani Nikula
2023-01-30 17:56 ` Borah, Chaitanya Kumar
2023-01-12 19:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-01-16 9:12 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-01-16 9:16 ` Borah, Chaitanya Kumar
2023-01-16 9:33 ` Borah, Chaitanya Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.