* [PATCH] block: Default to use cgroup support for BFQ
@ 2023-01-30 12:12 Ulf Hansson
2023-01-30 14:51 ` Linus Walleij
2023-01-30 16:42 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Ulf Hansson @ 2023-01-30 12:12 UTC (permalink / raw)
To: Jens Axboe, linux-block
Cc: Paolo Valente, Linus Walleij, linux-kernel, Ulf Hansson
Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
make it default y.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
block/Kconfig.iosched | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/Kconfig.iosched b/block/Kconfig.iosched
index 615516146086..27f11320b8d1 100644
--- a/block/Kconfig.iosched
+++ b/block/Kconfig.iosched
@@ -30,6 +30,7 @@ config IOSCHED_BFQ
config BFQ_GROUP_IOSCHED
bool "BFQ hierarchical scheduling support"
depends on IOSCHED_BFQ && BLK_CGROUP
+ default y
select BLK_CGROUP_RWSTAT
help
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Default to use cgroup support for BFQ
2023-01-30 12:12 [PATCH] block: Default to use cgroup support for BFQ Ulf Hansson
@ 2023-01-30 14:51 ` Linus Walleij
2023-01-30 16:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-01-30 14:51 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Jens Axboe, linux-block, Paolo Valente, linux-kernel
On Mon, Jan 30, 2023 at 1:12 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
> most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
> make it default y.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: Default to use cgroup support for BFQ
2023-01-30 12:12 [PATCH] block: Default to use cgroup support for BFQ Ulf Hansson
2023-01-30 14:51 ` Linus Walleij
@ 2023-01-30 16:42 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-01-30 16:42 UTC (permalink / raw)
To: linux-block, Ulf Hansson; +Cc: Paolo Valente, Linus Walleij, linux-kernel
On Mon, 30 Jan 2023 13:12:40 +0100, Ulf Hansson wrote:
> Assuming that both Kconfig options, BLK_CGROUP and IOSCHED_BFQ are set, we
> most likely want cgroup support for BFQ too (BFQ_GROUP_IOSCHED), so let's
> make it default y.
>
>
Applied, thanks!
[1/1] block: Default to use cgroup support for BFQ
commit: 4a6a7bc21d4726c5772e47525e6039852555b391
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-30 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30 12:12 [PATCH] block: Default to use cgroup support for BFQ Ulf Hansson
2023-01-30 14:51 ` Linus Walleij
2023-01-30 16:42 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.