* [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution
@ 2023-02-01 14:20 Nirmoy Das
2023-02-01 14:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Nirmoy Das @ 2023-02-01 14:20 UTC (permalink / raw)
To: igt-dev; +Cc: Chris Wilson, Nirmoy Das
From: Chris Wilson <chris.p.wilson@intel.com>
Make the no-bsd, no-blt, no-vebox tests also check that if the getparam does report
the engine, the ring selector rather than skipping.
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
tests/i915/gem_exec_params.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
index 618635ec3..3e06f2107 100644
--- a/tests/i915/gem_exec_params.c
+++ b/tests/i915/gem_exec_params.c
@@ -411,25 +411,26 @@ igt_main
igt_subtest("mmapped")
mmapped(fd);
-#define RUN_FAIL(expected_errno) do { \
- igt_assert_eq(__gem_execbuf(fd, &execbuf), -expected_errno); \
- } while(0)
-
igt_subtest("no-bsd") {
- igt_require(!gem_has_bsd(fd));
execbuf.flags = I915_EXEC_BSD;
- RUN_FAIL(EINVAL);
+ igt_assert_eq(__gem_execbuf(fd, &execbuf),
+ gem_has_bsd(fd) ? 0 : -EINVAL);
}
igt_subtest("no-blt") {
- igt_require(!gem_has_blt(fd));
execbuf.flags = I915_EXEC_BLT;
- RUN_FAIL(EINVAL);
+ igt_assert_eq(__gem_execbuf(fd, &execbuf),
+ gem_has_blt(fd) ? 0 : -EINVAL);
}
igt_subtest("no-vebox") {
- igt_require(!gem_has_vebox(fd));
execbuf.flags = I915_EXEC_VEBOX;
- RUN_FAIL(EINVAL);
+ igt_assert_eq(__gem_execbuf(fd, &execbuf),
+ gem_has_vebox(fd) ? 0 : -EINVAL);
}
+
+#define RUN_FAIL(expected_errno) do { \
+ igt_assert_eq(__gem_execbuf(fd, &execbuf), -expected_errno); \
+ } while(0)
+
igt_subtest("invalid-ring") {
execbuf.flags = I915_EXEC_RING_MASK;
RUN_FAIL(EINVAL);
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for i915/gem_exec_params: Cross-check getparam against engine execution
2023-02-01 14:20 [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
@ 2023-02-01 14:47 ` Patchwork
2023-02-01 15:56 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev2) Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-02-01 14:47 UTC (permalink / raw)
To: Nirmoy Das; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]
== Series Details ==
Series: i915/gem_exec_params: Cross-check getparam against engine execution
URL : https://patchwork.freedesktop.org/series/113556/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12678 -> IGTPW_8426
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8426 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8426, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8426/index.html
Participating hosts (26 -> 1)
------------------------------
ERROR: It appears as if the changes made in IGTPW_8426 prevented too many machines from booting.
Missing (25): fi-kbl-7567u bat-dg1-7 bat-kbl-2 bat-dg1-6 bat-dg1-5 bat-adlp-9 bat-adlp-6 fi-snb-2520m fi-glk-j4005 bat-rpls-1 fi-blb-e6850 bat-rpls-2 fi-skl-6600u bat-jsl-1 fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-kbl-guc bat-adln-1 fi-cfl-8109u bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick
Changes
-------
No changes found
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7143 -> IGTPW_8426
CI-20190529: 20190529
CI_DRM_12678: c19b23d9daab05a9107d661904743a0b15fe71ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8426: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8426/index.html
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8426/index.html
[-- Attachment #2: Type: text/html, Size: 2314 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev2)
2023-02-01 14:20 [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
2023-02-01 14:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2023-02-01 15:56 ` Patchwork
2023-02-01 16:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-02 15:41 ` [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Kamil Konieczny
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-02-01 15:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5378 bytes --]
== Series Details ==
Series: i915/gem_exec_params: Cross-check getparam against engine execution (rev2)
URL : https://patchwork.freedesktop.org/series/113556/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12678 -> IGTPW_8427
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
Participating hosts (26 -> 25)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8427:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: NOTRUN -> [DMESG-WARN][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@hangcheck:
- {bat-adln-1}: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/bat-adln-1/igt@i915_selftest@live@hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-adln-1/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@slpc:
- {bat-rpls-2}: NOTRUN -> [DMESG-FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@kms_force_connector_basic@force-edid:
- {bat-adlm-1}: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/bat-adlm-1/igt@kms_force_connector_basic@force-edid.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-adlm-1/igt@kms_force_connector_basic@force-edid.html
Known issues
------------
Here are the changes found in IGTPW_8427 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-bsw-nick: NOTRUN -> [SKIP][7] ([fdo#109271]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/fi-bsw-nick/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@dmabuf:
- fi-bsw-nick: [ABORT][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html
* igt@i915_selftest@live@guc:
- {bat-rpls-1}: [DMESG-WARN][10] ([i915#7852]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/bat-rpls-1/igt@i915_selftest@live@guc.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-rpls-1/igt@i915_selftest@live@guc.html
* igt@i915_selftest@live@requests:
- {bat-rplp-1}: [ABORT][12] ([i915#7913]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/bat-rplp-1/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-rplp-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [ABORT][14] ([i915#4983]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/bat-rpls-2/igt@i915_selftest@live@reset.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-kbl-7567u: [INCOMPLETE][16] ([i915#4817]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/fi-kbl-7567u/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7143 -> IGTPW_8427
CI-20190529: 20190529
CI_DRM_12678: c19b23d9daab05a9107d661904743a0b15fe71ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8427: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
[-- Attachment #2: Type: text/html, Size: 5768 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev2)
2023-02-01 14:20 [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
2023-02-01 14:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-02-01 15:56 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev2) Patchwork
@ 2023-02-01 16:56 ` Patchwork
2023-02-02 15:41 ` [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Kamil Konieczny
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-02-01 16:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 24161 bytes --]
== Series Details ==
Series: i915/gem_exec_params: Cross-check getparam against engine execution (rev2)
URL : https://patchwork.freedesktop.org/series/113556/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12678_full -> IGTPW_8427_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
Participating hosts (9 -> 10)
------------------------------
Additional (1): shard-tglu-9
Known issues
------------
Here are the changes found in IGTPW_8427_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk8/igt@gem_lmem_swapping@verify-ccs.html
* igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3886]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk5/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +69 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#658])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk6/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2437])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk6/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][8] -> [ABORT][9] ([i915#5213])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-glk8/igt@perf@stress-open-close.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk6/igt@perf@stress-open-close.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][10] ([i915#7742]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@fbdev@read:
- {shard-tglu}: [SKIP][12] ([i915#2582]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-tglu-6/igt@fbdev@read.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-tglu-5/igt@fbdev@read.html
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][14] ([i915#2582]) -> [PASS][15] +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@fbdev@unaligned-read.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@fbdev@unaligned-read.html
* igt@gem_ctx_persistence@hang:
- {shard-rkl}: [SKIP][16] ([i915#6252]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-5/igt@gem_ctx_persistence@hang.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-4/igt@gem_ctx_persistence@hang.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][18] ([i915#2842]) -> [PASS][19] +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@gem_exec_fair@basic-pace@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_params@no-blt:
- {shard-rkl}: [SKIP][20] ([fdo#109283]) -> [PASS][21] +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-2/igt@gem_exec_params@no-blt.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@gem_exec_params@no-blt.html
* igt@gem_exec_params@no-bsd:
- shard-glk: [SKIP][22] ([fdo#109271]) -> [PASS][23] +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-glk5/igt@gem_exec_params@no-bsd.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk5/igt@gem_exec_params@no-bsd.html
* igt@gem_exec_reloc@basic-gtt-cpu:
- {shard-rkl}: [SKIP][24] ([i915#3281]) -> [PASS][25] +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-3/igt@gem_exec_reloc@basic-gtt-cpu.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-cpu.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl}: [SKIP][26] ([i915#1850]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-3/igt@gem_mmap_wc@set-cache-level.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@gem_mmap_wc@set-cache-level.html
* igt@gem_pread@uncached:
- {shard-rkl}: [SKIP][28] ([i915#3282]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-3/igt@gem_pread@uncached.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@gem_pread@uncached.html
* igt@gen9_exec_parse@allowed-all:
- {shard-rkl}: [SKIP][30] ([i915#2527]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-3/igt@gen9_exec_parse@allowed-all.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@gen9_exec_parse@allowed-all.html
* igt@i915_hangman@engine-engine-error@bcs0:
- {shard-rkl}: [SKIP][32] ([i915#6258]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-5/igt@i915_hangman@engine-engine-error@bcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-3/igt@i915_hangman@engine-engine-error@bcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][34] ([i915#1397]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-2/igt@i915_pm_rpm@dpms-lpsp.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-dg1}: [SKIP][36] ([i915#1397]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-dg1-14/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-dg1-17/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- {shard-tglu}: [SKIP][38] ([i915#7651]) -> [PASS][39] +6 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-tglu-6/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-tglu-7/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][40] ([i915#79]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][42] ([i915#1849] / [i915#4098]) -> [PASS][43] +13 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-badstride.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
- {shard-tglu}: [SKIP][44] ([i915#1849]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-tglu-2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-rkl}: [SKIP][46] ([i915#1849]) -> [PASS][47] +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_psr@sprite_plane_move:
- {shard-rkl}: [SKIP][48] ([i915#1072]) -> [PASS][49] +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-1/igt@kms_psr@sprite_plane_move.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@kms_psr@sprite_plane_move.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- {shard-tglu}: [SKIP][50] ([fdo#109274]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-tglu-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-b.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-tglu-1/igt@kms_universal_plane@disable-primary-vs-flip-pipe-b.html
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- {shard-rkl}: [SKIP][52] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
* igt@kms_vblank@pipe-a-ts-continuation-idle:
- {shard-rkl}: [SKIP][54] ([i915#1845] / [i915#4098]) -> [PASS][55] +14 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@kms_vblank@pipe-a-ts-continuation-idle.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@kms_vblank@pipe-a-ts-continuation-idle.html
* igt@kms_vblank@pipe-a-ts-continuation-modeset-hang:
- {shard-tglu}: [SKIP][56] ([i915#1845] / [i915#7651]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-tglu-6/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-tglu-4/igt@kms_vblank@pipe-a-ts-continuation-modeset-hang.html
* igt@perf@gen12-mi-rpc:
- {shard-rkl}: [SKIP][58] ([fdo#109289]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-5/igt@perf@gen12-mi-rpc.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-3/igt@perf@gen12-mi-rpc.html
* igt@perf@mi-rpc:
- {shard-rkl}: [SKIP][60] ([i915#2434]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@perf@mi-rpc.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@perf@mi-rpc.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][62] ([i915#4349]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-4/igt@perf_pmu@idle@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-3/igt@perf_pmu@idle@rcs0.html
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][64] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-6/igt@prime_vgem@basic-fence-read.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-5/igt@prime_vgem@basic-fence-read.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][66] ([i915#4098]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12678/shard-rkl-5/igt@testdisplay.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7143 -> IGTPW_8427
CI-20190529: 20190529
CI_DRM_12678: c19b23d9daab05a9107d661904743a0b15fe71ef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8427: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8427/index.html
[-- Attachment #2: Type: text/html, Size: 18024 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution
2023-02-01 14:20 [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
` (2 preceding siblings ...)
2023-02-01 16:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-02-02 15:41 ` Kamil Konieczny
3 siblings, 0 replies; 5+ messages in thread
From: Kamil Konieczny @ 2023-02-02 15:41 UTC (permalink / raw)
To: igt-dev; +Cc: Chris Wilson, Nirmoy Das
Hi,
On 2023-02-01 at 15:20:26 +0100, Nirmoy Das wrote:
> From: Chris Wilson <chris.p.wilson@intel.com>
>
> Make the no-bsd, no-blt, no-vebox tests also check that if the getparam does report
----------------------------------------------------------- ^
This line is too long (86 chars), max is 75 chars but I prefer
65. Either way, please reformat this description.
> the engine, the ring selector rather than skipping.
------------- ^ - ^^^^ ^^^^^^^^ ^^^^^
This is unclear, I do not understand it. Please describe it better.
As I see it below, we either check for fail if it is not supported
or check for success if it is.
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> tests/i915/gem_exec_params.c | 21 +++++++++++----------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
> index 618635ec3..3e06f2107 100644
> --- a/tests/i915/gem_exec_params.c
> +++ b/tests/i915/gem_exec_params.c
> @@ -411,25 +411,26 @@ igt_main
> igt_subtest("mmapped")
> mmapped(fd);
>
> -#define RUN_FAIL(expected_errno) do { \
> - igt_assert_eq(__gem_execbuf(fd, &execbuf), -expected_errno); \
> - } while(0)
> -
You can keep macro if you add check function like:
#define CHK_RUN(has_check, expected_errno) do { \
igt_assert_eq(__gem_execbuf(fd, &execbuf), has_check(fd) ? 0 : -expected_errno); \
} while(0)
> igt_subtest("no-bsd") {
> - igt_require(!gem_has_bsd(fd));
> execbuf.flags = I915_EXEC_BSD;
> - RUN_FAIL(EINVAL);
> + igt_assert_eq(__gem_execbuf(fd, &execbuf),
> + gem_has_bsd(fd) ? 0 : -EINVAL);
Use it here as:
CHK_RUN(gem_has_bsd, EINVAL);
Regards,
Kamil
> }
> igt_subtest("no-blt") {
> - igt_require(!gem_has_blt(fd));
> execbuf.flags = I915_EXEC_BLT;
> - RUN_FAIL(EINVAL);
> + igt_assert_eq(__gem_execbuf(fd, &execbuf),
> + gem_has_blt(fd) ? 0 : -EINVAL);
> }
> igt_subtest("no-vebox") {
> - igt_require(!gem_has_vebox(fd));
> execbuf.flags = I915_EXEC_VEBOX;
> - RUN_FAIL(EINVAL);
> + igt_assert_eq(__gem_execbuf(fd, &execbuf),
> + gem_has_vebox(fd) ? 0 : -EINVAL);
> }
> +
> +#define RUN_FAIL(expected_errno) do { \
> + igt_assert_eq(__gem_execbuf(fd, &execbuf), -expected_errno); \
> + } while(0)
> +
> igt_subtest("invalid-ring") {
> execbuf.flags = I915_EXEC_RING_MASK;
> RUN_FAIL(EINVAL);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-02 15:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-01 14:20 [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Nirmoy Das
2023-02-01 14:47 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-02-01 15:56 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_exec_params: Cross-check getparam against engine execution (rev2) Patchwork
2023-02-01 16:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-02 15:41 ` [igt-dev] [PATCH i-g-t] i915/gem_exec_params: Cross-check getparam against engine execution Kamil Konieczny
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.