[PATCH bpf-next] selftests/bpf: Initialize tc in xdp_synproxy

[PATCH bpf-next] selftests/bpf: Initialize tc in xdp_synproxy

[Ilya Leoshkevich]

xdp_synproxy/xdp fails in CI with:

    Error: bpf_tc_hook_create: File exists

The XDP version of the test should not be calling bpf_tc_hook_create();
the reason it's happening anyway is that if we don't specify --tc on the
command line, tc variable remains uninitialized.

Fixes: 784d5dc0efc2 ("selftests/bpf: Add selftests for raw syncookie helpers in TC mode")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Reported-by: Joanne Koong <joannelkoong@gmail.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
 tools/testing/selftests/bpf/xdp_synproxy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/xdp_synproxy.c b/tools/testing/selftests/bpf/xdp_synproxy.c
index 410a1385a01d..6dbe0b745198 100644
--- a/tools/testing/selftests/bpf/xdp_synproxy.c
+++ b/tools/testing/selftests/bpf/xdp_synproxy.c
@@ -116,6 +116,7 @@ static void parse_options(int argc, char *argv[], unsigned int *ifindex, __u32 *
 	*tcpipopts = 0;
 	*ports = NULL;
 	*single = false;
+	*tc = false;
 
 	while (true) {
 		int opt;
-- 
2.39.1

Re: [PATCH bpf-next] selftests/bpf: Initialize tc in xdp_synproxy

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Fri,  3 Feb 2023 00:53:35 +0100 you wrote:
> xdp_synproxy/xdp fails in CI with:
> 
>     Error: bpf_tc_hook_create: File exists
> 
> The XDP version of the test should not be calling bpf_tc_hook_create();
> the reason it's happening anyway is that if we don't specify --tc on the
> command line, tc variable remains uninitialized.
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Initialize tc in xdp_synproxy
    https://git.kernel.org/bpf/bpf-next/c/354bb4a0e0b6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html