* [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes
@ 2023-02-03 8:42 Nidhi Gupta
2023-02-03 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nidhi Gupta @ 2023-02-03 8:42 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
As the test execution is taking more time on simulation, limit the
execution to two (first & last) pipes. This optimization is for
simulation only and hence there will be no impact on real hardware.
This patch will also provide an option (command line flag '-e') to
execute on all pipes.
Example: ./kms_pipe_crc_basic -e --run-subtest read-crc
V2: - Edited commit message (Bhanu)
V3: - New function for simulation constraints (Kamil)
- Update commit message (Bhanu)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_pipe_crc_basic.c | 45 +++++++++++++++++++++++++++++++++++++-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 91a1b8ab..376b9498 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -30,6 +30,9 @@
#include <string.h>
#include <fcntl.h>
+static bool extended = false;
+static enum pipe active_pipes[IGT_MAX_PIPES];
+static uint32_t last_pipe = 0;
typedef struct {
int drm_fd;
@@ -46,6 +49,16 @@ static struct {
{ .r = 0.0, .g = 1.0, .b = 1.0 },
};
+static bool simulation_constraint(enum pipe pipe)
+{
+ if (igt_run_in_simulation() && !extended &&
+ pipe != active_pipes[0] &&
+ pipe != active_pipes[last_pipe])
+ return true;
+
+ return false;
+}
+
static void test_bad_source(data_t *data)
{
errno = 0;
@@ -276,7 +289,23 @@ static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,
data_t data = {0, };
-igt_main
+static int opt_handler(int opt, int opt_index, void *_data)
+{
+ switch (opt) {
+ case 'e':
+ extended = true;
+ break;
+ default:
+ return IGT_OPT_HANDLER_ERROR;
+ }
+
+ return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+ " -e \tExtended tests.\n";
+
+igt_main_args("e", NULL, help_str, opt_handler, NULL)
{
enum pipe pipe;
igt_output_t *output;
@@ -312,6 +341,11 @@ igt_main
igt_require_pipe_crc(data.drm_fd);
data.debugfs = igt_debugfs_dir(data.drm_fd);
+
+ /* Get active pipes. */
+ for_each_pipe(&data.display, pipe)
+ active_pipes[last_pipe++] = pipe;
+ last_pipe--;
}
igt_describe("Tests error handling when the bad source is set.");
@@ -322,6 +356,9 @@ igt_main
igt_describe(tests[i].desc);
igt_subtest_with_dynamic(tests[i].name) {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
if (tests[i].flags & TEST_SUSPEND) {
test_read_crc(&data, pipe, output, 0);
@@ -350,6 +387,9 @@ igt_main
"does not cause issues.");
igt_subtest_with_dynamic("disable-crc-after-crtc") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
test_disable_crc_after_crtc(&data, pipe, output);
}
@@ -358,6 +398,9 @@ igt_main
igt_describe("Basic sanity check for CRC mismatches");
igt_subtest_with_dynamic("compare-crc-sanitycheck") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
test_compare_crc(&data, pipe, output);
}
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: Limit the execution to two pipes
2023-02-03 8:42 [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes Nidhi Gupta
@ 2023-02-03 13:19 ` Patchwork
2023-02-04 2:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-06 8:54 ` [igt-dev] [PATCH i-g-t] " Swati Sharma
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-02-03 13:19 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2658 bytes --]
== Series Details ==
Series: tests/kms_pipe_crc_basic: Limit the execution to two pipes
URL : https://patchwork.freedesktop.org/series/113635/
State : success
== Summary ==
CI Bug Log - changes from IGT_7146 -> IGTPW_8442
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
Participating hosts (25 -> 25)
------------------------------
Additional (1): fi-blb-e6850
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8442 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-blb-e6850: NOTRUN -> [SKIP][1] ([fdo#109271]) +51 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/fi-blb-e6850/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][2] -> [ABORT][3] ([i915#7911])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- {bat-jsl-1}: [DMESG-FAIL][4] ([i915#5334]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/bat-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7146 -> IGTPW_8442
CI-20190529: 20190529
CI_DRM_12688: 9fcffc218abe16fc5fbfca231fda6a7218661eb6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8442: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
IGT_7146: cfb2b835a2d688f123c9ffe5ecc7148e19e30e39 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
[-- Attachment #2: Type: text/html, Size: 3118 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_pipe_crc_basic: Limit the execution to two pipes
2023-02-03 8:42 [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes Nidhi Gupta
2023-02-03 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-02-04 2:31 ` Patchwork
2023-02-06 8:54 ` [igt-dev] [PATCH i-g-t] " Swati Sharma
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-02-04 2:31 UTC (permalink / raw)
To: Nidhi Gupta; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 23945 bytes --]
== Series Details ==
Series: tests/kms_pipe_crc_basic: Limit the execution to two pipes
URL : https://patchwork.freedesktop.org/series/113635/
State : success
== Summary ==
CI Bug Log - changes from IGT_7146_full -> IGTPW_8442_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
Participating hosts (11 -> 9)
------------------------------
Missing (2): shard-rkl0 shard-tglu-9
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8442_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_reloc@basic-wc-read:
- {shard-rkl}: [SKIP][1] ([i915#3281]) -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@gem_exec_reloc@basic-wc-read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-3/igt@gem_exec_reloc@basic-wc-read.html
Known issues
------------
Here are the changes found in IGTPW_8442_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk4/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][7] -> [ABORT][8] ([i915#5566])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk9/igt@gen9_exec_parse@allowed-single.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk7/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#72])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
#### Possible fixes ####
* igt@fbdev@eof:
- {shard-rkl}: [SKIP][13] ([i915#2582]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-2/igt@fbdev@eof.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@fbdev@eof.html
* igt@fbdev@info:
- {shard-tglu}: [SKIP][15] ([i915#2582]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@fbdev@info.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-2/igt@fbdev@info.html
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][17] ([i915#658]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-4/igt@feature_discovery@psr1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][19] ([i915#2846]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][21] ([i915#2842]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][23] ([i915#2842]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][25] ([i915#2842]) -> [PASS][26] +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read:
- {shard-rkl}: [SKIP][27] ([i915#3281]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-3/igt@gem_exec_reloc@basic-gtt-read.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl}: [SKIP][29] ([i915#1850]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@gem_mmap_wc@set-cache-level.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@gem_mmap_wc@set-cache-level.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][31] ([i915#3282]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-3/igt@gem_partial_pwrite_pread@writes-after-reads.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gen9_exec_parse@unaligned-jump:
- {shard-rkl}: [SKIP][33] ([i915#2527]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-6/igt@gen9_exec_parse@unaligned-jump.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@gen9_exec_parse@unaligned-jump.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- {shard-dg1}: [FAIL][35] ([i915#3591]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-dg1}: [SKIP][37] ([i915#1397]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-dg1-17/igt@i915_pm_rpm@dpms-lpsp.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-dg1-14/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][39] ([fdo#109308]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-3/igt@i915_pm_rpm@pm-tiling.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html
- {shard-tglu}: [SKIP][41] ([i915#3547]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@i915_pm_rpm@pm-tiling.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-7/igt@i915_pm_rpm@pm-tiling.html
* {igt@i915_power@sanity}:
- {shard-rkl}: [SKIP][43] ([i915#7984]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@i915_power@sanity.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-5/igt@i915_power@sanity.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- {shard-tglu}: [SKIP][45] ([i915#7651]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs:
- {shard-tglu}: [SKIP][47] ([i915#1845] / [i915#7651]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][49] ([i915#1845] / [i915#4098]) -> [PASS][50] +29 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][51] ([i915#2346]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- {shard-rkl}: [SKIP][53] ([i915#1849] / [i915#4098]) -> [PASS][54] +18 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-tglu}: [SKIP][55] ([i915#1849]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-7/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- {shard-tglu}: [SKIP][57] ([i915#1849] / [i915#3558]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-tglu-6/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-tglu-7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_plane@plane-position-hole-dpms@pipe-b-planes:
- {shard-rkl}: [SKIP][59] ([i915#1849]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-1/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@kms_plane@plane-position-hole-dpms@pipe-b-planes.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][61] ([i915#1072]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-5/igt@kms_psr@sprite_mmap_gtt.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][63] ([fdo#109289]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7146/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/shard-rkl-1/igt@perf@gen12-oa-tlb-invalidate.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7146 -> IGTPW_8442
CI-20190529: 20190529
CI_DRM_12688: 9fcffc218abe16fc5fbfca231fda6a7218661eb6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8442: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
IGT_7146: cfb2b835a2d688f123c9ffe5ecc7148e19e30e39 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8442/index.html
[-- Attachment #2: Type: text/html, Size: 16633 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes
2023-02-03 8:42 [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes Nidhi Gupta
2023-02-03 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-04 2:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-02-06 8:54 ` Swati Sharma
2 siblings, 0 replies; 4+ messages in thread
From: Swati Sharma @ 2023-02-06 8:54 UTC (permalink / raw)
To: Nidhi Gupta, igt-dev
Hi Nidhi,
Checkpatch is throwing following errors. Please fix.
ERROR: do not initialise statics to false
#42: FILE: tests/kms_pipe_crc_basic.c:33:
+static bool extended = false;
ERROR: do not initialise statics to 0
#44: FILE: tests/kms_pipe_crc_basic.c:35:
+static uint32_t last_pipe = 0;
ERROR: switch and case should be at the same indent
#72: FILE: tests/kms_pipe_crc_basic.c:294:
+ switch (opt) {
+ case 'e':
[...]
+ default:
total: 3 errors, 0 warnings, 87 lines checked
On 03-Feb-23 2:12 PM, Nidhi Gupta wrote:
> From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>
> As the test execution is taking more time on simulation, limit the
> execution to two (first & last) pipes. This optimization is for
> simulation only and hence there will be no impact on real hardware.
>
> This patch will also provide an option (command line flag '-e') to
> execute on all pipes.
>
> Example: ./kms_pipe_crc_basic -e --run-subtest read-crc
>
> V2: - Edited commit message (Bhanu)
> V3: - New function for simulation constraints (Kamil)
> - Update commit message (Bhanu)
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_pipe_crc_basic.c | 45 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 44 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index 91a1b8ab..376b9498 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -30,6 +30,9 @@
> #include <string.h>
> #include <fcntl.h>
>
> +static bool extended = false;
> +static enum pipe active_pipes[IGT_MAX_PIPES];
> +static uint32_t last_pipe = 0;
>
> typedef struct {
> int drm_fd;
> @@ -46,6 +49,16 @@ static struct {
> { .r = 0.0, .g = 1.0, .b = 1.0 },
> };
>
> +static bool simulation_constraint(enum pipe pipe)
> +{
> + if (igt_run_in_simulation() && !extended &&
> + pipe != active_pipes[0] &&
> + pipe != active_pipes[last_pipe])
> + return true;
> +
> + return false;
> +}
> +
> static void test_bad_source(data_t *data)
> {
> errno = 0;
> @@ -276,7 +289,23 @@ static void test_disable_crc_after_crtc(data_t *data, enum pipe pipe,
>
> data_t data = {0, };
>
> -igt_main
> +static int opt_handler(int opt, int opt_index, void *_data)
> +{
> + switch (opt) {
> + case 'e':
> + extended = true;
> + break;
> + default:
> + return IGT_OPT_HANDLER_ERROR;
> + }
> +
> + return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +const char *help_str =
> + " -e \tExtended tests.\n";
> +
> +igt_main_args("e", NULL, help_str, opt_handler, NULL)
> {
> enum pipe pipe;
> igt_output_t *output;
> @@ -312,6 +341,11 @@ igt_main
> igt_require_pipe_crc(data.drm_fd);
>
> data.debugfs = igt_debugfs_dir(data.drm_fd);
> +
> + /* Get active pipes. */
> + for_each_pipe(&data.display, pipe)
> + active_pipes[last_pipe++] = pipe;
> + last_pipe--;
> }
>
> igt_describe("Tests error handling when the bad source is set.");
> @@ -322,6 +356,9 @@ igt_main
> igt_describe(tests[i].desc);
> igt_subtest_with_dynamic(tests[i].name) {
> for_each_pipe_with_single_output(&data.display, pipe, output) {
> + if (simulation_constraint(pipe))
> + continue;
> +
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name) {
> if (tests[i].flags & TEST_SUSPEND) {
> test_read_crc(&data, pipe, output, 0);
> @@ -350,6 +387,9 @@ igt_main
> "does not cause issues.");
> igt_subtest_with_dynamic("disable-crc-after-crtc") {
> for_each_pipe_with_single_output(&data.display, pipe, output) {
> + if (simulation_constraint(pipe))
> + continue;
> +
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
> test_disable_crc_after_crtc(&data, pipe, output);
> }
> @@ -358,6 +398,9 @@ igt_main
> igt_describe("Basic sanity check for CRC mismatches");
> igt_subtest_with_dynamic("compare-crc-sanitycheck") {
> for_each_pipe_with_single_output(&data.display, pipe, output) {
> + if (simulation_constraint(pipe))
> + continue;
> +
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
> test_compare_crc(&data, pipe, output);
> }
--
~Swati Sharma
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-06 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 8:42 [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Limit the execution to two pipes Nidhi Gupta
2023-02-03 13:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-04 2:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-02-06 8:54 ` [igt-dev] [PATCH i-g-t] " Swati Sharma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.