All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io()
@ 2023-02-08 16:58 Lorenzo Bianconi
  2023-02-08 18:40 ` patchwork-bot+netdevbpf
  2023-02-10  8:55 ` Martin Habets
  0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2023-02-08 16:58 UTC (permalink / raw)
  To: bpf
  Cc: netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
	lorenzo.bianconi, ecree.xilinx, habetsm.xilinx

Move xdp_features configuration from efx_pci_probe() to
efx_pci_probe_post_io() since it is where all the other basic netdev
features are initialised.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/sfc/efx.c       | 8 ++++----
 drivers/net/ethernet/sfc/siena/efx.c | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 18ff8d8cff42..9569c3356b4a 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -1025,6 +1025,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
 	net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
 	net_dev->features |= efx->fixed_features;
 
+	net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
+				NETDEV_XDP_ACT_REDIRECT |
+				NETDEV_XDP_ACT_NDO_XMIT;
+
 	rc = efx_register_netdev(efx);
 	if (!rc)
 		return 0;
@@ -1078,10 +1082,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
 
 	pci_info(pci_dev, "Solarflare NIC detected\n");
 
-	efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
-				     NETDEV_XDP_ACT_REDIRECT |
-				     NETDEV_XDP_ACT_NDO_XMIT;
-
 	if (!efx->type->is_vf)
 		efx_probe_vpd_strings(efx);
 
diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c
index a6ef21845224..ef52ec71d197 100644
--- a/drivers/net/ethernet/sfc/siena/efx.c
+++ b/drivers/net/ethernet/sfc/siena/efx.c
@@ -1007,6 +1007,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
 	net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
 	net_dev->features |= efx->fixed_features;
 
+	net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
+				NETDEV_XDP_ACT_REDIRECT |
+				NETDEV_XDP_ACT_NDO_XMIT;
+
 	rc = efx_register_netdev(efx);
 	if (!rc)
 		return 0;
@@ -1048,10 +1052,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
 
 	pci_info(pci_dev, "Solarflare NIC detected\n");
 
-	efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
-				     NETDEV_XDP_ACT_REDIRECT |
-				     NETDEV_XDP_ACT_NDO_XMIT;
-
 	if (!efx->type->is_vf)
 		efx_probe_vpd_strings(efx);
 
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io()
  2023-02-08 16:58 [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io() Lorenzo Bianconi
@ 2023-02-08 18:40 ` patchwork-bot+netdevbpf
  2023-02-10  8:55 ` Martin Habets
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-08 18:40 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: bpf, netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
	lorenzo.bianconi, ecree.xilinx, habetsm.xilinx

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Wed,  8 Feb 2023 17:58:40 +0100 you wrote:
> Move xdp_features configuration from efx_pci_probe() to
> efx_pci_probe_post_io() since it is where all the other basic netdev
> features are initialised.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/net/ethernet/sfc/efx.c       | 8 ++++----
>  drivers/net/ethernet/sfc/siena/efx.c | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)

Here is the summary with links:
  - [bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io()
    https://git.kernel.org/bpf/bpf-next/c/9b0651e429a0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io()
  2023-02-08 16:58 [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io() Lorenzo Bianconi
  2023-02-08 18:40 ` patchwork-bot+netdevbpf
@ 2023-02-10  8:55 ` Martin Habets
  1 sibling, 0 replies; 3+ messages in thread
From: Martin Habets @ 2023-02-10  8:55 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: bpf, netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
	lorenzo.bianconi, ecree.xilinx

Many thanks Lorenzo. It got applied in record time!
Martin

On Wed, Feb 08, 2023 at 05:58:40PM +0100, Lorenzo Bianconi wrote:
> Move xdp_features configuration from efx_pci_probe() to
> efx_pci_probe_post_io() since it is where all the other basic netdev
> features are initialised.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  drivers/net/ethernet/sfc/efx.c       | 8 ++++----
>  drivers/net/ethernet/sfc/siena/efx.c | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 18ff8d8cff42..9569c3356b4a 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -1025,6 +1025,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
>  	net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
>  	net_dev->features |= efx->fixed_features;
>  
> +	net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> +				NETDEV_XDP_ACT_REDIRECT |
> +				NETDEV_XDP_ACT_NDO_XMIT;
> +
>  	rc = efx_register_netdev(efx);
>  	if (!rc)
>  		return 0;
> @@ -1078,10 +1082,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
>  
>  	pci_info(pci_dev, "Solarflare NIC detected\n");
>  
> -	efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> -				     NETDEV_XDP_ACT_REDIRECT |
> -				     NETDEV_XDP_ACT_NDO_XMIT;
> -
>  	if (!efx->type->is_vf)
>  		efx_probe_vpd_strings(efx);
>  
> diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c
> index a6ef21845224..ef52ec71d197 100644
> --- a/drivers/net/ethernet/sfc/siena/efx.c
> +++ b/drivers/net/ethernet/sfc/siena/efx.c
> @@ -1007,6 +1007,10 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
>  	net_dev->features &= ~NETIF_F_HW_VLAN_CTAG_FILTER;
>  	net_dev->features |= efx->fixed_features;
>  
> +	net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> +				NETDEV_XDP_ACT_REDIRECT |
> +				NETDEV_XDP_ACT_NDO_XMIT;
> +
>  	rc = efx_register_netdev(efx);
>  	if (!rc)
>  		return 0;
> @@ -1048,10 +1052,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev,
>  
>  	pci_info(pci_dev, "Solarflare NIC detected\n");
>  
> -	efx->net_dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> -				     NETDEV_XDP_ACT_REDIRECT |
> -				     NETDEV_XDP_ACT_NDO_XMIT;
> -
>  	if (!efx->type->is_vf)
>  		efx_probe_vpd_strings(efx);
>  
> -- 
> 2.39.1

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-10  8:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 16:58 [PATCH bpf-next] sfc: move xdp_features configuration in efx_pci_probe_post_io() Lorenzo Bianconi
2023-02-08 18:40 ` patchwork-bot+netdevbpf
2023-02-10  8:55 ` Martin Habets

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.