[igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling

All of lore.kernel.org
 help / color / mirror / Atom feed

* [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library
@ 2023-02-09 14:12 Karolina Stolarek
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info Karolina Stolarek
                   ` (10 more replies)
  0 siblings, 11 replies; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

As for now, there is no central place that provides information on
command properties such as compression support or if the command
requires any additional setup. It is possible to modify the already
existing library, intel_tiling_info, and add such information there.

The series adds a new field to better describe blitter commands,
which stores bit flags describing properties. Flags defined as a part
of the series mostly target the block-copy command, as its features
vary the most between generations. The introduction of the field is
followed by an update of DG2 and MTL definitions and gem_ccs test.

It was decided that the former blt_cmd_info struct will not only host
information on command properties, but will also describe non-blitter
copy commands. Because of this, in v3 we rename related structs,
functions and variables. To make reviewing easier, the additional
rename was split into three commits: intel_cmds_info definitions
update, supported_cmds field rename and intel_cmds_info getter
rename.

The most important name updates are:
  - intel_tiling_info lib ---> intel_cmds_info lib
  - blt_cmd_info struct ---> intel_cmds_info struct
  - blt_tiling_info struct ---> blt_cmd_info struct

v3:
  - Rename blt_cmds_desc struct to intel_cmds_info
  - Update ifdef in intel_cmds_info header (it still said TILING)
  - Move blt_get_cmd_info() helper from i915_blt to the library,
    make it public
  - Change supported_cmds field name to blt_cmds, as it only refers
    to the blitter copy commands
  - Correct MTL definition
  - Smaller renames, such as GET_BLT_INFO --> GET_CMDS_INFO

v2:
  - Rename the library and its structs to better describe what
    they store
  - Stop using has_flatccs field when checking if a command
    can use compression; use blt_cmd_info flags field instead
  - Update the name of blt_tiling field in intel_device_info,
    as it describes more than just a list of supported tiling
    formats
  - Drop additional macros for DG2 and MTL definitions

Karolina Stolarek (9):
  lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info
  lib/intel_tiling_info: Update names of commands definitions
  lib/intel_tiling_info: Update intel_cmds_info field name
  lib/intel_device_info: Update name for cmds_info getter
  lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info
  lib/i915: Rename intel_tiling_info library
  lib/intel_cmds_info: Add flags field to describe command properties
  lib/i915_blt: Add checks for command properties
  tests/gem_ccs: Check for extended block-copy and compression support

 lib/i915/i915_blt.c          | 121 +++++++++++++++++++++++-----------
 lib/i915/i915_blt.h          |  15 +++--
 lib/i915/intel_cmds_info.c   | 122 +++++++++++++++++++++++++++++++++++
 lib/i915/intel_cmds_info.h   |  55 ++++++++++++++++
 lib/i915/intel_tiling_info.c |  95 ---------------------------
 lib/i915/intel_tiling_info.h |  48 --------------
 lib/intel_chipset.h          |   6 +-
 lib/intel_device_info.c      |  68 +++++++++----------
 lib/meson.build              |   6 +-
 tests/i915/gem_ccs.c         |   7 +-
 10 files changed, 313 insertions(+), 230 deletions(-)
 create mode 100644 lib/i915/intel_cmds_info.c
 create mode 100644 lib/i915/intel_cmds_info.h
 delete mode 100644 lib/i915/intel_tiling_info.c
 delete mode 100644 lib/i915/intel_tiling_info.h

-- 
2.25.1

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:16   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions Karolina Stolarek
                   ` (9 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

The struct stores information on more than just one blitter cmd,
so the current name is slightly confusing. Also, we might want
to store information on other copy commands, like the one provided
by render. Change it to intel_cmds_info to emphasize that it
describes available commands on the platform. Change the field
name in intel_device_info, as it won't just describe tiling
information.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c          | 36 ++++++++++----------
 lib/i915/i915_blt.h          |  4 +--
 lib/i915/intel_tiling_info.c | 12 +++----
 lib/i915/intel_tiling_info.h | 14 ++++----
 lib/intel_chipset.h          |  4 +--
 lib/intel_device_info.c      | 66 ++++++++++++++++++------------------
 6 files changed, 68 insertions(+), 68 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index bbfb6ffc..92860e8d 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -210,42 +210,42 @@ bool blt_supports_compression(int i915)
 
 /**
  * blt_supports_command:
- * @info: Blitter command info struct
+ * @cmds_info: Copy commands description struct
  * @cmd: Blitter command enum
  *
- * Checks if @info has an entry of supported tiling formats for @cmd command.
+ * Checks if @cmds_info has an entry of supported tiling formats for @cmd command.
  *
  * Returns: true if it does, false otherwise
  */
-bool blt_supports_command(const struct blt_cmd_info *info,
+bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 			  enum blt_cmd_type cmd)
 {
-	igt_require_f(info, "No config found for the platform\n");
+	igt_require_f(cmds_info, "No config found for the platform\n");
 
-	return info->supported_cmds[cmd];
+	return cmds_info->supported_cmds[cmd];
 }
 
 /**
  * blt_cmd_supports_tiling:
- * @info: Blitter command info struct
+ * @cmds_info: Copy commands description struct
  * @cmd: Blitter command enum
  * @tiling: tiling format enum
  *
- * Checks if a @cmd entry of @info lists @tiling. It also returns false if
+ * Checks if a @cmd entry of @cmds_info lists @tiling. It also returns false if
  * no information about the command is stored.
  *
  * Returns: true if it does, false otherwise
  */
-bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
+bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 			     enum blt_cmd_type cmd,
 			     enum blt_tiling_type tiling)
 {
 	struct blt_tiling_info const *tile_config;
 
-	if (!info)
+	if (!cmds_info)
 		return false;
 
-	tile_config = info->supported_cmds[cmd];
+	tile_config = cmds_info->supported_cmds[cmd];
 
 	/* no config means no support for that tiling */
 	if (!tile_config)
@@ -265,9 +265,9 @@ bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
  */
 bool blt_has_block_copy(int i915)
 {
-	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
 
-	return blt_supports_command(blt_info, XY_BLOCK_COPY);
+	return blt_supports_command(cmds_info, XY_BLOCK_COPY);
 }
 
 /**
@@ -281,9 +281,9 @@ bool blt_has_block_copy(int i915)
  */
 bool blt_has_fast_copy(int i915)
 {
-	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
 
-	return blt_supports_command(blt_info, XY_FAST_COPY);
+	return blt_supports_command(cmds_info, XY_FAST_COPY);
 }
 
 /**
@@ -298,9 +298,9 @@ bool blt_has_fast_copy(int i915)
  */
 bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
 {
-	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
 
-	return blt_cmd_supports_tiling(blt_info, XY_FAST_COPY, tiling);
+	return blt_cmd_supports_tiling(cmds_info, XY_FAST_COPY, tiling);
 }
 
 /**
@@ -315,9 +315,9 @@ bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
  */
 bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
 {
-	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
 
-	return blt_cmd_supports_tiling(blt_info, XY_BLOCK_COPY, tiling);
+	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
 }
 
 /**
diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
index 299dff8e..ceafc529 100644
--- a/lib/i915/i915_blt.h
+++ b/lib/i915/i915_blt.h
@@ -158,9 +158,9 @@ struct blt_ctrl_surf_copy_data {
 };
 
 bool blt_supports_compression(int i915);
-bool blt_supports_command(const struct blt_cmd_info *info,
+bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 			  enum blt_cmd_type cmd);
-bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
+bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 			     enum blt_cmd_type cmd,
 			     enum blt_tiling_type tiling);
 bool blt_has_block_copy(int i915);
diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
index fc388919..467e4b45 100644
--- a/lib/i915/intel_tiling_info.c
+++ b/lib/i915/intel_tiling_info.c
@@ -51,27 +51,27 @@ static const struct blt_tiling_info
 					     BIT(T_TILE4)  |
 					     BIT(T_TILE64));
 
-const struct blt_cmd_info pre_gen8_blt_info = {
+const struct intel_cmds_info pre_gen8_blt_info = {
 	.supported_cmds = {
 		[SRC_COPY] = &src_copy,
 		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
 	}
 };
 
-const struct blt_cmd_info gen8_blt_info = {
+const struct intel_cmds_info gen8_blt_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 	}
 };
 
-const struct blt_cmd_info gen11_blt_info = {
+const struct intel_cmds_info gen11_blt_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen11_xy_fast_copy,
 	}
 };
 
-const struct blt_cmd_info gen12_blt_info = {
+const struct intel_cmds_info gen12_blt_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen12_xy_fast_copy,
@@ -79,7 +79,7 @@ const struct blt_cmd_info gen12_blt_info = {
 	}
 };
 
-const struct blt_cmd_info gen12_dg2_blt_info = {
+const struct intel_cmds_info gen12_dg2_blt_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
@@ -87,7 +87,7 @@ const struct blt_cmd_info gen12_dg2_blt_info = {
 	}
 };
 
-const struct blt_cmd_info gen12_mtl_blt_info = {
+const struct intel_cmds_info gen12_mtl_blt_info = {
 	.supported_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &dg2_xy_block_copy
diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
index bb655103..2b310f0c 100644
--- a/lib/i915/intel_tiling_info.h
+++ b/lib/i915/intel_tiling_info.h
@@ -31,16 +31,16 @@ struct blt_tiling_info {
 	uint32_t supported_tiling;
 };
 
-struct blt_cmd_info {
+struct intel_cmds_info {
 	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
 };
 
-extern const struct blt_cmd_info pre_gen8_blt_info;
-extern const struct blt_cmd_info gen8_blt_info;
-extern const struct blt_cmd_info gen11_blt_info;
-extern const struct blt_cmd_info gen12_blt_info;
-extern const struct blt_cmd_info gen12_dg2_blt_info;
-extern const struct blt_cmd_info gen12_mtl_blt_info;
+extern const struct intel_cmds_info pre_gen8_blt_info;
+extern const struct intel_cmds_info gen8_blt_info;
+extern const struct intel_cmds_info gen11_blt_info;
+extern const struct intel_cmds_info gen12_blt_info;
+extern const struct intel_cmds_info gen12_dg2_blt_info;
+extern const struct intel_cmds_info gen12_mtl_blt_info;
 
 #define for_each_tiling(__tiling) \
 	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index cceca929..0ae59adc 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -88,13 +88,13 @@ struct intel_device_info {
 	bool is_alderlake_p : 1;
 	bool is_alderlake_n : 1;
 	bool is_meteorlake : 1;
-	const struct blt_cmd_info *blt_tiling;
+	const struct intel_cmds_info *cmds_info;
 	const char *codename;
 };
 
 const struct intel_device_info *intel_get_device_info(uint16_t devid) __attribute__((pure));
 
-const struct blt_cmd_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
+const struct intel_cmds_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
 unsigned intel_gen(uint16_t devid) __attribute__((pure));
 unsigned intel_graphics_ver(uint16_t devid) __attribute__((pure));
 unsigned intel_display_ver(uint16_t devid) __attribute__((pure));
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 49e95ac8..a4cfca6a 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -145,7 +145,7 @@ static const struct intel_device_info intel_sandybridge_info = {
 	.graphics_ver = 6,
 	.display_ver = 6,
 	.is_sandybridge = true,
-	.blt_tiling = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_blt_info,
 	.codename = "sandybridge"
 };
 static const struct intel_device_info intel_sandybridge_m_info = {
@@ -153,7 +153,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
 	.display_ver = 6,
 	.is_mobile = true,
 	.is_sandybridge = true,
-	.blt_tiling = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_blt_info,
 	.codename = "sandybridge"
 };
 
@@ -161,7 +161,7 @@ static const struct intel_device_info intel_ivybridge_info = {
 	.graphics_ver = 7,
 	.display_ver = 7,
 	.is_ivybridge = true,
-	.blt_tiling = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_blt_info,
 	.codename = "ivybridge"
 };
 static const struct intel_device_info intel_ivybridge_m_info = {
@@ -169,7 +169,7 @@ static const struct intel_device_info intel_ivybridge_m_info = {
 	.display_ver = 7,
 	.is_mobile = true,
 	.is_ivybridge = true,
-	.blt_tiling = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_blt_info,
 	.codename = "ivybridge"
 };
 
@@ -177,7 +177,7 @@ static const struct intel_device_info intel_valleyview_info = {
 	.graphics_ver = 7,
 	.display_ver = 7,
 	.is_valleyview = true,
-	.blt_tiling = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_blt_info,
 	.codename = "valleyview"
 };
 
@@ -185,7 +185,7 @@ static const struct intel_device_info intel_valleyview_info = {
 	.graphics_ver = 7, \
 	.display_ver = 7, \
 	.is_haswell = true, \
-	.blt_tiling = &pre_gen8_blt_info, \
+	.cmds_info = &pre_gen8_blt_info, \
 	.codename = "haswell"
 
 static const struct intel_device_info intel_haswell_gt1_info = {
@@ -207,7 +207,7 @@ static const struct intel_device_info intel_haswell_gt3_info = {
 	.graphics_ver = 8, \
 	.display_ver = 8, \
 	.is_broadwell = true, \
-	.blt_tiling = &gen8_blt_info, \
+	.cmds_info = &gen8_blt_info, \
 	.codename = "broadwell"
 
 static const struct intel_device_info intel_broadwell_gt1_info = {
@@ -233,14 +233,14 @@ static const struct intel_device_info intel_cherryview_info = {
 	.graphics_ver = 8,
 	.display_ver = 8,
 	.is_cherryview = true,
-	.blt_tiling = &gen8_blt_info,
+	.cmds_info = &gen8_blt_info,
 	.codename = "cherryview"
 };
 
 #define SKYLAKE_FIELDS \
 	.graphics_ver = 9, \
 	.display_ver = 9, \
-	.blt_tiling = &gen11_blt_info, \
+	.cmds_info = &gen11_blt_info, \
 	.codename = "skylake", \
 	.is_skylake = true
 
@@ -268,7 +268,7 @@ static const struct intel_device_info intel_broxton_info = {
 	.graphics_ver = 9,
 	.display_ver = 9,
 	.is_broxton = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "broxton"
 };
 
@@ -276,7 +276,7 @@ static const struct intel_device_info intel_broxton_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_kabylake = true, \
-	.blt_tiling = &gen11_blt_info, \
+	.cmds_info = &gen11_blt_info, \
 	.codename = "kabylake"
 
 static const struct intel_device_info intel_kabylake_gt1_info = {
@@ -303,7 +303,7 @@ static const struct intel_device_info intel_geminilake_info = {
 	.graphics_ver = 9,
 	.display_ver = 9,
 	.is_geminilake = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "geminilake"
 };
 
@@ -311,7 +311,7 @@ static const struct intel_device_info intel_geminilake_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_coffeelake = true, \
-	.blt_tiling = &gen11_blt_info, \
+	.cmds_info = &gen11_blt_info, \
 	.codename = "coffeelake"
 
 static const struct intel_device_info intel_coffeelake_gt1_info = {
@@ -333,7 +333,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_cometlake = true, \
-	.blt_tiling = &gen11_blt_info, \
+	.cmds_info = &gen11_blt_info, \
 	.codename = "cometlake"
 
 static const struct intel_device_info intel_cometlake_gt1_info = {
@@ -350,7 +350,7 @@ static const struct intel_device_info intel_cannonlake_info = {
 	.graphics_ver = 10,
 	.display_ver = 10,
 	.is_cannonlake = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "cannonlake"
 };
 
@@ -358,7 +358,7 @@ static const struct intel_device_info intel_icelake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_icelake = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "icelake"
 };
 
@@ -366,7 +366,7 @@ static const struct intel_device_info intel_elkhartlake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_elkhartlake = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "elkhartlake"
 };
 
@@ -374,7 +374,7 @@ static const struct intel_device_info intel_jasperlake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_jasperlake = true,
-	.blt_tiling = &gen11_blt_info,
+	.cmds_info = &gen11_blt_info,
 	.codename = "jasperlake"
 };
 
@@ -382,7 +382,7 @@ static const struct intel_device_info intel_tigerlake_gt1_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_tigerlake = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "tigerlake",
 	.gt = 1,
 };
@@ -391,7 +391,7 @@ static const struct intel_device_info intel_tigerlake_gt2_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_tigerlake = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "tigerlake",
 	.gt = 2,
 };
@@ -400,7 +400,7 @@ static const struct intel_device_info intel_rocketlake_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_rocketlake = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "rocketlake"
 };
 
@@ -409,7 +409,7 @@ static const struct intel_device_info intel_dg1_info = {
 	.graphics_rel = 10,
 	.display_ver = 12,
 	.is_dg1 = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "dg1"
 };
 
@@ -420,7 +420,7 @@ static const struct intel_device_info intel_dg2_info = {
 	.has_4tile = true,
 	.is_dg2 = true,
 	.codename = "dg2",
-	.blt_tiling = &gen12_dg2_blt_info,
+	.cmds_info = &gen12_dg2_blt_info,
 	.has_flatccs = true,
 };
 
@@ -428,7 +428,7 @@ static const struct intel_device_info intel_alderlake_s_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_alderlake_s = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "alderlake_s"
 };
 
@@ -436,7 +436,7 @@ static const struct intel_device_info intel_raptorlake_s_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_raptorlake_s = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "raptorlake_s"
 };
 
@@ -444,7 +444,7 @@ static const struct intel_device_info intel_alderlake_p_info = {
 	.graphics_ver = 12,
 	.display_ver = 13,
 	.is_alderlake_p = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "alderlake_p"
 };
 
@@ -452,7 +452,7 @@ static const struct intel_device_info intel_alderlake_n_info = {
 	.graphics_ver = 12,
 	.display_ver = 13,
 	.is_alderlake_n = true,
-	.blt_tiling = &gen12_blt_info,
+	.cmds_info = &gen12_blt_info,
 	.codename = "alderlake_n"
 };
 
@@ -463,7 +463,7 @@ static const struct intel_device_info intel_ats_m_info = {
 	.is_dg2 = true,
 	.has_4tile = true,
 	.codename = "ats_m",
-	.blt_tiling = &gen12_dg2_blt_info,
+	.cmds_info = &gen12_dg2_blt_info,
 	.has_flatccs = true,
 };
 
@@ -474,7 +474,7 @@ static const struct intel_device_info intel_meteorlake_info = {
 	.has_4tile = true,
 	.is_meteorlake = true,
 	.codename = "meteorlake",
-	.blt_tiling = &gen12_mtl_blt_info
+	.cmds_info = &gen12_mtl_blt_info
 };
 
 static const struct pci_id_match intel_device_match[] = {
@@ -616,19 +616,19 @@ out:
  * intel_get_blt_info:
  * @devid: pci device id
  *
- * Looks up information on blitter commands and tiling formats supported
+ * Looks up information on copy commands and tiling formats supported
  * by the device.
  *
  * Returns:
- * The associated blt_cmd_info, NULL if no such information is found
+ * The associated intel_cmds_info, NULL if no such information is found
  */
-const struct blt_cmd_info *intel_get_blt_info(uint16_t devid)
+const struct intel_cmds_info *intel_get_blt_info(uint16_t devid)
 {
 	const struct intel_device_info *dev_info;
 
 	dev_info = intel_get_device_info(devid);
 
-	return dev_info->blt_tiling;
+	return dev_info->cmds_info;
 }
 
 /**
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:17   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name Karolina Stolarek
                   ` (8 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

intel_cmds_info will describe other copy commands, not just
these offered by blitter. Change the definition names to be
more generic.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/intel_tiling_info.c | 12 ++++----
 lib/i915/intel_tiling_info.h | 12 ++++----
 lib/intel_device_info.c      | 58 ++++++++++++++++++------------------
 3 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
index 467e4b45..3df23b60 100644
--- a/lib/i915/intel_tiling_info.c
+++ b/lib/i915/intel_tiling_info.c
@@ -51,27 +51,27 @@ static const struct blt_tiling_info
 					     BIT(T_TILE4)  |
 					     BIT(T_TILE64));
 
-const struct intel_cmds_info pre_gen8_blt_info = {
+const struct intel_cmds_info pre_gen8_cmds_info = {
 	.supported_cmds = {
 		[SRC_COPY] = &src_copy,
 		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
 	}
 };
 
-const struct intel_cmds_info gen8_blt_info = {
+const struct intel_cmds_info gen8_cmds_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 	}
 };
 
-const struct intel_cmds_info gen11_blt_info = {
+const struct intel_cmds_info gen11_cmds_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen11_xy_fast_copy,
 	}
 };
 
-const struct intel_cmds_info gen12_blt_info = {
+const struct intel_cmds_info gen12_cmds_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen12_xy_fast_copy,
@@ -79,7 +79,7 @@ const struct intel_cmds_info gen12_blt_info = {
 	}
 };
 
-const struct intel_cmds_info gen12_dg2_blt_info = {
+const struct intel_cmds_info gen12_dg2_cmds_info = {
 	.supported_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
@@ -87,7 +87,7 @@ const struct intel_cmds_info gen12_dg2_blt_info = {
 	}
 };
 
-const struct intel_cmds_info gen12_mtl_blt_info = {
+const struct intel_cmds_info gen12_mtl_cmds_info = {
 	.supported_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &dg2_xy_block_copy
diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
index 2b310f0c..6854c64b 100644
--- a/lib/i915/intel_tiling_info.h
+++ b/lib/i915/intel_tiling_info.h
@@ -35,12 +35,12 @@ struct intel_cmds_info {
 	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
 };
 
-extern const struct intel_cmds_info pre_gen8_blt_info;
-extern const struct intel_cmds_info gen8_blt_info;
-extern const struct intel_cmds_info gen11_blt_info;
-extern const struct intel_cmds_info gen12_blt_info;
-extern const struct intel_cmds_info gen12_dg2_blt_info;
-extern const struct intel_cmds_info gen12_mtl_blt_info;
+extern const struct intel_cmds_info pre_gen8_cmds_info;
+extern const struct intel_cmds_info gen8_cmds_info;
+extern const struct intel_cmds_info gen11_cmds_info;
+extern const struct intel_cmds_info gen12_cmds_info;
+extern const struct intel_cmds_info gen12_dg2_cmds_info;
+extern const struct intel_cmds_info gen12_mtl_cmds_info;
 
 #define for_each_tiling(__tiling) \
 	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index a4cfca6a..174e2b6f 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -145,7 +145,7 @@ static const struct intel_device_info intel_sandybridge_info = {
 	.graphics_ver = 6,
 	.display_ver = 6,
 	.is_sandybridge = true,
-	.cmds_info = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_cmds_info,
 	.codename = "sandybridge"
 };
 static const struct intel_device_info intel_sandybridge_m_info = {
@@ -153,7 +153,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
 	.display_ver = 6,
 	.is_mobile = true,
 	.is_sandybridge = true,
-	.cmds_info = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_cmds_info,
 	.codename = "sandybridge"
 };
 
@@ -161,7 +161,7 @@ static const struct intel_device_info intel_ivybridge_info = {
 	.graphics_ver = 7,
 	.display_ver = 7,
 	.is_ivybridge = true,
-	.cmds_info = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_cmds_info,
 	.codename = "ivybridge"
 };
 static const struct intel_device_info intel_ivybridge_m_info = {
@@ -169,7 +169,7 @@ static const struct intel_device_info intel_ivybridge_m_info = {
 	.display_ver = 7,
 	.is_mobile = true,
 	.is_ivybridge = true,
-	.cmds_info = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_cmds_info,
 	.codename = "ivybridge"
 };
 
@@ -177,7 +177,7 @@ static const struct intel_device_info intel_valleyview_info = {
 	.graphics_ver = 7,
 	.display_ver = 7,
 	.is_valleyview = true,
-	.cmds_info = &pre_gen8_blt_info,
+	.cmds_info = &pre_gen8_cmds_info,
 	.codename = "valleyview"
 };
 
@@ -185,7 +185,7 @@ static const struct intel_device_info intel_valleyview_info = {
 	.graphics_ver = 7, \
 	.display_ver = 7, \
 	.is_haswell = true, \
-	.cmds_info = &pre_gen8_blt_info, \
+	.cmds_info = &pre_gen8_cmds_info, \
 	.codename = "haswell"
 
 static const struct intel_device_info intel_haswell_gt1_info = {
@@ -207,7 +207,7 @@ static const struct intel_device_info intel_haswell_gt3_info = {
 	.graphics_ver = 8, \
 	.display_ver = 8, \
 	.is_broadwell = true, \
-	.cmds_info = &gen8_blt_info, \
+	.cmds_info = &gen8_cmds_info, \
 	.codename = "broadwell"
 
 static const struct intel_device_info intel_broadwell_gt1_info = {
@@ -233,14 +233,14 @@ static const struct intel_device_info intel_cherryview_info = {
 	.graphics_ver = 8,
 	.display_ver = 8,
 	.is_cherryview = true,
-	.cmds_info = &gen8_blt_info,
+	.cmds_info = &gen8_cmds_info,
 	.codename = "cherryview"
 };
 
 #define SKYLAKE_FIELDS \
 	.graphics_ver = 9, \
 	.display_ver = 9, \
-	.cmds_info = &gen11_blt_info, \
+	.cmds_info = &gen11_cmds_info, \
 	.codename = "skylake", \
 	.is_skylake = true
 
@@ -268,7 +268,7 @@ static const struct intel_device_info intel_broxton_info = {
 	.graphics_ver = 9,
 	.display_ver = 9,
 	.is_broxton = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "broxton"
 };
 
@@ -276,7 +276,7 @@ static const struct intel_device_info intel_broxton_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_kabylake = true, \
-	.cmds_info = &gen11_blt_info, \
+	.cmds_info = &gen11_cmds_info, \
 	.codename = "kabylake"
 
 static const struct intel_device_info intel_kabylake_gt1_info = {
@@ -303,7 +303,7 @@ static const struct intel_device_info intel_geminilake_info = {
 	.graphics_ver = 9,
 	.display_ver = 9,
 	.is_geminilake = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "geminilake"
 };
 
@@ -311,7 +311,7 @@ static const struct intel_device_info intel_geminilake_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_coffeelake = true, \
-	.cmds_info = &gen11_blt_info, \
+	.cmds_info = &gen11_cmds_info, \
 	.codename = "coffeelake"
 
 static const struct intel_device_info intel_coffeelake_gt1_info = {
@@ -333,7 +333,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
 	.graphics_ver = 9, \
 	.display_ver = 9, \
 	.is_cometlake = true, \
-	.cmds_info = &gen11_blt_info, \
+	.cmds_info = &gen11_cmds_info, \
 	.codename = "cometlake"
 
 static const struct intel_device_info intel_cometlake_gt1_info = {
@@ -350,7 +350,7 @@ static const struct intel_device_info intel_cannonlake_info = {
 	.graphics_ver = 10,
 	.display_ver = 10,
 	.is_cannonlake = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "cannonlake"
 };
 
@@ -358,7 +358,7 @@ static const struct intel_device_info intel_icelake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_icelake = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "icelake"
 };
 
@@ -366,7 +366,7 @@ static const struct intel_device_info intel_elkhartlake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_elkhartlake = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "elkhartlake"
 };
 
@@ -374,7 +374,7 @@ static const struct intel_device_info intel_jasperlake_info = {
 	.graphics_ver = 11,
 	.display_ver = 11,
 	.is_jasperlake = true,
-	.cmds_info = &gen11_blt_info,
+	.cmds_info = &gen11_cmds_info,
 	.codename = "jasperlake"
 };
 
@@ -382,7 +382,7 @@ static const struct intel_device_info intel_tigerlake_gt1_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_tigerlake = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "tigerlake",
 	.gt = 1,
 };
@@ -391,7 +391,7 @@ static const struct intel_device_info intel_tigerlake_gt2_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_tigerlake = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "tigerlake",
 	.gt = 2,
 };
@@ -400,7 +400,7 @@ static const struct intel_device_info intel_rocketlake_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_rocketlake = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "rocketlake"
 };
 
@@ -409,7 +409,7 @@ static const struct intel_device_info intel_dg1_info = {
 	.graphics_rel = 10,
 	.display_ver = 12,
 	.is_dg1 = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "dg1"
 };
 
@@ -420,7 +420,7 @@ static const struct intel_device_info intel_dg2_info = {
 	.has_4tile = true,
 	.is_dg2 = true,
 	.codename = "dg2",
-	.cmds_info = &gen12_dg2_blt_info,
+	.cmds_info = &gen12_dg2_cmds_info,
 	.has_flatccs = true,
 };
 
@@ -428,7 +428,7 @@ static const struct intel_device_info intel_alderlake_s_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_alderlake_s = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "alderlake_s"
 };
 
@@ -436,7 +436,7 @@ static const struct intel_device_info intel_raptorlake_s_info = {
 	.graphics_ver = 12,
 	.display_ver = 12,
 	.is_raptorlake_s = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "raptorlake_s"
 };
 
@@ -444,7 +444,7 @@ static const struct intel_device_info intel_alderlake_p_info = {
 	.graphics_ver = 12,
 	.display_ver = 13,
 	.is_alderlake_p = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "alderlake_p"
 };
 
@@ -452,7 +452,7 @@ static const struct intel_device_info intel_alderlake_n_info = {
 	.graphics_ver = 12,
 	.display_ver = 13,
 	.is_alderlake_n = true,
-	.cmds_info = &gen12_blt_info,
+	.cmds_info = &gen12_cmds_info,
 	.codename = "alderlake_n"
 };
 
@@ -463,7 +463,7 @@ static const struct intel_device_info intel_ats_m_info = {
 	.is_dg2 = true,
 	.has_4tile = true,
 	.codename = "ats_m",
-	.cmds_info = &gen12_dg2_blt_info,
+	.cmds_info = &gen12_dg2_cmds_info,
 	.has_flatccs = true,
 };
 
@@ -474,7 +474,7 @@ static const struct intel_device_info intel_meteorlake_info = {
 	.has_4tile = true,
 	.is_meteorlake = true,
 	.codename = "meteorlake",
-	.cmds_info = &gen12_mtl_blt_info
+	.cmds_info = &gen12_mtl_cmds_info
 };
 
 static const struct pci_id_match intel_device_match[] = {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info Karolina Stolarek
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:19   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter Karolina Stolarek
                   ` (7 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

Change supported_cmds field to blt_cmds to show it only describes
blitter-specific copy commands.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c          |  4 ++--
 lib/i915/intel_tiling_info.c | 12 ++++++------
 lib/i915/intel_tiling_info.h |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 92860e8d..dace57b3 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -222,7 +222,7 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 {
 	igt_require_f(cmds_info, "No config found for the platform\n");
 
-	return cmds_info->supported_cmds[cmd];
+	return cmds_info->blt_cmds[cmd];
 }
 
 /**
@@ -245,7 +245,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 	if (!cmds_info)
 		return false;
 
-	tile_config = cmds_info->supported_cmds[cmd];
+	tile_config = cmds_info->blt_cmds[cmd];
 
 	/* no config means no support for that tiling */
 	if (!tile_config)
diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
index 3df23b60..78e1ce16 100644
--- a/lib/i915/intel_tiling_info.c
+++ b/lib/i915/intel_tiling_info.c
@@ -52,27 +52,27 @@ static const struct blt_tiling_info
 					     BIT(T_TILE64));
 
 const struct intel_cmds_info pre_gen8_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[SRC_COPY] = &src_copy,
 		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
 	}
 };
 
 const struct intel_cmds_info gen8_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 	}
 };
 
 const struct intel_cmds_info gen11_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen11_xy_fast_copy,
 	}
 };
 
 const struct intel_cmds_info gen12_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &gen12_xy_fast_copy,
 		[XY_BLOCK_COPY] = &gen12_xy_block_copy,
@@ -80,7 +80,7 @@ const struct intel_cmds_info gen12_cmds_info = {
 };
 
 const struct intel_cmds_info gen12_dg2_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[XY_SRC_COPY] = &gen8_xy_src_copy,
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &dg2_xy_block_copy,
@@ -88,7 +88,7 @@ const struct intel_cmds_info gen12_dg2_cmds_info = {
 };
 
 const struct intel_cmds_info gen12_mtl_cmds_info = {
-	.supported_cmds = {
+	.blt_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
 		[XY_BLOCK_COPY] = &dg2_xy_block_copy
 	}
diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
index 6854c64b..fa8a9b9d 100644
--- a/lib/i915/intel_tiling_info.h
+++ b/lib/i915/intel_tiling_info.h
@@ -32,7 +32,7 @@ struct blt_tiling_info {
 };
 
 struct intel_cmds_info {
-	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
+	struct blt_tiling_info const *blt_cmds[__BLT_MAX_CMD];
 };
 
 extern const struct intel_cmds_info pre_gen8_cmds_info;
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (2 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:20   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 5/9] lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info Karolina Stolarek
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

cmds_info, previously referred as blt_tiling, is not just limited
to blitter commands. Keeping such reference in intel_get_blt_info()
is misleading and confusing. Update the name of the function,
together with the macro that uses it, to make their purpose clear.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c     | 10 +++++-----
 lib/intel_chipset.h     |  2 +-
 lib/intel_device_info.c |  4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index dace57b3..efc280f9 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -14,7 +14,7 @@
 #include "i915_blt.h"
 
 #define BITRANGE(start, end) (end - start + 1)
-#define GET_BLT_INFO(__fd) intel_get_blt_info(intel_get_drm_devid(__fd))
+#define GET_CMDS_INFO(__fd) intel_get_cmds_info(intel_get_drm_devid(__fd))
 
 enum blt_special_mode {
 	SM_NONE,
@@ -265,7 +265,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
  */
 bool blt_has_block_copy(int i915)
 {
-	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
 
 	return blt_supports_command(cmds_info, XY_BLOCK_COPY);
 }
@@ -281,7 +281,7 @@ bool blt_has_block_copy(int i915)
  */
 bool blt_has_fast_copy(int i915)
 {
-	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
 
 	return blt_supports_command(cmds_info, XY_FAST_COPY);
 }
@@ -298,7 +298,7 @@ bool blt_has_fast_copy(int i915)
  */
 bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
 {
-	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
 
 	return blt_cmd_supports_tiling(cmds_info, XY_FAST_COPY, tiling);
 }
@@ -315,7 +315,7 @@ bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
  */
 bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
 {
-	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
 
 	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
 }
diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 0ae59adc..3de67483 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -94,7 +94,7 @@ struct intel_device_info {
 
 const struct intel_device_info *intel_get_device_info(uint16_t devid) __attribute__((pure));
 
-const struct intel_cmds_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
+const struct intel_cmds_info *intel_get_cmds_info(uint16_t devid) __attribute__((pure));
 unsigned intel_gen(uint16_t devid) __attribute__((pure));
 unsigned intel_graphics_ver(uint16_t devid) __attribute__((pure));
 unsigned intel_display_ver(uint16_t devid) __attribute__((pure));
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 174e2b6f..2cd93c43 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -613,7 +613,7 @@ out:
 }
 
 /**
- * intel_get_blt_info:
+ * intel_get_cmds_info:
  * @devid: pci device id
  *
  * Looks up information on copy commands and tiling formats supported
@@ -622,7 +622,7 @@ out:
  * Returns:
  * The associated intel_cmds_info, NULL if no such information is found
  */
-const struct intel_cmds_info *intel_get_blt_info(uint16_t devid)
+const struct intel_cmds_info *intel_get_cmds_info(uint16_t devid)
 {
 	const struct intel_device_info *dev_info;
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 5/9] lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (3 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library Karolina Stolarek
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

This struct will store other information on the copy command,
not just what tiling formats it supports. Change the struct name
to be more generic.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c          |  8 ++++----
 lib/i915/intel_tiling_info.c | 16 ++++++++--------
 lib/i915/intel_tiling_info.h |  4 ++--
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index efc280f9..0ea25d2f 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -240,18 +240,18 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 			     enum blt_cmd_type cmd,
 			     enum blt_tiling_type tiling)
 {
-	struct blt_tiling_info const *tile_config;
+	struct blt_cmd_info const *cmd_info;
 
 	if (!cmds_info)
 		return false;
 
-	tile_config = cmds_info->blt_cmds[cmd];
+	cmd_info = cmds_info->blt_cmds[cmd];
 
 	/* no config means no support for that tiling */
-	if (!tile_config)
+	if (!cmd_info)
 		return false;
 
-	return tile_config->supported_tiling & BIT(tiling);
+	return cmd_info->supported_tiling & BIT(tiling);
 }
 
 /**
diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
index 78e1ce16..e869acb3 100644
--- a/lib/i915/intel_tiling_info.c
+++ b/lib/i915/intel_tiling_info.c
@@ -12,39 +12,39 @@
 		.supported_tiling = _tiling \
 	}
 
-static const struct blt_tiling_info src_copy = BLT_INFO(SRC_COPY, BIT(T_LINEAR));
-static const struct blt_tiling_info
+static const struct blt_cmd_info src_copy = BLT_INFO(SRC_COPY, BIT(T_LINEAR));
+static const struct blt_cmd_info
 		pre_gen8_xy_src_copy = BLT_INFO(XY_SRC_COPY,
 						BIT(T_LINEAR) |
 						BIT(T_XMAJOR));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		gen8_xy_src_copy = BLT_INFO(XY_SRC_COPY,
 					    BIT(T_LINEAR) |
 					    BIT(T_XMAJOR) |
 					    BIT(T_YMAJOR));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		gen11_xy_fast_copy = BLT_INFO(XY_FAST_COPY,
 					      BIT(T_LINEAR)  |
 					      BIT(T_YMAJOR)  |
 					      BIT(T_YFMAJOR) |
 					      BIT(T_TILE64));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		gen12_xy_fast_copy = BLT_INFO(XY_FAST_COPY,
 					      BIT(T_LINEAR) |
 					      BIT(T_YMAJOR) |
 					      BIT(T_TILE4)  |
 					      BIT(T_TILE64));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		dg2_xy_fast_copy = BLT_INFO(XY_FAST_COPY,
 					    BIT(T_LINEAR) |
 					    BIT(T_XMAJOR) |
 					    BIT(T_TILE4)  |
 					    BIT(T_TILE64));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		gen12_xy_block_copy = BLT_INFO(XY_BLOCK_COPY,
 					       BIT(T_LINEAR) |
 					       BIT(T_YMAJOR));
-static const struct blt_tiling_info
+static const struct blt_cmd_info
 		dg2_xy_block_copy = BLT_INFO(XY_BLOCK_COPY,
 					     BIT(T_LINEAR) |
 					     BIT(T_XMAJOR) |
diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
index fa8a9b9d..c7128a43 100644
--- a/lib/i915/intel_tiling_info.h
+++ b/lib/i915/intel_tiling_info.h
@@ -26,13 +26,13 @@ enum blt_cmd_type {
 	__BLT_MAX_CMD
 };
 
-struct blt_tiling_info {
+struct blt_cmd_info {
 	enum blt_cmd_type blt_cmd_type;
 	uint32_t supported_tiling;
 };
 
 struct intel_cmds_info {
-	struct blt_tiling_info const *blt_cmds[__BLT_MAX_CMD];
+	struct blt_cmd_info const *blt_cmds[__BLT_MAX_CMD];
 };
 
 extern const struct intel_cmds_info pre_gen8_cmds_info;
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (4 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 5/9] lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:23   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties Karolina Stolarek
                   ` (4 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

The structs here describe the properties of copy commands, not
just tiling formats they support. Make the library name more
generic.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.h                                 | 2 +-
 lib/i915/{intel_tiling_info.c => intel_cmds_info.c} | 2 +-
 lib/i915/{intel_tiling_info.h => intel_cmds_info.h} | 4 ++--
 lib/intel_chipset.h                                 | 2 +-
 lib/meson.build                                     | 6 +++---
 5 files changed, 8 insertions(+), 8 deletions(-)
 rename lib/i915/{intel_tiling_info.c => intel_cmds_info.c} (98%)
 rename lib/i915/{intel_tiling_info.h => intel_cmds_info.h} (93%)

diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
index ceafc529..3fe47527 100644
--- a/lib/i915/i915_blt.h
+++ b/lib/i915/i915_blt.h
@@ -47,7 +47,7 @@
 #include <malloc.h>
 #include "drm.h"
 #include "igt.h"
-#include "intel_tiling_info.h"
+#include "intel_cmds_info.h"
 
 #define CCS_RATIO 256
 
diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_cmds_info.c
similarity index 98%
rename from lib/i915/intel_tiling_info.c
rename to lib/i915/intel_cmds_info.c
index e869acb3..9fce0351 100644
--- a/lib/i915/intel_tiling_info.c
+++ b/lib/i915/intel_cmds_info.c
@@ -5,7 +5,7 @@
 
 #include <stdint.h>
 #include "intel_chipset.h"
-#include "i915/intel_tiling_info.h"
+#include "i915/intel_cmds_info.h"
 
 #define BLT_INFO(_cmd, _tiling)  { \
 		.blt_cmd_type = _cmd, \
diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_cmds_info.h
similarity index 93%
rename from lib/i915/intel_tiling_info.h
rename to lib/i915/intel_cmds_info.h
index c7128a43..4fdce343 100644
--- a/lib/i915/intel_tiling_info.h
+++ b/lib/i915/intel_cmds_info.h
@@ -3,8 +3,8 @@
  * Copyright © 2022 Intel Corporation
  */
 
-#ifndef __INTEL_TILING_INFO_H
-#define __INTEL_TILING_INFO_H
+#ifndef __INTEL_CMDS_INFO_H
+#define __INTEL_CMDS_INFO_H
 
 #include <stdint.h>
 
diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 3de67483..c9762ae6 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -31,7 +31,7 @@
 #include <pciaccess.h>
 #include <stdbool.h>
 
-#include "i915/intel_tiling_info.h"
+#include "i915/intel_cmds_info.h"
 
 #define BIT(x) (1ul <<(x))
 
diff --git a/lib/meson.build b/lib/meson.build
index d49b78ca..c5131d9a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -14,7 +14,7 @@ lib_sources = [
 	'i915/intel_decode.c',
 	'i915/intel_memory_region.c',
 	'i915/intel_mocs.c',
-	'i915/intel_tiling_info.c',
+	'i915/intel_cmds_info.c',
 	'i915/i915_blt.c',
 	'i915/i915_crc.c',
 	'igt_collection.c',
@@ -219,7 +219,7 @@ igt_deps = [ lib_igt ] + lib_deps
 lin_igt_chipset_build = static_library('igt_chipset',
                                        ['intel_chipset.c',
 					'intel_device_info.c',
-					'i915/intel_tiling_info.c'],
+					'i915/intel_cmds_info.c'],
                                        include_directories : inc)
 
 lib_igt_chipset = declare_dependency(link_with : lin_igt_chipset_build,
@@ -242,7 +242,7 @@ lib_igt_device_scan_build = static_library('igt_device_scan',
 	'igt_list.c',
 	'igt_tools_stub.c',
 	'intel_device_info.c',
-	'i915/intel_tiling_info.c',
+	'i915/intel_cmds_info.c',
 	],
 	dependencies : scan_dep,
 	include_directories : inc)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (5 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:25   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for " Karolina Stolarek
                   ` (3 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

Blitter commands may have different properties depending on the
platform. Add a new field to blt_cmd_info struct to describe
their properties. Update block-copy definitions for DG2 and MTL
to use that field.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/intel_cmds_info.c | 28 ++++++++++++++++++++++------
 lib/i915/intel_cmds_info.h |  4 ++++
 2 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/lib/i915/intel_cmds_info.c b/lib/i915/intel_cmds_info.c
index 9fce0351..59ee0403 100644
--- a/lib/i915/intel_cmds_info.c
+++ b/lib/i915/intel_cmds_info.c
@@ -12,6 +12,12 @@
 		.supported_tiling = _tiling \
 	}
 
+#define BLT_INFO_EXT(_cmd, _tiling, _flags)  { \
+		.blt_cmd_type = _cmd, \
+		.supported_tiling = _tiling, \
+		.flags = _flags, \
+	}
+
 static const struct blt_cmd_info src_copy = BLT_INFO(SRC_COPY, BIT(T_LINEAR));
 static const struct blt_cmd_info
 		pre_gen8_xy_src_copy = BLT_INFO(XY_SRC_COPY,
@@ -45,11 +51,21 @@ static const struct blt_cmd_info
 					       BIT(T_LINEAR) |
 					       BIT(T_YMAJOR));
 static const struct blt_cmd_info
-		dg2_xy_block_copy = BLT_INFO(XY_BLOCK_COPY,
-					     BIT(T_LINEAR) |
-					     BIT(T_XMAJOR) |
-					     BIT(T_TILE4)  |
-					     BIT(T_TILE64));
+		dg2_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
+						 BIT(T_LINEAR) |
+						 BIT(T_XMAJOR) |
+						 BIT(T_TILE4)  |
+						 BIT(T_TILE64),
+						 BLT_CMD_EXTENDED |
+						 BLT_CMD_SUPPORTS_COMPRESSION);
+
+static const struct blt_cmd_info
+		mtl_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
+						 BIT(T_LINEAR) |
+						 BIT(T_XMAJOR) |
+						 BIT(T_TILE4)  |
+						 BIT(T_TILE64),
+						 BLT_CMD_EXTENDED);
 
 const struct intel_cmds_info pre_gen8_cmds_info = {
 	.blt_cmds = {
@@ -90,6 +106,6 @@ const struct intel_cmds_info gen12_dg2_cmds_info = {
 const struct intel_cmds_info gen12_mtl_cmds_info = {
 	.blt_cmds = {
 		[XY_FAST_COPY] = &dg2_xy_fast_copy,
-		[XY_BLOCK_COPY] = &dg2_xy_block_copy
+		[XY_BLOCK_COPY] = &mtl_xy_block_copy,
 	}
 };
diff --git a/lib/i915/intel_cmds_info.h b/lib/i915/intel_cmds_info.h
index 4fdce343..541727ec 100644
--- a/lib/i915/intel_cmds_info.h
+++ b/lib/i915/intel_cmds_info.h
@@ -29,6 +29,10 @@ enum blt_cmd_type {
 struct blt_cmd_info {
 	enum blt_cmd_type blt_cmd_type;
 	uint32_t supported_tiling;
+
+	uint32_t flags;
+#define BLT_CMD_EXTENDED               (1 << 0)
+#define BLT_CMD_SUPPORTS_COMPRESSION   (1 << 1)
 };
 
 struct intel_cmds_info {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for command properties
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (6 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:27   ` Zbigniew Kempczyński
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support Karolina Stolarek
                   ` (2 subsequent siblings)
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

Add a predicate that checks if a command has a specific property.
Introduce helpers that check if a platform uses an extended
version of the block-copy command or supports compression. Add
a getter for blt_cmd_info to intel_cmds_info library. Group
functions together in i915_blt header file.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c        | 64 ++++++++++++++++++++++++++++++++++++--
 lib/i915/i915_blt.h        |  8 +++++
 lib/i915/intel_cmds_info.c | 11 +++++++
 lib/i915/intel_cmds_info.h |  3 ++
 4 files changed, 84 insertions(+), 2 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 0ea25d2f..9b32a0e9 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -222,7 +222,7 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 {
 	igt_require_f(cmds_info, "No config found for the platform\n");
 
-	return cmds_info->blt_cmds[cmd];
+	return blt_get_cmd_info(cmds_info, cmd);
 }
 
 /**
@@ -245,7 +245,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 	if (!cmds_info)
 		return false;
 
-	cmd_info = cmds_info->blt_cmds[cmd];
+	cmd_info = blt_get_cmd_info(cmds_info, cmd);
 
 	/* no config means no support for that tiling */
 	if (!cmd_info)
@@ -254,6 +254,32 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 	return cmd_info->supported_tiling & BIT(tiling);
 }
 
+/**
+ * blt_cmd_has_property:
+ * @cmds_info: Copy commands description struct
+ * @cmd: Blitter command enum
+ * @prop: property flag
+ *
+ * Checks if a @cmd entry of @cmds_info has @prop property. The properties can
+ * be freely combined, but the function will return true for platforms for
+ * which all properties defined in the bit flag are present. The function
+ * returns false if no information about the command is stored.
+ *
+ * Returns: true if it does, false otherwise
+ */
+bool blt_cmd_has_property(const struct intel_cmds_info *cmds_info,
+			  enum blt_cmd_type cmd, uint32_t prop)
+{
+	struct blt_cmd_info const *cmd_info;
+
+	cmd_info = blt_get_cmd_info(cmds_info, cmd);
+
+	if (!cmd_info)
+		return false;
+
+	return cmd_info->flags & prop;
+}
+
 /**
  * blt_has_block_copy
  * @i915: drm fd
@@ -320,6 +346,40 @@ bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
 	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
 }
 
+/**
+ * blt_block_copy_supports_compression
+ * @i915: drm fd
+ *
+ * Check if block copy provided by @i915 device supports compression.
+ *
+ * Returns:
+ * true if it does, false otherwise.
+ */
+bool blt_block_copy_supports_compression(int i915)
+{
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
+
+	return blt_cmd_has_property(cmds_info, XY_BLOCK_COPY,
+				    BLT_CMD_SUPPORTS_COMPRESSION);
+}
+
+/**
+ * blt_uses_extended_block_copy
+ * @i915: drm fd
+ *
+ * Check if block copy provided by @i915 device uses an extended version
+ * of the command.
+ *
+ * Returns:
+ * true if it does, false otherwise.
+ */
+bool blt_uses_extended_block_copy(int i915)
+{
+	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
+
+	return blt_cmd_has_property(cmds_info, XY_BLOCK_COPY, BLT_CMD_EXTENDED);
+}
+
 /**
  * blt_tiling_name:
  * @tiling: tiling id
diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
index 3fe47527..6634533b 100644
--- a/lib/i915/i915_blt.h
+++ b/lib/i915/i915_blt.h
@@ -163,10 +163,18 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
 			     enum blt_cmd_type cmd,
 			     enum blt_tiling_type tiling);
+bool blt_cmd_has_property(const struct intel_cmds_info *cmds_info,
+			  enum blt_cmd_type cmd,
+			  uint32_t prop);
+
 bool blt_has_block_copy(int i915);
 bool blt_has_fast_copy(int i915);
+
 bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling);
 bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling);
+bool blt_block_copy_supports_compression(int i915);
+bool blt_uses_extended_block_copy(int i915);
+
 const char *blt_tiling_name(enum blt_tiling_type tiling);
 
 uint64_t emit_blt_block_copy(int i915,
diff --git a/lib/i915/intel_cmds_info.c b/lib/i915/intel_cmds_info.c
index 59ee0403..2ac6bc2a 100644
--- a/lib/i915/intel_cmds_info.c
+++ b/lib/i915/intel_cmds_info.c
@@ -4,6 +4,8 @@
  */
 
 #include <stdint.h>
+#include <stddef.h>
+
 #include "intel_chipset.h"
 #include "i915/intel_cmds_info.h"
 
@@ -109,3 +111,12 @@ const struct intel_cmds_info gen12_mtl_cmds_info = {
 		[XY_BLOCK_COPY] = &mtl_xy_block_copy,
 	}
 };
+
+const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
+					    enum blt_cmd_type cmd)
+{
+	if (!cmds_info)
+		return NULL;
+
+	return cmds_info->blt_cmds[cmd];
+}
diff --git a/lib/i915/intel_cmds_info.h b/lib/i915/intel_cmds_info.h
index 541727ec..9bf6ecd5 100644
--- a/lib/i915/intel_cmds_info.h
+++ b/lib/i915/intel_cmds_info.h
@@ -49,4 +49,7 @@ extern const struct intel_cmds_info gen12_mtl_cmds_info;
 #define for_each_tiling(__tiling) \
 	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
 
+const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
+					    enum blt_cmd_type cmd);
+
 #endif
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (7 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for " Karolina Stolarek
@ 2023-02-09 14:12 ` Karolina Stolarek
  2023-02-10  9:29   ` Zbigniew Kempczyński
  2023-02-09 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend and rename intel_tiling_info library (rev2) Patchwork
  2023-02-10 11:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  10 siblings, 1 reply; 20+ messages in thread
From: Karolina Stolarek @ 2023-02-09 14:12 UTC (permalink / raw)
  To: igt-dev

Use a helper that checks blitter command flags instead of directly
checking Flat CCS compression support. Check for extended block-copy
command when initializing the copy object in block_copy and
block_multicopy tests.

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
---
 lib/i915/i915_blt.c  | 17 -----------------
 lib/i915/i915_blt.h  |  1 -
 tests/i915/gem_ccs.c |  7 +++----
 3 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
index 9b32a0e9..63eba4ac 100644
--- a/lib/i915/i915_blt.c
+++ b/lib/i915/i915_blt.c
@@ -191,23 +191,6 @@ struct gen12_block_copy_data_ext {
 	} dw21;
 };
 
-/**
- * blt_supports_compression:
- * @i915: drm fd
- *
- * Function checks if HW supports flatccs compression in blitter commands
- * on @i915 device.
- *
- * Returns:
- * true if it does, false otherwise.
- */
-bool blt_supports_compression(int i915)
-{
-	uint32_t devid = intel_get_drm_devid(i915);
-
-	return HAS_FLATCCS(devid);
-}
-
 /**
  * blt_supports_command:
  * @cmds_info: Copy commands description struct
diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
index 6634533b..c535961e 100644
--- a/lib/i915/i915_blt.h
+++ b/lib/i915/i915_blt.h
@@ -157,7 +157,6 @@ struct blt_ctrl_surf_copy_data {
 	bool print_bb;
 };
 
-bool blt_supports_compression(int i915);
 bool blt_supports_command(const struct intel_cmds_info *cmds_info,
 			  enum blt_cmd_type cmd);
 bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
diff --git a/tests/i915/gem_ccs.c b/tests/i915/gem_ccs.c
index a24c8e1f..b7e8bda7 100644
--- a/tests/i915/gem_ccs.c
+++ b/tests/i915/gem_ccs.c
@@ -346,7 +346,6 @@ static void block_copy(int i915,
 	uint32_t run_id = mid_tiling;
 	uint32_t mid_region = region2, bb;
 	uint32_t width = param.width, height = param.height;
-	uint32_t devid = intel_get_drm_devid(i915);
 	enum blt_compression mid_compression = config->compression;
 	int mid_compression_format = param.compression_format;
 	enum blt_compression_type comp_type = COMPRESSION_TYPE_3D;
@@ -355,7 +354,7 @@ static void block_copy(int i915,
 
 	igt_assert(__gem_create_in_memory_regions(i915, &bb, &bb_size, region1) == 0);
 
-	if (!blt_supports_compression(i915) && !IS_METEORLAKE(devid))
+	if (!blt_uses_extended_block_copy(i915))
 		pext = NULL;
 
 	src = blt_create_object(i915, region1, width, height, bpp, uc_mocs,
@@ -470,7 +469,7 @@ static void block_multicopy(int i915,
 
 	igt_assert(__gem_create_in_memory_regions(i915, &bb, &bb_size, region1) == 0);
 
-	if (!blt_supports_compression(i915))
+	if (!blt_uses_extended_block_copy(i915))
 		pext3 = NULL;
 
 	src = blt_create_object(i915, region1, width, height, bpp, uc_mocs,
@@ -557,7 +556,7 @@ static void block_copy_test(int i915,
 	const struct intel_execution_engine2 *e;
 	int tiling;
 
-	if (config->compression && !blt_supports_compression(i915))
+	if (config->compression && !blt_block_copy_supports_compression(i915))
 		return;
 
 	if (config->inplace && !config->compression)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Extend and rename intel_tiling_info library (rev2)
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (8 preceding siblings ...)
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support Karolina Stolarek
@ 2023-02-09 15:13 ` Patchwork
  2023-02-10 11:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  10 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2023-02-09 15:13 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 9303 bytes --]

== Series Details ==

Series: Extend and rename intel_tiling_info library (rev2)
URL   : https://patchwork.freedesktop.org/series/113785/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12721 -> IGTPW_8478
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html

Participating hosts (37 -> 37)
------------------------------

  Additional (2): bat-atsm-1 bat-dg1-6 
  Missing    (2): fi-kbl-soraka fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8478 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_mmap@basic:
    - bat-dg1-6:          NOTRUN -> [SKIP][1] ([i915#4083])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@gem_mmap@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-dg1-6:          NOTRUN -> [SKIP][2] ([i915#4079]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_fence_blits@basic:
    - bat-dg1-6:          NOTRUN -> [SKIP][3] ([i915#4077]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html

  * igt@i915_pm_backlight@basic-brightness:
    - bat-dg1-6:          NOTRUN -> [SKIP][4] ([i915#7561])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg1-6:          NOTRUN -> [SKIP][5] ([i915#6621])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@i915_pm_rps@basic-api.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg1-6:          NOTRUN -> [SKIP][6] ([i915#4215])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg1-6:          NOTRUN -> [SKIP][7] ([i915#4212]) +7 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-dg1-6:          NOTRUN -> [SKIP][8] ([i915#7828]) +8 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - fi-cfl-guc:         NOTRUN -> [SKIP][9] ([fdo#109271])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/fi-cfl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
    - bat-dg1-6:          NOTRUN -> [SKIP][10] ([i915#4103] / [i915#4213])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-dg1-6:          NOTRUN -> [SKIP][11] ([fdo#109285])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-dg1-6:          NOTRUN -> [SKIP][12] ([i915#1072] / [i915#4078]) +3 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-dg1-6:          NOTRUN -> [SKIP][13] ([i915#3555])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-gtt:
    - bat-dg1-6:          NOTRUN -> [SKIP][14] ([i915#3708] / [i915#4077]) +1 similar issue
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@prime_vgem@basic-gtt.html

  * igt@prime_vgem@basic-read:
    - bat-dg1-6:          NOTRUN -> [SKIP][15] ([i915#3708]) +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-userptr:
    - bat-dg1-6:          NOTRUN -> [SKIP][16] ([i915#3708] / [i915#4873])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-dg1-6/igt@prime_vgem@basic-userptr.html

  
#### Possible fixes ####

  * igt@dmabuf@all-tests@dma_fence:
    - fi-cfl-guc:         [DMESG-FAIL][17] -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/fi-cfl-guc/igt@dmabuf@all-tests@dma_fence.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/fi-cfl-guc/igt@dmabuf@all-tests@dma_fence.html

  * igt@dmabuf@all-tests@sanitycheck:
    - fi-cfl-guc:         [ABORT][19] -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/fi-cfl-guc/igt@dmabuf@all-tests@sanitycheck.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/fi-cfl-guc/igt@dmabuf@all-tests@sanitycheck.html

  * igt@i915_selftest@live@dmabuf:
    - fi-bsw-nick:        [DMESG-FAIL][21] ([i915#7562] / [i915#7913]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/fi-bsw-nick/igt@i915_selftest@live@dmabuf.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][23] ([i915#5334]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@requests:
    - {bat-rpls-1}:       [ABORT][25] ([i915#4983] / [i915#7911]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/bat-rpls-1/igt@i915_selftest@live@requests.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/bat-rpls-1/igt@i915_selftest@live@requests.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
  [i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
  [i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
  [i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
  [i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
  [i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#7102]: https://gitlab.freedesktop.org/drm/intel/issues/7102
  [i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
  [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7562]: https://gitlab.freedesktop.org/drm/intel/issues/7562
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7155 -> IGTPW_8478

  CI-20190529: 20190529
  CI_DRM_12721: e1f9df7a92c1e3da1009afa74dc1d08ef95c3d7c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8478: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html
  IGT_7155: 75c508d4e19c65683d4060cb3a772df600aaf23e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

-igt@gem_ctx_exec@barrier-race

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html

[-- Attachment #2: Type: text/html, Size: 9474 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info Karolina Stolarek
@ 2023-02-10  9:16   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:16 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:04PM +0100, Karolina Stolarek wrote:
> The struct stores information on more than just one blitter cmd,
> so the current name is slightly confusing. Also, we might want
> to store information on other copy commands, like the one provided
> by render. Change it to intel_cmds_info to emphasize that it
> describes available commands on the platform. Change the field
> name in intel_device_info, as it won't just describe tiling
> information.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/i915_blt.c          | 36 ++++++++++----------
>  lib/i915/i915_blt.h          |  4 +--
>  lib/i915/intel_tiling_info.c | 12 +++----
>  lib/i915/intel_tiling_info.h | 14 ++++----
>  lib/intel_chipset.h          |  4 +--
>  lib/intel_device_info.c      | 66 ++++++++++++++++++------------------
>  6 files changed, 68 insertions(+), 68 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index bbfb6ffc..92860e8d 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -210,42 +210,42 @@ bool blt_supports_compression(int i915)
>  
>  /**
>   * blt_supports_command:
> - * @info: Blitter command info struct
> + * @cmds_info: Copy commands description struct
>   * @cmd: Blitter command enum
>   *
> - * Checks if @info has an entry of supported tiling formats for @cmd command.
> + * Checks if @cmds_info has an entry of supported tiling formats for @cmd command.
>   *
>   * Returns: true if it does, false otherwise
>   */
> -bool blt_supports_command(const struct blt_cmd_info *info,
> +bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  			  enum blt_cmd_type cmd)
>  {
> -	igt_require_f(info, "No config found for the platform\n");
> +	igt_require_f(cmds_info, "No config found for the platform\n");
>  
> -	return info->supported_cmds[cmd];
> +	return cmds_info->supported_cmds[cmd];
>  }
>  
>  /**
>   * blt_cmd_supports_tiling:
> - * @info: Blitter command info struct
> + * @cmds_info: Copy commands description struct
>   * @cmd: Blitter command enum
>   * @tiling: tiling format enum
>   *
> - * Checks if a @cmd entry of @info lists @tiling. It also returns false if
> + * Checks if a @cmd entry of @cmds_info lists @tiling. It also returns false if
>   * no information about the command is stored.
>   *
>   * Returns: true if it does, false otherwise
>   */
> -bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
> +bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  			     enum blt_cmd_type cmd,
>  			     enum blt_tiling_type tiling)
>  {
>  	struct blt_tiling_info const *tile_config;
>  
> -	if (!info)
> +	if (!cmds_info)
>  		return false;
>  
> -	tile_config = info->supported_cmds[cmd];
> +	tile_config = cmds_info->supported_cmds[cmd];
>  
>  	/* no config means no support for that tiling */
>  	if (!tile_config)
> @@ -265,9 +265,9 @@ bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
>   */
>  bool blt_has_block_copy(int i915)
>  {
> -	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
>  
> -	return blt_supports_command(blt_info, XY_BLOCK_COPY);
> +	return blt_supports_command(cmds_info, XY_BLOCK_COPY);
>  }
>  
>  /**
> @@ -281,9 +281,9 @@ bool blt_has_block_copy(int i915)
>   */
>  bool blt_has_fast_copy(int i915)
>  {
> -	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
>  
> -	return blt_supports_command(blt_info, XY_FAST_COPY);
> +	return blt_supports_command(cmds_info, XY_FAST_COPY);
>  }
>  
>  /**
> @@ -298,9 +298,9 @@ bool blt_has_fast_copy(int i915)
>   */
>  bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>  {
> -	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
>  
> -	return blt_cmd_supports_tiling(blt_info, XY_FAST_COPY, tiling);
> +	return blt_cmd_supports_tiling(cmds_info, XY_FAST_COPY, tiling);
>  }
>  
>  /**
> @@ -315,9 +315,9 @@ bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>   */
>  bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>  {
> -	const struct blt_cmd_info *blt_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
>  
> -	return blt_cmd_supports_tiling(blt_info, XY_BLOCK_COPY, tiling);
> +	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
>  }
>  
>  /**
> diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
> index 299dff8e..ceafc529 100644
> --- a/lib/i915/i915_blt.h
> +++ b/lib/i915/i915_blt.h
> @@ -158,9 +158,9 @@ struct blt_ctrl_surf_copy_data {
>  };
>  
>  bool blt_supports_compression(int i915);
> -bool blt_supports_command(const struct blt_cmd_info *info,
> +bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  			  enum blt_cmd_type cmd);
> -bool blt_cmd_supports_tiling(const struct blt_cmd_info *info,
> +bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  			     enum blt_cmd_type cmd,
>  			     enum blt_tiling_type tiling);
>  bool blt_has_block_copy(int i915);
> diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
> index fc388919..467e4b45 100644
> --- a/lib/i915/intel_tiling_info.c
> +++ b/lib/i915/intel_tiling_info.c
> @@ -51,27 +51,27 @@ static const struct blt_tiling_info
>  					     BIT(T_TILE4)  |
>  					     BIT(T_TILE64));
>  
> -const struct blt_cmd_info pre_gen8_blt_info = {
> +const struct intel_cmds_info pre_gen8_blt_info = {
>  	.supported_cmds = {
>  		[SRC_COPY] = &src_copy,
>  		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
>  	}
>  };
>  
> -const struct blt_cmd_info gen8_blt_info = {
> +const struct intel_cmds_info gen8_blt_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  	}
>  };
>  
> -const struct blt_cmd_info gen11_blt_info = {
> +const struct intel_cmds_info gen11_blt_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen11_xy_fast_copy,
>  	}
>  };
>  
> -const struct blt_cmd_info gen12_blt_info = {
> +const struct intel_cmds_info gen12_blt_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen12_xy_fast_copy,
> @@ -79,7 +79,7 @@ const struct blt_cmd_info gen12_blt_info = {
>  	}
>  };
>  
> -const struct blt_cmd_info gen12_dg2_blt_info = {
> +const struct intel_cmds_info gen12_dg2_blt_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
> @@ -87,7 +87,7 @@ const struct blt_cmd_info gen12_dg2_blt_info = {
>  	}
>  };
>  
> -const struct blt_cmd_info gen12_mtl_blt_info = {
> +const struct intel_cmds_info gen12_mtl_blt_info = {
>  	.supported_cmds = {
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
>  		[XY_BLOCK_COPY] = &dg2_xy_block_copy
> diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
> index bb655103..2b310f0c 100644
> --- a/lib/i915/intel_tiling_info.h
> +++ b/lib/i915/intel_tiling_info.h
> @@ -31,16 +31,16 @@ struct blt_tiling_info {
>  	uint32_t supported_tiling;
>  };
>  
> -struct blt_cmd_info {
> +struct intel_cmds_info {
>  	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
>  };
>  
> -extern const struct blt_cmd_info pre_gen8_blt_info;
> -extern const struct blt_cmd_info gen8_blt_info;
> -extern const struct blt_cmd_info gen11_blt_info;
> -extern const struct blt_cmd_info gen12_blt_info;
> -extern const struct blt_cmd_info gen12_dg2_blt_info;
> -extern const struct blt_cmd_info gen12_mtl_blt_info;
> +extern const struct intel_cmds_info pre_gen8_blt_info;
> +extern const struct intel_cmds_info gen8_blt_info;
> +extern const struct intel_cmds_info gen11_blt_info;
> +extern const struct intel_cmds_info gen12_blt_info;
> +extern const struct intel_cmds_info gen12_dg2_blt_info;
> +extern const struct intel_cmds_info gen12_mtl_blt_info;
>  
>  #define for_each_tiling(__tiling) \
>  	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index cceca929..0ae59adc 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -88,13 +88,13 @@ struct intel_device_info {
>  	bool is_alderlake_p : 1;
>  	bool is_alderlake_n : 1;
>  	bool is_meteorlake : 1;
> -	const struct blt_cmd_info *blt_tiling;
> +	const struct intel_cmds_info *cmds_info;
>  	const char *codename;
>  };
>  
>  const struct intel_device_info *intel_get_device_info(uint16_t devid) __attribute__((pure));
>  
> -const struct blt_cmd_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
> +const struct intel_cmds_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
>  unsigned intel_gen(uint16_t devid) __attribute__((pure));
>  unsigned intel_graphics_ver(uint16_t devid) __attribute__((pure));
>  unsigned intel_display_ver(uint16_t devid) __attribute__((pure));
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 49e95ac8..a4cfca6a 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -145,7 +145,7 @@ static const struct intel_device_info intel_sandybridge_info = {
>  	.graphics_ver = 6,
>  	.display_ver = 6,
>  	.is_sandybridge = true,
> -	.blt_tiling = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_blt_info,
>  	.codename = "sandybridge"
>  };
>  static const struct intel_device_info intel_sandybridge_m_info = {
> @@ -153,7 +153,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
>  	.display_ver = 6,
>  	.is_mobile = true,
>  	.is_sandybridge = true,
> -	.blt_tiling = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_blt_info,
>  	.codename = "sandybridge"
>  };
>  
> @@ -161,7 +161,7 @@ static const struct intel_device_info intel_ivybridge_info = {
>  	.graphics_ver = 7,
>  	.display_ver = 7,
>  	.is_ivybridge = true,
> -	.blt_tiling = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_blt_info,
>  	.codename = "ivybridge"
>  };
>  static const struct intel_device_info intel_ivybridge_m_info = {
> @@ -169,7 +169,7 @@ static const struct intel_device_info intel_ivybridge_m_info = {
>  	.display_ver = 7,
>  	.is_mobile = true,
>  	.is_ivybridge = true,
> -	.blt_tiling = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_blt_info,
>  	.codename = "ivybridge"
>  };
>  
> @@ -177,7 +177,7 @@ static const struct intel_device_info intel_valleyview_info = {
>  	.graphics_ver = 7,
>  	.display_ver = 7,
>  	.is_valleyview = true,
> -	.blt_tiling = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_blt_info,
>  	.codename = "valleyview"
>  };
>  
> @@ -185,7 +185,7 @@ static const struct intel_device_info intel_valleyview_info = {
>  	.graphics_ver = 7, \
>  	.display_ver = 7, \
>  	.is_haswell = true, \
> -	.blt_tiling = &pre_gen8_blt_info, \
> +	.cmds_info = &pre_gen8_blt_info, \
>  	.codename = "haswell"
>  
>  static const struct intel_device_info intel_haswell_gt1_info = {
> @@ -207,7 +207,7 @@ static const struct intel_device_info intel_haswell_gt3_info = {
>  	.graphics_ver = 8, \
>  	.display_ver = 8, \
>  	.is_broadwell = true, \
> -	.blt_tiling = &gen8_blt_info, \
> +	.cmds_info = &gen8_blt_info, \
>  	.codename = "broadwell"
>  
>  static const struct intel_device_info intel_broadwell_gt1_info = {
> @@ -233,14 +233,14 @@ static const struct intel_device_info intel_cherryview_info = {
>  	.graphics_ver = 8,
>  	.display_ver = 8,
>  	.is_cherryview = true,
> -	.blt_tiling = &gen8_blt_info,
> +	.cmds_info = &gen8_blt_info,
>  	.codename = "cherryview"
>  };
>  
>  #define SKYLAKE_FIELDS \
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
> -	.blt_tiling = &gen11_blt_info, \
> +	.cmds_info = &gen11_blt_info, \
>  	.codename = "skylake", \
>  	.is_skylake = true
>  
> @@ -268,7 +268,7 @@ static const struct intel_device_info intel_broxton_info = {
>  	.graphics_ver = 9,
>  	.display_ver = 9,
>  	.is_broxton = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "broxton"
>  };
>  
> @@ -276,7 +276,7 @@ static const struct intel_device_info intel_broxton_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_kabylake = true, \
> -	.blt_tiling = &gen11_blt_info, \
> +	.cmds_info = &gen11_blt_info, \
>  	.codename = "kabylake"
>  
>  static const struct intel_device_info intel_kabylake_gt1_info = {
> @@ -303,7 +303,7 @@ static const struct intel_device_info intel_geminilake_info = {
>  	.graphics_ver = 9,
>  	.display_ver = 9,
>  	.is_geminilake = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "geminilake"
>  };
>  
> @@ -311,7 +311,7 @@ static const struct intel_device_info intel_geminilake_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_coffeelake = true, \
> -	.blt_tiling = &gen11_blt_info, \
> +	.cmds_info = &gen11_blt_info, \
>  	.codename = "coffeelake"
>  
>  static const struct intel_device_info intel_coffeelake_gt1_info = {
> @@ -333,7 +333,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_cometlake = true, \
> -	.blt_tiling = &gen11_blt_info, \
> +	.cmds_info = &gen11_blt_info, \
>  	.codename = "cometlake"
>  
>  static const struct intel_device_info intel_cometlake_gt1_info = {
> @@ -350,7 +350,7 @@ static const struct intel_device_info intel_cannonlake_info = {
>  	.graphics_ver = 10,
>  	.display_ver = 10,
>  	.is_cannonlake = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "cannonlake"
>  };
>  
> @@ -358,7 +358,7 @@ static const struct intel_device_info intel_icelake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_icelake = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "icelake"
>  };
>  
> @@ -366,7 +366,7 @@ static const struct intel_device_info intel_elkhartlake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_elkhartlake = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "elkhartlake"
>  };
>  
> @@ -374,7 +374,7 @@ static const struct intel_device_info intel_jasperlake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_jasperlake = true,
> -	.blt_tiling = &gen11_blt_info,
> +	.cmds_info = &gen11_blt_info,
>  	.codename = "jasperlake"
>  };
>  
> @@ -382,7 +382,7 @@ static const struct intel_device_info intel_tigerlake_gt1_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_tigerlake = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "tigerlake",
>  	.gt = 1,
>  };
> @@ -391,7 +391,7 @@ static const struct intel_device_info intel_tigerlake_gt2_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_tigerlake = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "tigerlake",
>  	.gt = 2,
>  };
> @@ -400,7 +400,7 @@ static const struct intel_device_info intel_rocketlake_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_rocketlake = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "rocketlake"
>  };
>  
> @@ -409,7 +409,7 @@ static const struct intel_device_info intel_dg1_info = {
>  	.graphics_rel = 10,
>  	.display_ver = 12,
>  	.is_dg1 = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "dg1"
>  };
>  
> @@ -420,7 +420,7 @@ static const struct intel_device_info intel_dg2_info = {
>  	.has_4tile = true,
>  	.is_dg2 = true,
>  	.codename = "dg2",
> -	.blt_tiling = &gen12_dg2_blt_info,
> +	.cmds_info = &gen12_dg2_blt_info,
>  	.has_flatccs = true,
>  };
>  
> @@ -428,7 +428,7 @@ static const struct intel_device_info intel_alderlake_s_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_alderlake_s = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "alderlake_s"
>  };
>  
> @@ -436,7 +436,7 @@ static const struct intel_device_info intel_raptorlake_s_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_raptorlake_s = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "raptorlake_s"
>  };
>  
> @@ -444,7 +444,7 @@ static const struct intel_device_info intel_alderlake_p_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 13,
>  	.is_alderlake_p = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "alderlake_p"
>  };
>  
> @@ -452,7 +452,7 @@ static const struct intel_device_info intel_alderlake_n_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 13,
>  	.is_alderlake_n = true,
> -	.blt_tiling = &gen12_blt_info,
> +	.cmds_info = &gen12_blt_info,
>  	.codename = "alderlake_n"
>  };
>  
> @@ -463,7 +463,7 @@ static const struct intel_device_info intel_ats_m_info = {
>  	.is_dg2 = true,
>  	.has_4tile = true,
>  	.codename = "ats_m",
> -	.blt_tiling = &gen12_dg2_blt_info,
> +	.cmds_info = &gen12_dg2_blt_info,
>  	.has_flatccs = true,
>  };
>  
> @@ -474,7 +474,7 @@ static const struct intel_device_info intel_meteorlake_info = {
>  	.has_4tile = true,
>  	.is_meteorlake = true,
>  	.codename = "meteorlake",
> -	.blt_tiling = &gen12_mtl_blt_info
> +	.cmds_info = &gen12_mtl_blt_info

As you're touching this line add , at the end for the future changes.

With minor nit altered:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew
>  };
>  
>  static const struct pci_id_match intel_device_match[] = {
> @@ -616,19 +616,19 @@ out:
>   * intel_get_blt_info:
>   * @devid: pci device id
>   *
> - * Looks up information on blitter commands and tiling formats supported
> + * Looks up information on copy commands and tiling formats supported
>   * by the device.
>   *
>   * Returns:
> - * The associated blt_cmd_info, NULL if no such information is found
> + * The associated intel_cmds_info, NULL if no such information is found
>   */
> -const struct blt_cmd_info *intel_get_blt_info(uint16_t devid)
> +const struct intel_cmds_info *intel_get_blt_info(uint16_t devid)
>  {
>  	const struct intel_device_info *dev_info;
>  
>  	dev_info = intel_get_device_info(devid);
>  
> -	return dev_info->blt_tiling;
> +	return dev_info->cmds_info;
>  }
>  
>  /**
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions Karolina Stolarek
@ 2023-02-10  9:17   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:17 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:05PM +0100, Karolina Stolarek wrote:
> intel_cmds_info will describe other copy commands, not just
> these offered by blitter. Change the definition names to be
> more generic.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/intel_tiling_info.c | 12 ++++----
>  lib/i915/intel_tiling_info.h | 12 ++++----
>  lib/intel_device_info.c      | 58 ++++++++++++++++++------------------
>  3 files changed, 41 insertions(+), 41 deletions(-)
> 
> diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
> index 467e4b45..3df23b60 100644
> --- a/lib/i915/intel_tiling_info.c
> +++ b/lib/i915/intel_tiling_info.c
> @@ -51,27 +51,27 @@ static const struct blt_tiling_info
>  					     BIT(T_TILE4)  |
>  					     BIT(T_TILE64));
>  
> -const struct intel_cmds_info pre_gen8_blt_info = {
> +const struct intel_cmds_info pre_gen8_cmds_info = {

Please squash this with 1/9. You may keep rb.

--
Zbigniew

>  	.supported_cmds = {
>  		[SRC_COPY] = &src_copy,
>  		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
>  	}
>  };
>  
> -const struct intel_cmds_info gen8_blt_info = {
> +const struct intel_cmds_info gen8_cmds_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  	}
>  };
>  
> -const struct intel_cmds_info gen11_blt_info = {
> +const struct intel_cmds_info gen11_cmds_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen11_xy_fast_copy,
>  	}
>  };
>  
> -const struct intel_cmds_info gen12_blt_info = {
> +const struct intel_cmds_info gen12_cmds_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen12_xy_fast_copy,
> @@ -79,7 +79,7 @@ const struct intel_cmds_info gen12_blt_info = {
>  	}
>  };
>  
> -const struct intel_cmds_info gen12_dg2_blt_info = {
> +const struct intel_cmds_info gen12_dg2_cmds_info = {
>  	.supported_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
> @@ -87,7 +87,7 @@ const struct intel_cmds_info gen12_dg2_blt_info = {
>  	}
>  };
>  
> -const struct intel_cmds_info gen12_mtl_blt_info = {
> +const struct intel_cmds_info gen12_mtl_cmds_info = {
>  	.supported_cmds = {
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
>  		[XY_BLOCK_COPY] = &dg2_xy_block_copy
> diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
> index 2b310f0c..6854c64b 100644
> --- a/lib/i915/intel_tiling_info.h
> +++ b/lib/i915/intel_tiling_info.h
> @@ -35,12 +35,12 @@ struct intel_cmds_info {
>  	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
>  };
>  
> -extern const struct intel_cmds_info pre_gen8_blt_info;
> -extern const struct intel_cmds_info gen8_blt_info;
> -extern const struct intel_cmds_info gen11_blt_info;
> -extern const struct intel_cmds_info gen12_blt_info;
> -extern const struct intel_cmds_info gen12_dg2_blt_info;
> -extern const struct intel_cmds_info gen12_mtl_blt_info;
> +extern const struct intel_cmds_info pre_gen8_cmds_info;
> +extern const struct intel_cmds_info gen8_cmds_info;
> +extern const struct intel_cmds_info gen11_cmds_info;
> +extern const struct intel_cmds_info gen12_cmds_info;
> +extern const struct intel_cmds_info gen12_dg2_cmds_info;
> +extern const struct intel_cmds_info gen12_mtl_cmds_info;
>  
>  #define for_each_tiling(__tiling) \
>  	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index a4cfca6a..174e2b6f 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -145,7 +145,7 @@ static const struct intel_device_info intel_sandybridge_info = {
>  	.graphics_ver = 6,
>  	.display_ver = 6,
>  	.is_sandybridge = true,
> -	.cmds_info = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_cmds_info,
>  	.codename = "sandybridge"
>  };
>  static const struct intel_device_info intel_sandybridge_m_info = {
> @@ -153,7 +153,7 @@ static const struct intel_device_info intel_sandybridge_m_info = {
>  	.display_ver = 6,
>  	.is_mobile = true,
>  	.is_sandybridge = true,
> -	.cmds_info = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_cmds_info,
>  	.codename = "sandybridge"
>  };
>  
> @@ -161,7 +161,7 @@ static const struct intel_device_info intel_ivybridge_info = {
>  	.graphics_ver = 7,
>  	.display_ver = 7,
>  	.is_ivybridge = true,
> -	.cmds_info = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_cmds_info,
>  	.codename = "ivybridge"
>  };
>  static const struct intel_device_info intel_ivybridge_m_info = {
> @@ -169,7 +169,7 @@ static const struct intel_device_info intel_ivybridge_m_info = {
>  	.display_ver = 7,
>  	.is_mobile = true,
>  	.is_ivybridge = true,
> -	.cmds_info = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_cmds_info,
>  	.codename = "ivybridge"
>  };
>  
> @@ -177,7 +177,7 @@ static const struct intel_device_info intel_valleyview_info = {
>  	.graphics_ver = 7,
>  	.display_ver = 7,
>  	.is_valleyview = true,
> -	.cmds_info = &pre_gen8_blt_info,
> +	.cmds_info = &pre_gen8_cmds_info,
>  	.codename = "valleyview"
>  };
>  
> @@ -185,7 +185,7 @@ static const struct intel_device_info intel_valleyview_info = {
>  	.graphics_ver = 7, \
>  	.display_ver = 7, \
>  	.is_haswell = true, \
> -	.cmds_info = &pre_gen8_blt_info, \
> +	.cmds_info = &pre_gen8_cmds_info, \
>  	.codename = "haswell"
>  
>  static const struct intel_device_info intel_haswell_gt1_info = {
> @@ -207,7 +207,7 @@ static const struct intel_device_info intel_haswell_gt3_info = {
>  	.graphics_ver = 8, \
>  	.display_ver = 8, \
>  	.is_broadwell = true, \
> -	.cmds_info = &gen8_blt_info, \
> +	.cmds_info = &gen8_cmds_info, \
>  	.codename = "broadwell"
>  
>  static const struct intel_device_info intel_broadwell_gt1_info = {
> @@ -233,14 +233,14 @@ static const struct intel_device_info intel_cherryview_info = {
>  	.graphics_ver = 8,
>  	.display_ver = 8,
>  	.is_cherryview = true,
> -	.cmds_info = &gen8_blt_info,
> +	.cmds_info = &gen8_cmds_info,
>  	.codename = "cherryview"
>  };
>  
>  #define SKYLAKE_FIELDS \
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
> -	.cmds_info = &gen11_blt_info, \
> +	.cmds_info = &gen11_cmds_info, \
>  	.codename = "skylake", \
>  	.is_skylake = true
>  
> @@ -268,7 +268,7 @@ static const struct intel_device_info intel_broxton_info = {
>  	.graphics_ver = 9,
>  	.display_ver = 9,
>  	.is_broxton = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "broxton"
>  };
>  
> @@ -276,7 +276,7 @@ static const struct intel_device_info intel_broxton_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_kabylake = true, \
> -	.cmds_info = &gen11_blt_info, \
> +	.cmds_info = &gen11_cmds_info, \
>  	.codename = "kabylake"
>  
>  static const struct intel_device_info intel_kabylake_gt1_info = {
> @@ -303,7 +303,7 @@ static const struct intel_device_info intel_geminilake_info = {
>  	.graphics_ver = 9,
>  	.display_ver = 9,
>  	.is_geminilake = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "geminilake"
>  };
>  
> @@ -311,7 +311,7 @@ static const struct intel_device_info intel_geminilake_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_coffeelake = true, \
> -	.cmds_info = &gen11_blt_info, \
> +	.cmds_info = &gen11_cmds_info, \
>  	.codename = "coffeelake"
>  
>  static const struct intel_device_info intel_coffeelake_gt1_info = {
> @@ -333,7 +333,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
>  	.graphics_ver = 9, \
>  	.display_ver = 9, \
>  	.is_cometlake = true, \
> -	.cmds_info = &gen11_blt_info, \
> +	.cmds_info = &gen11_cmds_info, \
>  	.codename = "cometlake"
>  
>  static const struct intel_device_info intel_cometlake_gt1_info = {
> @@ -350,7 +350,7 @@ static const struct intel_device_info intel_cannonlake_info = {
>  	.graphics_ver = 10,
>  	.display_ver = 10,
>  	.is_cannonlake = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "cannonlake"
>  };
>  
> @@ -358,7 +358,7 @@ static const struct intel_device_info intel_icelake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_icelake = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "icelake"
>  };
>  
> @@ -366,7 +366,7 @@ static const struct intel_device_info intel_elkhartlake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_elkhartlake = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "elkhartlake"
>  };
>  
> @@ -374,7 +374,7 @@ static const struct intel_device_info intel_jasperlake_info = {
>  	.graphics_ver = 11,
>  	.display_ver = 11,
>  	.is_jasperlake = true,
> -	.cmds_info = &gen11_blt_info,
> +	.cmds_info = &gen11_cmds_info,
>  	.codename = "jasperlake"
>  };
>  
> @@ -382,7 +382,7 @@ static const struct intel_device_info intel_tigerlake_gt1_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_tigerlake = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "tigerlake",
>  	.gt = 1,
>  };
> @@ -391,7 +391,7 @@ static const struct intel_device_info intel_tigerlake_gt2_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_tigerlake = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "tigerlake",
>  	.gt = 2,
>  };
> @@ -400,7 +400,7 @@ static const struct intel_device_info intel_rocketlake_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_rocketlake = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "rocketlake"
>  };
>  
> @@ -409,7 +409,7 @@ static const struct intel_device_info intel_dg1_info = {
>  	.graphics_rel = 10,
>  	.display_ver = 12,
>  	.is_dg1 = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "dg1"
>  };
>  
> @@ -420,7 +420,7 @@ static const struct intel_device_info intel_dg2_info = {
>  	.has_4tile = true,
>  	.is_dg2 = true,
>  	.codename = "dg2",
> -	.cmds_info = &gen12_dg2_blt_info,
> +	.cmds_info = &gen12_dg2_cmds_info,
>  	.has_flatccs = true,
>  };
>  
> @@ -428,7 +428,7 @@ static const struct intel_device_info intel_alderlake_s_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_alderlake_s = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "alderlake_s"
>  };
>  
> @@ -436,7 +436,7 @@ static const struct intel_device_info intel_raptorlake_s_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 12,
>  	.is_raptorlake_s = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "raptorlake_s"
>  };
>  
> @@ -444,7 +444,7 @@ static const struct intel_device_info intel_alderlake_p_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 13,
>  	.is_alderlake_p = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "alderlake_p"
>  };
>  
> @@ -452,7 +452,7 @@ static const struct intel_device_info intel_alderlake_n_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 13,
>  	.is_alderlake_n = true,
> -	.cmds_info = &gen12_blt_info,
> +	.cmds_info = &gen12_cmds_info,
>  	.codename = "alderlake_n"
>  };
>  
> @@ -463,7 +463,7 @@ static const struct intel_device_info intel_ats_m_info = {
>  	.is_dg2 = true,
>  	.has_4tile = true,
>  	.codename = "ats_m",
> -	.cmds_info = &gen12_dg2_blt_info,
> +	.cmds_info = &gen12_dg2_cmds_info,
>  	.has_flatccs = true,
>  };
>  
> @@ -474,7 +474,7 @@ static const struct intel_device_info intel_meteorlake_info = {
>  	.has_4tile = true,
>  	.is_meteorlake = true,
>  	.codename = "meteorlake",
> -	.cmds_info = &gen12_mtl_blt_info
> +	.cmds_info = &gen12_mtl_cmds_info
>  };
>  
>  static const struct pci_id_match intel_device_match[] = {
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name Karolina Stolarek
@ 2023-02-10  9:19   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:19 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:06PM +0100, Karolina Stolarek wrote:
> Change supported_cmds field to blt_cmds to show it only describes
> blitter-specific copy commands.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/i915_blt.c          |  4 ++--
>  lib/i915/intel_tiling_info.c | 12 ++++++------
>  lib/i915/intel_tiling_info.h |  2 +-
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index 92860e8d..dace57b3 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -222,7 +222,7 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  {
>  	igt_require_f(cmds_info, "No config found for the platform\n");
>  
> -	return cmds_info->supported_cmds[cmd];
> +	return cmds_info->blt_cmds[cmd];

Squash with 1/9 and 2/9. Keep rb.

--
Zbigniew

>  }
>  
>  /**
> @@ -245,7 +245,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  	if (!cmds_info)
>  		return false;
>  
> -	tile_config = cmds_info->supported_cmds[cmd];
> +	tile_config = cmds_info->blt_cmds[cmd];
>  
>  	/* no config means no support for that tiling */
>  	if (!tile_config)
> diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_tiling_info.c
> index 3df23b60..78e1ce16 100644
> --- a/lib/i915/intel_tiling_info.c
> +++ b/lib/i915/intel_tiling_info.c
> @@ -52,27 +52,27 @@ static const struct blt_tiling_info
>  					     BIT(T_TILE64));
>  
>  const struct intel_cmds_info pre_gen8_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[SRC_COPY] = &src_copy,
>  		[XY_SRC_COPY] = &pre_gen8_xy_src_copy
>  	}
>  };
>  
>  const struct intel_cmds_info gen8_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  	}
>  };
>  
>  const struct intel_cmds_info gen11_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen11_xy_fast_copy,
>  	}
>  };
>  
>  const struct intel_cmds_info gen12_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &gen12_xy_fast_copy,
>  		[XY_BLOCK_COPY] = &gen12_xy_block_copy,
> @@ -80,7 +80,7 @@ const struct intel_cmds_info gen12_cmds_info = {
>  };
>  
>  const struct intel_cmds_info gen12_dg2_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[XY_SRC_COPY] = &gen8_xy_src_copy,
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
>  		[XY_BLOCK_COPY] = &dg2_xy_block_copy,
> @@ -88,7 +88,7 @@ const struct intel_cmds_info gen12_dg2_cmds_info = {
>  };
>  
>  const struct intel_cmds_info gen12_mtl_cmds_info = {
> -	.supported_cmds = {
> +	.blt_cmds = {
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
>  		[XY_BLOCK_COPY] = &dg2_xy_block_copy
>  	}
> diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_tiling_info.h
> index 6854c64b..fa8a9b9d 100644
> --- a/lib/i915/intel_tiling_info.h
> +++ b/lib/i915/intel_tiling_info.h
> @@ -32,7 +32,7 @@ struct blt_tiling_info {
>  };
>  
>  struct intel_cmds_info {
> -	struct blt_tiling_info const *supported_cmds[__BLT_MAX_CMD];
> +	struct blt_tiling_info const *blt_cmds[__BLT_MAX_CMD];
>  };
>  
>  extern const struct intel_cmds_info pre_gen8_cmds_info;
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter Karolina Stolarek
@ 2023-02-10  9:20   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:20 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:07PM +0100, Karolina Stolarek wrote:
> cmds_info, previously referred as blt_tiling, is not just limited
> to blitter commands. Keeping such reference in intel_get_blt_info()
> is misleading and confusing. Update the name of the function,
> together with the macro that uses it, to make their purpose clear.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/i915_blt.c     | 10 +++++-----
>  lib/intel_chipset.h     |  2 +-
>  lib/intel_device_info.c |  4 ++--
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index dace57b3..efc280f9 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -14,7 +14,7 @@
>  #include "i915_blt.h"
>  
>  #define BITRANGE(start, end) (end - start + 1)
> -#define GET_BLT_INFO(__fd) intel_get_blt_info(intel_get_drm_devid(__fd))
> +#define GET_CMDS_INFO(__fd) intel_get_cmds_info(intel_get_drm_devid(__fd))

Squash with 1/9, 2/9 and 3/9. Those changes are subject of blt->cmds rename
and may be introduced in single patch.

--
Zbigniew

>  
>  enum blt_special_mode {
>  	SM_NONE,
> @@ -265,7 +265,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>   */
>  bool blt_has_block_copy(int i915)
>  {
> -	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
>  
>  	return blt_supports_command(cmds_info, XY_BLOCK_COPY);
>  }
> @@ -281,7 +281,7 @@ bool blt_has_block_copy(int i915)
>   */
>  bool blt_has_fast_copy(int i915)
>  {
> -	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
>  
>  	return blt_supports_command(cmds_info, XY_FAST_COPY);
>  }
> @@ -298,7 +298,7 @@ bool blt_has_fast_copy(int i915)
>   */
>  bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>  {
> -	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
>  
>  	return blt_cmd_supports_tiling(cmds_info, XY_FAST_COPY, tiling);
>  }
> @@ -315,7 +315,7 @@ bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>   */
>  bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>  {
> -	const struct intel_cmds_info *cmds_info = GET_BLT_INFO(i915);
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
>  
>  	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
>  }
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 0ae59adc..3de67483 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -94,7 +94,7 @@ struct intel_device_info {
>  
>  const struct intel_device_info *intel_get_device_info(uint16_t devid) __attribute__((pure));
>  
> -const struct intel_cmds_info *intel_get_blt_info(uint16_t devid) __attribute__((pure));
> +const struct intel_cmds_info *intel_get_cmds_info(uint16_t devid) __attribute__((pure));
>  unsigned intel_gen(uint16_t devid) __attribute__((pure));
>  unsigned intel_graphics_ver(uint16_t devid) __attribute__((pure));
>  unsigned intel_display_ver(uint16_t devid) __attribute__((pure));
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 174e2b6f..2cd93c43 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -613,7 +613,7 @@ out:
>  }
>  
>  /**
> - * intel_get_blt_info:
> + * intel_get_cmds_info:
>   * @devid: pci device id
>   *
>   * Looks up information on copy commands and tiling formats supported
> @@ -622,7 +622,7 @@ out:
>   * Returns:
>   * The associated intel_cmds_info, NULL if no such information is found
>   */
> -const struct intel_cmds_info *intel_get_blt_info(uint16_t devid)
> +const struct intel_cmds_info *intel_get_cmds_info(uint16_t devid)
>  {
>  	const struct intel_device_info *dev_info;
>  
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library Karolina Stolarek
@ 2023-02-10  9:23   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:23 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:09PM +0100, Karolina Stolarek wrote:
> The structs here describe the properties of copy commands, not
> just tiling formats they support. Make the library name more
> generic.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>

Squash 5/9 and 6/9, then:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

> ---
>  lib/i915/i915_blt.h                                 | 2 +-
>  lib/i915/{intel_tiling_info.c => intel_cmds_info.c} | 2 +-
>  lib/i915/{intel_tiling_info.h => intel_cmds_info.h} | 4 ++--
>  lib/intel_chipset.h                                 | 2 +-
>  lib/meson.build                                     | 6 +++---
>  5 files changed, 8 insertions(+), 8 deletions(-)
>  rename lib/i915/{intel_tiling_info.c => intel_cmds_info.c} (98%)
>  rename lib/i915/{intel_tiling_info.h => intel_cmds_info.h} (93%)
> 
> diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
> index ceafc529..3fe47527 100644
> --- a/lib/i915/i915_blt.h
> +++ b/lib/i915/i915_blt.h
> @@ -47,7 +47,7 @@
>  #include <malloc.h>
>  #include "drm.h"
>  #include "igt.h"
> -#include "intel_tiling_info.h"
> +#include "intel_cmds_info.h"
>  
>  #define CCS_RATIO 256
>  
> diff --git a/lib/i915/intel_tiling_info.c b/lib/i915/intel_cmds_info.c
> similarity index 98%
> rename from lib/i915/intel_tiling_info.c
> rename to lib/i915/intel_cmds_info.c
> index e869acb3..9fce0351 100644
> --- a/lib/i915/intel_tiling_info.c
> +++ b/lib/i915/intel_cmds_info.c
> @@ -5,7 +5,7 @@
>  
>  #include <stdint.h>
>  #include "intel_chipset.h"
> -#include "i915/intel_tiling_info.h"
> +#include "i915/intel_cmds_info.h"
>  
>  #define BLT_INFO(_cmd, _tiling)  { \
>  		.blt_cmd_type = _cmd, \
> diff --git a/lib/i915/intel_tiling_info.h b/lib/i915/intel_cmds_info.h
> similarity index 93%
> rename from lib/i915/intel_tiling_info.h
> rename to lib/i915/intel_cmds_info.h
> index c7128a43..4fdce343 100644
> --- a/lib/i915/intel_tiling_info.h
> +++ b/lib/i915/intel_cmds_info.h
> @@ -3,8 +3,8 @@
>   * Copyright © 2022 Intel Corporation
>   */
>  
> -#ifndef __INTEL_TILING_INFO_H
> -#define __INTEL_TILING_INFO_H
> +#ifndef __INTEL_CMDS_INFO_H
> +#define __INTEL_CMDS_INFO_H
>  
>  #include <stdint.h>
>  
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 3de67483..c9762ae6 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -31,7 +31,7 @@
>  #include <pciaccess.h>
>  #include <stdbool.h>
>  
> -#include "i915/intel_tiling_info.h"
> +#include "i915/intel_cmds_info.h"
>  
>  #define BIT(x) (1ul <<(x))
>  
> diff --git a/lib/meson.build b/lib/meson.build
> index d49b78ca..c5131d9a 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -14,7 +14,7 @@ lib_sources = [
>  	'i915/intel_decode.c',
>  	'i915/intel_memory_region.c',
>  	'i915/intel_mocs.c',
> -	'i915/intel_tiling_info.c',
> +	'i915/intel_cmds_info.c',
>  	'i915/i915_blt.c',
>  	'i915/i915_crc.c',
>  	'igt_collection.c',
> @@ -219,7 +219,7 @@ igt_deps = [ lib_igt ] + lib_deps
>  lin_igt_chipset_build = static_library('igt_chipset',
>                                         ['intel_chipset.c',
>  					'intel_device_info.c',
> -					'i915/intel_tiling_info.c'],
> +					'i915/intel_cmds_info.c'],
>                                         include_directories : inc)
>  
>  lib_igt_chipset = declare_dependency(link_with : lin_igt_chipset_build,
> @@ -242,7 +242,7 @@ lib_igt_device_scan_build = static_library('igt_device_scan',
>  	'igt_list.c',
>  	'igt_tools_stub.c',
>  	'intel_device_info.c',
> -	'i915/intel_tiling_info.c',
> +	'i915/intel_cmds_info.c',
>  	],
>  	dependencies : scan_dep,
>  	include_directories : inc)
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties Karolina Stolarek
@ 2023-02-10  9:25   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:25 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:10PM +0100, Karolina Stolarek wrote:
> Blitter commands may have different properties depending on the
> platform. Add a new field to blt_cmd_info struct to describe
> their properties. Update block-copy definitions for DG2 and MTL
> to use that field.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> ---
>  lib/i915/intel_cmds_info.c | 28 ++++++++++++++++++++++------
>  lib/i915/intel_cmds_info.h |  4 ++++
>  2 files changed, 26 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/i915/intel_cmds_info.c b/lib/i915/intel_cmds_info.c
> index 9fce0351..59ee0403 100644
> --- a/lib/i915/intel_cmds_info.c
> +++ b/lib/i915/intel_cmds_info.c
> @@ -12,6 +12,12 @@
>  		.supported_tiling = _tiling \
>  	}
>  
> +#define BLT_INFO_EXT(_cmd, _tiling, _flags)  { \
> +		.blt_cmd_type = _cmd, \
> +		.supported_tiling = _tiling, \
> +		.flags = _flags, \
> +	}
> +
>  static const struct blt_cmd_info src_copy = BLT_INFO(SRC_COPY, BIT(T_LINEAR));
>  static const struct blt_cmd_info
>  		pre_gen8_xy_src_copy = BLT_INFO(XY_SRC_COPY,
> @@ -45,11 +51,21 @@ static const struct blt_cmd_info
>  					       BIT(T_LINEAR) |
>  					       BIT(T_YMAJOR));
>  static const struct blt_cmd_info
> -		dg2_xy_block_copy = BLT_INFO(XY_BLOCK_COPY,
> -					     BIT(T_LINEAR) |
> -					     BIT(T_XMAJOR) |
> -					     BIT(T_TILE4)  |
> -					     BIT(T_TILE64));
> +		dg2_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
> +						 BIT(T_LINEAR) |
> +						 BIT(T_XMAJOR) |
> +						 BIT(T_TILE4)  |
> +						 BIT(T_TILE64),
> +						 BLT_CMD_EXTENDED |
> +						 BLT_CMD_SUPPORTS_COMPRESSION);
> +
> +static const struct blt_cmd_info
> +		mtl_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
> +						 BIT(T_LINEAR) |
> +						 BIT(T_XMAJOR) |
> +						 BIT(T_TILE4)  |
> +						 BIT(T_TILE64),
> +						 BLT_CMD_EXTENDED);
>  
>  const struct intel_cmds_info pre_gen8_cmds_info = {
>  	.blt_cmds = {
> @@ -90,6 +106,6 @@ const struct intel_cmds_info gen12_dg2_cmds_info = {
>  const struct intel_cmds_info gen12_mtl_cmds_info = {
>  	.blt_cmds = {
>  		[XY_FAST_COPY] = &dg2_xy_fast_copy,
> -		[XY_BLOCK_COPY] = &dg2_xy_block_copy
> +		[XY_BLOCK_COPY] = &mtl_xy_block_copy,
>  	}
>  };
> diff --git a/lib/i915/intel_cmds_info.h b/lib/i915/intel_cmds_info.h
> index 4fdce343..541727ec 100644
> --- a/lib/i915/intel_cmds_info.h
> +++ b/lib/i915/intel_cmds_info.h
> @@ -29,6 +29,10 @@ enum blt_cmd_type {
>  struct blt_cmd_info {
>  	enum blt_cmd_type blt_cmd_type;
>  	uint32_t supported_tiling;
> +
> +	uint32_t flags;
> +#define BLT_CMD_EXTENDED               (1 << 0)
> +#define BLT_CMD_SUPPORTS_COMPRESSION   (1 << 1)
>  };

Great! Finally we can extract this information from blitter library
instead of checking manually platform version.

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

>  
>  struct intel_cmds_info {
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for command properties
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for " Karolina Stolarek
@ 2023-02-10  9:27   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:27 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:11PM +0100, Karolina Stolarek wrote:
> Add a predicate that checks if a command has a specific property.
> Introduce helpers that check if a platform uses an extended
> version of the block-copy command or supports compression. Add
> a getter for blt_cmd_info to intel_cmds_info library. Group
> functions together in i915_blt header file.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>

LGTM:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

> ---
>  lib/i915/i915_blt.c        | 64 ++++++++++++++++++++++++++++++++++++--
>  lib/i915/i915_blt.h        |  8 +++++
>  lib/i915/intel_cmds_info.c | 11 +++++++
>  lib/i915/intel_cmds_info.h |  3 ++
>  4 files changed, 84 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index 0ea25d2f..9b32a0e9 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -222,7 +222,7 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  {
>  	igt_require_f(cmds_info, "No config found for the platform\n");
>  
> -	return cmds_info->blt_cmds[cmd];
> +	return blt_get_cmd_info(cmds_info, cmd);
>  }
>  
>  /**
> @@ -245,7 +245,7 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  	if (!cmds_info)
>  		return false;
>  
> -	cmd_info = cmds_info->blt_cmds[cmd];
> +	cmd_info = blt_get_cmd_info(cmds_info, cmd);
>  
>  	/* no config means no support for that tiling */
>  	if (!cmd_info)
> @@ -254,6 +254,32 @@ bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  	return cmd_info->supported_tiling & BIT(tiling);
>  }
>  
> +/**
> + * blt_cmd_has_property:
> + * @cmds_info: Copy commands description struct
> + * @cmd: Blitter command enum
> + * @prop: property flag
> + *
> + * Checks if a @cmd entry of @cmds_info has @prop property. The properties can
> + * be freely combined, but the function will return true for platforms for
> + * which all properties defined in the bit flag are present. The function
> + * returns false if no information about the command is stored.
> + *
> + * Returns: true if it does, false otherwise
> + */
> +bool blt_cmd_has_property(const struct intel_cmds_info *cmds_info,
> +			  enum blt_cmd_type cmd, uint32_t prop)
> +{
> +	struct blt_cmd_info const *cmd_info;
> +
> +	cmd_info = blt_get_cmd_info(cmds_info, cmd);
> +
> +	if (!cmd_info)
> +		return false;
> +
> +	return cmd_info->flags & prop;
> +}
> +
>  /**
>   * blt_has_block_copy
>   * @i915: drm fd
> @@ -320,6 +346,40 @@ bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling)
>  	return blt_cmd_supports_tiling(cmds_info, XY_BLOCK_COPY, tiling);
>  }
>  
> +/**
> + * blt_block_copy_supports_compression
> + * @i915: drm fd
> + *
> + * Check if block copy provided by @i915 device supports compression.
> + *
> + * Returns:
> + * true if it does, false otherwise.
> + */
> +bool blt_block_copy_supports_compression(int i915)
> +{
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
> +
> +	return blt_cmd_has_property(cmds_info, XY_BLOCK_COPY,
> +				    BLT_CMD_SUPPORTS_COMPRESSION);
> +}
> +
> +/**
> + * blt_uses_extended_block_copy
> + * @i915: drm fd
> + *
> + * Check if block copy provided by @i915 device uses an extended version
> + * of the command.
> + *
> + * Returns:
> + * true if it does, false otherwise.
> + */
> +bool blt_uses_extended_block_copy(int i915)
> +{
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(i915);
> +
> +	return blt_cmd_has_property(cmds_info, XY_BLOCK_COPY, BLT_CMD_EXTENDED);
> +}
> +
>  /**
>   * blt_tiling_name:
>   * @tiling: tiling id
> diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
> index 3fe47527..6634533b 100644
> --- a/lib/i915/i915_blt.h
> +++ b/lib/i915/i915_blt.h
> @@ -163,10 +163,18 @@ bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
>  			     enum blt_cmd_type cmd,
>  			     enum blt_tiling_type tiling);
> +bool blt_cmd_has_property(const struct intel_cmds_info *cmds_info,
> +			  enum blt_cmd_type cmd,
> +			  uint32_t prop);
> +
>  bool blt_has_block_copy(int i915);
>  bool blt_has_fast_copy(int i915);
> +
>  bool blt_fast_copy_supports_tiling(int i915, enum blt_tiling_type tiling);
>  bool blt_block_copy_supports_tiling(int i915, enum blt_tiling_type tiling);
> +bool blt_block_copy_supports_compression(int i915);
> +bool blt_uses_extended_block_copy(int i915);
> +
>  const char *blt_tiling_name(enum blt_tiling_type tiling);
>  
>  uint64_t emit_blt_block_copy(int i915,
> diff --git a/lib/i915/intel_cmds_info.c b/lib/i915/intel_cmds_info.c
> index 59ee0403..2ac6bc2a 100644
> --- a/lib/i915/intel_cmds_info.c
> +++ b/lib/i915/intel_cmds_info.c
> @@ -4,6 +4,8 @@
>   */
>  
>  #include <stdint.h>
> +#include <stddef.h>
> +
>  #include "intel_chipset.h"
>  #include "i915/intel_cmds_info.h"
>  
> @@ -109,3 +111,12 @@ const struct intel_cmds_info gen12_mtl_cmds_info = {
>  		[XY_BLOCK_COPY] = &mtl_xy_block_copy,
>  	}
>  };
> +
> +const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
> +					    enum blt_cmd_type cmd)
> +{
> +	if (!cmds_info)
> +		return NULL;
> +
> +	return cmds_info->blt_cmds[cmd];
> +}
> diff --git a/lib/i915/intel_cmds_info.h b/lib/i915/intel_cmds_info.h
> index 541727ec..9bf6ecd5 100644
> --- a/lib/i915/intel_cmds_info.h
> +++ b/lib/i915/intel_cmds_info.h
> @@ -49,4 +49,7 @@ extern const struct intel_cmds_info gen12_mtl_cmds_info;
>  #define for_each_tiling(__tiling) \
>  	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++)
>  
> +const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
> +					    enum blt_cmd_type cmd);
> +
>  #endif
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support
  2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support Karolina Stolarek
@ 2023-02-10  9:29   ` Zbigniew Kempczyński
  0 siblings, 0 replies; 20+ messages in thread
From: Zbigniew Kempczyński @ 2023-02-10  9:29 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

On Thu, Feb 09, 2023 at 03:12:12PM +0100, Karolina Stolarek wrote:
> Use a helper that checks blitter command flags instead of directly
> checking Flat CCS compression support. Check for extended block-copy
> command when initializing the copy object in block_copy and
> block_multicopy tests.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>

Whole series look good for me now, this patch too:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

--
Zbigniew

> ---
>  lib/i915/i915_blt.c  | 17 -----------------
>  lib/i915/i915_blt.h  |  1 -
>  tests/i915/gem_ccs.c |  7 +++----
>  3 files changed, 3 insertions(+), 22 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index 9b32a0e9..63eba4ac 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -191,23 +191,6 @@ struct gen12_block_copy_data_ext {
>  	} dw21;
>  };
>  
> -/**
> - * blt_supports_compression:
> - * @i915: drm fd
> - *
> - * Function checks if HW supports flatccs compression in blitter commands
> - * on @i915 device.
> - *
> - * Returns:
> - * true if it does, false otherwise.
> - */
> -bool blt_supports_compression(int i915)
> -{
> -	uint32_t devid = intel_get_drm_devid(i915);
> -
> -	return HAS_FLATCCS(devid);
> -}
> -
>  /**
>   * blt_supports_command:
>   * @cmds_info: Copy commands description struct
> diff --git a/lib/i915/i915_blt.h b/lib/i915/i915_blt.h
> index 6634533b..c535961e 100644
> --- a/lib/i915/i915_blt.h
> +++ b/lib/i915/i915_blt.h
> @@ -157,7 +157,6 @@ struct blt_ctrl_surf_copy_data {
>  	bool print_bb;
>  };
>  
> -bool blt_supports_compression(int i915);
>  bool blt_supports_command(const struct intel_cmds_info *cmds_info,
>  			  enum blt_cmd_type cmd);
>  bool blt_cmd_supports_tiling(const struct intel_cmds_info *cmds_info,
> diff --git a/tests/i915/gem_ccs.c b/tests/i915/gem_ccs.c
> index a24c8e1f..b7e8bda7 100644
> --- a/tests/i915/gem_ccs.c
> +++ b/tests/i915/gem_ccs.c
> @@ -346,7 +346,6 @@ static void block_copy(int i915,
>  	uint32_t run_id = mid_tiling;
>  	uint32_t mid_region = region2, bb;
>  	uint32_t width = param.width, height = param.height;
> -	uint32_t devid = intel_get_drm_devid(i915);
>  	enum blt_compression mid_compression = config->compression;
>  	int mid_compression_format = param.compression_format;
>  	enum blt_compression_type comp_type = COMPRESSION_TYPE_3D;
> @@ -355,7 +354,7 @@ static void block_copy(int i915,
>  
>  	igt_assert(__gem_create_in_memory_regions(i915, &bb, &bb_size, region1) == 0);
>  
> -	if (!blt_supports_compression(i915) && !IS_METEORLAKE(devid))
> +	if (!blt_uses_extended_block_copy(i915))
>  		pext = NULL;
>  
>  	src = blt_create_object(i915, region1, width, height, bpp, uc_mocs,
> @@ -470,7 +469,7 @@ static void block_multicopy(int i915,
>  
>  	igt_assert(__gem_create_in_memory_regions(i915, &bb, &bb_size, region1) == 0);
>  
> -	if (!blt_supports_compression(i915))
> +	if (!blt_uses_extended_block_copy(i915))
>  		pext3 = NULL;
>  
>  	src = blt_create_object(i915, region1, width, height, bpp, uc_mocs,
> @@ -557,7 +556,7 @@ static void block_copy_test(int i915,
>  	const struct intel_execution_engine2 *e;
>  	int tiling;
>  
> -	if (config->compression && !blt_supports_compression(i915))
> +	if (config->compression && !blt_block_copy_supports_compression(i915))
>  		return;
>  
>  	if (config->inplace && !config->compression)
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Extend and rename intel_tiling_info library (rev2)
  2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
                   ` (9 preceding siblings ...)
  2023-02-09 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend and rename intel_tiling_info library (rev2) Patchwork
@ 2023-02-10 11:32 ` Patchwork
  10 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2023-02-10 11:32 UTC (permalink / raw)
  To: Karolina Stolarek; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 21725 bytes --]

== Series Details ==

Series: Extend and rename intel_tiling_info library (rev2)
URL   : https://patchwork.freedesktop.org/series/113785/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12721_full -> IGTPW_8478_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html

Participating hosts (9 -> 10)
------------------------------

  Additional (1): shard-tglu-9 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8478_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_suspend@basic-s3-without-i915:
    - {shard-dg1}:        [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-dg1-15/igt@i915_suspend@basic-s3-without-i915.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-dg1-18/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_frames@dp-crc-fast:
    - {shard-rkl}:        [SKIP][3] ([i915#7828]) -> [SKIP][4] +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-3/igt@kms_chamelium_frames@dp-crc-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@kms_chamelium_frames@dp-crc-fast.html

  * igt@kms_color@ctm-0-25:
    - {shard-rkl}:        NOTRUN -> [SKIP][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@kms_color@ctm-0-25.html

  * igt@kms_plane_multiple@tiling-y:
    - {shard-rkl}:        [SKIP][6] ([i915#4098]) -> [SKIP][7] +1 similar issue
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-4/igt@kms_plane_multiple@tiling-y.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@kms_plane_multiple@tiling-y.html

  
Known issues
------------

  Here are the changes found in IGTPW_8478_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          [PASS][8] -> [FAIL][9] ([i915#2842]) +3 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk8/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_lmem_swapping@massive-random:
    - shard-glk:          NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk3/igt@gem_lmem_swapping@massive-random.html

  * igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
    - shard-glk:          NOTRUN -> [SKIP][11] ([fdo#109271]) +45 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk2/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html

  * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
    - shard-glk:          NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([i915#79])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html

  * igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][15] ([fdo#109271]) +28 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-snb4/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html

  * igt@kms_psr2_su@frontbuffer-xrgb8888:
    - shard-glk:          NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#658])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk6/igt@kms_psr2_su@frontbuffer-xrgb8888.html

  * igt@kms_setmode@basic@pipe-a-vga-1:
    - shard-snb:          NOTRUN -> [FAIL][17] ([i915#5465]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-snb2/igt@kms_setmode@basic@pipe-a-vga-1.html

  
#### Possible fixes ####

  * igt@fbdev@eof:
    - {shard-rkl}:        [SKIP][18] ([i915#2582]) -> [PASS][19] +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-5/igt@fbdev@eof.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-3/igt@fbdev@eof.html

  * igt@gem_ctx_persistence@legacy-engines-hang@blt:
    - {shard-rkl}:        [SKIP][20] ([i915#6252]) -> [PASS][21]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-4/igt@gem_ctx_persistence@legacy-engines-hang@blt.html

  * igt@gem_eio@suspend:
    - {shard-rkl}:        [FAIL][22] ([i915#5115] / [i915#7052]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-4/igt@gem_eio@suspend.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-2/igt@gem_eio@suspend.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-glk:          [FAIL][24] ([i915#2842]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-glk1/igt@gem_exec_fair@basic-none-share@rcs0.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - {shard-rkl}:        [FAIL][26] ([i915#2842]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_exec_flush@basic-batch-kernel-default-cmd:
    - {shard-rkl}:        [SKIP][28] ([fdo#109313]) -> [PASS][29]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-2/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html

  * igt@gem_exec_reloc@basic-gtt-read-noreloc:
    - {shard-rkl}:        [SKIP][30] ([i915#3281]) -> [PASS][31] +7 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html

  * igt@gem_pread@snoop:
    - {shard-rkl}:        [SKIP][32] ([i915#3282]) -> [PASS][33] +4 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-1/igt@gem_pread@snoop.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@gem_pread@snoop.html

  * igt@gen9_exec_parse@bb-secure:
    - {shard-rkl}:        [SKIP][34] ([i915#2527]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-6/igt@gen9_exec_parse@bb-secure.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@gen9_exec_parse@bb-secure.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - {shard-dg1}:        [SKIP][36] ([i915#1397]) -> [PASS][37]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-dg1-15/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@i915_suspend@forcewake:
    - {shard-rkl}:        [FAIL][38] ([fdo#103375]) -> [PASS][39]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-4/igt@i915_suspend@forcewake.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-3/igt@i915_suspend@forcewake.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs:
    - {shard-rkl}:        [SKIP][40] ([i915#1845] / [i915#4098]) -> [PASS][41] +15 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][42] ([i915#2122]) -> [PASS][43] +1 similar issue
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-glk4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
    - {shard-rkl}:        [SKIP][44] ([i915#1849] / [i915#4098]) -> [PASS][45] +11 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
    - {shard-rkl}:        [SKIP][46] ([i915#1849]) -> [PASS][47] +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html

  * igt@kms_psr@basic:
    - {shard-rkl}:        [SKIP][48] ([i915#1072]) -> [PASS][49]
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-4/igt@kms_psr@basic.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-6/igt@kms_psr@basic.html

  * igt@prime_vgem@basic-write:
    - {shard-rkl}:        [SKIP][50] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12721/shard-rkl-3/igt@prime_vgem@basic-write.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/shard-rkl-5/igt@prime_vgem@basic-write.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
  [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
  [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
  [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
  [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
  [i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
  [i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
  [i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
  [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
  [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
  [i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7155 -> IGTPW_8478

  CI-20190529: 20190529
  CI_DRM_12721: e1f9df7a92c1e3da1009afa74dc1d08ef95c3d7c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8478: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html
  IGT_7155: 75c508d4e19c65683d4060cb3a772df600aaf23e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8478/index.html

[-- Attachment #2: Type: text/html, Size: 14961 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2023-02-10 11:32 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 14:12 [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library Karolina Stolarek
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 1/9] lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info Karolina Stolarek
2023-02-10  9:16   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 2/9] lib/intel_tiling_info: Update names of commands definitions Karolina Stolarek
2023-02-10  9:17   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 3/9] lib/intel_tiling_info: Update intel_cmds_info field name Karolina Stolarek
2023-02-10  9:19   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 4/9] lib/intel_device_info: Update name for cmds_info getter Karolina Stolarek
2023-02-10  9:20   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 5/9] lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info Karolina Stolarek
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 6/9] lib/i915: Rename intel_tiling_info library Karolina Stolarek
2023-02-10  9:23   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 7/9] lib/intel_cmds_info: Add flags field to describe command properties Karolina Stolarek
2023-02-10  9:25   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 8/9] lib/i915_blt: Add checks for " Karolina Stolarek
2023-02-10  9:27   ` Zbigniew Kempczyński
2023-02-09 14:12 ` [igt-dev] [PATCH i-g-t v3 9/9] tests/gem_ccs: Check for extended block-copy and compression support Karolina Stolarek
2023-02-10  9:29   ` Zbigniew Kempczyński
2023-02-09 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend and rename intel_tiling_info library (rev2) Patchwork
2023-02-10 11:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.