From: Arnd Bergmann <arnd@arndb.de>
To: Duc Dang <dhdang@apm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
Grant Likely <grant.likely@linaro.org>,
Liviu Dudau <Liviu.Dudau@arm.com>, Feng Kan <fkan@apm.com>,
linux-pci@vger.kernel.org, Tanmay Inamdar <tinamdar@apm.com>,
Loc Ho <lho@apm.com>
Subject: Re: [PATCH 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver
Date: Mon, 12 Jan 2015 20:44:50 +0100 [thread overview]
Message-ID: <1678162.2PJ2o1jRen@wuerfel> (raw)
In-Reply-To: <CADaLND=C3AjdZpiMpom7+-Dgwc83NYo5pDjDWo+hrW7VDZ4m3A@mail.gmail.com>
On Monday 12 January 2015 10:53:14 Duc Dang wrote:
> On Tue, Jan 6, 2015 at 11:33 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 06 January 2015 08:15:41 Duc Dang wrote:
> >> X-Gene v1 SOC supports total 2688 MSI/MSIX vectors coalesced into
> >> 16 HW IRQ lines.
> >>
> >> Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
> >> Signed-off-by: Duc Dang <dhdang@apm.com>
> >>
> >
> > I might be a little behind the latest development, but why is this
> > not a struct msi_controller?
>
> X-Gene V1 have a separate MSI block to handle MSI/MSIX and is shared
> among 5 PCIe ports.
> So in this driver for this MSI block, we implement X-Gene v1 sepcific
> arch_teardown_msi_irqs,
> arch_setup_msi_irqs and not using msi_controller struct.
I see.
> Please let me know if this approach needs to be changed to follow
> other implementations of MSI
> drivers in latest kernel.
Yes, your approach does not work on distro kernels which will always
enable multiple targets. You cannot override generic weak functions from
a device driver.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver
Date: Mon, 12 Jan 2015 20:44:50 +0100 [thread overview]
Message-ID: <1678162.2PJ2o1jRen@wuerfel> (raw)
In-Reply-To: <CADaLND=C3AjdZpiMpom7+-Dgwc83NYo5pDjDWo+hrW7VDZ4m3A@mail.gmail.com>
On Monday 12 January 2015 10:53:14 Duc Dang wrote:
> On Tue, Jan 6, 2015 at 11:33 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tuesday 06 January 2015 08:15:41 Duc Dang wrote:
> >> X-Gene v1 SOC supports total 2688 MSI/MSIX vectors coalesced into
> >> 16 HW IRQ lines.
> >>
> >> Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
> >> Signed-off-by: Duc Dang <dhdang@apm.com>
> >>
> >
> > I might be a little behind the latest development, but why is this
> > not a struct msi_controller?
>
> X-Gene V1 have a separate MSI block to handle MSI/MSIX and is shared
> among 5 PCIe ports.
> So in this driver for this MSI block, we implement X-Gene v1 sepcific
> arch_teardown_msi_irqs,
> arch_setup_msi_irqs and not using msi_controller struct.
I see.
> Please let me know if this approach needs to be changed to follow
> other implementations of MSI
> drivers in latest kernel.
Yes, your approach does not work on distro kernels which will always
enable multiple targets. You cannot override generic weak functions from
a device driver.
Arnd
next prev parent reply other threads:[~2015-01-12 19:46 UTC|newest]
Thread overview: 230+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 16:15 [PATCH 0/4] PCI: X-Gene: Add APM X-Gene v1 MSI/MSIX termination driver Duc Dang
2015-01-06 16:15 ` Duc Dang
2015-01-06 16:15 ` [PATCH 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe " Duc Dang
2015-01-06 16:15 ` Duc Dang
2015-01-06 19:33 ` Arnd Bergmann
2015-01-06 19:33 ` Arnd Bergmann
2015-01-12 18:53 ` Duc Dang
2015-01-12 18:53 ` Duc Dang
2015-01-12 19:44 ` Arnd Bergmann [this message]
2015-01-12 19:44 ` Arnd Bergmann
2015-03-04 19:39 ` [PATCH v2 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-03-04 19:39 ` Duc Dang
2015-03-18 17:43 ` Duc Dang
2015-03-18 17:43 ` Duc Dang
2015-03-19 20:49 ` Bjorn Helgaas
2015-03-19 20:49 ` Bjorn Helgaas
2015-03-19 20:59 ` Duc Dang
2015-03-19 20:59 ` Duc Dang
2015-03-19 21:08 ` Bjorn Helgaas
2015-03-19 21:08 ` Bjorn Helgaas
2015-03-04 19:39 ` [PATCH v2 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe " Duc Dang
2015-03-04 19:39 ` Duc Dang
2015-03-18 18:05 ` Marc Zyngier
2015-03-18 18:05 ` Marc Zyngier
2015-03-18 18:29 ` Duc Dang
2015-03-18 18:29 ` Duc Dang
2015-03-18 18:52 ` Marc Zyngier
2015-03-18 18:52 ` Marc Zyngier
2015-04-07 19:56 ` Duc Dang
2015-04-07 19:56 ` Duc Dang
2015-04-08 7:44 ` Marc Zyngier
2015-04-08 7:44 ` Marc Zyngier
2015-04-09 17:05 ` [PATCH v3 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-04-09 17:05 ` Duc Dang
2015-04-09 17:05 ` [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe " Duc Dang
2015-04-09 17:05 ` Duc Dang
2015-04-09 20:11 ` Bjorn Helgaas
2015-04-09 20:11 ` Bjorn Helgaas
2015-04-09 21:52 ` Duc Dang
2015-04-09 21:52 ` Duc Dang
2015-04-09 22:39 ` Bjorn Helgaas
2015-04-09 22:39 ` Bjorn Helgaas
2015-04-09 23:26 ` Duc Dang
2015-04-09 23:26 ` Duc Dang
2015-04-10 17:20 ` Marc Zyngier
2015-04-10 17:20 ` Marc Zyngier
2015-04-10 17:20 ` Marc Zyngier
2015-04-10 23:42 ` Duc Dang
2015-04-10 23:42 ` Duc Dang
2015-04-10 23:42 ` Duc Dang
2015-04-11 12:06 ` Marc Zyngier
2015-04-11 12:06 ` Marc Zyngier
2015-04-14 18:20 ` Duc Dang
2015-04-14 18:20 ` Duc Dang
2015-04-15 8:16 ` Marc Zyngier
2015-04-15 8:16 ` Marc Zyngier
2015-04-17 9:50 ` [PATCH v4 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-04-17 9:50 ` Duc Dang
2015-04-17 9:50 ` [PATCH v4 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe " Duc Dang
2015-04-17 9:50 ` Duc Dang
2015-04-17 14:10 ` Arnd Bergmann
2015-04-17 14:10 ` Arnd Bergmann
2015-04-19 18:40 ` Duc Dang
2015-04-19 18:40 ` Duc Dang
2015-04-19 19:55 ` Arnd Bergmann
2015-04-19 19:55 ` Arnd Bergmann
2015-04-20 18:49 ` Feng Kan
2015-04-20 18:49 ` Feng Kan
2015-04-20 18:49 ` Feng Kan
2015-04-21 7:16 ` Arnd Bergmann
2015-04-21 7:16 ` Arnd Bergmann
2015-04-17 9:50 ` [PATCH v4 2/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-04-17 9:50 ` Duc Dang
2015-04-17 9:50 ` [PATCH v4 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-04-17 9:50 ` Duc Dang
2015-04-17 9:50 ` [PATCH v4 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-04-17 9:50 ` Duc Dang
2015-04-17 10:00 ` [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-04-17 10:00 ` Duc Dang
2015-04-17 10:17 ` Marc Zyngier
2015-04-17 10:17 ` Marc Zyngier
2015-04-17 12:37 ` Duc Dang
2015-04-17 12:37 ` Duc Dang
2015-04-17 12:45 ` Marc Zyngier
2015-04-17 12:45 ` Marc Zyngier
2015-04-20 18:51 ` Feng Kan
2015-04-20 18:51 ` Feng Kan
2015-04-21 8:32 ` Marc Zyngier
2015-04-21 8:32 ` Marc Zyngier
2015-04-21 4:04 ` [PATCH v5 0/4]PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-04-21 4:04 ` Duc Dang
2015-04-22 3:02 ` Jon Masters
2015-04-22 3:02 ` Jon Masters
2015-04-22 3:02 ` Jon Masters
2015-04-22 3:02 ` Jon Masters
2015-04-21 4:04 ` [PATCH v5 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe " Duc Dang
2015-04-21 4:04 ` Duc Dang
2015-04-21 15:08 ` Marc Zyngier
2015-04-21 15:08 ` Marc Zyngier
2015-04-21 15:08 ` Marc Zyngier
2015-04-22 6:15 ` [PATCH v6 0/4]PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-04-22 6:15 ` Duc Dang
2015-04-22 6:15 ` [PATCH v6 1/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-04-22 6:15 ` Duc Dang
2015-04-22 6:15 ` [PATCH v6 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-04-22 6:15 ` Duc Dang
2015-04-22 12:50 ` Marc Zyngier
2015-04-22 12:50 ` Marc Zyngier
2015-04-22 12:50 ` Marc Zyngier
2015-05-18 9:55 ` [PATCH v7 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-05-18 9:55 ` Duc Dang
2015-05-18 9:55 ` [PATCH v7 1/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-05-18 9:55 ` Duc Dang
2015-05-18 9:55 ` [PATCH v7 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-18 9:55 ` Duc Dang
2015-05-20 9:16 ` Marc Zyngier
2015-05-20 9:16 ` Marc Zyngier
2015-05-20 9:16 ` Marc Zyngier
2015-05-22 18:41 ` [PATCH v8 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-05-22 18:41 ` Duc Dang
2015-05-22 18:41 ` [PATCH v8 1/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-05-22 18:41 ` Duc Dang
2015-05-22 18:41 ` [PATCH v8 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-22 18:41 ` Duc Dang
2015-05-25 11:52 ` Marc Zyngier
2015-05-25 11:52 ` Marc Zyngier
2015-05-25 11:52 ` Marc Zyngier
2015-05-27 18:27 ` [PATCH v9 0/4]PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-05-27 18:27 ` Duc Dang
2015-05-27 18:27 ` [PATCH v9 1/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-05-27 18:27 ` Duc Dang
2015-05-27 18:27 ` [PATCH v9 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-27 18:27 ` Duc Dang
2015-05-28 8:05 ` Marc Zyngier
2015-05-28 8:05 ` Marc Zyngier
2015-05-28 8:05 ` Marc Zyngier
2015-05-28 17:16 ` Duc Dang
2015-05-28 17:16 ` Duc Dang
2015-05-28 17:16 ` Duc Dang
2015-05-29 18:24 ` [PATCH v10 0/4] PCI: X-Gene: Add APM X-Gene v1 " Duc Dang
2015-05-29 18:24 ` Duc Dang
2015-06-05 21:05 ` Bjorn Helgaas
2015-06-05 21:05 ` Bjorn Helgaas
2015-06-05 21:11 ` Duc Dang
2015-06-05 21:11 ` Duc Dang
2015-05-29 18:24 ` [PATCH v10 1/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-05-29 18:24 ` Duc Dang
2015-05-29 18:24 ` [PATCH v10 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-29 18:24 ` Duc Dang
2015-05-29 18:24 ` [PATCH v10 3/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-05-29 18:24 ` Duc Dang
2015-05-29 18:24 ` [PATCH v10 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-05-29 18:24 ` Duc Dang
2015-05-27 18:27 ` [PATCH v9 3/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-05-27 18:27 ` Duc Dang
2015-05-27 18:27 ` [PATCH v9 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-05-27 18:27 ` Duc Dang
2015-05-27 18:31 ` [PATCH v8 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-27 18:31 ` Duc Dang
2015-05-27 18:31 ` Duc Dang
2015-05-22 18:41 ` [PATCH v8 3/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-05-22 18:41 ` Duc Dang
2015-05-22 18:41 ` [PATCH v8 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-05-22 18:41 ` Duc Dang
2015-05-22 18:43 ` [PATCH v7 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-22 18:43 ` Duc Dang
2015-05-22 18:43 ` Duc Dang
2015-05-18 9:55 ` [PATCH v7 3/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-05-18 9:55 ` Duc Dang
2015-05-18 9:55 ` [PATCH v7 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-05-18 9:55 ` Duc Dang
2015-05-18 10:12 ` [PATCH v6 2/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-05-18 10:12 ` Duc Dang
2015-05-18 10:12 ` Duc Dang
2015-04-22 6:15 ` [PATCH v6 3/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-04-22 6:15 ` Duc Dang
2015-04-22 6:15 ` [PATCH v6 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-04-22 6:15 ` Duc Dang
2015-04-21 4:04 ` [PATCH v5 2/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-04-21 4:04 ` Duc Dang
2015-04-21 15:19 ` Marc Zyngier
2015-04-21 15:19 ` Marc Zyngier
2015-04-21 15:19 ` Marc Zyngier
2015-04-21 18:01 ` Duc Dang
2015-04-21 18:01 ` Duc Dang
2015-04-21 18:01 ` Duc Dang
2015-04-21 4:04 ` [PATCH v5 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-04-21 4:04 ` Duc Dang
2015-04-21 15:42 ` Mark Rutland
2015-04-21 15:42 ` Mark Rutland
2015-04-21 15:42 ` Mark Rutland
2015-04-21 17:37 ` Duc Dang
2015-04-21 17:37 ` Duc Dang
2015-04-21 17:37 ` Duc Dang
2015-04-21 4:04 ` [PATCH v5 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-04-21 4:04 ` Duc Dang
2015-04-11 0:16 ` [PATCH v3 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Feng Kan
2015-04-11 0:16 ` Feng Kan
2015-04-11 0:16 ` Feng Kan
2015-04-11 12:18 ` Marc Zyngier
2015-04-11 12:18 ` Marc Zyngier
2015-04-11 14:50 ` Arnd Bergmann
2015-04-11 14:50 ` Arnd Bergmann
2015-04-11 14:50 ` Arnd Bergmann
2015-04-10 18:13 ` Paul Bolle
2015-04-10 18:13 ` Paul Bolle
2015-04-10 23:55 ` Duc Dang
2015-04-10 23:55 ` Duc Dang
2015-04-09 17:05 ` [PATCH v3 2/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-04-09 17:05 ` Duc Dang
2015-04-09 17:05 ` [PATCH v3 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-04-09 17:05 ` Duc Dang
2015-04-09 17:05 ` [PATCH v3 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-04-09 17:05 ` Duc Dang
2015-04-09 17:20 ` [PATCH v2 1/4] PCI: X-Gene: Add the APM X-Gene v1 PCIe MSI/MSIX termination driver Duc Dang
2015-04-09 17:20 ` Duc Dang
2015-03-04 19:39 ` [PATCH v2 2/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-03-04 19:39 ` Duc Dang
2015-03-04 19:39 ` [PATCH v2 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-03-04 19:39 ` Duc Dang
2015-03-04 19:40 ` [PATCH v2 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-03-04 19:40 ` Duc Dang
2015-01-06 16:15 ` [PATCH 2/4] arm64: dts: Add the device tree entry for the APM X-Gene PCIe MSI node Duc Dang
2015-01-06 16:15 ` Duc Dang
2015-01-06 16:15 ` [PATCH 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node Duc Dang
2015-01-06 16:15 ` Duc Dang
2015-01-06 19:34 ` Arnd Bergmann
2015-01-06 19:34 ` Arnd Bergmann
2015-01-06 16:15 ` [PATCH 4/4] PCI: X-Gene: Add the MAINTAINERS entry for APM X-Gene v1 PCIe MSI driver Duc Dang
2015-01-06 16:15 ` Duc Dang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1678162.2PJ2o1jRen@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=bhelgaas@google.com \
--cc=dhdang@apm.com \
--cc=fkan@apm.com \
--cc=grant.likely@linaro.org \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.