From: Vijendar Mukunda via Alsa-devel <alsa-devel@alsa-project.org>
To: <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
Mario.Limonciello@amd.com, amadeuszx.slawinski@linux.intel.com,
Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com,
claudiu.beznea@microchip.com,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Subject: [PATCH V7 0/8] Add SoundWire support for AMD platforms
Date: Fri, 10 Mar 2023 21:55:46 +0530 [thread overview]
Message-ID: <167846534670.26.8055589033873148829@mailman-core.alsa-project.org> (raw)
[-- Attachment #0: Type: message/rfc822, Size: 12675 bytes --]
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com, amadeuszx.slawinski@linux.intel.com, Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com, claudiu.beznea@microchip.com, Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Subject: [PATCH V7 0/8] Add SoundWire support for AMD platforms
Date: Fri, 10 Mar 2023 21:55:46 +0530
Message-ID: <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
ACP IP(v6.x) block has two SoundWire manager instance support.
This patchset adds support for AMD SoundWire manager driver.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
changes since v6:
- remove pm suspend check in amd_resume_child_device()
and always return 0.
- use same name convention for command and response
variables.
changes since v5:
- replace loops logic with read_poll_timeout()
throughout the code.
changes since v4:
- fix nit-picks in the code.
- update naming convention for control word and response
buffer vairables.
- drop pm_suspend check in prepare callback.
- use return statement instead of returning ret variable.
changes since v3:
- add usleep_range() in command/response implementation.
- add usleep_range() in clock stop sequence.
- modify usleep_range() values throughout the code.
- remove unncessary debug statement from code.
- update comment in probe() call.
- fix timeout condition checks in the code.
- drop "ret" variable in amd_disable_sdw_manager().
changes since v2:
- Remove useless variable initializations.
- Add helper function to interpret peripheral status.
- Move runtime pm sequence to probe_work workqueue.
- Use string "SoundWire" instead of "soundwire" in code.
- Update comments in interrupt handler and probe sequence.
- Rename "sdw_lock" as "acp_sdw_lock".
- Remove __func__ from dev_dbg statements.
changes since v1:
- Drop asoc tree based patches. will send asoc patches as a separate series.
- Fixed double space errors.
- Use dev instead of pci->dev.
- Use SoundWire manager terminology.
- Remove amd_sdw_compute_slave_ports() function and use exported
sdw_compute_slave_ports() function.
- Remove unused variable "num_ports" from amd_manager structure.
- Drop startup and shutdown dai callbacks.
- Drop reset_page_addr callback. - Use relative address offset to program SoundWire manager
registers throughout the code.
- Separate wake enable interrupt handling from slave status handling logic.
- Use acp_mmio to program ACP common registers.
- Use dai_runtime_array implementation in dai_ops.
- Refactor port_ops callbacks.
- Add comments in port_ops callbacks.
- Add retry count logic in irq thread to address faulty case.
- Add helper function to interpret command response.
- Add generic bandwidth allocation dependency in Kconfig options.
- Add comments for AMD SoundWire power modes.
- Add missing timeout check in amd_init_sdw_manager callback.
- Declare frameshape parameters in probe call.
- Handle error case in clock stop sequence.
- Add comments in pm_prepare and pm_ops callbacks.
Vijendar Mukunda (8):
soundwire: export sdw_compute_slave_ports() function
soundwire: amd: Add support for AMD Manager driver
soundwire: amd: register SoundWire manager dai ops
soundwire: amd: enable build for AMD SoundWire manager driver
soundwire: amd: add SoundWire manager interrupt handling
soundwire: amd: add runtime pm ops for AMD SoundWire manager driver
soundwire: amd: handle SoundWire wake enable interrupt
soundwire: amd: add pm_prepare callback and pm ops support
drivers/soundwire/Kconfig | 10 +
drivers/soundwire/Makefile | 4 +
drivers/soundwire/amd_manager.c | 1244 +++++++++++++++++
drivers/soundwire/amd_manager.h | 274 ++++
drivers/soundwire/bus.h | 9 +
.../soundwire/generic_bandwidth_allocation.c | 12 +-
include/linux/soundwire/sdw_amd.h | 109 ++
7 files changed, 1653 insertions(+), 9 deletions(-)
create mode 100644 drivers/soundwire/amd_manager.c
create mode 100644 drivers/soundwire/amd_manager.h
create mode 100644 include/linux/soundwire/sdw_amd.h
--
2.34.1
next reply other threads:[~2023-03-10 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 16:25 Vijendar Mukunda via Alsa-devel [this message]
[not found] <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
2023-03-10 16:54 ` [PATCH V7 0/8] Add SoundWire support for AMD platforms Pierre-Louis Bossart
2023-03-14 5:16 ` Mukunda,Vijendar via Alsa-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167846534670.26.8055589033873148829@mailman-core.alsa-project.org \
--to=alsa-devel@alsa-project.org \
--cc=Arungopal.kondaveeti@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Mastan.Katragadda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.