* [PATCH V7 0/8] Add SoundWire support for AMD platforms
@ 2023-03-10 16:25 Vijendar Mukunda via Alsa-devel
0 siblings, 0 replies; 3+ messages in thread
From: Vijendar Mukunda via Alsa-devel @ 2023-03-10 16:25 UTC (permalink / raw)
To: vkoul
Cc: alsa-devel, pierre-louis.bossart, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, Mario.Limonciello, amadeuszx.slawinski,
Mastan.Katragadda, Arungopal.kondaveeti, claudiu.beznea,
Vijendar Mukunda
[-- Attachment #0: Type: message/rfc822, Size: 12675 bytes --]
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com, amadeuszx.slawinski@linux.intel.com, Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com, claudiu.beznea@microchip.com, Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Subject: [PATCH V7 0/8] Add SoundWire support for AMD platforms
Date: Fri, 10 Mar 2023 21:55:46 +0530
Message-ID: <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
ACP IP(v6.x) block has two SoundWire manager instance support.
This patchset adds support for AMD SoundWire manager driver.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
changes since v6:
- remove pm suspend check in amd_resume_child_device()
and always return 0.
- use same name convention for command and response
variables.
changes since v5:
- replace loops logic with read_poll_timeout()
throughout the code.
changes since v4:
- fix nit-picks in the code.
- update naming convention for control word and response
buffer vairables.
- drop pm_suspend check in prepare callback.
- use return statement instead of returning ret variable.
changes since v3:
- add usleep_range() in command/response implementation.
- add usleep_range() in clock stop sequence.
- modify usleep_range() values throughout the code.
- remove unncessary debug statement from code.
- update comment in probe() call.
- fix timeout condition checks in the code.
- drop "ret" variable in amd_disable_sdw_manager().
changes since v2:
- Remove useless variable initializations.
- Add helper function to interpret peripheral status.
- Move runtime pm sequence to probe_work workqueue.
- Use string "SoundWire" instead of "soundwire" in code.
- Update comments in interrupt handler and probe sequence.
- Rename "sdw_lock" as "acp_sdw_lock".
- Remove __func__ from dev_dbg statements.
changes since v1:
- Drop asoc tree based patches. will send asoc patches as a separate series.
- Fixed double space errors.
- Use dev instead of pci->dev.
- Use SoundWire manager terminology.
- Remove amd_sdw_compute_slave_ports() function and use exported
sdw_compute_slave_ports() function.
- Remove unused variable "num_ports" from amd_manager structure.
- Drop startup and shutdown dai callbacks.
- Drop reset_page_addr callback. - Use relative address offset to program SoundWire manager
registers throughout the code.
- Separate wake enable interrupt handling from slave status handling logic.
- Use acp_mmio to program ACP common registers.
- Use dai_runtime_array implementation in dai_ops.
- Refactor port_ops callbacks.
- Add comments in port_ops callbacks.
- Add retry count logic in irq thread to address faulty case.
- Add helper function to interpret command response.
- Add generic bandwidth allocation dependency in Kconfig options.
- Add comments for AMD SoundWire power modes.
- Add missing timeout check in amd_init_sdw_manager callback.
- Declare frameshape parameters in probe call.
- Handle error case in clock stop sequence.
- Add comments in pm_prepare and pm_ops callbacks.
Vijendar Mukunda (8):
soundwire: export sdw_compute_slave_ports() function
soundwire: amd: Add support for AMD Manager driver
soundwire: amd: register SoundWire manager dai ops
soundwire: amd: enable build for AMD SoundWire manager driver
soundwire: amd: add SoundWire manager interrupt handling
soundwire: amd: add runtime pm ops for AMD SoundWire manager driver
soundwire: amd: handle SoundWire wake enable interrupt
soundwire: amd: add pm_prepare callback and pm ops support
drivers/soundwire/Kconfig | 10 +
drivers/soundwire/Makefile | 4 +
drivers/soundwire/amd_manager.c | 1244 +++++++++++++++++
drivers/soundwire/amd_manager.h | 274 ++++
drivers/soundwire/bus.h | 9 +
.../soundwire/generic_bandwidth_allocation.c | 12 +-
include/linux/soundwire/sdw_amd.h | 109 ++
7 files changed, 1653 insertions(+), 9 deletions(-)
create mode 100644 drivers/soundwire/amd_manager.c
create mode 100644 drivers/soundwire/amd_manager.h
create mode 100644 include/linux/soundwire/sdw_amd.h
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V7 0/8] Add SoundWire support for AMD platforms
2023-03-10 16:54 ` Pierre-Louis Bossart
@ 2023-03-14 5:16 ` Mukunda,Vijendar via Alsa-devel
0 siblings, 0 replies; 3+ messages in thread
From: Mukunda,Vijendar via Alsa-devel @ 2023-03-14 5:16 UTC (permalink / raw)
To: Pierre-Louis Bossart, vkoul
Cc: alsa-devel, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
Mario.Limonciello, amadeuszx.slawinski, Mastan.Katragadda,
Arungopal.kondaveeti, claudiu.beznea, vinod.koul
[-- Attachment #0: Type: message/rfc822, Size: 11294 bytes --]
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, vkoul@kernel.org
Cc: alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Mario.Limonciello@amd.com, amadeuszx.slawinski@linux.intel.com, Mastan.Katragadda@amd.com, Arungopal.kondaveeti@amd.com, claudiu.beznea@microchip.com, vinod.koul@linaro.org
Subject: Re: [PATCH V7 0/8] Add SoundWire support for AMD platforms
Date: Tue, 14 Mar 2023 10:46:56 +0530
Message-ID: <6e035c86-829f-5620-df87-fd7fd72d7e88@amd.com>
On 10/03/23 22:24, Pierre-Louis Bossart wrote:
>
> On 3/10/23 10:25, Vijendar Mukunda wrote:
>> ACP IP(v6.x) block has two SoundWire manager instance support.
>> This patchset adds support for AMD SoundWire manager driver.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> I provided my Reviewed-by tag for all 8 patches, all feedback was taken
> into account and the code looks good to me at this point. This was a
> productive interaction, much appreciated.
Thanks Bossart for valuable review comments.
@vkoul: Please have a look and let us know if you have any review comments.
We need to push ASoC patch series for upstream review, which is dependent on
soundwire patch series.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V7 0/8] Add SoundWire support for AMD platforms
[not found] <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
@ 2023-03-10 16:54 ` Pierre-Louis Bossart
2023-03-14 5:16 ` Mukunda,Vijendar via Alsa-devel
0 siblings, 1 reply; 3+ messages in thread
From: Pierre-Louis Bossart @ 2023-03-10 16:54 UTC (permalink / raw)
To: Vijendar Mukunda, vkoul
Cc: alsa-devel, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
Mario.Limonciello, amadeuszx.slawinski, Mastan.Katragadda,
Arungopal.kondaveeti, claudiu.beznea
On 3/10/23 10:25, Vijendar Mukunda wrote:
> ACP IP(v6.x) block has two SoundWire manager instance support.
> This patchset adds support for AMD SoundWire manager driver.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
I provided my Reviewed-by tag for all 8 patches, all feedback was taken
into account and the code looks good to me at this point. This was a
productive interaction, much appreciated.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 5:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 16:25 [PATCH V7 0/8] Add SoundWire support for AMD platforms Vijendar Mukunda via Alsa-devel
[not found] <20230310162554.699766-1-Vijendar.Mukunda@amd.com>
2023-03-10 16:54 ` Pierre-Louis Bossart
2023-03-14 5:16 ` Mukunda,Vijendar via Alsa-devel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.