All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver
@ 2023-03-22 14:00 Mauro Carvalho Chehab
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the " Mauro Carvalho Chehab
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-22 14:00 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

It is interesting to let IGT to unload/reload the Xe driver,
as it can help CI to track track troubles.

Add support for it.

Test documentation:

	==================
	igt@xe_module_load
	==================
	
	:Category: Sofware building block
	:File: tests/xe/xe_module_load.c
	:Sub-category: driver
	:Summary: Tests the xe module loading
	:Test category: functionality test
	
	igt@xe_module_load@force-load
	=============================
	
	:Description: Load the Xe driver passing ``force_probe=*`` parameter
	:Run type: BAT
	
	
	igt@xe_module_load@load
	=======================
	
	:Description: Load the Xe driver
	:Run type: FULL
	
	
	igt@xe_module_load@unload
	=========================
	
	:Description: Unload the Xe driver
	:Run type: FULL
	
	
	igt@xe_module_load@reload
	=========================
	
	:Description: Reload the Xe driver
	:Run type: FULL
	
	
	igt@xe_module_load@reload-no-display
	====================================
	
	:Description: Reload the Xe driver passing ``enable_display=0`` parameter
	:Run type: FULL
	
	
	igt@xe_module_load@many-reload
	==============================
	
	:Description: Reload the Xe driver many times
	:Run type: FULL

---

v3:
- no changes. Just rebased due to a merge conflict.

v2:

- added a patch (already submitted) to shut-up i915 trybot to
  try to run those tests when i915 driver is loaded;
- removed duplication of the unwanted drivers array and declare
  it as const with const strings;
- reordered includes and removed a duplication;
- did some cosmetic changes.

Mauro Carvalho Chehab (3):
  intel-ci: update blacklists to work with the Xe driver
  lib/igt_kmod: add support for Xe driver
  xe/xe_module_load: add a test to load/unload Xe driver

 lib/igt_kmod.c                           |  34 ++---
 lib/igt_kmod.h                           |  32 ++++-
 tests/intel-ci/blacklist.txt             | 130 +------------------
 tests/intel-ci/i915-blacklist.txt        | 133 +++++++++++++++++++
 tests/intel-ci/xe-blacklist.txt          |  21 +++
 tests/intel-ci/xe-fast-feedback.testlist |   3 +
 tests/meson.build                        |   1 +
 tests/xe/xe_module_load.c                | 158 +++++++++++++++++++++++
 8 files changed, 363 insertions(+), 149 deletions(-)
 mode change 100644 => 120000 tests/intel-ci/blacklist.txt
 create mode 100644 tests/intel-ci/i915-blacklist.txt
 create mode 100644 tests/intel-ci/xe-blacklist.txt
 create mode 100644 tests/xe/xe_module_load.c

-- 
2.39.2

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the Xe driver
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
@ 2023-03-22 14:00 ` Mauro Carvalho Chehab
  2023-03-22 17:44   ` Kamil Konieczny
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for " Mauro Carvalho Chehab
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-22 14:00 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

It doesn't make sense to run i915 tests with Xe driver and
vice-versa. Update testlists to make it clear.

In order to avoid disrupts at exiting intel-ci tests, keep a
symlink:
	i915-blacklist.txt -> blacklist.txt

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/intel-ci/blacklist.txt      | 130 +----------------------------
 tests/intel-ci/i915-blacklist.txt | 133 ++++++++++++++++++++++++++++++
 tests/intel-ci/xe-blacklist.txt   |  21 +++++
 3 files changed, 155 insertions(+), 129 deletions(-)
 mode change 100644 => 120000 tests/intel-ci/blacklist.txt
 create mode 100644 tests/intel-ci/i915-blacklist.txt
 create mode 100644 tests/intel-ci/xe-blacklist.txt

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
deleted file mode 100644
index 6e5cc43667cf..000000000000
--- a/tests/intel-ci/blacklist.txt
+++ /dev/null
@@ -1,129 +0,0 @@
-igt@meta_test(@.*)?
-###############################################
-# Handle module reloads with great care!
-#
-# Reloading a module is more likely to leave
-# the machine in an unexpected state than other
-# self-contained tests, leading to random
-# failures in tests run afterwards.
-###############################################
-#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
-igt@i915_pm_rpm@module-reload
-igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
-###############################################
-# GEM
-###############################################
-igt@gem_busy@hang.*
-igt@gem_close_race@(?!.*basic).*
-igt@gem_concurrent_blit(@.*)?
-igt@gem_ctx_create@(?!.*basic).*
-igt@gem_ctx_exec@(?!.*basic).*
-igt@gem_ctx_shared@*exhaust*
-igt@gem_ctx_switch(@.*)?
-igt@gem_evict_alignment(@.*)?
-igt@gem_evict_everything(@.*)?
-igt@gem_exec_big@(?!.*single).*
-igt@gem_exec_capture@many-(?!4K-).*
-igt@gem_exec_fair@(?!.*basic).*
-igt@gem_exec_fence@.*hang.*
-igt@gem_exec_flush@(?!.*basic).*
-igt@gem_exec_latency(@.*)?
-igt@gem_exec_lut_handle(@.*)?
-igt@gem_exec_nop@(?!.*basic).*
-igt@gem_exec_reloc@(?!.*basic).*
-igt@gem_exec_suspend@(?!.*basic).*
-igt@gem_exec_whisper@(?!basic).*
-igt@gem_fd_exhaustion(@.*)?
-igt@gem_fence_upload(@.*)?
-igt@gem_gtt_hog(@.*)?
-igt@gem_gtt_speed(@.*)?
-igt@gem_lut_handle(@.*)?
-igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
-igt@gem_mmap@.*(swap|huge).*
-igt@gem_pread_after_blit(@.*)?
-igt@gem_pwrite@(?!.*basic).*
-igt@gem_read_read_speed(@.*)?
-igt@gem_render_linear_blits@(?!.*basic).*
-igt@gem_render_tiled_blits@(?!.*basic).*
-igt@gem_reset_stats(@.*)?
-igt@gem_ringfill@(?!.*basic).*
-igt@gem_shrink@(?!reclaim$).*
-igt@gem_softpin@.*(hang|S4).*
-igt@gem_streaming_writes(@.*)?
-igt@gem_sync@(?!.*basic).*
-igt@gem_tiled_swapping@(?!non-threaded).*
-igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
-igt@gem_wait@hang.*
-igt@gem_watchdog@far-fence
-igt@sysfs_heartbeat_interval@(long|off)
-igt@sysfs_preempt_timeout@off
-igt@sysfs_timeslice_duration@off
-###############################################
-# GEM: Not worth fixing
-###############################################
-igt@gen7_exec_parse@.*lri.*
-igt@gem_exec_alignment@pi-shared
-###############################################
-# There are no DRRS capable displays in CI lab
-###############################################
-igt@kms_frontbuffer_tracking@.*drrs.*
-###############################################
-# Tends to generate invalid configurations
-# using CCS planes or configurations that
-# exceed HW capabilities resulting in sporadic
-# failure with -EINVAL.
-#
-# Maintaining extra constraints for Intel's HW
-# is too costly in comparison to the value
-# provided.
-###############################################
-igt@kms_chamelium_frames@hdmi-.*-planes-random
-###############################################
-# Broadcom
-###############################################
-igt@vc4_.*
-igt@v3d_.*
-###############################################
-# AMD
-###############################################
-igt@amdgpu/.*
-###############################################
-# Panfrost
-###############################################
-igt@panfrost_.*
-###############################################
-# Qualcomm
-###############################################
-igt@msm_.*
-###############################################
-# Hibernate: not configured correctly on CI
-###############################################
-igt@.*@.*-hibernate
-igt@gem_softpin@noreloc-s4
-igt@gem_workarounds@hibernate-.*
-igt@gem_exec_suspend@basic-s4$
-igt@gem_ctx_isolation@.*-s4
-###############################################
-# Out-of-memory: spammy and often broken
-###############################################
-igt@i915_suspend@shrink
-###############################################
-# pipe-e, pipe-f no current HW support
-###############################################
-igt@.*@.*pipe-e($|-.*)
-igt@.*@.*pipe-f($|-.*)
-
-###############################################
-# Temporary workarounds for CI-impacting bugs
-###############################################
-
-# Currently fails and leaves the machine in a very bad state, and
-# causes coverage loss for other tests. IOMMU related.
-# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
-igt@core_hotunplug@.*(hot|plug).*
-
-# hangs several gens of hosts, and has no immediate fix
-igt@device_reset@reset-bound
-
-# not working for i915
-igt@kms_bw@.*
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
new file mode 120000
index 000000000000..e48e29e27f4e
--- /dev/null
+++ b/tests/intel-ci/blacklist.txt
@@ -0,0 +1 @@
+i915-blacklist.txt
\ No newline at end of file
diff --git a/tests/intel-ci/i915-blacklist.txt b/tests/intel-ci/i915-blacklist.txt
new file mode 100644
index 000000000000..389a2acb7f44
--- /dev/null
+++ b/tests/intel-ci/i915-blacklist.txt
@@ -0,0 +1,133 @@
+igt@meta_test(@.*)?
+###############################################
+# Handle module reloads with great care!
+#
+# Reloading a module is more likely to leave
+# the machine in an unexpected state than other
+# self-contained tests, leading to random
+# failures in tests run afterwards.
+###############################################
+#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
+igt@i915_pm_rpm@module-reload
+igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
+###############################################
+# GEM
+###############################################
+igt@gem_busy@hang.*
+igt@gem_close_race@(?!.*basic).*
+igt@gem_concurrent_blit(@.*)?
+igt@gem_ctx_create@(?!.*basic).*
+igt@gem_ctx_exec@(?!.*basic).*
+igt@gem_ctx_shared@*exhaust*
+igt@gem_ctx_switch(@.*)?
+igt@gem_evict_alignment(@.*)?
+igt@gem_evict_everything(@.*)?
+igt@gem_exec_big@(?!.*single).*
+igt@gem_exec_capture@many-(?!4K-).*
+igt@gem_exec_fair@(?!.*basic).*
+igt@gem_exec_fence@.*hang.*
+igt@gem_exec_flush@(?!.*basic).*
+igt@gem_exec_latency(@.*)?
+igt@gem_exec_lut_handle(@.*)?
+igt@gem_exec_nop@(?!.*basic).*
+igt@gem_exec_reloc@(?!.*basic).*
+igt@gem_exec_suspend@(?!.*basic).*
+igt@gem_exec_whisper@(?!basic).*
+igt@gem_fd_exhaustion(@.*)?
+igt@gem_fence_upload(@.*)?
+igt@gem_gtt_hog(@.*)?
+igt@gem_gtt_speed(@.*)?
+igt@gem_lut_handle(@.*)?
+igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
+igt@gem_mmap@.*(swap|huge).*
+igt@gem_pread_after_blit(@.*)?
+igt@gem_pwrite@(?!.*basic).*
+igt@gem_read_read_speed(@.*)?
+igt@gem_render_linear_blits@(?!.*basic).*
+igt@gem_render_tiled_blits@(?!.*basic).*
+igt@gem_reset_stats(@.*)?
+igt@gem_ringfill@(?!.*basic).*
+igt@gem_shrink@(?!reclaim$).*
+igt@gem_softpin@.*(hang|S4).*
+igt@gem_streaming_writes(@.*)?
+igt@gem_sync@(?!.*basic).*
+igt@gem_tiled_swapping@(?!non-threaded).*
+igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
+igt@gem_wait@hang.*
+igt@gem_watchdog@far-fence
+igt@sysfs_heartbeat_interval@(long|off)
+igt@sysfs_preempt_timeout@off
+igt@sysfs_timeslice_duration@off
+###############################################
+# GEM: Not worth fixing
+###############################################
+igt@gen7_exec_parse@.*lri.*
+igt@gem_exec_alignment@pi-shared
+###############################################
+# There are no DRRS capable displays in CI lab
+###############################################
+igt@kms_frontbuffer_tracking@.*drrs.*
+###############################################
+# Tends to generate invalid configurations
+# using CCS planes or configurations that
+# exceed HW capabilities resulting in sporadic
+# failure with -EINVAL.
+#
+# Maintaining extra constraints for Intel's HW
+# is too costly in comparison to the value
+# provided.
+###############################################
+igt@kms_chamelium_frames@hdmi-.*-planes-random
+###############################################
+# Broadcom
+###############################################
+igt@vc4_.*
+igt@v3d_.*
+###############################################
+# Intel Xe
+###############################################
+igt@xe/.*
+###############################################
+# AMD
+###############################################
+igt@amdgpu/.*
+###############################################
+# Panfrost
+###############################################
+igt@panfrost_.*
+###############################################
+# Qualcomm
+###############################################
+igt@msm_.*
+###############################################
+# Hibernate: not configured correctly on CI
+###############################################
+igt@.*@.*-hibernate
+igt@gem_softpin@noreloc-s4
+igt@gem_workarounds@hibernate-.*
+igt@gem_exec_suspend@basic-s4$
+igt@gem_ctx_isolation@.*-s4
+###############################################
+# Out-of-memory: spammy and often broken
+###############################################
+igt@i915_suspend@shrink
+###############################################
+# pipe-e, pipe-f no current HW support
+###############################################
+igt@.*@.*pipe-e($|-.*)
+igt@.*@.*pipe-f($|-.*)
+
+###############################################
+# Temporary workarounds for CI-impacting bugs
+###############################################
+
+# Currently fails and leaves the machine in a very bad state, and
+# causes coverage loss for other tests. IOMMU related.
+# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
+igt@core_hotunplug@.*(hot|plug).*
+
+# hangs several gens of hosts, and has no immediate fix
+igt@device_reset@reset-bound
+
+# not working for i915
+igt@kms_bw@.*
diff --git a/tests/intel-ci/xe-blacklist.txt b/tests/intel-ci/xe-blacklist.txt
new file mode 100644
index 000000000000..986e91a67069
--- /dev/null
+++ b/tests/intel-ci/xe-blacklist.txt
@@ -0,0 +1,21 @@
+###############################################
+# Broadcom
+###############################################
+igt@vc4_.*
+igt@v3d_.*
+###############################################
+# Intel i915
+###############################################
+igt@i915/.*
+###############################################
+# AMD
+###############################################
+igt@amdgpu/.*
+###############################################
+# Panfrost
+###############################################
+igt@panfrost_.*
+###############################################
+# Qualcomm
+###############################################
+igt@msm_.*
-- 
2.39.2

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for Xe driver
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the " Mauro Carvalho Chehab
@ 2023-03-22 14:00 ` Mauro Carvalho Chehab
  2023-03-22 18:00   ` Kamil Konieczny
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-22 14:00 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

Change the kmod logic to also work with the Xe driver.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 lib/igt_kmod.c | 34 +++++++++++++++++-----------------
 lib/igt_kmod.h | 32 +++++++++++++++++++++++++++++---
 2 files changed, 46 insertions(+), 20 deletions(-)

diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 6d6ecf0187ed..ccf0063ca1b1 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -404,23 +404,23 @@ static void *strdup_realloc(char *origptr, const char *strdata)
 }
 
 /**
- * igt_i915_driver_load:
- * @opts: options to pass to i915 driver
+ * igt_intel_driver_load:
+ * @opts: options to pass to Intel driver
  *
- * Loads the i915 driver and its dependencies.
+ * Loads an Intel driver and its dependencies.
  *
  */
 int
-igt_i915_driver_load(const char *opts)
+igt_intel_driver_load(const char *opts, const char *driver)
 {
 	int ret;
 
 	if (opts)
-		igt_info("Reloading i915 with %s\n\n", opts);
+		igt_info("Reloading %s with %s\n\n", driver, opts);
 
-	ret = igt_kmod_load("i915", opts);
+	ret = igt_kmod_load(driver, opts);
 	if (ret) {
-		igt_debug("Could not load i915\n");
+		igt_debug("Could not load %s\n", driver);
 		return ret;
 	}
 
@@ -496,7 +496,7 @@ int igt_audio_driver_unload(char **who)
 	return igt_always_unload_audio_driver(who);
 }
 
-int __igt_i915_driver_unload(char **who)
+int __igt_intel_driver_unload(char **who, const char *driver)
 {
 	int ret;
 
@@ -530,11 +530,11 @@ int __igt_i915_driver_unload(char **who)
 		}
 	}
 
-	if (igt_kmod_is_loaded("i915")) {
-		ret = igt_kmod_unload("i915", 0);
+	if (igt_kmod_is_loaded(driver)) {
+		ret = igt_kmod_unload(driver, 0);
 		if (ret) {
 			if (who)
-				*who = strdup_realloc(*who, "i915");
+				*who = strdup_realloc(*who, driver);
 
 			return ret;
 		}
@@ -544,18 +544,18 @@ int __igt_i915_driver_unload(char **who)
 }
 
 /**
- * igt_i915_driver_unload:
+ * igt_intel_driver_unload:
  *
- * Unloads the i915 driver and its dependencies.
+ * Unloads an Intel driver and its dependencies.
  *
  */
 int
-igt_i915_driver_unload(void)
+igt_intel_driver_unload(const char *driver)
 {
 	char *who = NULL;
 	int ret;
 
-	ret = __igt_i915_driver_unload(&who);
+	ret = __igt_intel_driver_unload(&who, driver);
 	if (ret) {
 		igt_warn("Could not unload %s\n", who);
 		igt_kmod_list_loaded();
@@ -572,8 +572,8 @@ igt_i915_driver_unload(void)
 	igt_kmod_unload("drm_kms_helper", 0);
 	igt_kmod_unload("drm", 0);
 
-	if (igt_kmod_is_loaded("i915")) {
-		igt_warn("i915.ko still loaded!\n");
+	if (igt_kmod_is_loaded("driver")) {
+		igt_warn("%s.ko still loaded!\n", driver);
 		return -EBUSY;
 	}
 
diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
index f98dd29fb175..d05af4a69410 100644
--- a/lib/igt_kmod.h
+++ b/lib/igt_kmod.h
@@ -38,9 +38,35 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
 
 int igt_audio_driver_unload(char **whom);
 
-int igt_i915_driver_load(const char *opts);
-int igt_i915_driver_unload(void);
-int __igt_i915_driver_unload(char **whom);
+int igt_intel_driver_load(const char *opts, const char *driver);
+int igt_intel_driver_unload(const char *driver);
+int __igt_intel_driver_unload(char **who, const char *driver);
+
+static inline int igt_i915_driver_load(const char *opts)
+{
+	return igt_intel_driver_load(opts, "i915");
+}
+
+static inline int igt_i915_driver_unload(void)
+{
+	return igt_intel_driver_unload("i915");
+}
+
+static inline int __igt_i915_driver_unload(char **whom)
+{
+	return __igt_intel_driver_unload(whom, "i915");
+};
+
+static inline int igt_xe_driver_load(const char *opts)
+{
+	return igt_intel_driver_load(opts, "xe");
+}
+
+
+static inline int igt_xe_driver_unload(void)
+{
+	return igt_intel_driver_unload("xe");
+}
 
 int igt_amdgpu_driver_load(const char *opts);
 int igt_amdgpu_driver_unload(void);
-- 
2.39.2

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload Xe driver
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the " Mauro Carvalho Chehab
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for " Mauro Carvalho Chehab
@ 2023-03-22 14:00 ` Mauro Carvalho Chehab
  2023-03-22 18:13   ` Kamil Konieczny
  2023-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for xe/xe_module_load: add a test to load/unload Xe driver (rev2) Patchwork
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-22 14:00 UTC (permalink / raw)
  To: igt-dev

From: Mauro Carvalho Chehab <mchehab@kernel.org>

This is helpful to allow IGT to check if there are issues
during module load/unload.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 tests/intel-ci/xe-fast-feedback.testlist |   3 +
 tests/meson.build                        |   1 +
 tests/xe/xe_module_load.c                | 158 +++++++++++++++++++++++
 3 files changed, 162 insertions(+)
 create mode 100644 tests/xe/xe_module_load.c

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 6525b1676b6f..3140d648833a 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -1,3 +1,6 @@
+# Should be the first test
+igt@xe_module_load@force-load
+
 igt@xe_compute@compute-square
 igt@xe_debugfs@base
 igt@xe_debugfs@gt
diff --git a/tests/meson.build b/tests/meson.build
index 2e62ff231416..9235d240fd85 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -256,6 +256,7 @@ xe_progs = [
 	'xe_huc_copy',
 	'xe_mmap',
 	'xe_mmio',
+	'xe_module_load',
 	'xe_noexec_ping_pong',
 	'xe_pm',
 	'xe_prime_self_import',
diff --git a/tests/xe/xe_module_load.c b/tests/xe/xe_module_load.c
new file mode 100644
index 000000000000..9a38d70858d1
--- /dev/null
+++ b/tests/xe/xe_module_load.c
@@ -0,0 +1,158 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+/**
+ * TEST: Tests the xe module loading
+ * Category: Sofware building block
+ * Sub-category: driver
+ * Test category: functionality test
+ */
+
+#include <dirent.h>
+#include <fcntl.h>
+#include <libgen.h>
+#include <signal.h>
+
+#ifdef __linux__
+#include <linux/limits.h>
+#endif
+
+#include <sys/ioctl.h>
+#include <sys/utsname.h>
+
+#include "igt.h"
+
+#include "igt_aux.h"
+#include "igt_core.h"
+#include "igt_debugfs.h"
+#include "igt_kmod.h"
+#include "igt_sysfs.h"
+
+#define BAR_SIZE_SHIFT 20
+#define MIN_BAR_SIZE 256
+
+static void hda_dynamic_debug(bool enable)
+{
+	FILE *fp;
+	static const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
+	static const char snd_hda_core_on[] = "module snd_hda_core +pf";
+
+	static const char snd_hda_intel_off[] = "module snd_hda_core =_";
+	static const char snd_hda_core_off[] = "module snd_hda_intel =_";
+
+	fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
+	if (!fp) {
+		igt_debug("hda dynamic debug not available\n");
+		return;
+	}
+
+	if (enable) {
+		fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
+		fwrite(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
+	} else {
+		fwrite(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
+		fwrite(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
+	}
+
+	fclose(fp);
+}
+
+static void load_and_check_xe(const char *opts)
+{
+	int error;
+	int drm_fd;
+
+	hda_dynamic_debug(true);
+	error = igt_xe_driver_load(opts);
+	hda_dynamic_debug(false);
+
+	igt_assert_eq(error, 0);
+
+	/* driver is ready, check if it's bound */
+	drm_fd = __drm_open_driver(DRIVER_XE);
+	igt_fail_on_f(drm_fd < 0, "Cannot open the xe DRM driver after modprobing xe.\n");
+}
+
+static const char * const unwanted_drivers[] = {
+	"xe",
+	"i915",
+	NULL
+};
+
+/**
+ * SUBTEST: force-load
+ * Description: Load the Xe driver passing ``force_probe=*`` parameter
+ * Run type: BAT
+ *
+ * SUBTEST: load
+ * Description: Load the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: unload
+ * Description: Unload the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: reload
+ * Description: Reload the Xe driver
+ * Run type: FULL
+ *
+ * SUBTEST: reload-no-display
+ * Description: Reload the Xe driver passing ``enable_display=0`` parameter
+ * Run type: FULL
+ *
+ * SUBTEST: many-reload
+ * Description: Reload the Xe driver many times
+ * Run type: FULL
+ */
+igt_main
+{
+	igt_describe("Check if xe and friends are not yet loaded, then load them.");
+	igt_subtest("load") {
+		for (int i = 0; unwanted_drivers[i] != NULL; i++) {
+			igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
+				      "%s is already loaded\n", unwanted_drivers[i]);
+		}
+
+		load_and_check_xe(NULL);
+	}
+
+	igt_subtest("unload") {
+		igt_xe_driver_unload();
+	}
+
+	igt_subtest("force-load") {
+		for (int i = 0; unwanted_drivers[i] != NULL; i++) {
+			igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
+				      "%s is already loaded\n", unwanted_drivers[i]);
+		}
+
+		load_and_check_xe("force_probe=*");
+	}
+
+	igt_subtest("reload-no-display") {
+		igt_xe_driver_unload();
+		load_and_check_xe("enable_display=0");
+	}
+
+	igt_subtest("many-reload") {
+		int i;
+
+		for (i = 0; i < 10; i++) {
+			igt_debug("reload cycle: %d\n", i);
+			igt_xe_driver_unload();
+			load_and_check_xe(NULL);
+			sleep(1);
+		}
+	}
+
+	igt_subtest("reload") {
+		igt_xe_driver_unload();
+		load_and_check_xe(NULL);
+
+		/* only default modparams, can leave module loaded */
+	}
+
+	/* Subtests should unload the module themselves if they use modparams */
+}
-- 
2.39.2

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for xe/xe_module_load: add a test to load/unload Xe driver (rev2)
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
                   ` (2 preceding siblings ...)
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
@ 2023-03-22 15:02 ` Patchwork
  2023-03-22 19:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2023-03-23  8:27 ` [igt-dev] ✗ Fi.CI.BUILD: failure for xe/xe_module_load: add a test to load/unload Xe driver (rev3) Patchwork
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-03-22 15:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 6457 bytes --]

== Series Details ==

Series: xe/xe_module_load: add a test to load/unload Xe driver (rev2)
URL   : https://patchwork.freedesktop.org/series/115511/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12897 -> IGTPW_8662
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html

Participating hosts (36 -> 37)
------------------------------

  Additional (2): fi-kbl-soraka fi-pnv-d510 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_8662 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-FAIL][4] ([i915#6997] / [i915#7913])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@i915_selftest@live@slpc.html
    - bat-rpls-1:         [PASS][5] -> [DMESG-FAIL][6] ([i915#6367] / [i915#7996])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-rpls-1/igt@i915_selftest@live@slpc.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-1/igt@i915_selftest@live@slpc.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271]) +16 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-rpls-2:         NOTRUN -> [SKIP][8] ([i915#7828])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
    - bat-rpls-1:         NOTRUN -> [SKIP][9] ([i915#7828])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-1/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-rpls-1:         NOTRUN -> [SKIP][10] ([i915#1845])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
    - bat-rpls-2:         NOTRUN -> [SKIP][11] ([i915#1845])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html

  * igt@kms_psr@primary_page_flip:
    - fi-pnv-d510:        NOTRUN -> [SKIP][12] ([fdo#109271]) +38 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/fi-pnv-d510/igt@kms_psr@primary_page_flip.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0@smem:
    - bat-rpls-2:         [ABORT][13] -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@gem_exec_suspend@basic-s0@smem.html

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-rpls-1:         [ABORT][15] ([i915#6687] / [i915#7978]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-1/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-11:         [FAIL][17] -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-dg2-11/igt@i915_pm_rps@basic-api.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-dg2-11/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_pm:
    - bat-rpls-2:         [DMESG-FAIL][19] ([i915#4258]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

  * igt@i915_selftest@live@mman:
    - bat-rpls-2:         [TIMEOUT][21] ([i915#6794]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/bat-rpls-2/igt@i915_selftest@live@mman.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/bat-rpls-2/igt@i915_selftest@live@mman.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
  [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
  [i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7211 -> IGTPW_8662

  CI-20190529: 20190529
  CI_DRM_12897: 48de8fde637e7fb42e44046fbb3f33199d36ea6b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8662: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html
  IGT_7211: c0cc1de7b2f4041ca68960362aa55f881d416bac @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@xe_module_load@force-load
+igt@xe_module_load@load
+igt@xe_module_load@many-reload
+igt@xe_module_load@reload
+igt@xe_module_load@reload-no-display
+igt@xe_module_load@unload

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html

[-- Attachment #2: Type: text/html, Size: 7798 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the Xe driver
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the " Mauro Carvalho Chehab
@ 2023-03-22 17:44   ` Kamil Konieczny
  2023-03-23  7:50     ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2023-03-22 17:44 UTC (permalink / raw)
  To: igt-dev

Hi Mauro,

On 2023-03-22 at 15:00:28 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> It doesn't make sense to run i915 tests with Xe driver and
> vice-versa. Update testlists to make it clear.
> 
> In order to avoid disrupts at exiting intel-ci tests, keep a
> symlink:
> 	i915-blacklist.txt -> blacklist.txt
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  tests/intel-ci/blacklist.txt      | 130 +----------------------------
>  tests/intel-ci/i915-blacklist.txt | 133 ++++++++++++++++++++++++++++++

Why not just git mv oldfile newfile ?
But that aside, imho better solution would be to just
add xe_* to blacklist. I am also not sure you can include
one blacklist into another.

+Cc: Petri Latvala <adrinael@adrinael.net>

>  tests/intel-ci/xe-blacklist.txt   |  21 +++++
>  3 files changed, 155 insertions(+), 129 deletions(-)
>  mode change 100644 => 120000 tests/intel-ci/blacklist.txt
>  create mode 100644 tests/intel-ci/i915-blacklist.txt
>  create mode 100644 tests/intel-ci/xe-blacklist.txt
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> deleted file mode 100644
> index 6e5cc43667cf..000000000000
> --- a/tests/intel-ci/blacklist.txt
> +++ /dev/null
> @@ -1,129 +0,0 @@
> -igt@meta_test(@.*)?
> -###############################################
> -# Handle module reloads with great care!
> -#
> -# Reloading a module is more likely to leave
> -# the machine in an unexpected state than other
> -# self-contained tests, leading to random
> -# failures in tests run afterwards.
> -###############################################
> -#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
> -igt@i915_pm_rpm@module-reload
> -igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
> -###############################################
> -# GEM
> -###############################################
> -igt@gem_busy@hang.*
> -igt@gem_close_race@(?!.*basic).*
> -igt@gem_concurrent_blit(@.*)?
> -igt@gem_ctx_create@(?!.*basic).*
> -igt@gem_ctx_exec@(?!.*basic).*
> -igt@gem_ctx_shared@*exhaust*
> -igt@gem_ctx_switch(@.*)?
> -igt@gem_evict_alignment(@.*)?
> -igt@gem_evict_everything(@.*)?
> -igt@gem_exec_big@(?!.*single).*
> -igt@gem_exec_capture@many-(?!4K-).*
> -igt@gem_exec_fair@(?!.*basic).*
> -igt@gem_exec_fence@.*hang.*
> -igt@gem_exec_flush@(?!.*basic).*
> -igt@gem_exec_latency(@.*)?
> -igt@gem_exec_lut_handle(@.*)?
> -igt@gem_exec_nop@(?!.*basic).*
> -igt@gem_exec_reloc@(?!.*basic).*
> -igt@gem_exec_suspend@(?!.*basic).*
> -igt@gem_exec_whisper@(?!basic).*
> -igt@gem_fd_exhaustion(@.*)?
> -igt@gem_fence_upload(@.*)?
> -igt@gem_gtt_hog(@.*)?
> -igt@gem_gtt_speed(@.*)?
> -igt@gem_lut_handle(@.*)?
> -igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
> -igt@gem_mmap@.*(swap|huge).*
> -igt@gem_pread_after_blit(@.*)?
> -igt@gem_pwrite@(?!.*basic).*
> -igt@gem_read_read_speed(@.*)?
> -igt@gem_render_linear_blits@(?!.*basic).*
> -igt@gem_render_tiled_blits@(?!.*basic).*
> -igt@gem_reset_stats(@.*)?
> -igt@gem_ringfill@(?!.*basic).*
> -igt@gem_shrink@(?!reclaim$).*
> -igt@gem_softpin@.*(hang|S4).*
> -igt@gem_streaming_writes(@.*)?
> -igt@gem_sync@(?!.*basic).*
> -igt@gem_tiled_swapping@(?!non-threaded).*
> -igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
> -igt@gem_wait@hang.*
> -igt@gem_watchdog@far-fence
> -igt@sysfs_heartbeat_interval@(long|off)
> -igt@sysfs_preempt_timeout@off
> -igt@sysfs_timeslice_duration@off
> -###############################################
> -# GEM: Not worth fixing
> -###############################################
> -igt@gen7_exec_parse@.*lri.*
> -igt@gem_exec_alignment@pi-shared
> -###############################################
> -# There are no DRRS capable displays in CI lab
> -###############################################
> -igt@kms_frontbuffer_tracking@.*drrs.*
> -###############################################
> -# Tends to generate invalid configurations
> -# using CCS planes or configurations that
> -# exceed HW capabilities resulting in sporadic
> -# failure with -EINVAL.
> -#
> -# Maintaining extra constraints for Intel's HW
> -# is too costly in comparison to the value
> -# provided.
> -###############################################
> -igt@kms_chamelium_frames@hdmi-.*-planes-random
> -###############################################
> -# Broadcom
> -###############################################
> -igt@vc4_.*
> -igt@v3d_.*
> -###############################################
> -# AMD
> -###############################################
> -igt@amdgpu/.*
> -###############################################
> -# Panfrost
> -###############################################
> -igt@panfrost_.*
> -###############################################
> -# Qualcomm
> -###############################################
> -igt@msm_.*
> -###############################################
> -# Hibernate: not configured correctly on CI
> -###############################################
> -igt@.*@.*-hibernate
> -igt@gem_softpin@noreloc-s4
> -igt@gem_workarounds@hibernate-.*
> -igt@gem_exec_suspend@basic-s4$
> -igt@gem_ctx_isolation@.*-s4
> -###############################################
> -# Out-of-memory: spammy and often broken
> -###############################################
> -igt@i915_suspend@shrink
> -###############################################
> -# pipe-e, pipe-f no current HW support
> -###############################################
> -igt@.*@.*pipe-e($|-.*)
> -igt@.*@.*pipe-f($|-.*)
> -
> -###############################################
> -# Temporary workarounds for CI-impacting bugs
> -###############################################
> -
> -# Currently fails and leaves the machine in a very bad state, and
> -# causes coverage loss for other tests. IOMMU related.
> -# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
> -igt@core_hotunplug@.*(hot|plug).*
> -
> -# hangs several gens of hosts, and has no immediate fix
> -igt@device_reset@reset-bound
> -
> -# not working for i915
> -igt@kms_bw@.*
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> new file mode 120000
> index 000000000000..e48e29e27f4e
> --- /dev/null
> +++ b/tests/intel-ci/blacklist.txt
> @@ -0,0 +1 @@
> +i915-blacklist.txt
> \ No newline at end of file

I am not sure it will work.

> diff --git a/tests/intel-ci/i915-blacklist.txt b/tests/intel-ci/i915-blacklist.txt
> new file mode 100644
> index 000000000000..389a2acb7f44
> --- /dev/null
> +++ b/tests/intel-ci/i915-blacklist.txt
> @@ -0,0 +1,133 @@
> +igt@meta_test(@.*)?
> +###############################################
> +# Handle module reloads with great care!
> +#
> +# Reloading a module is more likely to leave
> +# the machine in an unexpected state than other
> +# self-contained tests, leading to random
> +# failures in tests run afterwards.
> +###############################################
> +#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
> +igt@i915_pm_rpm@module-reload
> +igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
> +###############################################
> +# GEM
> +###############################################
> +igt@gem_busy@hang.*
> +igt@gem_close_race@(?!.*basic).*
> +igt@gem_concurrent_blit(@.*)?
> +igt@gem_ctx_create@(?!.*basic).*
> +igt@gem_ctx_exec@(?!.*basic).*
> +igt@gem_ctx_shared@*exhaust*
> +igt@gem_ctx_switch(@.*)?
> +igt@gem_evict_alignment(@.*)?
> +igt@gem_evict_everything(@.*)?
> +igt@gem_exec_big@(?!.*single).*
> +igt@gem_exec_capture@many-(?!4K-).*
> +igt@gem_exec_fair@(?!.*basic).*
> +igt@gem_exec_fence@.*hang.*
> +igt@gem_exec_flush@(?!.*basic).*
> +igt@gem_exec_latency(@.*)?
> +igt@gem_exec_lut_handle(@.*)?
> +igt@gem_exec_nop@(?!.*basic).*
> +igt@gem_exec_reloc@(?!.*basic).*
> +igt@gem_exec_suspend@(?!.*basic).*
> +igt@gem_exec_whisper@(?!basic).*
> +igt@gem_fd_exhaustion(@.*)?
> +igt@gem_fence_upload(@.*)?
> +igt@gem_gtt_hog(@.*)?
> +igt@gem_gtt_speed(@.*)?
> +igt@gem_lut_handle(@.*)?
> +igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
> +igt@gem_mmap@.*(swap|huge).*
> +igt@gem_pread_after_blit(@.*)?
> +igt@gem_pwrite@(?!.*basic).*
> +igt@gem_read_read_speed(@.*)?
> +igt@gem_render_linear_blits@(?!.*basic).*
> +igt@gem_render_tiled_blits@(?!.*basic).*
> +igt@gem_reset_stats(@.*)?
> +igt@gem_ringfill@(?!.*basic).*
> +igt@gem_shrink@(?!reclaim$).*
> +igt@gem_softpin@.*(hang|S4).*
> +igt@gem_streaming_writes(@.*)?
> +igt@gem_sync@(?!.*basic).*
> +igt@gem_tiled_swapping@(?!non-threaded).*
> +igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
> +igt@gem_wait@hang.*
> +igt@gem_watchdog@far-fence
> +igt@sysfs_heartbeat_interval@(long|off)
> +igt@sysfs_preempt_timeout@off
> +igt@sysfs_timeslice_duration@off
> +###############################################
> +# GEM: Not worth fixing
> +###############################################
> +igt@gen7_exec_parse@.*lri.*
> +igt@gem_exec_alignment@pi-shared
> +###############################################
> +# There are no DRRS capable displays in CI lab
> +###############################################
> +igt@kms_frontbuffer_tracking@.*drrs.*
> +###############################################
> +# Tends to generate invalid configurations
> +# using CCS planes or configurations that
> +# exceed HW capabilities resulting in sporadic
> +# failure with -EINVAL.
> +#
> +# Maintaining extra constraints for Intel's HW
> +# is too costly in comparison to the value
> +# provided.
> +###############################################
> +igt@kms_chamelium_frames@hdmi-.*-planes-random
> +###############################################
> +# Broadcom
> +###############################################
> +igt@vc4_.*
> +igt@v3d_.*
> +###############################################
> +# Intel Xe
> +###############################################
> +igt@xe/.*
-------- ^
imho this should be

igt@xe_.*

> +###############################################
> +# AMD
> +###############################################
> +igt@amdgpu/.*
> +###############################################
> +# Panfrost
> +###############################################
> +igt@panfrost_.*
> +###############################################
> +# Qualcomm
> +###############################################
> +igt@msm_.*
> +###############################################
> +# Hibernate: not configured correctly on CI
> +###############################################
> +igt@.*@.*-hibernate
> +igt@gem_softpin@noreloc-s4
> +igt@gem_workarounds@hibernate-.*
> +igt@gem_exec_suspend@basic-s4$
> +igt@gem_ctx_isolation@.*-s4
> +###############################################
> +# Out-of-memory: spammy and often broken
> +###############################################
> +igt@i915_suspend@shrink
> +###############################################
> +# pipe-e, pipe-f no current HW support
> +###############################################
> +igt@.*@.*pipe-e($|-.*)
> +igt@.*@.*pipe-f($|-.*)
> +
> +###############################################
> +# Temporary workarounds for CI-impacting bugs
> +###############################################
> +
> +# Currently fails and leaves the machine in a very bad state, and
> +# causes coverage loss for other tests. IOMMU related.
> +# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
> +igt@core_hotunplug@.*(hot|plug).*
> +
> +# hangs several gens of hosts, and has no immediate fix
> +igt@device_reset@reset-bound
> +
> +# not working for i915
> +igt@kms_bw@.*
> diff --git a/tests/intel-ci/xe-blacklist.txt b/tests/intel-ci/xe-blacklist.txt
> new file mode 100644
> index 000000000000..986e91a67069
> --- /dev/null
> +++ b/tests/intel-ci/xe-blacklist.txt
> @@ -0,0 +1,21 @@
> +###############################################
> +# Broadcom
> +###############################################
> +igt@vc4_.*
> +igt@v3d_.*
> +###############################################
> +# Intel i915
> +###############################################
> +igt@i915/.*
---------- ^

imho:
igt@i915_.*
igt@gem_.*

Regards,
Kamil

> +###############################################
> +# AMD
> +###############################################
> +igt@amdgpu/.*
> +###############################################
> +# Panfrost
> +###############################################
> +igt@panfrost_.*
> +###############################################
> +# Qualcomm
> +###############################################
> +igt@msm_.*
> -- 
> 2.39.2
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for Xe driver
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for " Mauro Carvalho Chehab
@ 2023-03-22 18:00   ` Kamil Konieczny
  0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-03-22 18:00 UTC (permalink / raw)
  To: igt-dev

On 2023-03-22 at 15:00:29 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Change the kmod logic to also work with the Xe driver.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

> ---
>  lib/igt_kmod.c | 34 +++++++++++++++++-----------------
>  lib/igt_kmod.h | 32 +++++++++++++++++++++++++++++---
>  2 files changed, 46 insertions(+), 20 deletions(-)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 6d6ecf0187ed..ccf0063ca1b1 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -404,23 +404,23 @@ static void *strdup_realloc(char *origptr, const char *strdata)
>  }
>  
>  /**
> - * igt_i915_driver_load:
> - * @opts: options to pass to i915 driver
> + * igt_intel_driver_load:
> + * @opts: options to pass to Intel driver
>   *
> - * Loads the i915 driver and its dependencies.
> + * Loads an Intel driver and its dependencies.
>   *
>   */
>  int
> -igt_i915_driver_load(const char *opts)
> +igt_intel_driver_load(const char *opts, const char *driver)
>  {
>  	int ret;
>  
>  	if (opts)
> -		igt_info("Reloading i915 with %s\n\n", opts);
> +		igt_info("Reloading %s with %s\n\n", driver, opts);
>  
> -	ret = igt_kmod_load("i915", opts);
> +	ret = igt_kmod_load(driver, opts);
>  	if (ret) {
> -		igt_debug("Could not load i915\n");
> +		igt_debug("Could not load %s\n", driver);
>  		return ret;
>  	}
>  
> @@ -496,7 +496,7 @@ int igt_audio_driver_unload(char **who)
>  	return igt_always_unload_audio_driver(who);
>  }
>  
> -int __igt_i915_driver_unload(char **who)
> +int __igt_intel_driver_unload(char **who, const char *driver)
>  {
>  	int ret;
>  
> @@ -530,11 +530,11 @@ int __igt_i915_driver_unload(char **who)
>  		}
>  	}
>  
> -	if (igt_kmod_is_loaded("i915")) {
> -		ret = igt_kmod_unload("i915", 0);
> +	if (igt_kmod_is_loaded(driver)) {
> +		ret = igt_kmod_unload(driver, 0);
>  		if (ret) {
>  			if (who)
> -				*who = strdup_realloc(*who, "i915");
> +				*who = strdup_realloc(*who, driver);
>  
>  			return ret;
>  		}
> @@ -544,18 +544,18 @@ int __igt_i915_driver_unload(char **who)
>  }
>  
>  /**
> - * igt_i915_driver_unload:
> + * igt_intel_driver_unload:
>   *
> - * Unloads the i915 driver and its dependencies.
> + * Unloads an Intel driver and its dependencies.
>   *
>   */
>  int
> -igt_i915_driver_unload(void)
> +igt_intel_driver_unload(const char *driver)
>  {
>  	char *who = NULL;
>  	int ret;
>  
> -	ret = __igt_i915_driver_unload(&who);
> +	ret = __igt_intel_driver_unload(&who, driver);
>  	if (ret) {
>  		igt_warn("Could not unload %s\n", who);
>  		igt_kmod_list_loaded();
> @@ -572,8 +572,8 @@ igt_i915_driver_unload(void)
>  	igt_kmod_unload("drm_kms_helper", 0);
>  	igt_kmod_unload("drm", 0);
>  
> -	if (igt_kmod_is_loaded("i915")) {
> -		igt_warn("i915.ko still loaded!\n");
> +	if (igt_kmod_is_loaded("driver")) {
> +		igt_warn("%s.ko still loaded!\n", driver);
>  		return -EBUSY;
>  	}
>  
> diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h
> index f98dd29fb175..d05af4a69410 100644
> --- a/lib/igt_kmod.h
> +++ b/lib/igt_kmod.h
> @@ -38,9 +38,35 @@ int igt_kmod_unload(const char *mod_name, unsigned int flags);
>  
>  int igt_audio_driver_unload(char **whom);
>  
> -int igt_i915_driver_load(const char *opts);
> -int igt_i915_driver_unload(void);
> -int __igt_i915_driver_unload(char **whom);
> +int igt_intel_driver_load(const char *opts, const char *driver);
> +int igt_intel_driver_unload(const char *driver);
> +int __igt_intel_driver_unload(char **who, const char *driver);
> +
> +static inline int igt_i915_driver_load(const char *opts)
> +{
> +	return igt_intel_driver_load(opts, "i915");
> +}
> +
> +static inline int igt_i915_driver_unload(void)
> +{
> +	return igt_intel_driver_unload("i915");
> +}
> +
> +static inline int __igt_i915_driver_unload(char **whom)
> +{
> +	return __igt_intel_driver_unload(whom, "i915");
> +};
> +
> +static inline int igt_xe_driver_load(const char *opts)
> +{
> +	return igt_intel_driver_load(opts, "xe");
> +}
> +
> +
> +static inline int igt_xe_driver_unload(void)
> +{
> +	return igt_intel_driver_unload("xe");
> +}
>  
>  int igt_amdgpu_driver_load(const char *opts);
>  int igt_amdgpu_driver_unload(void);
> -- 
> 2.39.2
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload Xe driver
  2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
@ 2023-03-22 18:13   ` Kamil Konieczny
  0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-03-22 18:13 UTC (permalink / raw)
  To: igt-dev

Hi Mauro,

small nits, see below.

On 2023-03-22 at 15:00:30 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> This is helpful to allow IGT to check if there are issues
> during module load/unload.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist |   3 +
>  tests/meson.build                        |   1 +
>  tests/xe/xe_module_load.c                | 158 +++++++++++++++++++++++
>  3 files changed, 162 insertions(+)
>  create mode 100644 tests/xe/xe_module_load.c
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 6525b1676b6f..3140d648833a 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -1,3 +1,6 @@
> +# Should be the first test
> +igt@xe_module_load@force-load
> +
>  igt@xe_compute@compute-square
>  igt@xe_debugfs@base
>  igt@xe_debugfs@gt
> diff --git a/tests/meson.build b/tests/meson.build
> index 2e62ff231416..9235d240fd85 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -256,6 +256,7 @@ xe_progs = [
>  	'xe_huc_copy',
>  	'xe_mmap',
>  	'xe_mmio',
> +	'xe_module_load',
>  	'xe_noexec_ping_pong',
>  	'xe_pm',
>  	'xe_prime_self_import',
> diff --git a/tests/xe/xe_module_load.c b/tests/xe/xe_module_load.c
> new file mode 100644
> index 000000000000..9a38d70858d1
> --- /dev/null
> +++ b/tests/xe/xe_module_load.c
> @@ -0,0 +1,158 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +/**
> + * TEST: Tests the xe module loading
> + * Category: Sofware building block
> + * Sub-category: driver
> + * Test category: functionality test
> + */
> +
> +#include <dirent.h>
> +#include <fcntl.h>
> +#include <libgen.h>
> +#include <signal.h>
------------ ^
This should be after <linux/limits.h>

> +
> +#ifdef __linux__
> +#include <linux/limits.h>
> +#endif
> +
> +#include <sys/ioctl.h>
> +#include <sys/utsname.h>
> +
> +#include "igt.h"
> +
> +#include "igt_aux.h"
> +#include "igt_core.h"
> +#include "igt_debugfs.h"
> +#include "igt_kmod.h"
> +#include "igt_sysfs.h"
> +
> +#define BAR_SIZE_SHIFT 20
> +#define MIN_BAR_SIZE 256
> +
> +static void hda_dynamic_debug(bool enable)
> +{
> +	FILE *fp;
> +	static const char snd_hda_intel_on[] = "module snd_hda_intel +pf";
> +	static const char snd_hda_core_on[] = "module snd_hda_core +pf";
> +
> +	static const char snd_hda_intel_off[] = "module snd_hda_core =_";
--------------------------------- ^ --------------------------- ^
> +	static const char snd_hda_core_off[] = "module snd_hda_intel =_";
--------------------------------- ^ --------------------------- ^

Name in string mismatch.

> +
> +	fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
> +	if (!fp) {
> +		igt_debug("hda dynamic debug not available\n");
> +		return;
> +	}
> +
> +	if (enable) {
> +		fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);

imho we can add checks for fwrite errors.

> +		fwrite(snd_hda_core_on, 1, sizeof(snd_hda_core_on), fp);
> +	} else {
> +		fwrite(snd_hda_intel_off, 1, sizeof(snd_hda_intel_off), fp);
> +		fwrite(snd_hda_core_off, 1, sizeof(snd_hda_core_off), fp);
> +	}
> +
> +	fclose(fp);
> +}
> +
> +static void load_and_check_xe(const char *opts)
> +{
> +	int error;
> +	int drm_fd;
> +
> +	hda_dynamic_debug(true);
> +	error = igt_xe_driver_load(opts);
> +	hda_dynamic_debug(false);
> +
> +	igt_assert_eq(error, 0);
> +
> +	/* driver is ready, check if it's bound */
> +	drm_fd = __drm_open_driver(DRIVER_XE);
> +	igt_fail_on_f(drm_fd < 0, "Cannot open the xe DRM driver after modprobing xe.\n");

imho we should close drm_fd here.
Rest looks good.

Regards,
Kamil

> +}
> +
> +static const char * const unwanted_drivers[] = {
> +	"xe",
> +	"i915",
> +	NULL
> +};
> +
> +/**
> + * SUBTEST: force-load
> + * Description: Load the Xe driver passing ``force_probe=*`` parameter
> + * Run type: BAT
> + *
> + * SUBTEST: load
> + * Description: Load the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: unload
> + * Description: Unload the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: reload
> + * Description: Reload the Xe driver
> + * Run type: FULL
> + *
> + * SUBTEST: reload-no-display
> + * Description: Reload the Xe driver passing ``enable_display=0`` parameter
> + * Run type: FULL
> + *
> + * SUBTEST: many-reload
> + * Description: Reload the Xe driver many times
> + * Run type: FULL
> + */
> +igt_main
> +{
> +	igt_describe("Check if xe and friends are not yet loaded, then load them.");
> +	igt_subtest("load") {
> +		for (int i = 0; unwanted_drivers[i] != NULL; i++) {
> +			igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
> +				      "%s is already loaded\n", unwanted_drivers[i]);
> +		}
> +
> +		load_and_check_xe(NULL);
> +	}
> +
> +	igt_subtest("unload") {
> +		igt_xe_driver_unload();
> +	}
> +
> +	igt_subtest("force-load") {
> +		for (int i = 0; unwanted_drivers[i] != NULL; i++) {
> +			igt_skip_on_f(igt_kmod_is_loaded(unwanted_drivers[i]),
> +				      "%s is already loaded\n", unwanted_drivers[i]);
> +		}
> +
> +		load_and_check_xe("force_probe=*");
> +	}
> +
> +	igt_subtest("reload-no-display") {
> +		igt_xe_driver_unload();
> +		load_and_check_xe("enable_display=0");
> +	}
> +
> +	igt_subtest("many-reload") {
> +		int i;
> +
> +		for (i = 0; i < 10; i++) {
> +			igt_debug("reload cycle: %d\n", i);
> +			igt_xe_driver_unload();
> +			load_and_check_xe(NULL);
> +			sleep(1);
> +		}
> +	}
> +
> +	igt_subtest("reload") {
> +		igt_xe_driver_unload();
> +		load_and_check_xe(NULL);
> +
> +		/* only default modparams, can leave module loaded */
> +	}
> +
> +	/* Subtests should unload the module themselves if they use modparams */
> +}
> -- 
> 2.39.2
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for xe/xe_module_load: add a test to load/unload Xe driver (rev2)
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
                   ` (3 preceding siblings ...)
  2023-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for xe/xe_module_load: add a test to load/unload Xe driver (rev2) Patchwork
@ 2023-03-22 19:25 ` Patchwork
  2023-03-23  8:27 ` [igt-dev] ✗ Fi.CI.BUILD: failure for xe/xe_module_load: add a test to load/unload Xe driver (rev3) Patchwork
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-03-22 19:25 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: igt-dev

[-- Attachment #1: Type: text/plain, Size: 27755 bytes --]

== Series Details ==

Series: xe/xe_module_load: add a test to load/unload Xe driver (rev2)
URL   : https://patchwork.freedesktop.org/series/115511/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12897_full -> IGTPW_8662_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html

Participating hosts (7 -> 8)
------------------------------

  Additional (1): shard-rkl0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_8662_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@xe_module_load@force-load} (NEW):
    - {shard-rkl}:        NOTRUN -> [SKIP][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-4/igt@xe_module_load@force-load.html
    - {shard-dg1}:        NOTRUN -> [SKIP][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-dg1-18/igt@xe_module_load@force-load.html
    - {shard-tglu}:       NOTRUN -> [SKIP][3] +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-3/igt@xe_module_load@force-load.html

  * {igt@xe_module_load@many-reload} (NEW):
    - shard-snb:          NOTRUN -> [FAIL][4] +2 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-snb7/igt@xe_module_load@many-reload.html
    - {shard-tglu}:       NOTRUN -> [FAIL][5] +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-10/igt@xe_module_load@many-reload.html

  * {igt@xe_module_load@reload} (NEW):
    - shard-glk:          NOTRUN -> [FAIL][6] +2 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk9/igt@xe_module_load@reload.html
    - {shard-rkl}:        NOTRUN -> [FAIL][7] +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@xe_module_load@reload.html

  * {igt@xe_module_load@reload-no-display} (NEW):
    - {shard-dg1}:        NOTRUN -> [FAIL][8]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-dg1-14/igt@xe_module_load@reload-no-display.html
    - shard-apl:          NOTRUN -> [FAIL][9] +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl7/igt@xe_module_load@reload-no-display.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_cursor_legacy@single-move@pipe-b:
    - {shard-tglu}:       [PASS][10] -> [INCOMPLETE][11] +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-7/igt@kms_cursor_legacy@single-move@pipe-b.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-1/igt@kms_cursor_legacy@single-move@pipe-b.html

  * {igt@xe_noexec_ping_pong}:
    - {shard-dg1}:        NOTRUN -> [SKIP][12]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-dg1-16/igt@xe_noexec_ping_pong.html

  
New tests
---------

  New tests have been introduced between CI_DRM_12897_full and IGTPW_8662_full:

### New IGT tests (6) ###

  * igt@xe_module_load@force-load:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@xe_module_load@load:
    - Statuses : 5 skip(s)
    - Exec time: [0.0] s

  * igt@xe_module_load@many-reload:
    - Statuses : 5 fail(s)
    - Exec time: [0.0] s

  * igt@xe_module_load@reload:
    - Statuses : 5 fail(s)
    - Exec time: [0.0] s

  * igt@xe_module_load@reload-no-display:
    - Statuses : 6 fail(s)
    - Exec time: [0.0] s

  * igt@xe_module_load@unload:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_8662_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@process:
    - shard-snb:          NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#1099])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-snb2/igt@gem_ctx_persistence@process.html

  * igt@gem_lmem_swapping@verify-random-ccs:
    - shard-glk:          NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk3/igt@gem_lmem_swapping@verify-random-ccs.html

  * igt@gen9_exec_parse@basic-rejected-ctx-param:
    - shard-snb:          NOTRUN -> [SKIP][15] ([fdo#109271]) +31 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-snb2/igt@gen9_exec_parse@basic-rejected-ctx-param.html

  * igt@i915_pm_rpm@gem-execbuf-stress-pc8:
    - shard-glk:          NOTRUN -> [SKIP][16] ([fdo#109271]) +30 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk9/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
    - shard-glk:          NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3886]) +3 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [PASS][18] -> [FAIL][19] ([i915#4767])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * {igt@xe_module_load@force-load} (NEW):
    - shard-apl:          NOTRUN -> [SKIP][20] ([fdo#109271]) +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl2/igt@xe_module_load@force-load.html

  
#### Possible fixes ####

  * igt@api_intel_bb@object-reloc-purge-cache:
    - {shard-rkl}:        [SKIP][21] ([i915#3281]) -> [PASS][22] +4 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-4/igt@api_intel_bb@object-reloc-purge-cache.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@api_intel_bb@object-reloc-purge-cache.html

  * igt@drm_read@short-buffer-nonblock:
    - {shard-rkl}:        [SKIP][23] ([i915#4098]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-3/igt@drm_read@short-buffer-nonblock.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@drm_read@short-buffer-nonblock.html

  * igt@fbdev@eof:
    - {shard-tglu}:       [SKIP][25] ([i915#2582]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-10/igt@fbdev@eof.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-6/igt@fbdev@eof.html

  * igt@fbdev@unaligned-write:
    - {shard-rkl}:        [SKIP][27] ([i915#2582]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-1/igt@fbdev@unaligned-write.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@fbdev@unaligned-write.html

  * igt@gem_eio@in-flight-suspend:
    - {shard-rkl}:        [FAIL][29] ([fdo#103375]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-1/igt@gem_eio@in-flight-suspend.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [FAIL][31] ([i915#2842]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - {shard-rkl}:        [FAIL][33] ([i915#2842]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-3/igt@gem_exec_fair@basic-none@vcs0.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-glk:          [FAIL][35] ([i915#2842]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@gem_mmap_gtt@coherency:
    - {shard-rkl}:        [SKIP][37] ([fdo#111656]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-2/igt@gem_mmap_gtt@coherency.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@gem_mmap_gtt@coherency.html

  * igt@gem_partial_pwrite_pread@write-snoop:
    - {shard-rkl}:        [SKIP][39] ([i915#3282]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-3/igt@gem_partial_pwrite_pread@write-snoop.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@gem_partial_pwrite_pread@write-snoop.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-glk:          [ABORT][41] ([i915#5566]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-glk8/igt@gen9_exec_parse@allowed-single.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk8/igt@gen9_exec_parse@allowed-single.html

  * igt@gen9_exec_parse@batch-invalid-length:
    - {shard-rkl}:        [SKIP][43] ([i915#2527]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-6/igt@gen9_exec_parse@batch-invalid-length.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html

  * igt@i915_pm_dc@dc6-psr:
    - {shard-rkl}:        [SKIP][45] ([i915#658]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-1/igt@i915_pm_dc@dc6-psr.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_dc@dc9-dpms:
    - {shard-tglu}:       [SKIP][47] ([i915#4281]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-3/igt@i915_pm_dc@dc9-dpms.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-9/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rpm@dpms-mode-unset-lpsp:
    - {shard-tglu}:       [SKIP][49] ([i915#1397]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-10/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-6/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html

  * igt@i915_pm_rpm@fences:
    - {shard-rkl}:        [SKIP][51] ([i915#1849]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-4/igt@i915_pm_rpm@fences.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@i915_pm_rpm@fences.html

  * igt@i915_pm_rpm@i2c:
    - {shard-tglu}:       [SKIP][53] ([i915#3547]) -> [PASS][54] +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-10/igt@i915_pm_rpm@i2c.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-8/igt@i915_pm_rpm@i2c.html

  * igt@i915_pm_rpm@modeset-lpsp:
    - {shard-rkl}:        [SKIP][55] ([i915#1397]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-3/igt@i915_pm_rpm@modeset-lpsp.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-apl:          [DMESG-FAIL][57] ([i915#5334]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@perf@engine_cs:
    - shard-snb:          [ABORT][59] ([i915#4528]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-snb2/igt@i915_selftest@perf@engine_cs.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-snb4/igt@i915_selftest@perf@engine_cs.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-0:
    - {shard-rkl}:        [SKIP][61] ([i915#1845] / [i915#4098]) -> [PASS][62] +35 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-4/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html

  * igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs:
    - {shard-tglu}:       [SKIP][63] ([i915#1845]) -> [PASS][64] +47 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-10/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-7/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs.html

  * igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs:
    - {shard-tglu}:       [SKIP][65] ([i915#1845] / [i915#7651]) -> [PASS][66] +20 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-9/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-3/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_rc_ccs.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [FAIL][67] ([i915#2346]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@single-move@pipe-b:
    - {shard-rkl}:        [INCOMPLETE][69] -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-6/igt@kms_cursor_legacy@single-move@pipe-b.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@kms_cursor_legacy@single-move@pipe-b.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
    - {shard-tglu}:       [SKIP][71] ([i915#1849]) -> [PASS][72] +19 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - {shard-rkl}:        [SKIP][73] ([i915#1849] / [i915#4098]) -> [PASS][74] +20 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html

  * igt@kms_psr@cursor_mmap_cpu:
    - {shard-rkl}:        [SKIP][75] ([i915#1072]) -> [PASS][76] +3 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-5/igt@kms_psr@cursor_mmap_cpu.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html

  * igt@perf@polling-small-buf:
    - {shard-rkl}:        [FAIL][77] ([i915#1722]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-4/igt@perf@polling-small-buf.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@perf@polling-small-buf.html

  * igt@perf@stress-open-close:
    - shard-glk:          [ABORT][79] ([i915#5213]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-glk4/igt@perf@stress-open-close.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-glk6/igt@perf@stress-open-close.html

  * igt@perf_pmu@idle@rcs0:
    - {shard-dg1}:        [FAIL][81] ([i915#4349]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-dg1-14/igt@perf_pmu@idle@rcs0.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-dg1-18/igt@perf_pmu@idle@rcs0.html

  * igt@prime_vgem@basic-read:
    - {shard-rkl}:        [SKIP][83] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12897/shard-rkl-2/igt@prime_vgem@basic-read.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/shard-rkl-5/igt@prime_vgem@basic-read.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
  [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
  [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
  [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
  [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
  [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
  [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
  [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
  [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
  [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
  [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
  [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
  [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
  [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
  [i915#8155]: https://gitlab.freedesktop.org/drm/intel/issues/8155
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7211 -> IGTPW_8662
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_12897: 48de8fde637e7fb42e44046fbb3f33199d36ea6b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_8662: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html
  IGT_7211: c0cc1de7b2f4041ca68960362aa55f881d416bac @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8662/index.html

[-- Attachment #2: Type: text/html, Size: 22742 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the Xe driver
  2023-03-22 17:44   ` Kamil Konieczny
@ 2023-03-23  7:50     ` Mauro Carvalho Chehab
  2023-03-23  7:55       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-23  7:50 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

On Wed, 22 Mar 2023 18:44:46 +0100
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Hi Mauro,
> 
> On 2023-03-22 at 15:00:28 +0100, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > 
> > It doesn't make sense to run i915 tests with Xe driver and
> > vice-versa. Update testlists to make it clear.
> > 
> > In order to avoid disrupts at exiting intel-ci tests, keep a
> > symlink:
> > 	i915-blacklist.txt -> blacklist.txt
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > ---
> >  tests/intel-ci/blacklist.txt      | 130 +----------------------------
> >  tests/intel-ci/i915-blacklist.txt | 133 ++++++++++++++++++++++++++++++  
> 
> Why not just git mv oldfile newfile ?

I did that. Then, I created a link:
	ln -s blacklist.txt tests/intel-ci/i915-blacklist.txt 

The rationale is to avoid breaking any existing CI pipelines that would
be expecting to find the i915 blacklist as "blacklist.txt.".

> But that aside, imho better solution would be to just
> add xe_* to blacklist. 

That is what I did: once renamed: I added "igt@xe_.*" to the blacklist
file.

Unfortunately, git diff output is weird when there is a rename and
a symlink to the same name at the same patch. If you prefer, I can
split it on two patches to make easier to view the differences.

> I am also not sure you can include
> one blacklist into another.

There's no such thing. Both blacklist files are independent. You
probably got tricked by the weird output git produced with the rename
+ symlink at the same patch.

> 
> +Cc: Petri Latvala <adrinael@adrinael.net>
> 
> >  tests/intel-ci/xe-blacklist.txt   |  21 +++++
> >  3 files changed, 155 insertions(+), 129 deletions(-)
> >  mode change 100644 => 120000 tests/intel-ci/blacklist.txt
> >  create mode 100644 tests/intel-ci/i915-blacklist.txt
> >  create mode 100644 tests/intel-ci/xe-blacklist.txt
> > 
> > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > deleted file mode 100644
> > index 6e5cc43667cf..000000000000
> > --- a/tests/intel-ci/blacklist.txt
> > +++ /dev/null
> > @@ -1,129 +0,0 @@
> > -igt@meta_test(@.*)?
> > -###############################################
> > -# Handle module reloads with great care!
> > -#
> > -# Reloading a module is more likely to leave
> > -# the machine in an unexpected state than other
> > -# self-contained tests, leading to random
> > -# failures in tests run afterwards.
> > -###############################################
> > -#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
> > -igt@i915_pm_rpm@module-reload
> > -igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
> > -###############################################
> > -# GEM
> > -###############################################
> > -igt@gem_busy@hang.*
> > -igt@gem_close_race@(?!.*basic).*
> > -igt@gem_concurrent_blit(@.*)?
> > -igt@gem_ctx_create@(?!.*basic).*
> > -igt@gem_ctx_exec@(?!.*basic).*
> > -igt@gem_ctx_shared@*exhaust*
> > -igt@gem_ctx_switch(@.*)?
> > -igt@gem_evict_alignment(@.*)?
> > -igt@gem_evict_everything(@.*)?
> > -igt@gem_exec_big@(?!.*single).*
> > -igt@gem_exec_capture@many-(?!4K-).*
> > -igt@gem_exec_fair@(?!.*basic).*
> > -igt@gem_exec_fence@.*hang.*
> > -igt@gem_exec_flush@(?!.*basic).*
> > -igt@gem_exec_latency(@.*)?
> > -igt@gem_exec_lut_handle(@.*)?
> > -igt@gem_exec_nop@(?!.*basic).*
> > -igt@gem_exec_reloc@(?!.*basic).*
> > -igt@gem_exec_suspend@(?!.*basic).*
> > -igt@gem_exec_whisper@(?!basic).*
> > -igt@gem_fd_exhaustion(@.*)?
> > -igt@gem_fence_upload(@.*)?
> > -igt@gem_gtt_hog(@.*)?
> > -igt@gem_gtt_speed(@.*)?
> > -igt@gem_lut_handle(@.*)?
> > -igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
> > -igt@gem_mmap@.*(swap|huge).*
> > -igt@gem_pread_after_blit(@.*)?
> > -igt@gem_pwrite@(?!.*basic).*
> > -igt@gem_read_read_speed(@.*)?
> > -igt@gem_render_linear_blits@(?!.*basic).*
> > -igt@gem_render_tiled_blits@(?!.*basic).*
> > -igt@gem_reset_stats(@.*)?
> > -igt@gem_ringfill@(?!.*basic).*
> > -igt@gem_shrink@(?!reclaim$).*
> > -igt@gem_softpin@.*(hang|S4).*
> > -igt@gem_streaming_writes(@.*)?
> > -igt@gem_sync@(?!.*basic).*
> > -igt@gem_tiled_swapping@(?!non-threaded).*
> > -igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
> > -igt@gem_wait@hang.*
> > -igt@gem_watchdog@far-fence
> > -igt@sysfs_heartbeat_interval@(long|off)
> > -igt@sysfs_preempt_timeout@off
> > -igt@sysfs_timeslice_duration@off
> > -###############################################
> > -# GEM: Not worth fixing
> > -###############################################
> > -igt@gen7_exec_parse@.*lri.*
> > -igt@gem_exec_alignment@pi-shared
> > -###############################################
> > -# There are no DRRS capable displays in CI lab
> > -###############################################
> > -igt@kms_frontbuffer_tracking@.*drrs.*
> > -###############################################
> > -# Tends to generate invalid configurations
> > -# using CCS planes or configurations that
> > -# exceed HW capabilities resulting in sporadic
> > -# failure with -EINVAL.
> > -#
> > -# Maintaining extra constraints for Intel's HW
> > -# is too costly in comparison to the value
> > -# provided.
> > -###############################################
> > -igt@kms_chamelium_frames@hdmi-.*-planes-random
> > -###############################################
> > -# Broadcom
> > -###############################################
> > -igt@vc4_.*
> > -igt@v3d_.*
> > -###############################################
> > -# AMD
> > -###############################################
> > -igt@amdgpu/.*
> > -###############################################
> > -# Panfrost
> > -###############################################
> > -igt@panfrost_.*
> > -###############################################
> > -# Qualcomm
> > -###############################################
> > -igt@msm_.*
> > -###############################################
> > -# Hibernate: not configured correctly on CI
> > -###############################################
> > -igt@.*@.*-hibernate
> > -igt@gem_softpin@noreloc-s4
> > -igt@gem_workarounds@hibernate-.*
> > -igt@gem_exec_suspend@basic-s4$
> > -igt@gem_ctx_isolation@.*-s4
> > -###############################################
> > -# Out-of-memory: spammy and often broken
> > -###############################################
> > -igt@i915_suspend@shrink
> > -###############################################
> > -# pipe-e, pipe-f no current HW support
> > -###############################################
> > -igt@.*@.*pipe-e($|-.*)
> > -igt@.*@.*pipe-f($|-.*)
> > -
> > -###############################################
> > -# Temporary workarounds for CI-impacting bugs
> > -###############################################
> > -
> > -# Currently fails and leaves the machine in a very bad state, and
> > -# causes coverage loss for other tests. IOMMU related.
> > -# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
> > -igt@core_hotunplug@.*(hot|plug).*
> > -
> > -# hangs several gens of hosts, and has no immediate fix
> > -igt@device_reset@reset-bound
> > -
> > -# not working for i915
> > -igt@kms_bw@.*
> > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > new file mode 120000
> > index 000000000000..e48e29e27f4e
> > --- /dev/null
> > +++ b/tests/intel-ci/blacklist.txt
> > @@ -0,0 +1 @@
> > +i915-blacklist.txt
> > \ No newline at end of file  
> 
> I am not sure it will work.
> 
> > diff --git a/tests/intel-ci/i915-blacklist.txt b/tests/intel-ci/i915-blacklist.txt
> > new file mode 100644
> > index 000000000000..389a2acb7f44
> > --- /dev/null
> > +++ b/tests/intel-ci/i915-blacklist.txt
> > @@ -0,0 +1,133 @@
> > +igt@meta_test(@.*)?
> > +###############################################
> > +# Handle module reloads with great care!
> > +#
> > +# Reloading a module is more likely to leave
> > +# the machine in an unexpected state than other
> > +# self-contained tests, leading to random
> > +# failures in tests run afterwards.
> > +###############################################
> > +#igt@i915_module_load(@.*)? # danger, danger; hope for taints!
> > +igt@i915_pm_rpm@module-reload
> > +igt@i915_pm_rpm@gem-execbuf-stress-extra-wait
> > +###############################################
> > +# GEM
> > +###############################################
> > +igt@gem_busy@hang.*
> > +igt@gem_close_race@(?!.*basic).*
> > +igt@gem_concurrent_blit(@.*)?
> > +igt@gem_ctx_create@(?!.*basic).*
> > +igt@gem_ctx_exec@(?!.*basic).*
> > +igt@gem_ctx_shared@*exhaust*
> > +igt@gem_ctx_switch(@.*)?
> > +igt@gem_evict_alignment(@.*)?
> > +igt@gem_evict_everything(@.*)?
> > +igt@gem_exec_big@(?!.*single).*
> > +igt@gem_exec_capture@many-(?!4K-).*
> > +igt@gem_exec_fair@(?!.*basic).*
> > +igt@gem_exec_fence@.*hang.*
> > +igt@gem_exec_flush@(?!.*basic).*
> > +igt@gem_exec_latency(@.*)?
> > +igt@gem_exec_lut_handle(@.*)?
> > +igt@gem_exec_nop@(?!.*basic).*
> > +igt@gem_exec_reloc@(?!.*basic).*
> > +igt@gem_exec_suspend@(?!.*basic).*
> > +igt@gem_exec_whisper@(?!basic).*
> > +igt@gem_fd_exhaustion(@.*)?
> > +igt@gem_fence_upload(@.*)?
> > +igt@gem_gtt_hog(@.*)?
> > +igt@gem_gtt_speed(@.*)?
> > +igt@gem_lut_handle(@.*)?
> > +igt@gem_mmap_gtt@.*(huge|swap|clflush|forked).*
> > +igt@gem_mmap@.*(swap|huge).*
> > +igt@gem_pread_after_blit(@.*)?
> > +igt@gem_pwrite@(?!.*basic).*
> > +igt@gem_read_read_speed(@.*)?
> > +igt@gem_render_linear_blits@(?!.*basic).*
> > +igt@gem_render_tiled_blits@(?!.*basic).*
> > +igt@gem_reset_stats(@.*)?
> > +igt@gem_ringfill@(?!.*basic).*
> > +igt@gem_shrink@(?!reclaim$).*
> > +igt@gem_softpin@.*(hang|S4).*
> > +igt@gem_streaming_writes(@.*)?
> > +igt@gem_sync@(?!.*basic).*
> > +igt@gem_tiled_swapping@(?!non-threaded).*
> > +igt@gem_userptr_blits@(major|minor|forked|mlocked|swapping).*
> > +igt@gem_wait@hang.*
> > +igt@gem_watchdog@far-fence
> > +igt@sysfs_heartbeat_interval@(long|off)
> > +igt@sysfs_preempt_timeout@off
> > +igt@sysfs_timeslice_duration@off
> > +###############################################
> > +# GEM: Not worth fixing
> > +###############################################
> > +igt@gen7_exec_parse@.*lri.*
> > +igt@gem_exec_alignment@pi-shared
> > +###############################################
> > +# There are no DRRS capable displays in CI lab
> > +###############################################
> > +igt@kms_frontbuffer_tracking@.*drrs.*
> > +###############################################
> > +# Tends to generate invalid configurations
> > +# using CCS planes or configurations that
> > +# exceed HW capabilities resulting in sporadic
> > +# failure with -EINVAL.
> > +#
> > +# Maintaining extra constraints for Intel's HW
> > +# is too costly in comparison to the value
> > +# provided.
> > +###############################################
> > +igt@kms_chamelium_frames@hdmi-.*-planes-random
> > +###############################################
> > +# Broadcom
> > +###############################################
> > +igt@vc4_.*
> > +igt@v3d_.*
> > +###############################################
> > +# Intel Xe
> > +###############################################
> > +igt@xe/.*  
> -------- ^
> imho this should be
> 
> igt@xe_.*
> 
> > +###############################################
> > +# AMD
> > +###############################################
> > +igt@amdgpu/.*
> > +###############################################
> > +# Panfrost
> > +###############################################
> > +igt@panfrost_.*
> > +###############################################
> > +# Qualcomm
> > +###############################################
> > +igt@msm_.*
> > +###############################################
> > +# Hibernate: not configured correctly on CI
> > +###############################################
> > +igt@.*@.*-hibernate
> > +igt@gem_softpin@noreloc-s4
> > +igt@gem_workarounds@hibernate-.*
> > +igt@gem_exec_suspend@basic-s4$
> > +igt@gem_ctx_isolation@.*-s4
> > +###############################################
> > +# Out-of-memory: spammy and often broken
> > +###############################################
> > +igt@i915_suspend@shrink
> > +###############################################
> > +# pipe-e, pipe-f no current HW support
> > +###############################################
> > +igt@.*@.*pipe-e($|-.*)
> > +igt@.*@.*pipe-f($|-.*)
> > +
> > +###############################################
> > +# Temporary workarounds for CI-impacting bugs
> > +###############################################
> > +
> > +# Currently fails and leaves the machine in a very bad state, and
> > +# causes coverage loss for other tests. IOMMU related.
> > +# https://gitlab.freedesktop.org/drm/intel/-/issues/2644
> > +igt@core_hotunplug@.*(hot|plug).*
> > +
> > +# hangs several gens of hosts, and has no immediate fix
> > +igt@device_reset@reset-bound
> > +
> > +# not working for i915
> > +igt@kms_bw@.*
> > diff --git a/tests/intel-ci/xe-blacklist.txt b/tests/intel-ci/xe-blacklist.txt
> > new file mode 100644
> > index 000000000000..986e91a67069
> > --- /dev/null
> > +++ b/tests/intel-ci/xe-blacklist.txt
> > @@ -0,0 +1,21 @@
> > +###############################################
> > +# Broadcom
> > +###############################################
> > +igt@vc4_.*
> > +igt@v3d_.*
> > +###############################################
> > +# Intel i915
> > +###############################################
> > +igt@i915/.*  
> ---------- ^
> 
> imho:
> igt@i915_.*
> igt@gem_.*
> 
> Regards,
> Kamil
> 
> > +###############################################
> > +# AMD
> > +###############################################
> > +igt@amdgpu/.*
> > +###############################################
> > +# Panfrost
> > +###############################################
> > +igt@panfrost_.*
> > +###############################################
> > +# Qualcomm
> > +###############################################
> > +igt@msm_.*
> > -- 
> > 2.39.2
> >   

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the Xe driver
  2023-03-23  7:50     ` Mauro Carvalho Chehab
@ 2023-03-23  7:55       ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2023-03-23  7:55 UTC (permalink / raw)
  To: Kamil Konieczny; +Cc: igt-dev

On Thu, 23 Mar 2023 08:50:25 +0100
Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:

> On Wed, 22 Mar 2023 18:44:46 +0100
> Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> 
> > Hi Mauro,
> > 
> > On 2023-03-22 at 15:00:28 +0100, Mauro Carvalho Chehab wrote:
> > > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > 
> > > It doesn't make sense to run i915 tests with Xe driver and
> > > vice-versa. Update testlists to make it clear.
> > > 
> > > In order to avoid disrupts at exiting intel-ci tests, keep a
> > > symlink:
> > > 	i915-blacklist.txt -> blacklist.txt
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > ---
> > >  tests/intel-ci/blacklist.txt      | 130 +----------------------------
> > >  tests/intel-ci/i915-blacklist.txt | 133 ++++++++++++++++++++++++++++++  
> > 
> > Why not just git mv oldfile newfile ?
> 
> I did that. Then, I created a link:
> 	ln -s blacklist.txt tests/intel-ci/i915-blacklist.txt 
> 
> The rationale is to avoid breaking any existing CI pipelines that would
> be expecting to find the i915 blacklist as "blacklist.txt.".
> 
> > But that aside, imho better solution would be to just
> > add xe_* to blacklist. 
> 
> That is what I did: once renamed: I added "igt@xe_.*" to the blacklist
> file.
> 
> Unfortunately, git diff output is weird when there is a rename and
> a symlink to the same name at the same patch. If you prefer, I can
> split it on two patches to make easier to view the differences.
> 
> > I am also not sure you can include
> > one blacklist into another.
> 
> There's no such thing. Both blacklist files are independent. You
> probably got tricked by the weird output git produced with the rename
> + symlink at the same patch.

Btw, if I remove the symlink, the diff becomes nice and clean:

[PATCH] intel-ci: update blacklists to work with the Xe driver
    
It doesn't make sense to run i915 tests with Xe driver and
vice-versa. Update testlists to make it clear.
    
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/i915-blacklist.txt
similarity index 97%
rename from tests/intel-ci/blacklist.txt
rename to tests/intel-ci/i915-blacklist.txt
index 6e5cc43667cf..389a2acb7f44 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/i915-blacklist.txt
@@ -84,6 +84,10 @@ igt@kms_chamelium_frames@hdmi-.*-planes-random
 igt@vc4_.*
 igt@v3d_.*
 ###############################################
+# Intel Xe
+###############################################
+igt@xe/.*
+###############################################
 # AMD
 ###############################################
 igt@amdgpu/.*
diff --git a/tests/intel-ci/xe-blacklist.txt b/tests/intel-ci/xe-blacklist.txt
new file mode 100644
index 000000000000..986e91a67069
--- /dev/null
+++ b/tests/intel-ci/xe-blacklist.txt
@@ -0,0 +1,21 @@
+###############################################
+# Broadcom
+###############################################
+igt@vc4_.*
+igt@v3d_.*
+###############################################
+# Intel i915
+###############################################
+igt@i915/.*
+###############################################
+# AMD
+###############################################
+igt@amdgpu/.*
+###############################################
+# Panfrost
+###############################################
+igt@panfrost_.*
+###############################################
+# Qualcomm
+###############################################
+igt@msm_.*

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [igt-dev] ✗ Fi.CI.BUILD: failure for xe/xe_module_load: add a test to load/unload Xe driver (rev3)
  2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
                   ` (4 preceding siblings ...)
  2023-03-22 19:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-03-23  8:27 ` Patchwork
  5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-03-23  8:27 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: igt-dev

== Series Details ==

Series: xe/xe_module_load: add a test to load/unload Xe driver (rev3)
URL   : https://patchwork.freedesktop.org/series/115511/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
c0cc1de7b2f4041ca68960362aa55f881d416bac tests/amdgpu/amd_dp_dsc: fix test crash signal sigsegv

Compiler for C supports arguments -Werror=return-type: YES 
Compiler for C supports arguments -Werror=sequence-point: YES 
Compiler for C supports arguments -Werror=trigraphs: YES 
Compiler for C supports arguments -Werror=write-strings: YES 
Compiler for C supports arguments -fno-builtin-malloc: YES 
Compiler for C supports arguments -fno-builtin-calloc: YES 
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency libdrm found: YES 2.4.107
Run-time dependency libdrm_intel found: YES 2.4.107
Run-time dependency pciaccess found: YES 0.16
Run-time dependency libkmod found: YES 27
Run-time dependency libprocps found: YES 3.3.16
Run-time dependency libunwind found: YES 1.21
Run-time dependency libdw found: YES 0.176
Run-time dependency pixman-1 found: YES 0.38.0
Run-time dependency valgrind found: YES 3.15.0
Run-time dependency cairo found: YES 1.17.2
Run-time dependency libudev found: YES 245
Run-time dependency glib-2.0 found: YES 2.64.6
Found CMake: /usr/bin/cmake (3.16.3)
Run-time dependency xmlrpc found: NO (tried pkgconfig and cmake)
Run-time dependency xmlrpc_util found: NO (tried pkgconfig and cmake)
Run-time dependency xmlrpc_client found: NO (tried pkgconfig and cmake)
Program xmlrpc-c-config found: YES (/usr/bin/xmlrpc-c-config)
Run-time dependency gsl found: YES 2.5
Run-time dependency alsa found: YES 1.2.2
Run-time dependency libcurl found: YES 7.68.0
Run-time dependency threads found: YES
Library m found: YES
Library rt found: YES
Library dl found: YES
Library z found: YES
Checking if "built-in atomics" links: YES 
Has header "linux/kd.h" : YES 
Has header "sys/kd.h" : YES 
Has header "libgen.h" : YES 
Has header "sys/io.h" : YES 
Checking if "cpuid.h" links: YES 
Header <unistd.h> has symbol "gettid" : YES 
Checking whether type "struct sysinfo" has member "totalram" : YES 
Checking for function "memfd_create" : YES 
Configuring config.h using configuration
Program python3 found: YES (/usr/bin/python3)
Configuring i915-perf.pc using configuration
Program generate_testlist.sh found: YES (/usr/src/igt-gpu-tools/tests/generate_testlist.sh)
Program igt_command_line.sh found: YES (/usr/src/igt-gpu-tools/tests/igt_command_line.sh)

tests/intel-ci/meson.build:11:0: ERROR: File blacklist.txt does not exist.

A full log can be found at /opt/igt/build/meson-logs/meson-log.txt




^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-03-23  8:27 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 14:00 [igt-dev] [PATCH i-g-t v3 0/3] xe/xe_module_load: add a test to load/unload Xe driver Mauro Carvalho Chehab
2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 1/3] intel-ci: update blacklists to work with the " Mauro Carvalho Chehab
2023-03-22 17:44   ` Kamil Konieczny
2023-03-23  7:50     ` Mauro Carvalho Chehab
2023-03-23  7:55       ` Mauro Carvalho Chehab
2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/igt_kmod: add support for " Mauro Carvalho Chehab
2023-03-22 18:00   ` Kamil Konieczny
2023-03-22 14:00 ` [igt-dev] [PATCH i-g-t v3 3/3] xe/xe_module_load: add a test to load/unload " Mauro Carvalho Chehab
2023-03-22 18:13   ` Kamil Konieczny
2023-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for xe/xe_module_load: add a test to load/unload Xe driver (rev2) Patchwork
2023-03-22 19:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-23  8:27 ` [igt-dev] ✗ Fi.CI.BUILD: failure for xe/xe_module_load: add a test to load/unload Xe driver (rev3) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.