* Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check
2023-03-24 16:21 [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check Jeffrey Hugo
@ 2023-03-27 10:23 ` Manivannan Sadhasivam
2023-04-03 5:17 ` Manivannan Sadhasivam
2023-04-03 5:18 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-27 10:23 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: mhi, linux-arm-msm, linux-kernel
On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check
2023-03-24 16:21 [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check Jeffrey Hugo
2023-03-27 10:23 ` Manivannan Sadhasivam
@ 2023-04-03 5:17 ` Manivannan Sadhasivam
2023-04-03 5:18 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-04-03 5:17 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: mhi, linux-arm-msm, linux-kernel
On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check
2023-03-24 16:21 [PATCH] bus: mhi: host: Use ERANGE for BHIOFF/BHIEOFF range check Jeffrey Hugo
2023-03-27 10:23 ` Manivannan Sadhasivam
2023-04-03 5:17 ` Manivannan Sadhasivam
@ 2023-04-03 5:18 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-04-03 5:18 UTC (permalink / raw)
To: Jeffrey Hugo; +Cc: mhi, linux-arm-msm, linux-kernel
On Fri, Mar 24, 2023 at 10:21:00AM -0600, Jeffrey Hugo wrote:
> If the BHIOFF or BHIEOFF range checks fail, they return EINVAL. ERANGE
> is a better error code since it implies an out of range condition.
>
> Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Applied to mhi-next!
- Mani
> ---
>
> This feels more like a style change than fixing a bug, so I'm being
> conservative and intentionally not listing a fixes tag.
>
> drivers/bus/mhi/host/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
> index b46a082..f72fcb6 100644
> --- a/drivers/bus/mhi/host/init.c
> +++ b/drivers/bus/mhi/host/init.c
> @@ -1112,7 +1112,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> if (bhi_off >= mhi_cntrl->reg_len) {
> dev_err(dev, "BHI offset: 0x%x is out of range: 0x%zx\n",
> bhi_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhi = mhi_cntrl->regs + bhi_off;
> @@ -1129,7 +1129,7 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
> dev_err(dev,
> "BHIe offset: 0x%x is out of range: 0x%zx\n",
> bhie_off, mhi_cntrl->reg_len);
> - ret = -EINVAL;
> + ret = -ERANGE;
> goto error_reg_offset;
> }
> mhi_cntrl->bhie = mhi_cntrl->regs + bhie_off;
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread