* [PATCH 0/2] Correct gpio-ir-recv wakeup capability
@ 2023-03-24 17:02 Florian Fainelli
2023-03-24 17:02 ` [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property Florian Fainelli
2023-03-24 17:02 ` [PATCH 2/2] media: rc: gpio-ir-recv: Fix support for wake-up Florian Fainelli
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-03-24 17:02 UTC (permalink / raw)
To: linux-kernel
Cc: bcm-kernel-feedback-list, Florian Fainelli,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sean Young, Sebastian Hesselbarth, Ravi Kumar V,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Matthew Lear
This small patch series fixes the gpio-ir-recv binding and driver to
first indicate that it can be a wake-up source for the system, and
second actually make that happen.
Florian Fainelli (2):
dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
media: rc: gpio-ir-recv: Fix support for wake-up
Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++
drivers/media/rc/gpio-ir-recv.c | 2 ++
2 files changed, 5 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
2023-03-24 17:02 [PATCH 0/2] Correct gpio-ir-recv wakeup capability Florian Fainelli
@ 2023-03-24 17:02 ` Florian Fainelli
2023-03-24 20:17 ` Rob Herring
2023-03-24 17:02 ` [PATCH 2/2] media: rc: gpio-ir-recv: Fix support for wake-up Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2023-03-24 17:02 UTC (permalink / raw)
To: linux-kernel
Cc: bcm-kernel-feedback-list, Florian Fainelli,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sean Young, Sebastian Hesselbarth, Ravi Kumar V,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Matthew Lear
The GPIO IR receiver can be used as a wake-up source for the system,
document that.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml b/Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml
index 61072745b983..7e76838388cd 100644
--- a/Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml
+++ b/Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml
@@ -23,6 +23,9 @@ properties:
description: autosuspend delay time in milliseconds
$ref: /schemas/types.yaml#/definitions/uint32
+ wakeup-source:
+ description: IR receiver can wake-up the system.
+
required:
- compatible
- gpios
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] media: rc: gpio-ir-recv: Fix support for wake-up
2023-03-24 17:02 [PATCH 0/2] Correct gpio-ir-recv wakeup capability Florian Fainelli
2023-03-24 17:02 ` [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property Florian Fainelli
@ 2023-03-24 17:02 ` Florian Fainelli
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-03-24 17:02 UTC (permalink / raw)
To: linux-kernel
Cc: bcm-kernel-feedback-list, Florian Fainelli, Matthew Lear,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sean Young, Sebastian Hesselbarth, Ravi Kumar V,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
The driver was intended from the start to be a wake-up source for the
system, however due to the absence of a suitable call to
device_set_wakeup_capable(), the device_may_wakeup() call used to decide
whether to enable the GPIO interrupt as a wake-up source would never
happen. Lookup the DT standard "wakeup-source" property and call
device_init_wakeup() to ensure the device is flagged as being wakeup
capable.
Reported-by: Matthew Lear <matthew.lear@broadcom.com>
Fixes: fd0f6851eb46 ("[media] rc: Add support for GPIO based IR Receiver driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/media/rc/gpio-ir-recv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
index 8dbe780dae4e..41ef8cdba28c 100644
--- a/drivers/media/rc/gpio-ir-recv.c
+++ b/drivers/media/rc/gpio-ir-recv.c
@@ -103,6 +103,8 @@ static int gpio_ir_recv_probe(struct platform_device *pdev)
rcdev->map_name = RC_MAP_EMPTY;
gpio_dev->rcdev = rcdev;
+ if (of_property_read_bool(np, "wakeup-source"))
+ device_init_wakeup(dev, true);
rc = devm_rc_register_device(dev, rcdev);
if (rc < 0) {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property
2023-03-24 17:02 ` [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property Florian Fainelli
@ 2023-03-24 20:17 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-03-24 20:17 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-media, Sean Young, Sebastian Hesselbarth,
Mauro Carvalho Chehab, bcm-kernel-feedback-list, Ravi Kumar V,
linux-kernel, devicetree, Matthew Lear, Krzysztof Kozlowski,
Rob Herring
On Fri, 24 Mar 2023 10:02:13 -0700, Florian Fainelli wrote:
> The GPIO IR receiver can be used as a wake-up source for the system,
> document that.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/gpio-ir-receiver.yaml:27:6: [warning] wrong indentation: expected 4 but found 5 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230324170214.3470675-2-f.fainelli@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-24 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 17:02 [PATCH 0/2] Correct gpio-ir-recv wakeup capability Florian Fainelli
2023-03-24 17:02 ` [PATCH 1/2] dt-bindings: media: gpio-ir-receiver: Document wakeup-souce property Florian Fainelli
2023-03-24 20:17 ` Rob Herring
2023-03-24 17:02 ` [PATCH 2/2] media: rc: gpio-ir-recv: Fix support for wake-up Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.