* [PATCH v4] dt-bindings: PCI: qcom: Document msi-map and msi-map-mask properties
@ 2023-04-11 12:14 Manivannan Sadhasivam
2023-04-11 16:32 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Manivannan Sadhasivam @ 2023-04-11 12:14 UTC (permalink / raw)
To: andersson, robh+dt, krzysztof.kozlowski+dt
Cc: bhelgaas, konrad.dybcio, linux-arm-msm, linux-pci, devicetree,
linux-kernel, lpieralisi, quic_devipriy, Manivannan Sadhasivam,
Rob Herring
The Qcom PCIe controller is capable of using either internal MSI controller
or the external GIC-ITS for signaling MSIs sent by endpoint devices.
Currently, the binding only documents the internal MSI implementation.
Let's document the GIC-ITS imeplementation by making use of msi-map and
msi-map-mask properties. Only one of the implementation should be used
at a time and the drivers can choose the preferred one.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Changes in v4:
* Spun off from the "Qcom: Add GIC-ITS support to SM8450 PCIe controllers"
series and incorporated the change to allow both MSI implementations.
* Added Reviewed-by tag from Rob
Changes in v3:
* Reworded the commit messages as per Lorenzo's comments
* Rebased on top of v6.2-rc1
Changes in v2:
* Swapped the Device ID for PCIe0 as it causes same issue as PCIe1
* Removed the definition of msi-map and msi-map-mask from binding
* Added Ack from Krzysztof
Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 5d236bac99b6..b26fff04859d 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -130,14 +130,20 @@ required:
- compatible
- reg
- reg-names
- - interrupts
- - interrupt-names
- - "#interrupt-cells"
- interrupt-map-mask
- interrupt-map
- clocks
- clock-names
+anyOf:
+ - required:
+ - interrupts
+ - interrupt-names
+ - "#interrupt-cells"
+ - required:
+ - msi-map
+ - msi-map-mask
+
allOf:
- $ref: /schemas/pci/pci-bus.yaml#
- if:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] dt-bindings: PCI: qcom: Document msi-map and msi-map-mask properties
2023-04-11 12:14 [PATCH v4] dt-bindings: PCI: qcom: Document msi-map and msi-map-mask properties Manivannan Sadhasivam
@ 2023-04-11 16:32 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2023-04-11 16:32 UTC (permalink / raw)
To: andersson, robh+dt, krzysztof.kozlowski+dt, Manivannan Sadhasivam
Cc: Lorenzo Pieralisi, bhelgaas, konrad.dybcio, linux-arm-msm,
linux-pci, devicetree, linux-kernel, quic_devipriy, Rob Herring
On Tue, 11 Apr 2023 17:44:42 +0530, Manivannan Sadhasivam wrote:
> The Qcom PCIe controller is capable of using either internal MSI controller
> or the external GIC-ITS for signaling MSIs sent by endpoint devices.
> Currently, the binding only documents the internal MSI implementation.
>
> Let's document the GIC-ITS imeplementation by making use of msi-map and
> msi-map-mask properties. Only one of the implementation should be used
> at a time and the drivers can choose the preferred one.
>
> [...]
Applied to controller/qcom, thanks!
[1/1] dt-bindings: PCI: qcom: Document msi-map and msi-map-mask properties
https://git.kernel.org/pci/pci/c/9d20b46def04
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-11 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-11 12:14 [PATCH v4] dt-bindings: PCI: qcom: Document msi-map and msi-map-mask properties Manivannan Sadhasivam
2023-04-11 16:32 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.