[PATCH] systemd: Fix service file for race issues

[PATCH] systemd: Fix service file for race issues

[Richard Purdie]

It seems this service needs both Requires: and After: according to the definitions
in the systemd docs, else we see boot race failures.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/psplash/files/psplash-systemd.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/psplash/files/psplash-systemd.service b/meta/recipes-core/psplash/files/psplash-systemd.service
index 249aa540394..4e18980bb27 100644
--- a/meta/recipes-core/psplash/files/psplash-systemd.service
+++ b/meta/recipes-core/psplash/files/psplash-systemd.service
@@ -2,6 +2,7 @@
 Description=Start psplash-systemd progress communication helper
 DefaultDependencies=no
 After=systemd-start.service
+After=psplash-start.service
 Requires=psplash-start.service
 RequiresMountsFor=/run
 
-- 
2.25.0

✗ patchtest: failure for systemd: Fix service file for race issues

[Patchwork]

== Series Details ==

Series: systemd: Fix service file for race issues
Revision: 1
URL   : https://patchwork.openembedded.org/series/23063/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at d6b1809e8c)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] systemd: Fix service file for race issues

[Ernst Sjöstrand]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Yeah it's exactly like that, been bitten by that before.

Regards
//Ernst

tis 2020-03-03 klockan 13:05 +0000 skrev Richard Purdie:

It seems this service needs both Requires: and After: according to the definitions

in the systemd docs, else we see boot race failures.


Signed-off-by: Richard Purdie <

<mailto:richard.purdie@linuxfoundation.org>

richard.purdie@linuxfoundation.org

>

---

 meta/recipes-core/psplash/files/psplash-systemd.service | 1 +

 1 file changed, 1 insertion(+)


diff --git a/meta/recipes-core/psplash/files/psplash-systemd.service b/meta/recipes-core/psplash/files/psplash-systemd.service

index 249aa540394..4e18980bb27 100644

--- a/meta/recipes-core/psplash/files/psplash-systemd.service

+++ b/meta/recipes-core/psplash/files/psplash-systemd.service

@@ -2,6 +2,7 @@

 Description=Start psplash-systemd progress communication helper

 DefaultDependencies=no

 After=systemd-start.service

+After=psplash-start.service

 Requires=psplash-start.service

 RequiresMountsFor=/run



--

2.25.0


[-- Attachment #2: Type: text/html, Size: 1739 bytes --]