* [PATCH qemu 1/1] [meson.build] Add conditional dependency for libkeyutils
2023-05-22 0:17 [PATCH qemu 0/1] [meson.build] Add conditional dependency for libkeyutils ~_6d6178667269747a
@ 2023-05-22 0:12 ` ~_6d6178667269747a
2023-05-26 7:34 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: ~_6d6178667269747a @ 2023-05-22 0:12 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth
From: Max Fritz <antischmock@googlemail.com>
This modification enables better control over the inclusion of libkeyutils
based on the configuration, enhancing the flexibility of the build system.
Signed-off-by: Max Fritz <antischmock@googlemail.com>
---
meson.build | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 0a5cdefd4d..206d4033bf 100644
--- a/meson.build
+++ b/meson.build
@@ -1764,8 +1764,11 @@ if gnutls.found()
tasn1 = dependency('libtasn1',
method: 'pkg-config')
endif
-keyutils = dependency('libkeyutils', required: false,
- method: 'pkg-config')
+keyutils = not_found
+if get_option('keyring').enabled()
+ keyutils = dependency('libkeyutils', required: false,
+ method: 'pkg-config', kwargs: static_kwargs)
+endif
has_gettid = cc.has_function('gettid')
--
2.38.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH qemu 0/1] [meson.build] Add conditional dependency for libkeyutils
@ 2023-05-22 0:17 ~_6d6178667269747a
2023-05-22 0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
0 siblings, 1 reply; 5+ messages in thread
From: ~_6d6178667269747a @ 2023-05-22 0:17 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth
I have a patch that adds a conditional dependency for 'libkeyutils' in
the meson.build file to enhance the build system's flexibility. The
patch addresses the following issue:
If the dynamic library 'libkeyutils' is found by pkg-config, but one
attempts to build with static linkage, the build will fail, even if the
keyring feature is disabled and, therefore, the library is not needed.
Max Fritz (1):
[meson.build] Add conditional dependency for libkeyutils
meson.build | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.38.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH qemu 1/1] [meson.build] Add conditional dependency for libkeyutils
2023-05-22 0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
@ 2023-05-26 7:34 ` Thomas Huth
2023-05-26 10:32 ` Daniel P. Berrangé
2023-05-31 13:09 ` Thomas Huth
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2023-05-26 7:34 UTC (permalink / raw)
To: ~_6d6178667269747a, qemu-devel, Daniel P. Berrange
Cc: Paolo Bonzini, Gonglei, zhenwei pi, antischmock
Hi!
On 22/05/2023 02.12, ~_6d6178667269747a wrote:
There is something weird with your setup (sender name is "~_6d6178667269747a" ?)
> From: Max Fritz <antischmock@googlemail.com>
>
> This modification enables better control over the inclusion of libkeyutils
> based on the configuration, enhancing the flexibility of the build system.
>
> Signed-off-by: Max Fritz <antischmock@googlemail.com>
> ---
> meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 0a5cdefd4d..206d4033bf 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1764,8 +1764,11 @@ if gnutls.found()
> tasn1 = dependency('libtasn1',
> method: 'pkg-config')
> endif
> -keyutils = dependency('libkeyutils', required: false,
> - method: 'pkg-config')
> +keyutils = not_found
> +if get_option('keyring').enabled()
> + keyutils = dependency('libkeyutils', required: false,
> + method: 'pkg-config', kwargs: static_kwargs)
> +endif
>
> has_gettid = cc.has_function('gettid')
Please put the maintainer for the crypto/ folder for this into copy (done now).
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH qemu 1/1] [meson.build] Add conditional dependency for libkeyutils
2023-05-22 0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
2023-05-26 7:34 ` Thomas Huth
@ 2023-05-26 10:32 ` Daniel P. Berrangé
2023-05-31 13:09 ` Thomas Huth
2 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2023-05-26 10:32 UTC (permalink / raw)
To: ~_6d6178667269747a; +Cc: qemu-devel, thuth
On Mon, May 22, 2023 at 02:12:02AM +0200, ~_6d6178667269747a wrote:
> From: Max Fritz <antischmock@googlemail.com>
>
> This modification enables better control over the inclusion of libkeyutils
> based on the configuration, enhancing the flexibility of the build system.
>
> Signed-off-by: Max Fritz <antischmock@googlemail.com>
> ---
> meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH qemu 1/1] [meson.build] Add conditional dependency for libkeyutils
2023-05-22 0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
2023-05-26 7:34 ` Thomas Huth
2023-05-26 10:32 ` Daniel P. Berrangé
@ 2023-05-31 13:09 ` Thomas Huth
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2023-05-31 13:09 UTC (permalink / raw)
To: qemu-devel, Max Fritz; +Cc: Daniel P. Berrange
On 22/05/2023 02.12, ~_6d6178667269747a wrote:
> From: Max Fritz <antischmock@googlemail.com>
>
> This modification enables better control over the inclusion of libkeyutils
> based on the configuration, enhancing the flexibility of the build system.
>
> Signed-off-by: Max Fritz <antischmock@googlemail.com>
> ---
> meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 0a5cdefd4d..206d4033bf 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1764,8 +1764,11 @@ if gnutls.found()
> tasn1 = dependency('libtasn1',
> method: 'pkg-config')
> endif
> -keyutils = dependency('libkeyutils', required: false,
> - method: 'pkg-config')
> +keyutils = not_found
> +if get_option('keyring').enabled()
> + keyutils = dependency('libkeyutils', required: false,
> + method: 'pkg-config', kwargs: static_kwargs)
> +endif
FYI, since nobody else picked this up yet, I'll add this to my next pull
request (dropping the "kwargs" part from the patch, AFAIK it's not needed
anymore, see commit 063d5119c18af76).
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-31 13:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 0:17 [PATCH qemu 0/1] [meson.build] Add conditional dependency for libkeyutils ~_6d6178667269747a
2023-05-22 0:12 ` [PATCH qemu 1/1] " ~_6d6178667269747a
2023-05-26 7:34 ` Thomas Huth
2023-05-26 10:32 ` Daniel P. Berrangé
2023-05-31 13:09 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.