* [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
@ 2023-05-22 12:51 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
some logic to reflect that.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- Replaced items: with const: for the single item (Conor)
.../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
index 07388bf2b90d..d97064140547 100644
--- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
@@ -28,12 +28,12 @@ properties:
const: ldb
reg:
+ minItems: 1
maxItems: 2
reg-names:
- items:
- - const: ldb
- - const: lvds
+ minItems: 1
+ maxItems: 2
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -74,6 +74,26 @@ allOf:
properties:
port@2: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx6sx-ldb
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ reg-names:
+ const: ldb
+ else:
+ properties:
+ reg:
+ minItems: 2
+ reg-names:
+ items:
+ - const: ldb
+ - const: lvds
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
@ 2023-05-22 12:51 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
some logic to reflect that.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- Replaced items: with const: for the single item (Conor)
.../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
index 07388bf2b90d..d97064140547 100644
--- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
@@ -28,12 +28,12 @@ properties:
const: ldb
reg:
+ minItems: 1
maxItems: 2
reg-names:
- items:
- - const: ldb
- - const: lvds
+ minItems: 1
+ maxItems: 2
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -74,6 +74,26 @@ allOf:
properties:
port@2: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx6sx-ldb
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ reg-names:
+ const: ldb
+ else:
+ properties:
+ reg:
+ minItems: 2
+ reg-names:
+ items:
+ - const: ldb
+ - const: lvds
+
additionalProperties: false
examples:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 12:51 ` Fabio Estevam
-1 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The i.MX6SX General Purpose Registers is a set of register that serves
various different purposes and in particular, IOMUXC_GPR_GPR6, at
offset 0x18, can be used to configure the LDB block.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- Renamed to syscon@20e4000 (Conor).
.../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
1 file changed, 84 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
new file mode 100644
index 000000000000..22777ecfb56b
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX6SX General Purpose Register
+
+maintainers:
+ - Fabio Estevam <festevam@denx.de>
+
+description:
+ The i.MX6SX General Purpose Registers is a set of register that serves
+ for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18,
+ can be used to configure the LDB block.
+
+properties:
+ compatible:
+ items:
+ - const: fsl,imx6sx-iomuxc-gpr
+ - const: fsl,imx6q-iomuxc-gpr
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ bridge@18:
+ type: object
+ $ref: /schemas/display/bridge/fsl,ldb.yaml#
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - '#address-cells'
+ - '#size-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx6sx-clock.h>
+
+ syscon@20e4000 {
+ compatible = "fsl,imx6sx-iomuxc-gpr", "fsl,imx6q-iomuxc-gpr", "syscon";
+ reg = <0x020e4000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ bridge@18 {
+ compatible = "fsl,imx6sx-ldb";
+ reg = <0x18 0x4>;
+ reg-names = "ldb";
+ clocks = <&clks IMX6SX_CLK_LDB_DI0>;
+ clock-names = "ldb";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ldb_from_lcdif1: endpoint {
+ remote-endpoint = <&lcdif1_to_ldb>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ldb_lvds_ch0: endpoint {
+ };
+ };
+ };
+ };
+ };
+...
--
2.34.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
@ 2023-05-22 12:51 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The i.MX6SX General Purpose Registers is a set of register that serves
various different purposes and in particular, IOMUXC_GPR_GPR6, at
offset 0x18, can be used to configure the LDB block.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- Renamed to syscon@20e4000 (Conor).
.../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
1 file changed, 84 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
new file mode 100644
index 000000000000..22777ecfb56b
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX6SX General Purpose Register
+
+maintainers:
+ - Fabio Estevam <festevam@denx.de>
+
+description:
+ The i.MX6SX General Purpose Registers is a set of register that serves
+ for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18,
+ can be used to configure the LDB block.
+
+properties:
+ compatible:
+ items:
+ - const: fsl,imx6sx-iomuxc-gpr
+ - const: fsl,imx6q-iomuxc-gpr
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ bridge@18:
+ type: object
+ $ref: /schemas/display/bridge/fsl,ldb.yaml#
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - '#address-cells'
+ - '#size-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/imx6sx-clock.h>
+
+ syscon@20e4000 {
+ compatible = "fsl,imx6sx-iomuxc-gpr", "fsl,imx6q-iomuxc-gpr", "syscon";
+ reg = <0x020e4000 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ bridge@18 {
+ compatible = "fsl,imx6sx-ldb";
+ reg = <0x18 0x4>;
+ reg-names = "ldb";
+ clocks = <&clks IMX6SX_CLK_LDB_DI0>;
+ clock-names = "ldb";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ldb_from_lcdif1: endpoint {
+ remote-endpoint = <&lcdif1_to_ldb>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ldb_lvds_ch0: endpoint {
+ };
+ };
+ };
+ };
+ };
+...
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 12:51 ` Fabio Estevam
-1 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
i.MX6SX has an LVDS controller that is connected to the eLCDIF.
Add support for it.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- None.
arch/arm/boot/dts/imx6sx.dtsi | 39 +++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 4233943a1cca..442106565025 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
gpr: iomuxc-gpr@20e4000 {
compatible = "fsl,imx6sx-iomuxc-gpr",
"fsl,imx6q-iomuxc-gpr", "syscon";
+ #address-cells = <1>;
+ #size-cells = <1>;
reg = <0x020e4000 0x4000>;
+
+ lvds_bridge: bridge@18 {
+ compatible = "fsl,imx6sx-ldb";
+ reg = <0x18 0x4>;
+ reg-names = "ldb";
+ clocks = <&clks IMX6SX_CLK_LDB_DI0>;
+ clock-names = "ldb";
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ldb_from_lcdif1: endpoint {
+ remote-endpoint = <&lcdif1_to_ldb>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ldb_lvds_ch0: endpoint {
+ };
+ };
+ };
+ };
};
sdma: dma-controller@20ec000 {
@@ -1278,6 +1309,14 @@ lcdif1: lcdif@2220000 {
clock-names = "pix", "axi", "disp_axi";
power-domains = <&pd_disp>;
status = "disabled";
+
+ ports {
+ port {
+ lcdif1_to_ldb: endpoint {
+ remote-endpoint = <&ldb_from_lcdif1>;
+ };
+ };
+ };
};
lcdif2: lcdif@2224000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
@ 2023-05-22 12:51 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
i.MX6SX has an LVDS controller that is connected to the eLCDIF.
Add support for it.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- None.
arch/arm/boot/dts/imx6sx.dtsi | 39 +++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 4233943a1cca..442106565025 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
gpr: iomuxc-gpr@20e4000 {
compatible = "fsl,imx6sx-iomuxc-gpr",
"fsl,imx6q-iomuxc-gpr", "syscon";
+ #address-cells = <1>;
+ #size-cells = <1>;
reg = <0x020e4000 0x4000>;
+
+ lvds_bridge: bridge@18 {
+ compatible = "fsl,imx6sx-ldb";
+ reg = <0x18 0x4>;
+ reg-names = "ldb";
+ clocks = <&clks IMX6SX_CLK_LDB_DI0>;
+ clock-names = "ldb";
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ldb_from_lcdif1: endpoint {
+ remote-endpoint = <&lcdif1_to_ldb>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ldb_lvds_ch0: endpoint {
+ };
+ };
+ };
+ };
};
sdma: dma-controller@20ec000 {
@@ -1278,6 +1309,14 @@ lcdif1: lcdif@2220000 {
clock-names = "pix", "axi", "disp_axi";
power-domains = <&pd_disp>;
status = "disabled";
+
+ ports {
+ port {
+ lcdif1_to_ldb: endpoint {
+ remote-endpoint = <&ldb_from_lcdif1>;
+ };
+ };
+ };
};
lcdif2: lcdif@2224000 {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 12:51 ` Fabio Estevam
-1 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The motivation for this imx6sx-gpr driver is to allow describing
the LVDS LDB bridge as a GPR subnode.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- None.
drivers/soc/imx/Makefile | 1 +
drivers/soc/imx/imx6sx-gpr.c | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+)
create mode 100644 drivers/soc/imx/imx6sx-gpr.c
diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
index a28c44a1f16a..9840d4c41015 100644
--- a/drivers/soc/imx/Makefile
+++ b/drivers/soc/imx/Makefile
@@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o
endif
obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
+obj-$(CONFIG_SOC_IMX6SX) += imx6sx-gpr.o
obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8m-blk-ctrl.o
obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8mp-blk-ctrl.o
diff --git a/drivers/soc/imx/imx6sx-gpr.c b/drivers/soc/imx/imx6sx-gpr.c
new file mode 100644
index 000000000000..7684acbe43ff
--- /dev/null
+++ b/drivers/soc/imx/imx6sx-gpr.c
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+
+static int imx6sx_gpr_probe(struct platform_device *pdev)
+{
+ return devm_of_platform_populate(&pdev->dev);
+}
+
+static const struct of_device_id imx6sx_gpr_ids[] = {
+ { .compatible = "fsl,imx6sx-iomuxc-gpr" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, imx6sx_gpr_ids);
+
+static struct platform_driver imx6sx_gpr_driver = {
+ .driver = {
+ .name = "imx6sx_gpr",
+ .of_match_table = imx6sx_gpr_ids,
+ },
+ .probe = imx6sx_gpr_probe,
+};
+module_platform_driver(imx6sx_gpr_driver);
+
+MODULE_AUTHOR("Fabio Estevam <festevam@denx.de>");
+MODULE_DESCRIPTION("NXP i.MX6SX GPR driver");
+MODULE_LICENSE("GPL");
--
2.34.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH v5 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver
@ 2023-05-22 12:51 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 12:51 UTC (permalink / raw)
To: shawnguo
Cc: marex, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The motivation for this imx6sx-gpr driver is to allow describing
the LVDS LDB bridge as a GPR subnode.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- None.
drivers/soc/imx/Makefile | 1 +
drivers/soc/imx/imx6sx-gpr.c | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+)
create mode 100644 drivers/soc/imx/imx6sx-gpr.c
diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
index a28c44a1f16a..9840d4c41015 100644
--- a/drivers/soc/imx/Makefile
+++ b/drivers/soc/imx/Makefile
@@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_MXC) += soc-imx.o
endif
obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
+obj-$(CONFIG_SOC_IMX6SX) += imx6sx-gpr.o
obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8m-blk-ctrl.o
obj-$(CONFIG_IMX8M_BLK_CTRL) += imx8mp-blk-ctrl.o
diff --git a/drivers/soc/imx/imx6sx-gpr.c b/drivers/soc/imx/imx6sx-gpr.c
new file mode 100644
index 000000000000..7684acbe43ff
--- /dev/null
+++ b/drivers/soc/imx/imx6sx-gpr.c
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+
+static int imx6sx_gpr_probe(struct platform_device *pdev)
+{
+ return devm_of_platform_populate(&pdev->dev);
+}
+
+static const struct of_device_id imx6sx_gpr_ids[] = {
+ { .compatible = "fsl,imx6sx-iomuxc-gpr" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, imx6sx_gpr_ids);
+
+static struct platform_driver imx6sx_gpr_driver = {
+ .driver = {
+ .name = "imx6sx_gpr",
+ .of_match_table = imx6sx_gpr_ids,
+ },
+ .probe = imx6sx_gpr_probe,
+};
+module_platform_driver(imx6sx_gpr_driver);
+
+MODULE_AUTHOR("Fabio Estevam <festevam@denx.de>");
+MODULE_DESCRIPTION("NXP i.MX6SX GPR driver");
+MODULE_LICENSE("GPL");
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 13:12 ` Marek Vasut
-1 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:12 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
> some logic to reflect that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Replaced items: with const: for the single item (Conor)
>
> .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> index 07388bf2b90d..d97064140547 100644
> --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -28,12 +28,12 @@ properties:
> const: ldb
>
> reg:
> + minItems: 1
> maxItems: 2
>
> reg-names:
> - items:
> - - const: ldb
> - - const: lvds
> + minItems: 1
> + maxItems: 2
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -74,6 +74,26 @@ allOf:
> properties:
> port@2: false
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx6sx-ldb
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + reg-names:
> + const: ldb
Can we drop the reg-names on MX6SX if we have reg maxItems=1 here ?
I think we can, but we need to retain that on the newer iMXes which have
reg maxItems=2
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
@ 2023-05-22 13:12 ` Marek Vasut
0 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:12 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
> some logic to reflect that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Replaced items: with const: for the single item (Conor)
>
> .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> index 07388bf2b90d..d97064140547 100644
> --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml
> @@ -28,12 +28,12 @@ properties:
> const: ldb
>
> reg:
> + minItems: 1
> maxItems: 2
>
> reg-names:
> - items:
> - - const: ldb
> - - const: lvds
> + minItems: 1
> + maxItems: 2
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -74,6 +74,26 @@ allOf:
> properties:
> port@2: false
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx6sx-ldb
> + then:
> + properties:
> + reg:
> + maxItems: 1
> + reg-names:
> + const: ldb
Can we drop the reg-names on MX6SX if we have reg maxItems=1 here ?
I think we can, but we need to retain that on the newer iMXes which have
reg maxItems=2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 13:20 ` Marek Vasut
-1 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:20 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The i.MX6SX General Purpose Registers is a set of register that serves
> various different purposes and in particular, IOMUXC_GPR_GPR6, at
> offset 0x18, can be used to configure the LDB block.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Renamed to syscon@20e4000 (Conor).
>
> .../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
> 1 file changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
> new file mode 100644
> index 000000000000..22777ecfb56b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX6SX General Purpose Register
> +
> +maintainers:
> + - Fabio Estevam <festevam@denx.de>
> +
> +description:
> + The i.MX6SX General Purpose Registers is a set of register that serves
> + for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18,
> + can be used to configure the LDB block.
> +
> +properties:
> + compatible:
> + items:
> + - const: fsl,imx6sx-iomuxc-gpr
> + - const: fsl,imx6q-iomuxc-gpr
> + - const: syscon
Take a look at MX6Q and notice how the iomuxc and GPR register sets
share the same base address . That's different on MX6SX where they are
separate. So I think this binding should be specific to MX6SX ONLY and
for MX6Q the subnode probing should be handled in the IOMUXC driver
instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
$ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000 {
arch/arm/boot/dts/imx6qdl.dtsi- compatible =
"fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
arch/arm/boot/dts/imx6qdl.dtsi- reg = <0x20e0000
0x38>;
--
arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000 {
arch/arm/boot/dts/imx6qdl.dtsi- compatible =
"fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
arch/arm/boot/dts/imx6qdl.dtsi- reg = <0x20e0000
0x4000>;
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
@ 2023-05-22 13:20 ` Marek Vasut
0 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:20 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The i.MX6SX General Purpose Registers is a set of register that serves
> various different purposes and in particular, IOMUXC_GPR_GPR6, at
> offset 0x18, can be used to configure the LDB block.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Renamed to syscon@20e4000 (Conor).
>
> .../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
> 1 file changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
> new file mode 100644
> index 000000000000..22777ecfb56b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/imx/fsl,imx6sx-gpr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX6SX General Purpose Register
> +
> +maintainers:
> + - Fabio Estevam <festevam@denx.de>
> +
> +description:
> + The i.MX6SX General Purpose Registers is a set of register that serves
> + for various purposes and in particular, IOMUXC_GPR_GPR6, at offset 0x18,
> + can be used to configure the LDB block.
> +
> +properties:
> + compatible:
> + items:
> + - const: fsl,imx6sx-iomuxc-gpr
> + - const: fsl,imx6q-iomuxc-gpr
> + - const: syscon
Take a look at MX6Q and notice how the iomuxc and GPR register sets
share the same base address . That's different on MX6SX where they are
separate. So I think this binding should be specific to MX6SX ONLY and
for MX6Q the subnode probing should be handled in the IOMUXC driver
instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
$ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000 {
arch/arm/boot/dts/imx6qdl.dtsi- compatible =
"fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
arch/arm/boot/dts/imx6qdl.dtsi- reg = <0x20e0000
0x38>;
--
arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000 {
arch/arm/boot/dts/imx6qdl.dtsi- compatible =
"fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
arch/arm/boot/dts/imx6qdl.dtsi- reg = <0x20e0000
0x4000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 13:20 ` Marek Vasut
-1 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:20 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX6SX has an LVDS controller that is connected to the eLCDIF.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - None.
>
> arch/arm/boot/dts/imx6sx.dtsi | 39 +++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 4233943a1cca..442106565025 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
> gpr: iomuxc-gpr@20e4000 {
> compatible = "fsl,imx6sx-iomuxc-gpr",
> "fsl,imx6q-iomuxc-gpr", "syscon";
Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
@ 2023-05-22 13:20 ` Marek Vasut
0 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 13:20 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
conor+dt, Fabio Estevam
On 5/22/23 14:51, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX6SX has an LVDS controller that is connected to the eLCDIF.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - None.
>
> arch/arm/boot/dts/imx6sx.dtsi | 39 +++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 4233943a1cca..442106565025 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
> gpr: iomuxc-gpr@20e4000 {
> compatible = "fsl,imx6sx-iomuxc-gpr",
> "fsl,imx6q-iomuxc-gpr", "syscon";
Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 13:28 ` Rob Herring
-1 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2023-05-22 13:28 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, devicetree, Fabio Estevam, conor+dt, marex,
linux-arm-kernel, shawnguo, krzysztof.kozlowski+dt
On Mon, 22 May 2023 09:51:26 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
> some logic to reflect that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Replaced items: with const: for the single item (Conor)
>
> .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml:84:12: [warning] wrong indentation: expected 10 but found 11 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522125129.526604-1-festevam@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
2023-05-22 12:51 ` Fabio Estevam
@ 2023-05-22 13:28 ` Rob Herring
-1 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2023-05-22 13:28 UTC (permalink / raw)
To: Fabio Estevam
Cc: krzysztof.kozlowski+dt, marex, conor+dt, devicetree, shawnguo,
Fabio Estevam, linux-arm-kernel, robh+dt
On Mon, 22 May 2023 09:51:27 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The i.MX6SX General Purpose Registers is a set of register that serves
> various different purposes and in particular, IOMUXC_GPR_GPR6, at
> offset 0x18, can be used to configure the LDB block.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Renamed to syscon@20e4000 (Conor).
>
> .../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
> 1 file changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:reg: [[24, 4]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:reg-names: ['ldb'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18: Unevaluated properties are not allowed ('compatible', 'reg', 'reg-names' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: /example-0/syscon@20e4000/bridge@18: failed to match any schema with compatible: ['fsl,imx6sx-ldb']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522125129.526604-2-festevam@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries
@ 2023-05-22 13:28 ` Rob Herring
0 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2023-05-22 13:28 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, devicetree, Fabio Estevam, conor+dt, marex,
linux-arm-kernel, shawnguo, krzysztof.kozlowski+dt
On Mon, 22 May 2023 09:51:26 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add
> some logic to reflect that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Replaced items: with const: for the single item (Conor)
>
> .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml:84:12: [warning] wrong indentation: expected 10 but found 11 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522125129.526604-1-festevam@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
@ 2023-05-22 13:28 ` Rob Herring
0 siblings, 0 replies; 26+ messages in thread
From: Rob Herring @ 2023-05-22 13:28 UTC (permalink / raw)
To: Fabio Estevam
Cc: krzysztof.kozlowski+dt, marex, conor+dt, devicetree, shawnguo,
Fabio Estevam, linux-arm-kernel, robh+dt
On Mon, 22 May 2023 09:51:27 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The i.MX6SX General Purpose Registers is a set of register that serves
> various different purposes and in particular, IOMUXC_GPR_GPR6, at
> offset 0x18, can be used to configure the LDB block.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v4:
> - Renamed to syscon@20e4000 (Conor).
>
> .../bindings/soc/imx/fsl,imx6sx-gpr.yaml | 84 +++++++++++++++++++
> 1 file changed, 84 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:compatible:0: 'fsl,imx6sx-ldb' is not one of ['fsl,imx8mp-ldb', 'fsl,imx93-ldb']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:reg: [[24, 4]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18:reg-names: ['ldb'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: syscon@20e4000: bridge@18: Unevaluated properties are not allowed ('compatible', 'reg', 'reg-names' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb: /example-0/syscon@20e4000/bridge@18: failed to match any schema with compatible: ['fsl,imx6sx-ldb']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522125129.526604-2-festevam@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
2023-05-22 13:20 ` Marek Vasut
@ 2023-05-22 14:18 ` Fabio Estevam
-1 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 14:18 UTC (permalink / raw)
To: Marek Vasut
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
Hi Marek,
On 22/05/2023 10:20, Marek Vasut wrote:
> Take a look at MX6Q and notice how the iomuxc and GPR register sets
> share the same base address . That's different on MX6SX where they are
> separate. So I think this binding should be specific to MX6SX ONLY and
> for MX6Q the subnode probing should be handled in the IOMUXC driver
> instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
>
> $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
> arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x38>;
> --
> arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x4000>;
Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx
as the driver searches for "fsl,imx6q-iomuxc-gpr":
static const struct imx6_pcie_drvdata drvdata[] = {
....
[IMX6SX] = {
.variant = IMX6SX,
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
.gpr = "fsl,imx6q-iomuxc-gpr",
# dmesg | grep pci
[ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
@ 2023-05-22 14:18 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 14:18 UTC (permalink / raw)
To: Marek Vasut
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
Hi Marek,
On 22/05/2023 10:20, Marek Vasut wrote:
> Take a look at MX6Q and notice how the iomuxc and GPR register sets
> share the same base address . That's different on MX6SX where they are
> separate. So I think this binding should be specific to MX6SX ONLY and
> for MX6Q the subnode probing should be handled in the IOMUXC driver
> instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
>
> $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
> arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x38>;
> --
> arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x4000>;
Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx
as the driver searches for "fsl,imx6q-iomuxc-gpr":
static const struct imx6_pcie_drvdata drvdata[] = {
....
[IMX6SX] = {
.variant = IMX6SX,
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
.gpr = "fsl,imx6q-iomuxc-gpr",
# dmesg | grep pci
[ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
2023-05-22 13:20 ` Marek Vasut
@ 2023-05-22 14:19 ` Fabio Estevam
-1 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 14:19 UTC (permalink / raw)
To: Marek Vasut
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 22/05/2023 10:20, Marek Vasut wrote:
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
>> b/arch/arm/boot/dts/imx6sx.dtsi
>> index 4233943a1cca..442106565025 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
>> gpr: iomuxc-gpr@20e4000 {
>> compatible = "fsl,imx6sx-iomuxc-gpr",
>> "fsl,imx6q-iomuxc-gpr", "syscon";
>
> Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
Cannot remove it as it breaks PCI:
imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
@ 2023-05-22 14:19 ` Fabio Estevam
0 siblings, 0 replies; 26+ messages in thread
From: Fabio Estevam @ 2023-05-22 14:19 UTC (permalink / raw)
To: Marek Vasut
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 22/05/2023 10:20, Marek Vasut wrote:
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
>> b/arch/arm/boot/dts/imx6sx.dtsi
>> index 4233943a1cca..442106565025 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
>> gpr: iomuxc-gpr@20e4000 {
>> compatible = "fsl,imx6sx-iomuxc-gpr",
>> "fsl,imx6q-iomuxc-gpr", "syscon";
>
> Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
Cannot remove it as it breaks PCI:
imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
2023-05-22 14:19 ` Fabio Estevam
@ 2023-05-22 14:22 ` Marek Vasut
-1 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 14:22 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 5/22/23 16:19, Fabio Estevam wrote:
> On 22/05/2023 10:20, Marek Vasut wrote:
>
>>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
>>> b/arch/arm/boot/dts/imx6sx.dtsi
>>> index 4233943a1cca..442106565025 100644
>>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>>> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
>>> gpr: iomuxc-gpr@20e4000 {
>>> compatible = "fsl,imx6sx-iomuxc-gpr",
>>> "fsl,imx6q-iomuxc-gpr", "syscon";
>>
>> Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
>
> Cannot remove it as it breaks PCI:
>
> imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
This might help?
diff --git a/drivers/pci/controller/dwc/pci-imx6.c
b/drivers/pci/controller/dwc/pci-imx6.c
index 52906f999f2bb..4803e3c9ee37c 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1460,7 +1460,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
- .gpr = "fsl,imx6q-iomuxc-gpr",
+ .gpr = "fsl,imx6sx-iomuxc-gpr",
},
[IMX6QP] = {
.variant = IMX6QP,
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support
@ 2023-05-22 14:22 ` Marek Vasut
0 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 14:22 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 5/22/23 16:19, Fabio Estevam wrote:
> On 22/05/2023 10:20, Marek Vasut wrote:
>
>>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi
>>> b/arch/arm/boot/dts/imx6sx.dtsi
>>> index 4233943a1cca..442106565025 100644
>>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>>> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 {
>>> gpr: iomuxc-gpr@20e4000 {
>>> compatible = "fsl,imx6sx-iomuxc-gpr",
>>> "fsl,imx6q-iomuxc-gpr", "syscon";
>>
>> Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
>
> Cannot remove it as it breaks PCI:
>
> imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
This might help?
diff --git a/drivers/pci/controller/dwc/pci-imx6.c
b/drivers/pci/controller/dwc/pci-imx6.c
index 52906f999f2bb..4803e3c9ee37c 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1460,7 +1460,7 @@ static const struct imx6_pcie_drvdata drvdata[] = {
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
- .gpr = "fsl,imx6q-iomuxc-gpr",
+ .gpr = "fsl,imx6sx-iomuxc-gpr",
},
[IMX6QP] = {
.variant = IMX6QP,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
2023-05-22 14:18 ` Fabio Estevam
@ 2023-05-22 14:24 ` Marek Vasut
-1 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 14:24 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 5/22/23 16:18, Fabio Estevam wrote:
> Hi Marek,
>
> On 22/05/2023 10:20, Marek Vasut wrote:
>
>> Take a look at MX6Q and notice how the iomuxc and GPR register sets
>> share the same base address . That's different on MX6SX where they are
>> separate. So I think this binding should be specific to MX6SX ONLY and
>> for MX6Q the subnode probing should be handled in the IOMUXC driver
>> instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
>>
>> $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
>> arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000 {
>> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
>> "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
>> arch/arm/boot/dts/imx6qdl.dtsi- reg =
>> <0x20e0000 0x38>;
>> --
>> arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000 {
>> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
>> "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
>> arch/arm/boot/dts/imx6qdl.dtsi- reg =
>> <0x20e0000 0x4000>;
>
> Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx
> as the driver searches for "fsl,imx6q-iomuxc-gpr":
>
> static const struct imx6_pcie_drvdata drvdata[] = {
> ....
> [IMX6SX] = {
> .variant = IMX6SX,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
> IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
> .gpr = "fsl,imx6q-iomuxc-gpr",
>
>
> # dmesg | grep pci
> [ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
I would say, this should use the mx6sx compatible string for the GPR
look up (or even use phandle ?)
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
@ 2023-05-22 14:24 ` Marek Vasut
0 siblings, 0 replies; 26+ messages in thread
From: Marek Vasut @ 2023-05-22 14:24 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, shawnguo, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-kernel, conor+dt
On 5/22/23 16:18, Fabio Estevam wrote:
> Hi Marek,
>
> On 22/05/2023 10:20, Marek Vasut wrote:
>
>> Take a look at MX6Q and notice how the iomuxc and GPR register sets
>> share the same base address . That's different on MX6SX where they are
>> separate. So I think this binding should be specific to MX6SX ONLY and
>> for MX6Q the subnode probing should be handled in the IOMUXC driver
>> instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
>>
>> $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
>> arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000 {
>> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
>> "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
>> arch/arm/boot/dts/imx6qdl.dtsi- reg =
>> <0x20e0000 0x38>;
>> --
>> arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000 {
>> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
>> "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
>> arch/arm/boot/dts/imx6qdl.dtsi- reg =
>> <0x20e0000 0x4000>;
>
> Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx
> as the driver searches for "fsl,imx6q-iomuxc-gpr":
>
> static const struct imx6_pcie_drvdata drvdata[] = {
> ....
> [IMX6SX] = {
> .variant = IMX6SX,
> .flags = IMX6_PCIE_FLAG_IMX6_PHY |
> IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
> IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
> .gpr = "fsl,imx6q-iomuxc-gpr",
>
>
> # dmesg | grep pci
> [ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
I would say, this should use the mx6sx compatible string for the GPR
look up (or even use phandle ?)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2023-05-22 14:24 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 12:51 [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Fabio Estevam
2023-05-22 12:51 ` Fabio Estevam
2023-05-22 12:51 ` [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register Fabio Estevam
2023-05-22 12:51 ` Fabio Estevam
2023-05-22 13:20 ` Marek Vasut
2023-05-22 13:20 ` Marek Vasut
2023-05-22 14:18 ` Fabio Estevam
2023-05-22 14:18 ` Fabio Estevam
2023-05-22 14:24 ` Marek Vasut
2023-05-22 14:24 ` Marek Vasut
2023-05-22 13:28 ` Rob Herring
2023-05-22 13:28 ` Rob Herring
2023-05-22 12:51 ` [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-22 12:51 ` Fabio Estevam
2023-05-22 13:20 ` Marek Vasut
2023-05-22 13:20 ` Marek Vasut
2023-05-22 14:19 ` Fabio Estevam
2023-05-22 14:19 ` Fabio Estevam
2023-05-22 14:22 ` Marek Vasut
2023-05-22 14:22 ` Marek Vasut
2023-05-22 12:51 ` [PATCH v5 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver Fabio Estevam
2023-05-22 12:51 ` Fabio Estevam
2023-05-22 13:12 ` [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Marek Vasut
2023-05-22 13:12 ` Marek Vasut
2023-05-22 13:28 ` Rob Herring
2023-05-22 13:28 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.