* [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver
@ 2023-05-26 6:46 Mauro Carvalho Chehab
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes Mauro Carvalho Chehab
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-26 6:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Don't let documentation to be out of sync with test changes for
i915.
The first patch contains a change on some subtsts at i915/perf_pmu
that happened after the patches adding documentation to i915.
After fixing it, we can now enable the check at build time.
Mauro Carvalho Chehab (2):
i915/perf_pmu: sync documentation with latest changes
testplan/meson.build: make it check for missing i915 documentation
docs/testplan/meson.build | 4 ++--
tests/i915/perf_pmu.c | 8 +-------
2 files changed, 3 insertions(+), 9 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes
2023-05-26 6:46 [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver Mauro Carvalho Chehab
@ 2023-05-26 6:46 ` Mauro Carvalho Chehab
2023-05-26 12:25 ` Kamil Konieczny
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
` (2 subsequent siblings)
3 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-26 6:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
There are some changes on some test names since when the
documentation was generated for this file.
Update it to keep in sync with the actual tests.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
tests/i915/perf_pmu.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
index 2aa018e13aff..8b31df7b229e 100644
--- a/tests/i915/perf_pmu.c
+++ b/tests/i915/perf_pmu.c
@@ -145,9 +145,6 @@
* Feature: i915 pmu perf interface, pmu
* Test category: Perf
*
- * SUBTEST: frequency-idle
- * Feature: pmu
- *
* SUBTEST: gt-awake
* Description: Setup workload on all engines,measure gt awake time via pmu
* Feature: i915 pmu perf interface, pmu
@@ -226,10 +223,7 @@
* SUBTEST: rc6
* Feature: pmu
*
- * SUBTEST: rc6-runtime-pm
- * Feature: pmu
- *
- * SUBTEST: rc6-runtime-pm-long
+ * SUBTEST: rc6-all-gts
* Feature: pmu
*
* SUBTEST: rc6-suspend
--
2.40.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-05-26 6:46 [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver Mauro Carvalho Chehab
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes Mauro Carvalho Chehab
@ 2023-05-26 6:46 ` Mauro Carvalho Chehab
2023-05-26 12:26 ` Kamil Konieczny
2023-07-04 12:28 ` Tvrtko Ursulin
2023-05-26 13:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable documentation check for i915 driver Patchwork
2023-05-27 4:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 2 replies; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-05-26 6:46 UTC (permalink / raw)
To: igt-dev
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Now that i915 is fully documented, check it at build time.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
docs/testplan/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
index 6cd44be5ccd3..bf73dd32a15f 100644
--- a/docs/testplan/meson.build
+++ b/docs/testplan/meson.build
@@ -30,13 +30,13 @@ xe_test_dict = {
if build_xe
test_dict = {
- 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
+ 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
}
else
test_dict = {
- 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
+ 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
}
endif
--
2.40.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes Mauro Carvalho Chehab
@ 2023-05-26 12:25 ` Kamil Konieczny
0 siblings, 0 replies; 13+ messages in thread
From: Kamil Konieczny @ 2023-05-26 12:25 UTC (permalink / raw)
To: igt-dev
On 2023-05-26 at 08:46:23 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> There are some changes on some test names since when the
> documentation was generated for this file.
>
> Update it to keep in sync with the actual tests.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/i915/perf_pmu.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 2aa018e13aff..8b31df7b229e 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -145,9 +145,6 @@
> * Feature: i915 pmu perf interface, pmu
> * Test category: Perf
> *
> - * SUBTEST: frequency-idle
> - * Feature: pmu
> - *
> * SUBTEST: gt-awake
> * Description: Setup workload on all engines,measure gt awake time via pmu
> * Feature: i915 pmu perf interface, pmu
> @@ -226,10 +223,7 @@
> * SUBTEST: rc6
> * Feature: pmu
> *
> - * SUBTEST: rc6-runtime-pm
> - * Feature: pmu
> - *
> - * SUBTEST: rc6-runtime-pm-long
> + * SUBTEST: rc6-all-gts
> * Feature: pmu
> *
> * SUBTEST: rc6-suspend
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
@ 2023-05-26 12:26 ` Kamil Konieczny
2023-07-04 12:28 ` Tvrtko Ursulin
1 sibling, 0 replies; 13+ messages in thread
From: Kamil Konieczny @ 2023-05-26 12:26 UTC (permalink / raw)
To: igt-dev
On 2023-05-26 at 08:46:24 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Now that i915 is fully documented, check it at build time.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> docs/testplan/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
> index 6cd44be5ccd3..bf73dd32a15f 100644
> --- a/docs/testplan/meson.build
> +++ b/docs/testplan/meson.build
> @@ -30,13 +30,13 @@ xe_test_dict = {
>
> if build_xe
> test_dict = {
> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
> + 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
> 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
> }
> else
> test_dict = {
> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
> + 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
> }
> endif
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Enable documentation check for i915 driver
2023-05-26 6:46 [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver Mauro Carvalho Chehab
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes Mauro Carvalho Chehab
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
@ 2023-05-26 13:04 ` Patchwork
2023-05-27 4:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2023-05-26 13:04 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7369 bytes --]
== Series Details ==
Series: Enable documentation check for i915 driver
URL : https://patchwork.freedesktop.org/series/118411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195 -> IGTPW_9043
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
Participating hosts (38 -> 39)
------------------------------
Additional (2): fi-kbl-soraka bat-mtlp-6
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9043 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@workarounds:
- bat-rpls-2: [PASS][4] -> [DMESG-FAIL][5] ([i915#6763] / [i915#7913])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-2/igt@i915_selftest@live@workarounds.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-rpls-2/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][6] ([i915#6687] / [i915#7978])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +14 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][8] ([i915#1845] / [i915#5354]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][9] ([i915#3546]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-adlp-9/igt@kms_pipe_crc_basic@read-crc.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][11] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-1/igt@i915_selftest@live@reset.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][13] ([i915#7932]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
#### Warnings ####
* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][15] ([i915#7913] / [i915#7982]) -> [ABORT][16] ([i915#4983] / [i915#7913])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-2/igt@i915_selftest@live@requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/bat-rpls-2/igt@i915_selftest@live@requests.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7305 -> IGTPW_9043
CI-20190529: 20190529
CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9043: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
[-- Attachment #2: Type: text/html, Size: 7352 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Enable documentation check for i915 driver
2023-05-26 6:46 [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver Mauro Carvalho Chehab
` (2 preceding siblings ...)
2023-05-26 13:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable documentation check for i915 driver Patchwork
@ 2023-05-27 4:54 ` Patchwork
3 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2023-05-27 4:54 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 15920 bytes --]
== Series Details ==
Series: Enable documentation check for i915 driver
URL : https://patchwork.freedesktop.org/series/118411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13195_full -> IGTPW_9043_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Known issues
------------
Here are the changes found in IGTPW_9043_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [PASS][1] -> [ABORT][2] ([i915#180])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][3] -> [ABORT][4] ([i915#5566])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl6/igt@gen9_exec_parse@allowed-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl3/igt@gen9_exec_parse@allowed-all.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3886])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271]) +82 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-snb5/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4579]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl7/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271]) +9 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl1/igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium.html
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible:
- shard-apl: NOTRUN -> [SKIP][9] ([IGT#6] / [fdo#109271]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl2/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
* igt@kms_hdr@static-toggle:
- shard-apl: NOTRUN -> [SKIP][12] ([IGT#6] / [fdo#109271] / [i915#4579])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl2/igt@kms_hdr@static-toggle.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579]) +20 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-snb6/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][14] ([i915#5465]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-snb7/igt@kms_setmode@basic@pipe-a-vga-1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][15] ([i915#7742]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_busy@close-race:
- shard-snb: [ABORT][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-snb2/igt@gem_busy@close-race.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-snb2/igt@gem_busy@close-race.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][19] ([i915#6268]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-none@vcs0:
- {shard-rkl}: [FAIL][21] ([i915#2842]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-4/igt@gem_exec_fair@basic-none@vcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-rkl-6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][23] ([i915#2842]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk4/igt@gem_exec_fair@basic-pace@vcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-glk9/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][25] ([i915#1397]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [FAIL][27] ([i915#3743]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4:
- {shard-dg1}: [INCOMPLETE][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-dg1-16/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][31] ([IGT#6] / [i915#2346]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][33] ([IGT#6] / [i915#4767]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][35] ([i915#79]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4:
- {shard-dg1}: [FAIL][37] ([i915#8151]) -> [PASS][38] +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-dg1-18/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html
* igt@perf_pmu@busy-idle-check-all@vecs0:
- {shard-dg1}: [FAIL][39] ([i915#4521]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-17/igt@perf_pmu@busy-idle-check-all@vecs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/shard-dg1-14/igt@perf_pmu@busy-idle-check-all@vecs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7305 -> IGTPW_9043
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9043: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9043/index.html
[-- Attachment #2: Type: text/html, Size: 12659 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
2023-05-26 12:26 ` Kamil Konieczny
@ 2023-07-04 12:28 ` Tvrtko Ursulin
2023-07-04 12:41 ` Tvrtko Ursulin
1 sibling, 1 reply; 13+ messages in thread
From: Tvrtko Ursulin @ 2023-07-04 12:28 UTC (permalink / raw)
To: Mauro Carvalho Chehab, igt-dev
On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> Now that i915 is fully documented, check it at build time.
This step seems to be slow as molasses and it also rebuilds the Xe test
plan when I touch an i915 test.
What is the way to disable it all when configuring the build?
Regards,
Tvrtko
P.S. I also find the "now that i915 is fully documented" statement a bit
of a chuckle, since random two tests I happened to open haven't really
been documented - it rather looks to be a bit of a charade.
I wouldn't care really apart from it significantly slowing down the
development workflow.
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> docs/testplan/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
> index 6cd44be5ccd3..bf73dd32a15f 100644
> --- a/docs/testplan/meson.build
> +++ b/docs/testplan/meson.build
> @@ -30,13 +30,13 @@ xe_test_dict = {
>
> if build_xe
> test_dict = {
> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
> + 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
> 'xe_tests': { 'input': xe_test_config, 'extra_args': check_testlist }
> }
> else
> test_dict = {
> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
> + 'i915_tests': { 'input': i915_test_config, 'extra_args': check_testlist },
> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
> }
> endif
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-07-04 12:28 ` Tvrtko Ursulin
@ 2023-07-04 12:41 ` Tvrtko Ursulin
2023-07-04 12:50 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 13+ messages in thread
From: Tvrtko Ursulin @ 2023-07-04 12:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, igt-dev
On 04/07/2023 13:28, Tvrtko Ursulin wrote:
>
> On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
>> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>>
>> Now that i915 is fully documented, check it at build time.
>
> This step seems to be slow as molasses and it also rebuilds the Xe test
> plan when I touch an i915 test.
>
> What is the way to disable it all when configuring the build?
>
> Regards,
>
> Tvrtko
>
> P.S. I also find the "now that i915 is fully documented" statement a bit
> of a chuckle, since random two tests I happened to open haven't really
> been documented - it rather looks to be a bit of a charade.
>
> I wouldn't care really apart from it significantly slowing down the
> development workflow.
# time ninja
[1/448] Generating lib/version.h with a custom command
fatal: not a git repository (or any of the parent directories): .git
[6/6] Generating docs/testplan/i915_tests.rst with a custom command
real 0m24.363s
user 0m6.530s
sys 0m20.968s
24 seconds.. I just changed one i915 test. :(
Regards,
Tvrtko
>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>> ---
>> docs/testplan/meson.build | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/testplan/meson.build b/docs/testplan/meson.build
>> index 6cd44be5ccd3..bf73dd32a15f 100644
>> --- a/docs/testplan/meson.build
>> +++ b/docs/testplan/meson.build
>> @@ -30,13 +30,13 @@ xe_test_dict = {
>> if build_xe
>> test_dict = {
>> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
>> + 'i915_tests': { 'input': i915_test_config, 'extra_args':
>> check_testlist },
>> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] },
>> 'xe_tests': { 'input': xe_test_config, 'extra_args':
>> check_testlist }
>> }
>> else
>> test_dict = {
>> - 'i915_tests': { 'input': i915_test_config, 'extra_args': [] },
>> + 'i915_tests': { 'input': i915_test_config, 'extra_args':
>> check_testlist },
>> 'kms_tests': { 'input': kms_test_config, 'extra_args': [] }
>> }
>> endif
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-07-04 12:41 ` Tvrtko Ursulin
@ 2023-07-04 12:50 ` Mauro Carvalho Chehab
2023-07-04 13:03 ` Tvrtko Ursulin
0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-07-04 12:50 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
On Tue, 4 Jul 2023 13:41:14 +0100
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 04/07/2023 13:28, Tvrtko Ursulin wrote:
> >
> > On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
> >> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> >>
> >> Now that i915 is fully documented, check it at build time.
> >
> > This step seems to be slow as molasses and it also rebuilds the Xe test
> > plan when I touch an i915 test.
This is fixable, but better to wait for Bhanu's patch series that will
be moving the Intel tests to a new directory (tests/intel/).
> >
> > What is the way to disable it all when configuring the build?
Yes, you can disable it:
$ meson -Dtestplan=disabled build --reconfigure
We do want this enabled by default, as CI needs to check it and
reject patches that aren't updating tests documentation.
Our internal CI is already dependent on it for the Xe and KMS, and
the plan is to extend it to i915 as well, to get rid of lots of
hacks that currently maps tests with the tested features.
> >
> > P.S. I also find the "now that i915 is fully documented" statement a bit
> > of a chuckle, since random two tests I happened to open haven't really
> > been documented - it rather looks to be a bit of a charade.
Well, it is as good as what we had documented on IGT itself and on
some separate spreadsheets. If you find anything odd, please fix it.
> >
> > I wouldn't care really apart from it significantly slowing down the
> > development workflow.
>
> # time ninja
> [1/448] Generating lib/version.h with a custom command
> fatal: not a git repository (or any of the parent directories): .git
> [6/6] Generating docs/testplan/i915_tests.rst with a custom command
>
> real 0m24.363s
> user 0m6.530s
> sys 0m20.968s
>
> 24 seconds.. I just changed one i915 test. :(
What it takes time is not building the docs, but to run all tests with
"--list" parameter, in order to double-check if every test has some
documentation.
Regards,
Mauro
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-07-04 12:50 ` Mauro Carvalho Chehab
@ 2023-07-04 13:03 ` Tvrtko Ursulin
2023-07-05 8:56 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 13+ messages in thread
From: Tvrtko Ursulin @ 2023-07-04 13:03 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: igt-dev
On 04/07/2023 13:50, Mauro Carvalho Chehab wrote:
> On Tue, 4 Jul 2023 13:41:14 +0100
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>
>> On 04/07/2023 13:28, Tvrtko Ursulin wrote:
>>>
>>> On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
>>>> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>>>>
>>>> Now that i915 is fully documented, check it at build time.
>>>
>>> This step seems to be slow as molasses and it also rebuilds the Xe test
>>> plan when I touch an i915 test.
>
> This is fixable, but better to wait for Bhanu's patch series that will
> be moving the Intel tests to a new directory (tests/intel/).
>
>>>
>>> What is the way to disable it all when configuring the build?
>
> Yes, you can disable it:
>
> $ meson -Dtestplan=disabled build --reconfigure
Works, thanks!
> We do want this enabled by default, as CI needs to check it and
> reject patches that aren't updating tests documentation.
>
> Our internal CI is already dependent on it for the Xe and KMS, and
> the plan is to extend it to i915 as well, to get rid of lots of
> hacks that currently maps tests with the tested features.
As long as the build process is not smart enough to only check a single
modified test, FWIW disabled by default sounds better to me and CI can
easily enable it.
>>> P.S. I also find the "now that i915 is fully documented" statement a bit
>>> of a chuckle, since random two tests I happened to open haven't really
>>> been documented - it rather looks to be a bit of a charade.
>
> Well, it is as good as what we had documented on IGT itself and on
> some separate spreadsheets. If you find anything odd, please fix it.
I happened to open i915_pm_rps yesterday and drm_fdinfo today. Majority
of documentation are just place holders to cheat the verification step.
Similarly I don't think it will be "enforceable" during code review and
such silliness will just land. Shrug. sometimes even best intentions
don't lead where you'd expect them to.
>>> I wouldn't care really apart from it significantly slowing down the
>>> development workflow.
>>
>> # time ninja
>> [1/448] Generating lib/version.h with a custom command
>> fatal: not a git repository (or any of the parent directories): .git
>> [6/6] Generating docs/testplan/i915_tests.rst with a custom command
>>
>> real 0m24.363s
>> user 0m6.530s
>> sys 0m20.968s
>>
>> 24 seconds.. I just changed one i915 test. :(
>
> What it takes time is not building the docs, but to run all tests with
> "--list" parameter, in order to double-check if every test has some
> documentation.
I don't really care what takes time, just that it was unbearable. But
now you gave me a workaround so that's good enough for me.
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-07-04 13:03 ` Tvrtko Ursulin
@ 2023-07-05 8:56 ` Mauro Carvalho Chehab
2023-07-05 15:33 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-07-05 8:56 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
On Tue, 4 Jul 2023 14:03:59 +0100
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 04/07/2023 13:50, Mauro Carvalho Chehab wrote:
> > On Tue, 4 Jul 2023 13:41:14 +0100
> > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> >
> >> On 04/07/2023 13:28, Tvrtko Ursulin wrote:
> >>>
> >>> On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
> >>>> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> >>>>
> >>>> Now that i915 is fully documented, check it at build time.
> >>>
> >>> This step seems to be slow as molasses and it also rebuilds the Xe test
> >>> plan when I touch an i915 test.
> >
> > This is fixable, but better to wait for Bhanu's patch series that will
> > be moving the Intel tests to a new directory (tests/intel/).
> >
> >>>
> >>> What is the way to disable it all when configuring the build?
> >
> > Yes, you can disable it:
> >
> > $ meson -Dtestplan=disabled build --reconfigure
>
> Works, thanks!
>
> > We do want this enabled by default, as CI needs to check it and
> > reject patches that aren't updating tests documentation.
> >
> > Our internal CI is already dependent on it for the Xe and KMS, and
> > the plan is to extend it to i915 as well, to get rid of lots of
> > hacks that currently maps tests with the tested features.
>
> As long as the build process is not smart enough to only check a single
> modified test, FWIW disabled by default sounds better to me and CI can
> easily enable it.
See, parsing the source code to produce documentation is really fast:
$ for i in tests/xe/xe_test_config.json tests/kms_test_config.json tests/i915/i915_test_config.json; do echo $i:; time ./scripts/igt_doc.py --config $i >/dev/null; echo; done
tests/xe/xe_test_config.json:
real 0m0.113s
user 0m0.090s
sys 0m0.022s
tests/kms_test_config.json:
real 0m0.132s
user 0m0.121s
sys 0m0.010s
tests/i915/i915_test_config.json:
real 0m0.271s
user 0m0.259s
sys 0m0.011s
Handling all documents and even producing a ReST output takes less than
500ms.
What takes time is to get a list of all IGT tests that are covered on
a test set (xe, kms or i915). The way IGT is conceived is that there's no
single exec file or build output that lists all tests. One needs to run all
tests that matches a certain pattern, using --list option, in order to get
a list of tests. This is what `igt_runner -L` does. The code I implemented
is faster than igt_runner, but it doesn't use multithread - as python is
currently problematic with multi-CPU multithread[1].
[1] https://www.turing.com/kb/python-multiprocessing-vs-multithreading
Perhaps one solution would be to change meson.build to produce a list
of tests per compiled file, by running the tests after their builds,
storing the results under the build dir. As meson/ninja is properly
parallelized, this should reduce the time to generate the testlists
that are used by the documentation tool to check if tests are documented.
I'll explore such solution, as we may end speeding up some CI runs
by having a build time generated "full" testlist.
>
> >>> P.S. I also find the "now that i915 is fully documented" statement a bit
> >>> of a chuckle, since random two tests I happened to open haven't really
> >>> been documented - it rather looks to be a bit of a charade.
> >
> > Well, it is as good as what we had documented on IGT itself and on
> > some separate spreadsheets. If you find anything odd, please fix it.
>
> I happened to open i915_pm_rps yesterday and drm_fdinfo today. Majority
> of documentation are just place holders to cheat the verification step.
It was not meant to be that. Those were generated from different data
sources:
- igt_describe(), igt_describe_f(), and IGT_TEST_DESCRIPTION();
- Grafana's feature mapping logic used internally;
- efforts from validation teams to document existing tests.
Now, for sure the efforts to write documentation after the facts are
hard.
> Similarly I don't think it will be "enforceable" during code review and
> such silliness will just land. Shrug. sometimes even best intentions
> don't lead where you'd expect them to.
The main goal of enforcing it is to ensure that developers and reviewers
will be doing it right for new tests and gradually fix issues at the
existing ones.
>
> >>> I wouldn't care really apart from it significantly slowing down the
> >>> development workflow.
> >>
> >> # time ninja
> >> [1/448] Generating lib/version.h with a custom command
> >> fatal: not a git repository (or any of the parent directories): .git
> >> [6/6] Generating docs/testplan/i915_tests.rst with a custom command
> >>
> >> real 0m24.363s
> >> user 0m6.530s
> >> sys 0m20.968s
> >>
> >> 24 seconds.. I just changed one i915 test. :(
> >
> > What it takes time is not building the docs, but to run all tests with
> > "--list" parameter, in order to double-check if every test has some
> > documentation.
>
> I don't really care what takes time, just that it was unbearable. But
> now you gave me a workaround so that's good enough for me.
>
> Regards,
>
> Tvrtko
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation
2023-07-05 8:56 ` Mauro Carvalho Chehab
@ 2023-07-05 15:33 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2023-07-05 15:33 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
On Wed, 5 Jul 2023 10:56:59 +0200
Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:
> On Tue, 4 Jul 2023 14:03:59 +0100
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>
> > On 04/07/2023 13:50, Mauro Carvalho Chehab wrote:
> > > On Tue, 4 Jul 2023 13:41:14 +0100
> > > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> > >
> > >> On 04/07/2023 13:28, Tvrtko Ursulin wrote:
> > >>>
> > >>> On 26/05/2023 07:46, Mauro Carvalho Chehab wrote:
> > >>>> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > >>>>
> > >>>> Now that i915 is fully documented, check it at build time.
> > >>>
> > >>> This step seems to be slow as molasses and it also rebuilds the Xe test
> > >>> plan when I touch an i915 test.
> > >
> > > This is fixable, but better to wait for Bhanu's patch series that will
> > > be moving the Intel tests to a new directory (tests/intel/).
> > >
> > >>>
> > >>> What is the way to disable it all when configuring the build?
> > >
> > > Yes, you can disable it:
> > >
> > > $ meson -Dtestplan=disabled build --reconfigure
> >
> > Works, thanks!
> >
> > > We do want this enabled by default, as CI needs to check it and
> > > reject patches that aren't updating tests documentation.
> > >
> > > Our internal CI is already dependent on it for the Xe and KMS, and
> > > the plan is to extend it to i915 as well, to get rid of lots of
> > > hacks that currently maps tests with the tested features.
> >
> > As long as the build process is not smart enough to only check a single
> > modified test, FWIW disabled by default sounds better to me and CI can
> > easily enable it.
>
> See, parsing the source code to produce documentation is really fast:
>
> $ for i in tests/xe/xe_test_config.json tests/kms_test_config.json tests/i915/i915_test_config.json; do echo $i:; time ./scripts/igt_doc.py --config $i >/dev/null; echo; done
>
> tests/xe/xe_test_config.json:
>
> real 0m0.113s
> user 0m0.090s
> sys 0m0.022s
>
> tests/kms_test_config.json:
>
> real 0m0.132s
> user 0m0.121s
> sys 0m0.010s
>
> tests/i915/i915_test_config.json:
>
> real 0m0.271s
> user 0m0.259s
> sys 0m0.011s
>
> Handling all documents and even producing a ReST output takes less than
> 500ms.
>
> What takes time is to get a list of all IGT tests that are covered on
> a test set (xe, kms or i915). The way IGT is conceived is that there's no
> single exec file or build output that lists all tests. One needs to run all
> tests that matches a certain pattern, using --list option, in order to get
> a list of tests. This is what `igt_runner -L` does. The code I implemented
> is faster than igt_runner, but it doesn't use multithread - as python is
> currently problematic with multi-CPU multithread[1].
>
> [1] https://www.turing.com/kb/python-multiprocessing-vs-multithreading
>
> Perhaps one solution would be to change meson.build to produce a list
> of tests per compiled file, by running the tests after their builds,
> storing the results under the build dir. As meson/ninja is properly
> parallelized, this should reduce the time to generate the testlists
> that are used by the documentation tool to check if tests are documented.
>
> I'll explore such solution, as we may end speeding up some CI runs
> by having a build time generated "full" testlist.
>
> >
> > >>> P.S. I also find the "now that i915 is fully documented" statement a bit
> > >>> of a chuckle, since random two tests I happened to open haven't really
> > >>> been documented - it rather looks to be a bit of a charade.
> > >
> > > Well, it is as good as what we had documented on IGT itself and on
> > > some separate spreadsheets. If you find anything odd, please fix it.
> >
> > I happened to open i915_pm_rps yesterday and drm_fdinfo today. Majority
> > of documentation are just place holders to cheat the verification step.
>
> It was not meant to be that. Those were generated from different data
> sources:
>
> - igt_describe(), igt_describe_f(), and IGT_TEST_DESCRIPTION();
> - Grafana's feature mapping logic used internally;
> - efforts from validation teams to document existing tests.
>
> Now, for sure the efforts to write documentation after the facts are
> hard.
>
> > Similarly I don't think it will be "enforceable" during code review and
> > such silliness will just land. Shrug. sometimes even best intentions
> > don't lead where you'd expect them to.
>
> The main goal of enforcing it is to ensure that developers and reviewers
> will be doing it right for new tests and gradually fix issues at the
> existing ones.
>
> >
> > >>> I wouldn't care really apart from it significantly slowing down the
> > >>> development workflow.
> > >>
> > >> # time ninja
> > >> [1/448] Generating lib/version.h with a custom command
> > >> fatal: not a git repository (or any of the parent directories): .git
> > >> [6/6] Generating docs/testplan/i915_tests.rst with a custom command
> > >>
> > >> real 0m24.363s
> > >> user 0m6.530s
> > >> sys 0m20.968s
> > >>
> > >> 24 seconds.. I just changed one i915 test. :(
This patch series should do the trick:
https://patchwork.freedesktop.org/series/120233/
The time for a single change is now 4 seconds with Sphinx disabled
(which is the default setting).
It can be speedup even further, but we need to wait for this series to
be merged:
https://patchwork.freedesktop.org/series/117227/
as it will conflict with it.
Please review.
> > >
> > > What it takes time is not building the docs, but to run all tests with
> > > "--list" parameter, in order to double-check if every test has some
> > > documentation.
> >
> > I don't really care what takes time, just that it was unbearable. But
> > now you gave me a workaround so that's good enough for me.
> >
> > Regards,
> >
> > Tvrtko
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-07-05 15:33 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 6:46 [igt-dev] [PATCH i-g-t 0/2] Enable documentation check for i915 driver Mauro Carvalho Chehab
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 1/2] i915/perf_pmu: sync documentation with latest changes Mauro Carvalho Chehab
2023-05-26 12:25 ` Kamil Konieczny
2023-05-26 6:46 ` [igt-dev] [PATCH i-g-t 2/2] testplan/meson.build: make it check for missing i915 documentation Mauro Carvalho Chehab
2023-05-26 12:26 ` Kamil Konieczny
2023-07-04 12:28 ` Tvrtko Ursulin
2023-07-04 12:41 ` Tvrtko Ursulin
2023-07-04 12:50 ` Mauro Carvalho Chehab
2023-07-04 13:03 ` Tvrtko Ursulin
2023-07-05 8:56 ` Mauro Carvalho Chehab
2023-07-05 15:33 ` Mauro Carvalho Chehab
2023-05-26 13:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Enable documentation check for i915 driver Patchwork
2023-05-27 4:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.