All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: spi-qcom-qspi: Add newline to PIO fallback warning
@ 2023-05-30 18:13 Douglas Anderson
  2023-05-30 19:21 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2023-05-30 18:13 UTC (permalink / raw)
  To: Mark Brown, Vijaya Krishna Nivarthi
  Cc: Stephen Boyd, Douglas Anderson, Andy Gross, Bjorn Andersson,
	Konrad Dybcio, linux-arm-msm, linux-kernel, linux-spi

A warning added in commit b5762d95607e ("spi: spi-qcom-qspi: Add DMA
mode support") was missing a newline. Add it.

Reported-by: Stephen Boyd <swboyd@chromium.org>
Closes: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4573857/comment/44331d65_79128099/
Fixes: b5762d95607e ("spi: spi-qcom-qspi: Add DMA mode support")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/spi/spi-qcom-qspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
index a3991e617c90..a8a683d6145c 100644
--- a/drivers/spi/spi-qcom-qspi.c
+++ b/drivers/spi/spi-qcom-qspi.c
@@ -445,7 +445,7 @@ static int qcom_qspi_transfer_one(struct spi_master *master,
 				qcom_qspi_dma_xfer(ctrl);
 			goto exit;
 		}
-		dev_warn_once(ctrl->dev, "DMA failure, falling back to PIO");
+		dev_warn_once(ctrl->dev, "DMA failure, falling back to PIO\n");
 		ret = 0; /* We'll retry w/ PIO */
 	}
 
-- 
2.41.0.rc0.172.g3f132b7071-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi: spi-qcom-qspi: Add newline to PIO fallback warning
  2023-05-30 18:13 [PATCH] spi: spi-qcom-qspi: Add newline to PIO fallback warning Douglas Anderson
@ 2023-05-30 19:21 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-05-30 19:21 UTC (permalink / raw)
  To: Vijaya Krishna Nivarthi, Douglas Anderson
  Cc: Stephen Boyd, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	linux-arm-msm, linux-kernel, linux-spi

On Tue, 30 May 2023 11:13:48 -0700, Douglas Anderson wrote:
> A warning added in commit b5762d95607e ("spi: spi-qcom-qspi: Add DMA
> mode support") was missing a newline. Add it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-qcom-qspi: Add newline to PIO fallback warning
      commit: 55c33e5ee6d3dff13125bdd32b7fa98260680a31

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-30 19:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 18:13 [PATCH] spi: spi-qcom-qspi: Add newline to PIO fallback warning Douglas Anderson
2023-05-30 19:21 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.