All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] gem_exec_balancer: move no-GuC requirement to test functions
@ 2023-06-02  9:24 Andrzej Hajda
  2023-06-02 10:10 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_balancer: move no-GuC requirement to test functions (rev2) Patchwork
  2023-06-04  9:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Andrzej Hajda @ 2023-06-02  9:24 UTC (permalink / raw)
  To: igt-dev; +Cc: Nirmoy Das

igt_fixture inside of subtest_group will get executed even for test
outside of it. It does not influence such test execution, but misleading
warnings are printed, for example:
  ./gem_exec_balancer --r nop
  ...test output...
  Subtest nop: SUCCESS (36,896s)
  Test requirement not met in [...]gem_exec_balancer.c:3608:
  Test requirement: !gem_using_guc_submission(i915)

Such message can be printed before or after proper test output and
is confusing especially in case test fails.

v2: improved commit message

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Acked-by : Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_exec_balancer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
index 004ba9a14fe..9190fc2383f 100644
--- a/tests/i915/gem_exec_balancer.c
+++ b/tests/i915/gem_exec_balancer.c
@@ -1525,6 +1525,7 @@ bonded_runner(int i915,
 	 * submission across multiple engines.
 	 */
 	igt_require(gem_scheduler_has_preemption(i915));
+	igt_require(!gem_using_guc_submission(i915));
 
 	cycles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 
@@ -1996,6 +1997,7 @@ static void sliced(int i915)
 
 	igt_require(gem_scheduler_has_preemption(i915));
 	igt_require(gem_scheduler_has_semaphores(i915));
+	igt_require(!gem_using_guc_submission(i915));
 
 	for (int class = 0; class < 32; class++) {
 		struct i915_engine_class_instance *ci;
@@ -3605,7 +3607,6 @@ igt_main
 
 	igt_subtest_group {
 		igt_fixture {
-			igt_require(!gem_using_guc_submission(i915));
 			intel_allocator_multiprocess_start();
 		}
 
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-04  9:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-02  9:24 [igt-dev] [PATCH i-g-t v2] gem_exec_balancer: move no-GuC requirement to test functions Andrzej Hajda
2023-06-02 10:10 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_balancer: move no-GuC requirement to test functions (rev2) Patchwork
2023-06-04  9:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.