[igt-dev] [PATCH i-g-t 0/4] gem_ctx_freq: multi-gt support and disable efficient freq

[igt-dev] [PATCH i-g-t 0/4] gem_ctx_freq: multi-gt support and disable efficient freq

[Ashutosh Dixit]

Ashutosh Dixit (3):
  lib/igt_sysfs: Don't assert in igt_sysfs_dir_id_to_name
  tests/gem_ctx_freq: Disable SLPC efficient freq for the test
  HAX: Add gem_ctx_freq to BAT testlist

Vinay Belgaumkar (1):
  tests/gem_ctx_freq: Add support for multi-gts

 lib/igt_sysfs.c                       |   4 +-
 tests/i915/gem_ctx_freq.c             | 114 ++++++++++++++++++--------
 tests/intel-ci/fast-feedback.testlist |   1 +
 3 files changed, 82 insertions(+), 37 deletions(-)

-- 
2.38.0

[igt-dev] [PATCH i-g-t 1/4] tests/gem_ctx_freq: Add support for multi-gts

[Ashutosh Dixit]

From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Run subtest sysfs-range on available sysfs interfaces.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/i915/gem_ctx_freq.c | 99 ++++++++++++++++++++++++++-------------
 1 file changed, 66 insertions(+), 33 deletions(-)

diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
index 2c30934daa23..b2f6c2af55e1 100644
--- a/tests/i915/gem_ctx_freq.c
+++ b/tests/i915/gem_ctx_freq.c
@@ -24,12 +24,15 @@
 
 #include <errno.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <sched.h>
 #include <stdlib.h>
 #include <stdint.h>
 #include <unistd.h>
 
 #include "i915/gem.h"
+#include "i915/gem_engine_topology.h"
+#include "i915_drm.h"
 #include "igt.h"
 #include "igt_perf.h"
 #include "igt_sysfs.h"
@@ -49,6 +52,7 @@
 #define SAMPLE_PERIOD (USEC_PER_SEC / 10)
 #define PMU_TOLERANCE 100
 
+static int i915 = -1;
 static int sysfs = -1;
 
 static void kick_rps_worker(void)
@@ -90,7 +94,7 @@ static void pmu_assert(double actual, double target)
 		     actual, target, PMU_TOLERANCE);
 }
 
-static void busy_wait_until_idle(int i915, igt_spin_t *spin)
+static void busy_wait_until_idle(igt_spin_t *spin)
 {
 	igt_spin_end(spin);
 	do {
@@ -98,9 +102,9 @@ static void busy_wait_until_idle(int i915, igt_spin_t *spin)
 	} while (gem_bo_busy(i915, spin->handle));
 }
 
-static void __igt_spin_free_idle(int i915, igt_spin_t *spin)
+static void __igt_spin_free_idle(igt_spin_t *spin)
 {
-	busy_wait_until_idle(i915, spin);
+	busy_wait_until_idle(spin);
 
 	igt_spin_free(i915, spin);
 }
@@ -115,23 +119,25 @@ static void triangle_fill(uint32_t *t, unsigned int nstep,
 	}
 }
 
-static void set_sysfs_freq(uint32_t min, uint32_t max)
+static void set_sysfs_freq(int dirfd, uint32_t min, uint32_t max)
 {
-	igt_sysfs_printf(sysfs, "gt_min_freq_mhz", "%u", min);
-	igt_sysfs_printf(sysfs, "gt_max_freq_mhz", "%u", max);
+	igt_sysfs_rps_printf(dirfd, RPS_MIN_FREQ_MHZ, "%u", min);
+	igt_sysfs_rps_printf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max);
 }
 
-static bool get_sysfs_freq(uint32_t *min, uint32_t *max)
+static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
 {
-	return (igt_sysfs_scanf(sysfs, "gt_min_freq_mhz", "%u", min) == 1 &&
-		igt_sysfs_scanf(sysfs, "gt_max_freq_mhz", "%u", max) == 1);
+	return (igt_sysfs_rps_scanf(dirfd, RPS_MIN_FREQ_MHZ, "%u", min) == 1 &&
+		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
 }
 
-static void sysfs_range(int i915)
+static void sysfs_range(int dirfd, int gt)
 {
 #define N_STEPS 10
 	uint32_t frequencies[TRIANGLE_SIZE(N_STEPS)];
-	uint32_t sys_min, sys_max;
+	struct i915_engine_class_instance *ci;
+	uint32_t sys_min, sys_max, ctx;
+	unsigned int count;
 	igt_spin_t *spin;
 	double measured;
 	int pmu;
@@ -144,12 +150,19 @@ static void sysfs_range(int i915)
 	 * constriained sysfs range.
 	 */
 
-	igt_require(get_sysfs_freq(&sys_min, &sys_max));
+	igt_require(get_sysfs_freq(dirfd, &sys_min, &sys_max));
 	igt_info("System min freq: %dMHz; max freq: %dMHz\n", sys_min, sys_max);
 
 	triangle_fill(frequencies, N_STEPS, sys_min, sys_max);
 
-	pmu = perf_i915_open(i915, I915_PMU_REQUESTED_FREQUENCY);
+	ci = gem_list_engines(i915, 1 << gt, ~0U, &count);
+	igt_require(ci);
+	ctx = gem_context_create_for_engine(i915,
+					    ci[0].engine_class,
+					    ci[0].engine_instance);
+	free(ci);
+
+	pmu = perf_i915_open(i915, __I915_PMU_REQUESTED_FREQUENCY(gt));
 	igt_require(pmu >= 0);
 
 	for (int outer = 0; outer <= 2*N_STEPS; outer++) {
@@ -157,17 +170,17 @@ static void sysfs_range(int i915)
 		uint32_t cur, discard;
 
 		gem_quiescent_gpu(i915);
-		spin = igt_spin_new(i915, .ahnd = ahnd);
+		spin = igt_spin_new(i915, .ahnd = ahnd, .ctx_id = ctx);
 		usleep(10000);
 
-		set_sysfs_freq(sys_freq, sys_freq);
-		get_sysfs_freq(&cur, &discard);
+		set_sysfs_freq(dirfd, sys_freq, sys_freq);
+		get_sysfs_freq(dirfd, &cur, &discard);
 
 		measured = measure_frequency(pmu, SAMPLE_PERIOD);
 		igt_debugfs_dump(i915, "i915_rps_boost_info");
 
-		set_sysfs_freq(sys_min, sys_max);
-		__igt_spin_free_idle(i915, spin);
+		set_sysfs_freq(dirfd, sys_min, sys_max);
+		__igt_spin_free_idle(spin);
 
 		igt_info("sysfs: Measured %.1fMHz, expected %dMhz\n",
 			 measured, cur);
@@ -175,42 +188,57 @@ static void sysfs_range(int i915)
 	}
 	gem_quiescent_gpu(i915);
 
+	gem_context_destroy(i915, ctx);
 	close(pmu);
 	put_ahnd(ahnd);
 
 #undef N_STEPS
 }
 
-static void restore_sysfs_freq(int sig)
+static void __restore_sysfs_freq(int dirfd)
 {
 	char buf[256];
 
 	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
-		igt_sysfs_set(sysfs, "gt_min_freq_mhz", buf);
+		igt_sysfs_rps_set(dirfd, RPS_MIN_FREQ_MHZ, buf);
 
-	if (igt_sysfs_read(sysfs, "gt_RP0_freq_mhz", buf, sizeof(buf)) > 0) {
-		igt_sysfs_set(sysfs, "gt_max_freq_mhz", buf);
-		igt_sysfs_set(sysfs, "gt_boost_freq_mhz", buf);
+	if (igt_sysfs_rps_read(dirfd, RPS_RP0_FREQ_MHZ, buf, sizeof(buf)) > 0) {
+		igt_sysfs_rps_set(dirfd, RPS_MAX_FREQ_MHZ, buf);
+		igt_sysfs_rps_set(dirfd, RPS_BOOST_FREQ_MHZ, buf);
 	}
 }
 
-static void disable_boost(void)
+static void restore_sysfs_freq(int sig)
+{
+	int dirfd, gt;
+
+	for_each_sysfs_gt_dirfd(i915, dirfd, gt)
+		__restore_sysfs_freq(dirfd);
+}
+
+static void __disable_boost(int dirfd)
 {
 	char buf[256];
 
-	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0) {
-		igt_sysfs_set(sysfs, "gt_min_freq_mhz", buf);
-		igt_sysfs_set(sysfs, "gt_boost_freq_mhz", buf);
+	if (igt_sysfs_rps_read(dirfd, RPS_RPn_FREQ_MHZ, buf, sizeof(buf)) > 0) {
+		igt_sysfs_rps_set(dirfd, RPS_MIN_FREQ_MHZ, buf);
+		igt_sysfs_rps_set(dirfd, RPS_BOOST_FREQ_MHZ, buf);
 	}
 
-	if (igt_sysfs_read(sysfs, "gt_RP0_freq_mhz", buf, sizeof(buf)) > 0)
-		igt_sysfs_set(sysfs, "gt_max_freq_mhz", buf);
+	if (igt_sysfs_rps_read(dirfd, RPS_RP0_FREQ_MHZ, buf, sizeof(buf)) > 0)
+		igt_sysfs_rps_set(dirfd, RPS_MAX_FREQ_MHZ, buf);
 }
 
-igt_main
+static void disable_boost(void)
 {
-	int i915 = -1;
+	int dirfd, gt;
+
+	for_each_sysfs_gt_dirfd(i915, dirfd, gt)
+		__disable_boost(dirfd);
+}
 
+igt_main
+{
 	igt_fixture {
 		i915 = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(i915);
@@ -222,6 +250,11 @@ igt_main
 		disable_boost();
 	}
 
-	igt_subtest_f("sysfs")
-		sysfs_range(i915);
+	igt_subtest_with_dynamic_f("sysfs") {
+		int dirfd, gt;
+
+		for_each_sysfs_gt_dirfd(i915, dirfd, gt)
+			igt_dynamic_f("gt%u", gt)
+				sysfs_range(dirfd, gt);
+	}
 }
-- 
2.38.0

[igt-dev] [PATCH i-g-t 2/4] lib/igt_sysfs: Don't assert in igt_sysfs_dir_id_to_name

[Ashutosh Dixit]

Old platforms (BLB/ELK) don't have any freq attributes even in legacy
per-device sysfs. Asserting for this platforms shows up as a CI
regression. So don't assert, just return the device level attribute and let
file open on the non-existent attribute fail to preserve previous behavior.

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 lib/igt_sysfs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
index 8021ba9cbb2e..35a4faa9aab5 100644
--- a/lib/igt_sysfs.c
+++ b/lib/igt_sysfs.c
@@ -115,10 +115,8 @@ const char *igt_sysfs_dir_id_to_name(int dir, enum i915_attr_id id)
 
 	if (igt_sysfs_has_attr(dir, i915_attr_name[RPS][id]))
 		return i915_attr_name[RPS][id];
-	if (igt_sysfs_has_attr(dir, i915_attr_name[GT][id]))
-		return i915_attr_name[GT][id];
 
-	igt_assert_f(0, "attr_id not found %d\n", id);
+	return i915_attr_name[GT][id];
 }
 
 /**
-- 
2.38.0

[igt-dev] [PATCH i-g-t 3/4] tests/gem_ctx_freq: Disable SLPC efficient freq for the test

[Ashutosh Dixit]

When SLPC efficient freq is enabled, GPU frequencies can be outside the
min/max range set from sysfs. Any test which compares actual GPU frequency
against set frequencies is therefore meaninful only when SLPC efficient
freq is disabled.

Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/gem_ctx_freq.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
index b2f6c2af55e1..6dfcf4187d4b 100644
--- a/tests/i915/gem_ctx_freq.c
+++ b/tests/i915/gem_ctx_freq.c
@@ -131,6 +131,15 @@ static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
 		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
 }
 
+static void slpc_ignore_efficient_freq(int dirfd, bool val)
+{
+	if (!(gem_using_guc_submission(i915) && i915_is_slpc_enabled(i915)))
+		return;
+
+	igt_require(igt_sysfs_has_attr(dirfd, "slpc_ignore_eff_freq"));
+	igt_assert(igt_sysfs_set_u32(dirfd, "slpc_ignore_eff_freq", val));
+}
+
 static void sysfs_range(int dirfd, int gt)
 {
 #define N_STEPS 10
@@ -147,9 +156,11 @@ static void sysfs_range(int dirfd, int gt)
 	 * The sysfs interface sets the global limits and overrides the
 	 * user's request. So we can to check that if the user requests
 	 * a range outside of the sysfs, the requests are only run at the
-	 * constriained sysfs range.
+	 * constrained sysfs range. With GuC SLPC this requires disabling
+	 * efficient freq.
 	 */
 
+	slpc_ignore_efficient_freq(dirfd, true);
 	igt_require(get_sysfs_freq(dirfd, &sys_min, &sys_max));
 	igt_info("System min freq: %dMHz; max freq: %dMHz\n", sys_min, sys_max);
 
@@ -199,6 +210,8 @@ static void __restore_sysfs_freq(int dirfd)
 {
 	char buf[256];
 
+	slpc_ignore_efficient_freq(dirfd, false);
+
 	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
 		igt_sysfs_rps_set(dirfd, RPS_MIN_FREQ_MHZ, buf);
 
-- 
2.38.0

[igt-dev] [PATCH i-g-t 4/4] HAX: Add gem_ctx_freq to BAT testlist

[Ashutosh Dixit]

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 31639c892987..0ef62e0f60b6 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -19,6 +19,7 @@ igt@gem_close_race@basic-threads
 igt@gem_ctx_create@basic
 igt@gem_ctx_create@basic-files
 igt@gem_ctx_exec@basic
+igt@gem_ctx_freq@sysfs
 igt@gem_exec_basic@basic
 igt@gem_exec_create@basic
 igt@gem_exec_fence@basic-busy
-- 
2.38.0

Re: [igt-dev] [PATCH i-g-t 2/4] lib/igt_sysfs: Don't assert in igt_sysfs_dir_id_to_name

[Dixit, Ashutosh]

On Mon, 05 Jun 2023 18:21:48 -0700, Ashutosh Dixit wrote:
>
> Old platforms (BLB/ELK) don't have any freq attributes even in legacy
> per-device sysfs. Asserting for this platforms shows up as a CI
> regression.

This can be seen in CI results here:

https://patchwork.freedesktop.org/series/118809/#rev6
https://intel-gfx-ci.01.org/tree/drm-tip/TrybotIGT_769/fi-blb-e6850/igt@gem_ctx_freq@sysfs.html
https://intel-gfx-ci.01.org/tree/drm-tip/TrybotIGT_769/fi-elk-e7500/igt@gem_ctx_freq@sysfs.html

> So don't assert, just return the device level attribute and let file open
> on the non-existent attribute fail to preserve previous behavior.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  lib/igt_sysfs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
> index 8021ba9cbb2e..35a4faa9aab5 100644
> --- a/lib/igt_sysfs.c
> +++ b/lib/igt_sysfs.c
> @@ -115,10 +115,8 @@ const char *igt_sysfs_dir_id_to_name(int dir, enum i915_attr_id id)
>
>	if (igt_sysfs_has_attr(dir, i915_attr_name[RPS][id]))
>		return i915_attr_name[RPS][id];
> -	if (igt_sysfs_has_attr(dir, i915_attr_name[GT][id]))
> -		return i915_attr_name[GT][id];
>
> -	igt_assert_f(0, "attr_id not found %d\n", id);
> +	return i915_attr_name[GT][id];
>  }
>
>  /**
> --
> 2.38.0
>

[igt-dev] ✓ Fi.CI.BAT: success for gem_ctx_freq: multi-gt support and disable efficient freq

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7123 bytes --]

== Series Details ==

Series: gem_ctx_freq: multi-gt support and disable efficient freq
URL   : https://patchwork.freedesktop.org/series/118893/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13234 -> IGTPW_9110
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html

Participating hosts (38 -> 36)
------------------------------

  Missing    (2): fi-kbl-soraka fi-snb-2520m 

New tests
---------

  New tests have been introduced between CI_DRM_13234 and IGTPW_9110:

### New IGT tests (2) ###

  * igt@gem_ctx_freq@sysfs@gt0:
    - Statuses : 34 pass(s) 2 skip(s)
    - Exec time: [0.0] s

  * igt@gem_ctx_freq@sysfs@gt1:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_9110 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * {igt@gem_ctx_freq@sysfs@gt0} (NEW):
    - fi-blb-e6850:       NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4579])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/fi-blb-e6850/igt@gem_ctx_freq@sysfs@gt0.html
    - fi-elk-e7500:       NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4579])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/fi-elk-e7500/igt@gem_ctx_freq@sysfs@gt0.html

  * igt@i915_selftest@live@guc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][3] ([i915#7852])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-rpls-2/igt@i915_selftest@live@guc.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-1:         [PASS][4] -> [ABORT][5] ([i915#7911] / [i915#7920] / [i915#7982])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-rpls-1/igt@i915_selftest@live@requests.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-rpls-1/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][6] ([i915#6367])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@i915_selftest@live@workarounds:
    - bat-adlp-9:         [PASS][7] -> [INCOMPLETE][8] ([i915#7677] / [i915#7913])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-adlp-9/igt@i915_selftest@live@workarounds.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-adlp-9/igt@i915_selftest@live@workarounds.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         NOTRUN -> [ABORT][9] ([i915#6687])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
    - bat-dg2-8:          [PASS][10] -> [FAIL][11] ([i915#7932])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][12] ([i915#1845] / [i915#5354])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - {bat-mtlp-8}:       [ABORT][13] ([i915#7953]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-2:         [ABORT][15] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-rpls-2/igt@i915_selftest@live@reset.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-rpls-2/igt@i915_selftest@live@reset.html

  * {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:
    - {bat-adlp-11}:      [ABORT][17] ([i915#4423]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/bat-adlp-11/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
  [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7319 -> IGTPW_9110

  CI-20190529: 20190529
  CI_DRM_13234: cb7bb5b791053c0ff10e314d24e6752795283803 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9110: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html
  IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html

[-- Attachment #2: Type: text/html, Size: 7584 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for gem_ctx_freq: multi-gt support and disable efficient freq

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 15144 bytes --]

== Series Details ==

Series: gem_ctx_freq: multi-gt support and disable efficient freq
URL   : https://patchwork.freedesktop.org/series/118893/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13234_full -> IGTPW_9110_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html

Participating hosts (7 -> 7)
------------------------------

  No changes in participating hosts

New tests
---------

  New tests have been introduced between CI_DRM_13234_full and IGTPW_9110_full:

### New IGT tests (1) ###

  * igt@gem_ctx_freq@sysfs@gt0:
    - Statuses : 6 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_9110_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-glk:          [PASS][3] -> [ABORT][4] ([i915#5566])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-glk9/igt@gen9_exec_parse@allowed-single.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-glk5/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_dc@dc9-dpms:
    - shard-apl:          [PASS][5] -> [SKIP][6] ([fdo#109271])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl4/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-apl:          [PASS][7] -> [DMESG-FAIL][8] ([i915#5334])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl4/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-2:
    - shard-glk:          [PASS][9] -> [FAIL][10] ([i915#2521])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-glk6/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-2.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-2.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [PASS][11] -> [FAIL][12] ([i915#2346])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
    - shard-snb:          [PASS][13] -> [SKIP][14] ([fdo#109271])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-snb1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-snb1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu.html

  * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579]) +6 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-snb1/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-b-hdmi-a-1.html

  * igt@kms_tv_load_detect@load-detect:
    - shard-snb:          NOTRUN -> [SKIP][16] ([fdo#109271]) +42 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-snb5/igt@kms_tv_load_detect@load-detect.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-apl:          [FAIL][17] ([i915#2842]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - {shard-rkl}:        [FAIL][19] ([i915#2842]) -> [PASS][20] +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-rkl-4/igt@gem_exec_fair@basic-pace@vecs0.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-rkl-2/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - {shard-tglu}:       [FAIL][21] ([i915#2842]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-tglu-9/igt@gem_exec_fair@basic-throttle@rcs0.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-tglu-4/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@i915_pm_rpm@dpms-lpsp:
    - {shard-rkl}:        [SKIP][23] ([i915#1397]) -> [PASS][24] +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - {shard-dg1}:        [SKIP][25] ([i915#1397]) -> [PASS][26] +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-dg1-12/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [DMESG-FAIL][27] ([i915#8319]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-snb4/igt@i915_pm_rps@reset.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-snb4/igt@i915_pm_rps@reset.html

  * igt@kms_cursor_legacy@forked-bo@pipe-b:
    - {shard-dg1}:        [INCOMPLETE][29] ([i915#8011] / [i915#8347]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-dg1-19/igt@kms_cursor_legacy@forked-bo@pipe-b.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-dg1-16/igt@kms_cursor_legacy@forked-bo@pipe-b.html

  * igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled:
    - shard-glk:          [DMESG-WARN][31] ([i915#7936]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-glk7/igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-glk9/igt@kms_draw_crc@draw-method-blt@xrgb2101010-ytiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [FAIL][33] ([i915#4767]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
    - shard-glk:          [FAIL][35] ([i915#2122]) -> [PASS][36] +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html

  * igt@kms_sysfs_edid_timing:
    - {shard-dg1}:        [FAIL][37] ([IGT#2] / [i915#6493]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13234/shard-dg1-16/igt@kms_sysfs_edid_timing.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/shard-dg1-16/igt@kms_sysfs_edid_timing.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
  [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
  [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
  [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7936]: https://gitlab.freedesktop.org/drm/intel/issues/7936
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8178]: https://gitlab.freedesktop.org/drm/intel/issues/8178
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8229]: https://gitlab.freedesktop.org/drm/intel/issues/8229
  [i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7319 -> IGTPW_9110
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13234: cb7bb5b791053c0ff10e314d24e6752795283803 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9110: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html
  IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9110/index.html

[-- Attachment #2: Type: text/html, Size: 11387 bytes --]

Re: [igt-dev] [PATCH i-g-t 2/4] lib/igt_sysfs: Don't assert in igt_sysfs_dir_id_to_name

[Umesh Nerlige Ramappa]

On Mon, Jun 05, 2023 at 06:21:48PM -0700, Ashutosh Dixit wrote:
>Old platforms (BLB/ELK) don't have any freq attributes even in legacy
>per-device sysfs. Asserting for this platforms shows up as a CI
>regression. So don't assert, just return the device level attribute and let
>file open on the non-existent attribute fail to preserve previous behavior.
>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>---
> lib/igt_sysfs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
>index 8021ba9cbb2e..35a4faa9aab5 100644
>--- a/lib/igt_sysfs.c
>+++ b/lib/igt_sysfs.c
>@@ -115,10 +115,8 @@ const char *igt_sysfs_dir_id_to_name(int dir, enum i915_attr_id id)
>
> 	if (igt_sysfs_has_attr(dir, i915_attr_name[RPS][id]))
> 		return i915_attr_name[RPS][id];
>-	if (igt_sysfs_has_attr(dir, i915_attr_name[GT][id]))
>-		return i915_attr_name[GT][id];
>
>-	igt_assert_f(0, "attr_id not found %d\n", id);
>+	return i915_attr_name[GT][id];

lgtm,

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

> }
>
> /**
>-- 
>2.38.0
>

Re: [igt-dev] [PATCH i-g-t 3/4] tests/gem_ctx_freq: Disable SLPC efficient freq for the test

[Umesh Nerlige Ramappa]

On Mon, Jun 05, 2023 at 06:21:49PM -0700, Ashutosh Dixit wrote:
>When SLPC efficient freq is enabled, GPU frequencies can be outside the
>min/max range set from sysfs. Any test which compares actual GPU frequency
>against set frequencies is therefore meaninful only when SLPC efficient

typo: meaningful

>freq is disabled.
>
>Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>---
> tests/i915/gem_ctx_freq.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
>diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
>index b2f6c2af55e1..6dfcf4187d4b 100644
>--- a/tests/i915/gem_ctx_freq.c
>+++ b/tests/i915/gem_ctx_freq.c
>@@ -131,6 +131,15 @@ static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
> 		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
> }
>
>+static void slpc_ignore_efficient_freq(int dirfd, bool val)
>+{
>+	if (!(gem_using_guc_submission(i915) && i915_is_slpc_enabled(i915)))
>+		return;

I think i915_is_slpc_enabled(i915) should be enough here, since 
intel_guc_debugfs_register() in kmd does not create "guc_slpc_info" if 
guc is not enabled.

Regards,
Umesh

Re: [igt-dev] [PATCH i-g-t 1/4] tests/gem_ctx_freq: Add support for multi-gts

[Dixit, Ashutosh]

On Mon, 05 Jun 2023 18:21:47 -0700, Ashutosh Dixit wrote:
>
> From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>
> Run subtest sysfs-range on available sysfs interfaces.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>  tests/i915/gem_ctx_freq.c | 99 ++++++++++++++++++++++++++-------------
>  1 file changed, 66 insertions(+), 33 deletions(-)
>
> diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> index 2c30934daa23..b2f6c2af55e1 100644
> --- a/tests/i915/gem_ctx_freq.c
> +++ b/tests/i915/gem_ctx_freq.c
> @@ -24,12 +24,15 @@
>
>  #include <errno.h>
>  #include <fcntl.h>
> +#include <limits.h>
>  #include <sched.h>
>  #include <stdlib.h>
>  #include <stdint.h>
>  #include <unistd.h>
>
>  #include "i915/gem.h"
> +#include "i915/gem_engine_topology.h"
> +#include "i915_drm.h"
>  #include "igt.h"
>  #include "igt_perf.h"
>  #include "igt_sysfs.h"
> @@ -49,6 +52,7 @@
>  #define SAMPLE_PERIOD (USEC_PER_SEC / 10)
>  #define PMU_TOLERANCE 100
>
> +static int i915 = -1;
>  static int sysfs = -1;
>
>  static void kick_rps_worker(void)
> @@ -90,7 +94,7 @@ static void pmu_assert(double actual, double target)
>		     actual, target, PMU_TOLERANCE);
>  }
>
> -static void busy_wait_until_idle(int i915, igt_spin_t *spin)
> +static void busy_wait_until_idle(igt_spin_t *spin)
>  {
>	igt_spin_end(spin);
>	do {
> @@ -98,9 +102,9 @@ static void busy_wait_until_idle(int i915, igt_spin_t *spin)
>	} while (gem_bo_busy(i915, spin->handle));
>  }
>
> -static void __igt_spin_free_idle(int i915, igt_spin_t *spin)
> +static void __igt_spin_free_idle(igt_spin_t *spin)
>  {
> -	busy_wait_until_idle(i915, spin);
> +	busy_wait_until_idle(spin);
>
>	igt_spin_free(i915, spin);
>  }
> @@ -115,23 +119,25 @@ static void triangle_fill(uint32_t *t, unsigned int nstep,
>	}
>  }
>
> -static void set_sysfs_freq(uint32_t min, uint32_t max)
> +static void set_sysfs_freq(int dirfd, uint32_t min, uint32_t max)
>  {
> -	igt_sysfs_printf(sysfs, "gt_min_freq_mhz", "%u", min);
> -	igt_sysfs_printf(sysfs, "gt_max_freq_mhz", "%u", max);
> +	igt_sysfs_rps_printf(dirfd, RPS_MIN_FREQ_MHZ, "%u", min);
> +	igt_sysfs_rps_printf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max);
>  }
>
> -static bool get_sysfs_freq(uint32_t *min, uint32_t *max)
> +static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
>  {
> -	return (igt_sysfs_scanf(sysfs, "gt_min_freq_mhz", "%u", min) == 1 &&
> -		igt_sysfs_scanf(sysfs, "gt_max_freq_mhz", "%u", max) == 1);
> +	return (igt_sysfs_rps_scanf(dirfd, RPS_MIN_FREQ_MHZ, "%u", min) == 1 &&
> +		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
>  }
>
> -static void sysfs_range(int i915)
> +static void sysfs_range(int dirfd, int gt)
>  {
>  #define N_STEPS 10
>	uint32_t frequencies[TRIANGLE_SIZE(N_STEPS)];
> -	uint32_t sys_min, sys_max;
> +	struct i915_engine_class_instance *ci;
> +	uint32_t sys_min, sys_max, ctx;
> +	unsigned int count;
>	igt_spin_t *spin;
>	double measured;
>	int pmu;
> @@ -144,12 +150,19 @@ static void sysfs_range(int i915)
>	 * constriained sysfs range.
>	 */
>
> -	igt_require(get_sysfs_freq(&sys_min, &sys_max));
> +	igt_require(get_sysfs_freq(dirfd, &sys_min, &sys_max));
>	igt_info("System min freq: %dMHz; max freq: %dMHz\n", sys_min, sys_max);
>
>	triangle_fill(frequencies, N_STEPS, sys_min, sys_max);
>
> -	pmu = perf_i915_open(i915, I915_PMU_REQUESTED_FREQUENCY);
> +	ci = gem_list_engines(i915, 1 << gt, ~0U, &count);
> +	igt_require(ci);
> +	ctx = gem_context_create_for_engine(i915,
> +					    ci[0].engine_class,
> +					    ci[0].engine_instance);
> +	free(ci);
> +
> +	pmu = perf_i915_open(i915, __I915_PMU_REQUESTED_FREQUENCY(gt));
>	igt_require(pmu >= 0);
>
>	for (int outer = 0; outer <= 2*N_STEPS; outer++) {
> @@ -157,17 +170,17 @@ static void sysfs_range(int i915)
>		uint32_t cur, discard;
>
>		gem_quiescent_gpu(i915);
> -		spin = igt_spin_new(i915, .ahnd = ahnd);
> +		spin = igt_spin_new(i915, .ahnd = ahnd, .ctx_id = ctx);

Maybe we should add an explicit '.engine = 0' here (to make clear the spin
is being scheduled on "ci[0]" above, but that is probably clear
already. Other LGTM so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Re: [igt-dev] [PATCH i-g-t 3/4] tests/gem_ctx_freq: Disable SLPC efficient freq for the test

[Dixit, Ashutosh]

On Wed, 07 Jun 2023 14:35:01 -0700, Umesh Nerlige Ramappa wrote:
>
> On Mon, Jun 05, 2023 at 06:21:49PM -0700, Ashutosh Dixit wrote:
> > When SLPC efficient freq is enabled, GPU frequencies can be outside the
> > min/max range set from sysfs. Any test which compares actual GPU frequency
> > against set frequencies is therefore meaninful only when SLPC efficient
>
> typo: meaningful
>
> > freq is disabled.
> >
> > Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> > tests/i915/gem_ctx_freq.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> > index b2f6c2af55e1..6dfcf4187d4b 100644
> > --- a/tests/i915/gem_ctx_freq.c
> > +++ b/tests/i915/gem_ctx_freq.c
> > @@ -131,6 +131,15 @@ static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
> >		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
> > }
> >
> > +static void slpc_ignore_efficient_freq(int dirfd, bool val)
> > +{
> > +	if (!(gem_using_guc_submission(i915) && i915_is_slpc_enabled(i915)))
> > +		return;
>
> I think i915_is_slpc_enabled(i915) should be enough here, since
> intel_guc_debugfs_register() in kmd does not create "guc_slpc_info" if guc
> is not enabled.

OK, I can fix this up before merging, let's see what Vinay says. I stole
this check from i915_pm_freq_api.c so it should probably change there too?

Thanks.
--
Ashutosh

Re: [igt-dev] [PATCH i-g-t 3/4] tests/gem_ctx_freq: Disable SLPC efficient freq for the test

[Belgaumkar, Vinay]

On 6/5/2023 6:21 PM, Ashutosh Dixit wrote:
> When SLPC efficient freq is enabled, GPU frequencies can be outside the
> min/max range set from sysfs. Any test which compares actual GPU frequency
> against set frequencies is therefore meaninful only when SLPC efficient
> freq is disabled.
>
> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>   tests/i915/gem_ctx_freq.c | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> index b2f6c2af55e1..6dfcf4187d4b 100644
> --- a/tests/i915/gem_ctx_freq.c
> +++ b/tests/i915/gem_ctx_freq.c
> @@ -131,6 +131,15 @@ static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
>   		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
>   }
>   
> +static void slpc_ignore_efficient_freq(int dirfd, bool val)
> +{
> +	if (!(gem_using_guc_submission(i915) && i915_is_slpc_enabled(i915)))
> +		return;
There was a reason why I had both, not remembering now.
> +
> +	igt_require(igt_sysfs_has_attr(dirfd, "slpc_ignore_eff_freq"));
> +	igt_assert(igt_sysfs_set_u32(dirfd, "slpc_ignore_eff_freq", val));
> +}

Can we add this as a helper in lib/igt_pm.c? I suspect there might be 
other present/future tests that may need to use this.

Thanks,

Vinay.

> +
>   static void sysfs_range(int dirfd, int gt)
>   {
>   #define N_STEPS 10
> @@ -147,9 +156,11 @@ static void sysfs_range(int dirfd, int gt)
>   	 * The sysfs interface sets the global limits and overrides the
>   	 * user's request. So we can to check that if the user requests
>   	 * a range outside of the sysfs, the requests are only run at the
> -	 * constriained sysfs range.
> +	 * constrained sysfs range. With GuC SLPC this requires disabling
> +	 * efficient freq.
>   	 */
>   
> +	slpc_ignore_efficient_freq(dirfd, true);
>   	igt_require(get_sysfs_freq(dirfd, &sys_min, &sys_max));
>   	igt_info("System min freq: %dMHz; max freq: %dMHz\n", sys_min, sys_max);
>   
> @@ -199,6 +210,8 @@ static void __restore_sysfs_freq(int dirfd)
>   {
>   	char buf[256];
>   
> +	slpc_ignore_efficient_freq(dirfd, false);
> +
>   	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
>   		igt_sysfs_rps_set(dirfd, RPS_MIN_FREQ_MHZ, buf);
>   

Re: [igt-dev] [PATCH i-g-t 3/4] tests/gem_ctx_freq: Disable SLPC efficient freq for the test

[Dixit, Ashutosh]

On Wed, 07 Jun 2023 23:01:57 -0700, Belgaumkar, Vinay wrote:
>
>
> On 6/5/2023 6:21 PM, Ashutosh Dixit wrote:
> > When SLPC efficient freq is enabled, GPU frequencies can be outside the
> > min/max range set from sysfs. Any test which compares actual GPU frequency
> > against set frequencies is therefore meaninful only when SLPC efficient
> > freq is disabled.
> >
> > Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >   tests/i915/gem_ctx_freq.c | 15 ++++++++++++++-
> >   1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_ctx_freq.c b/tests/i915/gem_ctx_freq.c
> > index b2f6c2af55e1..6dfcf4187d4b 100644
> > --- a/tests/i915/gem_ctx_freq.c
> > +++ b/tests/i915/gem_ctx_freq.c
> > @@ -131,6 +131,15 @@ static bool get_sysfs_freq(int dirfd, uint32_t *min, uint32_t *max)
> >		igt_sysfs_rps_scanf(dirfd, RPS_MAX_FREQ_MHZ, "%u", max) == 1);
> >   }
> >   +static void slpc_ignore_efficient_freq(int dirfd, bool val)
> > +{
> > +	if (!(gem_using_guc_submission(i915) && i915_is_slpc_enabled(i915)))
> > +		return;
> There was a reason why I had both, not remembering now.

OK, I have retained this for now as is in v2.

> > +
> > +	igt_require(igt_sysfs_has_attr(dirfd, "slpc_ignore_eff_freq"));
> > +	igt_assert(igt_sysfs_set_u32(dirfd, "slpc_ignore_eff_freq", val));
> > +}
>
> Can we add this as a helper in lib/igt_pm.c? I suspect there might be other
> present/future tests that may need to use this.

Done in v2.

Thanks.
--
Ashutosh


>
> > +
> >   static void sysfs_range(int dirfd, int gt)
> >   {
> >   #define N_STEPS 10
> > @@ -147,9 +156,11 @@ static void sysfs_range(int dirfd, int gt)
> >	 * The sysfs interface sets the global limits and overrides the
> >	 * user's request. So we can to check that if the user requests
> >	 * a range outside of the sysfs, the requests are only run at the
> > -	 * constriained sysfs range.
> > +	 * constrained sysfs range. With GuC SLPC this requires disabling
> > +	 * efficient freq.
> >	 */
> >   +	slpc_ignore_efficient_freq(dirfd, true);
> >	igt_require(get_sysfs_freq(dirfd, &sys_min, &sys_max));
> >	igt_info("System min freq: %dMHz; max freq: %dMHz\n", sys_min, sys_max);
> >   @@ -199,6 +210,8 @@ static void __restore_sysfs_freq(int dirfd)
> >   {
> >	char buf[256];
> >   +	slpc_ignore_efficient_freq(dirfd, false);
> > +
> >	if (igt_sysfs_read(sysfs, "gt_RPn_freq_mhz", buf, sizeof(buf)) > 0)
> >		igt_sysfs_rps_set(dirfd, RPS_MIN_FREQ_MHZ, buf);
> >