[PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register

[PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register

[Kevin Lo]

Use the PLE_MGN_INI_RDY bit rather than WDE_MGN_INI_RDY to check if 
PLE cfg ready runs into a timeout.

Signed-off-by: Kevin Lo <kevlo@kevlo.org>
---
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 512de491a064..4e0cec7c59a2 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -1814,7 +1814,7 @@ static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode,
 	}
 
 	ret = read_poll_timeout(rtw89_read32, ini,
-				(ini & WDE_MGN_INI_RDY) == WDE_MGN_INI_RDY, 1,
+				(ini & PLE_MGN_INI_RDY) == PLE_MGN_INI_RDY, 1,
 				2000, false, rtwdev, R_AX_PLE_INI_STATUS);
 	if (ret) {
 		rtw89_err(rtwdev, "[ERR]PLE cfg ready\n");

RE: [PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register

[Ping-Ke Shih]

> -----Original Message-----
> From: Kevin Lo <kevlo@kevlo.org>
> Sent: Friday, June 9, 2023 3:38 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: [PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register
> 
> Use the PLE_MGN_INI_RDY bit rather than WDE_MGN_INI_RDY to check if
> PLE cfg ready runs into a timeout.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 512de491a064..4e0cec7c59a2 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1814,7 +1814,7 @@ static int dle_init(struct rtw89_dev *rtwdev, enum rtw89_qta_mode mode,
>         }
> 
>         ret = read_poll_timeout(rtw89_read32, ini,
> -                               (ini & WDE_MGN_INI_RDY) == WDE_MGN_INI_RDY, 1,
> +                               (ini & PLE_MGN_INI_RDY) == PLE_MGN_INI_RDY, 1,

Luckily, definitions of WDE_MGN_INI_RDY and PLE_MGN_INI_RDY are the same, so
I don't really need to verify it.

>                                 2000, false, rtwdev, R_AX_PLE_INI_STATUS);
>         if (ret) {
>                 rtw89_err(rtwdev, "[ERR]PLE cfg ready\n");
> 
> 
> ------Please consider the environment before printing this e-mail.

Re: [PATCH] wifi: rtw89: use the correct bit in the R_AX_PLE_INI_STATUS register

[Kalle Valo]

Kevin Lo <kevlo@kevlo.org> wrote:

> Use the PLE_MGN_INI_RDY bit rather than WDE_MGN_INI_RDY to check if 
> PLE cfg ready runs into a timeout.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Why? Does this improve anything or is it just a theoretical fix. The commit log
should give answers to those.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/ZILW8Uct7yUjsVyh@ns.kevlo.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches