* [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Heiko Stuebner, Herbert Xu, Jaehoon Chung,
Jiri Slaby, Joachim Eastwood, John Youn, Jon Hunter,
Jonathan Cameron, Jonathan Corbet, Kalle Valo,
Kishon Vijay Abraham I, Kyungmin Park, Lars-Peter Clausen,
Laxman Dewangan, Lee Jones, Liam Girdwood, Linus Walleij,
Lucas Stach, Marc Dietrich, Marek Vasut, Mark Brown, Mark Yao,
Mathias Nyman, Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c, linux-ide,
linux-iio, linux-input, linux-media, linux-mediatek, linux-mips,
linux-mmc, linux-mtd, linux-pci, linux-pm, linux-pwm,
linux-remoteproc, linux-rockchip, linux-serial, linux-spi,
linux-tegra, linux-usb, linux-watchdog, linux-wireless, netdev,
nouveau
The reset control API has two modes: exclusive access, where the driver
expects to have full and immediate control over the state of the reset
line, and shared (clock-like) access, where drivers only request reset
deassertion while active, but don't care about the state of the reset line
while inactive.
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior.
This series converts all drivers that currently implicitly request
exclusive reset controls to the corresponding explicit API call. It is,
for the most part, generated from the following semantic patch:
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get(dev, id);
+rstc = reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get_optional(dev, id);
+rstc = reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, node, id;
@@
-rstc = of_reset_control_get(node, id);
+rstc = of_reset_control_get_exclusive(node, id);
@@
expression rstc, node, index;
@@
-rstc = of_reset_control_get_by_index(node, index);
+rstc = of_reset_control_get_exclusive_by_index(node, index);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get(dev, id);
+rstc = devm_reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get_optional(dev, id);
+rstc = devm_reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, dev, index;
@@
-rstc = devm_reset_control_get_by_index(dev, index);
+rstc = devm_reset_control_get_exclusive_by_index(dev, index);
After all driver patches are applied, the temporary transition helpers
can be removed.
regards
Philipp
Philipp Zabel (102):
ARM: rockchip: explicitly request exclusive reset control
ARM: socfpga: explicitly request exclusive reset control
MIPS: pci-mt7620: explicitly request exclusive reset control
ahci: st: explicitly request exclusive reset control
ata: sata_gemini: explicitly request exclusive reset control
ata: ahci_tegra: explicitly request exclusive reset control
bus: sunxi-rsb: explicitly request exclusive reset control
bus: tegra-gmi: explicitly request exclusive reset control
clk: sunxi: explicitly request exclusive reset control
clk: tegra: explicitly request exclusive reset control
clocksource/drivers/timer-stm32: explicitly request exclusive reset
control
clocksource/drivers/sun5i: explicitly request exclusive reset control
crypto: rockchip: explicitly request exclusive reset control
crypto: sun4i-ss - request exclusive reset control
PM / devfreq: tegra: explicitly request exclusive reset control
dmaengine: stm32-dma: explicitly request exclusive reset control
dmaengine: sun6i: explicitly request exclusive reset control
dmaengine: tegra-apb: explicitly request exclusive reset control
drm: kirin: explicitly request exclusive reset control
drm/nouveau/tegra: explicitly request exclusive reset control
drm/rockchip: explicitly request exclusive reset control
drm/sti: explicitly request exclusive reset control
drm/stm: explicitly request exclusive reset control
drm/sun4i: explicitly request exclusive reset control
drm/tegra: explicitly request exclusive reset control
gpu: host1x: explicitly request exclusive reset control
i2c: mv64xxx: explicitly request exclusive reset control
i2c: stm32f4: explicitly request exclusive reset control
i2c: sun6i-pw2i: explicitly request exclusive reset control
i2c: tegra: explicitly request exclusive reset control
iio: adc: rockchip_saradc: explicitly request exclusive reset control
iio: dac: stm32-dac-core: explicitly request exclusive reset control
Input: tegra-kbc - request exclusive reset control
coda: explicitly request exclusive reset control
st-rc: explicitly request exclusive reset control
stm32-dcmi: explicitly request exclusive reset control
rc: sunxi-cir: explicitly request exclusive reset control
mmc: dw_mmc: explicitly request exclusive reset control
mmc: sdhci-st: explicitly request exclusive reset control
mmc: sunxi: explicitly request exclusive reset control
mmc: tegra: explicitly request exclusive reset control
mtd: nand: sunxi: explicitly request exclusive reset control
mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
control
net: dsa: mt7530: explicitly request exclusive reset control
net: ethernet: hisi_femac: explicitly request exclusive reset control
net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
control
net: stmmac: explicitly request exclusive reset control
net: stmmac: dwc-qos: explicitly request exclusive reset control
ath10k: explicitly request exclusive reset control
nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
PCI: dwc: pcie-qcom: explicitly request exclusive reset control
PCI: imx6: explicitly request exclusive reset control
PCI: tegra: explicitly request exclusive reset control
PCI: rockchip: explicitly request exclusive reset control
phy: berlin-usb: explicitly request exclusive reset control
PCI: mediatek: explicitly request exclusive reset control
phy: qcom-usb-hs: explicitly request exclusive reset control
phy: rockchip-pcie: explicitly request exclusive reset control
phy: rockchip-typec: explicitly request exclusive reset control
phy: rockchip-usb: explicitly request exclusive reset control
phy: sun4i-usb: explicitly request exclusive reset control
phy: sun9i-usb: explicitly request exclusive reset control
phy: tegra: explicitly request exclusive reset control
phy: qcom-qmp: explicitly request exclusive reset control
phy: qcom-qusb2: explicitly request exclusive reset control
pinctrl: stm32: explicitly request exclusive reset control
pinctrl: sunxi: explicitly request exclusive reset control
pinctrl: tegra: explicitly request exclusive reset control
pwm: hibvt: explicitly request exclusive reset control
pwm: tegra: explicitly request exclusive reset control
remoteproc/keystone: explicitly request exclusive reset control
remoteproc: qcom: explicitly request exclusive reset control
remoteproc: st: explicitly request exclusive reset control
soc: mediatek: PMIC wrap: explicitly request exclusive reset control
soc/tegra: pmc: explicitly request exclusive reset control
spi: stm32: explicitly request exclusive reset control
spi: sun6i: explicitly request exclusive reset control
spi: tegra20-slink: explicitly request exclusive reset control
spi: tegra114: explicitly request exclusive reset control
spi: tegra20-sflash: explicitly request exclusive reset control
staging: nvec: explicitly request exclusive reset control
thermal: rockchip: explicitly request exclusive reset control
thermal: tegra: explicitly request exclusive reset control
serial: 8250_dw: explicitly request exclusive reset control
serial: tegra: explicitly request exclusive reset control
usb: chipidea: msm: explicitly request exclusive reset control
usb: dwc2: explicitly request exclusive reset control
usb: host: ehci-tegra: explicitly request exclusive reset control
usb: host: xhci-tegra: explicitly request exclusive reset control
usb: musb: sunxi: explicitly request exclusive reset control
usb: phy: msm: explicitly request exclusive reset control
usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
watchdog: asm9260: explicitly request exclusive reset control
watchdog: mt7621: explicitly request exclusive reset control
watchdog: rt2880: explicitly request exclusive reset control
watchdog: zx2967: explicitly request exclusive reset control
ASoC: img: explicitly request exclusive reset control
ASoC: stm32: explicitly request exclusive reset control
ASoC: sun4i: explicitly request exclusive reset control
ASoC: tegra: explicitly request exclusive reset control
Documentation: devres: add explicit exclusive/shared reset control
request calls
reset: finish transition to explicit exclusive reset control requests
Documentation/driver-model/devres.txt | 7 ++-
arch/arm/mach-rockchip/platsmp.c | 2 +-
arch/mips/pci/pci-mt7620.c | 2 +-
drivers/ata/ahci_st.c | 6 +--
drivers/ata/ahci_tegra.c | 8 ++--
drivers/ata/sata_gemini.c | 4 +-
drivers/bus/sunxi-rsb.c | 2 +-
drivers/bus/tegra-gmi.c | 2 +-
drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
drivers/clk/tegra/clk-dfll.c | 2 +-
drivers/clocksource/timer-stm32.c | 2 +-
drivers/clocksource/timer-sun5i.c | 2 +-
drivers/crypto/rockchip/rk3288_crypto.c | 2 +-
drivers/crypto/sunxi-ss/sun4i-ss-core.c | 3 +-
drivers/devfreq/tegra-devfreq.c | 2 +-
drivers/dma/stm32-dma.c | 2 +-
drivers/dma/sun6i-dma.c | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/fpga/altera-hps2fpga.c | 3 +-
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++--
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +-
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
drivers/gpu/drm/stm/ltdc.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
drivers/gpu/drm/tegra/dc.c | 2 +-
drivers/gpu/drm/tegra/dpaux.c | 3 +-
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/drm/tegra/gr3d.c | 6 +--
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 2 +-
drivers/gpu/host1x/dev.c | 2 +-
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 2 +-
drivers/iio/adc/rockchip_saradc.c | 3 +-
drivers/iio/dac/stm32-dac-core.c | 2 +-
drivers/input/keyboard/tegra-kbc.c | 2 +-
drivers/media/platform/coda/coda-common.c | 3 +-
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
drivers/media/rc/st_rc.c | 2 +-
drivers/media/rc/sunxi-cir.c | 2 +-
drivers/mmc/host/dw_mmc.c | 2 +-
drivers/mmc/host/sdhci-st.c | 2 +-
drivers/mmc/host/sdhci-tegra.c | 3 +-
drivers/mmc/host/sunxi-mmc.c | 3 +-
drivers/mtd/nand/sunxi_nand.c | 2 +-
drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
drivers/net/dsa/mt7530.c | 3 +-
drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +-
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +--
.../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +-
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
drivers/pci/dwc/pci-imx6.c | 7 +--
drivers/pci/dwc/pcie-qcom.c | 40 +++++++++--------
drivers/pci/host/pci-tegra.c | 6 +--
drivers/pci/host/pcie-mediatek.c | 2 +-
drivers/pci/host/pcie-rockchip.c | 15 ++++---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
drivers/phy/allwinner/phy-sun9i-usb.c | 4 +-
drivers/phy/marvell/phy-berlin-usb.c | 2 +-
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +-
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +-
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 3 +-
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +--
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
drivers/phy/tegra/xusb-tegra210.c | 4 +-
drivers/phy/tegra/xusb.c | 2 +-
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 2 +-
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-tegra.c | 2 +-
drivers/remoteproc/keystone_remoteproc.c | 2 +-
drivers/remoteproc/qcom_q6v5_pil.c | 3 +-
drivers/remoteproc/st_remoteproc.c | 6 ++-
drivers/reset/core.c | 2 +-
drivers/soc/mediatek/mtk-pmic-wrap.c | 5 ++-
drivers/soc/tegra/pmc.c | 2 +-
drivers/spi/spi-stm32.c | 2 +-
drivers/spi/spi-sun6i.c | 2 +-
drivers/spi/spi-tegra114.c | 2 +-
drivers/spi/spi-tegra20-sflash.c | 2 +-
drivers/spi/spi-tegra20-slink.c | 2 +-
drivers/staging/nvec/nvec.c | 2 +-
drivers/thermal/rockchip_thermal.c | 3 +-
drivers/thermal/tegra/soctherm.c | 3 +-
drivers/tty/serial/8250/8250_dw.c | 2 +-
drivers/tty/serial/serial-tegra.c | 2 +-
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
drivers/usb/dwc2/platform.c | 3 +-
drivers/usb/host/ehci-tegra.c | 5 ++-
drivers/usb/host/xhci-tegra.c | 6 ++-
drivers/usb/musb/sunxi.c | 2 +-
drivers/usb/phy/phy-msm-usb.c | 4 +-
drivers/usb/phy/phy-qcom-8x16-usb.c | 2 +-
drivers/watchdog/asm9260_wdt.c | 2 +-
drivers/watchdog/mt7621_wdt.c | 2 +-
drivers/watchdog/rt2880_wdt.c | 2 +-
drivers/watchdog/zx2967_wdt.c | 2 +-
include/linux/reset.h | 50 ----------------------
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
sound/soc/sunxi/sun4i-codec.c | 3 +-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 +-
sound/soc/tegra/tegra30_ahub.c | 4 +-
128 files changed, 226 insertions(+), 235 deletions(-)
--
2.11.0
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Alan Tull <atull@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Bin Liu <b-liu@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Rakesh Iyer <riyer@nvidia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: alsa-devel@alsa-project.org
Cc: ath10k@lists.infradead.org
Cc: devel@driverdev.osuosl.org
Cc: dmaengine@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-mips@linux-mips.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: nouveau@lists.freedesktop.org
^ permalink raw reply [flat|nested] 260+ messages in thread
* [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe
The reset control API has two modes: exclusive access, where the driver
expects to have full and immediate control over the state of the reset
line, and shared (clock-like) access, where drivers only request reset
deassertion while active, but don't care about the state of the reset line
while inactive.
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior.
This series converts all drivers that currently implicitly request
exclusive reset controls to the corresponding explicit API call. It is,
for the most part, generated from the following semantic patch:
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get(dev, id);
+rstc = reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get_optional(dev, id);
+rstc = reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, node, id;
@@
-rstc = of_reset_control_get(node, id);
+rstc = of_reset_control_get_exclusive(node, id);
@@
expression rstc, node, index;
@@
-rstc = of_reset_control_get_by_index(node, index);
+rstc = of_reset_control_get_exclusive_by_index(node, index);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get(dev, id);
+rstc = devm_reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get_optional(dev, id);
+rstc = devm_reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, dev, index;
@@
-rstc = devm_reset_control_get_by_index(dev, index);
+rstc = devm_reset_control_get_exclusive_by_index(dev, index);
After all driver patches are applied, the temporary transition helpers
can be removed.
regards
Philipp
Philipp Zabel (102):
ARM: rockchip: explicitly request exclusive reset control
ARM: socfpga: explicitly request exclusive reset control
MIPS: pci-mt7620: explicitly request exclusive reset control
ahci: st: explicitly request exclusive reset control
ata: sata_gemini: explicitly request exclusive reset control
ata: ahci_tegra: explicitly request exclusive reset control
bus: sunxi-rsb: explicitly request exclusive reset control
bus: tegra-gmi: explicitly request exclusive reset control
clk: sunxi: explicitly request exclusive reset control
clk: tegra: explicitly request exclusive reset control
clocksource/drivers/timer-stm32: explicitly request exclusive reset
control
clocksource/drivers/sun5i: explicitly request exclusive reset control
crypto: rockchip: explicitly request exclusive reset control
crypto: sun4i-ss - request exclusive reset control
PM / devfreq: tegra: explicitly request exclusive reset control
dmaengine: stm32-dma: explicitly request exclusive reset control
dmaengine: sun6i: explicitly request exclusive reset control
dmaengine: tegra-apb: explicitly request exclusive reset control
drm: kirin: explicitly request exclusive reset control
drm/nouveau/tegra: explicitly request exclusive reset control
drm/rockchip: explicitly request exclusive reset control
drm/sti: explicitly request exclusive reset control
drm/stm: explicitly request exclusive reset control
drm/sun4i: explicitly request exclusive reset control
drm/tegra: explicitly request exclusive reset control
gpu: host1x: explicitly request exclusive reset control
i2c: mv64xxx: explicitly request exclusive reset control
i2c: stm32f4: explicitly request exclusive reset control
i2c: sun6i-pw2i: explicitly request exclusive reset control
i2c: tegra: explicitly request exclusive reset control
iio: adc: rockchip_saradc: explicitly request exclusive reset control
iio: dac: stm32-dac-core: explicitly request exclusive reset control
Input: tegra-kbc - request exclusive reset control
coda: explicitly request exclusive reset control
st-rc: explicitly request exclusive reset control
stm32-dcmi: explicitly request exclusive reset control
rc: sunxi-cir: explicitly request exclusive reset control
mmc: dw_mmc: explicitly request exclusive reset control
mmc: sdhci-st: explicitly request exclusive reset control
mmc: sunxi: explicitly request exclusive reset control
mmc: tegra: explicitly request exclusive reset control
mtd: nand: sunxi: explicitly request exclusive reset control
mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
control
net: dsa: mt7530: explicitly request exclusive reset control
net: ethernet: hisi_femac: explicitly request exclusive reset control
net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
control
net: stmmac: explicitly request exclusive reset control
net: stmmac: dwc-qos: explicitly request exclusive reset control
ath10k: explicitly request exclusive reset control
nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
PCI: dwc: pcie-qcom: explicitly request exclusive reset control
PCI: imx6: explicitly request exclusive reset control
PCI: tegra: explicitly request exclusive reset control
PCI: rockchip: explicitly request exclusive reset control
phy: berlin-usb: explicitly request exclusive reset control
PCI: mediatek: explicitly request exclusive reset control
phy: qcom-usb-hs: explicitly request exclusive reset control
phy: rockchip-pcie: explicitly request exclusive reset control
phy: rockchip-typec: explicitly request exclusive reset control
phy: rockchip-usb: explicitly request exclusive reset control
phy: sun4i-usb: explicitly request exclusive reset control
phy: sun9i-usb: explicitly request exclusive reset control
phy: tegra: explicitly request exclusive reset control
phy: qcom-qmp: explicitly request exclusive reset control
phy: qcom-qusb2: explicitly request exclusive reset control
pinctrl: stm32: explicitly request exclusive reset control
pinctrl: sunxi: explicitly request exclusive reset control
pinctrl: tegra: explicitly request exclusive reset control
pwm: hibvt: explicitly request exclusive reset control
pwm: tegra: explicitly request exclusive reset control
remoteproc/keystone: explicitly request exclusive reset control
remoteproc: qcom: explicitly request exclusive reset control
remoteproc: st: explicitly request exclusive reset control
soc: mediatek: PMIC wrap: explicitly request exclusive reset control
soc/tegra: pmc: explicitly request exclusive reset control
spi: stm32: explicitly request exclusive reset control
spi: sun6i: explicitly request exclusive reset control
spi: tegra20-slink: explicitly request exclusive reset control
spi: tegra114: explicitly request exclusive reset control
spi: tegra20-sflash: explicitly request exclusive reset control
staging: nvec: explicitly request exclusive reset control
thermal: rockchip: explicitly request exclusive reset control
thermal: tegra: explicitly request exclusive reset control
serial: 8250_dw: explicitly request exclusive reset control
serial: tegra: explicitly request exclusive reset control
usb: chipidea: msm: explicitly request exclusive reset control
usb: dwc2: explicitly request exclusive reset control
usb: host: ehci-tegra: explicitly request exclusive reset control
usb: host: xhci-tegra: explicitly request exclusive reset control
usb: musb: sunxi: explicitly request exclusive reset control
usb: phy: msm: explicitly request exclusive reset control
usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
watchdog: asm9260: explicitly request exclusive reset control
watchdog: mt7621: explicitly request exclusive reset control
watchdog: rt2880: explicitly request exclusive reset control
watchdog: zx2967: explicitly request exclusive reset control
ASoC: img: explicitly request exclusive reset control
ASoC: stm32: explicitly request exclusive reset control
ASoC: sun4i: explicitly request exclusive reset control
ASoC: tegra: explicitly request exclusive reset control
Documentation: devres: add explicit exclusive/shared reset control
request calls
reset: finish transition to explicit exclusive reset control requests
Documentation/driver-model/devres.txt | 7 ++-
arch/arm/mach-rockchip/platsmp.c | 2 +-
arch/mips/pci/pci-mt7620.c | 2 +-
drivers/ata/ahci_st.c | 6 +--
drivers/ata/ahci_tegra.c | 8 ++--
drivers/ata/sata_gemini.c | 4 +-
drivers/bus/sunxi-rsb.c | 2 +-
drivers/bus/tegra-gmi.c | 2 +-
drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
drivers/clk/tegra/clk-dfll.c | 2 +-
drivers/clocksource/timer-stm32.c | 2 +-
drivers/clocksource/timer-sun5i.c | 2 +-
drivers/crypto/rockchip/rk3288_crypto.c | 2 +-
drivers/crypto/sunxi-ss/sun4i-ss-core.c | 3 +-
drivers/devfreq/tegra-devfreq.c | 2 +-
drivers/dma/stm32-dma.c | 2 +-
drivers/dma/sun6i-dma.c | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/fpga/altera-hps2fpga.c | 3 +-
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++--
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +-
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
drivers/gpu/drm/stm/ltdc.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
drivers/gpu/drm/tegra/dc.c | 2 +-
drivers/gpu/drm/tegra/dpaux.c | 3 +-
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/drm/tegra/gr3d.c | 6 +--
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 2 +-
drivers/gpu/host1x/dev.c | 2 +-
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 2 +-
drivers/iio/adc/rockchip_saradc.c | 3 +-
drivers/iio/dac/stm32-dac-core.c | 2 +-
drivers/input/keyboard/tegra-kbc.c | 2 +-
drivers/media/platform/coda/coda-common.c | 3 +-
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
drivers/media/rc/st_rc.c | 2 +-
drivers/media/rc/sunxi-cir.c | 2 +-
drivers/mmc/host/dw_mmc.c | 2 +-
drivers/mmc/host/sdhci-st.c | 2 +-
drivers/mmc/host/sdhci-tegra.c | 3 +-
drivers/mmc/host/sunxi-mmc.c | 3 +-
drivers/mtd/nand/sunxi_nand.c | 2 +-
drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
drivers/net/dsa/mt7530.c | 3 +-
drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +-
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +--
.../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +-
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
drivers/pci/dwc/pci-imx6.c | 7 +--
drivers/pci/dwc/pcie-qcom.c | 40 +++++++++--------
drivers/pci/host/pci-tegra.c | 6 +--
drivers/pci/host/pcie-mediatek.c | 2 +-
drivers/pci/host/pcie-rockchip.c | 15 ++++---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
drivers/phy/allwinner/phy-sun9i-usb.c | 4 +-
drivers/phy/marvell/phy-berlin-usb.c | 2 +-
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +-
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +-
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 3 +-
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +--
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
drivers/phy/tegra/xusb-tegra210.c | 4 +-
drivers/phy/tegra/xusb.c | 2 +-
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 2 +-
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-tegra.c | 2 +-
drivers/remoteproc/keystone_remoteproc.c | 2 +-
drivers/remoteproc/qcom_q6v5_pil.c | 3 +-
drivers/remoteproc/st_remoteproc.c | 6 ++-
drivers/reset/core.c | 2 +-
drivers/soc/mediatek/mtk-pmic-wrap.c | 5 ++-
drivers/soc/tegra/pmc.c | 2 +-
drivers/spi/spi-stm32.c | 2 +-
drivers/spi/spi-sun6i.c | 2 +-
drivers/spi/spi-tegra114.c | 2 +-
drivers/spi/spi-tegra20-sflash.c | 2 +-
drivers/spi/spi-tegra20-slink.c | 2 +-
drivers/staging/nvec/nvec.c | 2 +-
drivers/thermal/rockchip_thermal.c | 3 +-
drivers/thermal/tegra/soctherm.c | 3 +-
drivers/tty/serial/8250/8250_dw.c | 2 +-
drivers/tty/serial/serial-tegra.c | 2 +-
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
drivers/usb/dwc2/platform.c | 3 +-
drivers/usb/host/ehci-tegra.c | 5 ++-
drivers/usb/host/xhci-tegra.c | 6 ++-
drivers/usb/musb/sunxi.c | 2 +-
drivers/usb/phy/phy-msm-usb.c | 4 +-
drivers/usb/phy/phy-qcom-8x16-usb.c | 2 +-
drivers/watchdog/asm9260_wdt.c | 2 +-
drivers/watchdog/mt7621_wdt.c | 2 +-
drivers/watchdog/rt2880_wdt.c | 2 +-
drivers/watchdog/zx2967_wdt.c | 2 +-
include/linux/reset.h | 50 ----------------------
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
sound/soc/sunxi/sun4i-codec.c | 3 +-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 +-
sound/soc/tegra/tegra30_ahub.c | 4 +-
128 files changed, 226 insertions(+), 235 deletions(-)
--
2.11.0
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Alan Tull <atull@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Bin Liu <b-liu@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Rakesh Iyer <riyer@nvidia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: alsa-devel@alsa-project.org
Cc: ath10k@lists.infradead.org
Cc: devel@driverdev.osuosl.org
Cc: dmaengine@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-mips@linux-mips.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: nouveau@lists.freedesktop.org
^ permalink raw reply [flat|nested] 260+ messages in thread
* [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
linux-i2c, linux-watchdog, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter, linux-rockchip,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, linux-pci, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Philipp Zabel, Rongrong Zou,
linux-fpga, David Woodhouse, Lucas Stach
The reset control API has two modes: exclusive access, where the driver
expects to have full and immediate control over the state of the reset
line, and shared (clock-like) access, where drivers only request reset
deassertion while active, but don't care about the state of the reset line
while inactive.
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior.
This series converts all drivers that currently implicitly request
exclusive reset controls to the corresponding explicit API call. It is,
for the most part, generated from the following semantic patch:
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get(dev, id);
+rstc = reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get_optional(dev, id);
+rstc = reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, node, id;
@@
-rstc = of_reset_control_get(node, id);
+rstc = of_reset_control_get_exclusive(node, id);
@@
expression rstc, node, index;
@@
-rstc = of_reset_control_get_by_index(node, index);
+rstc = of_reset_control_get_exclusive_by_index(node, index);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get(dev, id);
+rstc = devm_reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get_optional(dev, id);
+rstc = devm_reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, dev, index;
@@
-rstc = devm_reset_control_get_by_index(dev, index);
+rstc = devm_reset_control_get_exclusive_by_index(dev, index);
After all driver patches are applied, the temporary transition helpers
can be removed.
regards
Philipp
Philipp Zabel (102):
ARM: rockchip: explicitly request exclusive reset control
ARM: socfpga: explicitly request exclusive reset control
MIPS: pci-mt7620: explicitly request exclusive reset control
ahci: st: explicitly request exclusive reset control
ata: sata_gemini: explicitly request exclusive reset control
ata: ahci_tegra: explicitly request exclusive reset control
bus: sunxi-rsb: explicitly request exclusive reset control
bus: tegra-gmi: explicitly request exclusive reset control
clk: sunxi: explicitly request exclusive reset control
clk: tegra: explicitly request exclusive reset control
clocksource/drivers/timer-stm32: explicitly request exclusive reset
control
clocksource/drivers/sun5i: explicitly request exclusive reset control
crypto: rockchip: explicitly request exclusive reset control
crypto: sun4i-ss - request exclusive reset control
PM / devfreq: tegra: explicitly request exclusive reset control
dmaengine: stm32-dma: explicitly request exclusive reset control
dmaengine: sun6i: explicitly request exclusive reset control
dmaengine: tegra-apb: explicitly request exclusive reset control
drm: kirin: explicitly request exclusive reset control
drm/nouveau/tegra: explicitly request exclusive reset control
drm/rockchip: explicitly request exclusive reset control
drm/sti: explicitly request exclusive reset control
drm/stm: explicitly request exclusive reset control
drm/sun4i: explicitly request exclusive reset control
drm/tegra: explicitly request exclusive reset control
gpu: host1x: explicitly request exclusive reset control
i2c: mv64xxx: explicitly request exclusive reset control
i2c: stm32f4: explicitly request exclusive reset control
i2c: sun6i-pw2i: explicitly request exclusive reset control
i2c: tegra: explicitly request exclusive reset control
iio: adc: rockchip_saradc: explicitly request exclusive reset control
iio: dac: stm32-dac-core: explicitly request exclusive reset control
Input: tegra-kbc - request exclusive reset control
coda: explicitly request exclusive reset control
st-rc: explicitly request exclusive reset control
stm32-dcmi: explicitly request exclusive reset control
rc: sunxi-cir: explicitly request exclusive reset control
mmc: dw_mmc: explicitly request exclusive reset control
mmc: sdhci-st: explicitly request exclusive reset control
mmc: sunxi: explicitly request exclusive reset control
mmc: tegra: explicitly request exclusive reset control
mtd: nand: sunxi: explicitly request exclusive reset control
mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
control
net: dsa: mt7530: explicitly request exclusive reset control
net: ethernet: hisi_femac: explicitly request exclusive reset control
net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
control
net: stmmac: explicitly request exclusive reset control
net: stmmac: dwc-qos: explicitly request exclusive reset control
ath10k: explicitly request exclusive reset control
nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
PCI: dwc: pcie-qcom: explicitly request exclusive reset control
PCI: imx6: explicitly request exclusive reset control
PCI: tegra: explicitly request exclusive reset control
PCI: rockchip: explicitly request exclusive reset control
phy: berlin-usb: explicitly request exclusive reset control
PCI: mediatek: explicitly request exclusive reset control
phy: qcom-usb-hs: explicitly request exclusive reset control
phy: rockchip-pcie: explicitly request exclusive reset control
phy: rockchip-typec: explicitly request exclusive reset control
phy: rockchip-usb: explicitly request exclusive reset control
phy: sun4i-usb: explicitly request exclusive reset control
phy: sun9i-usb: explicitly request exclusive reset control
phy: tegra: explicitly request exclusive reset control
phy: qcom-qmp: explicitly request exclusive reset control
phy: qcom-qusb2: explicitly request exclusive reset control
pinctrl: stm32: explicitly request exclusive reset control
pinctrl: sunxi: explicitly request exclusive reset control
pinctrl: tegra: explicitly request exclusive reset control
pwm: hibvt: explicitly request exclusive reset control
pwm: tegra: explicitly request exclusive reset control
remoteproc/keystone: explicitly request exclusive reset control
remoteproc: qcom: explicitly request exclusive reset control
remoteproc: st: explicitly request exclusive reset control
soc: mediatek: PMIC wrap: explicitly request exclusive reset control
soc/tegra: pmc: explicitly request exclusive reset control
spi: stm32: explicitly request exclusive reset control
spi: sun6i: explicitly request exclusive reset control
spi: tegra20-slink: explicitly request exclusive reset control
spi: tegra114: explicitly request exclusive reset control
spi: tegra20-sflash: explicitly request exclusive reset control
staging: nvec: explicitly request exclusive reset control
thermal: rockchip: explicitly request exclusive reset control
thermal: tegra: explicitly request exclusive reset control
serial: 8250_dw: explicitly request exclusive reset control
serial: tegra: explicitly request exclusive reset control
usb: chipidea: msm: explicitly request exclusive reset control
usb: dwc2: explicitly request exclusive reset control
usb: host: ehci-tegra: explicitly request exclusive reset control
usb: host: xhci-tegra: explicitly request exclusive reset control
usb: musb: sunxi: explicitly request exclusive reset control
usb: phy: msm: explicitly request exclusive reset control
usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
watchdog: asm9260: explicitly request exclusive reset control
watchdog: mt7621: explicitly request exclusive reset control
watchdog: rt2880: explicitly request exclusive reset control
watchdog: zx2967: explicitly request exclusive reset control
ASoC: img: explicitly request exclusive reset control
ASoC: stm32: explicitly request exclusive reset control
ASoC: sun4i: explicitly request exclusive reset control
ASoC: tegra: explicitly request exclusive reset control
Documentation: devres: add explicit exclusive/shared reset control
request calls
reset: finish transition to explicit exclusive reset control requests
Documentation/driver-model/devres.txt | 7 ++-
arch/arm/mach-rockchip/platsmp.c | 2 +-
arch/mips/pci/pci-mt7620.c | 2 +-
drivers/ata/ahci_st.c | 6 +--
drivers/ata/ahci_tegra.c | 8 ++--
drivers/ata/sata_gemini.c | 4 +-
drivers/bus/sunxi-rsb.c | 2 +-
drivers/bus/tegra-gmi.c | 2 +-
drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
drivers/clk/tegra/clk-dfll.c | 2 +-
drivers/clocksource/timer-stm32.c | 2 +-
drivers/clocksource/timer-sun5i.c | 2 +-
drivers/crypto/rockchip/rk3288_crypto.c | 2 +-
drivers/crypto/sunxi-ss/sun4i-ss-core.c | 3 +-
drivers/devfreq/tegra-devfreq.c | 2 +-
drivers/dma/stm32-dma.c | 2 +-
drivers/dma/sun6i-dma.c | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/fpga/altera-hps2fpga.c | 3 +-
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++--
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +-
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
drivers/gpu/drm/stm/ltdc.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
drivers/gpu/drm/tegra/dc.c | 2 +-
drivers/gpu/drm/tegra/dpaux.c | 3 +-
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/drm/tegra/gr3d.c | 6 +--
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 2 +-
drivers/gpu/host1x/dev.c | 2 +-
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 2 +-
drivers/iio/adc/rockchip_saradc.c | 3 +-
drivers/iio/dac/stm32-dac-core.c | 2 +-
drivers/input/keyboard/tegra-kbc.c | 2 +-
drivers/media/platform/coda/coda-common.c | 3 +-
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
drivers/media/rc/st_rc.c | 2 +-
drivers/media/rc/sunxi-cir.c | 2 +-
drivers/mmc/host/dw_mmc.c | 2 +-
drivers/mmc/host/sdhci-st.c | 2 +-
drivers/mmc/host/sdhci-tegra.c | 3 +-
drivers/mmc/host/sunxi-mmc.c | 3 +-
drivers/mtd/nand/sunxi_nand.c | 2 +-
drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
drivers/net/dsa/mt7530.c | 3 +-
drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +-
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +--
.../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +-
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
drivers/pci/dwc/pci-imx6.c | 7 +--
drivers/pci/dwc/pcie-qcom.c | 40 +++++++++--------
drivers/pci/host/pci-tegra.c | 6 +--
drivers/pci/host/pcie-mediatek.c | 2 +-
drivers/pci/host/pcie-rockchip.c | 15 ++++---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
drivers/phy/allwinner/phy-sun9i-usb.c | 4 +-
drivers/phy/marvell/phy-berlin-usb.c | 2 +-
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +-
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +-
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 3 +-
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +--
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
drivers/phy/tegra/xusb-tegra210.c | 4 +-
drivers/phy/tegra/xusb.c | 2 +-
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 2 +-
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-tegra.c | 2 +-
drivers/remoteproc/keystone_remoteproc.c | 2 +-
drivers/remoteproc/qcom_q6v5_pil.c | 3 +-
drivers/remoteproc/st_remoteproc.c | 6 ++-
drivers/reset/core.c | 2 +-
drivers/soc/mediatek/mtk-pmic-wrap.c | 5 ++-
drivers/soc/tegra/pmc.c | 2 +-
drivers/spi/spi-stm32.c | 2 +-
drivers/spi/spi-sun6i.c | 2 +-
drivers/spi/spi-tegra114.c | 2 +-
drivers/spi/spi-tegra20-sflash.c | 2 +-
drivers/spi/spi-tegra20-slink.c | 2 +-
drivers/staging/nvec/nvec.c | 2 +-
drivers/thermal/rockchip_thermal.c | 3 +-
drivers/thermal/tegra/soctherm.c | 3 +-
drivers/tty/serial/8250/8250_dw.c | 2 +-
drivers/tty/serial/serial-tegra.c | 2 +-
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
drivers/usb/dwc2/platform.c | 3 +-
drivers/usb/host/ehci-tegra.c | 5 ++-
drivers/usb/host/xhci-tegra.c | 6 ++-
drivers/usb/musb/sunxi.c | 2 +-
drivers/usb/phy/phy-msm-usb.c | 4 +-
drivers/usb/phy/phy-qcom-8x16-usb.c | 2 +-
drivers/watchdog/asm9260_wdt.c | 2 +-
drivers/watchdog/mt7621_wdt.c | 2 +-
drivers/watchdog/rt2880_wdt.c | 2 +-
drivers/watchdog/zx2967_wdt.c | 2 +-
include/linux/reset.h | 50 ----------------------
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
sound/soc/sunxi/sun4i-codec.c | 3 +-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 +-
sound/soc/tegra/tegra30_ahub.c | 4 +-
128 files changed, 226 insertions(+), 235 deletions(-)
--
2.11.0
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Alan Tull <atull@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Bin Liu <b-liu@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Rakesh Iyer <riyer@nvidia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: alsa-devel@alsa-project.org
Cc: ath10k@lists.infradead.org
Cc: devel@driverdev.osuosl.org
Cc: dmaengine@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-mips@linux-mips.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: nouveau@lists.freedesktop.org
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* [PATCH 001/102] ARM: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
(?)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-20 20:28 ` Heiko Stuebner
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Heiko Stuebner, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
arch/arm/mach-rockchip/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index 3abafdbdd7f4a..420ba67652230 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -67,7 +67,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu)
else
np = of_get_cpu_node(cpu, NULL);
- return of_reset_control_get(np, NULL);
+ return of_reset_control_get_exclusive(np, NULL);
}
static int pmu_set_power_domain(int pd, bool on)
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (2 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-19 16:12 ` Moritz Fischer
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Alan Tull, Moritz Fischer, linux-fpga
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: linux-fpga@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/fpga/altera-hps2fpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
index 3066b805f2d07..a18ff430c9af1 100644
--- a/drivers/fpga/altera-hps2fpga.c
+++ b/drivers/fpga/altera-hps2fpga.c
@@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
of_id = of_match_device(altera_fpga_of_match, dev);
priv = (struct altera_hps2fpga_data *)of_id->data;
- priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
+ priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
+ 0);
if (IS_ERR(priv->bridge_reset)) {
dev_err(dev, "Could not get %s reset control\n", priv->name);
return PTR_ERR(priv->bridge_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 003/102] MIPS: pci-mt7620: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (3 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Ralf Baechle, linux-mips
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
arch/mips/pci/pci-mt7620.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/pci/pci-mt7620.c b/arch/mips/pci/pci-mt7620.c
index 628c5132b3d8b..4e633c1e7ff3e 100644
--- a/arch/mips/pci/pci-mt7620.c
+++ b/arch/mips/pci/pci-mt7620.c
@@ -291,7 +291,7 @@ static int mt7620_pci_probe(struct platform_device *pdev)
IORESOURCE_MEM, 1);
u32 val = 0;
- rstpcie0 = devm_reset_control_get(&pdev->dev, "pcie0");
+ rstpcie0 = devm_reset_control_get_exclusive(&pdev->dev, "pcie0");
if (IS_ERR(rstpcie0))
return PTR_ERR(rstpcie0);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 004/102] ahci: st: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (4 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Patrice Chotard, Tejun Heo, linux-ide
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/ata/ahci_st.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index bc345f2495553..8a26e917dae90 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -108,19 +108,19 @@ static int st_ahci_probe_resets(struct ahci_host_priv *hpriv,
{
struct st_ahci_drv_data *drv_data = hpriv->plat_data;
- drv_data->pwr = devm_reset_control_get(dev, "pwr-dwn");
+ drv_data->pwr = devm_reset_control_get_exclusive(dev, "pwr-dwn");
if (IS_ERR(drv_data->pwr)) {
dev_info(dev, "power reset control not defined\n");
drv_data->pwr = NULL;
}
- drv_data->sw_rst = devm_reset_control_get(dev, "sw-rst");
+ drv_data->sw_rst = devm_reset_control_get_exclusive(dev, "sw-rst");
if (IS_ERR(drv_data->sw_rst)) {
dev_info(dev, "soft reset control not defined\n");
drv_data->sw_rst = NULL;
}
- drv_data->pwr_rst = devm_reset_control_get(dev, "pwr-rst");
+ drv_data->pwr_rst = devm_reset_control_get_exclusive(dev, "pwr-rst");
if (IS_ERR(drv_data->pwr_rst)) {
dev_dbg(dev, "power soft reset control not defined\n");
drv_data->pwr_rst = NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 005/102] ata: sata_gemini: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (5 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-08-02 9:39 ` Linus Walleij
2017-08-02 15:15 ` Tejun Heo
-1 siblings, 2 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Linus Walleij, Tejun Heo, linux-ide
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/ata/sata_gemini.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index 8c704523bae7d..7ae713a33e11a 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -274,14 +274,14 @@ static int gemini_sata_bridge_init(struct sata_gemini *sg)
return ret;
}
- sg->sata0_reset = devm_reset_control_get(dev, "sata0");
+ sg->sata0_reset = devm_reset_control_get_exclusive(dev, "sata0");
if (IS_ERR(sg->sata0_reset)) {
dev_err(dev, "no SATA0 reset controller\n");
clk_disable_unprepare(sg->sata1_pclk);
clk_disable_unprepare(sg->sata0_pclk);
return PTR_ERR(sg->sata0_reset);
}
- sg->sata1_reset = devm_reset_control_get(dev, "sata1");
+ sg->sata1_reset = devm_reset_control_get_exclusive(dev, "sata1");
if (IS_ERR(sg->sata1_reset)) {
dev_err(dev, "no SATA1 reset controller\n");
clk_disable_unprepare(sg->sata1_pclk);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 006/102] ata: ahci_tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (6 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Tejun Heo, Thierry Reding, Jonathan Hunter,
linux-ide, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Tejun Heo <tj@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-ide@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/ata/ahci_tegra.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 3a62eb246d80b..e9daf938738c5 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -319,19 +319,21 @@ static int tegra_ahci_probe(struct platform_device *pdev)
if (IS_ERR(tegra->sata_regs))
return PTR_ERR(tegra->sata_regs);
- tegra->sata_rst = devm_reset_control_get(&pdev->dev, "sata");
+ tegra->sata_rst = devm_reset_control_get_exclusive(&pdev->dev, "sata");
if (IS_ERR(tegra->sata_rst)) {
dev_err(&pdev->dev, "Failed to get sata reset\n");
return PTR_ERR(tegra->sata_rst);
}
- tegra->sata_oob_rst = devm_reset_control_get(&pdev->dev, "sata-oob");
+ tegra->sata_oob_rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "sata-oob");
if (IS_ERR(tegra->sata_oob_rst)) {
dev_err(&pdev->dev, "Failed to get sata-oob reset\n");
return PTR_ERR(tegra->sata_oob_rst);
}
- tegra->sata_cold_rst = devm_reset_control_get(&pdev->dev, "sata-cold");
+ tegra->sata_cold_rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "sata-cold");
if (IS_ERR(tegra->sata_cold_rst)) {
dev_err(&pdev->dev, "Failed to get sata-cold reset\n");
return PTR_ERR(tegra->sata_cold_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 007/102] bus: sunxi-rsb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Maxime Ripard, Chen-Yu Tsai, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/bus/sunxi-rsb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
index 795c9d9c96a6d..c7f585a420d3e 100644
--- a/drivers/bus/sunxi-rsb.c
+++ b/drivers/bus/sunxi-rsb.c
@@ -670,7 +670,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
p_clk_freq = clk_get_rate(rsb->clk);
- rsb->rstc = devm_reset_control_get(dev, NULL);
+ rsb->rstc = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rsb->rstc)) {
ret = PTR_ERR(rsb->rstc);
dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 007/102] bus: sunxi-rsb: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/bus/sunxi-rsb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
index 795c9d9c96a6d..c7f585a420d3e 100644
--- a/drivers/bus/sunxi-rsb.c
+++ b/drivers/bus/sunxi-rsb.c
@@ -670,7 +670,7 @@ static int sunxi_rsb_probe(struct platform_device *pdev)
p_clk_freq = clk_get_rate(rsb->clk);
- rsb->rstc = devm_reset_control_get(dev, NULL);
+ rsb->rstc = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rsb->rstc)) {
ret = PTR_ERR(rsb->rstc);
dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 008/102] bus: tegra-gmi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (8 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Thierry Reding, Jonathan Hunter, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/bus/tegra-gmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c
index a6570789f7afe..36b1a17014425 100644
--- a/drivers/bus/tegra-gmi.c
+++ b/drivers/bus/tegra-gmi.c
@@ -226,7 +226,7 @@ static int tegra_gmi_probe(struct platform_device *pdev)
return PTR_ERR(gmi->clk);
}
- gmi->rst = devm_reset_control_get(dev, "gmi");
+ gmi->rst = devm_reset_control_get_exclusive(dev, "gmi");
if (IS_ERR(gmi->rst)) {
dev_err(dev, "can not get reset\n");
return PTR_ERR(gmi->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 009/102] clk: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (9 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-11-02 5:55 ` Stephen Boyd
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Emilio López, Michael Turquette,
Stephen Boyd, Maxime Ripard, Chen-Yu Tsai, linux-clk
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-clk@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi/clk-sun9i-mmc.c b/drivers/clk/sunxi/clk-sun9i-mmc.c
index 6041bdba2e971..a1a634253d6f2 100644
--- a/drivers/clk/sunxi/clk-sun9i-mmc.c
+++ b/drivers/clk/sunxi/clk-sun9i-mmc.c
@@ -124,7 +124,7 @@ static int sun9i_a80_mmc_config_clk_probe(struct platform_device *pdev)
return PTR_ERR(data->clk);
}
- data->reset = devm_reset_control_get(&pdev->dev, NULL);
+ data->reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(data->reset)) {
dev_err(&pdev->dev, "Could not get reset control\n");
return PTR_ERR(data->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 010/102] clk: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (10 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-11-02 8:15 ` Stephen Boyd
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Peter De Schrijver, Prashant Gaikwad,
Michael Turquette, Stephen Boyd, Thierry Reding, Jonathan Hunter,
linux-clk, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-clk@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clk/tegra/clk-dfll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
index 2c44aeb0b97c7..bada64cf5392a 100644
--- a/drivers/clk/tegra/clk-dfll.c
+++ b/drivers/clk/tegra/clk-dfll.c
@@ -1631,7 +1631,7 @@ int tegra_dfll_register(struct platform_device *pdev,
return PTR_ERR(td->vdd_reg);
}
- td->dvco_rst = devm_reset_control_get(td->dev, "dvco");
+ td->dvco_rst = devm_reset_control_get_exclusive(td->dev, "dvco");
if (IS_ERR(td->dvco_rst)) {
dev_err(td->dev, "couldn't get dvco reset\n");
return PTR_ERR(td->dvco_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 011/102] clocksource/drivers/timer-stm32: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Daniel Lezcano, Thomas Gleixner, Maxime Coquelin,
Alexandre Torgue, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clocksource/timer-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index 174d1243ea93a..b0bac14911b11 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -122,7 +122,7 @@ static int __init stm32_clockevent_init(struct device_node *np)
rate = clk_get_rate(clk);
- rstc = of_reset_control_get(np, NULL);
+ rstc = of_reset_control_get_exclusive(np, NULL);
if (!IS_ERR(rstc)) {
reset_control_assert(rstc);
reset_control_deassert(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 011/102] clocksource/drivers/timer-stm32: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clocksource/timer-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index 174d1243ea93a..b0bac14911b11 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -122,7 +122,7 @@ static int __init stm32_clockevent_init(struct device_node *np)
rate = clk_get_rate(clk);
- rstc = of_reset_control_get(np, NULL);
+ rstc = of_reset_control_get_exclusive(np, NULL);
if (!IS_ERR(rstc)) {
reset_control_assert(rstc);
reset_control_deassert(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 012/102] clocksource/drivers/sun5i: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Daniel Lezcano, Thomas Gleixner, Maxime Ripard,
Chen-Yu Tsai, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clocksource/timer-sun5i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
index 2a3fe83ec3377..a75be5bfb8b20 100644
--- a/drivers/clocksource/timer-sun5i.c
+++ b/drivers/clocksource/timer-sun5i.c
@@ -349,7 +349,7 @@ static int __init sun5i_timer_init(struct device_node *node)
return PTR_ERR(clk);
}
- rstc = of_reset_control_get(node, NULL);
+ rstc = of_reset_control_get_exclusive(node, NULL);
if (!IS_ERR(rstc))
reset_control_deassert(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 012/102] clocksource/drivers/sun5i: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/clocksource/timer-sun5i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-sun5i.c b/drivers/clocksource/timer-sun5i.c
index 2a3fe83ec3377..a75be5bfb8b20 100644
--- a/drivers/clocksource/timer-sun5i.c
+++ b/drivers/clocksource/timer-sun5i.c
@@ -349,7 +349,7 @@ static int __init sun5i_timer_init(struct device_node *node)
return PTR_ERR(clk);
}
- rstc = of_reset_control_get(node, NULL);
+ rstc = of_reset_control_get_exclusive(node, NULL);
if (!IS_ERR(rstc))
reset_control_deassert(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 013/102] crypto: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (13 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Herbert Xu, David S. Miller, Heiko Stuebner,
linux-crypto, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-crypto@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/crypto/rockchip/rk3288_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
index d0f80c6241f95..fdfd1f02911e9 100644
--- a/drivers/crypto/rockchip/rk3288_crypto.c
+++ b/drivers/crypto/rockchip/rk3288_crypto.c
@@ -294,7 +294,7 @@ static int rk_crypto_probe(struct platform_device *pdev)
goto err_crypto;
}
- crypto_info->rst = devm_reset_control_get(dev, "crypto-rst");
+ crypto_info->rst = devm_reset_control_get_exclusive(dev, "crypto-rst");
if (IS_ERR(crypto_info->rst)) {
err = PTR_ERR(crypto_info->rst);
goto err_crypto;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 014/102] crypto: sun4i-ss - request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (14 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Corentin Labbe, Herbert Xu, David S. Miller,
Maxime Ripard, Chen-Yu Tsai, linux-crypto
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/crypto/sunxi-ss/sun4i-ss-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-core.c b/drivers/crypto/sunxi-ss/sun4i-ss-core.c
index 02ad8256e9002..69374e42ad05f 100644
--- a/drivers/crypto/sunxi-ss/sun4i-ss-core.c
+++ b/drivers/crypto/sunxi-ss/sun4i-ss-core.c
@@ -255,7 +255,8 @@ static int sun4i_ss_probe(struct platform_device *pdev)
}
dev_dbg(&pdev->dev, "clock ahb_ss acquired\n");
- ss->reset = devm_reset_control_get_optional(&pdev->dev, "ahb");
+ ss->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ "ahb");
if (IS_ERR(ss->reset)) {
if (PTR_ERR(ss->reset) == -EPROBE_DEFER)
return PTR_ERR(ss->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 015/102] PM / devfreq: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (15 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Thierry Reding, Jonathan Hunter, linux-pm, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/devfreq/tegra-devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index ae712159246fb..8108487b34192 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -628,7 +628,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
if (IS_ERR(tegra->regs))
return PTR_ERR(tegra->regs);
- tegra->reset = devm_reset_control_get(&pdev->dev, "actmon");
+ tegra->reset = devm_reset_control_get_exclusive(&pdev->dev, "actmon");
if (IS_ERR(tegra->reset)) {
dev_err(&pdev->dev, "Failed to get reset\n");
return PTR_ERR(tegra->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 016/102] dmaengine: stm32-dma: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (16 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Dan Williams, Vinod Koul, Maxime Coquelin,
Alexandre Torgue, dmaengine
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/dma/stm32-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
index 786fc8fcc38ed..73486af244744 100644
--- a/drivers/dma/stm32-dma.c
+++ b/drivers/dma/stm32-dma.c
@@ -1058,7 +1058,7 @@ static int stm32_dma_probe(struct platform_device *pdev)
dmadev->mem2mem = of_property_read_bool(pdev->dev.of_node,
"st,mem2mem");
- dmadev->rst = devm_reset_control_get(&pdev->dev, NULL);
+ dmadev->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(dmadev->rst)) {
reset_control_assert(dmadev->rst);
udelay(2);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 017/102] dmaengine: sun6i: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (17 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Vinod Koul, Dan Williams, Maxime Ripard,
Chen-Yu Tsai, dmaengine
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: dmaengine@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/dma/sun6i-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index a2358780ab2c3..7903c9971b8d2 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -1070,7 +1070,7 @@ static int sun6i_dma_probe(struct platform_device *pdev)
return PTR_ERR(sdc->clk);
}
- sdc->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ sdc->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(sdc->rstc)) {
dev_err(&pdev->dev, "No reset controller specified\n");
return PTR_ERR(sdc->rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 018/102] dmaengine: tegra-apb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (18 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Jon Hunter, Vinod Koul,
Dan Williams, Thierry Reding, dmaengine, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/dma/tegra20-apb-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index b9d75a54c896a..3d4d0241aefed 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -1330,7 +1330,7 @@ static int tegra_dma_probe(struct platform_device *pdev)
return PTR_ERR(tdma->dma_clk);
}
- tdma->rst = devm_reset_control_get(&pdev->dev, "dma");
+ tdma->rst = devm_reset_control_get_exclusive(&pdev->dev, "dma");
if (IS_ERR(tdma->rst)) {
dev_err(&pdev->dev, "Error: Missing reset\n");
return PTR_ERR(tdma->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 019/102] drm: kirin: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Xinliang Liu, Rongrong Zou, Xinwei Kong,
Chen Feng, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228a98980..5cef7ee83a168 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -933,7 +933,7 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
return PTR_ERR(ctx->base);
}
- ctx->reset = devm_reset_control_get(dev, NULL);
+ ctx->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(ctx->reset))
return PTR_ERR(ctx->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 019/102] drm: kirin: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Chen Feng, dri-devel, Xinliang Liu, Xinwei Kong, Rongrong Zou
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index c96c228a98980..5cef7ee83a168 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -933,7 +933,7 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
return PTR_ERR(ctx->base);
}
- ctx->reset = devm_reset_control_get(dev, NULL);
+ ctx->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(ctx->reset))
return PTR_ERR(ctx->reset);
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 020/102] drm/nouveau/tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (20 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Ben Skeggs, David Airlie, Thierry Reding,
Jonathan Hunter, dri-devel, nouveau, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index 189ed80e21ffb..ac5d4cf058c25 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -282,7 +282,7 @@ nvkm_device_tegra_new(const struct nvkm_device_tegra_func *func,
}
}
- tdev->rst = devm_reset_control_get(&pdev->dev, "gpu");
+ tdev->rst = devm_reset_control_get_exclusive(&pdev->dev, "gpu");
if (IS_ERR(tdev->rst)) {
ret = PTR_ERR(tdev->rst);
goto free;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 021/102] drm/rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Mark Yao, Heiko Stuebner, dri-devel, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++++----
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 9606121fa185a..172930e7645e7 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -297,7 +297,7 @@ static int rockchip_dp_init(struct rockchip_dp_device *dp)
return PTR_ERR(dp->pclk);
}
- dp->rst = devm_reset_control_get(dev, "dp");
+ dp->rst = devm_reset_control_get_exclusive(dev, "dp");
if (IS_ERR(dp->rst)) {
dev_err(dev, "failed to get dp reset control\n");
return PTR_ERR(dp->rst);
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 9b0b0588bbedb..b7f5c5d9f245d 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -765,25 +765,25 @@ static int cdn_dp_parse_dt(struct cdn_dp_device *dp)
return PTR_ERR(dp->grf_clk);
}
- dp->spdif_rst = devm_reset_control_get(dev, "spdif");
+ dp->spdif_rst = devm_reset_control_get_exclusive(dev, "spdif");
if (IS_ERR(dp->spdif_rst)) {
DRM_DEV_ERROR(dev, "no spdif reset control found\n");
return PTR_ERR(dp->spdif_rst);
}
- dp->dptx_rst = devm_reset_control_get(dev, "dptx");
+ dp->dptx_rst = devm_reset_control_get_exclusive(dev, "dptx");
if (IS_ERR(dp->dptx_rst)) {
DRM_DEV_ERROR(dev, "no uphy reset control found\n");
return PTR_ERR(dp->dptx_rst);
}
- dp->core_rst = devm_reset_control_get(dev, "core");
+ dp->core_rst = devm_reset_control_get_exclusive(dev, "core");
if (IS_ERR(dp->core_rst)) {
DRM_DEV_ERROR(dev, "no core reset control found\n");
return PTR_ERR(dp->core_rst);
}
- dp->apb_rst = devm_reset_control_get(dev, "apb");
+ dp->apb_rst = devm_reset_control_get_exclusive(dev, "apb");
if (IS_ERR(dp->apb_rst)) {
DRM_DEV_ERROR(dev, "no apb reset control found\n");
return PTR_ERR(dp->apb_rst);
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index 21b9737662ae9..c3501ae59db35 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -1221,7 +1221,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
* Note that the reset was not defined in the initial device tree, so
* we have to be prepared for it not being found.
*/
- apb_rst = devm_reset_control_get(dev, "apb");
+ apb_rst = devm_reset_control_get_exclusive(dev, "apb");
if (IS_ERR(apb_rst)) {
ret = PTR_ERR(apb_rst);
if (ret == -ENOENT) {
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 5d450332c2fd7..18b582cd81e50 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1443,7 +1443,7 @@ static int vop_initial(struct vop *vop)
/*
* do hclk_reset, reset all vop registers.
*/
- ahb_rst = devm_reset_control_get(vop->dev, "ahb");
+ ahb_rst = devm_reset_control_get_exclusive(vop->dev, "ahb");
if (IS_ERR(ahb_rst)) {
dev_err(vop->dev, "failed to get ahb reset\n");
ret = PTR_ERR(ahb_rst);
@@ -1469,7 +1469,7 @@ static int vop_initial(struct vop *vop)
/*
* do dclk_reset, let all config take affect.
*/
- vop->dclk_rst = devm_reset_control_get(vop->dev, "dclk");
+ vop->dclk_rst = devm_reset_control_get_exclusive(vop->dev, "dclk");
if (IS_ERR(vop->dclk_rst)) {
dev_err(vop->dev, "failed to get dclk reset\n");
ret = PTR_ERR(vop->dclk_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 021/102] drm/rockchip: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-rockchip, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++++----
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 9606121fa185a..172930e7645e7 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -297,7 +297,7 @@ static int rockchip_dp_init(struct rockchip_dp_device *dp)
return PTR_ERR(dp->pclk);
}
- dp->rst = devm_reset_control_get(dev, "dp");
+ dp->rst = devm_reset_control_get_exclusive(dev, "dp");
if (IS_ERR(dp->rst)) {
dev_err(dev, "failed to get dp reset control\n");
return PTR_ERR(dp->rst);
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index 9b0b0588bbedb..b7f5c5d9f245d 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -765,25 +765,25 @@ static int cdn_dp_parse_dt(struct cdn_dp_device *dp)
return PTR_ERR(dp->grf_clk);
}
- dp->spdif_rst = devm_reset_control_get(dev, "spdif");
+ dp->spdif_rst = devm_reset_control_get_exclusive(dev, "spdif");
if (IS_ERR(dp->spdif_rst)) {
DRM_DEV_ERROR(dev, "no spdif reset control found\n");
return PTR_ERR(dp->spdif_rst);
}
- dp->dptx_rst = devm_reset_control_get(dev, "dptx");
+ dp->dptx_rst = devm_reset_control_get_exclusive(dev, "dptx");
if (IS_ERR(dp->dptx_rst)) {
DRM_DEV_ERROR(dev, "no uphy reset control found\n");
return PTR_ERR(dp->dptx_rst);
}
- dp->core_rst = devm_reset_control_get(dev, "core");
+ dp->core_rst = devm_reset_control_get_exclusive(dev, "core");
if (IS_ERR(dp->core_rst)) {
DRM_DEV_ERROR(dev, "no core reset control found\n");
return PTR_ERR(dp->core_rst);
}
- dp->apb_rst = devm_reset_control_get(dev, "apb");
+ dp->apb_rst = devm_reset_control_get_exclusive(dev, "apb");
if (IS_ERR(dp->apb_rst)) {
DRM_DEV_ERROR(dev, "no apb reset control found\n");
return PTR_ERR(dp->apb_rst);
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index 21b9737662ae9..c3501ae59db35 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -1221,7 +1221,7 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
* Note that the reset was not defined in the initial device tree, so
* we have to be prepared for it not being found.
*/
- apb_rst = devm_reset_control_get(dev, "apb");
+ apb_rst = devm_reset_control_get_exclusive(dev, "apb");
if (IS_ERR(apb_rst)) {
ret = PTR_ERR(apb_rst);
if (ret == -ENOENT) {
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 5d450332c2fd7..18b582cd81e50 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1443,7 +1443,7 @@ static int vop_initial(struct vop *vop)
/*
* do hclk_reset, reset all vop registers.
*/
- ahb_rst = devm_reset_control_get(vop->dev, "ahb");
+ ahb_rst = devm_reset_control_get_exclusive(vop->dev, "ahb");
if (IS_ERR(ahb_rst)) {
dev_err(vop->dev, "failed to get ahb reset\n");
ret = PTR_ERR(ahb_rst);
@@ -1469,7 +1469,7 @@ static int vop_initial(struct vop *vop)
/*
* do dclk_reset, let all config take affect.
*/
- vop->dclk_rst = devm_reset_control_get(vop->dev, "dclk");
+ vop->dclk_rst = devm_reset_control_get_exclusive(vop->dev, "dclk");
if (IS_ERR(vop->dclk_rst)) {
dev_err(vop->dev, "failed to get dclk reset\n");
ret = PTR_ERR(vop->dclk_rst);
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 022/102] drm/sti: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (22 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-20 10:09 ` Benjamin Gaignard
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Benjamin Gaignard, Vincent Abriou, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index a59c95a8081b7..ea6e5b5a3725b 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1428,7 +1428,7 @@ static int sti_hdmi_probe(struct platform_device *pdev)
if (!hdmi->notifier)
goto release_adapter;
- hdmi->reset = devm_reset_control_get(dev, "hdmi");
+ hdmi->reset = devm_reset_control_get_exclusive(dev, "hdmi");
/* Take hdmi out of reset */
if (!IS_ERR(hdmi->reset))
reset_control_deassert(hdmi->reset);
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index a1c161f778044..2809db8c03216 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1375,7 +1375,7 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
}
/* Get reset resources */
- hqvdp->reset = devm_reset_control_get(dev, "hqvdp");
+ hqvdp->reset = devm_reset_control_get_exclusive(dev, "hqvdp");
if (!IS_ERR(hqvdp->reset))
reset_control_deassert(hqvdp->reset);
diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index 8959fcc743a8e..cbe0f5c162348 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -857,7 +857,7 @@ static int sti_tvout_probe(struct platform_device *pdev)
return -ENOMEM;
/* get reset resources */
- tvout->reset = devm_reset_control_get(dev, "tvout");
+ tvout->reset = devm_reset_control_get_exclusive(dev, "tvout");
/* take tvout out of reset */
if (!IS_ERR(tvout->reset))
reset_control_deassert(tvout->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 023/102] drm/stm: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (23 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/stm/ltdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 1b9483d4f2a4e..59d344a519097 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -1026,7 +1026,7 @@ int ltdc_load(struct drm_device *ddev)
if (!ldev->panel)
return -EPROBE_DEFER;
- rstc = of_reset_control_get(np, NULL);
+ rstc = of_reset_control_get_exclusive(np, NULL);
mutex_init(&ldev->err_lock);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 024/102] drm/sun4i: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Maxime Ripard, Chen-Yu Tsai, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index cf480218daa50..b7eb908798f6e 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -248,7 +248,7 @@ static int sun4i_backend_init_sat(struct device *dev) {
struct sun4i_backend *backend = dev_get_drvdata(dev);
int ret;
- backend->sat_reset = devm_reset_control_get(dev, "sat");
+ backend->sat_reset = devm_reset_control_get_exclusive(dev, "sat");
if (IS_ERR(backend->sat_reset)) {
dev_err(dev, "Couldn't get the SAT reset line\n");
return PTR_ERR(backend->sat_reset);
@@ -376,7 +376,7 @@ static int sun4i_backend_bind(struct device *dev, struct device *master,
return PTR_ERR(backend->engine.regs);
}
- backend->reset = devm_reset_control_get(dev, NULL);
+ backend->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(backend->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(backend->reset);
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index d9791292553ef..2135ae51356a1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -523,7 +523,7 @@ static int sun4i_tcon_bind(struct device *dev, struct device *master,
tcon->id = engine->id;
tcon->quirks = of_device_get_match_data(dev);
- tcon->lcd_rst = devm_reset_control_get(dev, "lcd");
+ tcon->lcd_rst = devm_reset_control_get_exclusive(dev, "lcd");
if (IS_ERR(tcon->lcd_rst)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(tcon->lcd_rst);
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 338b9e5bb2a3e..a8b93b2658c44 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
@@ -593,7 +593,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master,
return PTR_ERR(tv->regs);
}
- tv->reset = devm_reset_control_get(dev, NULL);
+ tv->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(tv->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(tv->reset);
diff --git a/drivers/gpu/drm/sun4i/sun6i_drc.c b/drivers/gpu/drm/sun4i/sun6i_drc.c
index 09bba853e2a42..8b018e539a9e3 100644
--- a/drivers/gpu/drm/sun4i/sun6i_drc.c
+++ b/drivers/gpu/drm/sun4i/sun6i_drc.c
@@ -33,7 +33,7 @@ static int sun6i_drc_bind(struct device *dev, struct device *master,
return -ENOMEM;
dev_set_drvdata(dev, drc);
- drc->reset = devm_reset_control_get(dev, NULL);
+ drc->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(drc->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(drc->reset);
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index cb193c5f16862..13adac261d1f8 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -287,7 +287,7 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
return PTR_ERR(mixer->engine.regs);
}
- mixer->reset = devm_reset_control_get(dev, NULL);
+ mixer->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(mixer->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(mixer->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 024/102] drm/sun4i: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: dri-devel, Maxime Ripard, Chen-Yu Tsai
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 ++--
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index cf480218daa50..b7eb908798f6e 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -248,7 +248,7 @@ static int sun4i_backend_init_sat(struct device *dev) {
struct sun4i_backend *backend = dev_get_drvdata(dev);
int ret;
- backend->sat_reset = devm_reset_control_get(dev, "sat");
+ backend->sat_reset = devm_reset_control_get_exclusive(dev, "sat");
if (IS_ERR(backend->sat_reset)) {
dev_err(dev, "Couldn't get the SAT reset line\n");
return PTR_ERR(backend->sat_reset);
@@ -376,7 +376,7 @@ static int sun4i_backend_bind(struct device *dev, struct device *master,
return PTR_ERR(backend->engine.regs);
}
- backend->reset = devm_reset_control_get(dev, NULL);
+ backend->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(backend->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(backend->reset);
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index d9791292553ef..2135ae51356a1 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -523,7 +523,7 @@ static int sun4i_tcon_bind(struct device *dev, struct device *master,
tcon->id = engine->id;
tcon->quirks = of_device_get_match_data(dev);
- tcon->lcd_rst = devm_reset_control_get(dev, "lcd");
+ tcon->lcd_rst = devm_reset_control_get_exclusive(dev, "lcd");
if (IS_ERR(tcon->lcd_rst)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(tcon->lcd_rst);
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 338b9e5bb2a3e..a8b93b2658c44 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
@@ -593,7 +593,7 @@ static int sun4i_tv_bind(struct device *dev, struct device *master,
return PTR_ERR(tv->regs);
}
- tv->reset = devm_reset_control_get(dev, NULL);
+ tv->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(tv->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(tv->reset);
diff --git a/drivers/gpu/drm/sun4i/sun6i_drc.c b/drivers/gpu/drm/sun4i/sun6i_drc.c
index 09bba853e2a42..8b018e539a9e3 100644
--- a/drivers/gpu/drm/sun4i/sun6i_drc.c
+++ b/drivers/gpu/drm/sun4i/sun6i_drc.c
@@ -33,7 +33,7 @@ static int sun6i_drc_bind(struct device *dev, struct device *master,
return -ENOMEM;
dev_set_drvdata(dev, drc);
- drc->reset = devm_reset_control_get(dev, NULL);
+ drc->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(drc->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(drc->reset);
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index cb193c5f16862..13adac261d1f8 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -287,7 +287,7 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
return PTR_ERR(mixer->engine.regs);
}
- mixer->reset = devm_reset_control_get(dev, NULL);
+ mixer->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(mixer->reset)) {
dev_err(dev, "Couldn't get our reset line\n");
return PTR_ERR(mixer->reset);
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 025/102] drm/tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (25 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Thierry Reding, Jonathan Hunter, dri-devel, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/tegra/dc.c | 2 +-
drivers/gpu/drm/tegra/dpaux.c | 3 ++-
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/drm/tegra/gr3d.c | 6 +++---
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 2 +-
6 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index c875f11786b93..61d476a3006af 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -2011,7 +2011,7 @@ static int tegra_dc_probe(struct platform_device *pdev)
return PTR_ERR(dc->clk);
}
- dc->rst = devm_reset_control_get(&pdev->dev, "dc");
+ dc->rst = devm_reset_control_get_exclusive(&pdev->dev, "dc");
if (IS_ERR(dc->rst)) {
dev_err(&pdev->dev, "failed to get reset\n");
return PTR_ERR(dc->rst);
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 2fde44c3a1b30..1cf18f4f98f06 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -445,7 +445,8 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
}
if (!pdev->dev.pm_domain) {
- dpaux->rst = devm_reset_control_get(&pdev->dev, "dpaux");
+ dpaux->rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "dpaux");
if (IS_ERR(dpaux->rst)) {
dev_err(&pdev->dev,
"failed to get reset control: %ld\n",
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index 3dea1216bafdc..af8850c74abe9 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -1518,7 +1518,7 @@ static int tegra_dsi_probe(struct platform_device *pdev)
dsi->lanes = 4;
if (!pdev->dev.pm_domain) {
- dsi->rst = devm_reset_control_get(&pdev->dev, "dsi");
+ dsi->rst = devm_reset_control_get_exclusive(&pdev->dev, "dsi");
if (IS_ERR(dsi->rst))
return PTR_ERR(dsi->rst);
}
diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c
index cee2ab645cde9..e8dd13e02483d 100644
--- a/drivers/gpu/drm/tegra/gr3d.c
+++ b/drivers/gpu/drm/tegra/gr3d.c
@@ -260,7 +260,7 @@ static int gr3d_probe(struct platform_device *pdev)
return PTR_ERR(gr3d->clk);
}
- gr3d->rst = devm_reset_control_get(&pdev->dev, "3d");
+ gr3d->rst = devm_reset_control_get_exclusive(&pdev->dev, "3d");
if (IS_ERR(gr3d->rst)) {
dev_err(&pdev->dev, "cannot get reset\n");
return PTR_ERR(gr3d->rst);
@@ -273,8 +273,8 @@ static int gr3d_probe(struct platform_device *pdev)
return PTR_ERR(gr3d->clk_secondary);
}
- gr3d->rst_secondary = devm_reset_control_get(&pdev->dev,
- "3d2");
+ gr3d->rst_secondary = devm_reset_control_get_exclusive(&pdev->dev,
+ "3d2");
if (IS_ERR(gr3d->rst_secondary)) {
dev_err(&pdev->dev, "cannot get secondary reset\n");
return PTR_ERR(gr3d->rst_secondary);
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index cda0491ed6bf8..49d1cade94742 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1686,7 +1686,7 @@ static int tegra_hdmi_probe(struct platform_device *pdev)
return PTR_ERR(hdmi->clk);
}
- hdmi->rst = devm_reset_control_get(&pdev->dev, "hdmi");
+ hdmi->rst = devm_reset_control_get_exclusive(&pdev->dev, "hdmi");
if (IS_ERR(hdmi->rst)) {
dev_err(&pdev->dev, "failed to get reset\n");
return PTR_ERR(hdmi->rst);
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index a8f528925009e..4a4796ceeb541 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -2609,7 +2609,7 @@ static int tegra_sor_probe(struct platform_device *pdev)
}
if (!pdev->dev.pm_domain) {
- sor->rst = devm_reset_control_get(&pdev->dev, "sor");
+ sor->rst = devm_reset_control_get_exclusive(&pdev->dev, "sor");
if (IS_ERR(sor->rst)) {
err = PTR_ERR(sor->rst);
dev_err(&pdev->dev, "failed to get reset control: %d\n",
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 026/102] gpu: host1x: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-tegra, Thierry Reding, dri-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/host1x/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
index 2c58a390123a1..5af7055280c6c 100644
--- a/drivers/gpu/host1x/dev.c
+++ b/drivers/gpu/host1x/dev.c
@@ -170,7 +170,7 @@ static int host1x_probe(struct platform_device *pdev)
return err;
}
- host->rst = devm_reset_control_get(&pdev->dev, "host1x");
+ host->rst = devm_reset_control_get_exclusive(&pdev->dev, "host1x");
if (IS_ERR(host->rst)) {
err = PTR_ERR(host->rst);
dev_err(&pdev->dev, "failed to get reset: %d\n", err);
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 026/102] gpu: host1x: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Thierry Reding, dri-devel, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/host1x/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
index 2c58a390123a1..5af7055280c6c 100644
--- a/drivers/gpu/host1x/dev.c
+++ b/drivers/gpu/host1x/dev.c
@@ -170,7 +170,7 @@ static int host1x_probe(struct platform_device *pdev)
return err;
}
- host->rst = devm_reset_control_get(&pdev->dev, "host1x");
+ host->rst = devm_reset_control_get_exclusive(&pdev->dev, "host1x");
if (IS_ERR(host->rst)) {
err = PTR_ERR(host->rst);
dev_err(&pdev->dev, "failed to get reset: %d\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 027/102] i2c: mv64xxx: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (27 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Wolfram Sang, linux-i2c
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 5c4db65c5019b..887bc7d97a777 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -820,7 +820,7 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data,
goto out;
}
- drv_data->rstc = devm_reset_control_get_optional(dev, NULL);
+ drv_data->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
if (IS_ERR(drv_data->rstc)) {
rc = PTR_ERR(drv_data->rstc);
goto out;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 028/102] i2c: stm32f4: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (28 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wolfram Sang, Maxime Coquelin, Alexandre Torgue,
linux-i2c
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
index f9dd7e86b861a..4da3ce0865ebd 100644
--- a/drivers/i2c/busses/i2c-stm32f4.c
+++ b/drivers/i2c/busses/i2c-stm32f4.c
@@ -798,7 +798,7 @@ static int stm32f4_i2c_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Error: Missing controller reset\n");
ret = PTR_ERR(rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 029/102] i2c: sun6i-pw2i: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (29 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wolfram Sang, Maxime Ripard, Chen-Yu Tsai, linux-i2c
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-i2c@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
index 7668e2e9b8fd2..68a4567ad974e 100644
--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
@@ -258,7 +258,7 @@ static int p2wi_probe(struct platform_device *pdev)
parent_clk_freq = clk_get_rate(p2wi->clk);
- p2wi->rstc = devm_reset_control_get(dev, NULL);
+ p2wi->rstc = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(p2wi->rstc)) {
ret = PTR_ERR(p2wi->rstc);
dev_err(dev, "failed to retrieve reset controller: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 030/102] i2c: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (30 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Wolfram Sang, Thierry Reding,
Jonathan Hunter, linux-i2c, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-i2c@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 4af9bbae20dfd..a23884445fa2f 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -911,7 +911,7 @@ static int tegra_i2c_probe(struct platform_device *pdev)
i2c_dev->cont_id = pdev->id;
i2c_dev->dev = &pdev->dev;
- i2c_dev->rst = devm_reset_control_get(&pdev->dev, "i2c");
+ i2c_dev->rst = devm_reset_control_get_exclusive(&pdev->dev, "i2c");
if (IS_ERR(i2c_dev->rst)) {
dev_err(&pdev->dev, "missing controller reset\n");
return PTR_ERR(i2c_dev->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 031/102] iio: adc: rockchip_saradc: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (31 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-08-20 11:09 ` Jonathan Cameron
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Heiko Stuebner,
linux-iio, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-iio@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/iio/adc/rockchip_saradc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index ae6d3324f5183..1d9300ba07c00 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -235,7 +235,8 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
* The reset should be an optional property, as it should work
* with old devicetrees as well
*/
- info->reset = devm_reset_control_get(&pdev->dev, "saradc-apb");
+ info->reset = devm_reset_control_get_exclusive(&pdev->dev,
+ "saradc-apb");
if (IS_ERR(info->reset)) {
ret = PTR_ERR(info->reset);
if (ret != -ENOENT)
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 032/102] iio: dac: stm32-dac-core: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (32 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-08-20 11:07 ` Jonathan Cameron
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Maxime Coquelin,
Alexandre Torgue, linux-iio
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/iio/dac/stm32-dac-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
index 75e48788c7ead..f1eeb1549f689 100644
--- a/drivers/iio/dac/stm32-dac-core.c
+++ b/drivers/iio/dac/stm32-dac-core.c
@@ -114,7 +114,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
goto err_vref;
}
- priv->rst = devm_reset_control_get(dev, NULL);
+ priv->rst = devm_reset_control_get_exclusive(dev, NULL);
if (!IS_ERR(priv->rst)) {
reset_control_assert(priv->rst);
udelay(2);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 033/102] Input: tegra-kbc - request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Rakesh Iyer, Laxman Dewangan, Dmitry Torokhov,
Thierry Reding, Jonathan Hunter,
linux-input-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Rakesh Iyer <riyer-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/input/keyboard/tegra-kbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 0c07e1023a469..c42c825dd982b 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -665,7 +665,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
return PTR_ERR(kbc->clk);
}
- kbc->rst = devm_reset_control_get(&pdev->dev, "kbc");
+ kbc->rst = devm_reset_control_get_exclusive(&pdev->dev, "kbc");
if (IS_ERR(kbc->rst)) {
dev_err(&pdev->dev, "failed to get keyboard reset\n");
return PTR_ERR(kbc->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 033/102] Input: tegra-kbc - request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Rakesh Iyer, Laxman Dewangan, Dmitry Torokhov,
Thierry Reding, Jonathan Hunter, linux-input, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Rakesh Iyer <riyer@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-input@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/input/keyboard/tegra-kbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 0c07e1023a469..c42c825dd982b 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -665,7 +665,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
return PTR_ERR(kbc->clk);
}
- kbc->rst = devm_reset_control_get(&pdev->dev, "kbc");
+ kbc->rst = devm_reset_control_get_exclusive(&pdev->dev, "kbc");
if (IS_ERR(kbc->rst)) {
dev_err(&pdev->dev, "failed to get keyboard reset\n");
return PTR_ERR(kbc->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 034/102] coda: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (33 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, linux-media
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: linux-media@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/platform/coda/coda-common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index f92cc7df58fb8..8e0b1a4e2546b 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -2470,7 +2470,8 @@ static int coda_probe(struct platform_device *pdev)
return ret;
}
- dev->rstc = devm_reset_control_get_optional(&pdev->dev, NULL);
+ dev->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(dev->rstc)) {
ret = PTR_ERR(dev->rstc);
dev_err(&pdev->dev, "failed get reset control: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 035/102] st-rc: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (34 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Patrice Chotard, linux-media
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: linux-media@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/rc/st_rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
index a08e1dd061249..d48304f6c3de0 100644
--- a/drivers/media/rc/st_rc.c
+++ b/drivers/media/rc/st_rc.c
@@ -280,7 +280,7 @@ static int st_rc_probe(struct platform_device *pdev)
else
rc_dev->rx_base = rc_dev->base;
- rc_dev->rstc = reset_control_get_optional(dev, NULL);
+ rc_dev->rstc = reset_control_get_optional_exclusive(dev, NULL);
if (IS_ERR(rc_dev->rstc)) {
ret = PTR_ERR(rc_dev->rstc);
goto err;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 036/102] stm32-dcmi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (35 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Maxime Coquelin, Alexandre Torgue, linux-media
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-media@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 83d32a5d0f408..a2d883dcf32b9 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1209,7 +1209,7 @@ static int dcmi_probe(struct platform_device *pdev)
if (!dcmi)
return -ENOMEM;
- dcmi->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ dcmi->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(dcmi->rstc)) {
dev_err(&pdev->dev, "Could not get reset control\n");
return -ENODEV;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 037/102] rc: sunxi-cir: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (36 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Maxime Ripard, Chen-Yu Tsai, linux-media
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-media@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/rc/sunxi-cir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 4b785dd775c11..3e033fb79463a 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -173,7 +173,7 @@ static int sunxi_ir_probe(struct platform_device *pdev)
}
/* Reset (optional) */
- ir->rst = devm_reset_control_get_optional(dev, NULL);
+ ir->rst = devm_reset_control_get_optional_exclusive(dev, NULL);
if (IS_ERR(ir->rst))
return PTR_ERR(ir->rst);
ret = reset_control_deassert(ir->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (37 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-22 13:13 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
-1 siblings, 2 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Jaehoon Chung, Ulf Hansson, linux-mmc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mmc/host/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a9dfb26972f21..7c1e2dbc76776 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2950,7 +2950,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
return ERR_PTR(-ENOMEM);
/* find reset controller when exist */
- pdata->rstc = devm_reset_control_get_optional(dev, "reset");
+ pdata->rstc = devm_reset_control_get_optional_exclusive(dev, "reset");
if (IS_ERR(pdata->rstc)) {
if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
return ERR_PTR(-EPROBE_DEFER);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 039/102] mmc: sdhci-st: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (38 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Patrice Chotard, Adrian Hunter, Ulf Hansson, linux-mmc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mmc/host/sdhci-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 68c36c9fa2318..ad1ab0777d5f6 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -371,7 +371,7 @@ static int sdhci_st_probe(struct platform_device *pdev)
if (IS_ERR(icnclk))
icnclk = NULL;
- rstc = devm_reset_control_get(&pdev->dev, NULL);
+ rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rstc))
rstc = NULL;
else
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 040/102] mmc: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (39 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-27 14:48 ` Ulf Hansson
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Ulf Hansson, Maxime Ripard, Chen-Yu Tsai, linux-mmc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mmc/host/sunxi-mmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index d6fa2214aaae8..522b09d446494 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1168,7 +1168,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
}
}
- host->reset = devm_reset_control_get_optional(&pdev->dev, "ahb");
+ host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ "ahb");
if (PTR_ERR(host->reset) == -EPROBE_DEFER)
return PTR_ERR(host->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 041/102] mmc: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (40 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Adrian Hunter, Ulf Hansson, Thierry Reding,
Jonathan Hunter, linux-mmc, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-mmc@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mmc/host/sdhci-tegra.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 7f93079c7a3ad..f668a6fa17654 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -508,7 +508,8 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
clk_prepare_enable(clk);
pltfm_host->clk = clk;
- tegra_host->rst = devm_reset_control_get(&pdev->dev, "sdhci");
+ tegra_host->rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "sdhci");
if (IS_ERR(tegra_host->rst)) {
rc = PTR_ERR(tegra_host->rst);
dev_err(&pdev->dev, "failed to get reset control: %d\n", rc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 042/102] mtd: nand: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (41 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-20 7:00 ` Boris Brezillon
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Boris Brezillon, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
Maxime Ripard, Chen-Yu Tsai, linux-mtd
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mtd/nand/sunxi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
index d0b6f8f9f297a..6eb97451f485c 100644
--- a/drivers/mtd/nand/sunxi_nand.c
+++ b/drivers/mtd/nand/sunxi_nand.c
@@ -2208,7 +2208,7 @@ static int sunxi_nfc_probe(struct platform_device *pdev)
if (ret)
goto out_ahb_clk_unprepare;
- nfc->reset = devm_reset_control_get_optional(dev, "ahb");
+ nfc->reset = devm_reset_control_get_optional_exclusive(dev, "ahb");
if (IS_ERR(nfc->reset)) {
ret = PTR_ERR(nfc->reset);
goto out_mod_clk_unprepare;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 043/102] mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (42 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2018-05-18 20:03 ` Boris Brezillon
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Cyrille Pitchen, Marek Vasut, David Woodhouse,
Brian Norris, Boris Brezillon, Richard Weinberger,
Maxime Coquelin, Alexandre Torgue, linux-mtd
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
index 86c0931543c53..a367c56deb3cc 100644
--- a/drivers/mtd/spi-nor/stm32-quadspi.c
+++ b/drivers/mtd/spi-nor/stm32-quadspi.c
@@ -633,7 +633,7 @@ static int stm32_qspi_probe(struct platform_device *pdev)
return ret;
}
- rstc = devm_reset_control_get(dev, NULL);
+ rstc = devm_reset_control_get_exclusive(dev, NULL);
if (!IS_ERR(rstc)) {
reset_control_assert(rstc);
udelay(2);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 044/102] net: dsa: mt7530: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (43 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Andrew Lunn, Vivien Didelot, Florian Fainelli, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/dsa/mt7530.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 1e46418a3b74c..657d06b3c6c47 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1044,7 +1044,8 @@ mt7530_probe(struct mdio_device *mdiodev)
if (priv->mcm) {
dev_info(&mdiodev->dev, "MT7530 adapts as multi-chip module\n");
- priv->rstc = devm_reset_control_get(&mdiodev->dev, "mcm");
+ priv->rstc = devm_reset_control_get_exclusive(&mdiodev->dev,
+ "mcm");
if (IS_ERR(priv->rstc)) {
dev_err(&mdiodev->dev, "Couldn't get our reset line\n");
return PTR_ERR(priv->rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 045/102] net: ethernet: hisi_femac: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (44 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Yisen Zhuang, Salil Mehta, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/ethernet/hisilicon/hisi_femac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
index 2c2808830e957..10aa7590afd54 100644
--- a/drivers/net/ethernet/hisilicon/hisi_femac.c
+++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
@@ -838,14 +838,14 @@ static int hisi_femac_drv_probe(struct platform_device *pdev)
goto out_free_netdev;
}
- priv->mac_rst = devm_reset_control_get(dev, "mac");
+ priv->mac_rst = devm_reset_control_get_exclusive(dev, "mac");
if (IS_ERR(priv->mac_rst)) {
ret = PTR_ERR(priv->mac_rst);
goto out_disable_clk;
}
hisi_femac_core_reset(priv);
- priv->phy_rst = devm_reset_control_get(dev, "phy");
+ priv->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(priv->phy_rst)) {
priv->phy_rst = NULL;
} else {
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 046/102] net: ethernet: hix5hd2_gmac: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (45 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Yisen Zhuang, Salil Mehta, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
index 25a6c8722ecac..02b7e2f490099 100644
--- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
@@ -1161,16 +1161,16 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
goto out_disable_mac_core_clk;
}
- priv->mac_core_rst = devm_reset_control_get(dev, "mac_core");
+ priv->mac_core_rst = devm_reset_control_get_exclusive(dev, "mac_core");
if (IS_ERR(priv->mac_core_rst))
priv->mac_core_rst = NULL;
hix5hd2_mac_core_reset(priv);
- priv->mac_ifc_rst = devm_reset_control_get(dev, "mac_ifc");
+ priv->mac_ifc_rst = devm_reset_control_get_exclusive(dev, "mac_ifc");
if (IS_ERR(priv->mac_ifc_rst))
priv->mac_ifc_rst = NULL;
- priv->phy_rst = devm_reset_control_get(dev, "phy");
+ priv->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(priv->phy_rst)) {
priv->phy_rst = NULL;
} else {
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 047/102] net: stmmac: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (46 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Giuseppe Cavallaro, Alexandre Torgue,
Maxime Ripard, Chen-Yu Tsai, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++-
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index fffd6d5fc907b..2771369c105d6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -942,7 +942,8 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
return -EINVAL;
}
- gmac->rst_ephy = of_reset_control_get(plat_dat->phy_node, NULL);
+ gmac->rst_ephy = of_reset_control_get_exclusive(plat_dat->phy_node,
+ NULL);
if (IS_ERR(gmac->rst_ephy)) {
ret = PTR_ERR(gmac->rst_ephy);
if (ret == -EPROBE_DEFER)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index a366b3747eeb5..5f94bbf745546 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -526,8 +526,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
dev_dbg(&pdev->dev, "PTP rate %d\n", plat->clk_ptp_rate);
}
- plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
- STMMAC_RESOURCE_NAME);
+ plat->stmmac_rst = devm_reset_control_get_exclusive(&pdev->dev,
+ STMMAC_RESOURCE_NAME);
if (IS_ERR(plat->stmmac_rst)) {
if (PTR_ERR(plat->stmmac_rst) == -EPROBE_DEFER)
goto error_hw_init;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 048/102] net: stmmac: dwc-qos: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (47 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Giuseppe Cavallaro, Alexandre Torgue, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
index dd6a2f9791cc1..cf4e0f09c0361 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c
@@ -339,7 +339,7 @@ static void *tegra_eqos_probe(struct platform_device *pdev,
usleep_range(2000, 4000);
gpiod_set_value(eqos->reset, 0);
- eqos->rst = devm_reset_control_get(&pdev->dev, "eqos");
+ eqos->rst = devm_reset_control_get_exclusive(&pdev->dev, "eqos");
if (IS_ERR(eqos->rst)) {
err = PTR_ERR(eqos->rst);
goto reset_phy;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 049/102] ath10k: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Kalle Valo, ath10k, linux-wireless, netdev
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index da770af830369..2ad3ed7b89417 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -197,35 +197,40 @@ static int ath10k_ahb_rst_ctrl_init(struct ath10k *ar)
dev = &ar_ahb->pdev->dev;
- ar_ahb->core_cold_rst = devm_reset_control_get(dev, "wifi_core_cold");
+ ar_ahb->core_cold_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_core_cold");
if (IS_ERR(ar_ahb->core_cold_rst)) {
ath10k_err(ar, "failed to get core cold rst ctrl: %ld\n",
PTR_ERR(ar_ahb->core_cold_rst));
return PTR_ERR(ar_ahb->core_cold_rst);
}
- ar_ahb->radio_cold_rst = devm_reset_control_get(dev, "wifi_radio_cold");
+ ar_ahb->radio_cold_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_cold");
if (IS_ERR(ar_ahb->radio_cold_rst)) {
ath10k_err(ar, "failed to get radio cold rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_cold_rst));
return PTR_ERR(ar_ahb->radio_cold_rst);
}
- ar_ahb->radio_warm_rst = devm_reset_control_get(dev, "wifi_radio_warm");
+ ar_ahb->radio_warm_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_warm");
if (IS_ERR(ar_ahb->radio_warm_rst)) {
ath10k_err(ar, "failed to get radio warm rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_warm_rst));
return PTR_ERR(ar_ahb->radio_warm_rst);
}
- ar_ahb->radio_srif_rst = devm_reset_control_get(dev, "wifi_radio_srif");
+ ar_ahb->radio_srif_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_srif");
if (IS_ERR(ar_ahb->radio_srif_rst)) {
ath10k_err(ar, "failed to get radio srif rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_srif_rst));
return PTR_ERR(ar_ahb->radio_srif_rst);
}
- ar_ahb->cpu_init_rst = devm_reset_control_get(dev, "wifi_cpu_init");
+ ar_ahb->cpu_init_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_cpu_init");
if (IS_ERR(ar_ahb->cpu_init_rst)) {
ath10k_err(ar, "failed to get cpu init rst ctrl: %ld\n",
PTR_ERR(ar_ahb->cpu_init_rst));
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 049/102] ath10k: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, Kalle Valo, linux-wireless, ath10k, Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index da770af830369..2ad3ed7b89417 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -197,35 +197,40 @@ static int ath10k_ahb_rst_ctrl_init(struct ath10k *ar)
dev = &ar_ahb->pdev->dev;
- ar_ahb->core_cold_rst = devm_reset_control_get(dev, "wifi_core_cold");
+ ar_ahb->core_cold_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_core_cold");
if (IS_ERR(ar_ahb->core_cold_rst)) {
ath10k_err(ar, "failed to get core cold rst ctrl: %ld\n",
PTR_ERR(ar_ahb->core_cold_rst));
return PTR_ERR(ar_ahb->core_cold_rst);
}
- ar_ahb->radio_cold_rst = devm_reset_control_get(dev, "wifi_radio_cold");
+ ar_ahb->radio_cold_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_cold");
if (IS_ERR(ar_ahb->radio_cold_rst)) {
ath10k_err(ar, "failed to get radio cold rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_cold_rst));
return PTR_ERR(ar_ahb->radio_cold_rst);
}
- ar_ahb->radio_warm_rst = devm_reset_control_get(dev, "wifi_radio_warm");
+ ar_ahb->radio_warm_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_warm");
if (IS_ERR(ar_ahb->radio_warm_rst)) {
ath10k_err(ar, "failed to get radio warm rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_warm_rst));
return PTR_ERR(ar_ahb->radio_warm_rst);
}
- ar_ahb->radio_srif_rst = devm_reset_control_get(dev, "wifi_radio_srif");
+ ar_ahb->radio_srif_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_radio_srif");
if (IS_ERR(ar_ahb->radio_srif_rst)) {
ath10k_err(ar, "failed to get radio srif rst ctrl: %ld\n",
PTR_ERR(ar_ahb->radio_srif_rst));
return PTR_ERR(ar_ahb->radio_srif_rst);
}
- ar_ahb->cpu_init_rst = devm_reset_control_get(dev, "wifi_cpu_init");
+ ar_ahb->cpu_init_rst = devm_reset_control_get_exclusive(dev,
+ "wifi_cpu_init");
if (IS_ERR(ar_ahb->cpu_init_rst)) {
ath10k_err(ar, "failed to get cpu init rst ctrl: %ld\n",
PTR_ERR(ar_ahb->cpu_init_rst));
--
2.11.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 050/102] nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Srinivas Kandagatla, Joachim Eastwood, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index c81ae4c6da74c..6c7e2c424a4e8 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -197,7 +197,7 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(dev, NULL);
+ rst = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rst)) {
dev_err(dev, "failed to get reset: %ld\n", PTR_ERR(rst));
ret = PTR_ERR(rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 050/102] nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index c81ae4c6da74c..6c7e2c424a4e8 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -197,7 +197,7 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(dev, NULL);
+ rst = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rst)) {
dev_err(dev, "failed to get reset: %ld\n", PTR_ERR(rst));
ret = PTR_ERR(rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 051/102] PCI: dwc: pcie-qcom: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (50 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-08-03 21:40 ` Bjorn Helgaas
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Stanimir Varbanov, Bjorn Helgaas, linux-pci,
linux-arm-msm
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pci/dwc/pcie-qcom.c | 40 ++++++++++++++++++++++------------------
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 68c5f2ab5bc8f..90f7796a7cffe 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -212,23 +212,23 @@ static int qcom_pcie_get_resources_v0(struct qcom_pcie *pcie)
if (IS_ERR(res->phy_clk))
return PTR_ERR(res->phy_clk);
- res->pci_reset = devm_reset_control_get(dev, "pci");
+ res->pci_reset = devm_reset_control_get_exclusive(dev, "pci");
if (IS_ERR(res->pci_reset))
return PTR_ERR(res->pci_reset);
- res->axi_reset = devm_reset_control_get(dev, "axi");
+ res->axi_reset = devm_reset_control_get_exclusive(dev, "axi");
if (IS_ERR(res->axi_reset))
return PTR_ERR(res->axi_reset);
- res->ahb_reset = devm_reset_control_get(dev, "ahb");
+ res->ahb_reset = devm_reset_control_get_exclusive(dev, "ahb");
if (IS_ERR(res->ahb_reset))
return PTR_ERR(res->ahb_reset);
- res->por_reset = devm_reset_control_get(dev, "por");
+ res->por_reset = devm_reset_control_get_exclusive(dev, "por");
if (IS_ERR(res->por_reset))
return PTR_ERR(res->por_reset);
- res->phy_reset = devm_reset_control_get(dev, "phy");
+ res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
return PTR_ERR_OR_ZERO(res->phy_reset);
}
@@ -393,7 +393,7 @@ static int qcom_pcie_get_resources_v1(struct qcom_pcie *pcie)
if (IS_ERR(res->slave_bus))
return PTR_ERR(res->slave_bus);
- res->core = devm_reset_control_get(dev, "core");
+ res->core = devm_reset_control_get_exclusive(dev, "core");
return PTR_ERR_OR_ZERO(res->core);
}
@@ -623,51 +623,55 @@ static int qcom_pcie_get_resources_v3(struct qcom_pcie *pcie)
if (IS_ERR(res->slave_clk))
return PTR_ERR(res->slave_clk);
- res->axi_m_reset = devm_reset_control_get(dev, "axi_m");
+ res->axi_m_reset = devm_reset_control_get_exclusive(dev, "axi_m");
if (IS_ERR(res->axi_m_reset))
return PTR_ERR(res->axi_m_reset);
- res->axi_s_reset = devm_reset_control_get(dev, "axi_s");
+ res->axi_s_reset = devm_reset_control_get_exclusive(dev, "axi_s");
if (IS_ERR(res->axi_s_reset))
return PTR_ERR(res->axi_s_reset);
- res->pipe_reset = devm_reset_control_get(dev, "pipe");
+ res->pipe_reset = devm_reset_control_get_exclusive(dev, "pipe");
if (IS_ERR(res->pipe_reset))
return PTR_ERR(res->pipe_reset);
- res->axi_m_vmid_reset = devm_reset_control_get(dev, "axi_m_vmid");
+ res->axi_m_vmid_reset = devm_reset_control_get_exclusive(dev,
+ "axi_m_vmid");
if (IS_ERR(res->axi_m_vmid_reset))
return PTR_ERR(res->axi_m_vmid_reset);
- res->axi_s_xpu_reset = devm_reset_control_get(dev, "axi_s_xpu");
+ res->axi_s_xpu_reset = devm_reset_control_get_exclusive(dev,
+ "axi_s_xpu");
if (IS_ERR(res->axi_s_xpu_reset))
return PTR_ERR(res->axi_s_xpu_reset);
- res->parf_reset = devm_reset_control_get(dev, "parf");
+ res->parf_reset = devm_reset_control_get_exclusive(dev, "parf");
if (IS_ERR(res->parf_reset))
return PTR_ERR(res->parf_reset);
- res->phy_reset = devm_reset_control_get(dev, "phy");
+ res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(res->phy_reset))
return PTR_ERR(res->phy_reset);
- res->axi_m_sticky_reset = devm_reset_control_get(dev, "axi_m_sticky");
+ res->axi_m_sticky_reset = devm_reset_control_get_exclusive(dev,
+ "axi_m_sticky");
if (IS_ERR(res->axi_m_sticky_reset))
return PTR_ERR(res->axi_m_sticky_reset);
- res->pipe_sticky_reset = devm_reset_control_get(dev, "pipe_sticky");
+ res->pipe_sticky_reset = devm_reset_control_get_exclusive(dev,
+ "pipe_sticky");
if (IS_ERR(res->pipe_sticky_reset))
return PTR_ERR(res->pipe_sticky_reset);
- res->pwr_reset = devm_reset_control_get(dev, "pwr");
+ res->pwr_reset = devm_reset_control_get_exclusive(dev, "pwr");
if (IS_ERR(res->pwr_reset))
return PTR_ERR(res->pwr_reset);
- res->ahb_reset = devm_reset_control_get(dev, "ahb");
+ res->ahb_reset = devm_reset_control_get_exclusive(dev, "ahb");
if (IS_ERR(res->ahb_reset))
return PTR_ERR(res->ahb_reset);
- res->phy_ahb_reset = devm_reset_control_get(dev, "phy_ahb");
+ res->phy_ahb_reset = devm_reset_control_get_exclusive(dev, "phy_ahb");
if (IS_ERR(res->phy_ahb_reset))
return PTR_ERR(res->phy_ahb_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 052/102] PCI: imx6: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (51 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
2017-08-03 21:41 ` Bjorn Helgaas
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Richard Zhu, Lucas Stach, Bjorn Helgaas, linux-pci
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pci/dwc/pci-imx6.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index bf5c3616e3448..5a2ece394ad39 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -778,14 +778,15 @@ static int imx6_pcie_probe(struct platform_device *pdev)
}
break;
case IMX7D:
- imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
- "pciephy");
+ imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev,
+ "pciephy");
if (IS_ERR(imx6_pcie->pciephy_reset)) {
dev_err(dev, "Failed to get PCIEPHY reset control\n");
return PTR_ERR(imx6_pcie->pciephy_reset);
}
- imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
+ imx6_pcie->apps_reset = devm_reset_control_get_exclusive(dev,
+ "apps");
if (IS_ERR(imx6_pcie->apps_reset)) {
dev_err(dev, "Failed to get PCIE APPS reset control\n");
return PTR_ERR(imx6_pcie->apps_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 053/102] PCI: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (52 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
[not found] ` <20170719152646.25903-54-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Thierry Reding, Bjorn Helgaas, Jonathan Hunter,
linux-tegra, linux-pci
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pci/host/pci-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index b3722b7709df8..a64bd0a191767 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -1147,15 +1147,15 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)
{
struct device *dev = pcie->dev;
- pcie->pex_rst = devm_reset_control_get(dev, "pex");
+ pcie->pex_rst = devm_reset_control_get_exclusive(dev, "pex");
if (IS_ERR(pcie->pex_rst))
return PTR_ERR(pcie->pex_rst);
- pcie->afi_rst = devm_reset_control_get(dev, "afi");
+ pcie->afi_rst = devm_reset_control_get_exclusive(dev, "afi");
if (IS_ERR(pcie->afi_rst))
return PTR_ERR(pcie->afi_rst);
- pcie->pcie_xrst = devm_reset_control_get(dev, "pcie_x");
+ pcie->pcie_xrst = devm_reset_control_get_exclusive(dev, "pcie_x");
if (IS_ERR(pcie->pcie_xrst))
return PTR_ERR(pcie->pcie_xrst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Shawn Lin, Bjorn Helgaas, Heiko Stuebner,
linux-pci, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-pci@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 7bb9870f6d8ce..e50d6f5a81f4b 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -903,49 +903,50 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
if (rockchip->link_gen < 0 || rockchip->link_gen > 2)
rockchip->link_gen = 2;
- rockchip->core_rst = devm_reset_control_get(dev, "core");
+ rockchip->core_rst = devm_reset_control_get_exclusive(dev, "core");
if (IS_ERR(rockchip->core_rst)) {
if (PTR_ERR(rockchip->core_rst) != -EPROBE_DEFER)
dev_err(dev, "missing core reset property in node\n");
return PTR_ERR(rockchip->core_rst);
}
- rockchip->mgmt_rst = devm_reset_control_get(dev, "mgmt");
+ rockchip->mgmt_rst = devm_reset_control_get_exclusive(dev, "mgmt");
if (IS_ERR(rockchip->mgmt_rst)) {
if (PTR_ERR(rockchip->mgmt_rst) != -EPROBE_DEFER)
dev_err(dev, "missing mgmt reset property in node\n");
return PTR_ERR(rockchip->mgmt_rst);
}
- rockchip->mgmt_sticky_rst = devm_reset_control_get(dev, "mgmt-sticky");
+ rockchip->mgmt_sticky_rst = devm_reset_control_get_exclusive(dev,
+ "mgmt-sticky");
if (IS_ERR(rockchip->mgmt_sticky_rst)) {
if (PTR_ERR(rockchip->mgmt_sticky_rst) != -EPROBE_DEFER)
dev_err(dev, "missing mgmt-sticky reset property in node\n");
return PTR_ERR(rockchip->mgmt_sticky_rst);
}
- rockchip->pipe_rst = devm_reset_control_get(dev, "pipe");
+ rockchip->pipe_rst = devm_reset_control_get_exclusive(dev, "pipe");
if (IS_ERR(rockchip->pipe_rst)) {
if (PTR_ERR(rockchip->pipe_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pipe reset property in node\n");
return PTR_ERR(rockchip->pipe_rst);
}
- rockchip->pm_rst = devm_reset_control_get(dev, "pm");
+ rockchip->pm_rst = devm_reset_control_get_exclusive(dev, "pm");
if (IS_ERR(rockchip->pm_rst)) {
if (PTR_ERR(rockchip->pm_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pm reset property in node\n");
return PTR_ERR(rockchip->pm_rst);
}
- rockchip->pclk_rst = devm_reset_control_get(dev, "pclk");
+ rockchip->pclk_rst = devm_reset_control_get_exclusive(dev, "pclk");
if (IS_ERR(rockchip->pclk_rst)) {
if (PTR_ERR(rockchip->pclk_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pclk reset property in node\n");
return PTR_ERR(rockchip->pclk_rst);
}
- rockchip->aclk_rst = devm_reset_control_get(dev, "aclk");
+ rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
if (IS_ERR(rockchip->aclk_rst)) {
if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
dev_err(dev, "missing aclk reset property in node\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
@ 2017-07-19 15:25 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Heiko Stuebner, linux-pci-u79uwXL29TY76Z2rM5mHXA, Shawn Lin,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Philipp Zabel,
Bjorn Helgaas
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
index 7bb9870f6d8ce..e50d6f5a81f4b 100644
--- a/drivers/pci/host/pcie-rockchip.c
+++ b/drivers/pci/host/pcie-rockchip.c
@@ -903,49 +903,50 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
if (rockchip->link_gen < 0 || rockchip->link_gen > 2)
rockchip->link_gen = 2;
- rockchip->core_rst = devm_reset_control_get(dev, "core");
+ rockchip->core_rst = devm_reset_control_get_exclusive(dev, "core");
if (IS_ERR(rockchip->core_rst)) {
if (PTR_ERR(rockchip->core_rst) != -EPROBE_DEFER)
dev_err(dev, "missing core reset property in node\n");
return PTR_ERR(rockchip->core_rst);
}
- rockchip->mgmt_rst = devm_reset_control_get(dev, "mgmt");
+ rockchip->mgmt_rst = devm_reset_control_get_exclusive(dev, "mgmt");
if (IS_ERR(rockchip->mgmt_rst)) {
if (PTR_ERR(rockchip->mgmt_rst) != -EPROBE_DEFER)
dev_err(dev, "missing mgmt reset property in node\n");
return PTR_ERR(rockchip->mgmt_rst);
}
- rockchip->mgmt_sticky_rst = devm_reset_control_get(dev, "mgmt-sticky");
+ rockchip->mgmt_sticky_rst = devm_reset_control_get_exclusive(dev,
+ "mgmt-sticky");
if (IS_ERR(rockchip->mgmt_sticky_rst)) {
if (PTR_ERR(rockchip->mgmt_sticky_rst) != -EPROBE_DEFER)
dev_err(dev, "missing mgmt-sticky reset property in node\n");
return PTR_ERR(rockchip->mgmt_sticky_rst);
}
- rockchip->pipe_rst = devm_reset_control_get(dev, "pipe");
+ rockchip->pipe_rst = devm_reset_control_get_exclusive(dev, "pipe");
if (IS_ERR(rockchip->pipe_rst)) {
if (PTR_ERR(rockchip->pipe_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pipe reset property in node\n");
return PTR_ERR(rockchip->pipe_rst);
}
- rockchip->pm_rst = devm_reset_control_get(dev, "pm");
+ rockchip->pm_rst = devm_reset_control_get_exclusive(dev, "pm");
if (IS_ERR(rockchip->pm_rst)) {
if (PTR_ERR(rockchip->pm_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pm reset property in node\n");
return PTR_ERR(rockchip->pm_rst);
}
- rockchip->pclk_rst = devm_reset_control_get(dev, "pclk");
+ rockchip->pclk_rst = devm_reset_control_get_exclusive(dev, "pclk");
if (IS_ERR(rockchip->pclk_rst)) {
if (PTR_ERR(rockchip->pclk_rst) != -EPROBE_DEFER)
dev_err(dev, "missing pclk reset property in node\n");
return PTR_ERR(rockchip->pclk_rst);
}
- rockchip->aclk_rst = devm_reset_control_get(dev, "aclk");
+ rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
if (IS_ERR(rockchip->aclk_rst)) {
if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
dev_err(dev, "missing aclk reset property in node\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 055/102] phy: berlin-usb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (54 preceding siblings ...)
(?)
@ 2017-07-19 15:25 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/marvell/phy-berlin-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy/marvell/phy-berlin-usb.c
index 2017751ede263..d4473ecd1f6b8 100644
--- a/drivers/phy/marvell/phy-berlin-usb.c
+++ b/drivers/phy/marvell/phy-berlin-usb.c
@@ -181,7 +181,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
- priv->rst_ctrl = devm_reset_control_get(&pdev->dev, NULL);
+ priv->rst_ctrl = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(priv->rst_ctrl))
return PTR_ERR(priv->rst_ctrl);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 056/102] PCI: mediatek: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Ryder Lee, Bjorn Helgaas, Matthias Brugger,
linux-pci, linux-mediatek
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pci/host/pcie-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index 5a9d8589ea0bd..9c9f89bcf24ce 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -303,7 +303,7 @@ static int mtk_pcie_parse_ports(struct mtk_pcie *pcie,
}
snprintf(name, sizeof(name), "pcie-rst%d", index);
- port->reset = devm_reset_control_get_optional(dev, name);
+ port->reset = devm_reset_control_get_optional_exclusive(dev, name);
if (PTR_ERR(port->reset) == -EPROBE_DEFER)
return PTR_ERR(port->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 056/102] PCI: mediatek: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Ryder Lee, linux-pci-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Philipp Zabel,
Bjorn Helgaas
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/pci/host/pcie-mediatek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index 5a9d8589ea0bd..9c9f89bcf24ce 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -303,7 +303,7 @@ static int mtk_pcie_parse_ports(struct mtk_pcie *pcie,
}
snprintf(name, sizeof(name), "pcie-rst%d", index);
- port->reset = devm_reset_control_get_optional(dev, name);
+ port->reset = devm_reset_control_get_optional_exclusive(dev, name);
if (PTR_ERR(port->reset) == -EPROBE_DEFER)
return PTR_ERR(port->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 057/102] phy: qcom-usb-hs: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (56 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hs.c b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
index 4b20abc3ae2f5..d56dd526feec0 100644
--- a/drivers/phy/qualcomm/phy-qcom-usb-hs.c
+++ b/drivers/phy/qualcomm/phy-qcom-usb-hs.c
@@ -250,7 +250,8 @@ static int qcom_usb_hs_phy_probe(struct ulpi *ulpi)
if (IS_ERR(reg))
return PTR_ERR(reg);
- uphy->reset = reset = devm_reset_control_get(&ulpi->dev, "por");
+ uphy->reset = reset = devm_reset_control_get_exclusive(&ulpi->dev,
+ "por");
if (IS_ERR(reset)) {
if (PTR_ERR(reset) == -EPROBE_DEFER)
return PTR_ERR(reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Heiko Stuebner, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
index 6904633cad687..258220b7f481c 100644
--- a/drivers/phy/rockchip/phy-rockchip-pcie.c
+++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
@@ -305,7 +305,7 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
rk_phy->phy_data = (struct rockchip_pcie_data *)of_id->data;
rk_phy->reg_base = grf;
- rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
+ rk_phy->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(rk_phy->phy_rst)) {
if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
dev_err(dev,
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Heiko Stuebner,
Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
index 6904633cad687..258220b7f481c 100644
--- a/drivers/phy/rockchip/phy-rockchip-pcie.c
+++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
@@ -305,7 +305,7 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
rk_phy->phy_data = (struct rockchip_pcie_data *)of_id->data;
rk_phy->reg_base = grf;
- rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
+ rk_phy->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(rk_phy->phy_rst)) {
if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
dev_err(dev,
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 059/102] phy: rockchip-typec: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Heiko Stuebner, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 7cfb0f8995de8..caf046e1348d1 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -888,19 +888,19 @@ static int tcphy_parse_dt(struct rockchip_typec_phy *tcphy,
return PTR_ERR(tcphy->clk_ref);
}
- tcphy->uphy_rst = devm_reset_control_get(dev, "uphy");
+ tcphy->uphy_rst = devm_reset_control_get_exclusive(dev, "uphy");
if (IS_ERR(tcphy->uphy_rst)) {
dev_err(dev, "no uphy_rst reset control found\n");
return PTR_ERR(tcphy->uphy_rst);
}
- tcphy->pipe_rst = devm_reset_control_get(dev, "uphy-pipe");
+ tcphy->pipe_rst = devm_reset_control_get_exclusive(dev, "uphy-pipe");
if (IS_ERR(tcphy->pipe_rst)) {
dev_err(dev, "no pipe_rst reset control found\n");
return PTR_ERR(tcphy->pipe_rst);
}
- tcphy->tcphy_rst = devm_reset_control_get(dev, "uphy-tcphy");
+ tcphy->tcphy_rst = devm_reset_control_get_exclusive(dev, "uphy-tcphy");
if (IS_ERR(tcphy->tcphy_rst)) {
dev_err(dev, "no tcphy_rst reset control found\n");
return PTR_ERR(tcphy->tcphy_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 059/102] phy: rockchip-typec: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Heiko Stuebner,
Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 7cfb0f8995de8..caf046e1348d1 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -888,19 +888,19 @@ static int tcphy_parse_dt(struct rockchip_typec_phy *tcphy,
return PTR_ERR(tcphy->clk_ref);
}
- tcphy->uphy_rst = devm_reset_control_get(dev, "uphy");
+ tcphy->uphy_rst = devm_reset_control_get_exclusive(dev, "uphy");
if (IS_ERR(tcphy->uphy_rst)) {
dev_err(dev, "no uphy_rst reset control found\n");
return PTR_ERR(tcphy->uphy_rst);
}
- tcphy->pipe_rst = devm_reset_control_get(dev, "uphy-pipe");
+ tcphy->pipe_rst = devm_reset_control_get_exclusive(dev, "uphy-pipe");
if (IS_ERR(tcphy->pipe_rst)) {
dev_err(dev, "no pipe_rst reset control found\n");
return PTR_ERR(tcphy->pipe_rst);
}
- tcphy->tcphy_rst = devm_reset_control_get(dev, "uphy-tcphy");
+ tcphy->tcphy_rst = devm_reset_control_get_exclusive(dev, "uphy-tcphy");
if (IS_ERR(tcphy->tcphy_rst)) {
dev_err(dev, "no tcphy_rst reset control found\n");
return PTR_ERR(tcphy->tcphy_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 060/102] phy: rockchip-usb: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Heiko Stuebner, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-usb.c b/drivers/phy/rockchip/phy-rockchip-usb.c
index 3378eeb7a562f..e8907ab926401 100644
--- a/drivers/phy/rockchip/phy-rockchip-usb.c
+++ b/drivers/phy/rockchip/phy-rockchip-usb.c
@@ -213,7 +213,7 @@ static int rockchip_usb_phy_init(struct rockchip_usb_phy_base *base,
return -EINVAL;
}
- rk_phy->reset = of_reset_control_get(child, "phy-reset");
+ rk_phy->reset = of_reset_control_get_exclusive(child, "phy-reset");
if (IS_ERR(rk_phy->reset))
rk_phy->reset = NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 060/102] phy: rockchip-usb: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Heiko Stuebner,
Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-usb.c b/drivers/phy/rockchip/phy-rockchip-usb.c
index 3378eeb7a562f..e8907ab926401 100644
--- a/drivers/phy/rockchip/phy-rockchip-usb.c
+++ b/drivers/phy/rockchip/phy-rockchip-usb.c
@@ -213,7 +213,7 @@ static int rockchip_usb_phy_init(struct rockchip_usb_phy_base *base,
return -EINVAL;
}
- rk_phy->reset = of_reset_control_get(child, "phy-reset");
+ rk_phy->reset = of_reset_control_get_exclusive(child, "phy-reset");
if (IS_ERR(rk_phy->reset))
rk_phy->reset = NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 061/102] phy: sun4i-usb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Maxime Ripard,
Chen-Yu Tsai, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
index bbf06cfe5898c..6b3c76e279c9b 100644
--- a/drivers/phy/allwinner/phy-sun4i-usb.c
+++ b/drivers/phy/allwinner/phy-sun4i-usb.c
@@ -707,7 +707,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
}
snprintf(name, sizeof(name), "usb%d_reset", i);
- phy->reset = devm_reset_control_get(dev, name);
+ phy->reset = devm_reset_control_get_exclusive(dev, name);
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset %s\n", name);
return PTR_ERR(phy->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 061/102] phy: sun4i-usb: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
index bbf06cfe5898c..6b3c76e279c9b 100644
--- a/drivers/phy/allwinner/phy-sun4i-usb.c
+++ b/drivers/phy/allwinner/phy-sun4i-usb.c
@@ -707,7 +707,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
}
snprintf(name, sizeof(name), "usb%d_reset", i);
- phy->reset = devm_reset_control_get(dev, name);
+ phy->reset = devm_reset_control_get_exclusive(dev, name);
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset %s\n", name);
return PTR_ERR(phy->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 062/102] phy: sun9i-usb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Maxime Ripard,
Chen-Yu Tsai, linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/allwinner/phy-sun9i-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/allwinner/phy-sun9i-usb.c b/drivers/phy/allwinner/phy-sun9i-usb.c
index 28fce4bce638e..a07aa04a88ed8 100644
--- a/drivers/phy/allwinner/phy-sun9i-usb.c
+++ b/drivers/phy/allwinner/phy-sun9i-usb.c
@@ -146,7 +146,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev)
return PTR_ERR(phy->hsic_clk);
}
- phy->reset = devm_reset_control_get(dev, "hsic");
+ phy->reset = devm_reset_control_get_exclusive(dev, "hsic");
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset control\n");
return PTR_ERR(phy->reset);
@@ -158,7 +158,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev)
return PTR_ERR(phy->clk);
}
- phy->reset = devm_reset_control_get(dev, "phy");
+ phy->reset = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset control\n");
return PTR_ERR(phy->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 062/102] phy: sun9i-usb: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-arm-kernel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/allwinner/phy-sun9i-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/allwinner/phy-sun9i-usb.c b/drivers/phy/allwinner/phy-sun9i-usb.c
index 28fce4bce638e..a07aa04a88ed8 100644
--- a/drivers/phy/allwinner/phy-sun9i-usb.c
+++ b/drivers/phy/allwinner/phy-sun9i-usb.c
@@ -146,7 +146,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev)
return PTR_ERR(phy->hsic_clk);
}
- phy->reset = devm_reset_control_get(dev, "hsic");
+ phy->reset = devm_reset_control_get_exclusive(dev, "hsic");
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset control\n");
return PTR_ERR(phy->reset);
@@ -158,7 +158,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev)
return PTR_ERR(phy->clk);
}
- phy->reset = devm_reset_control_get(dev, "phy");
+ phy->reset = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(phy->reset)) {
dev_err(dev, "failed to get reset control\n");
return PTR_ERR(phy->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 063/102] phy: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (62 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Kishon Vijay Abraham I, Thierry Reding,
Jonathan Hunter, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/tegra/xusb-tegra210.c | 4 ++--
drivers/phy/tegra/xusb.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c
index 9d0689ebd28c6..9a9ea17218900 100644
--- a/drivers/phy/tegra/xusb-tegra210.c
+++ b/drivers/phy/tegra/xusb-tegra210.c
@@ -1557,7 +1557,7 @@ tegra210_pcie_pad_probe(struct tegra_xusb_padctl *padctl,
goto unregister;
}
- pcie->rst = devm_reset_control_get(&pad->dev, "phy");
+ pcie->rst = devm_reset_control_get_exclusive(&pad->dev, "phy");
if (IS_ERR(pcie->rst)) {
err = PTR_ERR(pcie->rst);
dev_err(&pad->dev, "failed to get PCIe pad reset: %d\n", err);
@@ -1721,7 +1721,7 @@ tegra210_sata_pad_probe(struct tegra_xusb_padctl *padctl,
goto out;
}
- sata->rst = devm_reset_control_get(&pad->dev, "phy");
+ sata->rst = devm_reset_control_get_exclusive(&pad->dev, "phy");
if (IS_ERR(sata->rst)) {
err = PTR_ERR(sata->rst);
dev_err(&pad->dev, "failed to get SATA pad reset: %d\n", err);
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 3cbcb25376576..3b729fa27cf35 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -881,7 +881,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
goto remove;
}
- padctl->rst = devm_reset_control_get(&pdev->dev, NULL);
+ padctl->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(padctl->rst)) {
err = PTR_ERR(padctl->rst);
goto remove;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 064/102] phy: qcom-qmp: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (63 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 78ca62897784a..9f8bcf7743ddf 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -868,7 +868,7 @@ static int qcom_qmp_phy_reset_init(struct device *dev)
struct reset_control *rst;
const char *name = qmp->cfg->reset_list[i];
- rst = devm_reset_control_get(dev, name);
+ rst = devm_reset_control_get_exclusive(dev, name);
if (IS_ERR(rst)) {
dev_err(dev, "failed to get %s reset\n", name);
return PTR_ERR(rst);
@@ -1019,7 +1019,7 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id)
/* Get lane reset, if any */
if (qmp->cfg->has_lane_rst) {
snprintf(prop_name, sizeof(prop_name), "lane%d", id);
- qphy->lane_rst = of_reset_control_get(np, prop_name);
+ qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name);
if (IS_ERR(qphy->lane_rst)) {
dev_err(dev, "failed to get lane%d reset\n", id);
return PTR_ERR(qphy->lane_rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 065/102] phy: qcom-qusb2: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (64 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Kishon Vijay Abraham I
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 6c575244c0fb9..b7c6984ed5259 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -426,7 +426,8 @@ static int qusb2_phy_probe(struct platform_device *pdev)
dev_dbg(dev, "failed to get iface clk, %d\n", ret);
}
- qphy->phy_reset = devm_reset_control_get_by_index(&pdev->dev, 0);
+ qphy->phy_reset = devm_reset_control_get_exclusive_by_index(&pdev->dev,
+ 0);
if (IS_ERR(qphy->phy_reset)) {
dev_err(dev, "failed to get phy core reset\n");
return PTR_ERR(qphy->phy_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 066/102] pinctrl: stm32: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (65 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-08-02 11:43 ` Linus Walleij
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Linus Walleij, Maxime Coquelin, Alexandre Torgue,
linux-gpio
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c
index 06431ff49ffb2..50299ad966590 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.c
@@ -952,7 +952,7 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl,
int npins = STM32_GPIO_PINS_PER_BANK;
int bank_nr, err;
- rstc = of_reset_control_get(np, NULL);
+ rstc = of_reset_control_get_exclusive(np, NULL);
if (!IS_ERR(rstc))
reset_control_deassert(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 067/102] pinctrl: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (66 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-08-02 11:44 ` Linus Walleij
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Maxime Ripard, Chen-Yu Tsai, Linus Walleij, linux-gpio
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c b/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c
index a22bd88a1f03e..92c0ddc652959 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c
@@ -113,7 +113,7 @@ static int sun6i_a31_r_pinctrl_probe(struct platform_device *pdev)
struct reset_control *rstc;
int ret;
- rstc = devm_reset_control_get(&pdev->dev, NULL);
+ rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rstc)) {
dev_err(&pdev->dev, "Reset controller missing\n");
return PTR_ERR(rstc);
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
index 2292e05a397b4..2e113ca78f959 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c
@@ -100,7 +100,7 @@ static int sun8i_a23_r_pinctrl_probe(struct platform_device *pdev)
struct reset_control *rstc;
int ret;
- rstc = devm_reset_control_get(&pdev->dev, NULL);
+ rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(rstc)) {
dev_err(&pdev->dev, "Reset controller missing\n");
return PTR_ERR(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 068/102] pinctrl: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (67 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
[not found] ` <20170719152646.25903-69-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Linus Walleij, Thierry Reding, Jonathan Hunter,
linux-gpio, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
index ebedc2d324115..9d653c24219cb 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
@@ -901,7 +901,7 @@ int tegra_xusb_padctl_legacy_probe(struct platform_device *pdev)
if (IS_ERR(padctl->regs))
return PTR_ERR(padctl->regs);
- padctl->rst = devm_reset_control_get(&pdev->dev, NULL);
+ padctl->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(padctl->rst))
return PTR_ERR(padctl->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 069/102] pwm: hibvt: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (68 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-08-21 6:54 ` Thierry Reding
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Thierry Reding, linux-pwm
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pwm/pwm-hibvt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c
index 8dadc58d6cdfe..27c107e78d59a 100644
--- a/drivers/pwm/pwm-hibvt.c
+++ b/drivers/pwm/pwm-hibvt.c
@@ -208,7 +208,7 @@ static int hibvt_pwm_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- pwm_chip->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ pwm_chip->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(pwm_chip->rstc)) {
clk_disable_unprepare(pwm_chip->clk);
return PTR_ERR(pwm_chip->rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 070/102] pwm: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Thierry Reding, Jonathan Hunter,
linux-pwm-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/pwm/pwm-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index e9b33f09ff096..f8ebbece57b71 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -218,7 +218,7 @@ static int tegra_pwm_probe(struct platform_device *pdev)
*/
pwm->clk_rate = clk_get_rate(pwm->clk);
- pwm->rst = devm_reset_control_get(&pdev->dev, "pwm");
+ pwm->rst = devm_reset_control_get_exclusive(&pdev->dev, "pwm");
if (IS_ERR(pwm->rst)) {
ret = PTR_ERR(pwm->rst);
dev_err(&pdev->dev, "Reset control is not found: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 070/102] pwm: tegra: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Thierry Reding, Jonathan Hunter, linux-pwm, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pwm@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/pwm/pwm-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index e9b33f09ff096..f8ebbece57b71 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -218,7 +218,7 @@ static int tegra_pwm_probe(struct platform_device *pdev)
*/
pwm->clk_rate = clk_get_rate(pwm->clk);
- pwm->rst = devm_reset_control_get(&pdev->dev, "pwm");
+ pwm->rst = devm_reset_control_get_exclusive(&pdev->dev, "pwm");
if (IS_ERR(pwm->rst)) {
ret = PTR_ERR(pwm->rst);
dev_err(&pdev->dev, "Reset control is not found: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (69 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:59 ` Suman Anna
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/remoteproc/keystone_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
index 5f776bfd674a0..920fef072b364 100644
--- a/drivers/remoteproc/keystone_remoteproc.c
+++ b/drivers/remoteproc/keystone_remoteproc.c
@@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;
- ksproc->reset = devm_reset_control_get(dev, NULL);
+ ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(ksproc->reset)) {
ret = PTR_ERR(ksproc->reset);
goto free_rproc;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 072/102] remoteproc: qcom: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (70 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/remoteproc/qcom_q6v5_pil.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
index 8fd697a3cf8f9..f156dfc463d85 100644
--- a/drivers/remoteproc/qcom_q6v5_pil.c
+++ b/drivers/remoteproc/qcom_q6v5_pil.c
@@ -867,7 +867,8 @@ static int q6v5_init_clocks(struct device *dev, struct clk **clks,
static int q6v5_init_reset(struct q6v5 *qproc)
{
- qproc->mss_restart = devm_reset_control_get(qproc->dev, NULL);
+ qproc->mss_restart = devm_reset_control_get_exclusive(qproc->dev,
+ NULL);
if (IS_ERR(qproc->mss_restart)) {
dev_err(qproc->dev, "failed to acquire mss restart\n");
return PTR_ERR(qproc->mss_restart);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 073/102] remoteproc: st: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (71 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Patrice Chotard, Ohad Ben-Cohen, Bjorn Andersson,
linux-remoteproc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/remoteproc/st_remoteproc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
index d534bf23dc560..aacef0ea3b902 100644
--- a/drivers/remoteproc/st_remoteproc.c
+++ b/drivers/remoteproc/st_remoteproc.c
@@ -212,7 +212,8 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
int err;
if (ddata->config->sw_reset) {
- ddata->sw_reset = devm_reset_control_get(dev, "sw_reset");
+ ddata->sw_reset = devm_reset_control_get_exclusive(dev,
+ "sw_reset");
if (IS_ERR(ddata->sw_reset)) {
dev_err(dev, "Failed to get S/W Reset\n");
return PTR_ERR(ddata->sw_reset);
@@ -220,7 +221,8 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
}
if (ddata->config->pwr_reset) {
- ddata->pwr_reset = devm_reset_control_get(dev, "pwr_reset");
+ ddata->pwr_reset = devm_reset_control_get_exclusive(dev,
+ "pwr_reset");
if (IS_ERR(ddata->pwr_reset)) {
dev_err(dev, "Failed to get Power Reset\n");
return PTR_ERR(ddata->pwr_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 074/102] soc: mediatek: PMIC wrap: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (72 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Matthias Brugger, linux-mediatek
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/soc/mediatek/mtk-pmic-wrap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index c80a04e1b2b16..05496ba674517 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1145,7 +1145,7 @@ static int pwrap_probe(struct platform_device *pdev)
if (IS_ERR(wrp->base))
return PTR_ERR(wrp->base);
- wrp->rstc = devm_reset_control_get(wrp->dev, "pwrap");
+ wrp->rstc = devm_reset_control_get_exclusive(wrp->dev, "pwrap");
if (IS_ERR(wrp->rstc)) {
ret = PTR_ERR(wrp->rstc);
dev_dbg(wrp->dev, "cannot get pwrap reset: %d\n", ret);
@@ -1159,7 +1159,8 @@ static int pwrap_probe(struct platform_device *pdev)
if (IS_ERR(wrp->bridge_base))
return PTR_ERR(wrp->bridge_base);
- wrp->rstc_bridge = devm_reset_control_get(wrp->dev, "pwrap-bridge");
+ wrp->rstc_bridge = devm_reset_control_get_exclusive(wrp->dev,
+ "pwrap-bridge");
if (IS_ERR(wrp->rstc_bridge)) {
ret = PTR_ERR(wrp->rstc_bridge);
dev_dbg(wrp->dev, "cannot get pwrap-bridge reset: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 075/102] soc/tegra: pmc: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (73 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Thierry Reding, Jonathan Hunter, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/soc/tegra/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index e233dd5dcab3d..ee2c3482e9242 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -768,7 +768,7 @@ static int tegra_powergate_of_get_resets(struct tegra_powergate *pg,
return -ENOMEM;
for (i = 0; i < count; i++) {
- pg->resets[i] = of_reset_control_get_by_index(np, i);
+ pg->resets[i] = of_reset_control_get_exclusive_by_index(np, i);
if (IS_ERR(pg->resets[i])) {
err = PTR_ERR(pg->resets[i]);
goto error;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 076/102] spi: stm32: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (74 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "spi: stm32: explicitly request exclusive reset control" to the spi tree Mark Brown
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Mark Brown, Maxime Coquelin, Alexandre Torgue, linux-spi
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-spi@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/spi/spi-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 75644bcd938b6..680cdf5495061 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1132,7 +1132,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
goto err_master_put;
}
- spi->rst = devm_reset_control_get(&pdev->dev, NULL);
+ spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(spi->rst)) {
reset_control_assert(spi->rst);
udelay(2);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 077/102] spi: sun6i: explicitly request exclusive reset control
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Mark Brown, Maxime Ripard, Chen-Yu Tsai, linux-spi
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-spi@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/spi/spi-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 03a773a9531a9..fb38234249a80 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -502,7 +502,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
init_completion(&sspi->done);
- sspi->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ sspi->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(sspi->rstc)) {
dev_err(&pdev->dev, "Couldn't get reset controller\n");
ret = PTR_ERR(sspi->rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 077/102] spi: sun6i: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Mark Brown, Maxime Ripard, Chen-Yu Tsai,
linux-spi-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/spi/spi-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 03a773a9531a9..fb38234249a80 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -502,7 +502,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
init_completion(&sspi->done);
- sspi->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ sspi->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(sspi->rstc)) {
dev_err(&pdev->dev, "Couldn't get reset controller\n");
ret = PTR_ERR(sspi->rstc);
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 078/102] spi: tegra20-slink: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/spi/spi-tegra20-slink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 0c06ce424210a..3e12d5f87ee44 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1081,7 +1081,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 078/102] spi: tegra20-slink: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/spi/spi-tegra20-slink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 0c06ce424210a..3e12d5f87ee44 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1081,7 +1081,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 079/102] spi: tegra114: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/spi/spi-tegra114.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 08012ae5aa66e..44550182a4a36 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1083,7 +1083,7 @@ static int tegra_spi_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 079/102] spi: tegra114: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/spi/spi-tegra114.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 08012ae5aa66e..44550182a4a36 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1083,7 +1083,7 @@ static int tegra_spi_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 080/102] spi: tegra20-sflash: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/spi/spi-tegra20-sflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 2c797ee2664de..22893a7e0aa0e 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -485,7 +485,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tsd->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tsd->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tsd->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tsd->rst);
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 080/102] spi: tegra20-sflash: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Mark Brown, Thierry Reding,
Jonathan Hunter, linux-spi, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/spi/spi-tegra20-sflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 2c797ee2664de..22893a7e0aa0e 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -485,7 +485,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tsd->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tsd->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tsd->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tsd->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 081/102] staging: nvec: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-tegra, Greg Kroah-Hartman, devel, Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-tegra@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/staging/nvec/nvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index c1feccf8d94af..4ff8f47385dae 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -831,7 +831,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
return -ENODEV;
}
- nvec->rst = devm_reset_control_get(&pdev->dev, "i2c");
+ nvec->rst = devm_reset_control_get_exclusive(&pdev->dev, "i2c");
if (IS_ERR(nvec->rst)) {
dev_err(nvec->dev, "failed to get controller reset\n");
return PTR_ERR(nvec->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 081/102] staging: nvec: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Marc Dietrich, Greg Kroah-Hartman, linux-tegra, devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-tegra@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/staging/nvec/nvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index c1feccf8d94af..4ff8f47385dae 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -831,7 +831,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
return -ENODEV;
}
- nvec->rst = devm_reset_control_get(&pdev->dev, "i2c");
+ nvec->rst = devm_reset_control_get_exclusive(&pdev->dev, "i2c");
if (IS_ERR(nvec->rst)) {
dev_err(nvec->dev, "failed to get controller reset\n");
return PTR_ERR(nvec->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 082/102] thermal: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (77 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Zhang Rui, Eduardo Valentin, Heiko Stuebner,
linux-pm, linux-rockchip
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-pm@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/thermal/rockchip_thermal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 4c77965124535..7ca53a4368124 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -1088,7 +1088,8 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
if (IS_ERR(thermal->regs))
return PTR_ERR(thermal->regs);
- thermal->reset = devm_reset_control_get(&pdev->dev, "tsadc-apb");
+ thermal->reset = devm_reset_control_get_exclusive(&pdev->dev,
+ "tsadc-apb");
if (IS_ERR(thermal->reset)) {
error = PTR_ERR(thermal->reset);
dev_err(&pdev->dev, "failed to get tsadc reset: %d\n", error);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 083/102] thermal: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (78 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Zhang Rui, Eduardo Valentin, Thierry Reding,
Jonathan Hunter, linux-pm, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/thermal/tegra/soctherm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 7d2db23d71a32..06ce2becfc285 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -1334,7 +1334,8 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
}
}
- tegra->reset = devm_reset_control_get(&pdev->dev, "soctherm");
+ tegra->reset = devm_reset_control_get_exclusive(&pdev->dev,
+ "soctherm");
if (IS_ERR(tegra->reset)) {
dev_err(&pdev->dev, "can't get soctherm reset\n");
return PTR_ERR(tegra->reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 084/102] serial: 8250_dw: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (79 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Greg Kroah-Hartman, Jiri Slaby, linux-serial
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/tty/serial/8250/8250_dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 787b1160d3a53..7e638997bfc2c 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -529,7 +529,7 @@ static int dw8250_probe(struct platform_device *pdev)
}
}
- data->rst = devm_reset_control_get_optional(dev, NULL);
+ data->rst = devm_reset_control_get_optional_exclusive(dev, NULL);
if (IS_ERR(data->rst)) {
err = PTR_ERR(data->rst);
goto err_pclk;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 085/102] serial: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Laxman Dewangan, Greg Kroah-Hartman, Jiri Slaby,
Thierry Reding, Jonathan Hunter,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Jiri Slaby <jslaby-IBi9RG/b67k@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/tty/serial/serial-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index d92a150c87336..cf9b736f26f88 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -1310,7 +1310,7 @@ static int tegra_uart_probe(struct platform_device *pdev)
return PTR_ERR(tup->uart_clk);
}
- tup->rst = devm_reset_control_get(&pdev->dev, "serial");
+ tup->rst = devm_reset_control_get_exclusive(&pdev->dev, "serial");
if (IS_ERR(tup->rst)) {
dev_err(&pdev->dev, "Couldn't get the reset\n");
return PTR_ERR(tup->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 085/102] serial: tegra: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Laxman Dewangan, Greg Kroah-Hartman, Jiri Slaby,
Thierry Reding, Jonathan Hunter, linux-serial, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-serial@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/tty/serial/serial-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index d92a150c87336..cf9b736f26f88 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -1310,7 +1310,7 @@ static int tegra_uart_probe(struct platform_device *pdev)
return PTR_ERR(tup->uart_clk);
}
- tup->rst = devm_reset_control_get(&pdev->dev, "serial");
+ tup->rst = devm_reset_control_get_exclusive(&pdev->dev, "serial");
if (IS_ERR(tup->rst)) {
dev_err(&pdev->dev, "Couldn't get the reset\n");
return PTR_ERR(tup->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 086/102] usb: chipidea: msm: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (80 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Peter Chen, Greg Kroah-Hartman, linux-usb
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index 0bdfcdcbf7a5a..0cee09192d946 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -197,7 +197,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
CI_HDRC_OVERRIDE_PHY_CONTROL;
ci->pdata.notify_event = ci_hdrc_msm_notify_event;
- reset = devm_reset_control_get(&pdev->dev, "core");
+ reset = devm_reset_control_get_exclusive(&pdev->dev, "core");
if (IS_ERR(reset))
return PTR_ERR(reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 087/102] usb: dwc2: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (81 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, John Youn, Greg Kroah-Hartman, linux-usb
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: John Youn <johnyoun@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/dwc2/platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index daf0d37acb37f..b9ec45b5f85d4 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -211,7 +211,8 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)
{
int i, ret;
- hsotg->reset = devm_reset_control_get_optional(hsotg->dev, "dwc2");
+ hsotg->reset = devm_reset_control_get_optional_exclusive(hsotg->dev,
+ "dwc2");
if (IS_ERR(hsotg->reset)) {
ret = PTR_ERR(hsotg->reset);
dev_err(hsotg->dev, "error getting reset control %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 088/102] usb: host: ehci-tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Alan Stern, Greg Kroah-Hartman, Thierry Reding,
Jonathan Hunter, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
drivers/usb/host/ehci-tegra.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 9a3d7db5be57c..c60c43f66f313 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -94,7 +94,8 @@ static int tegra_reset_usb_controller(struct platform_device *pdev)
struct reset_control *usb1_reset;
if (!has_utmi_pad_registers)
- usb1_reset = of_reset_control_get(phy_np, "utmi-pads");
+ usb1_reset = of_reset_control_get_exclusive(phy_np,
+ "utmi-pads");
else
usb1_reset = tegra->rst;
@@ -450,7 +451,7 @@ static int tegra_ehci_probe(struct platform_device *pdev)
goto cleanup_hcd_create;
}
- tegra->rst = devm_reset_control_get(&pdev->dev, "usb");
+ tegra->rst = devm_reset_control_get_exclusive(&pdev->dev, "usb");
if (IS_ERR(tegra->rst)) {
dev_err(&pdev->dev, "Can't get ehci reset\n");
err = PTR_ERR(tegra->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 088/102] usb: host: ehci-tegra: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Alan Stern, Greg Kroah-Hartman, Thierry Reding,
Jonathan Hunter, linux-usb, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/host/ehci-tegra.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 9a3d7db5be57c..c60c43f66f313 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -94,7 +94,8 @@ static int tegra_reset_usb_controller(struct platform_device *pdev)
struct reset_control *usb1_reset;
if (!has_utmi_pad_registers)
- usb1_reset = of_reset_control_get(phy_np, "utmi-pads");
+ usb1_reset = of_reset_control_get_exclusive(phy_np,
+ "utmi-pads");
else
usb1_reset = tegra->rst;
@@ -450,7 +451,7 @@ static int tegra_ehci_probe(struct platform_device *pdev)
goto cleanup_hcd_create;
}
- tegra->rst = devm_reset_control_get(&pdev->dev, "usb");
+ tegra->rst = devm_reset_control_get_exclusive(&pdev->dev, "usb");
if (IS_ERR(tegra->rst)) {
dev_err(&pdev->dev, "Can't get ehci reset\n");
err = PTR_ERR(tegra->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 089/102] usb: host: xhci-tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (83 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Mathias Nyman, Greg Kroah-Hartman, Thierry Reding,
Jonathan Hunter, linux-usb, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/host/xhci-tegra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index 74436f8ca5382..ba53ee63d450c 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -933,14 +933,16 @@ static int tegra_xusb_probe(struct platform_device *pdev)
if (IS_ERR(tegra->padctl))
return PTR_ERR(tegra->padctl);
- tegra->host_rst = devm_reset_control_get(&pdev->dev, "xusb_host");
+ tegra->host_rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "xusb_host");
if (IS_ERR(tegra->host_rst)) {
err = PTR_ERR(tegra->host_rst);
dev_err(&pdev->dev, "failed to get xusb_host reset: %d\n", err);
goto put_padctl;
}
- tegra->ss_rst = devm_reset_control_get(&pdev->dev, "xusb_ss");
+ tegra->ss_rst = devm_reset_control_get_exclusive(&pdev->dev,
+ "xusb_ss");
if (IS_ERR(tegra->ss_rst)) {
err = PTR_ERR(tegra->ss_rst);
dev_err(&pdev->dev, "failed to get xusb_ss reset: %d\n", err);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 090/102] usb: musb: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (84 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Bin Liu, Greg Kroah-Hartman, Maxime Ripard,
Chen-Yu Tsai, linux-usb
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Bin Liu <b-liu@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/musb/sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index c9a09b5bb6e59..7eec1acbc729a 100644
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c
@@ -747,7 +747,7 @@ static int sunxi_musb_probe(struct platform_device *pdev)
}
if (test_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags)) {
- glue->rst = devm_reset_control_get(&pdev->dev, NULL);
+ glue->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(glue->rst)) {
if (PTR_ERR(glue->rst) == -EPROBE_DEFER)
return -EPROBE_DEFER;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 091/102] usb: phy: msm: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (85 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Felipe Balbi, Greg Kroah-Hartman, linux-usb
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/phy/phy-msm-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 8fb86a5f458e0..c4d93b391d281 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1653,11 +1653,11 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
if (!pdata->phy_type)
return 1;
- motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
+ motg->link_rst = devm_reset_control_get_exclusive(&pdev->dev, "link");
if (IS_ERR(motg->link_rst))
return PTR_ERR(motg->link_rst);
- motg->phy_rst = devm_reset_control_get(&pdev->dev, "phy");
+ motg->phy_rst = devm_reset_control_get_exclusive(&pdev->dev, "phy");
if (IS_ERR(motg->phy_rst))
motg->phy_rst = NULL;
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 092/102] usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (86 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Felipe Balbi, Greg Kroah-Hartman, linux-usb
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/usb/phy/phy-qcom-8x16-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-qcom-8x16-usb.c b/drivers/usb/phy/phy-qcom-8x16-usb.c
index b6a83a5cbad36..b9c31dc7bd026 100644
--- a/drivers/usb/phy/phy-qcom-8x16-usb.c
+++ b/drivers/usb/phy/phy-qcom-8x16-usb.c
@@ -232,7 +232,7 @@ static int phy_8x16_read_devicetree(struct phy_8x16 *qphy)
if (ret)
return ret;
- qphy->phy_reset = devm_reset_control_get(dev, "phy");
+ qphy->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
if (IS_ERR(qphy->phy_reset))
return PTR_ERR(qphy->phy_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 093/102] watchdog: asm9260: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (87 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wim Van Sebroeck, Guenter Roeck, linux-watchdog
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/watchdog/asm9260_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/asm9260_wdt.c b/drivers/watchdog/asm9260_wdt.c
index 53da001f0838e..186fac4cccf5a 100644
--- a/drivers/watchdog/asm9260_wdt.c
+++ b/drivers/watchdog/asm9260_wdt.c
@@ -296,7 +296,7 @@ static int asm9260_wdt_probe(struct platform_device *pdev)
if (ret)
return ret;
- priv->rst = devm_reset_control_get(&pdev->dev, "wdt_rst");
+ priv->rst = devm_reset_control_get_exclusive(&pdev->dev, "wdt_rst");
if (IS_ERR(priv->rst))
return PTR_ERR(priv->rst);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 094/102] watchdog: mt7621: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (88 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wim Van Sebroeck, Guenter Roeck, linux-watchdog
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/watchdog/mt7621_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
index 48a06067075d5..f6f4c1bf24c95 100644
--- a/drivers/watchdog/mt7621_wdt.c
+++ b/drivers/watchdog/mt7621_wdt.c
@@ -135,7 +135,7 @@ static int mt7621_wdt_probe(struct platform_device *pdev)
if (IS_ERR(mt7621_wdt_base))
return PTR_ERR(mt7621_wdt_base);
- mt7621_wdt_reset = devm_reset_control_get(&pdev->dev, NULL);
+ mt7621_wdt_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(mt7621_wdt_reset))
reset_control_deassert(mt7621_wdt_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 095/102] watchdog: rt2880: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (89 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wim Van Sebroeck, Guenter Roeck, linux-watchdog
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/watchdog/rt2880_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
index 05524baf7dccb..0d481a63cab14 100644
--- a/drivers/watchdog/rt2880_wdt.c
+++ b/drivers/watchdog/rt2880_wdt.c
@@ -152,7 +152,7 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
if (IS_ERR(rt288x_wdt_clk))
return PTR_ERR(rt288x_wdt_clk);
- rt288x_wdt_reset = devm_reset_control_get(&pdev->dev, NULL);
+ rt288x_wdt_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rt288x_wdt_reset))
reset_control_deassert(rt288x_wdt_reset);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 096/102] watchdog: zx2967: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (90 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Wim Van Sebroeck, Guenter Roeck, linux-watchdog
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/watchdog/zx2967_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
index 69ec5855584b1..9261f7c77f6de 100644
--- a/drivers/watchdog/zx2967_wdt.c
+++ b/drivers/watchdog/zx2967_wdt.c
@@ -229,7 +229,7 @@ static int zx2967_wdt_probe(struct platform_device *pdev)
}
clk_set_rate(wdt->clock, ZX2967_WDT_CLK_FREQ);
- rstc = devm_reset_control_get(dev, NULL);
+ rstc = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rstc)) {
dev_err(dev, "failed to get rstc");
ret = PTR_ERR(rstc);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 097/102] ASoC: img: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Liam Girdwood, Mark Brown, alsa-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index 0389203f85608..567f9767fb73e 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -443,7 +443,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE;
i2s->dai_driver.ops = &img_i2s_in_dai_ops;
- rst = devm_reset_control_get(dev, "rst");
+ rst = devm_reset_control_get_exclusive(dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-i2s-out.c b/sound/soc/img/img-i2s-out.c
index 5f997135a8aec..78b7f6cd675b7 100644
--- a/sound/soc/img/img-i2s-out.c
+++ b/sound/soc/img/img-i2s-out.c
@@ -446,7 +446,7 @@ static int img_i2s_out_probe(struct platform_device *pdev)
i2s->channel_base = base + (max_i2s_chan_pow_2 * 0x20);
- i2s->rst = devm_reset_control_get(&pdev->dev, "rst");
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(i2s->rst)) {
if (PTR_ERR(i2s->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
index 33ceb207ee704..23b0f0f6ec9cb 100644
--- a/sound/soc/img/img-parallel-out.c
+++ b/sound/soc/img/img-parallel-out.c
@@ -224,7 +224,7 @@ static int img_prl_out_probe(struct platform_device *pdev)
prl->base = base;
- prl->rst = devm_reset_control_get(&pdev->dev, "rst");
+ prl->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(prl->rst)) {
if (PTR_ERR(prl->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-spdif-in.c b/sound/soc/img/img-spdif-in.c
index 4d9953d318af4..8adfd65d43902 100644
--- a/sound/soc/img/img-spdif-in.c
+++ b/sound/soc/img/img-spdif-in.c
@@ -727,7 +727,7 @@ static int img_spdif_in_probe(struct platform_device *pdev)
if (ret)
return ret;
- rst = devm_reset_control_get(&pdev->dev, "rst");
+ rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
index 08f93a5dadfe9..383655da2e60d 100644
--- a/sound/soc/img/img-spdif-out.c
+++ b/sound/soc/img/img-spdif-out.c
@@ -334,7 +334,7 @@ static int img_spdif_out_probe(struct platform_device *pdev)
spdif->base = base;
- spdif->rst = devm_reset_control_get(&pdev->dev, "rst");
+ spdif->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(spdif->rst)) {
if (PTR_ERR(spdif->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 097/102] ASoC: img: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: alsa-devel, Mark Brown, Liam Girdwood, Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index 0389203f85608..567f9767fb73e 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -443,7 +443,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE;
i2s->dai_driver.ops = &img_i2s_in_dai_ops;
- rst = devm_reset_control_get(dev, "rst");
+ rst = devm_reset_control_get_exclusive(dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-i2s-out.c b/sound/soc/img/img-i2s-out.c
index 5f997135a8aec..78b7f6cd675b7 100644
--- a/sound/soc/img/img-i2s-out.c
+++ b/sound/soc/img/img-i2s-out.c
@@ -446,7 +446,7 @@ static int img_i2s_out_probe(struct platform_device *pdev)
i2s->channel_base = base + (max_i2s_chan_pow_2 * 0x20);
- i2s->rst = devm_reset_control_get(&pdev->dev, "rst");
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(i2s->rst)) {
if (PTR_ERR(i2s->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
index 33ceb207ee704..23b0f0f6ec9cb 100644
--- a/sound/soc/img/img-parallel-out.c
+++ b/sound/soc/img/img-parallel-out.c
@@ -224,7 +224,7 @@ static int img_prl_out_probe(struct platform_device *pdev)
prl->base = base;
- prl->rst = devm_reset_control_get(&pdev->dev, "rst");
+ prl->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(prl->rst)) {
if (PTR_ERR(prl->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-spdif-in.c b/sound/soc/img/img-spdif-in.c
index 4d9953d318af4..8adfd65d43902 100644
--- a/sound/soc/img/img-spdif-in.c
+++ b/sound/soc/img/img-spdif-in.c
@@ -727,7 +727,7 @@ static int img_spdif_in_probe(struct platform_device *pdev)
if (ret)
return ret;
- rst = devm_reset_control_get(&pdev->dev, "rst");
+ rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
index 08f93a5dadfe9..383655da2e60d 100644
--- a/sound/soc/img/img-spdif-out.c
+++ b/sound/soc/img/img-spdif-out.c
@@ -334,7 +334,7 @@ static int img_spdif_out_probe(struct platform_device *pdev)
spdif->base = base;
- spdif->rst = devm_reset_control_get(&pdev->dev, "rst");
+ spdif->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(spdif->rst)) {
if (PTR_ERR(spdif->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 098/102] ASoC: stm32: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (92 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Mark Brown
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Liam Girdwood, Mark Brown, Maxime Coquelin,
Alexandre Torgue, alsa-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c
index 8052629a89dfd..6d0bf78d114d0 100644
--- a/sound/soc/stm/stm32_i2s.c
+++ b/sound/soc/stm/stm32_i2s.c
@@ -840,7 +840,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev,
}
/* Reset */
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c
index f7713314913b9..1258bef4dcb37 100644
--- a/sound/soc/stm/stm32_sai.c
+++ b/sound/soc/stm/stm32_sai.c
@@ -85,7 +85,7 @@ static int stm32_sai_probe(struct platform_device *pdev)
}
/* reset */
- rst = reset_control_get(&pdev->dev, NULL);
+ rst = reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c
index 4e4250bdb75a8..84cc5678beba5 100644
--- a/sound/soc/stm/stm32_spdifrx.c
+++ b/sound/soc/stm/stm32_spdifrx.c
@@ -930,7 +930,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 099/102] ASoC: sun4i: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (93 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Mark Brown
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Liam Girdwood, Mark Brown, Maxime Ripard,
Chen-Yu Tsai, alsa-devel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
sound/soc/sunxi/sun4i-codec.c | 3 ++-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 150069987c0c3..9eec303605224 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -1574,7 +1574,8 @@ static int sun4i_codec_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- scodec->rst = devm_reset_control_get(&pdev->dev, NULL);
+ scodec->rst = devm_reset_control_get_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(scodec->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(scodec->rst);
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 3635bbc72cbcd..62b307b0c846c 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -716,7 +716,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- i2s->rst = devm_reset_control_get(&pdev->dev, NULL);
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(i2s->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(i2s->rst);
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index eaefd07a5ed08..c49f3757b686e 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -520,7 +520,8 @@ static int sun4i_spdif_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, host);
if (quirks->has_reset) {
- host->rst = devm_reset_control_get_optional(&pdev->dev, NULL);
+ host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(host->rst) && PTR_ERR(host->rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
dev_err(&pdev->dev, "Failed to get reset: %d\n", ret);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 100/102] ASoC: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-19 15:26 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Philipp Zabel, Liam Girdwood, Mark Brown, Thierry Reding,
Jonathan Hunter, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
sound/soc/tegra/tegra30_ahub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 8c10ae7982bad..43679aeeb12be 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -544,8 +544,8 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
soc_data->mod_list_mask))
continue;
- rst = reset_control_get(&pdev->dev,
- configlink_mods[i].rst_name);
+ rst = reset_control_get_exclusive(&pdev->dev,
+ configlink_mods[i].rst_name);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Can't get reset %s\n",
configlink_mods[i].rst_name);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 100/102] ASoC: tegra: explicitly request exclusive reset control
@ 2017-07-19 15:26 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel
Cc: Philipp Zabel, Liam Girdwood, Mark Brown, Thierry Reding,
Jonathan Hunter, alsa-devel, linux-tegra
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
sound/soc/tegra/tegra30_ahub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 8c10ae7982bad..43679aeeb12be 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -544,8 +544,8 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
soc_data->mod_list_mask))
continue;
- rst = reset_control_get(&pdev->dev,
- configlink_mods[i].rst_name);
+ rst = reset_control_get_exclusive(&pdev->dev,
+ configlink_mods[i].rst_name);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Can't get reset %s\n",
configlink_mods[i].rst_name);
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 101/102] Documentation: devres: add explicit exclusive/shared reset control request calls
2017-07-19 15:25 ` Philipp Zabel
` (94 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-20 7:10 ` Lee Jones
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Jonathan Corbet, Lee Jones, linux-doc
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Add the explicit API calls to the devres list.
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Documentation/driver-model/devres.txt | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
index 30e04f7a690dd..fd157078dd558 100644
--- a/Documentation/driver-model/devres.txt
+++ b/Documentation/driver-model/devres.txt
@@ -379,7 +379,12 @@ REGULATOR
devm_regulator_register()
RESET
- devm_reset_control_get()
+ devm_reset_control_get_exclusive()
+ devm_reset_control_get_shared()
+ devm_reset_control_get_optional_exclusive()
+ devm_reset_control_get_optional_shared()
+ devm_reset_control_get_exclusive_by_index()
+ devm_reset_control_get_shared_by_index()
devm_reset_controller_register()
SLAVE DMA ENGINE
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* [PATCH 102/102] reset: finish transition to explicit exclusive reset control requests
2017-07-19 15:25 ` Philipp Zabel
` (95 preceding siblings ...)
(?)
@ 2017-07-19 15:26 ` Philipp Zabel
2017-07-20 7:12 ` Lee Jones
-1 siblings, 1 reply; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:26 UTC (permalink / raw)
To: linux-kernel; +Cc: Philipp Zabel, Lee Jones
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. After all drivers are converted to the explicit API
calls, the temporary transition helpers can be removed.
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/reset/core.c | 2 +-
include/linux/reset.h | 50 --------------------------------------------------
2 files changed, 1 insertion(+), 51 deletions(-)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 0090784ff4105..9ebeb148d4516 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -461,7 +461,7 @@ int device_reset(struct device *dev)
struct reset_control *rstc;
int ret;
- rstc = reset_control_get(dev, NULL);
+ rstc = reset_control_get_exclusive(dev, NULL);
if (IS_ERR(rstc))
return PTR_ERR(rstc);
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 13d8681210d54..77a65dea9e82b 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -324,54 +324,4 @@ devm_reset_control_get_shared_by_index(struct device *dev, int index)
return __devm_reset_control_get(dev, NULL, index, true, false);
}
-/*
- * TEMPORARY calls to use during transition:
- *
- * of_reset_control_get() => of_reset_control_get_exclusive()
- *
- * These inline function calls will be removed once all consumers
- * have been moved over to the new explicit API.
- */
-static inline struct reset_control *reset_control_get(
- struct device *dev, const char *id)
-{
- return reset_control_get_exclusive(dev, id);
-}
-
-static inline struct reset_control *reset_control_get_optional(
- struct device *dev, const char *id)
-{
- return reset_control_get_optional_exclusive(dev, id);
-}
-
-static inline struct reset_control *of_reset_control_get(
- struct device_node *node, const char *id)
-{
- return of_reset_control_get_exclusive(node, id);
-}
-
-static inline struct reset_control *of_reset_control_get_by_index(
- struct device_node *node, int index)
-{
- return of_reset_control_get_exclusive_by_index(node, index);
-}
-
-static inline struct reset_control *devm_reset_control_get(
- struct device *dev, const char *id)
-{
- return devm_reset_control_get_exclusive(dev, id);
-}
-
-static inline struct reset_control *devm_reset_control_get_optional(
- struct device *dev, const char *id)
-{
- return devm_reset_control_get_optional_exclusive(dev, id);
-
-}
-
-static inline struct reset_control *devm_reset_control_get_by_index(
- struct device *dev, int index)
-{
- return devm_reset_control_get_exclusive_by_index(dev, index);
-}
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: tegra: explicitly request exclusive reset control" to the asoc tree
2017-07-19 15:26 ` Philipp Zabel
(?)
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: alsa-devel, linux-kernel, Liam Girdwood, Jonathan Hunter,
Mark Brown, Thierry Reding, linux-tegra
The patch
ASoC: tegra: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 181e8ce6a6c9a25ffbf10b09d8481f134c5a79ba Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:44 +0200
Subject: [PATCH] ASoC: tegra: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/tegra/tegra30_ahub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 8c10ae7982ba..43679aeeb12b 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -544,8 +544,8 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
soc_data->mod_list_mask))
continue;
- rst = reset_control_get(&pdev->dev,
- configlink_mods[i].rst_name);
+ rst = reset_control_get_exclusive(&pdev->dev,
+ configlink_mods[i].rst_name);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Can't get reset %s\n",
configlink_mods[i].rst_name);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: tegra: explicitly request exclusive reset control" to the asoc tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, Thierry Reding, Jonathan Hunter,
alsa-devel, linux-tegra, Mark Brown, linux-kernel, alsa-devel,
Liam Girdwood, Jonathan Hunter, Mark Brown, Thierry Reding,
linux-tegra, alsa-devel
The patch
ASoC: tegra: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 181e8ce6a6c9a25ffbf10b09d8481f134c5a79ba Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:44 +0200
Subject: [PATCH] ASoC: tegra: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/tegra/tegra30_ahub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 8c10ae7982ba..43679aeeb12b 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -544,8 +544,8 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
soc_data->mod_list_mask))
continue;
- rst = reset_control_get(&pdev->dev,
- configlink_mods[i].rst_name);
+ rst = reset_control_get_exclusive(&pdev->dev,
+ configlink_mods[i].rst_name);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Can't get reset %s\n",
configlink_mods[i].rst_name);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: tegra: explicitly request exclusive reset control" to the asoc tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: alsa-devel, linux-kernel, Liam Girdwood, Jonathan Hunter,
Mark Brown, Thierry Reding, linux-tegra
The patch
ASoC: tegra: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 181e8ce6a6c9a25ffbf10b09d8481f134c5a79ba Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:44 +0200
Subject: [PATCH] ASoC: tegra: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: alsa-devel@alsa-project.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/tegra/tegra30_ahub.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
index 8c10ae7982ba..43679aeeb12b 100644
--- a/sound/soc/tegra/tegra30_ahub.c
+++ b/sound/soc/tegra/tegra30_ahub.c
@@ -544,8 +544,8 @@ static int tegra30_ahub_probe(struct platform_device *pdev)
soc_data->mod_list_mask))
continue;
- rst = reset_control_get(&pdev->dev,
- configlink_mods[i].rst_name);
+ rst = reset_control_get_exclusive(&pdev->dev,
+ configlink_mods[i].rst_name);
if (IS_ERR(rst)) {
dev_err(&pdev->dev, "Can't get reset %s\n",
configlink_mods[i].rst_name);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: sun4i: explicitly request exclusive reset control" to the asoc tree
2017-07-19 15:26 ` [PATCH 099/102] ASoC: sun4i: explicitly request exclusive reset control Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, Maxime Ripard, Chen-Yu Tsai,
alsa-devel, Mark Brown, linux-kernel, alsa-devel, Liam Girdwood,
Chen-Yu Tsai, Mark Brown, Maxime Ripard, alsa-devel
The patch
ASoC: sun4i: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 72bfa2117bdb4bb5b07dd5ed833ff3c318fc70b6 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:43 +0200
Subject: [PATCH] ASoC: sun4i: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/sunxi/sun4i-codec.c | 3 ++-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 4c37231f254b..73d054f466c2 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -1573,7 +1573,8 @@ static int sun4i_codec_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- scodec->rst = devm_reset_control_get(&pdev->dev, NULL);
+ scodec->rst = devm_reset_control_get_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(scodec->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(scodec->rst);
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 3635bbc72cbc..62b307b0c846 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -716,7 +716,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- i2s->rst = devm_reset_control_get(&pdev->dev, NULL);
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(i2s->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(i2s->rst);
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index eaefd07a5ed0..c49f3757b686 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -520,7 +520,8 @@ static int sun4i_spdif_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, host);
if (quirks->has_reset) {
- host->rst = devm_reset_control_get_optional(&pdev->dev, NULL);
+ host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(host->rst) && PTR_ERR(host->rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
dev_err(&pdev->dev, "Failed to get reset: %d\n", ret);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: sun4i: explicitly request exclusive reset control" to the asoc tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, Maxime Ripard, Chen-Yu Tsai, alsa-devel
The patch
ASoC: sun4i: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 72bfa2117bdb4bb5b07dd5ed833ff3c318fc70b6 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:43 +0200
Subject: [PATCH] ASoC: sun4i: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/sunxi/sun4i-codec.c | 3 ++-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 ++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 4c37231f254b..73d054f466c2 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -1573,7 +1573,8 @@ static int sun4i_codec_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- scodec->rst = devm_reset_control_get(&pdev->dev, NULL);
+ scodec->rst = devm_reset_control_get_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(scodec->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(scodec->rst);
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 3635bbc72cbc..62b307b0c846 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -716,7 +716,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
}
if (quirks->has_reset) {
- i2s->rst = devm_reset_control_get(&pdev->dev, NULL);
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(i2s->rst)) {
dev_err(&pdev->dev, "Failed to get reset control\n");
return PTR_ERR(i2s->rst);
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index eaefd07a5ed0..c49f3757b686 100644
--- a/sound/soc/sunxi/sun4i-spdif.c
+++ b/sound/soc/sunxi/sun4i-spdif.c
@@ -520,7 +520,8 @@ static int sun4i_spdif_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, host);
if (quirks->has_reset) {
- host->rst = devm_reset_control_get_optional(&pdev->dev, NULL);
+ host->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
+ NULL);
if (IS_ERR(host->rst) && PTR_ERR(host->rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
dev_err(&pdev->dev, "Failed to get reset: %d\n", ret);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: stm32: explicitly request exclusive reset control" to the asoc tree
2017-07-19 15:26 ` [PATCH 098/102] ASoC: stm32: explicitly request exclusive reset control Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, Maxime Coquelin, Alexandre Torgue,
alsa-devel, Mark Brown, linux-kernel, alsa-devel, Liam Girdwood,
Mark Brown, Maxime Coquelin, Alexandre Torgue, alsa-devel
The patch
ASoC: stm32: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 635eac1e54d82c59f621a0f38a9bffae50f150c7 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:42 +0200
Subject: [PATCH] ASoC: stm32: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c
index 8052629a89df..6d0bf78d114d 100644
--- a/sound/soc/stm/stm32_i2s.c
+++ b/sound/soc/stm/stm32_i2s.c
@@ -840,7 +840,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev,
}
/* Reset */
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c
index f7713314913b..1258bef4dcb3 100644
--- a/sound/soc/stm/stm32_sai.c
+++ b/sound/soc/stm/stm32_sai.c
@@ -85,7 +85,7 @@ static int stm32_sai_probe(struct platform_device *pdev)
}
/* reset */
- rst = reset_control_get(&pdev->dev, NULL);
+ rst = reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c
index 4e4250bdb75a..84cc5678beba 100644
--- a/sound/soc/stm/stm32_spdifrx.c
+++ b/sound/soc/stm/stm32_spdifrx.c
@@ -930,7 +930,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: stm32: explicitly request exclusive reset control" to the asoc tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, Maxime Coquelin, Alexandre Torgue, alsa-devel
The patch
ASoC: stm32: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 635eac1e54d82c59f621a0f38a9bffae50f150c7 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:42 +0200
Subject: [PATCH] ASoC: stm32: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c
index 8052629a89df..6d0bf78d114d 100644
--- a/sound/soc/stm/stm32_i2s.c
+++ b/sound/soc/stm/stm32_i2s.c
@@ -840,7 +840,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev,
}
/* Reset */
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_sai.c b/sound/soc/stm/stm32_sai.c
index f7713314913b..1258bef4dcb3 100644
--- a/sound/soc/stm/stm32_sai.c
+++ b/sound/soc/stm/stm32_sai.c
@@ -85,7 +85,7 @@ static int stm32_sai_probe(struct platform_device *pdev)
}
/* reset */
- rst = reset_control_get(&pdev->dev, NULL);
+ rst = reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c
index 4e4250bdb75a..84cc5678beba 100644
--- a/sound/soc/stm/stm32_spdifrx.c
+++ b/sound/soc/stm/stm32_spdifrx.c
@@ -930,7 +930,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev)
return ret;
}
- rst = devm_reset_control_get(&pdev->dev, NULL);
+ rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(rst)) {
reset_control_assert(rst);
udelay(2);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: img: explicitly request exclusive reset control" to the asoc tree
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Liam Girdwood, Mark Brown, alsa-devel, Mark Brown, linux-kernel,
alsa-devel, Mark Brown, Liam Girdwood, alsa-devel
The patch
ASoC: img: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 3a4e1b93110362f0ca6f81c564b04b2aa4bab853 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:41 +0200
Subject: [PATCH] ASoC: img: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index 0389203f8560..567f9767fb73 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -443,7 +443,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE;
i2s->dai_driver.ops = &img_i2s_in_dai_ops;
- rst = devm_reset_control_get(dev, "rst");
+ rst = devm_reset_control_get_exclusive(dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-i2s-out.c b/sound/soc/img/img-i2s-out.c
index 5f997135a8ae..78b7f6cd675b 100644
--- a/sound/soc/img/img-i2s-out.c
+++ b/sound/soc/img/img-i2s-out.c
@@ -446,7 +446,7 @@ static int img_i2s_out_probe(struct platform_device *pdev)
i2s->channel_base = base + (max_i2s_chan_pow_2 * 0x20);
- i2s->rst = devm_reset_control_get(&pdev->dev, "rst");
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(i2s->rst)) {
if (PTR_ERR(i2s->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
index 33ceb207ee70..23b0f0f6ec9c 100644
--- a/sound/soc/img/img-parallel-out.c
+++ b/sound/soc/img/img-parallel-out.c
@@ -224,7 +224,7 @@ static int img_prl_out_probe(struct platform_device *pdev)
prl->base = base;
- prl->rst = devm_reset_control_get(&pdev->dev, "rst");
+ prl->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(prl->rst)) {
if (PTR_ERR(prl->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-spdif-in.c b/sound/soc/img/img-spdif-in.c
index 4d9953d318af..8adfd65d4390 100644
--- a/sound/soc/img/img-spdif-in.c
+++ b/sound/soc/img/img-spdif-in.c
@@ -727,7 +727,7 @@ static int img_spdif_in_probe(struct platform_device *pdev)
if (ret)
return ret;
- rst = devm_reset_control_get(&pdev->dev, "rst");
+ rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
index 08f93a5dadfe..383655da2e60 100644
--- a/sound/soc/img/img-spdif-out.c
+++ b/sound/soc/img/img-spdif-out.c
@@ -334,7 +334,7 @@ static int img_spdif_out_probe(struct platform_device *pdev)
spdif->base = base;
- spdif->rst = devm_reset_control_get(&pdev->dev, "rst");
+ spdif->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(spdif->rst)) {
if (PTR_ERR(spdif->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "ASoC: img: explicitly request exclusive reset control" to the asoc tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Liam Girdwood, Mark Brown, alsa-devel
The patch
ASoC: img: explicitly request exclusive reset control
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 3a4e1b93110362f0ca6f81c564b04b2aa4bab853 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:41 +0200
Subject: [PATCH] ASoC: img: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index 0389203f8560..567f9767fb73 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -443,7 +443,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE;
i2s->dai_driver.ops = &img_i2s_in_dai_ops;
- rst = devm_reset_control_get(dev, "rst");
+ rst = devm_reset_control_get_exclusive(dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-i2s-out.c b/sound/soc/img/img-i2s-out.c
index 5f997135a8ae..78b7f6cd675b 100644
--- a/sound/soc/img/img-i2s-out.c
+++ b/sound/soc/img/img-i2s-out.c
@@ -446,7 +446,7 @@ static int img_i2s_out_probe(struct platform_device *pdev)
i2s->channel_base = base + (max_i2s_chan_pow_2 * 0x20);
- i2s->rst = devm_reset_control_get(&pdev->dev, "rst");
+ i2s->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(i2s->rst)) {
if (PTR_ERR(i2s->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
index 33ceb207ee70..23b0f0f6ec9c 100644
--- a/sound/soc/img/img-parallel-out.c
+++ b/sound/soc/img/img-parallel-out.c
@@ -224,7 +224,7 @@ static int img_prl_out_probe(struct platform_device *pdev)
prl->base = base;
- prl->rst = devm_reset_control_get(&pdev->dev, "rst");
+ prl->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(prl->rst)) {
if (PTR_ERR(prl->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
diff --git a/sound/soc/img/img-spdif-in.c b/sound/soc/img/img-spdif-in.c
index 4d9953d318af..8adfd65d4390 100644
--- a/sound/soc/img/img-spdif-in.c
+++ b/sound/soc/img/img-spdif-in.c
@@ -727,7 +727,7 @@ static int img_spdif_in_probe(struct platform_device *pdev)
if (ret)
return ret;
- rst = devm_reset_control_get(&pdev->dev, "rst");
+ rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
index 08f93a5dadfe..383655da2e60 100644
--- a/sound/soc/img/img-spdif-out.c
+++ b/sound/soc/img/img-spdif-out.c
@@ -334,7 +334,7 @@ static int img_spdif_out_probe(struct platform_device *pdev)
spdif->base = base;
- spdif->rst = devm_reset_control_get(&pdev->dev, "rst");
+ spdif->rst = devm_reset_control_get_exclusive(&pdev->dev, "rst");
if (IS_ERR(spdif->rst)) {
if (PTR_ERR(spdif->rst) != -EPROBE_DEFER)
dev_err(&pdev->dev, "No top level reset found\n");
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra20-sflash: explicitly request exclusive reset control" to the spi tree
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra
The patch
spi: tegra20-sflash: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From e60dfe0782f251bb529f233e259dffdc8d786624 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:24 +0200
Subject: [PATCH] spi: tegra20-sflash: explicitly request exclusive reset
control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra20-sflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 2c797ee2664d..22893a7e0aa0 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -485,7 +485,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tsd->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tsd->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tsd->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tsd->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra20-sflash: explicitly request exclusive reset control" to the spi tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, Mark Brown, linux-kernel,
Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, linux-spi
The patch
spi: tegra20-sflash: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From e60dfe0782f251bb529f233e259dffdc8d786624 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:24 +0200
Subject: [PATCH] spi: tegra20-sflash: explicitly request exclusive reset
control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra20-sflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index 2c797ee2664d..22893a7e0aa0 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -485,7 +485,7 @@ static int tegra_sflash_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tsd->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tsd->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tsd->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tsd->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra114: explicitly request exclusive reset control" to the spi tree
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra
The patch
spi: tegra114: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From d006edb4202fc8160e7b5ba10c264b153e1f3e2d Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:23 +0200
Subject: [PATCH] spi: tegra114: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra114.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 08012ae5aa66..44550182a4a3 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1083,7 +1083,7 @@ static int tegra_spi_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra114: explicitly request exclusive reset control" to the spi tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, Mark Brown, linux-kernel,
Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, linux-spi
The patch
spi: tegra114: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d006edb4202fc8160e7b5ba10c264b153e1f3e2d Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:23 +0200
Subject: [PATCH] spi: tegra114: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra114.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 08012ae5aa66..44550182a4a3 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1083,7 +1083,7 @@ static int tegra_spi_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra20-slink: explicitly request exclusive reset control" to the spi tree
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra
The patch
spi: tegra20-slink: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 73b32756cec3128882165bd845956fe467a23ad4 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:22 +0200
Subject: [PATCH] spi: tegra20-slink: explicitly request exclusive reset
control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra20-slink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 0c06ce424210..3e12d5f87ee4 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1081,7 +1081,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: tegra20-slink: explicitly request exclusive reset control" to the spi tree
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, Mark Brown, linux-kernel,
Laxman Dewangan, Mark Brown, Thierry Reding, Jonathan Hunter,
linux-spi, linux-tegra, linux-spi
The patch
spi: tegra20-slink: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 73b32756cec3128882165bd845956fe467a23ad4 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:22 +0200
Subject: [PATCH] spi: tegra20-slink: explicitly request exclusive reset
control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-tegra20-slink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 0c06ce424210..3e12d5f87ee4 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1081,7 +1081,7 @@ static int tegra_slink_probe(struct platform_device *pdev)
goto exit_free_irq;
}
- tspi->rst = devm_reset_control_get(&pdev->dev, "spi");
+ tspi->rst = devm_reset_control_get_exclusive(&pdev->dev, "spi");
if (IS_ERR(tspi->rst)) {
dev_err(&pdev->dev, "can not get reset\n");
ret = PTR_ERR(tspi->rst);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: sun6i: explicitly request exclusive reset control" to the spi tree
2017-07-19 15:26 ` Philipp Zabel
(?)
@ 2017-07-19 16:08 ` Mark Brown
-1 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Mark Brown, Maxime Ripard, Chen-Yu Tsai, linux-spi, Mark Brown,
linux-kernel, Mark Brown, Maxime Ripard, Chen-Yu Tsai, linux-spi,
linux-spi
The patch
spi: sun6i: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 36bc7491f9558efef9a678f7d2555b3ecafd6d82 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:21 +0200
Subject: [PATCH] spi: sun6i: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: linux-spi@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c
index 03a773a9531a..fb38234249a8 100644
--- a/drivers/spi/spi-sun6i.c
+++ b/drivers/spi/spi-sun6i.c
@@ -502,7 +502,7 @@ static int sun6i_spi_probe(struct platform_device *pdev)
init_completion(&sspi->done);
- sspi->rstc = devm_reset_control_get(&pdev->dev, NULL);
+ sspi->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (IS_ERR(sspi->rstc)) {
dev_err(&pdev->dev, "Couldn't get reset controller\n");
ret = PTR_ERR(sspi->rstc);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Applied "spi: stm32: explicitly request exclusive reset control" to the spi tree
2017-07-19 15:26 ` [PATCH 076/102] spi: stm32: " Philipp Zabel
@ 2017-07-19 16:08 ` Mark Brown
0 siblings, 0 replies; 260+ messages in thread
From: Mark Brown @ 2017-07-19 16:08 UTC (permalink / raw)
To: Philipp Zabel
Cc: Mark Brown, Maxime Coquelin, Alexandre Torgue, linux-spi,
Mark Brown, linux-kernel, Mark Brown, Maxime Coquelin,
Alexandre Torgue, linux-spi, linux-spi
The patch
spi: stm32: explicitly request exclusive reset control
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d5e9a4a433f7d082538268501fa684ada2c76552 Mon Sep 17 00:00:00 2001
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Wed, 19 Jul 2017 17:26:20 +0200
Subject: [PATCH] spi: stm32: explicitly request exclusive reset control
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit API call so the temporary transition helpers can be removed.
No functional changes.
Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: linux-spi@vger.kernel.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-stm32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
index 75644bcd938b..680cdf549506 100644
--- a/drivers/spi/spi-stm32.c
+++ b/drivers/spi/spi-stm32.c
@@ -1132,7 +1132,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
goto err_master_put;
}
- spi->rst = devm_reset_control_get(&pdev->dev, NULL);
+ spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);
if (!IS_ERR(spi->rst)) {
reset_control_assert(spi->rst);
udelay(2);
--
2.13.2
^ permalink raw reply related [flat|nested] 260+ messages in thread
* Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 002/102] ARM: socfpga: " Philipp Zabel
@ 2017-07-19 16:12 ` Moritz Fischer
2017-07-27 18:49 ` Alan Tull
0 siblings, 1 reply; 260+ messages in thread
From: Moritz Fischer @ 2017-07-19 16:12 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Alan Tull, Moritz Fischer, linux-fpga
[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]
On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: linux-fpga@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-By: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/altera-hps2fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
> index 3066b805f2d07..a18ff430c9af1 100644
> --- a/drivers/fpga/altera-hps2fpga.c
> +++ b/drivers/fpga/altera-hps2fpga.c
> @@ -145,7 +145,8 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> of_id = of_match_device(altera_fpga_of_match, dev);
> priv = (struct altera_hps2fpga_data *)of_id->data;
>
> - priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
> + priv->bridge_reset = of_reset_control_get_exclusive_by_index(dev->of_node,
> + 0);
> if (IS_ERR(priv->bridge_reset)) {
> dev_err(dev, "Could not get %s reset control\n", priv->name);
> return PTR_ERR(priv->bridge_reset);
> --
> 2.11.0
>
Thanks,
Moritz
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 071/102] remoteproc/keystone: " Philipp Zabel
@ 2017-07-19 16:59 ` Suman Anna
0 siblings, 0 replies; 260+ messages in thread
From: Suman Anna @ 2017-07-19 16:59 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel
Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc
On 07/19/2017 10:26 AM, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-remoteproc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/remoteproc/keystone_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index 5f776bfd674a0..920fef072b364 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - ksproc->reset = devm_reset_control_get(dev, NULL);
> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(ksproc->reset)) {
> ret = PTR_ERR(ksproc->reset);
> goto free_rproc;
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control
@ 2017-07-19 16:59 ` Suman Anna
0 siblings, 0 replies; 260+ messages in thread
From: Suman Anna @ 2017-07-19 16:59 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel
Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc
On 07/19/2017 10:26 AM, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-remoteproc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/remoteproc/keystone_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index 5f776bfd674a0..920fef072b364 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - ksproc->reset = devm_reset_control_get(dev, NULL);
> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(ksproc->reset)) {
> ret = PTR_ERR(ksproc->reset);
> goto free_rproc;
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 093/102] watchdog: asm9260: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 093/102] watchdog: asm9260: " Philipp Zabel
@ 2017-07-19 17:35 ` Guenter Roeck
0 siblings, 0 replies; 260+ messages in thread
From: Guenter Roeck @ 2017-07-19 17:35 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Wim Van Sebroeck, linux-watchdog
On Wed, Jul 19, 2017 at 05:26:37PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/asm9260_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/asm9260_wdt.c b/drivers/watchdog/asm9260_wdt.c
> index 53da001f0838e..186fac4cccf5a 100644
> --- a/drivers/watchdog/asm9260_wdt.c
> +++ b/drivers/watchdog/asm9260_wdt.c
> @@ -296,7 +296,7 @@ static int asm9260_wdt_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - priv->rst = devm_reset_control_get(&pdev->dev, "wdt_rst");
> + priv->rst = devm_reset_control_get_exclusive(&pdev->dev, "wdt_rst");
> if (IS_ERR(priv->rst))
> return PTR_ERR(priv->rst);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 094/102] watchdog: mt7621: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 094/102] watchdog: mt7621: " Philipp Zabel
@ 2017-07-19 17:35 ` Guenter Roeck
0 siblings, 0 replies; 260+ messages in thread
From: Guenter Roeck @ 2017-07-19 17:35 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Wim Van Sebroeck, linux-watchdog
On Wed, Jul 19, 2017 at 05:26:38PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mt7621_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 48a06067075d5..f6f4c1bf24c95 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -135,7 +135,7 @@ static int mt7621_wdt_probe(struct platform_device *pdev)
> if (IS_ERR(mt7621_wdt_base))
> return PTR_ERR(mt7621_wdt_base);
>
> - mt7621_wdt_reset = devm_reset_control_get(&pdev->dev, NULL);
> + mt7621_wdt_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (!IS_ERR(mt7621_wdt_reset))
> reset_control_deassert(mt7621_wdt_reset);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 095/102] watchdog: rt2880: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 095/102] watchdog: rt2880: " Philipp Zabel
@ 2017-07-19 17:36 ` Guenter Roeck
0 siblings, 0 replies; 260+ messages in thread
From: Guenter Roeck @ 2017-07-19 17:36 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Wim Van Sebroeck, linux-watchdog
On Wed, Jul 19, 2017 at 05:26:39PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/rt2880_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 05524baf7dccb..0d481a63cab14 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -152,7 +152,7 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
> if (IS_ERR(rt288x_wdt_clk))
> return PTR_ERR(rt288x_wdt_clk);
>
> - rt288x_wdt_reset = devm_reset_control_get(&pdev->dev, NULL);
> + rt288x_wdt_reset = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (!IS_ERR(rt288x_wdt_reset))
> reset_control_deassert(rt288x_wdt_reset);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 096/102] watchdog: zx2967: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 096/102] watchdog: zx2967: " Philipp Zabel
@ 2017-07-19 17:36 ` Guenter Roeck
0 siblings, 0 replies; 260+ messages in thread
From: Guenter Roeck @ 2017-07-19 17:36 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Wim Van Sebroeck, linux-watchdog
On Wed, Jul 19, 2017 at 05:26:40PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Wim Van Sebroeck <wim@iguana.be>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/zx2967_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
> index 69ec5855584b1..9261f7c77f6de 100644
> --- a/drivers/watchdog/zx2967_wdt.c
> +++ b/drivers/watchdog/zx2967_wdt.c
> @@ -229,7 +229,7 @@ static int zx2967_wdt_probe(struct platform_device *pdev)
> }
> clk_set_rate(wdt->clock, ZX2967_WDT_CLK_FREQ);
>
> - rstc = devm_reset_control_get(dev, NULL);
> + rstc = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(rstc)) {
> dev_err(dev, "failed to get rstc");
> ret = PTR_ERR(rstc);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-19 19:15 ` Thomas Petazzoni
2017-07-19 15:26 ` Philipp Zabel
` (7 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-19 19:15 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
linux-i2c, linux-watchdog, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter, linux-rockchip,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, linux-pci, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hello,
On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
I don't know if it has been discussed in the past, so forgive me if it
has been. Have you considered adding a "int flags" argument to the
existing reset_control_get_*() functions, rather than introducing
separate exclusive variants ?
Indeed, with a "int flags" argument you could in the future add more
variants/behaviors without actually multiplying the number of
functions. Something like the "flags" argument for request_irq() for
example.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 19:15 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-19 19:15 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hello,
On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
I don't know if it has been discussed in the past, so forgive me if it
has been. Have you considered adding a "int flags" argument to the
existing reset_control_get_*() functions, rather than introducing
separate exclusive variants ?
Indeed, with a "int flags" argument you could in the future add more
variants/behaviors without actually multiplying the number of
functions. Something like the "flags" argument for request_irq() for
example.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 19:15 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-19 19:15 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hello,
On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
I don't know if it has been discussed in the past, so forgive me if it
has been. Have you considered adding a "int flags" argument to the
existing reset_control_get_*() functions, rather than introducing
separate exclusive variants ?
Indeed, with a "int flags" argument you could in the future add more
variants/behaviors without actually multiplying the number of
functions. Something like the "flags" argument for request_irq() for
example.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 19:15 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-19 19:15 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, linux-i2c, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, linux-watchdog,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou, linux-mediatek,
linux-tegra, Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
Hello,
On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
I don't know if it has been discussed in the past, so forgive me if it
has been. Have you considered adding a "int flags" argument to the
existing reset_control_get_*() functions, rather than introducing
separate exclusive variants ?
Indeed, with a "int flags" argument you could in the future add more
variants/behaviors without actually multiplying the number of
functions. Something like the "flags" argument for request_irq() for
example.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-20 6:56 ` Maxime Ripard
2017-07-19 15:26 ` Philipp Zabel
` (8 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Maxime Ripard @ 2017-07-20 6:56 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Heiko Stuebner, Herbert Xu, Jaehoon Chung,
Jiri Slaby, Joachim Eastwood, John Youn, Jon Hunter,
Jonathan Cameron, Jonathan Corbet, Kalle Valo,
Kishon Vijay Abraham I, Kyungmin Park, Lars-Peter Clausen,
Laxman Dewangan, Lee Jones, Liam Girdwood, Linus Walleij,
Lucas Stach, Marc Dietrich, Marek Vasut, Mark Brown, Mark Yao,
Mathias Nyman, Matthias Brugger, Maxime Coquelin,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c, linux-ide,
linux-iio, linux-input, linux-media, linux-mediatek, linux-mips,
linux-mmc, linux-mtd, linux-pci, linux-pm, linux-pwm,
linux-remoteproc, linux-rockchip, linux-serial, linux-spi,
linux-tegra, linux-usb, linux-watchdog, linux-wireless, netdev,
nouveau
[-- Attachment #1: Type: text/plain, Size: 8883 bytes --]
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get_optional(dev, id);
> +rstc = reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, node, id;
> @@
> -rstc = of_reset_control_get(node, id);
> +rstc = of_reset_control_get_exclusive(node, id);
> @@
> expression rstc, node, index;
> @@
> -rstc = of_reset_control_get_by_index(node, index);
> +rstc = of_reset_control_get_exclusive_by_index(node, index);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get(dev, id);
> +rstc = devm_reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get_optional(dev, id);
> +rstc = devm_reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, dev, index;
> @@
> -rstc = devm_reset_control_get_by_index(dev, index);
> +rstc = devm_reset_control_get_exclusive_by_index(dev, index);
>
> After all driver patches are applied, the temporary transition helpers
> can be removed.
>
> regards
> Philipp
>
> Philipp Zabel (102):
> ARM: rockchip: explicitly request exclusive reset control
> ARM: socfpga: explicitly request exclusive reset control
> MIPS: pci-mt7620: explicitly request exclusive reset control
> ahci: st: explicitly request exclusive reset control
> ata: sata_gemini: explicitly request exclusive reset control
> ata: ahci_tegra: explicitly request exclusive reset control
> bus: sunxi-rsb: explicitly request exclusive reset control
> bus: tegra-gmi: explicitly request exclusive reset control
> clk: sunxi: explicitly request exclusive reset control
> clk: tegra: explicitly request exclusive reset control
> clocksource/drivers/timer-stm32: explicitly request exclusive reset
> control
> clocksource/drivers/sun5i: explicitly request exclusive reset control
> crypto: rockchip: explicitly request exclusive reset control
> crypto: sun4i-ss - request exclusive reset control
> PM / devfreq: tegra: explicitly request exclusive reset control
> dmaengine: stm32-dma: explicitly request exclusive reset control
> dmaengine: sun6i: explicitly request exclusive reset control
> dmaengine: tegra-apb: explicitly request exclusive reset control
> drm: kirin: explicitly request exclusive reset control
> drm/nouveau/tegra: explicitly request exclusive reset control
> drm/rockchip: explicitly request exclusive reset control
> drm/sti: explicitly request exclusive reset control
> drm/stm: explicitly request exclusive reset control
> drm/sun4i: explicitly request exclusive reset control
> drm/tegra: explicitly request exclusive reset control
> gpu: host1x: explicitly request exclusive reset control
> i2c: mv64xxx: explicitly request exclusive reset control
> i2c: stm32f4: explicitly request exclusive reset control
> i2c: sun6i-pw2i: explicitly request exclusive reset control
> i2c: tegra: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> iio: dac: stm32-dac-core: explicitly request exclusive reset control
> Input: tegra-kbc - request exclusive reset control
> coda: explicitly request exclusive reset control
> st-rc: explicitly request exclusive reset control
> stm32-dcmi: explicitly request exclusive reset control
> rc: sunxi-cir: explicitly request exclusive reset control
> mmc: dw_mmc: explicitly request exclusive reset control
> mmc: sdhci-st: explicitly request exclusive reset control
> mmc: sunxi: explicitly request exclusive reset control
> mmc: tegra: explicitly request exclusive reset control
> mtd: nand: sunxi: explicitly request exclusive reset control
> mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
> control
> net: dsa: mt7530: explicitly request exclusive reset control
> net: ethernet: hisi_femac: explicitly request exclusive reset control
> net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
> control
> net: stmmac: explicitly request exclusive reset control
> net: stmmac: dwc-qos: explicitly request exclusive reset control
> ath10k: explicitly request exclusive reset control
> nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
> PCI: dwc: pcie-qcom: explicitly request exclusive reset control
> PCI: imx6: explicitly request exclusive reset control
> PCI: tegra: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: berlin-usb: explicitly request exclusive reset control
> PCI: mediatek: explicitly request exclusive reset control
> phy: qcom-usb-hs: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> phy: sun4i-usb: explicitly request exclusive reset control
> phy: sun9i-usb: explicitly request exclusive reset control
> phy: tegra: explicitly request exclusive reset control
> phy: qcom-qmp: explicitly request exclusive reset control
> phy: qcom-qusb2: explicitly request exclusive reset control
> pinctrl: stm32: explicitly request exclusive reset control
> pinctrl: sunxi: explicitly request exclusive reset control
> pinctrl: tegra: explicitly request exclusive reset control
> pwm: hibvt: explicitly request exclusive reset control
> pwm: tegra: explicitly request exclusive reset control
> remoteproc/keystone: explicitly request exclusive reset control
> remoteproc: qcom: explicitly request exclusive reset control
> remoteproc: st: explicitly request exclusive reset control
> soc: mediatek: PMIC wrap: explicitly request exclusive reset control
> soc/tegra: pmc: explicitly request exclusive reset control
> spi: stm32: explicitly request exclusive reset control
> spi: sun6i: explicitly request exclusive reset control
> spi: tegra20-slink: explicitly request exclusive reset control
> spi: tegra114: explicitly request exclusive reset control
> spi: tegra20-sflash: explicitly request exclusive reset control
> staging: nvec: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
> thermal: tegra: explicitly request exclusive reset control
> serial: 8250_dw: explicitly request exclusive reset control
> serial: tegra: explicitly request exclusive reset control
> usb: chipidea: msm: explicitly request exclusive reset control
> usb: dwc2: explicitly request exclusive reset control
> usb: host: ehci-tegra: explicitly request exclusive reset control
> usb: host: xhci-tegra: explicitly request exclusive reset control
> usb: musb: sunxi: explicitly request exclusive reset control
> usb: phy: msm: explicitly request exclusive reset control
> usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
> watchdog: asm9260: explicitly request exclusive reset control
> watchdog: mt7621: explicitly request exclusive reset control
> watchdog: rt2880: explicitly request exclusive reset control
> watchdog: zx2967: explicitly request exclusive reset control
> ASoC: img: explicitly request exclusive reset control
> ASoC: stm32: explicitly request exclusive reset control
> ASoC: sun4i: explicitly request exclusive reset control
> ASoC: tegra: explicitly request exclusive reset control
> Documentation: devres: add explicit exclusive/shared reset control
> request calls
> reset: finish transition to explicit exclusive reset control requests
For all sunxi patches:
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 6:56 ` Maxime Ripard
0 siblings, 0 replies; 260+ messages in thread
From: Maxime Ripard @ 2017-07-20 6:56 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TaqPxH82wqD4g
[-- Attachment #1.1: Type: text/plain, Size: 8914 bytes --]
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get_optional(dev, id);
> +rstc = reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, node, id;
> @@
> -rstc = of_reset_control_get(node, id);
> +rstc = of_reset_control_get_exclusive(node, id);
> @@
> expression rstc, node, index;
> @@
> -rstc = of_reset_control_get_by_index(node, index);
> +rstc = of_reset_control_get_exclusive_by_index(node, index);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get(dev, id);
> +rstc = devm_reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get_optional(dev, id);
> +rstc = devm_reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, dev, index;
> @@
> -rstc = devm_reset_control_get_by_index(dev, index);
> +rstc = devm_reset_control_get_exclusive_by_index(dev, index);
>
> After all driver patches are applied, the temporary transition helpers
> can be removed.
>
> regards
> Philipp
>
> Philipp Zabel (102):
> ARM: rockchip: explicitly request exclusive reset control
> ARM: socfpga: explicitly request exclusive reset control
> MIPS: pci-mt7620: explicitly request exclusive reset control
> ahci: st: explicitly request exclusive reset control
> ata: sata_gemini: explicitly request exclusive reset control
> ata: ahci_tegra: explicitly request exclusive reset control
> bus: sunxi-rsb: explicitly request exclusive reset control
> bus: tegra-gmi: explicitly request exclusive reset control
> clk: sunxi: explicitly request exclusive reset control
> clk: tegra: explicitly request exclusive reset control
> clocksource/drivers/timer-stm32: explicitly request exclusive reset
> control
> clocksource/drivers/sun5i: explicitly request exclusive reset control
> crypto: rockchip: explicitly request exclusive reset control
> crypto: sun4i-ss - request exclusive reset control
> PM / devfreq: tegra: explicitly request exclusive reset control
> dmaengine: stm32-dma: explicitly request exclusive reset control
> dmaengine: sun6i: explicitly request exclusive reset control
> dmaengine: tegra-apb: explicitly request exclusive reset control
> drm: kirin: explicitly request exclusive reset control
> drm/nouveau/tegra: explicitly request exclusive reset control
> drm/rockchip: explicitly request exclusive reset control
> drm/sti: explicitly request exclusive reset control
> drm/stm: explicitly request exclusive reset control
> drm/sun4i: explicitly request exclusive reset control
> drm/tegra: explicitly request exclusive reset control
> gpu: host1x: explicitly request exclusive reset control
> i2c: mv64xxx: explicitly request exclusive reset control
> i2c: stm32f4: explicitly request exclusive reset control
> i2c: sun6i-pw2i: explicitly request exclusive reset control
> i2c: tegra: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> iio: dac: stm32-dac-core: explicitly request exclusive reset control
> Input: tegra-kbc - request exclusive reset control
> coda: explicitly request exclusive reset control
> st-rc: explicitly request exclusive reset control
> stm32-dcmi: explicitly request exclusive reset control
> rc: sunxi-cir: explicitly request exclusive reset control
> mmc: dw_mmc: explicitly request exclusive reset control
> mmc: sdhci-st: explicitly request exclusive reset control
> mmc: sunxi: explicitly request exclusive reset control
> mmc: tegra: explicitly request exclusive reset control
> mtd: nand: sunxi: explicitly request exclusive reset control
> mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
> control
> net: dsa: mt7530: explicitly request exclusive reset control
> net: ethernet: hisi_femac: explicitly request exclusive reset control
> net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
> control
> net: stmmac: explicitly request exclusive reset control
> net: stmmac: dwc-qos: explicitly request exclusive reset control
> ath10k: explicitly request exclusive reset control
> nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
> PCI: dwc: pcie-qcom: explicitly request exclusive reset control
> PCI: imx6: explicitly request exclusive reset control
> PCI: tegra: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: berlin-usb: explicitly request exclusive reset control
> PCI: mediatek: explicitly request exclusive reset control
> phy: qcom-usb-hs: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> phy: sun4i-usb: explicitly request exclusive reset control
> phy: sun9i-usb: explicitly request exclusive reset control
> phy: tegra: explicitly request exclusive reset control
> phy: qcom-qmp: explicitly request exclusive reset control
> phy: qcom-qusb2: explicitly request exclusive reset control
> pinctrl: stm32: explicitly request exclusive reset control
> pinctrl: sunxi: explicitly request exclusive reset control
> pinctrl: tegra: explicitly request exclusive reset control
> pwm: hibvt: explicitly request exclusive reset control
> pwm: tegra: explicitly request exclusive reset control
> remoteproc/keystone: explicitly request exclusive reset control
> remoteproc: qcom: explicitly request exclusive reset control
> remoteproc: st: explicitly request exclusive reset control
> soc: mediatek: PMIC wrap: explicitly request exclusive reset control
> soc/tegra: pmc: explicitly request exclusive reset control
> spi: stm32: explicitly request exclusive reset control
> spi: sun6i: explicitly request exclusive reset control
> spi: tegra20-slink: explicitly request exclusive reset control
> spi: tegra114: explicitly request exclusive reset control
> spi: tegra20-sflash: explicitly request exclusive reset control
> staging: nvec: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
> thermal: tegra: explicitly request exclusive reset control
> serial: 8250_dw: explicitly request exclusive reset control
> serial: tegra: explicitly request exclusive reset control
> usb: chipidea: msm: explicitly request exclusive reset control
> usb: dwc2: explicitly request exclusive reset control
> usb: host: ehci-tegra: explicitly request exclusive reset control
> usb: host: xhci-tegra: explicitly request exclusive reset control
> usb: musb: sunxi: explicitly request exclusive reset control
> usb: phy: msm: explicitly request exclusive reset control
> usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
> watchdog: asm9260: explicitly request exclusive reset control
> watchdog: mt7621: explicitly request exclusive reset control
> watchdog: rt2880: explicitly request exclusive reset control
> watchdog: zx2967: explicitly request exclusive reset control
> ASoC: img: explicitly request exclusive reset control
> ASoC: stm32: explicitly request exclusive reset control
> ASoC: sun4i: explicitly request exclusive reset control
> ASoC: tegra: explicitly request exclusive reset control
> Documentation: devres: add explicit exclusive/shared reset control
> request calls
> reset: finish transition to explicit exclusive reset control requests
For all sunxi patches:
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 6:56 ` Maxime Ripard
0 siblings, 0 replies; 260+ messages in thread
From: Maxime Ripard @ 2017-07-20 6:56 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Kalle Valo, Laxman Dewangan,
Corentin Labbe, linux-i2c, linux-watchdog, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, Alexandre Torgue,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, linux-tegra, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Brian Norris, David S. Miller,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, dmaengine, linux-mediatek,
Matthias Brugger, Mark Yao, Moritz Fischer, Vivien Didelot,
netdev, Peter De Schrijver, Stephen Boyd, Adrian Hunter,
Vinod Koul, Rongrong Zou, linux-fpga, David Woodhouse,
Lucas Stach
[-- Attachment #1.1: Type: text/plain, Size: 8883 bytes --]
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
>
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get(dev, id);
> +rstc = reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = reset_control_get_optional(dev, id);
> +rstc = reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, node, id;
> @@
> -rstc = of_reset_control_get(node, id);
> +rstc = of_reset_control_get_exclusive(node, id);
> @@
> expression rstc, node, index;
> @@
> -rstc = of_reset_control_get_by_index(node, index);
> +rstc = of_reset_control_get_exclusive_by_index(node, index);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get(dev, id);
> +rstc = devm_reset_control_get_exclusive(dev, id);
> @@
> expression rstc, dev, id;
> @@
> -rstc = devm_reset_control_get_optional(dev, id);
> +rstc = devm_reset_control_get_optional_exclusive(dev, id);
> @@
> expression rstc, dev, index;
> @@
> -rstc = devm_reset_control_get_by_index(dev, index);
> +rstc = devm_reset_control_get_exclusive_by_index(dev, index);
>
> After all driver patches are applied, the temporary transition helpers
> can be removed.
>
> regards
> Philipp
>
> Philipp Zabel (102):
> ARM: rockchip: explicitly request exclusive reset control
> ARM: socfpga: explicitly request exclusive reset control
> MIPS: pci-mt7620: explicitly request exclusive reset control
> ahci: st: explicitly request exclusive reset control
> ata: sata_gemini: explicitly request exclusive reset control
> ata: ahci_tegra: explicitly request exclusive reset control
> bus: sunxi-rsb: explicitly request exclusive reset control
> bus: tegra-gmi: explicitly request exclusive reset control
> clk: sunxi: explicitly request exclusive reset control
> clk: tegra: explicitly request exclusive reset control
> clocksource/drivers/timer-stm32: explicitly request exclusive reset
> control
> clocksource/drivers/sun5i: explicitly request exclusive reset control
> crypto: rockchip: explicitly request exclusive reset control
> crypto: sun4i-ss - request exclusive reset control
> PM / devfreq: tegra: explicitly request exclusive reset control
> dmaengine: stm32-dma: explicitly request exclusive reset control
> dmaengine: sun6i: explicitly request exclusive reset control
> dmaengine: tegra-apb: explicitly request exclusive reset control
> drm: kirin: explicitly request exclusive reset control
> drm/nouveau/tegra: explicitly request exclusive reset control
> drm/rockchip: explicitly request exclusive reset control
> drm/sti: explicitly request exclusive reset control
> drm/stm: explicitly request exclusive reset control
> drm/sun4i: explicitly request exclusive reset control
> drm/tegra: explicitly request exclusive reset control
> gpu: host1x: explicitly request exclusive reset control
> i2c: mv64xxx: explicitly request exclusive reset control
> i2c: stm32f4: explicitly request exclusive reset control
> i2c: sun6i-pw2i: explicitly request exclusive reset control
> i2c: tegra: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> iio: dac: stm32-dac-core: explicitly request exclusive reset control
> Input: tegra-kbc - request exclusive reset control
> coda: explicitly request exclusive reset control
> st-rc: explicitly request exclusive reset control
> stm32-dcmi: explicitly request exclusive reset control
> rc: sunxi-cir: explicitly request exclusive reset control
> mmc: dw_mmc: explicitly request exclusive reset control
> mmc: sdhci-st: explicitly request exclusive reset control
> mmc: sunxi: explicitly request exclusive reset control
> mmc: tegra: explicitly request exclusive reset control
> mtd: nand: sunxi: explicitly request exclusive reset control
> mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
> control
> net: dsa: mt7530: explicitly request exclusive reset control
> net: ethernet: hisi_femac: explicitly request exclusive reset control
> net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
> control
> net: stmmac: explicitly request exclusive reset control
> net: stmmac: dwc-qos: explicitly request exclusive reset control
> ath10k: explicitly request exclusive reset control
> nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
> PCI: dwc: pcie-qcom: explicitly request exclusive reset control
> PCI: imx6: explicitly request exclusive reset control
> PCI: tegra: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: berlin-usb: explicitly request exclusive reset control
> PCI: mediatek: explicitly request exclusive reset control
> phy: qcom-usb-hs: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> phy: sun4i-usb: explicitly request exclusive reset control
> phy: sun9i-usb: explicitly request exclusive reset control
> phy: tegra: explicitly request exclusive reset control
> phy: qcom-qmp: explicitly request exclusive reset control
> phy: qcom-qusb2: explicitly request exclusive reset control
> pinctrl: stm32: explicitly request exclusive reset control
> pinctrl: sunxi: explicitly request exclusive reset control
> pinctrl: tegra: explicitly request exclusive reset control
> pwm: hibvt: explicitly request exclusive reset control
> pwm: tegra: explicitly request exclusive reset control
> remoteproc/keystone: explicitly request exclusive reset control
> remoteproc: qcom: explicitly request exclusive reset control
> remoteproc: st: explicitly request exclusive reset control
> soc: mediatek: PMIC wrap: explicitly request exclusive reset control
> soc/tegra: pmc: explicitly request exclusive reset control
> spi: stm32: explicitly request exclusive reset control
> spi: sun6i: explicitly request exclusive reset control
> spi: tegra20-slink: explicitly request exclusive reset control
> spi: tegra114: explicitly request exclusive reset control
> spi: tegra20-sflash: explicitly request exclusive reset control
> staging: nvec: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
> thermal: tegra: explicitly request exclusive reset control
> serial: 8250_dw: explicitly request exclusive reset control
> serial: tegra: explicitly request exclusive reset control
> usb: chipidea: msm: explicitly request exclusive reset control
> usb: dwc2: explicitly request exclusive reset control
> usb: host: ehci-tegra: explicitly request exclusive reset control
> usb: host: xhci-tegra: explicitly request exclusive reset control
> usb: musb: sunxi: explicitly request exclusive reset control
> usb: phy: msm: explicitly request exclusive reset control
> usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
> watchdog: asm9260: explicitly request exclusive reset control
> watchdog: mt7621: explicitly request exclusive reset control
> watchdog: rt2880: explicitly request exclusive reset control
> watchdog: zx2967: explicitly request exclusive reset control
> ASoC: img: explicitly request exclusive reset control
> ASoC: stm32: explicitly request exclusive reset control
> ASoC: sun4i: explicitly request exclusive reset control
> ASoC: tegra: explicitly request exclusive reset control
> Documentation: devres: add explicit exclusive/shared reset control
> request calls
> reset: finish transition to explicit exclusive reset control requests
For all sunxi patches:
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 042/102] mtd: nand: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 042/102] mtd: nand: sunxi: " Philipp Zabel
@ 2017-07-20 7:00 ` Boris Brezillon
2017-07-20 9:27 ` Philipp Zabel
0 siblings, 1 reply; 260+ messages in thread
From: Boris Brezillon @ 2017-07-20 7:00 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Cyrille Pitchen, Maxime Ripard, Chen-Yu Tsai,
linux-mtd
Hi Philipp,
On Wed, 19 Jul 2017 17:25:46 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
If you don't mind, I'd like to take this patch in the nand tree, just in
case we have other modifications on sunxi_nand.c for this cycle.
Regards,
Boris
>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/mtd/nand/sunxi_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c
> index d0b6f8f9f297a..6eb97451f485c 100644
> --- a/drivers/mtd/nand/sunxi_nand.c
> +++ b/drivers/mtd/nand/sunxi_nand.c
> @@ -2208,7 +2208,7 @@ static int sunxi_nfc_probe(struct platform_device *pdev)
> if (ret)
> goto out_ahb_clk_unprepare;
>
> - nfc->reset = devm_reset_control_get_optional(dev, "ahb");
> + nfc->reset = devm_reset_control_get_optional_exclusive(dev, "ahb");
> if (IS_ERR(nfc->reset)) {
> ret = PTR_ERR(nfc->reset);
> goto out_mod_clk_unprepare;
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 101/102] Documentation: devres: add explicit exclusive/shared reset control request calls
2017-07-19 15:26 ` [PATCH 101/102] Documentation: devres: add explicit exclusive/shared reset control request calls Philipp Zabel
@ 2017-07-20 7:10 ` Lee Jones
0 siblings, 0 replies; 260+ messages in thread
From: Lee Jones @ 2017-07-20 7:10 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Jonathan Corbet, linux-doc
On Wed, 19 Jul 2017, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Add the explicit API calls to the devres list.
>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Documentation/driver-model/devres.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/Documentation/driver-model/devres.txt b/Documentation/driver-model/devres.txt
> index 30e04f7a690dd..fd157078dd558 100644
> --- a/Documentation/driver-model/devres.txt
> +++ b/Documentation/driver-model/devres.txt
> @@ -379,7 +379,12 @@ REGULATOR
> devm_regulator_register()
>
> RESET
> - devm_reset_control_get()
> + devm_reset_control_get_exclusive()
> + devm_reset_control_get_shared()
> + devm_reset_control_get_optional_exclusive()
> + devm_reset_control_get_optional_shared()
> + devm_reset_control_get_exclusive_by_index()
> + devm_reset_control_get_shared_by_index()
> devm_reset_controller_register()
>
> SLAVE DMA ENGINE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 102/102] reset: finish transition to explicit exclusive reset control requests
2017-07-19 15:26 ` [PATCH 102/102] reset: finish transition to explicit exclusive reset control requests Philipp Zabel
@ 2017-07-20 7:12 ` Lee Jones
0 siblings, 0 replies; 260+ messages in thread
From: Lee Jones @ 2017-07-20 7:12 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel
On Wed, 19 Jul 2017, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. After all drivers are converted to the explicit API
> calls, the temporary transition helpers can be removed.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/core.c | 2 +-
> include/linux/reset.h | 50 --------------------------------------------------
> 2 files changed, 1 insertion(+), 51 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
@ 2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-19 15:26 ` Philipp Zabel
` (7 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 8:11 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Guenter Roeck, Hartmut Knaack,
Heiko Stuebner, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c, linux-ide,
linux-iio, linux-input, linux-media, linux-mediatek, linux-mips,
linux-mmc, linux-mtd, linux-pci, linux-pm, linux-pwm,
linux-remoteproc, linux-rockchip, linux-serial, linux-spi,
linux-tegra, linux-usb, linux-watchdog, linux-wireless, netdev,
nouveau
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 8:11 ` Greg Kroah-Hartman
0 siblings, 0 replies; 260+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 8:11 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, linux-kernel
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 8:11 ` Greg Kroah-Hartman
0 siblings, 0 replies; 260+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 8:11 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 8:11 ` Greg Kroah-Hartman
0 siblings, 0 replies; 260+ messages in thread
From: Greg Kroah-Hartman @ 2017-07-20 8:11 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Kalle Valo, Laxman Dewangan,
Corentin Labbe, linux-i2c, linux-watchdog, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, Alexandre Torgue,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, linux-tegra, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> The reset control API has two modes: exclusive access, where the driver
> expects to have full and immediate control over the state of the reset
> line, and shared (clock-like) access, where drivers only request reset
> deassertion while active, but don't care about the state of the reset line
> while inactive.
>
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior.
>
> This series converts all drivers that currently implicitly request
> exclusive reset controls to the corresponding explicit API call. It is,
> for the most part, generated from the following semantic patch:
Hey, I'm all for large api changes, but this really seems ackward, isn't
there a "better" way to do this?
Why not, as you say the "implicit" request is exclusive, just leave
everything alone and state that the "reset_control_get()" call is
exclusive and make the shared one the "odd" usage as that seems to not
be the normal case.
That should be a much smaller patch right?
That way you don't break everything here, and require 100+ patches to
just change the name of a function from one to another and do nothing
else.
thanks,
greg k-h
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-20 8:11 ` Greg Kroah-Hartman
(?)
(?)
@ 2017-07-20 9:24 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Guenter Roeck, Hartmut Knaack,
Heiko Stuebner, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c, linux-ide,
linux-iio, linux-input, linux-media, linux-mediatek, linux-mips,
linux-mmc, linux-mtd, linux-pci, linux-pm, linux-pwm,
linux-remoteproc, linux-rockchip, linux-serial, linux-spi,
linux-tegra, linux-usb, linux-watchdog, linux-wireless, netdev,
nouveau
Hi Greg,
The patches in this series are completely independent of each other, and
I would like the subsystem maintainers to apply them at their own
leisure.
Well, except for the last one, which I will apply only after there are
no more users of the transition helpers.
On Thu, 2017-07-20 at 10:11 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
>
> Hey, I'm all for large api changes, but this really seems ackward, isn't
> there a "better" way to do this?
It is a bit awkward. I am sorry I haven't done this earlier. Quite a few
new drivers started using the old API after the explicit requests were
introduced last year.
> Why not, as you say the "implicit" request is exclusive, just leave
> everything alone and state that the "reset_control_get()" call is
> exclusive
I think it is better to let the drivers explicitly state what they
expect from the API, and using reset_control_get_exclusive vs _shared
helps driver developers to make a conscious decision.
Further, the implicit API call predates shared reset support, so it is
not clear that all of the old users really need exclusive control.
A few drivers have been switched to the shared API already.
> and make the shared one the "odd" usage as that seems to not
> be the normal case.
I am not sure, there have been people arguing that the "clock-like" case
really is the common one. I suppose some of those drivers touched by the
100 patches in this series could also be changed to shared. But I don't
dare to make this decision for each of them.
> That should be a much smaller patch right?
>
> That way you don't break everything here, and require 100+ patches to
> just change the name of a function from one to another and do nothing
> else.
I don't break anything here, and I'm absolutely fine with squashing
patches together per subsystem where that is preferable.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:24 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, linux-usb,
linux-wireless, linux-kernel
Hi Greg,
The patches in this series are completely independent of each other, and
I would like the subsystem maintainers to apply them at their own
leisure.
Well, except for the last one, which I will apply only after there are
no more users of the transition helpers.
On Thu, 2017-07-20 at 10:11 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
>
> Hey, I'm all for large api changes, but this really seems ackward, isn't
> there a "better" way to do this?
It is a bit awkward. I am sorry I haven't done this earlier. Quite a few
new drivers started using the old API after the explicit requests were
introduced last year.
> Why not, as you say the "implicit" request is exclusive, just leave
> everything alone and state that the "reset_control_get()" call is
> exclusive
I think it is better to let the drivers explicitly state what they
expect from the API, and using reset_control_get_exclusive vs _shared
helps driver developers to make a conscious decision.
Further, the implicit API call predates shared reset support, so it is
not clear that all of the old users really need exclusive control.
A few drivers have been switched to the shared API already.
> and make the shared one the "odd" usage as that seems to not
> be the normal case.
I am not sure, there have been people arguing that the "clock-like" case
really is the common one. I suppose some of those drivers touched by the
100 patches in this series could also be changed to shared. But I don't
dare to make this decision for each of them.
> That should be a much smaller patch right?
>
> That way you don't break everything here, and require 100+ patches to
> just change the name of a function from one to another and do nothing
> else.
I don't break anything here, and I'm absolutely fine with squashing
patches together per subsystem where that is preferable.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:24 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, linux-usb,
linux-wireless
Hi Greg,
The patches in this series are completely independent of each other, and
I would like the subsystem maintainers to apply them at their own
leisure.
Well, except for the last one, which I will apply only after there are
no more users of the transition helpers.
On Thu, 2017-07-20 at 10:11 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
>
> Hey, I'm all for large api changes, but this really seems ackward, isn't
> there a "better" way to do this?
It is a bit awkward. I am sorry I haven't done this earlier. Quite a few
new drivers started using the old API after the explicit requests were
introduced last year.
> Why not, as you say the "implicit" request is exclusive, just leave
> everything alone and state that the "reset_control_get()" call is
> exclusive
I think it is better to let the drivers explicitly state what they
expect from the API, and using reset_control_get_exclusive vs _shared
helps driver developers to make a conscious decision.
Further, the implicit API call predates shared reset support, so it is
not clear that all of the old users really need exclusive control.
A few drivers have been switched to the shared API already.
> and make the shared one the "odd" usage as that seems to not
> be the normal case.
I am not sure, there have been people arguing that the "clock-like" case
really is the common one. I suppose some of those drivers touched by the
100 patches in this series could also be changed to shared. But I don't
dare to make this decision for each of them.
> That should be a much smaller patch right?
>
> That way you don't break everything here, and require 100+ patches to
> just change the name of a function from one to another and do nothing
> else.
I don't break anything here, and I'm absolutely fine with squashing
patches together per subsystem where that is preferable.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:24 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Kalle Valo, Laxman Dewangan,
Corentin Labbe, linux-i2c, linux-watchdog, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, Alexandre Torgue,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, linux-tegra, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hi Greg,
The patches in this series are completely independent of each other, and
I would like the subsystem maintainers to apply them at their own
leisure.
Well, except for the last one, which I will apply only after there are
no more users of the transition helpers.
On Thu, 2017-07-20 at 10:11 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 19, 2017 at 05:25:04PM +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
>
> Hey, I'm all for large api changes, but this really seems ackward, isn't
> there a "better" way to do this?
It is a bit awkward. I am sorry I haven't done this earlier. Quite a few
new drivers started using the old API after the explicit requests were
introduced last year.
> Why not, as you say the "implicit" request is exclusive, just leave
> everything alone and state that the "reset_control_get()" call is
> exclusive
I think it is better to let the drivers explicitly state what they
expect from the API, and using reset_control_get_exclusive vs _shared
helps driver developers to make a conscious decision.
Further, the implicit API call predates shared reset support, so it is
not clear that all of the old users really need exclusive control.
A few drivers have been switched to the shared API already.
> and make the shared one the "odd" usage as that seems to not
> be the normal case.
I am not sure, there have been people arguing that the "clock-like" case
really is the common one. I suppose some of those drivers touched by the
100 patches in this series could also be changed to shared. But I don't
dare to make this decision for each of them.
> That should be a much smaller patch right?
>
> That way you don't break everything here, and require 100+ patches to
> just change the name of a function from one to another and do nothing
> else.
I don't break anything here, and I'm absolutely fine with squashing
patches together per subsystem where that is preferable.
regards
Philipp
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 042/102] mtd: nand: sunxi: explicitly request exclusive reset control
2017-07-20 7:00 ` Boris Brezillon
@ 2017-07-20 9:27 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:27 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-kernel, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Cyrille Pitchen, Maxime Ripard, Chen-Yu Tsai,
linux-mtd
On Thu, 2017-07-20 at 09:00 +0200, Boris Brezillon wrote:
> Hi Philipp,
>
> On Wed, 19 Jul 2017 17:25:46 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior. Convert all drivers requesting exclusive resets to the
> > explicit API call so the temporary transition helpers can be removed.
> >
> > No functional changes.
>
> If you don't mind, I'd like to take this patch in the nand tree, just in
> case we have other modifications on sunxi_nand.c for this cycle.
Absolutely, I'd like to only to apply the last two patches myself,
eventually.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 042/102] mtd: nand: sunxi: explicitly request exclusive reset control
@ 2017-07-20 9:27 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:27 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-kernel, Richard Weinberger, David Woodhouse, Brian Norris,
Marek Vasut, Cyrille Pitchen, Maxime Ripard, Chen-Yu Tsai,
linux-mtd
On Thu, 2017-07-20 at 09:00 +0200, Boris Brezillon wrote:
> Hi Philipp,
>
> On Wed, 19 Jul 2017 17:25:46 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior. Convert all drivers requesting exclusive resets to the
> > explicit API call so the temporary transition helpers can be removed.
> >
> > No functional changes.
>
> If you don't mind, I'd like to take this patch in the nand tree, just in
> case we have other modifications on sunxi_nand.c for this cycle.
Absolutely, I'd like to only to apply the last two patches myself,
eventually.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-19 19:15 ` Thomas Petazzoni
(?)
(?)
@ 2017-07-20 9:36 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:36 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
linux-i2c, linux-watchdog, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter, linux-rockchip,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, linux-pci, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hi Thomas,
On Wed, 2017-07-19 at 21:15 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
> >
> > @@
> > expression rstc, dev, id;
> > @@
> > -rstc = reset_control_get(dev, id);
> > +rstc = reset_control_get_exclusive(dev, id);
>
> I don't know if it has been discussed in the past, so forgive me if it
> has been. Have you considered adding a "int flags" argument to the
> existing reset_control_get_*() functions, rather than introducing
> separate exclusive variants ?
>
> Indeed, with a "int flags" argument you could in the future add more
> variants/behaviors without actually multiplying the number of
> functions. Something like the "flags" argument for request_irq() for
> example.
I can't find the discussion right now, but I remember we had talked
about this in the past.
Behind the scenes, all the inline API functions already call common
entry points with flags (well, currently separate bool parameters for
shared and optional).
One reason against exposing those as an int flags in the user facing API
is the possibility to accidentally provide a wrong value.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:36 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner
Hi Thomas,
On Wed, 2017-07-19 at 21:15 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
> >
> > @@
> > expression rstc, dev, id;
> > @@
> > -rstc = reset_control_get(dev, id);
> > +rstc = reset_control_get_exclusive(dev, id);
>
> I don't know if it has been discussed in the past, so forgive me if it
> has been. Have you considered adding a "int flags" argument to the
> existing reset_control_get_*() functions, rather than introducing
> separate exclusive variants ?
>
> Indeed, with a "int flags" argument you could in the future add more
> variants/behaviors without actually multiplying the number of
> functions. Something like the "flags" argument for request_irq() for
> example.
I can't find the discussion right now, but I remember we had talked
about this in the past.
Behind the scenes, all the inline API functions already call common
entry points with flags (well, currently separate bool parameters for
shared and optional).
One reason against exposing those as an int flags in the user facing API
is the possibility to accidentally provide a wrong value.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:36 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner
Hi Thomas,
On Wed, 2017-07-19 at 21:15 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
> >
> > @@
> > expression rstc, dev, id;
> > @@
> > -rstc = reset_control_get(dev, id);
> > +rstc = reset_control_get_exclusive(dev, id);
>
> I don't know if it has been discussed in the past, so forgive me if it
> has been. Have you considered adding a "int flags" argument to the
> existing reset_control_get_*() functions, rather than introducing
> separate exclusive variants ?
>
> Indeed, with a "int flags" argument you could in the future add more
> variants/behaviors without actually multiplying the number of
> functions. Something like the "flags" argument for request_irq() for
> example.
I can't find the discussion right now, but I remember we had talked
about this in the past.
Behind the scenes, all the inline API functions already call common
entry points with flags (well, currently separate bool parameters for
shared and optional).
One reason against exposing those as an int flags in the user facing API
is the possibility to accidentally provide a wrong value.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 9:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 9:36 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, linux-i2c, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, linux-watchdog,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou, linux-mediatek,
linux-tegra, Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
Hi Thomas,
On Wed, 2017-07-19 at 21:15 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 19 Jul 2017 17:25:04 +0200, Philipp Zabel wrote:
> > The reset control API has two modes: exclusive access, where the driver
> > expects to have full and immediate control over the state of the reset
> > line, and shared (clock-like) access, where drivers only request reset
> > deassertion while active, but don't care about the state of the reset line
> > while inactive.
> >
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior.
> >
> > This series converts all drivers that currently implicitly request
> > exclusive reset controls to the corresponding explicit API call. It is,
> > for the most part, generated from the following semantic patch:
> >
> > @@
> > expression rstc, dev, id;
> > @@
> > -rstc = reset_control_get(dev, id);
> > +rstc = reset_control_get_exclusive(dev, id);
>
> I don't know if it has been discussed in the past, so forgive me if it
> has been. Have you considered adding a "int flags" argument to the
> existing reset_control_get_*() functions, rather than introducing
> separate exclusive variants ?
>
> Indeed, with a "int flags" argument you could in the future add more
> variants/behaviors without actually multiplying the number of
> functions. Something like the "flags" argument for request_irq() for
> example.
I can't find the discussion right now, but I remember we had talked
about this in the past.
Behind the scenes, all the inline API functions already call common
entry points with flags (well, currently separate bool parameters for
shared and optional).
One reason against exposing those as an int flags in the user facing API
is the possibility to accidentally provide a wrong value.
regards
Philipp
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 022/102] drm/sti: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 022/102] drm/sti: " Philipp Zabel
@ 2017-07-20 10:09 ` Benjamin Gaignard
0 siblings, 0 replies; 260+ messages in thread
From: Benjamin Gaignard @ 2017-07-20 10:09 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Linux Kernel Mailing List, Vincent Abriou, dri-devel
2017-07-19 17:25 GMT+02:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
> drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
> drivers/gpu/drm/sti/sti_tvout.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index a59c95a8081b7..ea6e5b5a3725b 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1428,7 +1428,7 @@ static int sti_hdmi_probe(struct platform_device *pdev)
> if (!hdmi->notifier)
> goto release_adapter;
>
> - hdmi->reset = devm_reset_control_get(dev, "hdmi");
> + hdmi->reset = devm_reset_control_get_exclusive(dev, "hdmi");
> /* Take hdmi out of reset */
> if (!IS_ERR(hdmi->reset))
> reset_control_deassert(hdmi->reset);
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index a1c161f778044..2809db8c03216 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1375,7 +1375,7 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
> }
>
> /* Get reset resources */
> - hqvdp->reset = devm_reset_control_get(dev, "hqvdp");
> + hqvdp->reset = devm_reset_control_get_exclusive(dev, "hqvdp");
> if (!IS_ERR(hqvdp->reset))
> reset_control_deassert(hqvdp->reset);
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index 8959fcc743a8e..cbe0f5c162348 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -857,7 +857,7 @@ static int sti_tvout_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* get reset resources */
> - tvout->reset = devm_reset_control_get(dev, "tvout");
> + tvout->reset = devm_reset_control_get_exclusive(dev, "tvout");
> /* take tvout out of reset */
> if (!IS_ERR(tvout->reset))
> reset_control_deassert(tvout->reset);
> --
> 2.11.0
>
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 022/102] drm/sti: explicitly request exclusive reset control
@ 2017-07-20 10:09 ` Benjamin Gaignard
0 siblings, 0 replies; 260+ messages in thread
From: Benjamin Gaignard @ 2017-07-20 10:09 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Vincent Abriou, Linux Kernel Mailing List, dri-devel
2017-07-19 17:25 GMT+02:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
> drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
> drivers/gpu/drm/sti/sti_tvout.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index a59c95a8081b7..ea6e5b5a3725b 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1428,7 +1428,7 @@ static int sti_hdmi_probe(struct platform_device *pdev)
> if (!hdmi->notifier)
> goto release_adapter;
>
> - hdmi->reset = devm_reset_control_get(dev, "hdmi");
> + hdmi->reset = devm_reset_control_get_exclusive(dev, "hdmi");
> /* Take hdmi out of reset */
> if (!IS_ERR(hdmi->reset))
> reset_control_deassert(hdmi->reset);
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index a1c161f778044..2809db8c03216 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1375,7 +1375,7 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
> }
>
> /* Get reset resources */
> - hqvdp->reset = devm_reset_control_get(dev, "hqvdp");
> + hqvdp->reset = devm_reset_control_get_exclusive(dev, "hqvdp");
> if (!IS_ERR(hqvdp->reset))
> reset_control_deassert(hqvdp->reset);
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index 8959fcc743a8e..cbe0f5c162348 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -857,7 +857,7 @@ static int sti_tvout_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* get reset resources */
> - tvout->reset = devm_reset_control_get(dev, "tvout");
> + tvout->reset = devm_reset_control_get_exclusive(dev, "tvout");
> /* take tvout out of reset */
> if (!IS_ERR(tvout->reset))
> reset_control_deassert(tvout->reset);
> --
> 2.11.0
>
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 10:36 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-20 10:36 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
linux-i2c, linux-watchdog, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter, linux-rockchip,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, linux-pci, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hello,
On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
> > I don't know if it has been discussed in the past, so forgive me if it
> > has been. Have you considered adding a "int flags" argument to the
> > existing reset_control_get_*() functions, rather than introducing
> > separate exclusive variants ?
> >
> > Indeed, with a "int flags" argument you could in the future add more
> > variants/behaviors without actually multiplying the number of
> > functions. Something like the "flags" argument for request_irq() for
> > example.
>
> I can't find the discussion right now, but I remember we had talked
> about this in the past.
> Behind the scenes, all the inline API functions already call common
> entry points with flags (well, currently separate bool parameters for
> shared and optional).
> One reason against exposing those as an int flags in the user facing API
> is the possibility to accidentally provide a wrong value.
This is a quite strange argument. You could also accidentally use the
wrong variant of the function, just like you could use the wrong flag.
Once again, the next time you have another parameter for those reset
functions, beyond the exclusive/shared variant, you will multiply again
by two the number of functions ? You already have the exclusive/shared
and optional/mandatory variants, so 4 variants. When you'll add a new
parameter, you'll have 8 variants. Doesn't seem really good.
What about reset_control_get(struct device *, const char *, int flags)
to replace all those variants ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 10:36 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-20 10:36 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hello,
On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
> > I don't know if it has been discussed in the past, so forgive me if it
> > has been. Have you considered adding a "int flags" argument to the
> > existing reset_control_get_*() functions, rather than introducing
> > separate exclusive variants ?
> >
> > Indeed, with a "int flags" argument you could in the future add more
> > variants/behaviors without actually multiplying the number of
> > functions. Something like the "flags" argument for request_irq() for
> > example.
>
> I can't find the discussion right now, but I remember we had talked
> about this in the past.
> Behind the scenes, all the inline API functions already call common
> entry points with flags (well, currently separate bool parameters for
> shared and optional).
> One reason against exposing those as an int flags in the user facing API
> is the possibility to accidentally provide a wrong value.
This is a quite strange argument. You could also accidentally use the
wrong variant of the function, just like you could use the wrong flag.
Once again, the next time you have another parameter for those reset
functions, beyond the exclusive/shared variant, you will multiply again
by two the number of functions ? You already have the exclusive/shared
and optional/mandatory variants, so 4 variants. When you'll add a new
parameter, you'll have 8 variants. Doesn't seem really good.
What about reset_control_get(struct device *, const char *, int flags)
to replace all those variants ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 10:36 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-20 10:36 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hello,
On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
> > I don't know if it has been discussed in the past, so forgive me if it
> > has been. Have you considered adding a "int flags" argument to the
> > existing reset_control_get_*() functions, rather than introducing
> > separate exclusive variants ?
> >
> > Indeed, with a "int flags" argument you could in the future add more
> > variants/behaviors without actually multiplying the number of
> > functions. Something like the "flags" argument for request_irq() for
> > example.
>
> I can't find the discussion right now, but I remember we had talked
> about this in the past.
> Behind the scenes, all the inline API functions already call common
> entry points with flags (well, currently separate bool parameters for
> shared and optional).
> One reason against exposing those as an int flags in the user facing API
> is the possibility to accidentally provide a wrong value.
This is a quite strange argument. You could also accidentally use the
wrong variant of the function, just like you could use the wrong flag.
Once again, the next time you have another parameter for those reset
functions, beyond the exclusive/shared variant, you will multiply again
by two the number of functions ? You already have the exclusive/shared
and optional/mandatory variants, so 4 variants. When you'll add a new
parameter, you'll have 8 variants. Doesn't seem really good.
What about reset_control_get(struct device *, const char *, int flags)
to replace all those variants ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 10:36 ` Thomas Petazzoni
0 siblings, 0 replies; 260+ messages in thread
From: Thomas Petazzoni @ 2017-07-20 10:36 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, linux-i2c, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, linux-watchdog,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou, linux-mediatek,
linux-tegra, Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
Hello,
On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
> > I don't know if it has been discussed in the past, so forgive me if it
> > has been. Have you considered adding a "int flags" argument to the
> > existing reset_control_get_*() functions, rather than introducing
> > separate exclusive variants ?
> >
> > Indeed, with a "int flags" argument you could in the future add more
> > variants/behaviors without actually multiplying the number of
> > functions. Something like the "flags" argument for request_irq() for
> > example.
>
> I can't find the discussion right now, but I remember we had talked
> about this in the past.
> Behind the scenes, all the inline API functions already call common
> entry points with flags (well, currently separate bool parameters for
> shared and optional).
> One reason against exposing those as an int flags in the user facing API
> is the possibility to accidentally provide a wrong value.
This is a quite strange argument. You could also accidentally use the
wrong variant of the function, just like you could use the wrong flag.
Once again, the next time you have another parameter for those reset
functions, beyond the exclusive/shared variant, you will multiply again
by two the number of functions ? You already have the exclusive/shared
and optional/mandatory variants, so 4 variants. When you'll add a new
parameter, you'll have 8 variants. Doesn't seem really good.
What about reset_control_get(struct device *, const char *, int flags)
to replace all those variants ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-20 10:36 ` Thomas Petazzoni
(?)
(?)
@ 2017-07-20 12:55 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 12:55 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
linux-usb, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
linux-i2c, linux-watchdog, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter, linux-rockchip,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, linux-pci, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hi Thomas,
On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>
> > > I don't know if it has been discussed in the past, so forgive me if it
> > > has been. Have you considered adding a "int flags" argument to the
> > > existing reset_control_get_*() functions, rather than introducing
> > > separate exclusive variants ?
> > >
> > > Indeed, with a "int flags" argument you could in the future add more
> > > variants/behaviors without actually multiplying the number of
> > > functions. Something like the "flags" argument for request_irq() for
> > > example.
> >
> > I can't find the discussion right now, but I remember we had talked
> > about this in the past.
> > Behind the scenes, all the inline API functions already call common
> > entry points with flags (well, currently separate bool parameters for
> > shared and optional).
> > One reason against exposing those as an int flags in the user facing API
> > is the possibility to accidentally provide a wrong value.
>
> This is a quite strange argument. You could also accidentally use the
> wrong variant of the function, just like you could use the wrong flag.
You can't accidentally use no flag at all or a completely bogus value
with the "plethora of inline functions" variant.
> Once again, the next time you have another parameter for those reset
> functions, beyond the exclusive/shared variant, you will multiply again
> by two the number of functions ? You already have the exclusive/shared
> and optional/mandatory variants, so 4 variants. When you'll add a new
> parameter, you'll have 8 variants. Doesn't seem really good.
I'd rather avoid adding more variants, if possible. The complexity
increases regardless of whether the API is expressed as a bunch of
functions or as a single function with a bunch of flags.
> What about reset_control_get(struct device *, const char *, int flags)
> to replace all those variants ?
While I like how this looks, unfortunately (devm_)reset_control_get
already exists without the flags, so we can't change to that with a
gentle transition.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 12:55 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 12:55 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner
Hi Thomas,
On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>
> > > I don't know if it has been discussed in the past, so forgive me if it
> > > has been. Have you considered adding a "int flags" argument to the
> > > existing reset_control_get_*() functions, rather than introducing
> > > separate exclusive variants ?
> > >
> > > Indeed, with a "int flags" argument you could in the future add more
> > > variants/behaviors without actually multiplying the number of
> > > functions. Something like the "flags" argument for request_irq() for
> > > example.
> >
> > I can't find the discussion right now, but I remember we had talked
> > about this in the past.
> > Behind the scenes, all the inline API functions already call common
> > entry points with flags (well, currently separate bool parameters for
> > shared and optional).
> > One reason against exposing those as an int flags in the user facing API
> > is the possibility to accidentally provide a wrong value.
>
> This is a quite strange argument. You could also accidentally use the
> wrong variant of the function, just like you could use the wrong flag.
You can't accidentally use no flag at all or a completely bogus value
with the "plethora of inline functions" variant.
> Once again, the next time you have another parameter for those reset
> functions, beyond the exclusive/shared variant, you will multiply again
> by two the number of functions ? You already have the exclusive/shared
> and optional/mandatory variants, so 4 variants. When you'll add a new
> parameter, you'll have 8 variants. Doesn't seem really good.
I'd rather avoid adding more variants, if possible. The complexity
increases regardless of whether the API is expressed as a bunch of
functions or as a single function with a bunch of flags.
> What about reset_control_get(struct device *, const char *, int flags)
> to replace all those variants ?
While I like how this looks, unfortunately (devm_)reset_control_get
already exists without the flags, so we can't change to that with a
gentle transition.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 12:55 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 12:55 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: linux-kernel, Andrew Lunn, Prashant Gaikwad, Heiko Stuebner,
Peter Chen, Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner
Hi Thomas,
On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>
> > > I don't know if it has been discussed in the past, so forgive me if it
> > > has been. Have you considered adding a "int flags" argument to the
> > > existing reset_control_get_*() functions, rather than introducing
> > > separate exclusive variants ?
> > >
> > > Indeed, with a "int flags" argument you could in the future add more
> > > variants/behaviors without actually multiplying the number of
> > > functions. Something like the "flags" argument for request_irq() for
> > > example.
> >
> > I can't find the discussion right now, but I remember we had talked
> > about this in the past.
> > Behind the scenes, all the inline API functions already call common
> > entry points with flags (well, currently separate bool parameters for
> > shared and optional).
> > One reason against exposing those as an int flags in the user facing API
> > is the possibility to accidentally provide a wrong value.
>
> This is a quite strange argument. You could also accidentally use the
> wrong variant of the function, just like you could use the wrong flag.
You can't accidentally use no flag at all or a completely bogus value
with the "plethora of inline functions" variant.
> Once again, the next time you have another parameter for those reset
> functions, beyond the exclusive/shared variant, you will multiply again
> by two the number of functions ? You already have the exclusive/shared
> and optional/mandatory variants, so 4 variants. When you'll add a new
> parameter, you'll have 8 variants. Doesn't seem really good.
I'd rather avoid adding more variants, if possible. The complexity
increases regardless of whether the API is expressed as a bunch of
functions or as a single function with a bunch of flags.
> What about reset_control_get(struct device *, const char *, int flags)
> to replace all those variants ?
While I like how this looks, unfortunately (devm_)reset_control_get
already exists without the flags, so we can't change to that with a
gentle transition.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 12:55 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-20 12:55 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, linux-i2c, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, linux-watchdog,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou, linux-mediatek,
linux-tegra, Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
Hi Thomas,
On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>
> > > I don't know if it has been discussed in the past, so forgive me if it
> > > has been. Have you considered adding a "int flags" argument to the
> > > existing reset_control_get_*() functions, rather than introducing
> > > separate exclusive variants ?
> > >
> > > Indeed, with a "int flags" argument you could in the future add more
> > > variants/behaviors without actually multiplying the number of
> > > functions. Something like the "flags" argument for request_irq() for
> > > example.
> >
> > I can't find the discussion right now, but I remember we had talked
> > about this in the past.
> > Behind the scenes, all the inline API functions already call common
> > entry points with flags (well, currently separate bool parameters for
> > shared and optional).
> > One reason against exposing those as an int flags in the user facing API
> > is the possibility to accidentally provide a wrong value.
>
> This is a quite strange argument. You could also accidentally use the
> wrong variant of the function, just like you could use the wrong flag.
You can't accidentally use no flag at all or a completely bogus value
with the "plethora of inline functions" variant.
> Once again, the next time you have another parameter for those reset
> functions, beyond the exclusive/shared variant, you will multiply again
> by two the number of functions ? You already have the exclusive/shared
> and optional/mandatory variants, so 4 variants. When you'll add a new
> parameter, you'll have 8 variants. Doesn't seem really good.
I'd rather avoid adding more variants, if possible. The complexity
increases regardless of whether the API is expressed as a bunch of
functions or as a single function with a bunch of flags.
> What about reset_control_get(struct device *, const char *, int flags)
> to replace all those variants ?
While I like how this looks, unfortunately (devm_)reset_control_get
already exists without the flags, so we can't change to that with a
gentle transition.
regards
Philipp
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 001/102] ARM: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 001/102] ARM: rockchip: explicitly request exclusive reset control Philipp Zabel
@ 2017-07-20 20:28 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:28 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, linux-rockchip
Am Mittwoch, 19. Juli 2017, 17:25:05 CEST schrieb Philipp Zabel:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
amended the subject with an "[...] in smp code" and applied for 4.14
Heiko
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-19 15:25 ` Philipp Zabel
` (3 preceding siblings ...)
(?)
@ 2017-07-20 20:32 ` Heiko Stuebner
-1 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c, linux-ide,
linux-iio, linux-input, linux-media, linux-mediatek, linux-mips,
linux-mmc, linux-mtd, linux-pci, linux-pm, linux-pwm,
linux-remoteproc, linux-rockchip, linux-serial, linux-spi,
linux-tegra, linux-usb, linux-watchdog, linux-wireless, netdev,
nouveau
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-20 20:32 ` Heiko Stuebner
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-19 15:25 ` Philipp Zabel
@ 2017-07-20 20:32 ` Heiko Stuebner
-1 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel, Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk, Wim Van Sebroeck, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-20 20:32 ` Heiko Stuebner
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2017-07-20 20:32 ` Heiko Stuebner
2017-07-19 15:26 ` Philipp Zabel
` (9 subsequent siblings)
10 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel, Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk, Wim Van Sebroeck, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 260+ messages in thread
* (no subject)
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 260+ messages in thread
* (no subject)
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, Stanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano, David Airlie, David Woodhouse, Dmitry Torokhov,
Eduardo Valentin, Felipe Balbi, Florian Fainelli,
Giuseppe Cavallaro, Greg Kroah-Hartman, Guenter Roeck,
Hartmut Knaack, Herbert Xu, Jaehoon Chung, Jiri Slaby,
Joachim Eastwood, John Youn, Jon Hunter, Jonathan Cameron,
Jonathan Corbet, Kalle Valo, Kishon Vijay Abraham I,
Kyungmin Park, Lars-Peter Clausen, Laxman Dewangan, Lee Jones,
Liam Girdwood, Linus Walleij, Lucas Stach, Marc Dietrich,
Marek Vasut, Mark Brown, Mark Yao, Mathias Nyman,
Matthias Brugger, Maxime Coquelin, Maxime Ripard,
Michael Turquette, Moritz Fischer, MyungJoo Ham, Ohad Ben-Cohen,
Patrice Chotard, Peter Chen, Peter De Schrijver,
Peter Meerwald-Stadler, Philippe Cornu, Prashant Gaikwad,
Rakesh Iyer, Ralf Baechle, Richard Weinberger, Richard Zhu,
Rongrong Zou, Ryder Lee, Salil Mehta, Shawn Lin,
Srinivas Kandagatla, S tanimir Varbanov, Stephen Boyd, Tejun Heo,
Thierry Reding, Thomas Gleixner, Ulf Hansson, Vincent Abriou,
Vinod Koul, Vivien Didelot, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Xinwei Kong, Yannick Fertre, Yisen Zhuang,
Zhang Rui, alsa-devel, ath10k, devel, dmaengine, dri-devel,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-crypto,
linux-doc, linux-fpga, linux-gpio, linux-i2c
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:32 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Peter Chen, Linus Walleij,
dri-devel, Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk, Wim Van Sebroeck, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, linux-usb,
linux-wireless, linux-kernel, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Kalle Valo, Laxman Dewangan,
Corentin Labbe, linux-i2c, linux-watchdog, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, linux-rockchip, MyungJoo Ham, Ben Skeggs,
Yisen Zhuang, linux-media, Richard Zhu, Alexandre Torgue,
Mathias Nyman, linux-arm-msm, Joachim Eastwood, linux-gpio,
linux-mips, Bjorn Helgaas, Giuseppe Cavallaro, linux-arm-kernel,
Patrice Chotard, Stanimir Varbanov, Kyungmin Park,
Maxime Coquelin, Hartmut Knaack, Jonathan Cameron, Ulf Hansson,
linux-iio, linux-pci, Shawn Lin, linux-tegra, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Liam Girdwood, Thierry Reding, Cyrille Pitchen,
Srinivas Kandagatla, Maxime Ripard, Brian Norris,
David S. Miller, linux-remoteproc, Bjorn Andersson, linux-ide,
Lee Jones, devel, Yannick Fertre, Ryder Lee, Herbert Xu,
Richard Weinberger, Jaehoon Chung, Marek Vasut, linux-serial,
Zhang Rui, Alan Tull, John Youn, Eduardo Valentin, dmaengine,
linux-mediatek, Matthias Brugger, Mark Yao, Moritz Fischer,
Vivien Didelot, netdev, Peter De Schrijver, Stephen Boyd,
Adrian Hunter, Vinod Koul, Rongrong Zou, linux-fpga,
David Woodhouse, Lucas Stach
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* (no subject)
@ 2017-07-20 20:32 ` Heiko Stuebner
0 siblings, 0 replies; 260+ messages in thread
From: Heiko Stuebner @ 2017-07-20 20:36 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, David S. Miller, Emilio López, Adrian Hunter,
Alan Stern, Alan Tull, Alexandre Torgue, Andrew Lunn, Ben Skeggs,
Benjamin Gaignard, Bin Liu, Bjorn Andersson, Bjorn Helgaas,
Boris Brezillon, Brian Norris, Chanwoo Choi, Chen Feng,
Chen-Yu Tsai, Corentin Labbe, Cyrille Pitchen, Dan Williams,
Daniel Lezcano
Hi,
> crypto: rockchip: explicitly request exclusive reset control
> iio: adc: rockchip_saradc: explicitly request exclusive reset control
> PCI: rockchip: explicitly request exclusive reset control
> phy: rockchip-pcie: explicitly request exclusive reset control
> phy: rockchip-typec: explicitly request exclusive reset control
> phy: rockchip-usb: explicitly request exclusive reset control
> thermal: rockchip: explicitly request exclusive reset control
for the driver-related Rockchip changes
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-20 12:55 ` Philipp Zabel
(?)
(?)
@ 2017-07-20 20:46 ` Dmitry Torokhov
-1 siblings, 0 replies; 260+ messages in thread
From: Dmitry Torokhov @ 2017-07-20 20:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Thomas Petazzoni, lkml, Andrew Lunn, Prashant Gaikwad,
Heiko Stuebner, Peter Chen, Linus Walleij, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
USB list, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
Linux I2C, LINUXWATCHDOG, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter,
open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, Linux PCI, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Liam Girdwood,
Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, dmaengine, linux-mediatek, Matthias Brugger,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
Rongrong Zou, linux-fpga, David Woodhouse, Lucas Stach
On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Thomas,
>
> On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>>
>> > > I don't know if it has been discussed in the past, so forgive me if it
>> > > has been. Have you considered adding a "int flags" argument to the
>> > > existing reset_control_get_*() functions, rather than introducing
>> > > separate exclusive variants ?
>> > >
>> > > Indeed, with a "int flags" argument you could in the future add more
>> > > variants/behaviors without actually multiplying the number of
>> > > functions. Something like the "flags" argument for request_irq() for
>> > > example.
>> >
>> > I can't find the discussion right now, but I remember we had talked
>> > about this in the past.
>> > Behind the scenes, all the inline API functions already call common
>> > entry points with flags (well, currently separate bool parameters for
>> > shared and optional).
>> > One reason against exposing those as an int flags in the user facing API
>> > is the possibility to accidentally provide a wrong value.
>>
>> This is a quite strange argument. You could also accidentally use the
>> wrong variant of the function, just like you could use the wrong flag.
>
> You can't accidentally use no flag at all or a completely bogus value
> with the "plethora of inline functions" variant.
>
>> Once again, the next time you have another parameter for those reset
>> functions, beyond the exclusive/shared variant, you will multiply again
>> by two the number of functions ? You already have the exclusive/shared
>> and optional/mandatory variants, so 4 variants. When you'll add a new
>> parameter, you'll have 8 variants. Doesn't seem really good.
>
> I'd rather avoid adding more variants, if possible. The complexity
> increases regardless of whether the API is expressed as a bunch of
> functions or as a single function with a bunch of flags.
>
>> What about reset_control_get(struct device *, const char *, int flags)
>> to replace all those variants ?
>
> While I like how this looks, unfortunately (devm_)reset_control_get
> already exists without the flags, so we can't change to that with a
> gentle transition.
This was done for gpiod_get() and its flags argument with horrifying
#define-ry, which thankfully was completely hidden from users.
--
Dmitry
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:46 ` Dmitry Torokhov
0 siblings, 0 replies; 260+ messages in thread
From: Dmitry Torokhov @ 2017-07-20 20:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Thomas Petazzoni, lkml, Andrew Lunn, Prashant Gaikwad,
Heiko Stuebner, Peter Chen, Linus Walleij, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck
On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Thomas,
>
> On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>>
>> > > I don't know if it has been discussed in the past, so forgive me if it
>> > > has been. Have you considered adding a "int flags" argument to the
>> > > existing reset_control_get_*() functions, rather than introducing
>> > > separate exclusive variants ?
>> > >
>> > > Indeed, with a "int flags" argument you could in the future add more
>> > > variants/behaviors without actually multiplying the number of
>> > > functions. Something like the "flags" argument for request_irq() for
>> > > example.
>> >
>> > I can't find the discussion right now, but I remember we had talked
>> > about this in the past.
>> > Behind the scenes, all the inline API functions already call common
>> > entry points with flags (well, currently separate bool parameters for
>> > shared and optional).
>> > One reason against exposing those as an int flags in the user facing API
>> > is the possibility to accidentally provide a wrong value.
>>
>> This is a quite strange argument. You could also accidentally use the
>> wrong variant of the function, just like you could use the wrong flag.
>
> You can't accidentally use no flag at all or a completely bogus value
> with the "plethora of inline functions" variant.
>
>> Once again, the next time you have another parameter for those reset
>> functions, beyond the exclusive/shared variant, you will multiply again
>> by two the number of functions ? You already have the exclusive/shared
>> and optional/mandatory variants, so 4 variants. When you'll add a new
>> parameter, you'll have 8 variants. Doesn't seem really good.
>
> I'd rather avoid adding more variants, if possible. The complexity
> increases regardless of whether the API is expressed as a bunch of
> functions or as a single function with a bunch of flags.
>
>> What about reset_control_get(struct device *, const char *, int flags)
>> to replace all those variants ?
>
> While I like how this looks, unfortunately (devm_)reset_control_get
> already exists without the flags, so we can't change to that with a
> gentle transition.
This was done for gpiod_get() and its flags argument with horrifying
#define-ry, which thankfully was completely hidden from users.
--
Dmitry
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:46 ` Dmitry Torokhov
0 siblings, 0 replies; 260+ messages in thread
From: Dmitry Torokhov @ 2017-07-20 20:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Thomas Petazzoni, lkml, Andrew Lunn, Prashant Gaikwad,
Heiko Stuebner, Peter Chen, Linus Walleij, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck
On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Thomas,
>
> On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>>
>> > > I don't know if it has been discussed in the past, so forgive me if it
>> > > has been. Have you considered adding a "int flags" argument to the
>> > > existing reset_control_get_*() functions, rather than introducing
>> > > separate exclusive variants ?
>> > >
>> > > Indeed, with a "int flags" argument you could in the future add more
>> > > variants/behaviors without actually multiplying the number of
>> > > functions. Something like the "flags" argument for request_irq() for
>> > > example.
>> >
>> > I can't find the discussion right now, but I remember we had talked
>> > about this in the past.
>> > Behind the scenes, all the inline API functions already call common
>> > entry points with flags (well, currently separate bool parameters for
>> > shared and optional).
>> > One reason against exposing those as an int flags in the user facing API
>> > is the possibility to accidentally provide a wrong value.
>>
>> This is a quite strange argument. You could also accidentally use the
>> wrong variant of the function, just like you could use the wrong flag.
>
> You can't accidentally use no flag at all or a completely bogus value
> with the "plethora of inline functions" variant.
>
>> Once again, the next time you have another parameter for those reset
>> functions, beyond the exclusive/shared variant, you will multiply again
>> by two the number of functions ? You already have the exclusive/shared
>> and optional/mandatory variants, so 4 variants. When you'll add a new
>> parameter, you'll have 8 variants. Doesn't seem really good.
>
> I'd rather avoid adding more variants, if possible. The complexity
> increases regardless of whether the API is expressed as a bunch of
> functions or as a single function with a bunch of flags.
>
>> What about reset_control_get(struct device *, const char *, int flags)
>> to replace all those variants ?
>
> While I like how this looks, unfortunately (devm_)reset_control_get
> already exists without the flags, so we can't change to that with a
> gentle transition.
This was done for gpiod_get() and its flags argument with horrifying
#define-ry, which thankfully was completely hidden from users.
--
Dmitry
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-20 20:46 ` Dmitry Torokhov
0 siblings, 0 replies; 260+ messages in thread
From: Dmitry Torokhov @ 2017-07-20 20:46 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, DRI, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Wolfram Sang, Xinliang Liu,
Chanwoo Choi, Alan Stern, Jiri Slaby, Michael Turquette,
Guenter Roeck, Ohad Ben-Cohen, linux-pm, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, USB list,
linux-wireless, lkml, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, Linux I2C, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
LINUXWATCHDOG, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Thomas Petazzoni, Patrice Chotard,
Stanimir Varbanov, Kyungmin Park, Maxime Coquelin,
Hartmut Knaack, Jonathan Cameron, Ulf Hansson, linux-iio,
Linux PCI, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Kalle Valo, Thierry Reding,
Cyrille Pitchen, Srinivas Kandagatla, Maxime Ripard,
Brian Norris, David S. Miller, Liam Girdwood, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, Rongrong Zou, linux-mediatek, linux-tegra,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Thomas,
>
> On Thu, 2017-07-20 at 12:36 +0200, Thomas Petazzoni wrote:
>> Hello,
>>
>> On Thu, 20 Jul 2017 11:36:55 +0200, Philipp Zabel wrote:
>>
>> > > I don't know if it has been discussed in the past, so forgive me if it
>> > > has been. Have you considered adding a "int flags" argument to the
>> > > existing reset_control_get_*() functions, rather than introducing
>> > > separate exclusive variants ?
>> > >
>> > > Indeed, with a "int flags" argument you could in the future add more
>> > > variants/behaviors without actually multiplying the number of
>> > > functions. Something like the "flags" argument for request_irq() for
>> > > example.
>> >
>> > I can't find the discussion right now, but I remember we had talked
>> > about this in the past.
>> > Behind the scenes, all the inline API functions already call common
>> > entry points with flags (well, currently separate bool parameters for
>> > shared and optional).
>> > One reason against exposing those as an int flags in the user facing API
>> > is the possibility to accidentally provide a wrong value.
>>
>> This is a quite strange argument. You could also accidentally use the
>> wrong variant of the function, just like you could use the wrong flag.
>
> You can't accidentally use no flag at all or a completely bogus value
> with the "plethora of inline functions" variant.
>
>> Once again, the next time you have another parameter for those reset
>> functions, beyond the exclusive/shared variant, you will multiply again
>> by two the number of functions ? You already have the exclusive/shared
>> and optional/mandatory variants, so 4 variants. When you'll add a new
>> parameter, you'll have 8 variants. Doesn't seem really good.
>
> I'd rather avoid adding more variants, if possible. The complexity
> increases regardless of whether the API is expressed as a bunch of
> functions or as a single function with a bunch of flags.
>
>> What about reset_control_get(struct device *, const char *, int flags)
>> to replace all those variants ?
>
> While I like how this looks, unfortunately (devm_)reset_control_get
> already exists without the flags, so we can't change to that with a
> gentle transition.
This was done for gpiod_get() and its flags argument with horrifying
#define-ry, which thankfully was completely hidden from users.
--
Dmitry
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control
2017-07-19 15:26 ` Philipp Zabel
(?)
@ 2017-07-22 13:09 ` Shawn Lin
-1 siblings, 0 replies; 260+ messages in thread
From: Shawn Lin @ 2017-07-22 13:09 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, shawn.lin, linux-rockchip, Heiko Stuebner,
Kishon Vijay Abraham I
Hi Philipp
On 2017/7/19 23:26, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
This driver is under reconstruction and would probably go via
pci tree later. So I would mention your change to the reconstruction
work if that's applied.
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
> index 6904633cad687..258220b7f481c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-pcie.c
> +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
> @@ -305,7 +305,7 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
> rk_phy->phy_data = (struct rockchip_pcie_data *)of_id->data;
> rk_phy->reg_base = grf;
>
> - rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
> + rk_phy->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
> if (IS_ERR(rk_phy->phy_rst)) {
> if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
> dev_err(dev,
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
(?)
@ 2017-07-22 13:12 ` Shawn Lin
2017-07-24 8:35 ` Philipp Zabel
-1 siblings, 1 reply; 260+ messages in thread
From: Shawn Lin @ 2017-07-22 13:12 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, shawn.lin, Bjorn Helgaas, Heiko Stuebner,
linux-pci, linux-rockchip
Hi Philipp,
On 2017/7/19 23:25, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Shawn Lin <shawn.lin@rock-chips.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
As mentioned in the thread of conversion for phy-rockchip-pcie,
I would prefer add your patches after the reconstruction work got
merged.
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index 7bb9870f6d8ce..e50d6f5a81f4b 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -903,49 +903,50 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
> if (rockchip->link_gen < 0 || rockchip->link_gen > 2)
> rockchip->link_gen = 2;
>
> - rockchip->core_rst = devm_reset_control_get(dev, "core");
> + rockchip->core_rst = devm_reset_control_get_exclusive(dev, "core");
> if (IS_ERR(rockchip->core_rst)) {
> if (PTR_ERR(rockchip->core_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing core reset property in node\n");
> return PTR_ERR(rockchip->core_rst);
> }
>
> - rockchip->mgmt_rst = devm_reset_control_get(dev, "mgmt");
> + rockchip->mgmt_rst = devm_reset_control_get_exclusive(dev, "mgmt");
> if (IS_ERR(rockchip->mgmt_rst)) {
> if (PTR_ERR(rockchip->mgmt_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt reset property in node\n");
> return PTR_ERR(rockchip->mgmt_rst);
> }
>
> - rockchip->mgmt_sticky_rst = devm_reset_control_get(dev, "mgmt-sticky");
> + rockchip->mgmt_sticky_rst = devm_reset_control_get_exclusive(dev,
> + "mgmt-sticky");
> if (IS_ERR(rockchip->mgmt_sticky_rst)) {
> if (PTR_ERR(rockchip->mgmt_sticky_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt-sticky reset property in node\n");
> return PTR_ERR(rockchip->mgmt_sticky_rst);
> }
>
> - rockchip->pipe_rst = devm_reset_control_get(dev, "pipe");
> + rockchip->pipe_rst = devm_reset_control_get_exclusive(dev, "pipe");
> if (IS_ERR(rockchip->pipe_rst)) {
> if (PTR_ERR(rockchip->pipe_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pipe reset property in node\n");
> return PTR_ERR(rockchip->pipe_rst);
> }
>
> - rockchip->pm_rst = devm_reset_control_get(dev, "pm");
> + rockchip->pm_rst = devm_reset_control_get_exclusive(dev, "pm");
> if (IS_ERR(rockchip->pm_rst)) {
> if (PTR_ERR(rockchip->pm_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pm reset property in node\n");
> return PTR_ERR(rockchip->pm_rst);
> }
>
> - rockchip->pclk_rst = devm_reset_control_get(dev, "pclk");
> + rockchip->pclk_rst = devm_reset_control_get_exclusive(dev, "pclk");
> if (IS_ERR(rockchip->pclk_rst)) {
> if (PTR_ERR(rockchip->pclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pclk reset property in node\n");
> return PTR_ERR(rockchip->pclk_rst);
> }
>
> - rockchip->aclk_rst = devm_reset_control_get(dev, "aclk");
> + rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
> if (IS_ERR(rockchip->aclk_rst)) {
> if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing aclk reset property in node\n");
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 038/102] mmc: dw_mmc: " Philipp Zabel
@ 2017-07-22 13:13 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
1 sibling, 0 replies; 260+ messages in thread
From: Shawn Lin @ 2017-07-22 13:13 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, shawn.lin, Jaehoon Chung, Ulf Hansson, linux-mmc
On 2017/7/19 23:25, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a9dfb26972f21..7c1e2dbc76776 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2950,7 +2950,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
> return ERR_PTR(-ENOMEM);
>
> /* find reset controller when exist */
> - pdata->rstc = devm_reset_control_get_optional(dev, "reset");
> + pdata->rstc = devm_reset_control_get_optional_exclusive(dev, "reset");
> if (IS_ERR(pdata->rstc)) {
> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> return ERR_PTR(-EPROBE_DEFER);
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-20 20:46 ` Dmitry Torokhov
(?)
(?)
@ 2017-07-23 18:41 ` Linus Walleij
-1 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-07-23 18:41 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Philipp Zabel, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
USB list, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
Linux I2C, LINUXWATCHDOG, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter,
open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, Linux PCI, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Liam Girdwood,
Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, dmaengine,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
Rongrong Zou, linux-fpga, David Woodhouse, Lucas Stach
On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>>> What about reset_control_get(struct device *, const char *, int flags)
>>> to replace all those variants ?
>>
>> While I like how this looks, unfortunately (devm_)reset_control_get
>> already exists without the flags, so we can't change to that with a
>> gentle transition.
>
> This was done for gpiod_get() and its flags argument with horrifying
> #define-ry, which thankfully was completely hidden from users.
For your reference:
commit bae48da237fcedd7ad09569025483b988635efb7
"gpiolib: add gpiod_get() and gpiod_put() functions"
commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
"gpio: add flags argument to gpiod_get*() functions"
commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
"gpio: move varargs hack outside #ifdef GPIOLIB"
commit b17d1bf16cc72a374a48d748940f700009d40ff4
"gpio: make flags mandatory for gpiod_get functions"
Retrospectively ... was that really a good idea... it was a LOT
of trouble to add a flag, maybe it had been better to try and
just slam all users in a single go.
But it worked.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-23 18:41 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-07-23 18:41 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Philipp Zabel, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck
On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>>> What about reset_control_get(struct device *, const char *, int flags)
>>> to replace all those variants ?
>>
>> While I like how this looks, unfortunately (devm_)reset_control_get
>> already exists without the flags, so we can't change to that with a
>> gentle transition.
>
> This was done for gpiod_get() and its flags argument with horrifying
> #define-ry, which thankfully was completely hidden from users.
For your reference:
commit bae48da237fcedd7ad09569025483b988635efb7
"gpiolib: add gpiod_get() and gpiod_put() functions"
commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
"gpio: add flags argument to gpiod_get*() functions"
commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
"gpio: move varargs hack outside #ifdef GPIOLIB"
commit b17d1bf16cc72a374a48d748940f700009d40ff4
"gpio: make flags mandatory for gpiod_get functions"
Retrospectively ... was that really a good idea... it was a LOT
of trouble to add a flag, maybe it had been better to try and
just slam all users in a single go.
But it worked.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-23 18:41 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-07-23 18:41 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Philipp Zabel, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck
On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>>> What about reset_control_get(struct device *, const char *, int flags)
>>> to replace all those variants ?
>>
>> While I like how this looks, unfortunately (devm_)reset_control_get
>> already exists without the flags, so we can't change to that with a
>> gentle transition.
>
> This was done for gpiod_get() and its flags argument with horrifying
> #define-ry, which thankfully was completely hidden from users.
For your reference:
commit bae48da237fcedd7ad09569025483b988635efb7
"gpiolib: add gpiod_get() and gpiod_put() functions"
commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
"gpio: add flags argument to gpiod_get*() functions"
commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
"gpio: move varargs hack outside #ifdef GPIOLIB"
commit b17d1bf16cc72a374a48d748940f700009d40ff4
"gpio: make flags mandatory for gpiod_get functions"
Retrospectively ... was that really a good idea... it was a LOT
of trouble to add a flag, maybe it had been better to try and
just slam all users in a single go.
But it worked.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-23 18:41 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-07-23 18:41 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Shawn Lin, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
USB list, linux-wireless, lkml, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, Linux I2C, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
LINUXWATCHDOG, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Thomas Petazzoni, Patrice Chotard,
Stanimir Varbanov, Kyungmin Park, Maxime Coquelin,
Hartmut Knaack, Jonathan Cameron, Ulf Hansson, linux-iio,
Linux PCI, Michael Turquette, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Kalle Valo, Thierry Reding,
Cyrille Pitchen, Srinivas Kandagatla, Maxime Ripard,
Brian Norris, David S. Miller, Liam Girdwood, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, Rongrong Zou,
moderated list:ARM/Mediatek SoC support, linux-tegra, Mark Yao,
Moritz Fischer, Vivien Didelot, netdev, Peter De Schrijver,
Stephen Boyd, Adrian Hunter, Vinod Koul, Philipp Zabel,
dmaengine, linux-fpga, David Woodhouse, Lucas Stach
On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>>> What about reset_control_get(struct device *, const char *, int flags)
>>> to replace all those variants ?
>>
>> While I like how this looks, unfortunately (devm_)reset_control_get
>> already exists without the flags, so we can't change to that with a
>> gentle transition.
>
> This was done for gpiod_get() and its flags argument with horrifying
> #define-ry, which thankfully was completely hidden from users.
For your reference:
commit bae48da237fcedd7ad09569025483b988635efb7
"gpiolib: add gpiod_get() and gpiod_put() functions"
commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
"gpio: add flags argument to gpiod_get*() functions"
commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
"gpio: move varargs hack outside #ifdef GPIOLIB"
commit b17d1bf16cc72a374a48d748940f700009d40ff4
"gpio: make flags mandatory for gpiod_get functions"
Retrospectively ... was that really a good idea... it was a LOT
of trouble to add a flag, maybe it had been better to try and
just slam all users in a single go.
But it worked.
Yours,
Linus Walleij
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-07-23 18:41 ` Linus Walleij
(?)
(?)
@ 2017-07-24 8:33 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-24 8:33 UTC (permalink / raw)
To: Linus Walleij
Cc: Dmitry Torokhov, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
USB list, linux-wireless, Ralf Baechle, linux-spi, linux-crypto,
Tejun Heo, alsa-devel, linux-doc, David Airlie, nouveau,
Philippe Cornu, Kalle Valo, Laxman Dewangan, Corentin Labbe,
Linux I2C, LINUXWATCHDOG, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter,
open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, Linux PCI, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Liam Girdwood,
Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, dmaengine,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
Rongrong Zou, linux-fpga, David Woodhouse, Lucas Stach
On Sun, 2017-07-23 at 20:41 +0200, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> >>> What about reset_control_get(struct device *, const char *, int flags)
> >>> to replace all those variants ?
> >>
> >> While I like how this looks, unfortunately (devm_)reset_control_get
> >> already exists without the flags, so we can't change to that with a
> >> gentle transition.
> >
> > This was done for gpiod_get() and its flags argument with horrifying
> > #define-ry, which thankfully was completely hidden from users.
>
> For your reference:
>
> commit bae48da237fcedd7ad09569025483b988635efb7
> "gpiolib: add gpiod_get() and gpiod_put() functions"
>
> commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
> "gpio: add flags argument to gpiod_get*() functions"
>
> commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
> "gpio: move varargs hack outside #ifdef GPIOLIB"
>
> commit b17d1bf16cc72a374a48d748940f700009d40ff4
> "gpio: make flags mandatory for gpiod_get functions"
>
> Retrospectively ... was that really a good idea... it was a LOT
> of trouble to add a flag, maybe it had been better to try and
> just slam all users in a single go.
>
> But it worked.
Thanks for the hint and the references. It seems this turned out okay,
but I wouldn't dare to introduce such macro horror^Wmagic.
I'd rather have all users converted to the _exclusive/_shared function
calls and maybe then replace the internal __reset_control_get with
Thomas' suggestion.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-24 8:33 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-24 8:33 UTC (permalink / raw)
To: Linus Walleij
Cc: Dmitry Torokhov, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck
On Sun, 2017-07-23 at 20:41 +0200, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> >>> What about reset_control_get(struct device *, const char *, int flags)
> >>> to replace all those variants ?
> >>
> >> While I like how this looks, unfortunately (devm_)reset_control_get
> >> already exists without the flags, so we can't change to that with a
> >> gentle transition.
> >
> > This was done for gpiod_get() and its flags argument with horrifying
> > #define-ry, which thankfully was completely hidden from users.
>
> For your reference:
>
> commit bae48da237fcedd7ad09569025483b988635efb7
> "gpiolib: add gpiod_get() and gpiod_put() functions"
>
> commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
> "gpio: add flags argument to gpiod_get*() functions"
>
> commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
> "gpio: move varargs hack outside #ifdef GPIOLIB"
>
> commit b17d1bf16cc72a374a48d748940f700009d40ff4
> "gpio: make flags mandatory for gpiod_get functions"
>
> Retrospectively ... was that really a good idea... it was a LOT
> of trouble to add a flag, maybe it had been better to try and
> just slam all users in a single go.
>
> But it worked.
Thanks for the hint and the references. It seems this turned out okay,
but I wouldn't dare to introduce such macro horror^Wmagic.
I'd rather have all users converted to the _exclusive/_shared function
calls and maybe then replace the internal __reset_control_get with
Thomas' suggestion.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-24 8:33 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-24 8:33 UTC (permalink / raw)
To: Linus Walleij
Cc: Dmitry Torokhov, Thomas Petazzoni, lkml, Andrew Lunn,
Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI, Marc Dietrich,
Rakesh Iyer, Peter Meerwald-Stadler, linux-clk, Wim Van Sebroeck,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette
On Sun, 2017-07-23 at 20:41 +0200, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> >>> What about reset_control_get(struct device *, const char *, int flags)
> >>> to replace all those variants ?
> >>
> >> While I like how this looks, unfortunately (devm_)reset_control_get
> >> already exists without the flags, so we can't change to that with a
> >> gentle transition.
> >
> > This was done for gpiod_get() and its flags argument with horrifying
> > #define-ry, which thankfully was completely hidden from users.
>
> For your reference:
>
> commit bae48da237fcedd7ad09569025483b988635efb7
> "gpiolib: add gpiod_get() and gpiod_put() functions"
>
> commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
> "gpio: add flags argument to gpiod_get*() functions"
>
> commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
> "gpio: move varargs hack outside #ifdef GPIOLIB"
>
> commit b17d1bf16cc72a374a48d748940f700009d40ff4
> "gpio: make flags mandatory for gpiod_get functions"
>
> Retrospectively ... was that really a good idea... it was a LOT
> of trouble to add a flag, maybe it had been better to try and
> just slam all users in a single go.
>
> But it worked.
Thanks for the hint and the references. It seems this turned out okay,
but I wouldn't dare to introduce such macro horror^Wmagic.
I'd rather have all users converted to the _exclusive/_shared function
calls and maybe then replace the internal __reset_control_get with
Thomas' suggestion.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-24 8:33 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-24 8:33 UTC (permalink / raw)
To: Linus Walleij
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wolfram Sang, Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Shawn Lin, Guenter Roeck, Ohad Ben-Cohen, linux-pm,
Thomas Gleixner, Vincent Abriou, Bin Liu, Greg Kroah-Hartman,
USB list, linux-wireless, lkml, Ralf Baechle, linux-spi,
linux-crypto, Tejun Heo, alsa-devel, linux-doc, David Airlie,
nouveau, Philippe Cornu, Wim Van Sebroeck, Laxman Dewangan,
Corentin Labbe, Linux I2C, Alexandre Torgue, Boris Brezillon,
Lars-Peter Clausen, Emilio López, Daniel Lezcano,
Jon Hunter, open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
LINUXWATCHDOG, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Thomas Petazzoni, Patrice Chotard,
Stanimir Varbanov, Kyungmin Park, Maxime Coquelin,
Hartmut Knaack, Jonathan Cameron, Ulf Hansson, linux-iio,
Linux PCI, Michael Turquette, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Chen-Yu Tsai, ath10k, Kishon Vijay Abraham I, Xinwei Kong,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou,
moderated list:ARM/Mediatek SoC support, linux-tegra, Mark Yao,
Moritz Fischer, Vivien Didelot, netdev, Peter De Schrijver,
Stephen Boyd, Adrian Hunter, Vinod Koul, dmaengine, linux-fpga,
David Woodhouse, Lucas Stach
On Sun, 2017-07-23 at 20:41 +0200, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 10:46 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Thu, Jul 20, 2017 at 5:55 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> >>> What about reset_control_get(struct device *, const char *, int flags)
> >>> to replace all those variants ?
> >>
> >> While I like how this looks, unfortunately (devm_)reset_control_get
> >> already exists without the flags, so we can't change to that with a
> >> gentle transition.
> >
> > This was done for gpiod_get() and its flags argument with horrifying
> > #define-ry, which thankfully was completely hidden from users.
>
> For your reference:
>
> commit bae48da237fcedd7ad09569025483b988635efb7
> "gpiolib: add gpiod_get() and gpiod_put() functions"
>
> commit 39b2bbe3d715cf5013b5c48695ccdd25bd3bf120
> "gpio: add flags argument to gpiod_get*() functions"
>
> commit 0dbc8b7afef6e4fddcfebcbacbeb269a0a3b06d5
> "gpio: move varargs hack outside #ifdef GPIOLIB"
>
> commit b17d1bf16cc72a374a48d748940f700009d40ff4
> "gpio: make flags mandatory for gpiod_get functions"
>
> Retrospectively ... was that really a good idea... it was a LOT
> of trouble to add a flag, maybe it had been better to try and
> just slam all users in a single go.
>
> But it worked.
Thanks for the hint and the references. It seems this turned out okay,
but I wouldn't dare to introduce such macro horror^Wmagic.
I'd rather have all users converted to the _exclusive/_shared function
calls and maybe then replace the internal __reset_control_get with
Thomas' suggestion.
regards
Philipp
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
2017-07-22 13:12 ` Shawn Lin
@ 2017-07-24 8:35 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-24 8:35 UTC (permalink / raw)
To: Shawn Lin
Cc: linux-kernel, Bjorn Helgaas, Heiko Stuebner, linux-pci, linux-rockchip
Hi Shawn,
On Sat, 2017-07-22 at 21:12 +0800, Shawn Lin wrote:
> Hi Philipp,
>
> On 2017/7/19 23:25, Philipp Zabel wrote:
> > Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> > reset lines") started to transition the reset control request API calls
> > to explicitly state whether the driver needs exclusive or shared reset
> > control behavior. Convert all drivers requesting exclusive resets to the
> > explicit API call so the temporary transition helpers can be removed.
> >
> > No functional changes.
> >
> > Cc: Shawn Lin <shawn.lin@rock-chips.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-rockchip@lists.infradead.org
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
>
> As mentioned in the thread of conversion for phy-rockchip-pcie,
> I would prefer add your patches after the reconstruction work got
> merged.
Feel free to add them when and where it is most convenient for you.
Please let me know if you want me to rebase them somewhere.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 038/102] mmc: dw_mmc: " Philipp Zabel
2017-07-22 13:13 ` Shawn Lin
@ 2017-07-27 14:48 ` Ulf Hansson
1 sibling, 0 replies; 260+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:48 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Jaehoon Chung, linux-mmc
On 19 July 2017 at 17:25, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a9dfb26972f21..7c1e2dbc76776 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2950,7 +2950,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
> return ERR_PTR(-ENOMEM);
>
> /* find reset controller when exist */
> - pdata->rstc = devm_reset_control_get_optional(dev, "reset");
> + pdata->rstc = devm_reset_control_get_optional_exclusive(dev, "reset");
> if (IS_ERR(pdata->rstc)) {
> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> return ERR_PTR(-EPROBE_DEFER);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 040/102] mmc: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 040/102] mmc: sunxi: " Philipp Zabel
@ 2017-07-27 14:48 ` Ulf Hansson
0 siblings, 0 replies; 260+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:48 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Maxime Ripard, Chen-Yu Tsai, linux-mmc
On 19 July 2017 at 17:25, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sunxi-mmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index d6fa2214aaae8..522b09d446494 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1168,7 +1168,8 @@ static int sunxi_mmc_resource_request(struct sunxi_mmc_host *host,
> }
> }
>
> - host->reset = devm_reset_control_get_optional(&pdev->dev, "ahb");
> + host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
> + "ahb");
> if (PTR_ERR(host->reset) == -EPROBE_DEFER)
> return PTR_ERR(host->reset);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 039/102] mmc: sdhci-st: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 039/102] mmc: sdhci-st: " Philipp Zabel
@ 2017-07-27 14:49 ` Ulf Hansson
0 siblings, 0 replies; 260+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:49 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Patrice Chotard, Adrian Hunter, linux-mmc
On 19 July 2017 at 17:25, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 68c36c9fa2318..ad1ab0777d5f6 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -371,7 +371,7 @@ static int sdhci_st_probe(struct platform_device *pdev)
> if (IS_ERR(icnclk))
> icnclk = NULL;
>
> - rstc = devm_reset_control_get(&pdev->dev, NULL);
> + rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> if (IS_ERR(rstc))
> rstc = NULL;
> else
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 041/102] mmc: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 041/102] mmc: tegra: " Philipp Zabel
@ 2017-07-27 14:49 ` Ulf Hansson
0 siblings, 0 replies; 260+ messages in thread
From: Ulf Hansson @ 2017-07-27 14:49 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Adrian Hunter, Thierry Reding, Jonathan Hunter,
linux-mmc, linux-tegra
On 19 July 2017 at 17:25, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7f93079c7a3ad..f668a6fa17654 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -508,7 +508,8 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
> clk_prepare_enable(clk);
> pltfm_host->clk = clk;
>
> - tegra_host->rst = devm_reset_control_get(&pdev->dev, "sdhci");
> + tegra_host->rst = devm_reset_control_get_exclusive(&pdev->dev,
> + "sdhci");
> if (IS_ERR(tegra_host->rst)) {
> rc = PTR_ERR(tegra_host->rst);
> dev_err(&pdev->dev, "failed to get reset control: %d\n", rc);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control
2017-07-19 16:12 ` Moritz Fischer
@ 2017-07-27 18:49 ` Alan Tull
0 siblings, 0 replies; 260+ messages in thread
From: Alan Tull @ 2017-07-27 18:49 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Philipp Zabel, linux-kernel, Moritz Fischer, linux-fpga
On Wed, Jul 19, 2017 at 11:12 AM, Moritz Fischer <mdf@kernel.org> wrote:
> On Wed, Jul 19, 2017 at 05:25:06PM +0200, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Alan Tull <atull@kernel.org>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: linux-fpga@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Acked-By: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 005/102] ata: sata_gemini: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 005/102] ata: sata_gemini: " Philipp Zabel
@ 2017-08-02 9:39 ` Linus Walleij
2017-08-02 15:15 ` Tejun Heo
1 sibling, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-08-02 9:39 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Tejun Heo, linux-ide
On Wed, Jul 19, 2017 at 5:25 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: linux-ide@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 066/102] pinctrl: stm32: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 066/102] pinctrl: stm32: " Philipp Zabel
@ 2017-08-02 11:43 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-08-02 11:43 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Maxime Coquelin, Alexandre Torgue, linux-gpio
On Wed, Jul 19, 2017 at 5:26 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 067/102] pinctrl: sunxi: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 067/102] pinctrl: sunxi: " Philipp Zabel
@ 2017-08-02 11:44 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-08-02 11:44 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Maxime Ripard, Chen-Yu Tsai, linux-gpio
On Wed, Jul 19, 2017 at 5:26 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 068/102] pinctrl: tegra: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 068/102] pinctrl: tegra: " Philipp Zabel
@ 2017-08-02 11:45 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-08-02 11:45 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Jonathan Hunter, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On Wed, Jul 19, 2017 at 5:26 PM, Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 068/102] pinctrl: tegra: explicitly request exclusive reset control
@ 2017-08-02 11:45 ` Linus Walleij
0 siblings, 0 replies; 260+ messages in thread
From: Linus Walleij @ 2017-08-02 11:45 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Thierry Reding, Jonathan Hunter, linux-gpio, linux-tegra
On Wed, Jul 19, 2017 at 5:26 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 005/102] ata: sata_gemini: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 005/102] ata: sata_gemini: " Philipp Zabel
2017-08-02 9:39 ` Linus Walleij
@ 2017-08-02 15:15 ` Tejun Heo
1 sibling, 0 replies; 260+ messages in thread
From: Tejun Heo @ 2017-08-02 15:15 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Linus Walleij, linux-ide
On Wed, Jul 19, 2017 at 05:25:09PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: linux-ide@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to libata/for-4.14.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
(?)
(?)
@ 2017-08-03 0:31 ` Shawn Lin
-1 siblings, 0 replies; 260+ messages in thread
From: Shawn Lin @ 2017-08-03 0:31 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, shawn.lin, Bjorn Helgaas, Heiko Stuebner,
linux-pci, linux-rockchip
Hi,
On 2017/7/19 23:25, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Shawn Lin <shawn.lin@rock-chips.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index 7bb9870f6d8ce..e50d6f5a81f4b 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -903,49 +903,50 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
> if (rockchip->link_gen < 0 || rockchip->link_gen > 2)
> rockchip->link_gen = 2;
>
> - rockchip->core_rst = devm_reset_control_get(dev, "core");
> + rockchip->core_rst = devm_reset_control_get_exclusive(dev, "core");
> if (IS_ERR(rockchip->core_rst)) {
> if (PTR_ERR(rockchip->core_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing core reset property in node\n");
> return PTR_ERR(rockchip->core_rst);
> }
>
> - rockchip->mgmt_rst = devm_reset_control_get(dev, "mgmt");
> + rockchip->mgmt_rst = devm_reset_control_get_exclusive(dev, "mgmt");
> if (IS_ERR(rockchip->mgmt_rst)) {
> if (PTR_ERR(rockchip->mgmt_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt reset property in node\n");
> return PTR_ERR(rockchip->mgmt_rst);
> }
>
> - rockchip->mgmt_sticky_rst = devm_reset_control_get(dev, "mgmt-sticky");
> + rockchip->mgmt_sticky_rst = devm_reset_control_get_exclusive(dev,
> + "mgmt-sticky");
> if (IS_ERR(rockchip->mgmt_sticky_rst)) {
> if (PTR_ERR(rockchip->mgmt_sticky_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt-sticky reset property in node\n");
> return PTR_ERR(rockchip->mgmt_sticky_rst);
> }
>
> - rockchip->pipe_rst = devm_reset_control_get(dev, "pipe");
> + rockchip->pipe_rst = devm_reset_control_get_exclusive(dev, "pipe");
> if (IS_ERR(rockchip->pipe_rst)) {
> if (PTR_ERR(rockchip->pipe_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pipe reset property in node\n");
> return PTR_ERR(rockchip->pipe_rst);
> }
>
> - rockchip->pm_rst = devm_reset_control_get(dev, "pm");
> + rockchip->pm_rst = devm_reset_control_get_exclusive(dev, "pm");
> if (IS_ERR(rockchip->pm_rst)) {
> if (PTR_ERR(rockchip->pm_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pm reset property in node\n");
> return PTR_ERR(rockchip->pm_rst);
> }
>
> - rockchip->pclk_rst = devm_reset_control_get(dev, "pclk");
> + rockchip->pclk_rst = devm_reset_control_get_exclusive(dev, "pclk");
> if (IS_ERR(rockchip->pclk_rst)) {
> if (PTR_ERR(rockchip->pclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pclk reset property in node\n");
> return PTR_ERR(rockchip->pclk_rst);
> }
>
> - rockchip->aclk_rst = devm_reset_control_get(dev, "aclk");
> + rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
> if (IS_ERR(rockchip->aclk_rst)) {
> if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing aclk reset property in node\n");
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control
2017-07-19 15:26 ` Philipp Zabel
(?)
(?)
@ 2017-08-03 0:37 ` Shawn Lin
-1 siblings, 0 replies; 260+ messages in thread
From: Shawn Lin @ 2017-08-03 0:37 UTC (permalink / raw)
To: Philipp Zabel, Bjorn Helgaas
Cc: linux-kernel, shawn.lin, linux-rockchip, Heiko Stuebner,
Kishon Vijay Abraham I
[+ Bjorn]
On 2017/7/19 23:26, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
some changes for phy-rockchip-pcie.c would go via pci tree
for 4.14, so is it ok for Bjorn to pick this up if no objection
from Kishon, in case of merge conflict?
Anyway,
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c
> index 6904633cad687..258220b7f481c 100644
> --- a/drivers/phy/rockchip/phy-rockchip-pcie.c
> +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c
> @@ -305,7 +305,7 @@ static int rockchip_pcie_phy_probe(struct platform_device *pdev)
> rk_phy->phy_data = (struct rockchip_pcie_data *)of_id->data;
> rk_phy->reg_base = grf;
>
> - rk_phy->phy_rst = devm_reset_control_get(dev, "phy");
> + rk_phy->phy_rst = devm_reset_control_get_exclusive(dev, "phy");
> if (IS_ERR(rk_phy->phy_rst)) {
> if (PTR_ERR(rk_phy->phy_rst) != -EPROBE_DEFER)
> dev_err(dev,
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [049/102] ath10k: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
@ 2017-08-03 11:38 ` Kalle Valo
-1 siblings, 0 replies; 260+ messages in thread
From: Kalle Valo @ 2017-08-03 11:38 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Philipp Zabel, ath10k, linux-wireless, netdev
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
a764284f34f9 ath10k: explicitly request exclusive reset control
--
https://patchwork.kernel.org/patch/9852575/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [049/102] ath10k: explicitly request exclusive reset control
@ 2017-08-03 11:38 ` Kalle Valo
0 siblings, 0 replies; 260+ messages in thread
From: Kalle Valo @ 2017-08-03 11:38 UTC (permalink / raw)
To: Philipp Zabel; +Cc: netdev, ath10k, linux-wireless, linux-kernel
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
a764284f34f9 ath10k: explicitly request exclusive reset control
--
https://patchwork.kernel.org/patch/9852575/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 051/102] PCI: dwc: pcie-qcom: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 051/102] PCI: dwc: pcie-qcom: " Philipp Zabel
@ 2017-08-03 21:40 ` Bjorn Helgaas
0 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:40 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Stanimir Varbanov, Bjorn Helgaas, linux-pci, linux-arm-msm
On Wed, Jul 19, 2017 at 05:25:55PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to pci/host-qcom for v4.14, thanks!
Stanimir, holler if you see any issues.
> ---
> drivers/pci/dwc/pcie-qcom.c | 40 ++++++++++++++++++++++------------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 68c5f2ab5bc8f..90f7796a7cffe 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -212,23 +212,23 @@ static int qcom_pcie_get_resources_v0(struct qcom_pcie *pcie)
> if (IS_ERR(res->phy_clk))
> return PTR_ERR(res->phy_clk);
>
> - res->pci_reset = devm_reset_control_get(dev, "pci");
> + res->pci_reset = devm_reset_control_get_exclusive(dev, "pci");
> if (IS_ERR(res->pci_reset))
> return PTR_ERR(res->pci_reset);
>
> - res->axi_reset = devm_reset_control_get(dev, "axi");
> + res->axi_reset = devm_reset_control_get_exclusive(dev, "axi");
> if (IS_ERR(res->axi_reset))
> return PTR_ERR(res->axi_reset);
>
> - res->ahb_reset = devm_reset_control_get(dev, "ahb");
> + res->ahb_reset = devm_reset_control_get_exclusive(dev, "ahb");
> if (IS_ERR(res->ahb_reset))
> return PTR_ERR(res->ahb_reset);
>
> - res->por_reset = devm_reset_control_get(dev, "por");
> + res->por_reset = devm_reset_control_get_exclusive(dev, "por");
> if (IS_ERR(res->por_reset))
> return PTR_ERR(res->por_reset);
>
> - res->phy_reset = devm_reset_control_get(dev, "phy");
> + res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
> return PTR_ERR_OR_ZERO(res->phy_reset);
> }
>
> @@ -393,7 +393,7 @@ static int qcom_pcie_get_resources_v1(struct qcom_pcie *pcie)
> if (IS_ERR(res->slave_bus))
> return PTR_ERR(res->slave_bus);
>
> - res->core = devm_reset_control_get(dev, "core");
> + res->core = devm_reset_control_get_exclusive(dev, "core");
> return PTR_ERR_OR_ZERO(res->core);
> }
>
> @@ -623,51 +623,55 @@ static int qcom_pcie_get_resources_v3(struct qcom_pcie *pcie)
> if (IS_ERR(res->slave_clk))
> return PTR_ERR(res->slave_clk);
>
> - res->axi_m_reset = devm_reset_control_get(dev, "axi_m");
> + res->axi_m_reset = devm_reset_control_get_exclusive(dev, "axi_m");
> if (IS_ERR(res->axi_m_reset))
> return PTR_ERR(res->axi_m_reset);
>
> - res->axi_s_reset = devm_reset_control_get(dev, "axi_s");
> + res->axi_s_reset = devm_reset_control_get_exclusive(dev, "axi_s");
> if (IS_ERR(res->axi_s_reset))
> return PTR_ERR(res->axi_s_reset);
>
> - res->pipe_reset = devm_reset_control_get(dev, "pipe");
> + res->pipe_reset = devm_reset_control_get_exclusive(dev, "pipe");
> if (IS_ERR(res->pipe_reset))
> return PTR_ERR(res->pipe_reset);
>
> - res->axi_m_vmid_reset = devm_reset_control_get(dev, "axi_m_vmid");
> + res->axi_m_vmid_reset = devm_reset_control_get_exclusive(dev,
> + "axi_m_vmid");
> if (IS_ERR(res->axi_m_vmid_reset))
> return PTR_ERR(res->axi_m_vmid_reset);
>
> - res->axi_s_xpu_reset = devm_reset_control_get(dev, "axi_s_xpu");
> + res->axi_s_xpu_reset = devm_reset_control_get_exclusive(dev,
> + "axi_s_xpu");
> if (IS_ERR(res->axi_s_xpu_reset))
> return PTR_ERR(res->axi_s_xpu_reset);
>
> - res->parf_reset = devm_reset_control_get(dev, "parf");
> + res->parf_reset = devm_reset_control_get_exclusive(dev, "parf");
> if (IS_ERR(res->parf_reset))
> return PTR_ERR(res->parf_reset);
>
> - res->phy_reset = devm_reset_control_get(dev, "phy");
> + res->phy_reset = devm_reset_control_get_exclusive(dev, "phy");
> if (IS_ERR(res->phy_reset))
> return PTR_ERR(res->phy_reset);
>
> - res->axi_m_sticky_reset = devm_reset_control_get(dev, "axi_m_sticky");
> + res->axi_m_sticky_reset = devm_reset_control_get_exclusive(dev,
> + "axi_m_sticky");
> if (IS_ERR(res->axi_m_sticky_reset))
> return PTR_ERR(res->axi_m_sticky_reset);
>
> - res->pipe_sticky_reset = devm_reset_control_get(dev, "pipe_sticky");
> + res->pipe_sticky_reset = devm_reset_control_get_exclusive(dev,
> + "pipe_sticky");
> if (IS_ERR(res->pipe_sticky_reset))
> return PTR_ERR(res->pipe_sticky_reset);
>
> - res->pwr_reset = devm_reset_control_get(dev, "pwr");
> + res->pwr_reset = devm_reset_control_get_exclusive(dev, "pwr");
> if (IS_ERR(res->pwr_reset))
> return PTR_ERR(res->pwr_reset);
>
> - res->ahb_reset = devm_reset_control_get(dev, "ahb");
> + res->ahb_reset = devm_reset_control_get_exclusive(dev, "ahb");
> if (IS_ERR(res->ahb_reset))
> return PTR_ERR(res->ahb_reset);
>
> - res->phy_ahb_reset = devm_reset_control_get(dev, "phy_ahb");
> + res->phy_ahb_reset = devm_reset_control_get_exclusive(dev, "phy_ahb");
> if (IS_ERR(res->phy_ahb_reset))
> return PTR_ERR(res->phy_ahb_reset);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 052/102] PCI: imx6: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 052/102] PCI: imx6: " Philipp Zabel
@ 2017-08-03 21:41 ` Bjorn Helgaas
0 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:41 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Richard Zhu, Lucas Stach, Bjorn Helgaas, linux-pci
On Wed, Jul 19, 2017 at 05:25:56PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to pci/host-imx6 for v4.14, thanks!
Richard, Lucas, holler if you see any issues.
> ---
> drivers/pci/dwc/pci-imx6.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
> index bf5c3616e3448..5a2ece394ad39 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -778,14 +778,15 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> }
> break;
> case IMX7D:
> - imx6_pcie->pciephy_reset = devm_reset_control_get(dev,
> - "pciephy");
> + imx6_pcie->pciephy_reset = devm_reset_control_get_exclusive(dev,
> + "pciephy");
> if (IS_ERR(imx6_pcie->pciephy_reset)) {
> dev_err(dev, "Failed to get PCIEPHY reset control\n");
> return PTR_ERR(imx6_pcie->pciephy_reset);
> }
>
> - imx6_pcie->apps_reset = devm_reset_control_get(dev, "apps");
> + imx6_pcie->apps_reset = devm_reset_control_get_exclusive(dev,
> + "apps");
> if (IS_ERR(imx6_pcie->apps_reset)) {
> dev_err(dev, "Failed to get PCIE APPS reset control\n");
> return PTR_ERR(imx6_pcie->apps_reset);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 053/102] PCI: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 053/102] PCI: tegra: " Philipp Zabel
@ 2017-08-03 21:42 ` Bjorn Helgaas
0 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:42 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Bjorn Helgaas, Jonathan Hunter,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-pci-u79uwXL29TY76Z2rM5mHXA
On Wed, Jul 19, 2017 at 05:25:57PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Cc: Jonathan Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied to pci/host-tegra for v4.14, thanks!
Tegra folks, holler if you see any issues.
> ---
> drivers/pci/host/pci-tegra.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index b3722b7709df8..a64bd0a191767 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1147,15 +1147,15 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)
> {
> struct device *dev = pcie->dev;
>
> - pcie->pex_rst = devm_reset_control_get(dev, "pex");
> + pcie->pex_rst = devm_reset_control_get_exclusive(dev, "pex");
> if (IS_ERR(pcie->pex_rst))
> return PTR_ERR(pcie->pex_rst);
>
> - pcie->afi_rst = devm_reset_control_get(dev, "afi");
> + pcie->afi_rst = devm_reset_control_get_exclusive(dev, "afi");
> if (IS_ERR(pcie->afi_rst))
> return PTR_ERR(pcie->afi_rst);
>
> - pcie->pcie_xrst = devm_reset_control_get(dev, "pcie_x");
> + pcie->pcie_xrst = devm_reset_control_get_exclusive(dev, "pcie_x");
> if (IS_ERR(pcie->pcie_xrst))
> return PTR_ERR(pcie->pcie_xrst);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 053/102] PCI: tegra: explicitly request exclusive reset control
@ 2017-08-03 21:42 ` Bjorn Helgaas
0 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:42 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Thierry Reding, Bjorn Helgaas, Jonathan Hunter,
linux-tegra, linux-pci
On Wed, Jul 19, 2017 at 05:25:57PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-tegra@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to pci/host-tegra for v4.14, thanks!
Tegra folks, holler if you see any issues.
> ---
> drivers/pci/host/pci-tegra.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index b3722b7709df8..a64bd0a191767 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1147,15 +1147,15 @@ static int tegra_pcie_resets_get(struct tegra_pcie *pcie)
> {
> struct device *dev = pcie->dev;
>
> - pcie->pex_rst = devm_reset_control_get(dev, "pex");
> + pcie->pex_rst = devm_reset_control_get_exclusive(dev, "pex");
> if (IS_ERR(pcie->pex_rst))
> return PTR_ERR(pcie->pex_rst);
>
> - pcie->afi_rst = devm_reset_control_get(dev, "afi");
> + pcie->afi_rst = devm_reset_control_get_exclusive(dev, "afi");
> if (IS_ERR(pcie->afi_rst))
> return PTR_ERR(pcie->afi_rst);
>
> - pcie->pcie_xrst = devm_reset_control_get(dev, "pcie_x");
> + pcie->pcie_xrst = devm_reset_control_get_exclusive(dev, "pcie_x");
> if (IS_ERR(pcie->pcie_xrst))
> return PTR_ERR(pcie->pcie_xrst);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control
2017-07-19 15:25 ` Philipp Zabel
` (2 preceding siblings ...)
(?)
@ 2017-08-03 21:43 ` Bjorn Helgaas
-1 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Shawn Lin, Bjorn Helgaas, Heiko Stuebner,
linux-pci, linux-rockchip
On Wed, Jul 19, 2017 at 05:25:58PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Shawn Lin <shawn.lin@rock-chips.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied with Shawn's ack to pci/host-rockchip for v4.14, thanks!
> ---
> drivers/pci/host/pcie-rockchip.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index 7bb9870f6d8ce..e50d6f5a81f4b 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -903,49 +903,50 @@ static int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip)
> if (rockchip->link_gen < 0 || rockchip->link_gen > 2)
> rockchip->link_gen = 2;
>
> - rockchip->core_rst = devm_reset_control_get(dev, "core");
> + rockchip->core_rst = devm_reset_control_get_exclusive(dev, "core");
> if (IS_ERR(rockchip->core_rst)) {
> if (PTR_ERR(rockchip->core_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing core reset property in node\n");
> return PTR_ERR(rockchip->core_rst);
> }
>
> - rockchip->mgmt_rst = devm_reset_control_get(dev, "mgmt");
> + rockchip->mgmt_rst = devm_reset_control_get_exclusive(dev, "mgmt");
> if (IS_ERR(rockchip->mgmt_rst)) {
> if (PTR_ERR(rockchip->mgmt_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt reset property in node\n");
> return PTR_ERR(rockchip->mgmt_rst);
> }
>
> - rockchip->mgmt_sticky_rst = devm_reset_control_get(dev, "mgmt-sticky");
> + rockchip->mgmt_sticky_rst = devm_reset_control_get_exclusive(dev,
> + "mgmt-sticky");
> if (IS_ERR(rockchip->mgmt_sticky_rst)) {
> if (PTR_ERR(rockchip->mgmt_sticky_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing mgmt-sticky reset property in node\n");
> return PTR_ERR(rockchip->mgmt_sticky_rst);
> }
>
> - rockchip->pipe_rst = devm_reset_control_get(dev, "pipe");
> + rockchip->pipe_rst = devm_reset_control_get_exclusive(dev, "pipe");
> if (IS_ERR(rockchip->pipe_rst)) {
> if (PTR_ERR(rockchip->pipe_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pipe reset property in node\n");
> return PTR_ERR(rockchip->pipe_rst);
> }
>
> - rockchip->pm_rst = devm_reset_control_get(dev, "pm");
> + rockchip->pm_rst = devm_reset_control_get_exclusive(dev, "pm");
> if (IS_ERR(rockchip->pm_rst)) {
> if (PTR_ERR(rockchip->pm_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pm reset property in node\n");
> return PTR_ERR(rockchip->pm_rst);
> }
>
> - rockchip->pclk_rst = devm_reset_control_get(dev, "pclk");
> + rockchip->pclk_rst = devm_reset_control_get_exclusive(dev, "pclk");
> if (IS_ERR(rockchip->pclk_rst)) {
> if (PTR_ERR(rockchip->pclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing pclk reset property in node\n");
> return PTR_ERR(rockchip->pclk_rst);
> }
>
> - rockchip->aclk_rst = devm_reset_control_get(dev, "aclk");
> + rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
> if (IS_ERR(rockchip->aclk_rst)) {
> if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
> dev_err(dev, "missing aclk reset property in node\n");
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 056/102] PCI: mediatek: explicitly request exclusive reset control
2017-07-19 15:26 ` Philipp Zabel
(?)
@ 2017-08-03 21:45 ` Bjorn Helgaas
-1 siblings, 0 replies; 260+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 21:45 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Ryder Lee, Bjorn Helgaas, Matthias Brugger,
linux-pci, linux-mediatek
On Wed, Jul 19, 2017 at 05:26:00PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ryder Lee <ryder.lee@mediatek.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to pci/host-mediatek for v4.14, thanks!
Ryder, Matthias, holler if you see any issues.
> ---
> drivers/pci/host/pcie-mediatek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
> index 5a9d8589ea0bd..9c9f89bcf24ce 100644
> --- a/drivers/pci/host/pcie-mediatek.c
> +++ b/drivers/pci/host/pcie-mediatek.c
> @@ -303,7 +303,7 @@ static int mtk_pcie_parse_ports(struct mtk_pcie *pcie,
> }
>
> snprintf(name, sizeof(name), "pcie-rst%d", index);
> - port->reset = devm_reset_control_get_optional(dev, name);
> + port->reset = devm_reset_control_get_optional_exclusive(dev, name);
> if (PTR_ERR(port->reset) == -EPROBE_DEFER)
> return PTR_ERR(port->reset);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-12 11:43 ` Wolfram Sang
0 siblings, 0 replies; 260+ messages in thread
From: Wolfram Sang @ 2017-08-12 11:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Linus Walleij, Dmitry Torokhov, Thomas Petazzoni, lkml,
Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wim Van Sebroeck, Xinliang Liu, Chanwoo Choi, Alan Stern,
Jiri Slaby, Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm, Thomas Gleixner, Vincent Abriou, Bin Liu,
Greg Kroah-Hartman, USB list, linux-wireless, Ralf Baechle,
linux-spi, linux-crypto, Tejun Heo, alsa-devel, linux-doc,
David Airlie, nouveau, Philippe Cornu, Kalle Valo,
Laxman Dewangan, Corentin Labbe, Linux I2C, LINUXWATCHDOG,
Boris Brezillon, Lars-Peter Clausen, Emilio López,
Daniel Lezcano, Jon Hunter, open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, Linux PCI, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Liam Girdwood,
Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, dmaengine,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
Rongrong Zou, linux-fpga, David Woodhouse, Lucas Stach
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
> Thanks for the hint and the references. It seems this turned out okay,
> but I wouldn't dare to introduce such macro horror^Wmagic.
> I'd rather have all users converted to the _exclusive/_shared function
> calls and maybe then replace the internal __reset_control_get with
> Thomas' suggestion.
I didn't follow the discussion closely. Shall I still apply the i2c
patches?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-12 11:43 ` Wolfram Sang
0 siblings, 0 replies; 260+ messages in thread
From: Wolfram Sang @ 2017-08-12 11:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, DRI, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Xinliang Liu, Chanwoo Choi,
Alan Stern, Jiri Slaby, Michael Turquette, Guenter Roeck,
Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, USB list, linux
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
> Thanks for the hint and the references. It seems this turned out okay,
> but I wouldn't dare to introduce such macro horror^Wmagic.
> I'd rather have all users converted to the _exclusive/_shared function
> calls and maybe then replace the internal __reset_control_get with
> Thomas' suggestion.
I didn't follow the discussion closely. Shall I still apply the i2c
patches?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-12 11:43 ` Wolfram Sang
0 siblings, 0 replies; 260+ messages in thread
From: Wolfram Sang @ 2017-08-12 11:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, DRI, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Xinliang Liu, Chanwoo Choi,
Alan Stern, Jiri Slaby, Michael Turquette, Guenter Roeck,
Ohad Ben-Cohen, linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner,
Vincent Abriou, Bin Liu, Greg Kroah-Hartman, USB list
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
> Thanks for the hint and the references. It seems this turned out okay,
> but I wouldn't dare to introduce such macro horror^Wmagic.
> I'd rather have all users converted to the _exclusive/_shared function
> calls and maybe then replace the internal __reset_control_get with
> Thomas' suggestion.
I didn't follow the discussion closely. Shall I still apply the i2c
patches?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-12 11:43 ` Wolfram Sang
0 siblings, 0 replies; 260+ messages in thread
From: Wolfram Sang @ 2017-08-12 11:43 UTC (permalink / raw)
To: Philipp Zabel
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, DRI, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Xinliang Liu, Chanwoo Choi,
Alan Stern, Jiri Slaby, Michael Turquette, Guenter Roeck,
Ohad Ben-Cohen, linux-pm, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, USB list, linux-wireless, lkml,
Ralf Baechle, linux-spi, linux-crypto, Tejun Heo, alsa-devel,
linux-doc, David Airlie, nouveau, Philippe Cornu,
Wim Van Sebroeck, Laxman Dewangan, Corentin Labbe, Linux I2C,
LINUXWATCHDOG, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter,
open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Thomas Petazzoni, Patrice Chotard,
Stanimir Varbanov, Kyungmin Park, Maxime Coquelin,
Hartmut Knaack, Jonathan Cameron, Ulf Hansson, linux-iio,
Linux PCI, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou,
moderated list:ARM/Mediatek SoC support, linux-tegra, Mark Yao,
Moritz Fischer, Vivien Didelot, netdev, Peter De Schrijver,
Stephen Boyd, Adrian Hunter, Vinod Koul, dmaengine, linux-fpga,
David Woodhouse, Lucas Stach
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
> Thanks for the hint and the references. It seems this turned out okay,
> but I wouldn't dare to introduce such macro horror^Wmagic.
> I'd rather have all users converted to the _exclusive/_shared function
> calls and maybe then replace the internal __reset_control_get with
> Thomas' suggestion.
I didn't follow the discussion closely. Shall I still apply the i2c
patches?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
2017-08-12 11:43 ` Wolfram Sang
(?)
(?)
@ 2017-08-14 7:36 ` Philipp Zabel
-1 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-08-14 7:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linus Walleij, Dmitry Torokhov, Thomas Petazzoni, lkml,
Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wim Van Sebroeck, Xinliang Liu, Chanwoo Choi, Alan Stern,
Jiri Slaby, Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm, Thomas Gleixner, Vincent Abriou, Bin Liu,
Greg Kroah-Hartman, USB list, linux-wireless, Ralf Baechle,
linux-spi, linux-crypto, Tejun Heo, alsa-devel, linux-doc,
David Airlie, nouveau, Philippe Cornu, Kalle Valo,
Laxman Dewangan, Corentin Labbe, Linux I2C, LINUXWATCHDOG,
Boris Brezillon, Lars-Peter Clausen, Emilio López,
Daniel Lezcano, Jon Hunter, open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Patrice Chotard, Stanimir Varbanov,
Kyungmin Park, Maxime Coquelin, Hartmut Knaack, Jonathan Cameron,
Ulf Hansson, linux-iio, Linux PCI, Shawn Lin, linux-tegra,
linux-mtd, Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, linux-mmc, Liam Girdwood,
Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, linux-remoteproc,
Bjorn Andersson, linux-ide, Lee Jones, devel, Yannick Fertre,
Ryder Lee, Herbert Xu, Richard Weinberger, Jaehoon Chung,
Marek Vasut, linux-serial, Zhang Rui, Alan Tull, John Youn,
Eduardo Valentin, dmaengine,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Mark Yao, Moritz Fischer, Vivien Didelot, netdev,
Peter De Schrijver, Stephen Boyd, Adrian Hunter, Vinod Koul,
Rongrong Zou, linux-fpga, David Woodhouse, Lucas Stach
On Sat, 2017-08-12 at 13:43 +0200, Wolfram Sang wrote:
> > Thanks for the hint and the references. It seems this turned out
> > okay,
> > but I wouldn't dare to introduce such macro horror^Wmagic.
> > I'd rather have all users converted to the _exclusive/_shared
> > function
> > calls and maybe then replace the internal __reset_control_get with
> > Thomas' suggestion.
>
> I didn't follow the discussion closely. Shall I still apply the i2c
> patches?
Yes, please.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-14 7:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-08-14 7:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linus Walleij, Dmitry Torokhov, Thomas Petazzoni, lkml,
Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wim Van Sebroeck, Xinliang Liu, Chanwoo Choi, Alan Stern,
Jiri Slaby, Michael Turquette, Guenter
On Sat, 2017-08-12 at 13:43 +0200, Wolfram Sang wrote:
> > Thanks for the hint and the references. It seems this turned out
> > okay,
> > but I wouldn't dare to introduce such macro horror^Wmagic.
> > I'd rather have all users converted to the _exclusive/_shared
> > function
> > calls and maybe then replace the internal __reset_control_get with
> > Thomas' suggestion.
>
> I didn't follow the discussion closely. Shall I still apply the i2c
> patches?
Yes, please.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-14 7:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-08-14 7:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linus Walleij, Dmitry Torokhov, Thomas Petazzoni, lkml,
Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen, DRI,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler, linux-clk,
Wim Van Sebroeck, Xinliang Liu, Chanwoo Choi, Alan Stern,
Jiri Slaby, Michael Turquette, Guenter
On Sat, 2017-08-12 at 13:43 +0200, Wolfram Sang wrote:
> > Thanks for the hint and the references. It seems this turned out
> > okay,
> > but I wouldn't dare to introduce such macro horror^Wmagic.
> > I'd rather have all users converted to the _exclusive/_shared
> > function
> > calls and maybe then replace the internal __reset_control_get with
> > Thomas' suggestion.
>
> I didn't follow the discussion closely. Shall I still apply the i2c
> patches?
Yes, please.
regards
Philipp
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-08-14 7:36 ` Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-08-14 7:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, DRI, Marc Dietrich, Rakesh Iyer,
Peter Meerwald-Stadler, linux-clk, Xinliang Liu, Chanwoo Choi,
Alan Stern, Jiri Slaby, Michael Turquette, Guenter Roeck,
Ohad Ben-Cohen, linux-pm, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, USB list, linux-wireless, lkml,
Ralf Baechle, linux-spi, linux-crypto, Tejun Heo, alsa-devel,
linux-doc, David Airlie, nouveau, Philippe Cornu,
Wim Van Sebroeck, Laxman Dewangan, Corentin Labbe, Linux I2C,
LINUXWATCHDOG, Boris Brezillon, Lars-Peter Clausen,
Emilio López, Daniel Lezcano, Jon Hunter,
open list:ARM/Rockchip SoC...,
MyungJoo Ham, Ben Skeggs, Yisen Zhuang, linux-media, Richard Zhu,
Alexandre Torgue, Mathias Nyman, linux-arm-msm, Joachim Eastwood,
linux-gpio, linux-mips, Bjorn Helgaas, Giuseppe Cavallaro,
linux-arm-kernel, Thomas Petazzoni, Patrice Chotard,
Stanimir Varbanov, Kyungmin Park, Maxime Coquelin,
Hartmut Knaack, Jonathan Cameron, Ulf Hansson, linux-iio,
Linux PCI, Shawn Lin, Matthias Brugger, linux-mtd,
Benjamin Gaignard, Florian Fainelli, Jonathan Corbet,
Xinwei Kong, ath10k, Kishon Vijay Abraham I, Chen-Yu Tsai,
linux-input, linux-pwm, Chen Feng, Mark Brown, Dan Williams,
Felipe Balbi, Salil Mehta, Dmitry Torokhov, linux-mmc,
Kalle Valo, Thierry Reding, Cyrille Pitchen, Srinivas Kandagatla,
Maxime Ripard, Brian Norris, David S. Miller, Liam Girdwood,
linux-remoteproc, Bjorn Andersson, linux-ide, Lee Jones, devel,
Yannick Fertre, Ryder Lee, Herbert Xu, Richard Weinberger,
Jaehoon Chung, Marek Vasut, linux-serial, Zhang Rui, Alan Tull,
John Youn, Eduardo Valentin, Rongrong Zou,
moderated list:ARM/Mediatek SoC support, linux-tegra, Mark Yao,
Moritz Fischer, Vivien Didelot, netdev, Peter De Schrijver,
Stephen Boyd, Adrian Hunter, Vinod Koul, dmaengine, linux-fpga,
David Woodhouse, Lucas Stach
On Sat, 2017-08-12 at 13:43 +0200, Wolfram Sang wrote:
> > Thanks for the hint and the references. It seems this turned out
> > okay,
> > but I wouldn't dare to introduce such macro horror^Wmagic.
> > I'd rather have all users converted to the _exclusive/_shared
> > function
> > calls and maybe then replace the internal __reset_control_get with
> > Thomas' suggestion.
>
> I didn't follow the discussion closely. Shall I still apply the i2c
> patches?
Yes, please.
regards
Philipp
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 032/102] iio: dac: stm32-dac-core: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 032/102] iio: dac: stm32-dac-core: " Philipp Zabel
@ 2017-08-20 11:07 ` Jonathan Cameron
0 siblings, 0 replies; 260+ messages in thread
From: Jonathan Cameron @ 2017-08-20 11:07 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Maxime Coquelin, Alexandre Torgue,
linux-iio
On Wed, 19 Jul 2017 17:25:36 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/stm32-dac-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
> index 75e48788c7ead..f1eeb1549f689 100644
> --- a/drivers/iio/dac/stm32-dac-core.c
> +++ b/drivers/iio/dac/stm32-dac-core.c
> @@ -114,7 +114,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
> goto err_vref;
> }
>
> - priv->rst = devm_reset_control_get(dev, NULL);
> + priv->rst = devm_reset_control_get_exclusive(dev, NULL);
> if (!IS_ERR(priv->rst)) {
> reset_control_assert(priv->rst);
> udelay(2);
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 031/102] iio: adc: rockchip_saradc: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 031/102] iio: adc: rockchip_saradc: " Philipp Zabel
@ 2017-08-20 11:09 ` Jonathan Cameron
0 siblings, 0 replies; 260+ messages in thread
From: Jonathan Cameron @ 2017-08-20 11:09 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Heiko Stuebner, linux-iio,
linux-rockchip
On Wed, 19 Jul 2017 17:25:35 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-iio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/rockchip_saradc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index ae6d3324f5183..1d9300ba07c00 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -235,7 +235,8 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
> * The reset should be an optional property, as it should work
> * with old devicetrees as well
> */
> - info->reset = devm_reset_control_get(&pdev->dev, "saradc-apb");
> + info->reset = devm_reset_control_get_exclusive(&pdev->dev,
> + "saradc-apb");
> if (IS_ERR(info->reset)) {
> ret = PTR_ERR(info->reset);
> if (ret != -ENOENT)
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 069/102] pwm: hibvt: explicitly request exclusive reset control
2017-07-19 15:26 ` [PATCH 069/102] pwm: hibvt: " Philipp Zabel
@ 2017-08-21 6:54 ` Thierry Reding
0 siblings, 0 replies; 260+ messages in thread
From: Thierry Reding @ 2017-08-21 6:54 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Wed, Jul 19, 2017 at 05:26:13PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/pwm/pwm-hibvt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-4.14/drivers, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 070/102] pwm: tegra: explicitly request exclusive reset control
2017-07-19 15:26 ` Philipp Zabel
(?)
@ 2017-08-21 6:54 ` Thierry Reding
-1 siblings, 0 replies; 260+ messages in thread
From: Thierry Reding @ 2017-08-21 6:54 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Jonathan Hunter, linux-pwm, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On Wed, Jul 19, 2017 at 05:26:14PM +0200, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/pwm/pwm-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-4.14/drivers, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control
2017-07-19 16:59 ` Suman Anna
@ 2017-08-24 21:58 ` Suman Anna
-1 siblings, 0 replies; 260+ messages in thread
From: Suman Anna @ 2017-08-24 21:58 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel, Bjorn Andersson
Cc: Ohad Ben-Cohen, linux-remoteproc
Hi Bjorn,
On 07/19/2017 11:59 AM, Suman Anna wrote:
> On 07/19/2017 10:26 AM, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Ohad Ben-Cohen <ohad@wizery.com>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-remoteproc@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> Acked-by: Suman Anna <s-anna@ti.com>
Can you pick this one and the other 2 related remoteproc patches?
Believe the subsystem maintainers have been picking these up, I see some
of the other related patches in linux-next but not these.
regards
Suman
>
>> ---
>> drivers/remoteproc/keystone_remoteproc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
>> index 5f776bfd674a0..920fef072b364 100644
>> --- a/drivers/remoteproc/keystone_remoteproc.c
>> +++ b/drivers/remoteproc/keystone_remoteproc.c
>> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>> if (ret)
>> goto free_rproc;
>>
>> - ksproc->reset = devm_reset_control_get(dev, NULL);
>> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>> if (IS_ERR(ksproc->reset)) {
>> ret = PTR_ERR(ksproc->reset);
>> goto free_rproc;
>>
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control
@ 2017-08-24 21:58 ` Suman Anna
0 siblings, 0 replies; 260+ messages in thread
From: Suman Anna @ 2017-08-24 21:58 UTC (permalink / raw)
To: Philipp Zabel, linux-kernel, Bjorn Andersson
Cc: Ohad Ben-Cohen, linux-remoteproc
Hi Bjorn,
On 07/19/2017 11:59 AM, Suman Anna wrote:
> On 07/19/2017 10:26 AM, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Ohad Ben-Cohen <ohad@wizery.com>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-remoteproc@vger.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> Acked-by: Suman Anna <s-anna@ti.com>
Can you pick this one and the other 2 related remoteproc patches?
Believe the subsystem maintainers have been picking these up, I see some
of the other related patches in linux-next but not these.
regards
Suman
>
>> ---
>> drivers/remoteproc/keystone_remoteproc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
>> index 5f776bfd674a0..920fef072b364 100644
>> --- a/drivers/remoteproc/keystone_remoteproc.c
>> +++ b/drivers/remoteproc/keystone_remoteproc.c
>> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>> if (ret)
>> goto free_rproc;
>>
>> - ksproc->reset = devm_reset_control_get(dev, NULL);
>> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>> if (IS_ERR(ksproc->reset)) {
>> ret = PTR_ERR(ksproc->reset);
>> goto free_rproc;
>>
>
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 009/102] clk: sunxi: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 009/102] clk: sunxi: " Philipp Zabel
@ 2017-11-02 5:55 ` Stephen Boyd
0 siblings, 0 replies; 260+ messages in thread
From: Stephen Boyd @ 2017-11-02 5:55 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Emilio López, Michael Turquette,
Maxime Ripard, Chen-Yu Tsai, linux-clk
On 07/19, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: "Emilio López" <emilio@elopez.com.ar>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 010/102] clk: tegra: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 010/102] clk: tegra: " Philipp Zabel
@ 2017-11-02 8:15 ` Stephen Boyd
0 siblings, 0 replies; 260+ messages in thread
From: Stephen Boyd @ 2017-11-02 8:15 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Peter De Schrijver, Prashant Gaikwad,
Michael Turquette, Thierry Reding, Jonathan Hunter, linux-clk,
linux-tegra
On 07/19, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
> Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 260+ messages in thread
* Re: [PATCH 043/102] mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset control
2017-07-19 15:25 ` [PATCH 043/102] mtd: spi-nor: stm32-quadspi: " Philipp Zabel
@ 2018-05-18 20:03 ` Boris Brezillon
0 siblings, 0 replies; 260+ messages in thread
From: Boris Brezillon @ 2018-05-18 20:03 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Boris Brezillon, Maxime Coquelin,
Richard Weinberger, Marek Vasut, linux-mtd, Cyrille Pitchen,
Brian Norris, David Woodhouse, Alexandre Torgue
On Wed, 19 Jul 2017 17:25:47 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Queued to spi-nor/next.
Thanks,
Boris
> ---
> drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 86c0931543c53..a367c56deb3cc 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -633,7 +633,7 @@ static int stm32_qspi_probe(struct platform_device *pdev)
> return ret;
> }
>
> - rstc = devm_reset_control_get(dev, NULL);
> + rstc = devm_reset_control_get_exclusive(dev, NULL);
> if (!IS_ERR(rstc)) {
> reset_control_assert(rstc);
> udelay(2);
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 260+ messages in thread
* [PATCH 000/102] Convert drivers to explicit reset API
@ 2017-07-19 15:25 Philipp Zabel
0 siblings, 0 replies; 260+ messages in thread
From: Philipp Zabel @ 2017-07-19 15:25 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Andrew Lunn, Prashant Gaikwad, Heiko Stuebner, Peter Chen,
Linus Walleij, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
Marc Dietrich, Rakesh Iyer, Peter Meerwald-Stadler,
linux-clk-u79uwXL29TY76Z2rM5mHXA, Wim Van Sebroeck, Wolfram Sang,
Xinliang Liu, Chanwoo Choi, Alan Stern, Jiri Slaby,
Michael Turquette, Guenter Roeck, Ohad Ben-Cohen,
linux-pm-u79uwXL29TY76Z2rM5mHXA, Thomas Gleixner, Vincent Abriou,
Bin Liu, Greg Kroah-Hartman, linux-usb-u79uwXL29TaqPxH82wqD4g
The reset control API has two modes: exclusive access, where the driver
expects to have full and immediate control over the state of the reset
line, and shared (clock-like) access, where drivers only request reset
deassertion while active, but don't care about the state of the reset line
while inactive.
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior.
This series converts all drivers that currently implicitly request
exclusive reset controls to the corresponding explicit API call. It is,
for the most part, generated from the following semantic patch:
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get(dev, id);
+rstc = reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = reset_control_get_optional(dev, id);
+rstc = reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, node, id;
@@
-rstc = of_reset_control_get(node, id);
+rstc = of_reset_control_get_exclusive(node, id);
@@
expression rstc, node, index;
@@
-rstc = of_reset_control_get_by_index(node, index);
+rstc = of_reset_control_get_exclusive_by_index(node, index);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get(dev, id);
+rstc = devm_reset_control_get_exclusive(dev, id);
@@
expression rstc, dev, id;
@@
-rstc = devm_reset_control_get_optional(dev, id);
+rstc = devm_reset_control_get_optional_exclusive(dev, id);
@@
expression rstc, dev, index;
@@
-rstc = devm_reset_control_get_by_index(dev, index);
+rstc = devm_reset_control_get_exclusive_by_index(dev, index);
After all driver patches are applied, the temporary transition helpers
can be removed.
regards
Philipp
Philipp Zabel (102):
ARM: rockchip: explicitly request exclusive reset control
ARM: socfpga: explicitly request exclusive reset control
MIPS: pci-mt7620: explicitly request exclusive reset control
ahci: st: explicitly request exclusive reset control
ata: sata_gemini: explicitly request exclusive reset control
ata: ahci_tegra: explicitly request exclusive reset control
bus: sunxi-rsb: explicitly request exclusive reset control
bus: tegra-gmi: explicitly request exclusive reset control
clk: sunxi: explicitly request exclusive reset control
clk: tegra: explicitly request exclusive reset control
clocksource/drivers/timer-stm32: explicitly request exclusive reset
control
clocksource/drivers/sun5i: explicitly request exclusive reset control
crypto: rockchip: explicitly request exclusive reset control
crypto: sun4i-ss - request exclusive reset control
PM / devfreq: tegra: explicitly request exclusive reset control
dmaengine: stm32-dma: explicitly request exclusive reset control
dmaengine: sun6i: explicitly request exclusive reset control
dmaengine: tegra-apb: explicitly request exclusive reset control
drm: kirin: explicitly request exclusive reset control
drm/nouveau/tegra: explicitly request exclusive reset control
drm/rockchip: explicitly request exclusive reset control
drm/sti: explicitly request exclusive reset control
drm/stm: explicitly request exclusive reset control
drm/sun4i: explicitly request exclusive reset control
drm/tegra: explicitly request exclusive reset control
gpu: host1x: explicitly request exclusive reset control
i2c: mv64xxx: explicitly request exclusive reset control
i2c: stm32f4: explicitly request exclusive reset control
i2c: sun6i-pw2i: explicitly request exclusive reset control
i2c: tegra: explicitly request exclusive reset control
iio: adc: rockchip_saradc: explicitly request exclusive reset control
iio: dac: stm32-dac-core: explicitly request exclusive reset control
Input: tegra-kbc - request exclusive reset control
coda: explicitly request exclusive reset control
st-rc: explicitly request exclusive reset control
stm32-dcmi: explicitly request exclusive reset control
rc: sunxi-cir: explicitly request exclusive reset control
mmc: dw_mmc: explicitly request exclusive reset control
mmc: sdhci-st: explicitly request exclusive reset control
mmc: sunxi: explicitly request exclusive reset control
mmc: tegra: explicitly request exclusive reset control
mtd: nand: sunxi: explicitly request exclusive reset control
mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset
control
net: dsa: mt7530: explicitly request exclusive reset control
net: ethernet: hisi_femac: explicitly request exclusive reset control
net: ethernet: hix5hd2_gmac: explicitly request exclusive reset
control
net: stmmac: explicitly request exclusive reset control
net: stmmac: dwc-qos: explicitly request exclusive reset control
ath10k: explicitly request exclusive reset control
nvmem: lpc18xx-eeprom: explicitly request exclusive reset control
PCI: dwc: pcie-qcom: explicitly request exclusive reset control
PCI: imx6: explicitly request exclusive reset control
PCI: tegra: explicitly request exclusive reset control
PCI: rockchip: explicitly request exclusive reset control
phy: berlin-usb: explicitly request exclusive reset control
PCI: mediatek: explicitly request exclusive reset control
phy: qcom-usb-hs: explicitly request exclusive reset control
phy: rockchip-pcie: explicitly request exclusive reset control
phy: rockchip-typec: explicitly request exclusive reset control
phy: rockchip-usb: explicitly request exclusive reset control
phy: sun4i-usb: explicitly request exclusive reset control
phy: sun9i-usb: explicitly request exclusive reset control
phy: tegra: explicitly request exclusive reset control
phy: qcom-qmp: explicitly request exclusive reset control
phy: qcom-qusb2: explicitly request exclusive reset control
pinctrl: stm32: explicitly request exclusive reset control
pinctrl: sunxi: explicitly request exclusive reset control
pinctrl: tegra: explicitly request exclusive reset control
pwm: hibvt: explicitly request exclusive reset control
pwm: tegra: explicitly request exclusive reset control
remoteproc/keystone: explicitly request exclusive reset control
remoteproc: qcom: explicitly request exclusive reset control
remoteproc: st: explicitly request exclusive reset control
soc: mediatek: PMIC wrap: explicitly request exclusive reset control
soc/tegra: pmc: explicitly request exclusive reset control
spi: stm32: explicitly request exclusive reset control
spi: sun6i: explicitly request exclusive reset control
spi: tegra20-slink: explicitly request exclusive reset control
spi: tegra114: explicitly request exclusive reset control
spi: tegra20-sflash: explicitly request exclusive reset control
staging: nvec: explicitly request exclusive reset control
thermal: rockchip: explicitly request exclusive reset control
thermal: tegra: explicitly request exclusive reset control
serial: 8250_dw: explicitly request exclusive reset control
serial: tegra: explicitly request exclusive reset control
usb: chipidea: msm: explicitly request exclusive reset control
usb: dwc2: explicitly request exclusive reset control
usb: host: ehci-tegra: explicitly request exclusive reset control
usb: host: xhci-tegra: explicitly request exclusive reset control
usb: musb: sunxi: explicitly request exclusive reset control
usb: phy: msm: explicitly request exclusive reset control
usb: phy: qcom-8x16-usb: explicitly request exclusive reset control
watchdog: asm9260: explicitly request exclusive reset control
watchdog: mt7621: explicitly request exclusive reset control
watchdog: rt2880: explicitly request exclusive reset control
watchdog: zx2967: explicitly request exclusive reset control
ASoC: img: explicitly request exclusive reset control
ASoC: stm32: explicitly request exclusive reset control
ASoC: sun4i: explicitly request exclusive reset control
ASoC: tegra: explicitly request exclusive reset control
Documentation: devres: add explicit exclusive/shared reset control
request calls
reset: finish transition to explicit exclusive reset control requests
Documentation/driver-model/devres.txt | 7 ++-
arch/arm/mach-rockchip/platsmp.c | 2 +-
arch/mips/pci/pci-mt7620.c | 2 +-
drivers/ata/ahci_st.c | 6 +--
drivers/ata/ahci_tegra.c | 8 ++--
drivers/ata/sata_gemini.c | 4 +-
drivers/bus/sunxi-rsb.c | 2 +-
drivers/bus/tegra-gmi.c | 2 +-
drivers/clk/sunxi/clk-sun9i-mmc.c | 2 +-
drivers/clk/tegra/clk-dfll.c | 2 +-
drivers/clocksource/timer-stm32.c | 2 +-
drivers/clocksource/timer-sun5i.c | 2 +-
drivers/crypto/rockchip/rk3288_crypto.c | 2 +-
drivers/crypto/sunxi-ss/sun4i-ss-core.c | 3 +-
drivers/devfreq/tegra-devfreq.c | 2 +-
drivers/dma/stm32-dma.c | 2 +-
drivers/dma/sun6i-dma.c | 2 +-
drivers/dma/tegra20-apb-dma.c | 2 +-
drivers/fpga/altera-hps2fpga.c | 3 +-
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/cdn-dp-core.c | 8 ++--
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +-
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
drivers/gpu/drm/stm/ltdc.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
drivers/gpu/drm/sun4i/sun6i_drc.c | 2 +-
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +-
drivers/gpu/drm/tegra/dc.c | 2 +-
drivers/gpu/drm/tegra/dpaux.c | 3 +-
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/drm/tegra/gr3d.c | 6 +--
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 2 +-
drivers/gpu/host1x/dev.c | 2 +-
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
drivers/i2c/busses/i2c-tegra.c | 2 +-
drivers/iio/adc/rockchip_saradc.c | 3 +-
drivers/iio/dac/stm32-dac-core.c | 2 +-
drivers/input/keyboard/tegra-kbc.c | 2 +-
drivers/media/platform/coda/coda-common.c | 3 +-
drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
drivers/media/rc/st_rc.c | 2 +-
drivers/media/rc/sunxi-cir.c | 2 +-
drivers/mmc/host/dw_mmc.c | 2 +-
drivers/mmc/host/sdhci-st.c | 2 +-
drivers/mmc/host/sdhci-tegra.c | 3 +-
drivers/mmc/host/sunxi-mmc.c | 3 +-
drivers/mtd/nand/sunxi_nand.c | 2 +-
drivers/mtd/spi-nor/stm32-quadspi.c | 2 +-
drivers/net/dsa/mt7530.c | 3 +-
drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +-
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +--
.../ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 +-
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +-
drivers/net/wireless/ath/ath10k/ahb.c | 15 ++++---
drivers/nvmem/lpc18xx_eeprom.c | 2 +-
drivers/pci/dwc/pci-imx6.c | 7 +--
drivers/pci/dwc/pcie-qcom.c | 40 +++++++++--------
drivers/pci/host/pci-tegra.c | 6 +--
drivers/pci/host/pcie-mediatek.c | 2 +-
drivers/pci/host/pcie-rockchip.c | 15 ++++---
drivers/phy/allwinner/phy-sun4i-usb.c | 2 +-
drivers/phy/allwinner/phy-sun9i-usb.c | 4 +-
drivers/phy/marvell/phy-berlin-usb.c | 2 +-
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 +-
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +-
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 3 +-
drivers/phy/rockchip/phy-rockchip-pcie.c | 2 +-
drivers/phy/rockchip/phy-rockchip-typec.c | 6 +--
drivers/phy/rockchip/phy-rockchip-usb.c | 2 +-
drivers/phy/tegra/xusb-tegra210.c | 4 +-
drivers/phy/tegra/xusb.c | 2 +-
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 2 +-
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 2 +-
drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-tegra.c | 2 +-
drivers/remoteproc/keystone_remoteproc.c | 2 +-
drivers/remoteproc/qcom_q6v5_pil.c | 3 +-
drivers/remoteproc/st_remoteproc.c | 6 ++-
drivers/reset/core.c | 2 +-
drivers/soc/mediatek/mtk-pmic-wrap.c | 5 ++-
drivers/soc/tegra/pmc.c | 2 +-
drivers/spi/spi-stm32.c | 2 +-
drivers/spi/spi-sun6i.c | 2 +-
drivers/spi/spi-tegra114.c | 2 +-
drivers/spi/spi-tegra20-sflash.c | 2 +-
drivers/spi/spi-tegra20-slink.c | 2 +-
drivers/staging/nvec/nvec.c | 2 +-
drivers/thermal/rockchip_thermal.c | 3 +-
drivers/thermal/tegra/soctherm.c | 3 +-
drivers/tty/serial/8250/8250_dw.c | 2 +-
drivers/tty/serial/serial-tegra.c | 2 +-
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
drivers/usb/dwc2/platform.c | 3 +-
drivers/usb/host/ehci-tegra.c | 5 ++-
drivers/usb/host/xhci-tegra.c | 6 ++-
drivers/usb/musb/sunxi.c | 2 +-
drivers/usb/phy/phy-msm-usb.c | 4 +-
drivers/usb/phy/phy-qcom-8x16-usb.c | 2 +-
drivers/watchdog/asm9260_wdt.c | 2 +-
drivers/watchdog/mt7621_wdt.c | 2 +-
drivers/watchdog/rt2880_wdt.c | 2 +-
drivers/watchdog/zx2967_wdt.c | 2 +-
include/linux/reset.h | 50 ----------------------
sound/soc/img/img-i2s-in.c | 2 +-
sound/soc/img/img-i2s-out.c | 2 +-
sound/soc/img/img-parallel-out.c | 2 +-
sound/soc/img/img-spdif-in.c | 2 +-
sound/soc/img/img-spdif-out.c | 2 +-
sound/soc/stm/stm32_i2s.c | 2 +-
sound/soc/stm/stm32_sai.c | 2 +-
sound/soc/stm/stm32_spdifrx.c | 2 +-
sound/soc/sunxi/sun4i-codec.c | 3 +-
sound/soc/sunxi/sun4i-i2s.c | 2 +-
sound/soc/sunxi/sun4i-spdif.c | 3 +-
sound/soc/tegra/tegra30_ahub.c | 4 +-
128 files changed, 226 insertions(+), 235 deletions(-)
--
2.11.0
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "Emilio López" <emilio@elopez.com.ar>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Alan Tull <atull@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Bin Liu <b-liu@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: John Youn <johnyoun@synopsys.com>
Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Marc Dietrich <marvin24@gmx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Mark Yao <mark.yao@rock-chips.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Peter Chen <Peter.Chen@nxp.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Philippe Cornu <philippe.cornu@st.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
Cc: Rakesh Iyer <riyer@nvidia.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: alsa-devel@alsa-project.org
Cc: ath10k@lists.infradead.org
Cc: devel@driverdev.osuosl.org
Cc: dmaengine@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-fpga@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-mips@linux-mips.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-pwm@vger.kernel.org
Cc: linux-remoteproc@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: linux-spi@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: nouveau@lists.freedesktop.org
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 260+ messages in thread
end of thread, other threads:[~2018-05-18 20:03 UTC | newest]
Thread overview: 260+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-19 15:25 [PATCH 000/102] Convert drivers to explicit reset API Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 001/102] ARM: rockchip: explicitly request exclusive reset control Philipp Zabel
2017-07-20 20:28 ` Heiko Stuebner
2017-07-19 15:25 ` [PATCH 002/102] ARM: socfpga: " Philipp Zabel
2017-07-19 16:12 ` Moritz Fischer
2017-07-27 18:49 ` Alan Tull
2017-07-19 15:25 ` [PATCH 003/102] MIPS: pci-mt7620: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 004/102] ahci: st: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 005/102] ata: sata_gemini: " Philipp Zabel
2017-08-02 9:39 ` Linus Walleij
2017-08-02 15:15 ` Tejun Heo
2017-07-19 15:25 ` [PATCH 006/102] ata: ahci_tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 007/102] bus: sunxi-rsb: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 008/102] bus: tegra-gmi: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 009/102] clk: sunxi: " Philipp Zabel
2017-11-02 5:55 ` Stephen Boyd
2017-07-19 15:25 ` [PATCH 010/102] clk: tegra: " Philipp Zabel
2017-11-02 8:15 ` Stephen Boyd
2017-07-19 15:25 ` [PATCH 011/102] clocksource/drivers/timer-stm32: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 012/102] clocksource/drivers/sun5i: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 013/102] crypto: rockchip: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 014/102] crypto: sun4i-ss - " Philipp Zabel
2017-07-19 15:25 ` [PATCH 015/102] PM / devfreq: tegra: explicitly " Philipp Zabel
2017-07-19 15:25 ` [PATCH 016/102] dmaengine: stm32-dma: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 017/102] dmaengine: sun6i: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 018/102] dmaengine: tegra-apb: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 019/102] drm: kirin: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 020/102] drm/nouveau/tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 021/102] drm/rockchip: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 022/102] drm/sti: " Philipp Zabel
2017-07-20 10:09 ` Benjamin Gaignard
2017-07-20 10:09 ` Benjamin Gaignard
2017-07-19 15:25 ` [PATCH 023/102] drm/stm: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 024/102] drm/sun4i: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 025/102] drm/tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 026/102] gpu: host1x: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 027/102] i2c: mv64xxx: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 028/102] i2c: stm32f4: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 029/102] i2c: sun6i-pw2i: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 030/102] i2c: tegra: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 031/102] iio: adc: rockchip_saradc: " Philipp Zabel
2017-08-20 11:09 ` Jonathan Cameron
2017-07-19 15:25 ` [PATCH 032/102] iio: dac: stm32-dac-core: " Philipp Zabel
2017-08-20 11:07 ` Jonathan Cameron
2017-07-19 15:25 ` [PATCH 034/102] coda: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 035/102] st-rc: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 036/102] stm32-dcmi: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 037/102] rc: sunxi-cir: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 038/102] mmc: dw_mmc: " Philipp Zabel
2017-07-22 13:13 ` Shawn Lin
2017-07-27 14:48 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 039/102] mmc: sdhci-st: " Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 040/102] mmc: sunxi: " Philipp Zabel
2017-07-27 14:48 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 041/102] mmc: tegra: " Philipp Zabel
2017-07-27 14:49 ` Ulf Hansson
2017-07-19 15:25 ` [PATCH 042/102] mtd: nand: sunxi: " Philipp Zabel
2017-07-20 7:00 ` Boris Brezillon
2017-07-20 9:27 ` Philipp Zabel
2017-07-20 9:27 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 043/102] mtd: spi-nor: stm32-quadspi: " Philipp Zabel
2018-05-18 20:03 ` Boris Brezillon
2017-07-19 15:25 ` [PATCH 044/102] net: dsa: mt7530: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 045/102] net: ethernet: hisi_femac: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 046/102] net: ethernet: hix5hd2_gmac: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 047/102] net: stmmac: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 048/102] net: stmmac: dwc-qos: " Philipp Zabel
2017-07-19 15:25 ` [PATCH 049/102] ath10k: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-08-03 11:38 ` [049/102] " Kalle Valo
2017-08-03 11:38 ` Kalle Valo
2017-07-19 15:25 ` [PATCH 050/102] nvmem: lpc18xx-eeprom: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:25 ` [PATCH 051/102] PCI: dwc: pcie-qcom: " Philipp Zabel
2017-08-03 21:40 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 052/102] PCI: imx6: " Philipp Zabel
2017-08-03 21:41 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 053/102] PCI: tegra: " Philipp Zabel
[not found] ` <20170719152646.25903-54-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-08-03 21:42 ` Bjorn Helgaas
2017-08-03 21:42 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 054/102] PCI: rockchip: " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-22 13:12 ` Shawn Lin
2017-07-24 8:35 ` Philipp Zabel
2017-08-03 0:31 ` Shawn Lin
2017-08-03 21:43 ` Bjorn Helgaas
2017-07-19 15:25 ` [PATCH 055/102] phy: berlin-usb: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 056/102] PCI: mediatek: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-08-03 21:45 ` Bjorn Helgaas
2017-07-19 15:26 ` [PATCH 057/102] phy: qcom-usb-hs: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 058/102] phy: rockchip-pcie: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-22 13:09 ` Shawn Lin
2017-08-03 0:37 ` Shawn Lin
2017-07-19 15:26 ` [PATCH 059/102] phy: rockchip-typec: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 060/102] phy: rockchip-usb: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 061/102] phy: sun4i-usb: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 062/102] phy: sun9i-usb: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 063/102] phy: tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 064/102] phy: qcom-qmp: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 065/102] phy: qcom-qusb2: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 066/102] pinctrl: stm32: " Philipp Zabel
2017-08-02 11:43 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 067/102] pinctrl: sunxi: " Philipp Zabel
2017-08-02 11:44 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 068/102] pinctrl: tegra: " Philipp Zabel
[not found] ` <20170719152646.25903-69-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-08-02 11:45 ` Linus Walleij
2017-08-02 11:45 ` Linus Walleij
2017-07-19 15:26 ` [PATCH 069/102] pwm: hibvt: " Philipp Zabel
2017-08-21 6:54 ` Thierry Reding
2017-07-19 15:26 ` [PATCH 071/102] remoteproc/keystone: " Philipp Zabel
2017-07-19 16:59 ` Suman Anna
2017-07-19 16:59 ` Suman Anna
2017-08-24 21:58 ` Suman Anna
2017-08-24 21:58 ` Suman Anna
2017-07-19 15:26 ` [PATCH 072/102] remoteproc: qcom: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 073/102] remoteproc: st: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 074/102] soc: mediatek: PMIC wrap: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 075/102] soc/tegra: pmc: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 076/102] spi: stm32: " Philipp Zabel
2017-07-19 16:08 ` Applied "spi: stm32: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 15:26 ` [PATCH 077/102] spi: sun6i: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "spi: sun6i: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 15:26 ` [PATCH 081/102] staging: nvec: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 082/102] thermal: rockchip: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 083/102] thermal: tegra: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 084/102] serial: 8250_dw: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 086/102] usb: chipidea: msm: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 087/102] usb: dwc2: " Philipp Zabel
[not found] ` <20170719152646.25903-1-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-07-19 15:25 ` [PATCH 033/102] Input: tegra-kbc - " Philipp Zabel
2017-07-19 15:25 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 070/102] pwm: tegra: explicitly " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-08-21 6:54 ` Thierry Reding
2017-07-19 15:26 ` [PATCH 078/102] spi: tegra20-slink: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra20-slink: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 079/102] spi: tegra114: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra114: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 080/102] spi: tegra20-sflash: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "spi: tegra20-sflash: explicitly request exclusive reset control" to the spi tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 085/102] serial: tegra: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 088/102] usb: host: ehci-tegra: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 15:26 ` [PATCH 100/102] ASoC: tegra: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: tegra: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-20 20:32 ` [PATCH 000/102] Convert drivers to explicit reset API Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-19 15:26 ` [PATCH 089/102] usb: host: xhci-tegra: explicitly request exclusive reset control Philipp Zabel
2017-07-19 15:26 ` [PATCH 090/102] usb: musb: sunxi: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 091/102] usb: phy: msm: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 092/102] usb: phy: qcom-8x16-usb: " Philipp Zabel
2017-07-19 15:26 ` [PATCH 093/102] watchdog: asm9260: " Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 094/102] watchdog: mt7621: " Philipp Zabel
2017-07-19 17:35 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 095/102] watchdog: rt2880: " Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 096/102] watchdog: zx2967: " Philipp Zabel
2017-07-19 17:36 ` Guenter Roeck
2017-07-19 15:26 ` [PATCH 097/102] ASoC: img: " Philipp Zabel
2017-07-19 15:26 ` Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: img: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 098/102] ASoC: stm32: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: stm32: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 099/102] ASoC: sun4i: explicitly request exclusive reset control Philipp Zabel
2017-07-19 16:08 ` Applied "ASoC: sun4i: explicitly request exclusive reset control" to the asoc tree Mark Brown
2017-07-19 16:08 ` Mark Brown
2017-07-19 15:26 ` [PATCH 101/102] Documentation: devres: add explicit exclusive/shared reset control request calls Philipp Zabel
2017-07-20 7:10 ` Lee Jones
2017-07-19 15:26 ` [PATCH 102/102] reset: finish transition to explicit exclusive reset control requests Philipp Zabel
2017-07-20 7:12 ` Lee Jones
2017-07-19 19:15 ` [PATCH 000/102] Convert drivers to explicit reset API Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-19 19:15 ` Thomas Petazzoni
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 9:36 ` Philipp Zabel
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 10:36 ` Thomas Petazzoni
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 12:55 ` Philipp Zabel
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-20 20:46 ` Dmitry Torokhov
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-23 18:41 ` Linus Walleij
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
2017-07-24 8:33 ` Philipp Zabel
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-12 11:43 ` Wolfram Sang
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-08-14 7:36 ` Philipp Zabel
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 6:56 ` Maxime Ripard
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 8:11 ` Greg Kroah-Hartman
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 9:24 ` Philipp Zabel
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:36 ` (no subject) Heiko Stuebner
2017-07-20 20:32 ` [PATCH 000/102] Convert drivers to explicit reset API Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` (no subject) Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
2017-07-20 20:32 ` [PATCH 000/102] Convert drivers to explicit reset API Heiko Stuebner
2017-07-20 20:32 ` Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2017-07-19 15:25 Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.