[Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

[Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

[Chaitanya Kumar Borah]

With change [1], visibility of struct seq_file is lost in
intel_display_power.h leading to build errors. Add header
file explicitly to restore visibility.

[1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")

Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index be1a87bde0c9..888993079a7b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -6,6 +6,8 @@
 #ifndef __INTEL_DISPLAY_POWER_H__
 #define __INTEL_DISPLAY_POWER_H__
 
+#include <linux/seq_file.h>
+
 #include "intel_wakeref.h"
 
 enum aux_ch;
-- 
2.25.1

Re: [Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

[Jani Nikula]

On Mon, 26 Jun 2023, Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> wrote:
> With change [1], visibility of struct seq_file is lost in
> intel_display_power.h leading to build errors. Add header
> file explicitly to restore visibility.
>
> [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_power.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index be1a87bde0c9..888993079a7b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -6,6 +6,8 @@
>  #ifndef __INTEL_DISPLAY_POWER_H__
>  #define __INTEL_DISPLAY_POWER_H__
>  
> +#include <linux/seq_file.h>
> +

Always prefer a forward declaration over an include when it's
sufficient.

BR,
Jani.


>  #include "intel_wakeref.h"
>  
>  enum aux_ch;

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Chaitanya Kumar Borah]

With change [1], visibility of struct seq_file is lost in
intel_display_power.h leading to build errors. Add forward
declaration.

[1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")

v2: Use forward declaration instead of headerfile inclusion [Jani]

Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index be1a87bde0c9..0ba268e566b0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -16,6 +16,7 @@ enum port;
 struct drm_i915_private;
 struct i915_power_well;
 struct intel_encoder;
+struct seq_file;
 
 /*
  * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances
-- 
2.25.1

Re: [Intel-gfx] [PATCH] drm/i915/display: Add header file for struct seq_file

[Borah, Chaitanya Kumar]

Hello Jani,

> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, June 26, 2023 12:25 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah@intel.com>
> Subject: Re: [PATCH] drm/i915/display: Add header file for struct seq_file
> 
> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com> wrote:
> > With change [1], visibility of struct seq_file is lost in
> > intel_display_power.h leading to build errors. Add header file
> > explicitly to restore visibility.
> >
> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
> > declaration")
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display_power.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
> > b/drivers/gpu/drm/i915/display/intel_display_power.h
> > index be1a87bde0c9..888993079a7b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> > @@ -6,6 +6,8 @@
> >  #ifndef __INTEL_DISPLAY_POWER_H__
> >  #define __INTEL_DISPLAY_POWER_H__
> >
> > +#include <linux/seq_file.h>
> > +
> 
> Always prefer a forward declaration over an include when it's sufficient.
> 

Thank you for your comment, I have sent out the v2 of the patch with forward declaration.

Is there a path for this patch to get merged into linux-next?

Regards

Chaitanya

> BR,
> Jani.
> 
> 
> >  #include "intel_wakeref.h"
> >
> >  enum aux_ch;
> 
> --
> Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Add header file for struct seq_file (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/display: Add header file for struct seq_file (rev2)
URL   : https://patchwork.freedesktop.org/series/119845/
State : warning

== Summary ==

Error: dim checkpatch failed
2cbe7a6b6366 drm/i915/display: Add forward declaration for struct seq_file
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")'
#10: 
[1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")

total: 1 errors, 0 warnings, 0 checks, 7 lines checked

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Add header file for struct seq_file (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/display: Add header file for struct seq_file (rev2)
URL   : https://patchwork.freedesktop.org/series/119845/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Add header file for struct seq_file (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 9189 bytes --]

== Series Details ==

Series: drm/i915/display: Add header file for struct seq_file (rev2)
URL   : https://patchwork.freedesktop.org/series/119845/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13321 -> Patchwork_119845v2
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/index.html

Participating hosts (41 -> 40)
------------------------------

  Additional (1): fi-bsw-n3050 
  Missing    (2): bat-rpls-2 fi-snb-2520m 

New tests
---------

  New tests have been introduced between CI_DRM_13321 and Patchwork_119845v2:

### New IGT tests (8) ###

  * igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-5:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@hang-read-crc@pipe-b-dp-6:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-5:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-5:
    - Statuses : 1 dmesg-fail(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-a-dp-5:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-b-dp-5:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-5:
    - Statuses : 1 pass(s)
    - Exec time: [0.0] s

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-5:
    - Statuses : 1 abort(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_119845v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-adlp-11:        NOTRUN -> [SKIP][1] ([i915#7456])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@debugfs_test@basic-hwmon.html

  * igt@gem_tiled_pread_basic:
    - bat-adlp-11:        NOTRUN -> [SKIP][2] ([i915#3282])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@gem_tiled_pread_basic.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      [PASS][3] -> [DMESG-FAIL][4] ([i915#5334] / [i915#7872])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-8:         [PASS][5] -> [DMESG-FAIL][6] ([i915#7059])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [PASS][7] -> [ABORT][8] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-rpls-1/igt@i915_selftest@live@reset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-rpls-1/igt@i915_selftest@live@reset.html

  * igt@i915_selftest@live@workarounds:
    - bat-mtlp-6:         [PASS][9] -> [DMESG-FAIL][10] ([i915#6763])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html

  * igt@kms_chamelium_edid@dp-edid-read:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][11] ([fdo#109271]) +25 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/fi-bsw-n3050/igt@kms_chamelium_edid@dp-edid-read.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - bat-adlp-11:        NOTRUN -> [SKIP][12] ([i915#7828]) +7 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-adlp-11:        NOTRUN -> [SKIP][13] ([i915#4103]) +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - bat-adlp-11:        NOTRUN -> [SKIP][14] ([i915#3637])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_flip@basic-flip-vs-wf_vblank.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-adlp-11:        NOTRUN -> [SKIP][15] ([i915#4093]) +3 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4579]) +1 similar issue
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/fi-bsw-n3050/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2.html

  * igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-5 (NEW):
    - bat-adlp-11:        NOTRUN -> [DMESG-FAIL][17] ([i915#6868]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_pipe_crc_basic@hang-read-crc@pipe-d-dp-5.html

  * igt@kms_pipe_crc_basic@nonblocking-crc:
    - bat-adlp-11:        NOTRUN -> [SKIP][18] ([i915#3546])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_pipe_crc_basic@nonblocking-crc.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
    - bat-dg2-8:          [PASS][19] -> [FAIL][20] ([i915#7932]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-5 (NEW):
    - bat-adlp-11:        NOTRUN -> [ABORT][21] ([i915#4423])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-5.html

  
#### Possible fixes ####

  * igt@i915_module_load@load:
    - bat-adlp-11:        [ABORT][22] ([i915#4423]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-adlp-11/igt@i915_module_load@load.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-adlp-11/igt@i915_module_load@load.html

  * igt@i915_selftest@live@requests:
    - bat-mtlp-6:         [DMESG-FAIL][24] ([i915#7269]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/bat-mtlp-6/igt@i915_selftest@live@requests.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/bat-mtlp-6/igt@i915_selftest@live@requests.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
  [i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384


Build changes
-------------

  * Linux: CI_DRM_13321 -> Patchwork_119845v2

  CI-20190529: 20190529
  CI_DRM_13321: 8bcc0ce6569a5889bd5a4b078b7c20e50d7be9d7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7348: feb4fdbcce1e53cb1d483aad3d5ec4ff41092359 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119845v2: 8bcc0ce6569a5889bd5a4b078b7c20e50d7be9d7 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

8d74d1d87679 drm/i915/display: Add forward declaration for struct seq_file

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/index.html

[-- Attachment #2: Type: text/html, Size: 10623 bytes --]

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Jani Nikula]

On Mon, 26 Jun 2023, Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> wrote:
> With change [1], visibility of struct seq_file is lost in
> intel_display_power.h leading to build errors. Add forward
> declaration.
>
> [1] ef104443bffa ("procfs: consolidate arch_report_meminfo declaration")
>
> v2: Use forward declaration instead of headerfile inclusion [Jani]
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

Hey, thanks for the patch, this would've been fine, but looks like Imre
just pushed commit f4fab137dd2b ("drm/i915: Add missing forward
declarations/includes to display power headers") which adds the forward
declaration among other things.

Sorry for the trouble.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index be1a87bde0c9..0ba268e566b0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -16,6 +16,7 @@ enum port;
>  struct drm_i915_private;
>  struct i915_power_well;
>  struct intel_encoder;
> +struct seq_file;
>  
>  /*
>   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain instances

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Borah, Chaitanya Kumar]

Hello Jani,

> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, June 26, 2023 5:37 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah@intel.com>
> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for struct
> seq_file
> 
> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
> <chaitanya.kumar.borah@intel.com> wrote:
> > With change [1], visibility of struct seq_file is lost in
> > intel_display_power.h leading to build errors. Add forward
> > declaration.
> >
> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
> > declaration")
> >
> > v2: Use forward declaration instead of headerfile inclusion [Jani]
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> 
> Hey, thanks for the patch, this would've been fine, but looks like Imre just
> pushed commit f4fab137dd2b ("drm/i915: Add missing forward
> declarations/includes to display power headers") which adds the forward
> declaration among other things.
> 
> Sorry for the trouble.
> 

No problem, Thank you for the info.

Sorry for my ignorance but will this patch eventually find its way to linux-next or do we need to do something special here?

Regards

Chaitanya

> BR,
> Jani.
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
> > b/drivers/gpu/drm/i915/display/intel_display_power.h
> > index be1a87bde0c9..0ba268e566b0 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> > @@ -16,6 +16,7 @@ enum port;
> >  struct drm_i915_private;
> >  struct i915_power_well;
> >  struct intel_encoder;
> > +struct seq_file;
> >
> >  /*
> >   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain
> > instances
> 
> --
> Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Jani Nikula]

On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
> Hello Jani,
>
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@linux.intel.com>
>> Sent: Monday, June 26, 2023 5:37 PM
>> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
>> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
>> <chaitanya.kumar.borah@intel.com>
>> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for struct
>> seq_file
>> 
>> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
>> <chaitanya.kumar.borah@intel.com> wrote:
>> > With change [1], visibility of struct seq_file is lost in
>> > intel_display_power.h leading to build errors. Add forward
>> > declaration.
>> >
>> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
>> > declaration")
>> >
>> > v2: Use forward declaration instead of headerfile inclusion [Jani]
>> >
>> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>> 
>> Hey, thanks for the patch, this would've been fine, but looks like Imre just
>> pushed commit f4fab137dd2b ("drm/i915: Add missing forward
>> declarations/includes to display power headers") which adds the forward
>> declaration among other things.
>> 
>> Sorry for the trouble.
>> 
>
> No problem, Thank you for the info.
>
> Sorry for my ignorance but will this patch eventually find its way to
> linux-next or do we need to do something special here?

It'll show up in linux-next once -rc1 is out. But I'm not sure that's
the *question* you want the answer to, really.

BR,
Jani.


>
> Regards
>
> Chaitanya
>
>> BR,
>> Jani.
>> 
>> > ---
>> >  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
>> > b/drivers/gpu/drm/i915/display/intel_display_power.h
>> > index be1a87bde0c9..0ba268e566b0 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
>> > @@ -16,6 +16,7 @@ enum port;
>> >  struct drm_i915_private;
>> >  struct i915_power_well;
>> >  struct intel_encoder;
>> > +struct seq_file;
>> >
>> >  /*
>> >   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain
>> > instances
>> 
>> --
>> Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Add header file for struct seq_file (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 22874 bytes --]

== Series Details ==

Series: drm/i915/display: Add header file for struct seq_file (rev2)
URL   : https://patchwork.freedesktop.org/series/119845/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13321_full -> Patchwork_119845v2_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (9 -> 9)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_119845v2_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a-dp-4:
    - {shard-dg2}:        NOTRUN -> [TIMEOUT][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-9/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-a-dp-4.html

  
New tests
---------

  New tests have been introduced between CI_DRM_13321_full and Patchwork_119845v2_full:

### New IGT tests (2) ###

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-c-dp-2:
    - Statuses : 1 skip(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_119845v2_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - shard-rkl:          [PASS][2] -> [FAIL][3] ([i915#7742]) +1 similar issue
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@gem_barrier_race@remote-request@rcs0:
    - shard-glk:          [PASS][4] -> [ABORT][5] ([i915#7461] / [i915#8211])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-glk1/igt@gem_barrier_race@remote-request@rcs0.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-glk8/igt@gem_barrier_race@remote-request@rcs0.html

  * igt@gem_exec_fair@basic-none-solo@rcs0:
    - shard-apl:          [PASS][6] -> [FAIL][7] ([i915#2842])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html

  * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
    - shard-rkl:          [PASS][8] -> [SKIP][9] ([i915#1937] / [i915#4579])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html

  * igt@i915_pm_rpm@dpms-non-lpsp:
    - shard-rkl:          [PASS][10] -> [SKIP][11] ([i915#1397]) +1 similar issue
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html

  * igt@kms_cursor_legacy@single-move@pipe-b:
    - shard-rkl:          [PASS][12] -> [INCOMPLETE][13] ([i915#8011]) +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-4/igt@kms_cursor_legacy@single-move@pipe-b.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_cursor_legacy@single-move@pipe-b.html

  * igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][14] ([i915#3804] / [i915#4579])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][15] ([fdo#109271]) +15 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-snb1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [FAIL][16] ([i915#8292])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-2/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][17] ([i915#5176]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2 (NEW):
    - {shard-dg2}:        NOTRUN -> [SKIP][18] ([i915#5176]) +1 similar issue
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-12/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][19] ([i915#4579] / [i915#5176]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][20] ([i915#5235]) +4 similar issues
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-a-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1:
    - shard-rkl:          NOTRUN -> [SKIP][21] ([i915#4579] / [i915#5235]) +4 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4579]) +8 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-1.html

  
#### Possible fixes ####

  * igt@gem_ctx_exec@basic-nohangcheck:
    - shard-tglu:         [FAIL][23] ([i915#6268]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html

  * igt@gem_exec_await@wide-contexts:
    - {shard-dg2}:        [FAIL][25] ([i915#5892]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-6/igt@gem_exec_await@wide-contexts.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-6/igt@gem_exec_await@wide-contexts.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-rkl:          [FAIL][27] ([i915#2842]) -> [PASS][28] +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-7/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_suspend@basic-s4-devices@lmem0:
    - {shard-dg2}:        [ABORT][29] ([i915#7975] / [i915#8213] / [i915#8682]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-1/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-11/igt@gem_exec_suspend@basic-s4-devices@lmem0.html

  * igt@gem_exec_whisper@basic-contexts-priority-all:
    - {shard-mtlp}:       [TIMEOUT][31] ([i915#7392]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-priority-all.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-mtlp-1/igt@gem_exec_whisper@basic-contexts-priority-all.html

  * igt@gem_exec_whisper@basic-normal:
    - {shard-mtlp}:       [FAIL][33] ([i915#6363]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-mtlp-3/igt@gem_exec_whisper@basic-normal.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-mtlp-4/igt@gem_exec_whisper@basic-normal.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - {shard-dg2}:        [TIMEOUT][35] ([i915#5493]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-10/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gem_mmap_offset@clear@smem0:
    - {shard-dg1}:        [DMESG-WARN][37] ([i915#8304]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg1-17/igt@gem_mmap_offset@clear@smem0.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg1-17/igt@gem_mmap_offset@clear@smem0.html

  * igt@i915_module_load@reload-with-fault-injection:
    - {shard-dg2}:        [DMESG-WARN][39] ([i915#7061]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-9/igt@i915_module_load@reload-with-fault-injection.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-3/igt@i915_module_load@reload-with-fault-injection.html
    - {shard-mtlp}:       [ABORT][41] ([i915#8489]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-mtlp-1/igt@i915_module_load@reload-with-fault-injection.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-mtlp-6/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
    - {shard-dg1}:        [SKIP][43] ([i915#1397]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg1-12/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html

  * igt@i915_pm_rpm@modeset-non-lpsp-stress:
    - shard-rkl:          [SKIP][45] ([i915#1397]) -> [PASS][46] +3 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-1/igt@i915_pm_rpm@modeset-non-lpsp-stress.html

  * igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1:
    - {shard-mtlp}:       [FAIL][47] ([i915#2521]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-mtlp-2/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-mtlp-3/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-edp-1.html

  * igt@kms_cdclk@mode-transition-all-outputs:
    - {shard-dg2}:        [SKIP][49] ([i915#4087]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-7/igt@kms_cdclk@mode-transition-all-outputs.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-9/igt@kms_cdclk@mode-transition-all-outputs.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-apl:          [FAIL][51] ([i915#2346]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-glk:          [FAIL][53] ([i915#2346]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-tglu:         [FAIL][55] ([i915#4767]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-tglu-10/igt@kms_fbcon_fbt@fbc-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-tglu-9/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
    - {shard-dg2}:        [FAIL][57] ([i915#6880]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-dg2-9/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html

  * igt@perf_pmu@busy-double-start@ccs0:
    - {shard-mtlp}:       [FAIL][59] ([i915#4349]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-mtlp-4/igt@perf_pmu@busy-double-start@ccs0.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-mtlp-5/igt@perf_pmu@busy-double-start@ccs0.html

  
#### Warnings ####

  * igt@kms_fbcon_fbt@psr:
    - shard-rkl:          [SKIP][61] ([i915#3955]) -> [SKIP][62] ([fdo#110189] / [i915#3955])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13321/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/shard-rkl-1/igt@kms_fbcon_fbt@psr.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
  [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
  [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#5793]: https://gitlab.freedesktop.org/drm/intel/issues/5793
  [i915#5882]: https://gitlab.freedesktop.org/drm/intel/issues/5882
  [i915#5889]: https://gitlab.freedesktop.org/drm/intel/issues/5889
  [i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
  [i915#6122]: https://gitlab.freedesktop.org/drm/intel/issues/6122
  [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
  [i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
  [i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
  [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
  [i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
  [i915#7069]: https://gitlab.freedesktop.org/drm/intel/issues/7069
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387
  [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7679]: https://gitlab.freedesktop.org/drm/intel/issues/7679
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7959]: https://gitlab.freedesktop.org/drm/intel/issues/7959
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
  [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
  [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
  [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428
  [i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
  [i915#8503]: https://gitlab.freedesktop.org/drm/intel/issues/8503
  [i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
  [i915#8682]: https://gitlab.freedesktop.org/drm/intel/issues/8682
  [i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691
  [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
  [i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709


Build changes
-------------

  * Linux: CI_DRM_13321 -> Patchwork_119845v2

  CI-20190529: 20190529
  CI_DRM_13321: 8bcc0ce6569a5889bd5a4b078b7c20e50d7be9d7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7348: feb4fdbcce1e53cb1d483aad3d5ec4ff41092359 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_119845v2: 8bcc0ce6569a5889bd5a4b078b7c20e50d7be9d7 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119845v2/index.html

[-- Attachment #2: Type: text/html, Size: 19587 bytes --]

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Borah, Chaitanya Kumar]

Hello Jani,

> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Monday, June 26, 2023 8:05 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>
> Subject: RE: [PATCH] drm/i915/display: Add forward declaration for struct
> seq_file
> 
> On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar"
> <chaitanya.kumar.borah@intel.com> wrote:
> > Hello Jani,
> >
> >> -----Original Message-----
> >> From: Jani Nikula <jani.nikula@linux.intel.com>
> >> Sent: Monday, June 26, 2023 5:37 PM
> >> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> >> gfx@lists.freedesktop.org
> >> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> >> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
> >> <chaitanya.kumar.borah@intel.com>
> >> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for
> >> struct seq_file
> >>
> >> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
> >> <chaitanya.kumar.borah@intel.com> wrote:
> >> > With change [1], visibility of struct seq_file is lost in
> >> > intel_display_power.h leading to build errors. Add forward
> >> > declaration.
> >> >
> >> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
> >> > declaration")
> >> >
> >> > v2: Use forward declaration instead of headerfile inclusion [Jani]
> >> >
> >> > Signed-off-by: Chaitanya Kumar Borah
> >> > <chaitanya.kumar.borah@intel.com>
> >>
> >> Hey, thanks for the patch, this would've been fine, but looks like
> >> Imre just pushed commit f4fab137dd2b ("drm/i915: Add missing forward
> >> declarations/includes to display power headers") which adds the
> >> forward declaration among other things.
> >>
> >> Sorry for the trouble.
> >>
> >
> > No problem, Thank you for the info.
> >
> > Sorry for my ignorance but will this patch eventually find its way to
> > linux-next or do we need to do something special here?
> 
> It'll show up in linux-next once -rc1 is out. But I'm not sure that's the
> *question* you want the answer to, really.
> 

If I understand correctly, the patch will get merged with linux-next
along with the release of 6.4-rc1.

The pertinent question is when will linux-next builds be fixed?
We are missing out on regression tracking because of the build failures.

Regards

Chaitanya

> BR,
> Jani.
> 
> 
> >
> > Regards
> >
> > Chaitanya
> >
> >> BR,
> >> Jani.
> >>
> >> > ---
> >> >  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
> >> >  1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
> >> > b/drivers/gpu/drm/i915/display/intel_display_power.h
> >> > index be1a87bde0c9..0ba268e566b0 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> >> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> >> > @@ -16,6 +16,7 @@ enum port;
> >> >  struct drm_i915_private;
> >> >  struct i915_power_well;
> >> >  struct intel_encoder;
> >> > +struct seq_file;
> >> >
> >> >  /*
> >> >   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain
> >> > instances
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
> 
> --
> Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Jani Nikula]

On Tue, 27 Jun 2023, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
> Hello Jani,
>
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@linux.intel.com>
>> Sent: Monday, June 26, 2023 8:05 PM
>> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
>> <arun.r.murthy@intel.com>
>> Subject: RE: [PATCH] drm/i915/display: Add forward declaration for struct
>> seq_file
>> 
>> On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar"
>> <chaitanya.kumar.borah@intel.com> wrote:
>> > Hello Jani,
>> >
>> >> -----Original Message-----
>> >> From: Jani Nikula <jani.nikula@linux.intel.com>
>> >> Sent: Monday, June 26, 2023 5:37 PM
>> >> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
>> >> gfx@lists.freedesktop.org
>> >> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
>> >> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
>> >> <chaitanya.kumar.borah@intel.com>
>> >> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for
>> >> struct seq_file
>> >>
>> >> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
>> >> <chaitanya.kumar.borah@intel.com> wrote:
>> >> > With change [1], visibility of struct seq_file is lost in
>> >> > intel_display_power.h leading to build errors. Add forward
>> >> > declaration.
>> >> >
>> >> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
>> >> > declaration")
>> >> >
>> >> > v2: Use forward declaration instead of headerfile inclusion [Jani]
>> >> >
>> >> > Signed-off-by: Chaitanya Kumar Borah
>> >> > <chaitanya.kumar.borah@intel.com>
>> >>
>> >> Hey, thanks for the patch, this would've been fine, but looks like
>> >> Imre just pushed commit f4fab137dd2b ("drm/i915: Add missing forward
>> >> declarations/includes to display power headers") which adds the
>> >> forward declaration among other things.
>> >>
>> >> Sorry for the trouble.
>> >>
>> >
>> > No problem, Thank you for the info.
>> >
>> > Sorry for my ignorance but will this patch eventually find its way to
>> > linux-next or do we need to do something special here?
>> 
>> It'll show up in linux-next once -rc1 is out. But I'm not sure that's the
>> *question* you want the answer to, really.
>> 
>
> If I understand correctly, the patch will get merged with linux-next
> along with the release of 6.4-rc1.
>
> The pertinent question is when will linux-next builds be fixed?
> We are missing out on regression tracking because of the build failures.

I've asked Tvrtko to pick this up to drm-intel-next-fixes, which should
show up in linux-next when it's next generated (it's daily).

BR,
Jani.

>
> Regards
>
> Chaitanya
>
>> BR,
>> Jani.
>> 
>> 
>> >
>> > Regards
>> >
>> > Chaitanya
>> >
>> >> BR,
>> >> Jani.
>> >>
>> >> > ---
>> >> >  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
>> >> >  1 file changed, 1 insertion(+)
>> >> >
>> >> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
>> >> > b/drivers/gpu/drm/i915/display/intel_display_power.h
>> >> > index be1a87bde0c9..0ba268e566b0 100644
>> >> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
>> >> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
>> >> > @@ -16,6 +16,7 @@ enum port;
>> >> >  struct drm_i915_private;
>> >> >  struct i915_power_well;
>> >> >  struct intel_encoder;
>> >> > +struct seq_file;
>> >> >
>> >> >  /*
>> >> >   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX) domain
>> >> > instances
>> >>
>> >> --
>> >> Jani Nikula, Intel Open Source Graphics Center
>> 
>> --
>> Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH] drm/i915/display: Add forward declaration for struct seq_file

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, June 27, 2023 3:17 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> <arun.r.murthy@intel.com>
> Subject: RE: [PATCH] drm/i915/display: Add forward declaration for struct
> seq_file
> 
> On Tue, 27 Jun 2023, "Borah, Chaitanya Kumar"
> <chaitanya.kumar.borah@intel.com> wrote:
> > Hello Jani,
> >
> >> -----Original Message-----
> >> From: Jani Nikula <jani.nikula@linux.intel.com>
> >> Sent: Monday, June 26, 2023 8:05 PM
> >> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; intel-
> >> gfx@lists.freedesktop.org
> >> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> >> <arun.r.murthy@intel.com>
> >> Subject: RE: [PATCH] drm/i915/display: Add forward declaration for
> >> struct seq_file
> >>
> >> On Mon, 26 Jun 2023, "Borah, Chaitanya Kumar"
> >> <chaitanya.kumar.borah@intel.com> wrote:
> >> > Hello Jani,
> >> >
> >> >> -----Original Message-----
> >> >> From: Jani Nikula <jani.nikula@linux.intel.com>
> >> >> Sent: Monday, June 26, 2023 5:37 PM
> >> >> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>;
> >> >> intel- gfx@lists.freedesktop.org
> >> >> Cc: Shankar, Uma <uma.shankar@intel.com>; Murthy, Arun R
> >> >> <arun.r.murthy@intel.com>; Borah, Chaitanya Kumar
> >> >> <chaitanya.kumar.borah@intel.com>
> >> >> Subject: Re: [PATCH] drm/i915/display: Add forward declaration for
> >> >> struct seq_file
> >> >>
> >> >> On Mon, 26 Jun 2023, Chaitanya Kumar Borah
> >> >> <chaitanya.kumar.borah@intel.com> wrote:
> >> >> > With change [1], visibility of struct seq_file is lost in
> >> >> > intel_display_power.h leading to build errors. Add forward
> >> >> > declaration.
> >> >> >
> >> >> > [1] ef104443bffa ("procfs: consolidate arch_report_meminfo
> >> >> > declaration")
> >> >> >
> >> >> > v2: Use forward declaration instead of headerfile inclusion
> >> >> > [Jani]
> >> >> >
> >> >> > Signed-off-by: Chaitanya Kumar Borah
> >> >> > <chaitanya.kumar.borah@intel.com>
> >> >>
> >> >> Hey, thanks for the patch, this would've been fine, but looks like
> >> >> Imre just pushed commit f4fab137dd2b ("drm/i915: Add missing
> >> >> forward declarations/includes to display power headers") which
> >> >> adds the forward declaration among other things.
> >> >>
> >> >> Sorry for the trouble.
> >> >>
> >> >
> >> > No problem, Thank you for the info.
> >> >
> >> > Sorry for my ignorance but will this patch eventually find its way
> >> > to linux-next or do we need to do something special here?
> >>
> >> It'll show up in linux-next once -rc1 is out. But I'm not sure that's
> >> the
> >> *question* you want the answer to, really.
> >>
> >
> > If I understand correctly, the patch will get merged with linux-next
> > along with the release of 6.4-rc1.
> >
> > The pertinent question is when will linux-next builds be fixed?
> > We are missing out on regression tracking because of the build failures.
> 
> I've asked Tvrtko to pick this up to drm-intel-next-fixes, which should show up
> in linux-next when it's next generated (it's daily).
> 

Thanks a lot, Jani!

Best Regards

Chaitanya

> BR,
> Jani.
> 
> >
> > Regards
> >
> > Chaitanya
> >
> >> BR,
> >> Jani.
> >>
> >>
> >> >
> >> > Regards
> >> >
> >> > Chaitanya
> >> >
> >> >> BR,
> >> >> Jani.
> >> >>
> >> >> > ---
> >> >> >  drivers/gpu/drm/i915/display/intel_display_power.h | 1 +
> >> >> >  1 file changed, 1 insertion(+)
> >> >> >
> >> >> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h
> >> >> > b/drivers/gpu/drm/i915/display/intel_display_power.h
> >> >> > index be1a87bde0c9..0ba268e566b0 100644
> >> >> > --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> >> >> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> >> >> > @@ -16,6 +16,7 @@ enum port;
> >> >> >  struct drm_i915_private;
> >> >> >  struct i915_power_well;
> >> >> >  struct intel_encoder;
> >> >> > +struct seq_file;
> >> >> >
> >> >> >  /*
> >> >> >   * Keep the pipe, transcoder, port (DDI_LANES,DDI_IO,AUX)
> >> >> > domain instances
> >> >>
> >> >> --
> >> >> Jani Nikula, Intel Open Source Graphics Center
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
> 
> --
> Jani Nikula, Intel Open Source Graphics Center