* [PATCH] wcn36xx: remove space before ')'
[not found] <tencent_5D948ECE7946A4A04536C5EAD0B120565B07@qq.com>
@ 2023-07-17 7:04 ` hanyu001
2023-07-17 15:28 ` Jeff Johnson
2023-07-21 11:05 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: hanyu001 @ 2023-07-17 7:04 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, wcn36xx, linux-kernel
Fixes checkpatch.pl error:
./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited
before that close parenthesis ')'
./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited
before that close parenthesis ')'
Signed-off-by: maqimei <2433033762@qq.com>
---
drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c
b/drivers/net/wireless/ath/wcn36xx/dxe.c
index 9013f05..b8d7676 100644
--- a/drivers/net/wireless/ath/wcn36xx/dxe.c
+++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
@@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq,
void *dev)
WCN36XX_DXE_0_INT_CLR,
WCN36XX_INT_MASK_CHAN_TX_H);
- if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+ if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
wcn36xx_dxe_write_register(wcn,
WCN36XX_DXE_0_INT_ERR_CLR,
WCN36XX_INT_MASK_CHAN_TX_H);
@@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq,
void *dev)
WCN36XX_DXE_0_INT_CLR,
WCN36XX_INT_MASK_CHAN_TX_L);
- if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
+ if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
wcn36xx_dxe_write_register(wcn,
WCN36XX_DXE_0_INT_ERR_CLR,
WCN36XX_INT_MASK_CHAN_TX_L);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wcn36xx: remove space before ')'
2023-07-17 7:04 ` [PATCH] wcn36xx: remove space before ')' hanyu001
@ 2023-07-17 15:28 ` Jeff Johnson
2023-07-21 11:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2023-07-17 15:28 UTC (permalink / raw)
To: hanyu001, kvalo; +Cc: linux-wireless, wcn36xx, linux-kernel
On 7/17/2023 12:04 AM, hanyu001@208suo.com wrote:
> Fixes checkpatch.pl error:
>
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited
> before that close parenthesis ')'
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited
> before that close parenthesis ')'
>
> Signed-off-by: maqimei <2433033762@qq.com>
For all of your recent patches you have the issue that your
Signed-off-by does not seem to be a legal name, and that it does not
match the From address in your e-mail.
Refer to
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin>
Also all wifi drivers should have a subject prefix of "wifi:
<drivername>:", in this case "wifi: wcn36xx: "
The actual patch LGTM
> ---
> drivers/net/wireless/ath/wcn36xx/dxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c
> b/drivers/net/wireless/ath/wcn36xx/dxe.c
> index 9013f05..b8d7676 100644
> --- a/drivers/net/wireless/ath/wcn36xx/dxe.c
> +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
> @@ -467,7 +467,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq,
> void *dev)
> WCN36XX_DXE_0_INT_CLR,
> WCN36XX_INT_MASK_CHAN_TX_H);
>
> - if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
> + if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
> wcn36xx_dxe_write_register(wcn,
> WCN36XX_DXE_0_INT_ERR_CLR,
> WCN36XX_INT_MASK_CHAN_TX_H);
> @@ -506,7 +506,7 @@ static irqreturn_t wcn36xx_irq_tx_complete(int irq,
> void *dev)
> WCN36XX_DXE_0_INT_CLR,
> WCN36XX_INT_MASK_CHAN_TX_L);
>
> - if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK ) {
> + if (int_reason & WCN36XX_CH_STAT_INT_ERR_MASK) {
> wcn36xx_dxe_write_register(wcn,
> WCN36XX_DXE_0_INT_ERR_CLR,
> WCN36XX_INT_MASK_CHAN_TX_L);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wcn36xx: remove space before ')'
2023-07-17 7:04 ` [PATCH] wcn36xx: remove space before ')' hanyu001
2023-07-17 15:28 ` Jeff Johnson
@ 2023-07-21 11:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-07-21 11:05 UTC (permalink / raw)
To: hanyu001; +Cc: linux-wireless, wcn36xx, linux-kernel
hanyu001@208suo.com wrote:
> Fixes checkpatch.pl error:
>
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:470: ERROR: space prohibited
> before that close parenthesis ')'
> ./drivers/net/wireless/ath/wcn36xx/dxe.c:509: ERROR: space prohibited
> before that close parenthesis ')'
>
> Signed-off-by: maqimei <2433033762@qq.com>
ERROR: Missing Signed-off-by: hanyu001@208suo.com
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/f2d9a75e98698b245e5126eb425944a1@208suo.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-21 11:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_5D948ECE7946A4A04536C5EAD0B120565B07@qq.com>
2023-07-17 7:04 ` [PATCH] wcn36xx: remove space before ')' hanyu001
2023-07-17 15:28 ` Jeff Johnson
2023-07-21 11:05 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.