[GIT PULL for v6.6] super fixes

[GIT PULL for v6.6] super fixes

[Christian Brauner]

Hey Linus,

/* Summary */
This contains two follow-up fixes for the super work this cycle:

* Move a misplaced lockep assertion before we potentially free the
  object containing the lock.

* Ensure that filesystems which match superblocks in sget{_fc}() based
  on sb->s_fs_info are guaranteed to see a valid sb->s_fs_info as long
  as a superblock still appears on the filesystem type's superblock
  list.

  What we want as a proper solution for next cycle is to split
  sb->free_sb() out of sb->kill_sb() so that we can simply call
  kill_super_notify() after sb->kill_sb() but before sb->free_sb().
  Currently, this is lumped together in sb->kill_sb().

/* Testing */
clang: Ubuntu clang version 15.0.7
gcc: (Ubuntu 12.2.0-3ubuntu1) 12.2.0

All patches are based on v6.6-vfs.super and have been sitting in
linux-next. No build failures or warnings were observed. All old and new
tests in selftests, and LTP pass without regressions.

/* Conflicts */
At the time of creating this PR no merge conflicts were reported from
linux-next and no merge conflicts showed up doing a test-merge with
current mainline.

The following changes since commit cd4284cfd3e11c7a49e4808f76f53284d47d04dd:

  Merge tag 'vfs-6.6-merge-3' of ssh://gitolite.kernel.org/pub/scm/fs/xfs/xfs-linux (2023-08-23 13:09:22 +0200)

are available in the Git repository at:

  git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.6-vfs.super.fixes

for you to fetch changes up to dc3216b1416056b04712e53431f6e9aefdc83177:

  super: ensure valid info (2023-08-29 10:13:04 +0200)

Please consider pulling these changes from the signed v6.6-vfs.super.fixes tag.

Thanks!
Christian

----------------------------------------------------------------
v6.6-vfs.super.fixes

----------------------------------------------------------------
Christian Brauner (2):
      super: move lockdep assert
      super: ensure valid info

 fs/super.c | 51 +++++++++++++++++++++++++++++++--------------------
 1 file changed, 31 insertions(+), 20 deletions(-)

Re: [GIT PULL for v6.6] super fixes

[pr-tracker-bot]

The pull request you sent on Tue, 29 Aug 2023 12:51:21 +0200:

> git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.6-vfs.super.fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/468e28d4ac72869ed6c7cd7c7632008597949bd3

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL for v6.6] super fixes

[Christian Brauner]

Thanks to both of you for helping with reviewing and fixing the
immediate remaining issues. Much appreciated.

Re: [GIT PULL for v6.6] super fixes

[pr-tracker-bot]

The pull request you sent on Thu, 31 Aug 2023 13:04:04 +0200:

> git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.6-vfs.super.fixes.2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e7e9423db459423d3dcb367217553ad9ededadc9

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[GIT PULL for v6.6] super fixes

[Christian Brauner]

Hey Linus,

/* Summary */
This contains two more small follow-up fixes for the super work this
cycle. I went through all filesystems once more and detected two minor
issues that still needed fixing:

* Some filesystems support mtd devices (e.g., mount -t jffs2 mtd2 /mnt).
  The mtd infrastructure uses the sb->s_mtd pointer to find an existing
  superblock. When the mtd device is put and sb->s_mtd cleared the
  superblock can still be found fs_supers and so this risks a
  use-after-free.

  Add a small patch that aligns mtd with what we did for regular block
  devices and switch keying to rely on sb->s_dev.

  (This was tested with mtd devices and jffs2 as xfstests doesn't
   support mtd devices.)

* Switch nfs back to rely on kill_anon_super() so the superblock is
  removed from the list of active supers before sb->s_fs_info is freed.

/* Testing */
clang: Ubuntu clang version 15.0.7
gcc: (Ubuntu 12.2.0-3ubuntu1) 12.2.0

All patches are based on v6.6-vfs.super and have been sitting in
linux-next. No build failures or warnings were observed. All old and new
tests in selftests, and LTP pass without regressions.

/* Conflicts */
At the time of creating this PR no merge conflicts were reported from
linux-next and no merge conflicts showed up doing a test-merge with
current mainline.

The following changes since commit b97d64c722598ffed42ece814a2cb791336c6679:

  Merge tag '6.6-rc-smb3-client-fixes-part1' of git://git.samba.org/sfrench/cifs-2.6 (2023-08-30 21:01:40 -0700)

are available in the Git repository at:

  git@gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs tags/v6.6-vfs.super.fixes.2

for you to fetch changes up to 5069ba84b5e67873a2dfa4bf73a24506950fa1bf:

  NFS: switch back to using kill_anon_super (2023-08-31 12:47:16 +0200)

Please consider pulling these changes from the signed v6.6-vfs.super.fixes.2 tag.

Thanks!
Christian

----------------------------------------------------------------
v6.6-vfs.super.fixes.2

----------------------------------------------------------------
Christian Brauner (2):
      fs: export sget_dev()
      mtd: key superblock by device number

Christoph Hellwig (1):
      NFS: switch back to using kill_anon_super

 drivers/mtd/mtdsuper.c | 45 +++++++++--------------------------
 fs/nfs/super.c         |  4 +---
 fs/super.c             | 64 +++++++++++++++++++++++++++++++++++---------------
 include/linux/fs.h     |  1 +
 4 files changed, 58 insertions(+), 56 deletions(-)