* [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
@ 2023-07-02 13:31 Tom Rix
2023-07-03 7:24 ` Keguang Zhang
2023-08-31 1:31 ` [tip: timers/core] clocksource/drivers/loongson1: Set " tip-bot2 for Tom Rix
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-07-02 13:31 UTC (permalink / raw)
To: keguang.zhang, daniel.lezcano, tglx; +Cc: linux-mips, linux-kernel, Tom Rix
smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/clocksource/timer-loongson1-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee03017..244d66835508 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
#define CNTR_WIDTH 24
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
struct ls1x_clocksource {
void __iomem *reg_base;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
2023-07-02 13:31 [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static Tom Rix
@ 2023-07-03 7:24 ` Keguang Zhang
2023-08-31 1:31 ` [tip: timers/core] clocksource/drivers/loongson1: Set " tip-bot2 for Tom Rix
1 sibling, 0 replies; 3+ messages in thread
From: Keguang Zhang @ 2023-07-03 7:24 UTC (permalink / raw)
To: Tom Rix; +Cc: daniel.lezcano, tglx, linux-mips, linux-kernel
> smatch reports
> drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
> 'ls1x_timer_lock' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> drivers/clocksource/timer-loongson1-pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
> index 6335fee03017..244d66835508 100644
> --- a/drivers/clocksource/timer-loongson1-pwm.c
> +++ b/drivers/clocksource/timer-loongson1-pwm.c
> @@ -28,7 +28,7 @@
>
> #define CNTR_WIDTH 24
>
> -DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
> +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
>
> struct ls1x_clocksource {
> void __iomem *reg_base;
> --
> 2.27.0
>
--
Best regards,
Keguang Zhang
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: timers/core] clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static
2023-07-02 13:31 [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static Tom Rix
2023-07-03 7:24 ` Keguang Zhang
@ 2023-08-31 1:31 ` tip-bot2 for Tom Rix
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Tom Rix @ 2023-08-31 1:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: Tom Rix, Keguang Zhang, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Gitweb: https://git.kernel.org/tip/bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Author: Tom Rix <trix@redhat.com>
AuthorDate: Sun, 02 Jul 2023 09:31:13 -04:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Fri, 18 Aug 2023 12:13:03 +02:00
clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static
smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230702133113.3438049-1-trix@redhat.com
---
drivers/clocksource/timer-loongson1-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee..244d668 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
#define CNTR_WIDTH 24
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
struct ls1x_clocksource {
void __iomem *reg_base;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-31 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-02 13:31 [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static Tom Rix
2023-07-03 7:24 ` Keguang Zhang
2023-08-31 1:31 ` [tip: timers/core] clocksource/drivers/loongson1: Set " tip-bot2 for Tom Rix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.