[PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[Sascha Hauer]

The MAC address is stored at offset 0x107 in the EEPROM, like correctly
stated in the comment. Add a two bytes reserved field right before the
MAC address to shift it from offset 0x105 to 0x107.

With this the MAC address returned from my RTL8723du wifi stick can be
correctly decoded as "Shenzhen Four Seas Global Link Network Technology
Co., Ltd."

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reported-by: Yanik Fuchs <Yanik.fuchs@mbv.ch>
Cc: stable@vger.kernel.org
---
 drivers/net/wireless/realtek/rtw88/rtw8723d.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.h b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
index 3642a2c7f80c9..2434e2480cbe2 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723d.h
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
@@ -46,6 +46,7 @@ struct rtw8723du_efuse {
 	u8 vender_id[2];                /* 0x100 */
 	u8 product_id[2];               /* 0x102 */
 	u8 usb_option;                  /* 0x104 */
+	u8 res5[2];			/* 0x105 */
 	u8 mac_addr[ETH_ALEN];          /* 0x107 */
 };
 
-- 
2.39.2

RE: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[Ping-Ke Shih]

> -----Original Message-----
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Thursday, September 7, 2023 3:16 PM
> To: linux-wireless@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih <pkshih@realtek.com>; Yanik
> Fuchs <Yanik.fuchs@mbv.ch>
> Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
> 
> The MAC address is stored at offset 0x107 in the EEPROM, like correctly
> stated in the comment. Add a two bytes reserved field right before the
> MAC address to shift it from offset 0x105 to 0x107.
> 
> With this the MAC address returned from my RTL8723du wifi stick can be
> correctly decoded as "Shenzhen Four Seas Global Link Network Technology
> Co., Ltd."

With this correctness, my stick can be recognized as: 
" Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter"

Should it add a Fixes tag? 
Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")

> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reported-by: Yanik Fuchs <Yanik.fuchs@mbv.ch>
> Cc: stable@vger.kernel.org

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

By the way, this patch should be 'v2' that seems to add more people in
To or Cc fields.

> ---
>  drivers/net/wireless/realtek/rtw88/rtw8723d.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.h
> b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
> index 3642a2c7f80c9..2434e2480cbe2 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8723d.h
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
> @@ -46,6 +46,7 @@ struct rtw8723du_efuse {
>         u8 vender_id[2];                /* 0x100 */
>         u8 product_id[2];               /* 0x102 */
>         u8 usb_option;                  /* 0x104 */
> +       u8 res5[2];                     /* 0x105 */
>         u8 mac_addr[ETH_ALEN];          /* 0x107 */
>  };
> 
> --
> 2.39.2

Re: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[Sascha Hauer]

On Fri, Sep 08, 2023 at 12:23:13AM +0000, Ping-Ke Shih wrote:
> 
> 
> > -----Original Message-----
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> > Sent: Thursday, September 7, 2023 3:16 PM
> > To: linux-wireless@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih <pkshih@realtek.com>; Yanik
> > Fuchs <Yanik.fuchs@mbv.ch>
> > Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM
> > 
> > The MAC address is stored at offset 0x107 in the EEPROM, like correctly
> > stated in the comment. Add a two bytes reserved field right before the
> > MAC address to shift it from offset 0x105 to 0x107.
> > 
> > With this the MAC address returned from my RTL8723du wifi stick can be
> > correctly decoded as "Shenzhen Four Seas Global Link Network Technology
> > Co., Ltd."
> 
> With this correctness, my stick can be recognized as: 
> " Bus 003 Device 010: ID 0bda:d723 Realtek Semiconductor Corp. 802.11n WLAN Adapter"

It should be recognized like this also without this patch, but with this
patch the MAC address should be read correctly.

> 
> Should it add a Fixes tag? 
> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")

Yes, I forgot this. Kalle, can you add it once again while applying?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[Kalle Valo]

Sascha Hauer <s.hauer@pengutronix.de> writes:

>> Should it add a Fixes tag? 
>> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")
>
> Yes, I forgot this. Kalle, can you add it once again while applying?

Yes, I'll add it. I guess it would be good to apply this to wireless
tree?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

[Kalle Valo]

Sascha Hauer <s.hauer@pengutronix.de> wrote:

> The MAC address is stored at offset 0x107 in the EEPROM, like correctly
> stated in the comment. Add a two bytes reserved field right before the
> MAC address to shift it from offset 0x105 to 0x107.
> 
> With this the MAC address returned from my RTL8723du wifi stick can be
> correctly decoded as "Shenzhen Four Seas Global Link Network Technology
> Co., Ltd."
> 
> Fixes: 87caeef032fc ("wifi: rtw88: Add rtw8723du chipset support")
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reported-by: Yanik Fuchs <Yanik.fuchs@mbv.ch>
> Cc: stable@vger.kernel.org
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless.git, thanks.

2e1b3ae3e1f2 wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230907071614.2032404-1-s.hauer@pengutronix.de/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches