All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply
@ 2023-08-16  6:05 Krzysztof Kozlowski
  2023-08-16 22:29 ` Doug Anderson
  2023-09-20  2:14 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-16  6:05 UTC (permalink / raw)
  To: cros-qcom-dts-watchers, Andy Gross, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Bluetooth requires VDDIO supply and Doug Anderson suggested it is
vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:

  sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Use vreg_l18b_1p8 (Doug). Due to such change, don't add Rb tag.
---
 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
index afae7f46b050..c2cba9d7179b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
@@ -38,6 +38,10 @@ vreg_s1k_1p0: smps1 {
 	};
 };
 
+&bluetooth {
+	vddio-supply = <&vreg_l18b_1p8>;
+};
+
 ap_tp_i2c: &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply
  2023-08-16  6:05 [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply Krzysztof Kozlowski
@ 2023-08-16 22:29 ` Doug Anderson
  2023-09-20  2:14 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2023-08-16 22:29 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: cros-qcom-dts-watchers, Andy Gross, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

Hi,

On Tue, Aug 15, 2023 at 11:05 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bluetooth requires VDDIO supply and Doug Anderson suggested it is
> vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:
>
>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes in v2:
> 1. Use vreg_l18b_1p8 (Doug). Due to such change, don't add Rb tag.
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 4 ++++
>  1 file changed, 4 insertions(+)

Right. Previous discussion was at:

https://lore.kernel.org/r/CAD=FV=UMqrAU9cLy3Ew5o1MJyNDAAG2TY1mvMkY2-8kiw6qpjg@mail.gmail.com

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply
  2023-08-16  6:05 [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply Krzysztof Kozlowski
  2023-08-16 22:29 ` Doug Anderson
@ 2023-09-20  2:14 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-09-20  2:14 UTC (permalink / raw)
  To: cros-qcom-dts-watchers, Andy Gross, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel, Krzysztof Kozlowski


On Wed, 16 Aug 2023 08:05:02 +0200, Krzysztof Kozlowski wrote:
> Bluetooth requires VDDIO supply and Doug Anderson suggested it is
> vreg_l18b_1p8.  Add one to satisfy `dtbs_check`:
> 
>   sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply
      commit: b9a2ee03019609f580ac5cae8211371119025909

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-20  2:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16  6:05 [PATCH v2] arm64: dts: qcom: sc7280-crd: add Bluetooth VDDIO supply Krzysztof Kozlowski
2023-08-16 22:29 ` Doug Anderson
2023-09-20  2:14 ` Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.