* [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
@ 2023-09-22 17:51 Kees Cook
2023-09-23 16:33 ` Gustavo A. R. Silva
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kees Cook @ 2023-09-22 17:51 UTC (permalink / raw)
To: Benson Leung
Cc: Kees Cook, Tzung-Bi Shih, Dawei Li, Dmitry Torokhov,
Maximilian Luz, Uwe Kleine-König, Greg Kroah-Hartman,
Jiang Jian, chrome-platform, Nathan Chancellor, Nick Desaulniers,
Tom Rix, Hans de Goede, Lee Jones, linux-kernel, llvm,
linux-hardening
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct ec_event_queue.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Benson Leung <bleung@chromium.org>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Dawei Li <set_pte_at@outlook.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Maximilian Luz <luzmaximilian@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiang Jian <jiangjian@cdjrlc.com>
Cc: chrome-platform@lists.linux.dev
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/platform/chrome/wilco_ec/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
index a40f60bcefb6..f80a7c83cfba 100644
--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -95,7 +95,7 @@ struct ec_event_queue {
int capacity;
int head;
int tail;
- struct ec_event *entries[];
+ struct ec_event *entries[] __counted_by(capacity);
};
/* Maximum number of events to store in ec_event_queue */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
2023-09-22 17:51 [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by Kees Cook
@ 2023-09-23 16:33 ` Gustavo A. R. Silva
2023-09-25 2:30 ` patchwork-bot+chrome-platform
2023-09-25 10:16 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2023-09-23 16:33 UTC (permalink / raw)
To: Kees Cook, Benson Leung
Cc: Tzung-Bi Shih, Dawei Li, Dmitry Torokhov, Maximilian Luz,
Uwe Kleine-König, Greg Kroah-Hartman, Jiang Jian,
chrome-platform, Nathan Chancellor, Nick Desaulniers, Tom Rix,
Hans de Goede, Lee Jones, linux-kernel, llvm, linux-hardening
On 9/22/23 11:51, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct ec_event_queue.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Tzung-Bi Shih <tzungbi@kernel.org>
> Cc: Dawei Li <set_pte_at@outlook.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Maximilian Luz <luzmaximilian@gmail.com>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiang Jian <jiangjian@cdjrlc.com>
> Cc: chrome-platform@lists.linux.dev
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> drivers/platform/chrome/wilco_ec/event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
> index a40f60bcefb6..f80a7c83cfba 100644
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -95,7 +95,7 @@ struct ec_event_queue {
> int capacity;
> int head;
> int tail;
> - struct ec_event *entries[];
> + struct ec_event *entries[] __counted_by(capacity);
> };
>
> /* Maximum number of events to store in ec_event_queue */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
2023-09-22 17:51 [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by Kees Cook
2023-09-23 16:33 ` Gustavo A. R. Silva
@ 2023-09-25 2:30 ` patchwork-bot+chrome-platform
2023-09-25 10:16 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-25 2:30 UTC (permalink / raw)
To: Kees Cook
Cc: bleung, tzungbi, set_pte_at, dmitry.torokhov, luzmaximilian,
u.kleine-koenig, gregkh, jiangjian, chrome-platform, nathan,
ndesaulniers, trix, hdegoede, lee, linux-kernel, llvm,
linux-hardening
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Fri, 22 Sep 2023 10:51:47 -0700 you wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct ec_event_queue.
>
> [...]
Here is the summary with links:
- platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
https://git.kernel.org/chrome-platform/c/1aa8df90f456
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
2023-09-22 17:51 [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by Kees Cook
2023-09-23 16:33 ` Gustavo A. R. Silva
2023-09-25 2:30 ` patchwork-bot+chrome-platform
@ 2023-09-25 10:16 ` patchwork-bot+chrome-platform
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-25 10:16 UTC (permalink / raw)
To: Kees Cook
Cc: bleung, tzungbi, set_pte_at, dmitry.torokhov, luzmaximilian,
u.kleine-koenig, gregkh, jiangjian, chrome-platform, nathan,
ndesaulniers, trix, hdegoede, lee, linux-kernel, llvm,
linux-hardening
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Fri, 22 Sep 2023 10:51:47 -0700 you wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct ec_event_queue.
>
> [...]
Here is the summary with links:
- platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by
https://git.kernel.org/chrome-platform/c/1aa8df90f456
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-25 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-22 17:51 [PATCH] platform/chrome: wilco_ec: Annotate struct ec_event_queue with __counted_by Kees Cook
2023-09-23 16:33 ` Gustavo A. R. Silva
2023-09-25 2:30 ` patchwork-bot+chrome-platform
2023-09-25 10:16 ` patchwork-bot+chrome-platform
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.