* [PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable
@ 2023-09-22 9:34 ` Xin Ji
0 siblings, 0 replies; 4+ messages in thread
From: Xin Ji @ 2023-09-22 9:34 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: bliang, qwen, hsinyi, Xin Ji, dri-devel, linux-kernel
For the no-interrupt design (sink device is panel, polling HPD
status when chip power on), anx7625 FW has more than 200ms HPD
de-bounce time in FW, for the safety to get HPD status, driver
better to wait 200ms before HPD detection after OS resume back.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 51abe42c639e..8f740154707d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1464,6 +1464,9 @@ static int _anx7625_hpd_polling(struct anx7625_data *ctx,
if (ctx->pdata.intp_irq)
return 0;
+ /* Delay 200ms for FW HPD de-bounce */
+ msleep(200);
+
ret = readx_poll_timeout(anx7625_read_hpd_status_p0,
ctx, val,
((val & HPD_STATUS) || (val < 0)),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable
@ 2023-09-22 9:34 ` Xin Ji
0 siblings, 0 replies; 4+ messages in thread
From: Xin Ji @ 2023-09-22 9:34 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: qwen, linux-kernel, dri-devel, hsinyi, bliang, Xin Ji
For the no-interrupt design (sink device is panel, polling HPD
status when chip power on), anx7625 FW has more than 200ms HPD
de-bounce time in FW, for the safety to get HPD status, driver
better to wait 200ms before HPD detection after OS resume back.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 51abe42c639e..8f740154707d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1464,6 +1464,9 @@ static int _anx7625_hpd_polling(struct anx7625_data *ctx,
if (ctx->pdata.intp_irq)
return 0;
+ /* Delay 200ms for FW HPD de-bounce */
+ msleep(200);
+
ret = readx_poll_timeout(anx7625_read_hpd_status_p0,
ctx, val,
((val & HPD_STATUS) || (val < 0)),
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable
2023-09-22 9:34 ` Xin Ji
@ 2023-09-25 10:48 ` Robert Foss
-1 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2023-09-25 10:48 UTC (permalink / raw)
To: David Airlie, Xin Ji, Jernej Skrabec, Neil Armstrong,
Laurent Pinchart, Andrzej Hajda, Daniel Vetter, Jonas Karlman
Cc: hsinyi, bliang, qwen, dri-devel, linux-kernel
On Fri, 22 Sep 2023 17:34:49 +0800, Xin Ji wrote:
> For the no-interrupt design (sink device is panel, polling HPD
> status when chip power on), anx7625 FW has more than 200ms HPD
> de-bounce time in FW, for the safety to get HPD status, driver
> better to wait 200ms before HPD detection after OS resume back.
>
>
Applied, thanks!
[1/1] drm/bridge: Add 200ms delay to wait FW HPD status stable
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=330140d7319f
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable
@ 2023-09-25 10:48 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2023-09-25 10:48 UTC (permalink / raw)
To: David Airlie, Xin Ji, Jernej Skrabec, Neil Armstrong,
Laurent Pinchart, Andrzej Hajda, Daniel Vetter, Jonas Karlman
Cc: qwen, bliang, linux-kernel, dri-devel, hsinyi
On Fri, 22 Sep 2023 17:34:49 +0800, Xin Ji wrote:
> For the no-interrupt design (sink device is panel, polling HPD
> status when chip power on), anx7625 FW has more than 200ms HPD
> de-bounce time in FW, for the safety to get HPD status, driver
> better to wait 200ms before HPD detection after OS resume back.
>
>
Applied, thanks!
[1/1] drm/bridge: Add 200ms delay to wait FW HPD status stable
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=330140d7319f
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-25 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-22 9:34 [PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable Xin Ji
2023-09-22 9:34 ` Xin Ji
2023-09-25 10:48 ` Robert Foss
2023-09-25 10:48 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.