* [PATCH] net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF
@ 2023-10-19 18:23 Rob Herring
2023-10-23 17:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-10-19 18:23 UTC (permalink / raw)
To: Iyappan Subramanian, Keyur Chudgar, Quan Nguyen, Andrew Lunn,
Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: kernel test robot, netdev, linux-kernel
Commit a243ecc323b9 ("net: mdio: xgene: Use device_get_match_data()")
dropped the unconditional use of xgene_mdio_of_match resulting in this
warning:
drivers/net/mdio/mdio-xgene.c:303:34: warning: unused variable 'xgene_mdio_of_match' [-Wunused-const-variable]
The fix is to drop of_match_ptr() which is not necessary because DT is
always used for this driver (well, it could in theory support ACPI only,
but CONFIG_OF is always enabled for arm64).
Fixes: a243ecc323b9 ("net: mdio: xgene: Use device_get_match_data()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310170832.xnVXw1bb-lkp@intel.com/
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/net/mdio/mdio-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/mdio-xgene.c b/drivers/net/mdio/mdio-xgene.c
index 495fbe35b6ce..2772a3098543 100644
--- a/drivers/net/mdio/mdio-xgene.c
+++ b/drivers/net/mdio/mdio-xgene.c
@@ -437,7 +437,7 @@ static void xgene_mdio_remove(struct platform_device *pdev)
static struct platform_driver xgene_mdio_driver = {
.driver = {
.name = "xgene-mdio",
- .of_match_table = of_match_ptr(xgene_mdio_of_match),
+ .of_match_table = xgene_mdio_of_match,
.acpi_match_table = ACPI_PTR(xgene_mdio_acpi_match),
},
.probe = xgene_mdio_probe,
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF
2023-10-19 18:23 [PATCH] net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF Rob Herring
@ 2023-10-23 17:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-23 17:20 UTC (permalink / raw)
To: Rob Herring
Cc: iyappan, keyur, quan, andrew, hkallweit1, linux, davem, edumazet,
kuba, pabeni, lkp, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 19 Oct 2023 13:23:45 -0500 you wrote:
> Commit a243ecc323b9 ("net: mdio: xgene: Use device_get_match_data()")
> dropped the unconditional use of xgene_mdio_of_match resulting in this
> warning:
>
> drivers/net/mdio/mdio-xgene.c:303:34: warning: unused variable 'xgene_mdio_of_match' [-Wunused-const-variable]
>
> The fix is to drop of_match_ptr() which is not necessary because DT is
> always used for this driver (well, it could in theory support ACPI only,
> but CONFIG_OF is always enabled for arm64).
>
> [...]
Here is the summary with links:
- net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF
https://git.kernel.org/netdev/net-next/c/d6e48462e88f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-23 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-19 18:23 [PATCH] net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF Rob Herring
2023-10-23 17:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.