All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
@ 2018-12-23 10:10 ` Katsuhiro Suzuki
  0 siblings, 0 replies; 7+ messages in thread
From: Katsuhiro Suzuki @ 2018-12-23 10:10 UTC (permalink / raw)
  To: Heiko Stuebner, linux-rockchip
  Cc: linux-arm-kernel, linux-kernel, Katsuhiro Suzuki

The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1 and ACODEC core.

This patch adds sound node for analog audio for Rock64.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---

This patch depends on the following ACODEC node patch. If ACODEC
patch is not good to you, please drop this patch too.
  https://lkml.org/lkml/2018/12/23/53

 .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index bd937d68ca3b..0a71e1287a1b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -66,7 +66,8 @@
 	sound {
 		compatible = "audio-graph-card";
 		label = "rockchip,rk3328";
-		dais = <&spdif_p0>;
+		dais = <&i2s1_p0
+			&spdif_p0>;
 	};
 
 	spdif-dit {
@@ -81,6 +82,17 @@
 	};
 };
 
+&codec {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	port@0 {
+		codec_p0_0: endpoint {
+			remote-endpoint = <&i2s1_p0_0>;
+		};
+	};
+};
+
 &cpu0 {
 	cpu-supply = <&vdd_arm>;
 };
@@ -243,6 +255,19 @@
 	};
 };
 
+&i2s1 {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	i2s1_p0: port {
+		i2s1_p0_0: endpoint {
+			dai-format = "i2s";
+			mclk-fs = <256>;
+			remote-endpoint = <&codec_p0_0>;
+		};
+	};
+};
+
 &io_domains {
 	status = "okay";
 
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
@ 2018-12-23 10:10 ` Katsuhiro Suzuki
  0 siblings, 0 replies; 7+ messages in thread
From: Katsuhiro Suzuki @ 2018-12-23 10:10 UTC (permalink / raw)
  To: Heiko Stuebner, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Katsuhiro Suzuki, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1 and ACODEC core.

This patch adds sound node for analog audio for Rock64.

Signed-off-by: Katsuhiro Suzuki <katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org>
---

This patch depends on the following ACODEC node patch. If ACODEC
patch is not good to you, please drop this patch too.
  https://lkml.org/lkml/2018/12/23/53

 .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index bd937d68ca3b..0a71e1287a1b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -66,7 +66,8 @@
 	sound {
 		compatible = "audio-graph-card";
 		label = "rockchip,rk3328";
-		dais = <&spdif_p0>;
+		dais = <&i2s1_p0
+			&spdif_p0>;
 	};
 
 	spdif-dit {
@@ -81,6 +82,17 @@
 	};
 };
 
+&codec {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	port@0 {
+		codec_p0_0: endpoint {
+			remote-endpoint = <&i2s1_p0_0>;
+		};
+	};
+};
+
 &cpu0 {
 	cpu-supply = <&vdd_arm>;
 };
@@ -243,6 +255,19 @@
 	};
 };
 
+&i2s1 {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	i2s1_p0: port {
+		i2s1_p0_0: endpoint {
+			dai-format = "i2s";
+			mclk-fs = <256>;
+			remote-endpoint = <&codec_p0_0>;
+		};
+	};
+};
+
 &io_domains {
 	status = "okay";
 
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
@ 2018-12-23 10:10 ` Katsuhiro Suzuki
  0 siblings, 0 replies; 7+ messages in thread
From: Katsuhiro Suzuki @ 2018-12-23 10:10 UTC (permalink / raw)
  To: Heiko Stuebner, linux-rockchip
  Cc: Katsuhiro Suzuki, linux-kernel, linux-arm-kernel

The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1 and ACODEC core.

This patch adds sound node for analog audio for Rock64.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---

This patch depends on the following ACODEC node patch. If ACODEC
patch is not good to you, please drop this patch too.
  https://lkml.org/lkml/2018/12/23/53

 .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index bd937d68ca3b..0a71e1287a1b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -66,7 +66,8 @@
 	sound {
 		compatible = "audio-graph-card";
 		label = "rockchip,rk3328";
-		dais = <&spdif_p0>;
+		dais = <&i2s1_p0
+			&spdif_p0>;
 	};
 
 	spdif-dit {
@@ -81,6 +82,17 @@
 	};
 };
 
+&codec {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	port@0 {
+		codec_p0_0: endpoint {
+			remote-endpoint = <&i2s1_p0_0>;
+		};
+	};
+};
+
 &cpu0 {
 	cpu-supply = <&vdd_arm>;
 };
@@ -243,6 +255,19 @@
 	};
 };
 
+&i2s1 {
+	status = "okay";
+	#sound-dai-cells = <0>;
+
+	i2s1_p0: port {
+		i2s1_p0_0: endpoint {
+			dai-format = "i2s";
+			mclk-fs = <256>;
+			remote-endpoint = <&codec_p0_0>;
+		};
+	};
+};
+
 &io_domains {
 	status = "okay";
 
-- 
2.19.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
  2018-12-23 10:10 ` Katsuhiro Suzuki
@ 2018-12-24  7:16   ` Heiko Stuebner
  -1 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2018-12-24  7:16 UTC (permalink / raw)
  To: Katsuhiro Suzuki; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel

Hi,

Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
> The Rock64 boards has analog audio jack on it. RK3328 can output
> analog audio signal using I2S1 and ACODEC core.
> 
> This patch adds sound node for analog audio for Rock64.
> 
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>

I've put a patch collecting the sound-dai-cells in rk3328.dtsi
before this one, dropped the sound-dai-cells from here and
applied the patch for 4.22.

Thanks
Heiko



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
@ 2018-12-24  7:16   ` Heiko Stuebner
  0 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2018-12-24  7:16 UTC (permalink / raw)
  To: Katsuhiro Suzuki; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel

Hi,

Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
> The Rock64 boards has analog audio jack on it. RK3328 can output
> analog audio signal using I2S1 and ACODEC core.
> 
> This patch adds sound node for analog audio for Rock64.
> 
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>

I've put a patch collecting the sound-dai-cells in rk3328.dtsi
before this one, dropped the sound-dai-cells from here and
applied the patch for 4.22.

Thanks
Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
  2018-12-24  7:16   ` Heiko Stuebner
@ 2018-12-24 12:58     ` Katsuhiro Suzuki
  -1 siblings, 0 replies; 7+ messages in thread
From: Katsuhiro Suzuki @ 2018-12-24 12:58 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel

Hello Heiko,

I understand. Thanks a lot!

Best Regards,
Katsuhiro Suzuki

On 2018/12/24 16:16, Heiko Stuebner wrote:
> Hi,
> 
> Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
>> The Rock64 boards has analog audio jack on it. RK3328 can output
>> analog audio signal using I2S1 and ACODEC core.
>>
>> This patch adds sound node for analog audio for Rock64.
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> 
> I've put a patch collecting the sound-dai-cells in rk3328.dtsi
> before this one, dropped the sound-dai-cells from here and
> applied the patch for 4.22.
> 
> Thanks
> Heiko
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64
@ 2018-12-24 12:58     ` Katsuhiro Suzuki
  0 siblings, 0 replies; 7+ messages in thread
From: Katsuhiro Suzuki @ 2018-12-24 12:58 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel

Hello Heiko,

I understand. Thanks a lot!

Best Regards,
Katsuhiro Suzuki

On 2018/12/24 16:16, Heiko Stuebner wrote:
> Hi,
> 
> Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
>> The Rock64 boards has analog audio jack on it. RK3328 can output
>> analog audio signal using I2S1 and ACODEC core.
>>
>> This patch adds sound node for analog audio for Rock64.
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> 
> I've put a patch collecting the sound-dai-cells in rk3328.dtsi
> before this one, dropped the sound-dai-cells from here and
> applied the patch for 4.22.
> 
> Thanks
> Heiko
> 
> 
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-24 12:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-23 10:10 [PATCH] arm64: dts: rockchip: enable analog audio node for rock64 Katsuhiro Suzuki
2018-12-23 10:10 ` Katsuhiro Suzuki
2018-12-23 10:10 ` Katsuhiro Suzuki
2018-12-24  7:16 ` Heiko Stuebner
2018-12-24  7:16   ` Heiko Stuebner
2018-12-24 12:58   ` Katsuhiro Suzuki
2018-12-24 12:58     ` Katsuhiro Suzuki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.