From: David Hildenbrand <david@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
Michal Hocko <mhocko@suse.com>, Qian Cai <cai@lca.pw>,
Oscar Salvador <osalvador@suse.de>,
Eric Biederman <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
x86@kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources
Date: Tue, 23 Mar 2021 12:26:27 +0100 [thread overview]
Message-ID: <16bfac8e-cee1-c8ce-14f1-70e697e4f2f1@redhat.com> (raw)
In-Reply-To: <YFnMOK6VuIBsoKWr@smile.fi.intel.com>
On 23.03.21 12:08, Andy Shevchenko wrote:
> On Mon, Mar 22, 2021 at 05:01:59PM +0100, David Hildenbrand wrote:
>> It used to be true that we can have system RAM only on the first level
>> in the resourc tree. However, this is no longer holds for driver-managed
>> system RAM (i.e., dax/kmem and virtio-mem).
>>
>> The function walk_mem_res() only consideres the first level and is
>> used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently
>> fail to identify System RAM added by dax/kmem and virtio-mem as
>> "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such
>> "normal RAM" in __ioremap_caller().
>
> Here I dunno, but consider to add Fixes tag if it fixes known bad behaviour.
Haven't observed it in the wild. We can add the same fixes tags as to
patch #1.
--
Thanks,
David / dhildenb
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
Michal Hocko <mhocko@suse.com>, Qian Cai <cai@lca.pw>,
Oscar Salvador <osalvador@suse.de>,
Eric Biederman <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
x86@kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources
Date: Tue, 23 Mar 2021 12:26:27 +0100 [thread overview]
Message-ID: <16bfac8e-cee1-c8ce-14f1-70e697e4f2f1@redhat.com> (raw)
In-Reply-To: <YFnMOK6VuIBsoKWr@smile.fi.intel.com>
On 23.03.21 12:08, Andy Shevchenko wrote:
> On Mon, Mar 22, 2021 at 05:01:59PM +0100, David Hildenbrand wrote:
>> It used to be true that we can have system RAM only on the first level
>> in the resourc tree. However, this is no longer holds for driver-managed
>> system RAM (i.e., dax/kmem and virtio-mem).
>>
>> The function walk_mem_res() only consideres the first level and is
>> used in arch/x86/mm/ioremap.c:__ioremap_check_mem() only. We currently
>> fail to identify System RAM added by dax/kmem and virtio-mem as
>> "IORES_MAP_SYSTEM_RAM", for example, allowing for remapping of such
>> "normal RAM" in __ioremap_caller().
>
> Here I dunno, but consider to add Fixes tag if it fixes known bad behaviour.
Haven't observed it in the wild. We can add the same fixes tags as to
patch #1.
--
Thanks,
David / dhildenb
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-03-23 11:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 16:01 [PATCH v1 0/3] kernel/resource: make walk_system_ram_res() and walk_mem_res() search the whole tree David Hildenbrand
2021-03-22 16:01 ` [PATCH v1 1/3] kernel/resource: make walk_system_ram_res() find all busy IORESOURCE_SYSTEM_RAM resources David Hildenbrand
2021-03-22 16:01 ` David Hildenbrand
2021-03-22 16:10 ` Dan Williams
2021-03-22 16:10 ` Dan Williams
2021-03-22 16:10 ` Dan Williams
2021-03-23 9:40 ` David Hildenbrand
2021-03-23 9:40 ` David Hildenbrand
2021-03-23 11:07 ` Andy Shevchenko
2021-03-23 11:07 ` Andy Shevchenko
2021-03-23 11:06 ` Andy Shevchenko
2021-03-23 11:06 ` Andy Shevchenko
2021-03-23 11:25 ` David Hildenbrand
2021-03-23 11:25 ` David Hildenbrand
2021-03-23 14:33 ` Baoquan He
2021-03-23 14:33 ` Baoquan He
2021-03-24 11:18 ` Oscar Salvador
2021-03-24 11:18 ` Oscar Salvador
2021-03-24 11:28 ` David Hildenbrand
2021-03-24 11:28 ` David Hildenbrand
2021-03-22 16:01 ` [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources David Hildenbrand
2021-03-22 16:01 ` David Hildenbrand
2021-03-22 16:11 ` Dan Williams
2021-03-22 16:11 ` Dan Williams
2021-03-22 16:11 ` Dan Williams
2021-03-23 11:08 ` Andy Shevchenko
2021-03-23 11:08 ` Andy Shevchenko
2021-03-23 11:26 ` David Hildenbrand [this message]
2021-03-23 11:26 ` David Hildenbrand
2021-03-22 16:02 ` [PATCH v1 3/3] kernel/resource: remove first_lvl / siblings_only logic David Hildenbrand
2021-03-22 16:02 ` David Hildenbrand
2021-03-22 16:12 ` Dan Williams
2021-03-22 16:12 ` Dan Williams
2021-03-22 16:12 ` Dan Williams
2021-03-23 11:11 ` Andy Shevchenko
2021-03-23 11:11 ` Andy Shevchenko
2021-03-23 11:19 ` David Hildenbrand
2021-03-23 11:19 ` David Hildenbrand
2021-03-23 11:05 ` [PATCH v1 0/3] kernel/resource: make walk_system_ram_res() and walk_mem_res() search the whole tree Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16bfac8e-cee1-c8ce-14f1-70e697e4f2f1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=keith.busch@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mchehab+huawei@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.