From: Thomas Preston <thomas.preston@codethink.co.uk>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Marco Felsch <m.felsch@pengutronix.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kirill Marinushkin <kmarinushkin@birdec.tech>,
Cheng-Yi Chiang <cychiang@chromium.org>,
linux-kernel@vger.kernel.org, Nate Case <ncase@tesla.com>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Annaliese McDermond <nh6z@nh6z.net>,
Rob Duncan <rduncan@tesla.com>,
Patrick Glaser <pglaser@tesla.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [alsa-devel] [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier
Date: Tue, 30 Jul 2019 15:10:00 +0100 [thread overview]
Message-ID: <16dff5b4-6a94-42de-85d4-0f4ec01fac8c@codethink.co.uk> (raw)
In-Reply-To: <20190730122748.GF54126@ediswmail.ad.cirrus.com>
On 30/07/2019 13:27, Charles Keepax wrote:
> On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote:
>> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk>
>> Cc: Patrick Glaser <pglaser@tesla.com>
>> Cc: Rob Duncan <rduncan@tesla.com>
>> Cc: Nate Case <ncase@tesla.com>
>> ---
>> .../devicetree/bindings/sound/tda7802.txt | 26 +++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/tda7802.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/tda7802.txt b/Documentation/devicetree/bindings/sound/tda7802.txt
>> new file mode 100644
>> index 000000000000..f80aaf4f1ba0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/tda7802.txt
>> @@ -0,0 +1,26 @@
>> +ST TDA7802 audio processor
>> +
>> +This device supports I2C only.
>> +
>> +Required properties:
>> +
>> +- compatible : "st,tda7802"
>> +- reg : the I2C address of the device
>> +- enable-supply : a regulator spec for the PLLen pin
>> +
>> +Optional properties:
>> +
>> +- st,gain-ch13 : gain for channels 1 and 3 (range: 1-4)
>> +- st,gain-ch24 : gain for channels 2 and 3 (range: 1-4)
>
> I wouldn't have expected the gains to be available as a device
> tree setting.
>
Ah, I forgot to update the docs from v1. Thanks
next prev parent reply other threads:[~2019-07-30 14:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:09 [PATCH v2 0/3] ASoC: Codecs: Add TDA7802 codec Thomas Preston
2019-07-30 12:09 ` Thomas Preston
2019-07-30 12:09 ` [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier Thomas Preston
2019-07-30 12:09 ` Thomas Preston
2019-07-30 12:27 ` Charles Keepax
2019-07-30 12:27 ` Charles Keepax
2019-07-30 13:12 ` Marco Felsch
2019-07-30 13:12 ` Marco Felsch
2019-07-30 14:12 ` [alsa-devel] " Thomas Preston
2019-07-30 14:33 ` Mark Brown
2019-07-30 14:10 ` Thomas Preston [this message]
2019-07-30 12:09 ` [PATCH v2 2/3] ASoC: Add codec driver for ST TDA7802 Thomas Preston
2019-07-30 12:09 ` Thomas Preston
2019-07-30 12:38 ` Charles Keepax
2019-07-30 12:38 ` Charles Keepax
2019-07-30 15:49 ` [alsa-devel] " Thomas Preston
2019-07-30 14:58 ` Mark Brown
2019-07-30 14:58 ` Mark Brown
2019-07-30 17:26 ` [alsa-devel] " Thomas Preston
2019-07-31 6:06 ` Marco Felsch
2019-07-31 8:57 ` Thomas Preston
2019-07-30 12:09 ` [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine Thomas Preston
2019-07-30 12:09 ` Thomas Preston
2019-07-30 12:41 ` Charles Keepax
2019-07-30 12:41 ` Charles Keepax
2019-07-30 14:04 ` [alsa-devel] " Thomas Preston
2019-07-30 14:18 ` Charles Keepax
2019-07-30 14:18 ` Charles Keepax
2019-07-30 14:20 ` [alsa-devel] " Mark Brown
2019-07-30 15:27 ` Thomas Preston
2019-07-30 14:19 ` Mark Brown
2019-07-30 14:19 ` Mark Brown
2019-07-30 15:25 ` [alsa-devel] " Thomas Preston
2019-07-30 15:50 ` Mark Brown
2019-07-30 16:28 ` Thomas Preston
2019-07-31 8:03 ` Charles Keepax
2019-07-31 8:03 ` Charles Keepax
2019-08-01 23:42 ` Mark Brown
2019-08-02 8:32 ` Thomas Preston
2019-08-02 11:10 ` Mark Brown
2019-08-02 14:51 ` Thomas Preston
2019-08-02 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16dff5b4-6a94-42de-85d4-0f4ec01fac8c@codethink.co.uk \
--to=thomas.preston@codethink.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kmarinushkin@birdec.tech \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=ncase@tesla.com \
--cc=nh6z@nh6z.net \
--cc=paul@crapouillou.net \
--cc=pglaser@tesla.com \
--cc=rduncan@tesla.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.