* [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe
@ 2023-11-20 9:10 ` Su Hui
0 siblings, 0 replies; 4+ messages in thread
From: Su Hui @ 2023-11-20 9:10 UTC (permalink / raw)
To: vincent.sunplus, vkoul, kishon
Cc: Su Hui, linux-usb, linux-phy, linux-kernel, kernel-janitors
devm_phy_create() return negative error code, 'ret' should be
'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.
Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/phy/sunplus/phy-sunplus-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c
index 0efe74ac9c6a..637a5fbae6d9 100644
--- a/drivers/phy/sunplus/phy-sunplus-usb2.c
+++ b/drivers/phy/sunplus/phy-sunplus-usb2.c
@@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev)
phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops);
if (IS_ERR(phy)) {
- ret = -PTR_ERR(phy);
+ ret = PTR_ERR(phy);
return ret;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe
@ 2023-11-20 9:10 ` Su Hui
0 siblings, 0 replies; 4+ messages in thread
From: Su Hui @ 2023-11-20 9:10 UTC (permalink / raw)
To: vincent.sunplus, vkoul, kishon
Cc: Su Hui, linux-usb, linux-phy, linux-kernel, kernel-janitors
devm_phy_create() return negative error code, 'ret' should be
'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.
Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/phy/sunplus/phy-sunplus-usb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c
index 0efe74ac9c6a..637a5fbae6d9 100644
--- a/drivers/phy/sunplus/phy-sunplus-usb2.c
+++ b/drivers/phy/sunplus/phy-sunplus-usb2.c
@@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev)
phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops);
if (IS_ERR(phy)) {
- ret = -PTR_ERR(phy);
+ ret = PTR_ERR(phy);
return ret;
}
--
2.30.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe
2023-11-20 9:10 ` Su Hui
@ 2023-11-27 13:22 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-11-27 13:22 UTC (permalink / raw)
To: vincent.sunplus, kishon, Su Hui
Cc: linux-usb, linux-phy, linux-kernel, kernel-janitors
On Mon, 20 Nov 2023 17:10:47 +0800, Su Hui wrote:
> devm_phy_create() return negative error code, 'ret' should be
> 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.
>
>
Applied, thanks!
[1/1] phy: sunplus: return negative error code in sp_usb_phy_probe
commit: 2a9c713825b3127ece11984abf973672c9779518
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe
@ 2023-11-27 13:22 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-11-27 13:22 UTC (permalink / raw)
To: vincent.sunplus, kishon, Su Hui
Cc: linux-usb, linux-phy, linux-kernel, kernel-janitors
On Mon, 20 Nov 2023 17:10:47 +0800, Su Hui wrote:
> devm_phy_create() return negative error code, 'ret' should be
> 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'.
>
>
Applied, thanks!
[1/1] phy: sunplus: return negative error code in sp_usb_phy_probe
commit: 2a9c713825b3127ece11984abf973672c9779518
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-27 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-20 9:10 [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe Su Hui
2023-11-20 9:10 ` Su Hui
2023-11-27 13:22 ` Vinod Koul
2023-11-27 13:22 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.