[igt-dev] [PATCH i-g-t 1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes

[igt-dev] [PATCH i-g-t 1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes

[Rodrigo Vivi]

Aligns with kernel commit ("drm/xe: Change the name of frequency sysfs attributes")

Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/intel/{xe_guc_pc.c => xe_gt_freq.c} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename tests/intel/{xe_guc_pc.c => xe_gt_freq.c} (98%)

diff --git a/tests/intel/xe_guc_pc.c b/tests/intel/xe_gt_freq.c
similarity index 98%
rename from tests/intel/xe_guc_pc.c
rename to tests/intel/xe_gt_freq.c
index 3376e838f..a92833acb 100644
--- a/tests/intel/xe_guc_pc.c
+++ b/tests/intel/xe_gt_freq.c
@@ -37,7 +37,7 @@ static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq)
 	char freq_attr[16];
 	int gt_fd;
 
-	snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name);
+	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
 	gt_fd = xe_sysfs_gt_open(fd, gt_id);
 	igt_assert(gt_fd >= 0);
 
@@ -55,7 +55,7 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
 	char freq_attr[16];
 	int gt_fd;
 
-	snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name);
+	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
 	gt_fd = xe_sysfs_gt_open(fd, gt_id);
 	igt_assert(gt_fd >= 0);
 
-- 
2.43.0

[igt-dev] [PATCH i-g-t 2/3] tests/intel/xe: Align with new xe_gt_freq component

[Rodrigo Vivi]

Aligns with kernel commit ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")

Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: Riana Tauro <riana.tauro@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/intel-ci/xe-fast-feedback.testlist |  6 +++---
 tests/intel/xe_gt_freq.c                 | 16 ++++++++--------
 tests/meson.build                        |  2 +-
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index f48e8fb67..7648ec3f3 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -83,9 +83,9 @@ igt@xe_exec_threads@threads-mixed-fd-basic
 igt@xe_exec_threads@threads-mixed-userptr-invalidate
 igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
 igt@xe_gpgpu_fill@basic
-igt@xe_guc_pc@freq_basic_api
-igt@xe_guc_pc@freq_fixed_idle
-igt@xe_guc_pc@freq_range_idle
+igt@xe_gt_freq@freq_basic_api
+igt@xe_gt_freq@freq_fixed_idle
+igt@xe_gt_freq@freq_range_idle
 igt@xe_huc_copy@huc_copy
 igt@xe_intel_bb@add-remove-objects
 igt@xe_intel_bb@bb-with-allocator
diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
index a92833acb..719852530 100644
--- a/tests/intel/xe_gt_freq.c
+++ b/tests/intel/xe_gt_freq.c
@@ -1,12 +1,12 @@
 // SPDX-License-Identifier: MIT
 /*
- * Copyright © 2022 Intel Corporation
+ * Copyright © 2023 Intel Corporation
  */
 
 /**
- * TEST: Test GuC frequency request functionality
- * Category: Firmware building block
- * Sub-category: GuC
+ * TEST: Test Xe GT frequency request functionality
+ * Category: Infrastructure
+ * Sub-category: frequency
  * Functionality: frequency request
  * Test category: functionality test
  */
@@ -34,10 +34,10 @@
 static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq)
 {
 	int ret = -EAGAIN;
-	char freq_attr[16];
+	char freq_attr[22];
 	int gt_fd;
 
-	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
+	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);
 	gt_fd = xe_sysfs_gt_open(fd, gt_id);
 	igt_assert(gt_fd >= 0);
 
@@ -52,10 +52,10 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
 {
 	uint32_t freq;
 	int err = -EAGAIN;
-	char freq_attr[16];
+	char freq_attr[22];
 	int gt_fd;
 
-	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
+	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);
 	gt_fd = xe_sysfs_gt_open(fd, gt_id);
 	igt_assert(gt_fd >= 0);
 
diff --git a/tests/meson.build b/tests/meson.build
index facf60ccf..f6cfbcf5e 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -293,7 +293,7 @@ intel_xe_progs = [
 	'xe_exec_threads',
 	'xe_exercise_blt',
 	'xe_gpgpu_fill',
-	'xe_guc_pc',
+	'xe_gt_freq',
 	'xe_huc_copy',
 	'xe_intel_bb',
 	'xe_live_ktest',
-- 
2.43.0

[igt-dev] [PATCH i-g-t 3/3] tests/intel/freq: Test throttle basic API infra

[Rodrigo Vivi]

For now we don't have a reliable way to force PCODE throttling,
but let's at least check for some sanity on our exposed API.

Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/intel/xe_gt_freq.c | 48 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
index 719852530..650c54005 100644
--- a/tests/intel/xe_gt_freq.c
+++ b/tests/intel/xe_gt_freq.c
@@ -68,6 +68,49 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
 	return freq;
 }
 
+static uint32_t get_throttle(int fd, int gt_id, const char *throttle_file)
+{
+	uint32_t val;
+	char throttle_attr[40];
+	int gt_fd;
+
+	snprintf(throttle_attr, sizeof(throttle_attr),
+		 "freq0/throttle/%s", throttle_file);
+	gt_fd = xe_sysfs_gt_open(fd, gt_id);
+	igt_assert(gt_fd >= 0);
+
+	igt_sysfs_scanf(gt_fd, throttle_attr, "%u", &val);
+
+	igt_debug("gt%d/freq0/throttle/%s: %u\n", gt_id, throttle_file, val);
+
+	close(gt_fd);
+	return val;
+}
+
+/**
+ * SUBTEST: throttle_basic_api
+ * Description: Test basic throttle API
+ */
+
+static void test_throttle_basic_api(int fd, int gt_id)
+{
+	uint32_t status, reasons;
+
+	status = get_throttle(fd, gt_id, "status");
+	reasons = get_throttle(fd, gt_id, "reason_pl1");
+	reasons |= get_throttle(fd, gt_id, "reason_pl2");
+        reasons |= get_throttle(fd, gt_id, "reason_pl4");
+	reasons |= get_throttle(fd, gt_id, "reason_prochot");
+	reasons |= get_throttle(fd, gt_id, "reason_ratl");
+	reasons |= get_throttle(fd, gt_id, "reason_thermal");
+        reasons |= get_throttle(fd, gt_id, "reason_vr_tdc");
+	reasons |= get_throttle(fd, gt_id, "reason_vr_thermalert");
+
+	if (status)
+		igt_assert(reasons);
+	else
+		igt_assert(!reasons);
+}
 
 /**
  * SUBTEST: freq_basic_api
@@ -289,6 +332,11 @@ igt_main
 		stash_max = get_freq(fd, 0, "max");
 	}
 
+	igt_subtest("throttle_basic_api") {
+		xe_for_each_gt(fd, gt)
+			test_throttle_basic_api(fd, gt);
+	}
+
 	igt_subtest("freq_basic_api") {
 		xe_for_each_gt(fd, gt)
 			test_freq_basic_api(fd, gt);
-- 
2.43.0

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 11490 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes
URL   : https://patchwork.freedesktop.org/series/127392/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13983 -> IGTPW_10346
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10346 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10346, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/index.html

Participating hosts (35 -> 35)
------------------------------

  Additional (2): bat-dg2-8 bat-mtlp-8 
  Missing    (2): bat-adlp-11 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10346:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_psr@psr_cursor_plane_move:
    - bat-mtlp-8:         NOTRUN -> [SKIP][1] +3 other tests skip
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_psr@psr_cursor_plane_move.html

  
Known issues
------------

  Here are the changes found in IGTPW_10346 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - bat-mtlp-8:         NOTRUN -> [ABORT][2] ([i915#8213] / [i915#8668])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@core_hotunplug@unbind-rebind.html
    - bat-dg2-8:          NOTRUN -> [ABORT][3] ([i915#8213])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@core_hotunplug@unbind-rebind.html

  * igt@debugfs_test@basic-hwmon:
    - bat-mtlp-8:         NOTRUN -> [SKIP][4] ([i915#9318])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html

  * igt@gem_mmap@basic:
    - bat-mtlp-8:         NOTRUN -> [SKIP][5] ([i915#4083])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@gem_mmap@basic.html
    - bat-dg2-8:          NOTRUN -> [SKIP][6] ([i915#4083])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@gem_mmap@basic.html

  * igt@gem_mmap_gtt@basic:
    - bat-mtlp-8:         NOTRUN -> [SKIP][7] ([i915#4077]) +2 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@gem_mmap_gtt@basic.html
    - bat-dg2-8:          NOTRUN -> [SKIP][8] ([i915#4077]) +2 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@gem_mmap_gtt@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-mtlp-8:         NOTRUN -> [SKIP][9] ([i915#4079]) +1 other test skip
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_pread_basic:
    - bat-dg2-8:          NOTRUN -> [SKIP][10] ([i915#4079]) +1 other test skip
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-mtlp-8:         NOTRUN -> [SKIP][11] ([i915#6621])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
    - bat-dg2-8:          NOTRUN -> [SKIP][12] ([i915#6621])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@i915_pm_rps@basic-api.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-mtlp-8:         NOTRUN -> [SKIP][13] ([i915#5190])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
    - bat-dg2-8:          NOTRUN -> [SKIP][14] ([i915#5190])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-mtlp-8:         NOTRUN -> [SKIP][15] ([i915#4212]) +8 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
    - bat-dg2-8:          NOTRUN -> [SKIP][16] ([i915#4215] / [i915#5190])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - bat-dg2-8:          NOTRUN -> [SKIP][17] ([i915#4212]) +6 other tests skip
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg2-8:          NOTRUN -> [SKIP][18] ([i915#4212] / [i915#5608])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-mtlp-8:         NOTRUN -> [SKIP][19] ([i915#4213]) +1 other test skip
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-dg2-8:          NOTRUN -> [SKIP][20] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - bat-mtlp-8:         NOTRUN -> [SKIP][21] ([i915#3555] / [i915#3840] / [i915#9159])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-mtlp-8:         NOTRUN -> [SKIP][22] ([fdo#109285])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html
    - bat-dg2-8:          NOTRUN -> [SKIP][23] ([fdo#109285])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-mtlp-8:         NOTRUN -> [SKIP][24] ([i915#5274])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html
    - bat-dg2-8:          NOTRUN -> [SKIP][25] ([i915#5274])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_pm_backlight@basic-brightness:
    - bat-dg2-8:          NOTRUN -> [SKIP][26] ([i915#5354])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_psr@psr_cursor_plane_move:
    - bat-dg2-8:          NOTRUN -> [SKIP][27] ([i915#9673] / [i915#9736]) +3 other tests skip
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_psr@psr_cursor_plane_move.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-mtlp-8:         NOTRUN -> [SKIP][28] ([i915#3555] / [i915#8809])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html
    - bat-dg2-8:          NOTRUN -> [SKIP][29] ([i915#3555])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-dg2-8:          NOTRUN -> [SKIP][30] ([i915#3708])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-fence-mmap:
    - bat-dg2-8:          NOTRUN -> [SKIP][31] ([i915#3708] / [i915#4077]) +1 other test skip
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@prime_vgem@basic-fence-mmap.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][32] ([i915#3708] / [i915#4077]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html

  * igt@prime_vgem@basic-fence-read:
    - bat-mtlp-8:         NOTRUN -> [SKIP][33] ([i915#3708]) +2 other tests skip
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-write:
    - bat-dg2-8:          NOTRUN -> [SKIP][34] ([i915#3291] / [i915#3708]) +2 other tests skip
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/bat-dg2-8/igt@prime_vgem@basic-write.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
  [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
  [i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
  [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
  [i915#9736]: https://gitlab.freedesktop.org/drm/intel/issues/9736


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7622 -> IGTPW_10346

  CI-20190529: 20190529
  CI_DRM_13983: a9d99261a978835b02e248fe18af3026416af3e8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10346: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/index.html
  IGT_7622: 48a47d91b7727215b965690c69d84159c8fb1aa2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@xe_gt_freq@freq_basic_api
+igt@xe_gt_freq@freq_fixed_idle
+igt@xe_gt_freq@freq_low_max
+igt@xe_gt_freq@freq_range_idle
+igt@xe_gt_freq@freq_reset
+igt@xe_gt_freq@freq_reset_multiple
+igt@xe_gt_freq@freq_suspend
+igt@xe_gt_freq@throttle_basic_api
-igt@xe_guc_pc@freq_basic_api
-igt@xe_guc_pc@freq_fixed_idle
-igt@xe_guc_pc@freq_low_max
-igt@xe_guc_pc@freq_range_idle
-igt@xe_guc_pc@freq_reset
-igt@xe_guc_pc@freq_reset_multiple
-igt@xe_guc_pc@freq_suspend

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/index.html

[-- Attachment #2: Type: text/html, Size: 14255 bytes --]

[igt-dev] ✓ CI.xeBAT: success for series starting with [i-g-t,1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2844 bytes --]

== Series Details ==

Series: series starting with [i-g-t,1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes
URL   : https://patchwork.freedesktop.org/series/127392/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7622_BAT -> XEIGTPW_10346_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 2)
------------------------------

  Missing    (2): bat-pvc-2 bat-atsm-2 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in XEIGTPW_10346_BAT:

### IGT changes ###

#### Possible regressions ####

  * {igt@xe_gt_freq@freq_basic_api} (NEW):
    - bat-adlp-7:         NOTRUN -> [FAIL][1] +2 other tests fail
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10346/bat-adlp-7/igt@xe_gt_freq@freq_basic_api.html
    - bat-dg2-oem2:       NOTRUN -> [FAIL][2] +2 other tests fail
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10346/bat-dg2-oem2/igt@xe_gt_freq@freq_basic_api.html

  
New tests
---------

  New tests have been introduced between XEIGT_7622_BAT and XEIGTPW_10346_BAT:

### New IGT tests (3) ###

  * igt@xe_gt_freq@freq_basic_api:
    - Statuses : 2 fail(s)
    - Exec time: [0.0] s

  * igt@xe_gt_freq@freq_fixed_idle:
    - Statuses : 2 fail(s)
    - Exec time: [0.0] s

  * igt@xe_gt_freq@freq_range_idle:
    - Statuses : 2 fail(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in XEIGTPW_10346_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@xe_create@create-execqueues-noleak:
    - bat-adlp-7:         [FAIL][3] ([Intel XE#524]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7622/bat-adlp-7/igt@xe_create@create-execqueues-noleak.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10346/bat-adlp-7/igt@xe_create@create-execqueues-noleak.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524


Build changes
-------------

  * IGT: IGT_7622 -> IGTPW_10346
  * Linux: xe-550-ac7b89571d802765762e7c15d78a6dcd5d92c41b -> xe-551-176c42b6ba690d4c84e37f151e832d5520a38354

  IGTPW_10346: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10346/index.html
  IGT_7622: 48a47d91b7727215b965690c69d84159c8fb1aa2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-550-ac7b89571d802765762e7c15d78a6dcd5d92c41b: ac7b89571d802765762e7c15d78a6dcd5d92c41b
  xe-551-176c42b6ba690d4c84e37f151e832d5520a38354: 176c42b6ba690d4c84e37f151e832d5520a38354

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10346/index.html

[-- Attachment #2: Type: text/html, Size: 3584 bytes --]

Re: [igt-dev] [PATCH i-g-t 1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes

[Sundaresan, Sujaritha]

On 12/6/2023 3:08 AM, Rodrigo Vivi wrote:
> Aligns with kernel commit ("drm/xe: Change the name of frequency sysfs attributes")
>
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   tests/intel/{xe_guc_pc.c => xe_gt_freq.c} | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>   rename tests/intel/{xe_guc_pc.c => xe_gt_freq.c} (98%)
>
> diff --git a/tests/intel/xe_guc_pc.c b/tests/intel/xe_gt_freq.c
> similarity index 98%
> rename from tests/intel/xe_guc_pc.c
> rename to tests/intel/xe_gt_freq.c
> index 3376e838f..a92833acb 100644
> --- a/tests/intel/xe_guc_pc.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -37,7 +37,7 @@ static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq)
>   	char freq_attr[16];
>   	int gt_fd;
>   
> -	snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name);
> +	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
>   	gt_fd = xe_sysfs_gt_open(fd, gt_id);
>   	igt_assert(gt_fd >= 0);
>   
> @@ -55,7 +55,7 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
>   	char freq_attr[16];
>   	int gt_fd;
>   
> -	snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name);
> +	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
>   	gt_fd = xe_sysfs_gt_open(fd, gt_id);
>   	igt_assert(gt_fd >= 0);
>   

This should be good to go in once the kernel changes have been merged.

LGTM.

Reviewed-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>

Re: [igt-dev] [PATCH i-g-t 3/3] tests/intel/freq: Test throttle basic API infra

[Sundaresan, Sujaritha]

On 12/6/2023 3:08 AM, Rodrigo Vivi wrote:
> For now we don't have a reliable way to force PCODE throttling,
> but let's at least check for some sanity on our exposed API.
>
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   tests/intel/xe_gt_freq.c | 48 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
>
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index 719852530..650c54005 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -68,6 +68,49 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
>   	return freq;
>   }
>   
> +static uint32_t get_throttle(int fd, int gt_id, const char *throttle_file)
> +{
> +	uint32_t val;
> +	char throttle_attr[40];
> +	int gt_fd;
> +
> +	snprintf(throttle_attr, sizeof(throttle_attr),
> +		 "freq0/throttle/%s", throttle_file);
> +	gt_fd = xe_sysfs_gt_open(fd, gt_id);
> +	igt_assert(gt_fd >= 0);
> +
> +	igt_sysfs_scanf(gt_fd, throttle_attr, "%u", &val);
> +
> +	igt_debug("gt%d/freq0/throttle/%s: %u\n", gt_id, throttle_file, val);
> +
> +	close(gt_fd);
> +	return val;
> +}
> +
> +/**
> + * SUBTEST: throttle_basic_api
> + * Description: Test basic throttle API
> + */
> +
> +static void test_throttle_basic_api(int fd, int gt_id)
> +{
> +	uint32_t status, reasons;
> +
> +	status = get_throttle(fd, gt_id, "status");
> +	reasons = get_throttle(fd, gt_id, "reason_pl1");
> +	reasons |= get_throttle(fd, gt_id, "reason_pl2");
> +        reasons |= get_throttle(fd, gt_id, "reason_pl4");
> +	reasons |= get_throttle(fd, gt_id, "reason_prochot");
> +	reasons |= get_throttle(fd, gt_id, "reason_ratl");
> +	reasons |= get_throttle(fd, gt_id, "reason_thermal");
> +        reasons |= get_throttle(fd, gt_id, "reason_vr_tdc");
> +	reasons |= get_throttle(fd, gt_id, "reason_vr_thermalert");
> +
> +	if (status)
> +		igt_assert(reasons);
> +	else
> +		igt_assert(!reasons);
> +}

Hi Rodrigo,

Some weird alignment issues above ?

Otherwise LGTM.

Reviewed-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>

>   
>   /**
>    * SUBTEST: freq_basic_api
> @@ -289,6 +332,11 @@ igt_main
>   		stash_max = get_freq(fd, 0, "max");
>   	}
>   
> +	igt_subtest("throttle_basic_api") {
> +		xe_for_each_gt(fd, gt)
> +			test_throttle_basic_api(fd, gt);
> +	}
> +
>   	igt_subtest("freq_basic_api") {
>   		xe_for_each_gt(fd, gt)
>   			test_freq_basic_api(fd, gt);

Re: [igt-dev] [PATCH i-g-t 2/3] tests/intel/xe: Align with new xe_gt_freq component

[Kamil Konieczny]

Hi Rodrigo,
On 2023-12-05 at 16:38:12 -0500, Rodrigo Vivi wrote:
> Aligns with kernel commit ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
> 
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Cc: Riana Tauro <riana.tauro@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/intel-ci/xe-fast-feedback.testlist |  6 +++---
>  tests/intel/xe_gt_freq.c                 | 16 ++++++++--------
>  tests/meson.build                        |  2 +-
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index f48e8fb67..7648ec3f3 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -83,9 +83,9 @@ igt@xe_exec_threads@threads-mixed-fd-basic
>  igt@xe_exec_threads@threads-mixed-userptr-invalidate
>  igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
>  igt@xe_gpgpu_fill@basic
> -igt@xe_guc_pc@freq_basic_api
> -igt@xe_guc_pc@freq_fixed_idle
> -igt@xe_guc_pc@freq_range_idle
> +igt@xe_gt_freq@freq_basic_api
> +igt@xe_gt_freq@freq_fixed_idle
> +igt@xe_gt_freq@freq_range_idle
>  igt@xe_huc_copy@huc_copy
>  igt@xe_intel_bb@add-remove-objects
>  igt@xe_intel_bb@bb-with-allocator
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index a92833acb..719852530 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -1,12 +1,12 @@
>  // SPDX-License-Identifier: MIT
>  /*
> - * Copyright © 2022 Intel Corporation
> + * Copyright © 2023 Intel Corporation
---------------------^
Please just add new year after 2022, for example:

 * Copyright © 2022,2023 Intel Corporation

>   */
>  
>  /**
> - * TEST: Test GuC frequency request functionality
> - * Category: Firmware building block
> - * Sub-category: GuC
> + * TEST: Test Xe GT frequency request functionality
> + * Category: Infrastructure
> + * Sub-category: frequency
>   * Functionality: frequency request
>   * Test category: functionality test
>   */
> @@ -34,10 +34,10 @@
>  static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq)
>  {
>  	int ret = -EAGAIN;
> -	char freq_attr[16];
> +	char freq_attr[22];
------------------ ^^
Why not define it and use in all places?

>  	int gt_fd;
>  
> -	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
> +	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);
--- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
See below.

>  	gt_fd = xe_sysfs_gt_open(fd, gt_id);
>  	igt_assert(gt_fd >= 0);
>  
> @@ -52,10 +52,10 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
>  {
>  	uint32_t freq;
>  	int err = -EAGAIN;
> -	char freq_attr[16];
> +	char freq_attr[22];
>  	int gt_fd;
>  
> -	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
> +	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);

This is duplicated code, it can be written in one function,
may be left to follow up.

With above copyright fixed:
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Regards,
Kamil

>  	gt_fd = xe_sysfs_gt_open(fd, gt_id);
>  	igt_assert(gt_fd >= 0);
>  
> diff --git a/tests/meson.build b/tests/meson.build
> index facf60ccf..f6cfbcf5e 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -293,7 +293,7 @@ intel_xe_progs = [
>  	'xe_exec_threads',
>  	'xe_exercise_blt',
>  	'xe_gpgpu_fill',
> -	'xe_guc_pc',
> +	'xe_gt_freq',
>  	'xe_huc_copy',
>  	'xe_intel_bb',
>  	'xe_live_ktest',
> -- 
> 2.43.0
> 

Re: [igt-dev] [PATCH i-g-t 2/3] tests/intel/xe: Align with new xe_gt_freq component

[Rodrigo Vivi]

On Wed, Dec 06, 2023 at 01:45:44PM +0100, Kamil Konieczny wrote:
> Hi Rodrigo,
> On 2023-12-05 at 16:38:12 -0500, Rodrigo Vivi wrote:
> > Aligns with kernel commit ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
> > 
> > Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> > Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> > Cc: Riana Tauro <riana.tauro@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  tests/intel-ci/xe-fast-feedback.testlist |  6 +++---
> >  tests/intel/xe_gt_freq.c                 | 16 ++++++++--------
> >  tests/meson.build                        |  2 +-
> >  3 files changed, 12 insertions(+), 12 deletions(-)
> > 
> > diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> > index f48e8fb67..7648ec3f3 100644
> > --- a/tests/intel-ci/xe-fast-feedback.testlist
> > +++ b/tests/intel-ci/xe-fast-feedback.testlist
> > @@ -83,9 +83,9 @@ igt@xe_exec_threads@threads-mixed-fd-basic
> >  igt@xe_exec_threads@threads-mixed-userptr-invalidate
> >  igt@xe_exec_threads@threads-mixed-shared-vm-userptr-invalidate-race
> >  igt@xe_gpgpu_fill@basic
> > -igt@xe_guc_pc@freq_basic_api
> > -igt@xe_guc_pc@freq_fixed_idle
> > -igt@xe_guc_pc@freq_range_idle
> > +igt@xe_gt_freq@freq_basic_api
> > +igt@xe_gt_freq@freq_fixed_idle
> > +igt@xe_gt_freq@freq_range_idle
> >  igt@xe_huc_copy@huc_copy
> >  igt@xe_intel_bb@add-remove-objects
> >  igt@xe_intel_bb@bb-with-allocator
> > diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> > index a92833acb..719852530 100644
> > --- a/tests/intel/xe_gt_freq.c
> > +++ b/tests/intel/xe_gt_freq.c
> > @@ -1,12 +1,12 @@
> >  // SPDX-License-Identifier: MIT
> >  /*
> > - * Copyright © 2022 Intel Corporation
> > + * Copyright © 2023 Intel Corporation
> ---------------------^
> Please just add new year after 2022, for example:
> 
>  * Copyright © 2022,2023 Intel Corporation
> 
> >   */
> >  
> >  /**
> > - * TEST: Test GuC frequency request functionality
> > - * Category: Firmware building block
> > - * Sub-category: GuC
> > + * TEST: Test Xe GT frequency request functionality
> > + * Category: Infrastructure
> > + * Sub-category: frequency
> >   * Functionality: frequency request
> >   * Test category: functionality test
> >   */
> > @@ -34,10 +34,10 @@
> >  static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq)
> >  {
> >  	int ret = -EAGAIN;
> > -	char freq_attr[16];
> > +	char freq_attr[22];
> ------------------ ^^
> Why not define it and use in all places?
> 
> >  	int gt_fd;
> >  
> > -	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
> > +	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);
> --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> See below.
> 
> >  	gt_fd = xe_sysfs_gt_open(fd, gt_id);
> >  	igt_assert(gt_fd >= 0);
> >  
> > @@ -52,10 +52,10 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name)
> >  {
> >  	uint32_t freq;
> >  	int err = -EAGAIN;
> > -	char freq_attr[16];
> > +	char freq_attr[22];
> >  	int gt_fd;
> >  
> > -	snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name);
> > +	snprintf(freq_attr, sizeof(freq_attr), "freq0/%s_freq", freq_name);
> 
> This is duplicated code, it can be written in one function,
> may be left to follow up.

I had already thought about that, but both igt_printf in set and igt_scanf in get
also use the freq_attr.

Maybe we could remove the open/close on our side and rely solo and directly
on the sysfs helpers? but then we miss our asserts...

> 
> With above copyright fixed:
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Fixed, thank you!

> 
> Regards,
> Kamil
> 
> >  	gt_fd = xe_sysfs_gt_open(fd, gt_id);
> >  	igt_assert(gt_fd >= 0);
> >  
> > diff --git a/tests/meson.build b/tests/meson.build
> > index facf60ccf..f6cfbcf5e 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -293,7 +293,7 @@ intel_xe_progs = [
> >  	'xe_exec_threads',
> >  	'xe_exercise_blt',
> >  	'xe_gpgpu_fill',
> > -	'xe_guc_pc',
> > +	'xe_gt_freq',
> >  	'xe_huc_copy',
> >  	'xe_intel_bb',
> >  	'xe_live_ktest',
> > -- 
> > 2.43.0
> >