* [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt
@ 2023-12-18 7:06 ` Lai Peter Jun Ann
0 siblings, 0 replies; 4+ messages in thread
From: Lai Peter Jun Ann @ 2023-12-18 7:06 UTC (permalink / raw)
To: Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Song Yoong Siang, Lai Peter Jun Ann
The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN
flag is set.
Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
index 540f6a4..f05bd75 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
@@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv)
*/
ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS);
- if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)
+ if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN))
return;
num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt
@ 2023-12-18 7:06 ` Lai Peter Jun Ann
0 siblings, 0 replies; 4+ messages in thread
From: Lai Peter Jun Ann @ 2023-12-18 7:06 UTC (permalink / raw)
To: Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Maxime Coquelin
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel,
Song Yoong Siang, Lai Peter Jun Ann
The driver should continue get the timestamp if STMMAC_FLAG_EXT_SNAPSHOT_EN
flag is set.
Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
index 540f6a4..f05bd75 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
@@ -237,7 +237,7 @@ static void timestamp_interrupt(struct stmmac_priv *priv)
*/
ts_status = readl(priv->ioaddr + GMAC_TIMESTAMP_STATUS);
- if (priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN)
+ if (!(priv->plat->flags & STMMAC_FLAG_EXT_SNAPSHOT_EN))
return;
num_snapshot = (ts_status & GMAC_TIMESTAMP_ATSNS_MASK) >>
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt
2023-12-18 7:06 ` Lai Peter Jun Ann
@ 2023-12-18 11:39 ` Suman Ghosh
-1 siblings, 0 replies; 4+ messages in thread
From: Suman Ghosh @ 2023-12-18 11:39 UTC (permalink / raw)
To: Lai Peter Jun Ann, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, Song Yoong Siang
>----------------------------------------------------------------------
>The driver should continue get the timestamp if
>STMMAC_FLAG_EXT_SNAPSHOT_EN flag is set.
>
[Suman] Hi Lai,
Please ad the "fixes" tag
>Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
>Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt
@ 2023-12-18 11:39 ` Suman Ghosh
0 siblings, 0 replies; 4+ messages in thread
From: Suman Ghosh @ 2023-12-18 11:39 UTC (permalink / raw)
To: Lai Peter Jun Ann, Alexandre Torgue, Jose Abreu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin
Cc: netdev, linux-stm32, linux-arm-kernel, linux-kernel, Song Yoong Siang
>----------------------------------------------------------------------
>The driver should continue get the timestamp if
>STMMAC_FLAG_EXT_SNAPSHOT_EN flag is set.
>
[Suman] Hi Lai,
Please ad the "fixes" tag
>Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
>Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-18 11:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-18 7:06 [PATCH net 1/1] net: stmmac: fix incorrect flag check in timestamp interrupt Lai Peter Jun Ann
2023-12-18 7:06 ` Lai Peter Jun Ann
2023-12-18 11:39 ` [EXT] " Suman Ghosh
2023-12-18 11:39 ` Suman Ghosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.