* [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
@ 2024-01-26 8:41 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2024-01-26 8:41 UTC (permalink / raw)
To: Zhi Wang
Cc: Zhenyu Wang, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, intel-gvt-dev,
intel-gfx, dri-devel, linux-kernel, kernel-janitors
This code prints the wrong variable in the warning message. It should
print "i" instead of "info->offset". On the first iteration "info" is
uninitialized leading to a crash and on subsequent iterations it prints
the previous offset instead of the current one.
Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 90f6c1ece57d..efcb00472be2 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
for (i = start; i < end; i += 4) {
p = intel_gvt_find_mmio_info(gvt, i);
if (p) {
- WARN(1, "dup mmio definition offset %x\n",
- info->offset);
+ WARN(1, "dup mmio definition offset %x\n", i);
/* We return -EEXIST here to make GVT-g load fail.
* So duplicated MMIO can be found as soon as
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
@ 2024-01-26 8:41 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2024-01-26 8:41 UTC (permalink / raw)
To: Zhi Wang
Cc: Tvrtko Ursulin, dri-devel, intel-gvt-dev, intel-gfx,
kernel-janitors, linux-kernel, Daniel Vetter, Rodrigo Vivi,
David Airlie
This code prints the wrong variable in the warning message. It should
print "i" instead of "info->offset". On the first iteration "info" is
uninitialized leading to a crash and on subsequent iterations it prints
the previous offset instead of the current one.
Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 90f6c1ece57d..efcb00472be2 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
for (i = start; i < end; i += 4) {
p = intel_gvt_find_mmio_info(gvt, i);
if (p) {
- WARN(1, "dup mmio definition offset %x\n",
- info->offset);
+ WARN(1, "dup mmio definition offset %x\n", i);
/* We return -EEXIST here to make GVT-g load fail.
* So duplicated MMIO can be found as soon as
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
@ 2024-01-26 8:41 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2024-01-26 8:41 UTC (permalink / raw)
To: Zhi Wang
Cc: dri-devel, intel-gvt-dev, intel-gfx, kernel-janitors,
linux-kernel, Daniel Vetter, Rodrigo Vivi, David Airlie
This code prints the wrong variable in the warning message. It should
print "i" instead of "info->offset". On the first iteration "info" is
uninitialized leading to a crash and on subsequent iterations it prints
the previous offset instead of the current one.
Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 90f6c1ece57d..efcb00472be2 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
for (i = start; i < end; i += 4) {
p = intel_gvt_find_mmio_info(gvt, i);
if (p) {
- WARN(1, "dup mmio definition offset %x\n",
- info->offset);
+ WARN(1, "dup mmio definition offset %x\n", i);
/* We return -EEXIST here to make GVT-g load fail.
* So duplicated MMIO can be found as soon as
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix uninitialized variable in handle_mmio()
2024-01-26 8:41 ` Dan Carpenter
(?)
(?)
@ 2024-01-26 9:34 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2024-01-26 9:34 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]
== Series Details ==
Series: drm/i915/gvt: Fix uninitialized variable in handle_mmio()
URL : https://patchwork.freedesktop.org/series/129190/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14180 -> Patchwork_129190v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_129190v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_129190v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129190v1/index.html
Participating hosts (36 -> 33)
------------------------------
Missing (3): fi-skl-guc fi-snb-2520m fi-pnv-d510
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_129190v1:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@basic-flip-vs-dpms@d-edp1:
- bat-adlp-6: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14180/bat-adlp-6/igt@kms_flip@basic-flip-vs-dpms@d-edp1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129190v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-dpms@d-edp1.html
Known issues
------------
Here are the changes found in Patchwork_129190v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][3] -> [DMESG-FAIL][4] ([i915#10010])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14180/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129190v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][5] ([i915#9197]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129190v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
[i915#10010]: https://gitlab.freedesktop.org/drm/intel/issues/10010
[i915#9197]: https://gitlab.freedesktop.org/drm/intel/issues/9197
Build changes
-------------
* Linux: CI_DRM_14180 -> Patchwork_129190v1
CI-20190529: 20190529
CI_DRM_14180: 246d92693aa04ab89430fc3b028ed9b0b7e8a0c8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7692: 5d9c29c620701497323bf3721146da57efa50952 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_129190v1: 246d92693aa04ab89430fc3b028ed9b0b7e8a0c8 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
c0fb87b248d9 drm/i915/gvt: Fix uninitialized variable in handle_mmio()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129190v1/index.html
[-- Attachment #2: Type: text/html, Size: 3607 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
2024-01-26 8:41 ` Dan Carpenter
(?)
@ 2024-01-29 3:37 ` Zhenyu Wang
-1 siblings, 0 replies; 7+ messages in thread
From: Zhenyu Wang @ 2024-01-29 3:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, intel-gvt-dev, intel-gfx, dri-devel,
linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On 2024.01.26 11:41:47 +0300, Dan Carpenter wrote:
> This code prints the wrong variable in the warning message. It should
> print "i" instead of "info->offset". On the first iteration "info" is
> uninitialized leading to a crash and on subsequent iterations it prints
> the previous offset instead of the current one.
>
> Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 90f6c1ece57d..efcb00472be2 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
> for (i = start; i < end; i += 4) {
> p = intel_gvt_find_mmio_info(gvt, i);
> if (p) {
> - WARN(1, "dup mmio definition offset %x\n",
> - info->offset);
> + WARN(1, "dup mmio definition offset %x\n", i);
>
> /* We return -EEXIST here to make GVT-g load fail.
> * So duplicated MMIO can be found as soon as
> --
> 2.43.0
>
Thanks for the fix.
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
@ 2024-01-29 3:37 ` Zhenyu Wang
0 siblings, 0 replies; 7+ messages in thread
From: Zhenyu Wang @ 2024-01-29 3:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tvrtko Ursulin, intel-gvt-dev, intel-gfx, kernel-janitors,
linux-kernel, dri-devel, Daniel Vetter, Rodrigo Vivi,
David Airlie
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On 2024.01.26 11:41:47 +0300, Dan Carpenter wrote:
> This code prints the wrong variable in the warning message. It should
> print "i" instead of "info->offset". On the first iteration "info" is
> uninitialized leading to a crash and on subsequent iterations it prints
> the previous offset instead of the current one.
>
> Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 90f6c1ece57d..efcb00472be2 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
> for (i = start; i < end; i += 4) {
> p = intel_gvt_find_mmio_info(gvt, i);
> if (p) {
> - WARN(1, "dup mmio definition offset %x\n",
> - info->offset);
> + WARN(1, "dup mmio definition offset %x\n", i);
>
> /* We return -EEXIST here to make GVT-g load fail.
> * So duplicated MMIO can be found as soon as
> --
> 2.43.0
>
Thanks for the fix.
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio()
@ 2024-01-29 3:37 ` Zhenyu Wang
0 siblings, 0 replies; 7+ messages in thread
From: Zhenyu Wang @ 2024-01-29 3:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: intel-gvt-dev, intel-gfx, kernel-janitors, linux-kernel,
dri-devel, Daniel Vetter, Rodrigo Vivi, David Airlie
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
On 2024.01.26 11:41:47 +0300, Dan Carpenter wrote:
> This code prints the wrong variable in the warning message. It should
> print "i" instead of "info->offset". On the first iteration "info" is
> uninitialized leading to a crash and on subsequent iterations it prints
> the previous offset instead of the current one.
>
> Fixes: e0f74ed4634d ("i915/gvt: Separate the MMIO tracking table from GVT-g")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/i915/gvt/handlers.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 90f6c1ece57d..efcb00472be2 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -2849,8 +2849,7 @@ static int handle_mmio(struct intel_gvt_mmio_table_iter *iter, u32 offset,
> for (i = start; i < end; i += 4) {
> p = intel_gvt_find_mmio_info(gvt, i);
> if (p) {
> - WARN(1, "dup mmio definition offset %x\n",
> - info->offset);
> + WARN(1, "dup mmio definition offset %x\n", i);
>
> /* We return -EEXIST here to make GVT-g load fail.
> * So duplicated MMIO can be found as soon as
> --
> 2.43.0
>
Thanks for the fix.
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-29 3:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-26 8:41 [PATCH] drm/i915/gvt: Fix uninitialized variable in handle_mmio() Dan Carpenter
2024-01-26 8:41 ` Dan Carpenter
2024-01-26 8:41 ` Dan Carpenter
2024-01-26 9:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-01-29 3:37 ` [PATCH] " Zhenyu Wang
2024-01-29 3:37 ` Zhenyu Wang
2024-01-29 3:37 ` Zhenyu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.