* [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
@ 2024-01-30 9:22 Kunwu Chan
2024-01-30 10:05 ` Jiri Pirko
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kunwu Chan @ 2024-01-30 9:22 UTC (permalink / raw)
To: davem, dsahern, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel, Kunwu Chan
commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
introduces a new macro.
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
net/ipv4/inetpeer.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index e9fed83e9b3c..5bd759963451 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -81,10 +81,7 @@ void __init inet_initpeers(void)
inet_peer_threshold = clamp_val(nr_entries, 4096, 65536 + 128);
- peer_cachep = kmem_cache_create("inet_peer_cache",
- sizeof(struct inet_peer),
- 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC,
- NULL);
+ peer_cachep = KMEM_CACHE(inet_peer, SLAB_HWCACHE_ALIGN | SLAB_PANIC);
}
/* Called with rcu_read_lock() or base->lock held */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
2024-01-30 9:22 [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers Kunwu Chan
@ 2024-01-30 10:05 ` Jiri Pirko
2024-01-31 7:56 ` Kunwu Chan
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Pirko @ 2024-01-30 10:05 UTC (permalink / raw)
To: Kunwu Chan; +Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel
Tue, Jan 30, 2024 at 10:22:55AM CET, chentao@kylinos.cn wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>---
> net/ipv4/inetpeer.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
>index e9fed83e9b3c..5bd759963451 100644
>--- a/net/ipv4/inetpeer.c
>+++ b/net/ipv4/inetpeer.c
>@@ -81,10 +81,7 @@ void __init inet_initpeers(void)
>
> inet_peer_threshold = clamp_val(nr_entries, 4096, 65536 + 128);
>
>- peer_cachep = kmem_cache_create("inet_peer_cache",
>- sizeof(struct inet_peer),
>- 0, SLAB_HWCACHE_ALIGN | SLAB_PANIC,
>- NULL);
>+ peer_cachep = KMEM_CACHE(inet_peer, SLAB_HWCACHE_ALIGN | SLAB_PANIC);
The name is going to be different. Could it be a source of some issue?
My guess is not, just want to make sure.
> }
>
> /* Called with rcu_read_lock() or base->lock held */
>--
>2.39.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
2024-01-30 9:22 [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers Kunwu Chan
2024-01-30 10:05 ` Jiri Pirko
@ 2024-01-31 7:56 ` Kunwu Chan
2024-01-31 9:26 ` Jiri Pirko
2024-02-01 0:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Kunwu Chan @ 2024-01-31 7:56 UTC (permalink / raw)
To: jiri; +Cc: netdev, linux-kernel, davem, dsahern, edumazet, kuba, pabeni
Thanks for your reply.
As the code say, the name is only for human beings and to identify a
cache, so it's ok.
"A string which is used in /proc/slabinfo to identify this cache."
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
2024-01-30 9:22 [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers Kunwu Chan
2024-01-30 10:05 ` Jiri Pirko
2024-01-31 7:56 ` Kunwu Chan
@ 2024-01-31 9:26 ` Jiri Pirko
2024-02-01 0:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Pirko @ 2024-01-31 9:26 UTC (permalink / raw)
To: Kunwu Chan; +Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel
Tue, Jan 30, 2024 at 10:22:55AM CET, chentao@kylinos.cn wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
2024-01-30 9:22 [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers Kunwu Chan
` (2 preceding siblings ...)
2024-01-31 9:26 ` Jiri Pirko
@ 2024-02-01 0:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-01 0:50 UTC (permalink / raw)
To: Kunwu Chan; +Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 30 Jan 2024 17:22:55 +0800 you wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>
> [...]
Here is the summary with links:
- [net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers
https://git.kernel.org/netdev/net-next/c/57f2c6350f2d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-01 0:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30 9:22 [PATCH net-next] net: ipv4: Simplify the allocation of slab caches in inet_initpeers Kunwu Chan
2024-01-30 10:05 ` Jiri Pirko
2024-01-31 7:56 ` Kunwu Chan
2024-01-31 9:26 ` Jiri Pirko
2024-02-01 0:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.