* [PATCH rdma-next] RDMA/irdma: Remove duplicate assignment
@ 2024-01-31 23:39 Sindhu Devale
2024-02-04 9:38 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Sindhu Devale @ 2024-01-31 23:39 UTC (permalink / raw)
To: jgg, leon; +Cc: linux-rdma, sindhu.devale, Mustafa Ismail
From: Mustafa Ismail <mustafa.ismail@intel.com>
Remove the unneeded assignment of the qp_num which is already
set in irdma_create_qp().
Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Sindhu Devale <sindhu.devale@intel.com>
---
drivers/infiniband/hw/irdma/verbs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index b5eb8d421988..44b03bc061fa 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -719,7 +719,6 @@ static int irdma_setup_kmode_qp(struct irdma_device *iwdev,
info->rq_pa + (ukinfo->rq_depth * IRDMA_QP_WQE_MIN_SIZE);
ukinfo->sq_size = ukinfo->sq_depth >> ukinfo->sq_shift;
ukinfo->rq_size = ukinfo->rq_depth >> ukinfo->rq_shift;
- ukinfo->qp_id = iwqp->ibqp.qp_num;
iwqp->max_send_wr = (ukinfo->sq_depth - IRDMA_SQ_RSVD) >> ukinfo->sq_shift;
iwqp->max_recv_wr = (ukinfo->rq_depth - IRDMA_RQ_RSVD) >> ukinfo->rq_shift;
@@ -942,7 +941,7 @@ static int irdma_create_qp(struct ib_qp *ibqp,
iwqp->host_ctx.size = IRDMA_QP_CTX_SIZE;
init_info.pd = &iwpd->sc_pd;
- init_info.qp_uk_init_info.qp_id = iwqp->ibqp.qp_num;
+ init_info.qp_uk_init_info.qp_id = qp_num;
if (!rdma_protocol_roce(&iwdev->ibdev, 1))
init_info.qp_uk_init_info.first_sq_wq = 1;
iwqp->ctx_info.qp_compl_ctx = (uintptr_t)qp;
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-next] RDMA/irdma: Remove duplicate assignment
2024-01-31 23:39 [PATCH rdma-next] RDMA/irdma: Remove duplicate assignment Sindhu Devale
@ 2024-02-04 9:38 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2024-02-04 9:38 UTC (permalink / raw)
To: Jason Gunthorpe, Sindhu Devale; +Cc: linux-rdma, Mustafa Ismail
On Wed, 31 Jan 2024 17:39:53 -0600, Sindhu Devale wrote:
> Remove the unneeded assignment of the qp_num which is already
> set in irdma_create_qp().
>
>
Applied, thanks!
[1/1] RDMA/irdma: Remove duplicate assignment
https://git.kernel.org/rdma/rdma/c/926e8ea4b8dac8
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-04 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 23:39 [PATCH rdma-next] RDMA/irdma: Remove duplicate assignment Sindhu Devale
2024-02-04 9:38 ` Leon Romanovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.