All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/32: fix ADB_CUDA kconfig warning
@ 2024-02-11 22:16 Randy Dunlap
  2024-03-13 13:19 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2024-02-11 22:16 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, Yuan Tan

From: Michael Ellerman <mpe@ellerman.id.au>

Fix a (randconfig) kconfig warning by correcting the select
statement:

WARNING: unmet direct dependencies detected for ADB_CUDA
  Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
  Selected by [y]:
  - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]

The PPC32 isn't needed because ADB depends on (PPC_PMAC && PPC32).

Fixes: a3ef2fef198c ("powerpc/32: Add dependencies of POWER_RESET for pmac32")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Tested: Randy Dunlap <rdunlap@infradead.org>
Cc: Yuan Tan <tanyuan@tinylab.org>
---
 arch/powerpc/platforms/powermac/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
--- a/arch/powerpc/platforms/powermac/Kconfig
+++ b/arch/powerpc/platforms/powermac/Kconfig
@@ -2,7 +2,7 @@
 config PPC_PMAC
 	bool "Apple PowerMac based machines"
 	depends on PPC_BOOK3S && CPU_BIG_ENDIAN
-	select ADB_CUDA if POWER_RESET && PPC32
+	select ADB_CUDA if POWER_RESET && ADB
 	select MPIC
 	select FORCE_PCI
 	select PPC_INDIRECT_PCI if PPC32

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/32: fix ADB_CUDA kconfig warning
  2024-02-11 22:16 [PATCH] powerpc/32: fix ADB_CUDA kconfig warning Randy Dunlap
@ 2024-03-13 13:19 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2024-03-13 13:19 UTC (permalink / raw)
  To: linux-kernel, Randy Dunlap; +Cc: Yuan Tan

On Sun, 11 Feb 2024 14:16:23 -0800, Randy Dunlap wrote:
> Fix a (randconfig) kconfig warning by correcting the select
> statement:
> 
> WARNING: unmet direct dependencies detected for ADB_CUDA
>   Depends on [n]: MACINTOSH_DRIVERS [=n] && (ADB [=n] || PPC_PMAC [=y]) && !PPC_PMAC64 [=n]
>   Selected by [y]:
>   - PPC_PMAC [=y] && PPC_BOOK3S [=y] && CPU_BIG_ENDIAN [=y] && POWER_RESET [=y] && PPC32 [=y]
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/32: fix ADB_CUDA kconfig warning
      https://git.kernel.org/powerpc/c/b72c066ba85a131091498a15a62d6068997278a4

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-13 13:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-11 22:16 [PATCH] powerpc/32: fix ADB_CUDA kconfig warning Randy Dunlap
2024-03-13 13:19 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.