All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix bo leak in intel_fb_bo_framebuffer_init
@ 2024-03-21 14:56 Maarten Lankhorst
  2024-03-21 16:13 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Maarten Lankhorst @ 2024-03-21 14:56 UTC (permalink / raw)
  To: intel-xe; +Cc: Maarten Lankhorst, stable

Add a reference to bo after all error paths, to prevent leaking a bo
ref.

Return 0 to clarify that this is the success path.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Cc: <stable@vger.kernel.org> # v6.8+
---
 drivers/gpu/drm/xe/display/intel_fb_bo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/intel_fb_bo.c b/drivers/gpu/drm/xe/display/intel_fb_bo.c
index b21da7b745a5..7262bbca9baf 100644
--- a/drivers/gpu/drm/xe/display/intel_fb_bo.c
+++ b/drivers/gpu/drm/xe/display/intel_fb_bo.c
@@ -27,8 +27,6 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
 	struct drm_i915_private *i915 = to_i915(bo->ttm.base.dev);
 	int ret;
 
-	xe_bo_get(bo);
-
 	ret = ttm_bo_reserve(&bo->ttm, true, false, NULL);
 	if (ret)
 		return ret;
@@ -48,7 +46,8 @@ int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
 	}
 	ttm_bo_unreserve(&bo->ttm);
 
-	return ret;
+	xe_bo_get(bo);
+	return 0;
 }
 
 struct xe_bo *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-03-22 16:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-21 14:56 [PATCH] drm/xe: Fix bo leak in intel_fb_bo_framebuffer_init Maarten Lankhorst
2024-03-21 16:13 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-21 16:14 ` ✓ CI.checkpatch: " Patchwork
2024-03-21 16:14 ` ✓ CI.KUnit: " Patchwork
2024-03-21 16:25 ` ✓ CI.Build: " Patchwork
2024-03-21 16:28 ` ✓ CI.Hooks: " Patchwork
2024-03-21 16:29 ` ✓ CI.checksparse: " Patchwork
2024-03-21 16:57 ` ✓ CI.BAT: " Patchwork
2024-03-21 19:56 ` [PATCH] " Rodrigo Vivi
2024-03-22 16:16   ` Lucas De Marchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.