All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND] ASoC: amd: simplify soundwire dependencies for legacy stack
@ 2024-03-22 11:20 Vijendar Mukunda
  2024-03-25 17:44 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Vijendar Mukunda @ 2024-03-22 11:20 UTC (permalink / raw)
  To: broonie
  Cc: alsa-devel, venkataprasad.potturu, Basavaraj.Hiregoudar,
	Sunil-kumar.Dommati, arnd, Vijendar Mukunda, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Cristian Ciocaltea,
	Syed Saba Kareem,
	open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never
selected by another driver.
So replace the extra complexity with a normal Kconfig dependency in
SND_SOC_AMD_SOUNDWIRE.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index fa74635cee08..3508f5a96b75 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -134,15 +134,14 @@ config SND_SOC_AMD_RPL_ACP6x
 
 config SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
 	tristate
-	select SOUNDWIRE_AMD if SND_SOC_AMD_SOUNDWIRE != n
 	select SND_AMD_SOUNDWIRE_ACPI if ACPI
 
 config SND_SOC_AMD_SOUNDWIRE
 	tristate "Support for SoundWire based AMD platforms"
 	default SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
 	depends on SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
-	depends on ACPI && SOUNDWIRE
-	depends on !(SOUNDWIRE=m && SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE=y)
+	depends on ACPI
+	depends on SOUNDWIRE_AMD
 	help
 	  This adds support for SoundWire for AMD platforms.
 	  Say Y if you want to enable SoundWire links with SOF.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RESEND] ASoC: amd: simplify soundwire dependencies for legacy stack
  2024-03-22 11:20 [RESEND] ASoC: amd: simplify soundwire dependencies for legacy stack Vijendar Mukunda
@ 2024-03-25 17:44 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2024-03-25 17:44 UTC (permalink / raw)
  To: Vijendar Mukunda
  Cc: alsa-devel, venkataprasad.potturu, Basavaraj.Hiregoudar,
	Sunil-kumar.Dommati, arnd, Liam Girdwood, Jaroslav Kysela,
	Takashi Iwai, Cristian Ciocaltea, Syed Saba Kareem,
	open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

On Fri, 22 Mar 2024 16:50:15 +0530, Vijendar Mukunda wrote:
> The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never
> selected by another driver.
> So replace the extra complexity with a normal Kconfig dependency in
> SND_SOC_AMD_SOUNDWIRE.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: simplify soundwire dependencies for legacy stack
      commit: a806793f231e390510343837668d8f0eade75a72

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-25 17:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-22 11:20 [RESEND] ASoC: amd: simplify soundwire dependencies for legacy stack Vijendar Mukunda
2024-03-25 17:44 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.